Re: [PATCH 4/7] tracing/function: Introduce persistent trace option

On Wed, Jun 27, 2012 at 08:40:12AM -0400, Steven Rostedt wrote:

On Tue, 2012-06-26 at 16:23 -0700, Anton Vorontsov wrote:

...

@@ -219,6 +232,8 @@ static int func_set_flag(u32 old_flags, u32 bit, int set) return 0; }

• if (bit == TRACE_FUNC_OPT_PSTORE)

• return 0;
  

Perhaps this should be a switch() statement, or at least put a } else if () {

As it can't be bit == TRACE_FUNC_OPT_STACK and bit == TRACE_FUNC_OPT_PSTORE.

Yup, thanks for the idea. I'll start using 'else if' at first, and then will convert it to a switch statement via a separate patch, that way I'll not clobber the functional patch with cosmetic changes.

Thanks,