On Friday 11 September 2015 14:36:06 Viresh Kumar wrote:
debugfs_create_bool() declares the pointer to be of type u32 *. Shouldn't that be changed to u8 *? There are many users which are typecasting the variables to make debugfs API happy
I'd say that the argument to debugfs_create_bool() has to match the access in the functions you are modifying, as well as whatever gets passed into it by callers.
By accessing only the first byte, you break all drivers that call debugfs_create_bool() with a four-byte argument, at least on big-endian systems!
If we change any part of this, we need to audit the existing 31 callers of the function and change them all to use a bool type.
In the problem that you saw, what prevented gcc from printing a compile-time warning about debugfs_create_bool() being called with a bool argument?
Arnd