Failure after v6.1-rc1-158-ga2c896ab66f2: staging: wlan-ng: Remove unused struct wlan_ie_ibss_parms references:
Results changed to -10 # build_abe binutils: -9 # build_abe stage1: -5 # build_abe qemu: -2 # linux_n_obj: 31874 # linux build successful: all # First few build errors in logs:
from -10 # build_abe binutils: -9 # build_abe stage1: -5 # build_abe qemu: -2 # linux_n_obj: 31874 # linux build successful: all # linux boot successful: boot
THIS IS THE END OF INTERESTING STUFF. BELOW ARE LINKS TO BUILDS, REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT.
For latest status see comments in https://linaro.atlassian.net/browse/GNU-681 . Status of v6.1-rc1-158-ga2c896ab66f2 commit for tcwg_kernel: commit a2c896ab66f2c65cf6eeba140b97200a47d0450e Author: Deepak R Varma drv@mailo.com Date: Tue Nov 1 19:19:30 2022 +0530
staging: wlan-ng: Remove unused struct wlan_ie_ibss_parms references
Pointer reference to struct wlan_ie_ibss_parms is added as a member variable to 2 structures; However, these references are never used. Remove such unused struct references. The cleanup also renders the struct useless; so remove it as well. Issue identified as part of coccicheck based code analysis.
Suggested-by: Dan Carpenter dan.carpenter@oracle.com Suggested-by: Pavel Skripkin paskripkin@gmail.com Signed-off-by: Deepak R Varma drv@mailo.com Link: https://lore.kernel.org/r/e53084cdd3ca3ffea6a32393f6f28c7b7650d1a4.166730882... Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org * gnu-release-arm-next-allmodconfig ** Failure after v6.1-rc1-158-ga2c896ab66f2: staging: wlan-ng: Remove unused struct wlan_ie_ibss_parms references: ** https://ci.linaro.org/job/tcwg_kernel-gnu-build-gnu-release-arm-next-allmodc...
Bad build: https://ci.linaro.org/job/tcwg_kernel-gnu-build-gnu-release-arm-next-allmodc... Good build: https://ci.linaro.org/job/tcwg_kernel-gnu-build-gnu-release-arm-next-allmodc...
Reproduce current build: <cut> mkdir -p investigate-linux-a2c896ab66f2c65cf6eeba140b97200a47d0450e cd investigate-linux-a2c896ab66f2c65cf6eeba140b97200a47d0450e
# Fetch scripts git clone https://git.linaro.org/toolchain/jenkins-scripts
# Fetch manifests for bad and good builds mkdir -p bad/artifacts good/artifacts curl -o bad/artifacts/manifest.sh https://ci.linaro.org/job/tcwg_kernel-gnu-build-gnu-release-arm-next-allmodc... --fail curl -o good/artifacts/manifest.sh https://ci.linaro.org/job/tcwg_kernel-gnu-build-gnu-release-arm-next-allmodc... --fail
# Reproduce bad build (cd bad; ../jenkins-scripts/tcwg_kernel-build.sh ^^ true %%rr[top_artifacts] artifacts) # Reproduce good build (cd good; ../jenkins-scripts/tcwg_kernel-build.sh ^^ true %%rr[top_artifacts] artifacts) </cut>
Full commit (up to 1000 lines): <cut> commit a2c896ab66f2c65cf6eeba140b97200a47d0450e Author: Deepak R Varma drv@mailo.com Date: Tue Nov 1 19:19:30 2022 +0530
staging: wlan-ng: Remove unused struct wlan_ie_ibss_parms references
Pointer reference to struct wlan_ie_ibss_parms is added as a member variable to 2 structures; However, these references are never used. Remove such unused struct references. The cleanup also renders the struct useless; so remove it as well. Issue identified as part of coccicheck based code analysis.
Suggested-by: Dan Carpenter dan.carpenter@oracle.com Suggested-by: Pavel Skripkin paskripkin@gmail.com Signed-off-by: Deepak R Varma drv@mailo.com Link: https://lore.kernel.org/r/e53084cdd3ca3ffea6a32393f6f28c7b7650d1a4.166730882... Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org --- drivers/staging/wlan-ng/p80211mgmt.h | 9 --------- 1 file changed, 9 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211mgmt.h b/drivers/staging/wlan-ng/p80211mgmt.h index d95ffe0097e9..816b25641f5a 100644 --- a/drivers/staging/wlan-ng/p80211mgmt.h +++ b/drivers/staging/wlan-ng/p80211mgmt.h @@ -253,13 +253,6 @@ struct wlan_ie_cf_parms { u16 cfp_durremaining; } __packed;
-/*-- IBSS Parameter Set ---------------------------*/ -struct wlan_ie_ibss_parms { - u8 eid; - u8 len; - u16 atim_win; -} __packed; - /*-- Challenge Text ------------------------------*/ struct wlan_ie_challenge { u8 eid; @@ -298,7 +291,6 @@ struct wlan_fr_beacon { struct wlan_ie_fh_parms *fh_parms; struct wlan_ie_ds_parms *ds_parms; struct wlan_ie_cf_parms *cf_parms; - struct wlan_ie_ibss_parms *ibss_parms; };
/*-- IBSS ATIM ------------------------------------*/ @@ -424,7 +416,6 @@ struct wlan_fr_proberesp { struct wlan_ie_fh_parms *fh_parms; struct wlan_ie_ds_parms *ds_parms; struct wlan_ie_cf_parms *cf_parms; - struct wlan_ie_ibss_parms *ibss_parms; };
/*-- Authentication -------------------------------*/ </cut>