On Mon, Jan 27, 2014 at 09:22:55AM +0100, Daniel Lezcano wrote:
On 01/27/2014 07:08 AM, Nicolas Pitre wrote:
ARM and ARM64 are the only two architectures implementing arch_cpu_idle_prepare() simply to call local_fiq_enable().
We have secondary_start_kernel() already calling local_fiq_enable() and this is done a second time in arch_cpu_idle_prepare() in that case. And enabling FIQs has nothing to do with idling the CPU to start with.
So let's introduce init_fiq_boot_cpu() to take care of FIQs on the boot CPU and remove arch_cpu_idle_prepare(). This is now done a bit earlier at late_initcall time but this shouldn't make a difference in practice i.e. when FIQs are actually used.
Signed-off-by: Nicolas Pitre nico@linaro.org
Reviewed-by: Daniel Lezcano daniel.lezcano@linaro.org
What kind of review did you do when giving that attributation?