On Tue, 2012-07-10 at 12:01 +0000, Arnd Bergmann wrote:
On Tuesday 10 July 2012, Anton Vorontsov wrote:
With this support kernel can save functions call chain log into a persistent ram buffer that can be decoded and dumped after reboot through pstore filesystem. It can be used to determine what function was last called before a hang or an unexpected reset (caused by, for example, a buggy driver that abuses HW).
I just looked at the patches, and they are all well implemented. I could find nothing wrong with the implementation. As to the question of whether we want this functionality I have to leave that to the tracing people.
I'm fine with it. You can add my:
Acked-by: Steven Rostedt rostedt@goodmis.org
to the tracing specific patches (I haven't taken a deep look at the pstore specific patches).
-- Steve