On Tue, Apr 05, 2011 at 03:09:05PM +0800, Shawn Guo wrote:
On Mon, Apr 04, 2011 at 10:48:27PM -0600, Grant Likely wrote:
On Mon, Apr 04, 2011 at 11:01:47PM +0800, Shawn Guo wrote:
With 'make ARCH=arm dtb', it builds Device Tree Blobs for those boards enabled by build CONFIG.
Signed-off-by: Shawn Guo shawn.guo@linaro.org
It's based on commit fe8e6d0b0e601ca0a63fe768d4b812d5a45a9da7 "arm/dt: Add dtb make rule" from Rob Herring. And it works against Linaro kernel tree. But it needs to go through mainline review before it gets applied.
Changes since v1:
- Take suggestion from Rob Herring to move .dts dection into machine sepcific Makefile.boot, so that arch/arm/boot/Makefile can be as clean as it is.
Looks good, some minor comments below, but I've picked it up and asked Nicolas to merge it.
Cheers, g.
arch/arm/Makefile | 3 +++ arch/arm/boot/Makefile | 2 ++ arch/arm/mach-exynos4/Makefile.boot | 2 ++ arch/arm/mach-mx5/Makefile.boot | 5 +++++ arch/arm/mach-omap2/Makefile.boot | 4 ++++ arch/arm/mach-tegra/Makefile.boot | 2 ++ arch/arm/mach-versatile/Makefile.boot | 2 ++ 7 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/arch/arm/Makefile b/arch/arm/Makefile index d51ab6c..7fd2af9 100644 --- a/arch/arm/Makefile +++ b/arch/arm/Makefile @@ -292,6 +292,9 @@ zinstall uinstall install: vmlinux %.dtb: $(Q)$(MAKE) $(build)=$(boot) MACHINE=$(MACHINE) $(boot)/$@ +dtb:
- $(Q)$(MAKE) $(build)=$(boot) MACHINE=$(MACHINE) $(boot)/$@
Since the target is the same, I've merged this rule with the %.dtb rule. I also renamed the target 'dtbs' because it will build more than one .dtb file.
I started with 'dtbs' as target name, and later changed it to 'dtb' to align with $(dtb-y). And 'dtbs' looks truly fine for me, but you may want to change commit message accordingly, as there is 'make ARCH=arm dtb' in it.
Thanks, fixed in my devicetree/test tree and also added something to the help text.
g.