November 2017 - Linux-stable-mirror

[Linux-stable-mirror] Patch "[media] adv7604: Initialize drive strength to default when using DT" has been added to the 4.9-stable tree

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled [media] adv7604: Initialize drive strength to default when using DT to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: adv7604-initialize-drive-strength-to-default-when-using-dt.patch and it can be found in the queue-4.9 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From foo@baz Thu Nov 9 09:48:01 CET 2017 From: Lars-Peter Clausen <lars(a)metafoo.de> Date: Tue, 29 Nov 2016 09:23:48 -0200 Subject: [media] adv7604: Initialize drive strength to default when using DT From: Lars-Peter Clausen <lars(a)metafoo.de> [ Upstream commit da8892d410db224d9a24104529794e6e37e0c100 ] The adv7604 driver platform data contains fields for configuring the drive strength of the output pins. When probing the driver through DT these fields are not explicitly initialized, which means they are left at 0. This is a reserved setting for the drive strength configuration though and can cause signal integrity issues. Whether these signal integrity issues are visible depends on the PCB specifics (e.g. the higher the load capacitance for the output the more visible the issue). But it has been observed on existing solutions at high pixel clock rates. Initialize the drive strength settings to the power-on-reset value of the device when probing through devicetree to avoid this issue. Fixes: 0e158be0162b ("adv7604: Add DT support") Signed-off-by: Lars-Peter Clausen <lars(a)metafoo.de> Reviewed-by: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> Tested-by: Niklas Söderlund <niklas.soderlund+renesas(a)ragnatech.se> Signed-off-by: Hans Verkuil <hans.verkuil(a)cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab(a)s-opensource.com> Signed-off-by: Sasha Levin <alexander.levin(a)verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/media/i2c/adv7604.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/media/i2c/adv7604.c +++ b/drivers/media/i2c/adv7604.c @@ -3118,6 +3118,9 @@ static int adv76xx_parse_dt(struct adv76 state->pdata.blank_data = 1; state->pdata.op_format_mode_sel = ADV7604_OP_FORMAT_MODE0; state->pdata.bus_order = ADV7604_BUS_ORDER_RGB; + state->pdata.dr_str_data = ADV76XX_DR_STR_MEDIUM_HIGH; + state->pdata.dr_str_clk = ADV76XX_DR_STR_MEDIUM_HIGH; + state->pdata.dr_str_sync = ADV76XX_DR_STR_MEDIUM_HIGH; return 0; } Patches currently in stable-queue which might be from lars(a)metafoo.de are queue-4.9/adv7604-initialize-drive-strength-to-default-when-using-dt.patch

7 years, 1 month

1
0
0 0

Re: [Linux-stable-mirror] [PATCH] drm/edid: Don't send non-zero YQ in AVI infoframe for HDMI 1.x sinks

by Daniel Vetter

On Wed, Nov 08, 2017 at 02:21:08PM -0800, Eric Anholt wrote: > Ville Syrjälä <ville.syrjala(a)linux.intel.com> writes: > > > On Wed, Nov 08, 2017 at 12:17:28PM -0800, Eric Anholt wrote: > >> Ville Syrjala <ville.syrjala(a)linux.intel.com> writes: > >> > >> > From: Ville Syrjälä <ville.syrjala(a)linux.intel.com> > >> > > >> > Apparently some sinks look at the YQ bits even when receiving RGB, > >> > and they get somehow confused when they see a non-zero YQ value. > >> > So we can't just blindly follow CEA-861-F and set YQ to match the > >> > RGB range. > >> > > >> > Unfortunately there is no good way to tell whether the sink > >> > designer claims to have read CEA-861-F. The CEA extension block > >> > revision number has generally been stuck at 3 since forever, > >> > and even a very recently manufactured sink might be based on > >> > an old design so the manufacturing date doesn't seem like > >> > something we can use. In lieu of better information let's > >> > follow CEA-861-F only for HDMI 2.0 sinks, since HDMI 2.0 is > >> > based on CEA-861-F. For HDMI 1.x sinks we'll always set YQ=0. > >> > > >> > The alternative would of course be to always set YQ=0. And if > >> > we ever encounter a HDMI 2.0+ sink with this bug that's what > >> > we'll probably have to do. > >> > >> Should vc4 be doing anything special for HDMI2 sinks, if it's an HDMI1.4 > >> source? > > > > As long as you stick to < 340 MHz modes you shouldn't have to do > > anything. For >=340 MHz you'd need to use some new HDMI 2.0 features. > > > > Looks like vc4 crtc .mode_valid() doesn't do much. I presume it's up > > to bridges/encoders to filter out most things that aren't supported? > > I had a patch for that at > https://patchwork.freedesktop.org/series/30680/ -- fedora folks had run > into trouble with 4k monitors. Ack on the clock limiting patch, silly that it's stuck. No idea about CEC, better for Hans/Boris I guess. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

7 years, 1 month

1
0
0 0

[Linux-stable-mirror] [PATCH] ALSA: hda - fix headset mic problem for Dell machines with alc274

by Hui Wang

Confirmed with Kailang of Realtek, the pin 0x19 is for Headset Mic, and the pin 0x1a is for Headphone Mic, he suggested to apply ALC269_FIXUP_DELL1_MIC_NO_PRESENCE to fix this problem. And we verified applying this FIXUP can fix this problem. Cc: <stable(a)vger.kernel.org> Cc: Kailang Yang <kailang(a)realtek.com> Signed-off-by: Hui Wang <hui.wang(a)canonical.com> --- sound/pci/hda/patch_realtek.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 9b77d43..db1a376 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6568,6 +6568,11 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { {0x14, 0x90170110}, {0x1b, 0x90a70130}, {0x21, 0x03211020}), + SND_HDA_PIN_QUIRK(0x10ec0274, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE, + {0x12, 0xb7a60130}, + {0x13, 0xb8a61140}, + {0x16, 0x90170110}, + {0x21, 0x04211020}), SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC280_FIXUP_HP_GPIO4, {0x12, 0x90a60130}, {0x14, 0x90170110}, -- 2.7.4

7 years, 1 month

2
1
0 0

[Linux-stable-mirror] [PATCH 2/2] ARM: mm: dump: check hardware RO bit for LPAE

by Philip Derrin

When CONFIG_ARM_LPAE is set, the PMD dump relies on the software read-only bit to determine whether a page is writable. This concealed a bug which left the kernel text section writable (AP2=0) while marked read-only in the software bit. In a kernel with the AP2 bug, the dump looks like this: ---[ Kernel Mapping ]--- 0xc0000000-0xc0200000 2M RW NX SHD 0xc0200000-0xc0600000 4M ro x SHD 0xc0600000-0xc0800000 2M ro NX SHD 0xc0800000-0xc4800000 64M RW NX SHD The fix is to check that the software and hardware bits are both set before displaying "ro". The dump then shows the true perms: ---[ Kernel Mapping ]--- 0xc0000000-0xc0200000 2M RW NX SHD 0xc0200000-0xc0600000 4M RW x SHD 0xc0600000-0xc0800000 2M RW NX SHD 0xc0800000-0xc4800000 64M RW NX SHD Fixes: ded947798469 ("ARM: 8109/1: mm: Modify pte_write and pmd_write logic for LPAE") Signed-off-by: Philip Derrin <philip(a)cog.systems> Tested-by: Neil Dick <neil(a)cog.systems> Cc: stable(a)vger.kernel.org --- arch/arm/mm/dump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mm/dump.c b/arch/arm/mm/dump.c index 35ff45470dbf..fc3b44028cfb 100644 --- a/arch/arm/mm/dump.c +++ b/arch/arm/mm/dump.c @@ -129,8 +129,8 @@ static const struct prot_bits section_bits[] = { .val = PMD_SECT_USER, .set = "USR", }, { - .mask = L_PMD_SECT_RDONLY, - .val = L_PMD_SECT_RDONLY, + .mask = L_PMD_SECT_RDONLY | PMD_SECT_AP2, + .val = L_PMD_SECT_RDONLY | PMD_SECT_AP2, .set = "ro", .clear = "RW", #elif __LINUX_ARM_ARCH__ >= 6 -- 2.15.0

7 years, 1 month

1
0
0 0

[Linux-stable-mirror] [PATCH 1/2] ARM: mm: make STRICT_KERNEL_RWX effective for LPAE

by Philip Derrin

Currently, for ARM kernels with CONFIG_ARM_LPAE and CONFIG_STRICT_KERNEL_RWX enabled, the 2MiB pages mapping the kernel code and rodata are writable. They are marked read-only in a software bit (L_PMD_SECT_RDONLY) but the hardware read-only bit is not set (PMD_SECT_AP2). For user mappings, the logic that propagates the software bit to the hardware bit is in set_pmd_at(); but for the kernel, section_update() writes the PMDs directly, skipping this logic. The fix is to set PMD_SECT_AP2 for read-only sections in section_update(), at the same time as L_PMD_SECT_RDONLY. Fixes: 1e3479225acb ("ARM: 8275/1: mm: fix PMD_SECT_RDONLY undeclared compile error") Signed-off-by: Philip Derrin <philip(a)cog.systems> Reported-by: Neil Dick <neil(a)cog.systems> Tested-by: Neil Dick <neil(a)cog.systems> Tested-by: Laura Abbott <labbott(a)redhat.com> Cc: stable(a)vger.kernel.org --- arch/arm/mm/init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c index ad80548325fe..0f6d1537f330 100644 --- a/arch/arm/mm/init.c +++ b/arch/arm/mm/init.c @@ -639,8 +639,8 @@ static struct section_perm ro_perms[] = { .start = (unsigned long)_stext, .end = (unsigned long)__init_begin, #ifdef CONFIG_ARM_LPAE - .mask = ~L_PMD_SECT_RDONLY, - .prot = L_PMD_SECT_RDONLY, + .mask = ~(L_PMD_SECT_RDONLY | PMD_SECT_AP2), + .prot = L_PMD_SECT_RDONLY | PMD_SECT_AP2, #else .mask = ~(PMD_SECT_APX | PMD_SECT_AP_WRITE), .prot = PMD_SECT_APX | PMD_SECT_AP_WRITE, -- 2.15.0

7 years, 1 month

1
0
0 0

Re: [Linux-stable-mirror] [PATCH AUTOSEL for-4.9 04/53] spi: imx: adjust watermark level according to transfer length

by Levin, Alexander (Sasha Levin)

On Wed, Nov 08, 2017 at 11:11:11PM +0000, Mark Brown wrote: >On Wed, Nov 08, 2017 at 10:48:14PM +0000, Levin, Alexander (Sasha Levin) wrote: >> On Wed, Nov 08, 2017 at 10:11:02PM +0000, Mark Brown wrote: > >> >expose problems if we start using it. If you look at the history of the >> >driver there's some quirks were added later on for example, and I didn't >> >check the DMA controller drivers or anything and obviously can't see any >> >out of tree code users may have. > >> I'm considering these commits to be on the safer side because they're >> much older than the ones Greg usually grabs. There were no upstream >> fixes to this commit for 10 months now, and given the code changes >> upstream in that subsystem, this patch seemed to be safe to backport. > >Like I say I'm seeing some potentially relevant variant handling added >later and you also have to consider the DMA drivers it might be used >with (imx-dma looks safe but perhaps there's other things, never mind >out of tree code). It just doesn't feel good. > >We have also had problems in the past with SPI performance enhancements >exposing exising problems elsewhere though not so much with this sort of >area so I'm less worried about that. Sure, I'll drop it. Thanks! -- Thanks, Sasha

7 years, 1 month

1
0
0 0

Re: [Linux-stable-mirror] [PATCH AUTOSEL for-4.9 04/53] spi: imx: adjust watermark level according to transfer length

by Levin, Alexander (Sasha Levin)

On Wed, Nov 08, 2017 at 10:11:02PM +0000, Mark Brown wrote: >On Wed, Nov 08, 2017 at 09:39:11PM +0000, Levin, Alexander (Sasha Levin) wrote: >> >On Wed, Nov 08, 2017 at 08:49:55PM +0000, Levin, Alexander (Sasha Levin) wrote: >> >This seems like an optimization not a bug fix... > >> Hm, is it? I read it as "DMA is not being used at all even though we >> thought we're using it". > >Yes, that's how I read it too. > >> Yes, the impact is "just" performance, but doesn't it result in quite >> a significat impact? > >Only about double according to the initial commit adding DMA support >which is frankly a bit disappointing although yeah, it's a big win. My >worry is that if there's a problem with DMA on some device for which a >fix wasn't backported (or where we're using a fallback) this could >expose problems if we start using it. If you look at the history of the >driver there's some quirks were added later on for example, and I didn't >check the DMA controller drivers or anything and obviously can't see any >out of tree code users may have. > >*Probably* it doesn't break anything but since it's not fixing anything >and the risk is data corruption I'd be much more comfortable with a more >thorough risk analysis. I'm considering these commits to be on the safer side because they're much older than the ones Greg usually grabs. There were no upstream fixes to this commit for 10 months now, and given the code changes upstream in that subsystem, this patch seemed to be safe to backport. -- Thanks, Sasha

7 years, 1 month

1
0
0 0

Re: [Linux-stable-mirror] [PATCH AUTOSEL for-4.9 04/53] spi: imx: adjust watermark level according to transfer length

by Levin, Alexander (Sasha Levin)

On Wed, Nov 08, 2017 at 08:57:52PM +0000, Mark Brown wrote: >On Wed, Nov 08, 2017 at 08:49:55PM +0000, Levin, Alexander (Sasha Levin) wrote: >> From: Jiada Wang <jiada_wang(a)mentor.com> >> >> [ Upstream commit 66459c5a50a787c474b734b586328f7111ab6df0 ] >> >> Previously DMA watermark level is configured to fifosize/2, >> DMA mode can be used only when transfer length can be divided >> by 'watermark level * bpw', which makes DMA mode not pratical. >> >> This patch adjusts watermark level to largest number (no bigger >> than fifosize/2) which can divide 'tranfer length / bpw' for >> each transfer. > >This seems like an optimization not a bug fix... Hm, is it? I read it as "DMA is not being used at all even though we thought we're using it". Yes, the impact is "just" performance, but doesn't it result in quite a significat impact? -- Thanks, Sasha

7 years, 1 month

1
0
0 0

[Linux-stable-mirror] [PATCH 3/3] ASoC: sun8i-codec: Fix left and right channels inversion

by Maxime Ripard

Since its introduction, the codec had an inversion of the left and right channels. It turned out to be pretty simple as it appears that the codec doesn't have the same polarity on the LRCK signal than the I2S block. Fix this by inverting our bit value for the LRCK inversion. Fixes: 36c684936fae ("ASoC: Add sun8i digital audio codec") Cc: <stable(a)vger.kernel.org> Signed-off-by: Maxime Ripard <maxime.ripard(a)free-electrons.com> --- sound/soc/sunxi/sun8i-codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sunxi/sun8i-codec.c b/sound/soc/sunxi/sun8i-codec.c index 522546e6b153..c8dcb1502d74 100644 --- a/sound/soc/sunxi/sun8i-codec.c +++ b/sound/soc/sunxi/sun8i-codec.c @@ -200,7 +200,7 @@ static int sun8i_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) value << SUN8I_AIF1CLK_CTRL_AIF1_BCLK_INV); regmap_update_bits(scodec->regmap, SUN8I_AIF1CLK_CTRL, BIT(SUN8I_AIF1CLK_CTRL_AIF1_LRCK_INV), - value << SUN8I_AIF1CLK_CTRL_AIF1_LRCK_INV); + !value << SUN8I_AIF1CLK_CTRL_AIF1_LRCK_INV); /* DAI format */ switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) { -- 2.14.3

7 years, 1 month

3
2
0 0

[Linux-stable-mirror] v4.9.61 build: 0 failures 0 warnings (v4.9.61)

by Build bot for Mark Brown

Tree/Branch: v4.9.61 Git describe: v4.9.61 Commit: 5caae9d141 Linux 4.9.61 Build Time: 82 min 53 sec Passed: 10 / 10 (100.00 %) Failed: 0 / 10 ( 0.00 %) Errors: 0 Warnings: 0 Section Mismatches: 0 ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): ------------------------------------------------------------------------------- =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: arm64-allnoconfig arm64-allmodconfig arm-multi_v5_defconfig arm-multi_v7_defconfig x86_64-defconfig arm-allmodconfig arm-allnoconfig x86_64-allnoconfig arm-multi_v4t_defconfig arm64-defconfig close failed in file object destructor: sys.excepthook is missing lost sys.stderr

7 years, 1 month

1
0
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror November 2017