May 2019 - Linux-stable-mirror

[PATCH v2] serial: sh-sci: disable DMA for uart_console

by George G. Davis

As noted in commit 84b40e3b57ee ("serial: 8250: omap: Disable DMA for console UART"), UART console lines use low-level PIO only access functions which will conflict with use of the line when DMA is enabled, e.g. when the console line is also used for systemd messages. So disable DMA support for UART console lines. Fixes: https://patchwork.kernel.org/patch/10929511/ Reported-by: Michael Rodin <mrodin(a)de.adit-jv.com> Tested-by: Eugeniu Rosca <erosca(a)de.adit-jv.com> Reviewed-by: Simon Horman <horms+renesas(a)verge.net.au> Reviewed-by: Wolfram Sang <wsa+renesas(a)sang-engineering.com> Cc: stable(a)vger.kernel.org Signed-off-by: George G. Davis <george_davis(a)mentor.com> --- v2: Clarify comment regarding DMA support on kernel console, add {Tested,Reviewed}-by:, and Cc: linux-stable lines. --- drivers/tty/serial/sh-sci.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c index 3cd139752d3f..abc705716aa0 100644 --- a/drivers/tty/serial/sh-sci.c +++ b/drivers/tty/serial/sh-sci.c @@ -1557,6 +1557,13 @@ static void sci_request_dma(struct uart_port *port) dev_dbg(port->dev, "%s: port %d\n", __func__, port->line); + /* + * DMA on console may interfere with Kernel log messages which use + * plain putchar(). So, simply don't use it with a console. + */ + if (uart_console(port)) + return; + if (!port->dev->of_node) return; -- 2.7.4

5 years, 9 months

3
4
0 0

stable-rc/linux-4.19.y boot: 127 boots: 1 failed, 120 passed with 5 offline, 1 untried/unknown (v4.19.42-86-gc8e3be30c4b6)

by kernelci.org bot

stable-rc/linux-4.19.y boot: 127 boots: 1 failed, 120 passed with 5 offline, 1 untried/unknown (v4.19.42-86-gc8e3be30c4b6) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.19.y/kernel/v4.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.19.y/kernel/v4.19.42-86… Tree: stable-rc Branch: linux-4.19.y Git Describe: v4.19.42-86-gc8e3be30c4b6 Git Commit: c8e3be30c4b609f2f7c587d1a2ae32d1a1d8f9c9 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 66 unique boards, 23 SoC families, 14 builds out of 206 Boot Failure Detected: arm: multi_v7_defconfig: gcc-8: stih410-b2120: 1 failed lab Offline Platforms: arm: multi_v7_defconfig: gcc-8 exynos5800-peach-pi: 1 offline lab exynos_defconfig: gcc-8 exynos5800-peach-pi: 1 offline lab davinci_all_defconfig: gcc-8 dm365evm,legacy: 1 offline lab arm64: defconfig: gcc-8 meson-axg-s400: 1 offline lab meson-gxl-s905x-libretech-cc: 1 offline lab --- For more info write to <info(a)kernelci.org>

5 years, 9 months

1
0
0 0

stable-rc/linux-5.0.y boot: 135 boots: 1 failed, 126 passed with 7 offline, 1 conflict (v5.0.15-106-gfaddc6604ec4)

by kernelci.org bot

stable-rc/linux-5.0.y boot: 135 boots: 1 failed, 126 passed with 7 offline, 1 conflict (v5.0.15-106-gfaddc6604ec4) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-5.0.y/kernel/v5.0.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-5.0.y/kernel/v5.0.15-106-… Tree: stable-rc Branch: linux-5.0.y Git Describe: v5.0.15-106-gfaddc6604ec4 Git Commit: faddc6604ec40ecc25d17a782d76f0de82d564be Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 72 unique boards, 23 SoC families, 14 builds out of 208 Boot Regressions Detected: arm: omap2plus_defconfig: gcc-8: omap4-panda: lab-baylibre: failing since 3 days (last pass: v5.0.14-96-gdf1376651d49 - first fail: v5.0.15) Boot Failure Detected: arm: multi_v7_defconfig: gcc-8: stih410-b2120: 1 failed lab Offline Platforms: arm: multi_v7_defconfig: gcc-8 exynos5800-peach-pi: 1 offline lab exynos_defconfig: gcc-8 exynos5800-peach-pi: 1 offline lab davinci_all_defconfig: gcc-8 dm365evm,legacy: 1 offline lab arm64: defconfig: gcc-8 meson-axg-s400: 1 offline lab meson-g12a-u200: 1 offline lab meson-g12a-x96-max: 1 offline lab meson-gxl-s905x-libretech-cc: 1 offline lab Conflicting Boot Failure Detected: (These likely are not failures as other labs are reporting PASS. Needs review.) arm: omap2plus_defconfig: omap4-panda: lab-baylibre: FAIL (gcc-8) lab-baylibre-seattle: PASS (gcc-8) --- For more info write to <info(a)kernelci.org>

5 years, 9 months

1
0
0 0

✅ PASS: Test report for kernel 5.1.2-rc1-9b1451b.cki (stable)

by CKI Project

Hello, We ran automated tests on a recent commit from this kernel tree: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Commit: 7a7bf35978ee - Linux 5.1.2-rc1 The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Compile testing --------------- We compiled the kernel for 4 architectures: aarch64: build options: -j25 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/aarch64/kernel-stable-aarch64-7a7b… kernel build: https://artifacts.cki-project.org/builds/aarch64/kernel-stable-aarch64-7a7b… ppc64le: build options: -j25 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable-ppc64le-7a7b… kernel build: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable-ppc64le-7a7b… s390x: build options: -j25 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/s390x/kernel-stable-s390x-7a7bf359… kernel build: https://artifacts.cki-project.org/builds/s390x/kernel-stable-s390x-7a7bf359… x86_64: build options: -j25 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/x86_64/kernel-stable-x86_64-7a7bf3… kernel build: https://artifacts.cki-project.org/builds/x86_64/kernel-stable-x86_64-7a7bf3… Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: ✅ Boot test [0] ✅ xfstests: ext4 [1] ✅ xfstests: xfs [1] ✅ Boot test [0] ✅ LTP lite [2] ✅ Loopdev Sanity [3] ✅ Memory function: memfd_create [4] ✅ AMTU (Abstract Machine Test Utility) [5] ✅ Ethernet drivers sanity [6] ✅ httpd: mod_ssl smoke sanity [7] ✅ iotop: sanity [8] ✅ redhat-rpm-config: detect-kabi-provides sanity [9] ✅ redhat-rpm-config: kabi-whitelist-not-found sanity [10] ✅ tuned: tune-processes-through-perf [11] ✅ Usex - version 1.9-29 [12] ✅ lvm thinp sanity [13] 🚧 ✅ selinux-policy: serge-testsuite [14] 🚧 ✅ Networking route: pmtu [15] 🚧 ✅ audit: audit testsuite test [16] 🚧 ✅ Storage blktests [17] 🚧 ✅ stress: stress-ng [18] ppc64le: ✅ Boot test [0] ✅ xfstests: ext4 [1] ✅ xfstests: xfs [1] ✅ Boot test [0] ✅ LTP lite [2] ✅ Loopdev Sanity [3] ✅ Memory function: memfd_create [4] ✅ AMTU (Abstract Machine Test Utility) [5] ✅ Ethernet drivers sanity [6] ✅ httpd: mod_ssl smoke sanity [7] ✅ iotop: sanity [8] ✅ redhat-rpm-config: detect-kabi-provides sanity [9] ✅ redhat-rpm-config: kabi-whitelist-not-found sanity [10] ✅ tuned: tune-processes-through-perf [11] ✅ Usex - version 1.9-29 [12] ✅ lvm thinp sanity [13] 🚧 ✅ selinux-policy: serge-testsuite [14] 🚧 ✅ Networking route: pmtu [15] 🚧 ✅ audit: audit testsuite test [16] 🚧 ✅ Storage blktests [17] 🚧 ✅ stress: stress-ng [18] s390x: ✅ Boot test [0] ✅ Boot test [0] ✅ Boot test [0] ✅ LTP lite [2] ✅ Loopdev Sanity [3] ✅ Memory function: memfd_create [4] ✅ Ethernet drivers sanity [6] ✅ httpd: mod_ssl smoke sanity [7] ✅ iotop: sanity [8] ✅ redhat-rpm-config: detect-kabi-provides sanity [9] ✅ redhat-rpm-config: kabi-whitelist-not-found sanity [10] ✅ tuned: tune-processes-through-perf [11] ✅ Usex - version 1.9-29 [12] ✅ lvm thinp sanity [13] 🚧 ✅ kdump: sysrq-c [19] 🚧 ✅ selinux-policy: serge-testsuite [14] 🚧 ✅ Networking route: pmtu [15] 🚧 ✅ audit: audit testsuite test [16] 🚧 ✅ Storage blktests [17] 🚧 ✅ stress: stress-ng [18] x86_64: ✅ Boot test [0] ✅ Boot test [0] ✅ LTP lite [2] ✅ Loopdev Sanity [3] ✅ Memory function: memfd_create [4] ✅ AMTU (Abstract Machine Test Utility) [5] ✅ Ethernet drivers sanity [6] ✅ httpd: mod_ssl smoke sanity [7] ✅ iotop: sanity [8] ✅ redhat-rpm-config: detect-kabi-provides sanity [9] ✅ redhat-rpm-config: kabi-whitelist-not-found sanity [10] ✅ tuned: tune-processes-through-perf [11] ✅ Usex - version 1.9-29 [12] ✅ lvm thinp sanity [13] ✅ Boot test [0] ✅ xfstests: ext4 [1] ✅ xfstests: xfs [1] ✅ Boot test [0] 🚧 ✅ kdump: sysrq-c [19] 🚧 ✅ Networking route: pmtu [15] 🚧 ✅ audit: audit testsuite test [16] 🚧 ✅ Storage blktests [17] 🚧 ✅ stress: stress-ng [18] 🚧 ✅ selinux-policy: serge-testsuite [14] 🚧 ✅ kdump: sysrq-c - megaraid_sas [19] Test source: [0]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [1]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… [2]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [3]: https://github.com/CKI-project/tests-beaker/archive/master.zip#filesystems/… [4]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/memory/func… [5]: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu [6]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [7]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/htt… [8]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/iot… [9]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/red… [10]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/red… [11]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/tun… [12]: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us… [13]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/lvm/… [14]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/packages/se… [15]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [16]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/aud… [17]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/blk [18]: https://github.com/CKI-project/tests-beaker/archive/master.zip#stress/stres… [19]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/kdump/kdump… Waived tests (marked with 🚧) ----------------------------- This test run included waived tests. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed.

5 years, 9 months

1
0
0 0

Re: [PATCH 1/5] USB: serial: fix unthrottle races

by Johan Hovold

On Thu, Apr 25, 2019 at 06:05:36PM +0200, Johan Hovold wrote: > Fix two long-standing bugs which could potentially lead to memory > corruption or leave the port throttled until it is reopened (on weakly > ordered systems), respectively, when read-URB completion races with > unthrottle(). > > First, the URB must not be marked as free before processing is complete > to prevent it from being submitted by unthrottle() on another CPU. > > CPU 1 CPU 2 > ================ ================ > complete() unthrottle() > process_urb(); > smp_mb__before_atomic(); > set_bit(i, free); if (test_and_clear_bit(i, free)) > submit_urb(); > > Second, the URB must be marked as free before checking the throttled > flag to prevent unthrottle() on another CPU from failing to observe that > the URB needs to be submitted if complete() sees that the throttled flag > is set. > > CPU 1 CPU 2 > ================ ================ > complete() unthrottle() > set_bit(i, free); throttled = 0; > smp_mb__after_atomic(); smp_mb(); > if (throttled) if (test_and_clear_bit(i, free)) > return; submit_urb(); > > Note that test_and_clear_bit() only implies barriers when the test is > successful. To handle the case where the URB is still in use an explicit > barrier needs to be added to unthrottle() for the second race condition. > > Fixes: d83b405383c9 ("USB: serial: add support for multiple read urbs") > Signed-off-by: Johan Hovold <johan(a)kernel.org> Greg, I noticed you added a stable tag to the corresponding cdc-acm fix and think I should have added on one from the start to this one as well. Would you mind queuing this one up for stable? Upstream commit 3f5edd58d040bfa4b74fb89bc02f0bc6b9cd06ab. Thanks, Johan

5 years, 9 months

3
6
0 0

✅ PASS: Stable queue: queue-5.1

by CKI Project

Hello, We ran automated tests on a patchset that was proposed for merging into this kernel tree. The patches were applied to: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: b724e9356404 - Linux 5.1.1 The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Merge testing ------------- We cloned this repository and checked out the following commit: Repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: b724e9356404 - Linux 5.1.1 We then merged the patchset with `git am`: platform-x86-sony-laptop-fix-unintentional-fall-through.patch platform-x86-thinkpad_acpi-disable-bluetooth-for-some-machines.patch platform-x86-dell-laptop-fix-rfkill-functionality.patch hwmon-pwm-fan-disable-pwm-if-fetching-cooling-data-fails.patch hwmon-occ-fix-extended-status-bits.patch selftests-seccomp-handle-namespace-failures-gracefully.patch i2c-core-ratelimit-transfer-when-suspended-errors.patch kernfs-fix-barrier-usage-in-__kernfs_new_node.patch virt-vbox-sanity-check-parameter-types-for-hgcm-calls-coming-from-userspace.patch usb-serial-fix-unthrottle-races.patch mwl8k-fix-rate_idx-underflow.patch rtlwifi-rtl8723ae-fix-missing-break-in-switch-statement.patch mm-memory_hotplug-do-not-unlock-when-fails-to-take-the-device_hotplug_lock.patch don-t-jump-to-compute_result-state-from-check_result-state.patch Compile testing --------------- We compiled the kernel for 4 architectures: aarch64: build options: -j25 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/aarch64/kernel-stable_queue_5.1-aa… kernel build: https://artifacts.cki-project.org/builds/aarch64/kernel-stable_queue_5.1-aa… ppc64le: build options: -j25 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable_queue_5.1-pp… kernel build: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable_queue_5.1-pp… s390x: build options: -j25 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/s390x/kernel-stable_queue_5.1-s390… kernel build: https://artifacts.cki-project.org/builds/s390x/kernel-stable_queue_5.1-s390… x86_64: build options: -j25 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/x86_64/kernel-stable_queue_5.1-x86… kernel build: https://artifacts.cki-project.org/builds/x86_64/kernel-stable_queue_5.1-x86… Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: ✅ Boot test [0] ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ AMTU (Abstract Machine Test Utility) [3] ✅ httpd: mod_ssl smoke sanity [4] ✅ iotop: sanity [5] ✅ tuned: tune-processes-through-perf [6] 🚧 ✅ selinux-policy: serge-testsuite [7] 🚧 ✅ audit: audit testsuite test [8] 🚧 ✅ stress: stress-ng [9] ppc64le: ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ AMTU (Abstract Machine Test Utility) [3] ✅ httpd: mod_ssl smoke sanity [4] ✅ iotop: sanity [5] ✅ tuned: tune-processes-through-perf [6] ✅ Boot test [0] 🚧 ✅ audit: audit testsuite test [8] 🚧 ✅ stress: stress-ng [9] 🚧 ✅ selinux-policy: serge-testsuite [7] s390x: ✅ Boot test [0] ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ httpd: mod_ssl smoke sanity [4] ✅ iotop: sanity [5] ✅ tuned: tune-processes-through-perf [6] 🚧 ✅ selinux-policy: serge-testsuite [7] 🚧 ✅ audit: audit testsuite test [8] 🚧 ✅ stress: stress-ng [9] x86_64: ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ AMTU (Abstract Machine Test Utility) [3] ✅ httpd: mod_ssl smoke sanity [4] ✅ iotop: sanity [5] ✅ tuned: tune-processes-through-perf [6] ✅ Boot test [0] 🚧 ✅ audit: audit testsuite test [8] 🚧 ✅ stress: stress-ng [9] 🚧 ✅ selinux-policy: serge-testsuite [7] Test source: [0]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [1]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [2]: https://github.com/CKI-project/tests-beaker/archive/master.zip#filesystems/… [3]: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu [4]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/htt… [5]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/iot… [6]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/tun… [7]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/packages/se… [8]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/aud… [9]: https://github.com/CKI-project/tests-beaker/archive/master.zip#stress/stres… Waived tests (marked with 🚧) ----------------------------- This test run included waived tests. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed.

5 years, 9 months

1
0
0 0

✅ PASS: Test report for kernel 4.19.43-rc1-1263e10.cki (stable)

by CKI Project

Hello, We ran automated tests on a recent commit from this kernel tree: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Commit: c8e3be30c4b6 - Linux 4.19.43-rc1 The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Compile testing --------------- We compiled the kernel for 4 architectures: aarch64: build options: -j25 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/aarch64/kernel-stable-aarch64-c8e3… kernel build: https://artifacts.cki-project.org/builds/aarch64/kernel-stable-aarch64-c8e3… ppc64le: build options: -j25 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable-ppc64le-c8e3… kernel build: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable-ppc64le-c8e3… s390x: build options: -j25 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/s390x/kernel-stable-s390x-c8e3be30… kernel build: https://artifacts.cki-project.org/builds/s390x/kernel-stable-s390x-c8e3be30… x86_64: build options: -j25 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/x86_64/kernel-stable-x86_64-c8e3be… kernel build: https://artifacts.cki-project.org/builds/x86_64/kernel-stable-x86_64-c8e3be… Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: ✅ Boot test [0] ✅ xfstests: ext4 [1] ✅ xfstests: xfs [1] ✅ Boot test [0] ✅ LTP lite [2] ✅ Loopdev Sanity [3] ✅ Memory function: memfd_create [4] ✅ AMTU (Abstract Machine Test Utility) [5] ✅ Ethernet drivers sanity [6] ✅ httpd: mod_ssl smoke sanity [7] ✅ iotop: sanity [8] ✅ redhat-rpm-config: detect-kabi-provides sanity [9] ✅ redhat-rpm-config: kabi-whitelist-not-found sanity [10] ✅ tuned: tune-processes-through-perf [11] ✅ Usex - version 1.9-29 [12] ✅ lvm thinp sanity [13] 🚧 ✅ selinux-policy: serge-testsuite [14] 🚧 ✅ Networking route: pmtu [15] 🚧 ✅ audit: audit testsuite test [16] 🚧 ✅ Storage blktests [17] 🚧 ✅ stress: stress-ng [18] ppc64le: ✅ Boot test [0] ✅ xfstests: ext4 [1] ✅ xfstests: xfs [1] ✅ Boot test [0] ✅ LTP lite [2] ✅ Loopdev Sanity [3] ✅ Memory function: memfd_create [4] ✅ AMTU (Abstract Machine Test Utility) [5] ✅ Ethernet drivers sanity [6] ✅ httpd: mod_ssl smoke sanity [7] ✅ iotop: sanity [8] ✅ redhat-rpm-config: detect-kabi-provides sanity [9] ✅ redhat-rpm-config: kabi-whitelist-not-found sanity [10] ✅ tuned: tune-processes-through-perf [11] ✅ Usex - version 1.9-29 [12] ✅ lvm thinp sanity [13] 🚧 ✅ selinux-policy: serge-testsuite [14] 🚧 ✅ Networking route: pmtu [15] 🚧 ✅ audit: audit testsuite test [16] 🚧 ✅ Storage blktests [17] 🚧 ✅ stress: stress-ng [18] s390x: ✅ Boot test [0] ✅ Boot test [0] ✅ Boot test [0] ✅ LTP lite [2] ✅ Loopdev Sanity [3] ✅ Memory function: memfd_create [4] ✅ Ethernet drivers sanity [6] ✅ httpd: mod_ssl smoke sanity [7] ✅ iotop: sanity [8] ✅ redhat-rpm-config: detect-kabi-provides sanity [9] ✅ redhat-rpm-config: kabi-whitelist-not-found sanity [10] ✅ tuned: tune-processes-through-perf [11] ✅ Usex - version 1.9-29 [12] ✅ lvm thinp sanity [13] 🚧 ✅ kdump: sysrq-c [19] 🚧 ✅ selinux-policy: serge-testsuite [14] 🚧 ✅ Networking route: pmtu [15] 🚧 ✅ audit: audit testsuite test [16] 🚧 ✅ Storage blktests [17] 🚧 ✅ stress: stress-ng [18] x86_64: ✅ Boot test [0] ✅ Boot test [0] ✅ xfstests: ext4 [1] ✅ xfstests: xfs [1] ✅ Boot test [0] ✅ LTP lite [2] ✅ Loopdev Sanity [3] ✅ Memory function: memfd_create [4] ✅ AMTU (Abstract Machine Test Utility) [5] ✅ Ethernet drivers sanity [6] ✅ httpd: mod_ssl smoke sanity [7] ✅ iotop: sanity [8] ✅ redhat-rpm-config: detect-kabi-provides sanity [9] ✅ redhat-rpm-config: kabi-whitelist-not-found sanity [10] ✅ tuned: tune-processes-through-perf [11] ✅ Usex - version 1.9-29 [12] ✅ lvm thinp sanity [13] ✅ Boot test [0] 🚧 ✅ kdump: sysrq-c - megaraid_sas [19] 🚧 ✅ selinux-policy: serge-testsuite [14] 🚧 ✅ Networking route: pmtu [15] 🚧 ✅ audit: audit testsuite test [16] 🚧 ✅ Storage blktests [17] 🚧 ✅ stress: stress-ng [18] 🚧 ✅ kdump: sysrq-c [19] Test source: [0]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [1]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… [2]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [3]: https://github.com/CKI-project/tests-beaker/archive/master.zip#filesystems/… [4]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/memory/func… [5]: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu [6]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [7]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/htt… [8]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/iot… [9]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/red… [10]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/red… [11]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/tun… [12]: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us… [13]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/lvm/… [14]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/packages/se… [15]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [16]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/aud… [17]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/blk [18]: https://github.com/CKI-project/tests-beaker/archive/master.zip#stress/stres… [19]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/kdump/kdump… Waived tests (marked with 🚧) ----------------------------- This test run included waived tests. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed.

5 years, 9 months

1
0
0 0

Re: [PATCH] powerpc/powernv/npu: Fix reference leak

by Greg Kurz

On Mon, 29 Apr 2019 16:01:29 +1000 Alexey Kardashevskiy <aik(a)ozlabs.ru> wrote: > On 20/04/2019 01:34, Greg Kurz wrote: > > Since 902bdc57451c, get_pci_dev() calls pci_get_domain_bus_and_slot(). This > > has the effect of incrementing the reference count of the PCI device, as > > explained in drivers/pci/search.c: > > > > * Given a PCI domain, bus, and slot/function number, the desired PCI > > * device is located in the list of PCI devices. If the device is > > * found, its reference count is increased and this function returns a > > * pointer to its data structure. The caller must decrement the > > * reference count by calling pci_dev_put(). If no device is found, > > * %NULL is returned. > > > > Nothing was done to call pci_dev_put() and the reference count of GPU and > > NPU PCI devices rockets up. > > > > A natural way to fix this would be to teach the callers about the change, > > so that they call pci_dev_put() when done with the pointer. This turns > > out to be quite intrusive, as it affects many paths in npu-dma.c, > > pci-ioda.c and vfio_pci_nvlink2.c. > > > afaict this referencing is only done to protect the current traverser > and what you've done is actually a natural way (and the generic > pci_get_dev_by_id() does exactly the same), although this looks a bit weird. > Not exactly the same: pci_get_dev_by_id() always increment the refcount of the returned PCI device. The refcount is only decremented when this device is passed to pci_get_dev_by_id() to continue searching. That means that the users of the PCI device pointer returned by pci_get_dev_by_id() or its exported variants pci_get_subsys(), pci_get_device() and pci_get_class() do handle the refcount. They all pass the pointer to pci_dev_put() or continue the search, which calls pci_dev_put() internally. Direct and indirect callers of get_pci_dev() don't care for the refcount at all unless I'm missing something. > > > Also, the issue appeared in 4.16 and > > some affected code got moved around since then: it would be problematic > > to backport the fix to stable releases. > > > > All that code never cared for reference counting anyway. Call pci_dev_put() > > from get_pci_dev() to revert to the previous behavior. > >> Fixes: 902bdc57451c ("powerpc/powernv/idoa: Remove unnecessary pcidev > from pci_dn") > > Cc: stable(a)vger.kernel.org # v4.16 > > Signed-off-by: Greg Kurz <groug(a)kaod.org> > > --- > > arch/powerpc/platforms/powernv/npu-dma.c | 15 ++++++++++++++- > > 1 file changed, 14 insertions(+), 1 deletion(-) > > > > diff --git a/arch/powerpc/platforms/powernv/npu-dma.c b/arch/powerpc/platforms/powernv/npu-dma.c > > index e713ade30087..d8f3647e8fb2 100644 > > --- a/arch/powerpc/platforms/powernv/npu-dma.c > > +++ b/arch/powerpc/platforms/powernv/npu-dma.c > > @@ -31,9 +31,22 @@ static DEFINE_SPINLOCK(npu_context_lock); > > static struct pci_dev *get_pci_dev(struct device_node *dn) > > { > > struct pci_dn *pdn = PCI_DN(dn); > > + struct pci_dev *pdev; > > > > - return pci_get_domain_bus_and_slot(pci_domain_nr(pdn->phb->bus), > > + pdev = pci_get_domain_bus_and_slot(pci_domain_nr(pdn->phb->bus), > > pdn->busno, pdn->devfn); > > + > > + /* > > + * pci_get_domain_bus_and_slot() increased the reference count of > > + * the PCI device, but callers don't need that actually as the PE > > + * already holds a reference to the device. > > Imho this would be just enough. > > Anyway, > > Reviewed-by: Alexey Kardashevskiy <aik(a)ozlabs.ru> > Thanks ! I now realize that I forgot to add the --cc option for stable on my stgit command line :-\. Cc'ing now. > > How did you find it? :) > While reading code to find some inspiration for OpenCAPI passthrough. :) I saw the following in vfio_pci_ibm_npu2_init(): if (!pnv_pci_get_gpu_dev(vdev->pdev)) return -ENODEV; and simply followed the function calls. > > > Since callers aren't > > + * aware of the reference count change, call pci_dev_put() now to > > + * avoid leaks. > > + */ > > + if (pdev) > > + pci_dev_put(pdev); > > + > > + return pdev; > > } > > > > /* Given a NPU device get the associated PCI device. */ > > >

5 years, 9 months

2
3
0 0

✅ PASS: Stable queue: queue-4.19

by CKI Project

Hello, We ran automated tests on a patchset that was proposed for merging into this kernel tree. The patches were applied to: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 9c2556f428cf - Linux 4.19.42 The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Merge testing ------------- We cloned this repository and checked out the following commit: Repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 9c2556f428cf - Linux 4.19.42 We then merged the patchset with `git am`: bfq-update-internal-depth-state-when-queue-depth-cha.patch platform-x86-sony-laptop-fix-unintentional-fall-through.patch platform-x86-thinkpad_acpi-disable-bluetooth-for-some-machines.patch platform-x86-dell-laptop-fix-rfkill-functionality.patch hwmon-pwm-fan-disable-pwm-if-fetching-cooling-data-fails.patch kernfs-fix-barrier-usage-in-__kernfs_new_node.patch virt-vbox-sanity-check-parameter-types-for-hgcm-calls-coming-from-userspace.patch usb-serial-fix-unthrottle-races.patch iio-adc-xilinx-fix-potential-use-after-free-on-remov.patch iio-adc-xilinx-fix-potential-use-after-free-on-probe.patch iio-adc-xilinx-prevent-touching-unclocked-h-w-on-rem.patch acpi-nfit-always-dump-_dsm-output-payload.patch libnvdimm-namespace-fix-a-potential-null-pointer-der.patch hid-input-add-mapping-for-expose-overview-key.patch hid-input-add-mapping-for-keyboard-brightness-up-dow.patch hid-input-add-mapping-for-toggle-display-key.patch libnvdimm-btt-fix-a-kmemdup-failure-check.patch s390-dasd-fix-capacity-calculation-for-large-volumes.patch mac80211-fix-unaligned-access-in-mesh-table-hash-fun.patch mac80211-increase-max_msg_len.patch cfg80211-handle-wmm-rules-in-regulatory-domain-inter.patch mac80211-fix-memory-accounting-with-a-msdu-aggregati.patch nl80211-add-nl80211_flag_clear_skb-flag-for-other-nl.patch libnvdimm-pmem-fix-a-possible-oob-access-when-read-a.patch s390-3270-fix-lockdep-false-positive-on-view-lock.patch drm-amd-display-extending-aux-sw-timeout.patch clocksource-drivers-npcm-select-timer_of.patch clocksource-drivers-oxnas-fix-ox820-compatible.patch selftests-fib_tests-fix-command-line-is-not-complete.patch misdn-check-address-length-before-reading-address-fa.patch vxge-fix-return-of-a-free-d-memblock-on-a-failed-dma.patch qede-fix-write-to-free-d-pointer-error-and-double-fr.patch afs-unlock-pages-for-__pagevec_release.patch drm-amd-display-if-one-stream-full-updates-full-upda.patch s390-pkey-add-one-more-argument-space-for-debug-feat.patch x86-build-lto-fix-truncated-.bss-with-fdata-sections.patch x86-reboot-efi-use-efi-reboot-for-acer-travelmate-x5.patch kvm-fix-spectrev1-gadgets.patch kvm-x86-avoid-misreporting-level-triggered-irqs-as-e.patch tools-lib-traceevent-fix-missing-equality-check-for-.patch ipmi-ipmi_si_hardcode.c-init-si_type-array-to-fix-a-.patch ocelot-don-t-sleep-in-atomic-context-irqs_disabled.patch scsi-aic7xxx-fix-eisa-support.patch mm-fix-inactive-list-balancing-between-numa-nodes-an.patch init-initialize-jump-labels-before-command-line-opti.patch selftests-netfilter-check-icmp-pkttoobig-errors-are-.patch ipvs-do-not-schedule-icmp-errors-from-tunnels.patch netfilter-ctnetlink-don-t-use-conntrack-expect-objec.patch netfilter-nf_tables-prevent-shift-wrap-in-nft_chain_.patch mips-perf-ath79-fix-perfcount-irq-assignment.patch s390-ctcm-fix-ctcm_new_device-error-return-code.patch drm-sun4i-set-device-driver-data-at-bind-time-for-us.patch drm-sun4i-fix-component-unbinding-and-component-mast.patch selftests-net-correct-the-return-value-for-run_netso.patch netfilter-fix-nf_l4proto_log_invalid-to-log-invalid-.patch gpu-ipu-v3-dp-fix-csc-handling.patch drm-imx-don-t-skip-dp-channel-disable-for-background.patch arm-8856-1-nommu-fix-ccr-register-faulty-initializat.patch spi-micrel-eth-switch-declare-missing-of-table.patch spi-st-st95hf-nfc-declare-missing-of-table.patch drm-sun4i-unbind-components-before-releasing-drm-and.patch input-synaptics-rmi4-fix-possible-double-free.patch rdma-hns-bugfix-for-mapping-user-db.patch mm-memory_hotplug.c-drop-memory-device-reference-aft.patch powerpc-smp-fix-nmi-ipi-timeout.patch powerpc-smp-fix-nmi-ipi-xmon-timeout.patch net-dsa-mv88e6xxx-fix-few-issues-in-mv88e6390x_port_.patch mm-memory.c-fix-modifying-of-page-protection-by-inse.patch usb-typec-fix-unchecked-return-value.patch netfilter-nf_tables-use-after-free-in-dynamic-operat.patch netfilter-nf_tables-add-missing-release_ops-in-error.patch net-fec-manage-ahb-clock-in-runtime-pm.patch mlxsw-spectrum_switchdev-add-mdb-entries-in-prepare-.patch mlxsw-core-do-not-use-wq_mem_reclaim-for-emad-workqu.patch mlxsw-core-do-not-use-wq_mem_reclaim-for-mlxsw-order.patch mlxsw-core-do-not-use-wq_mem_reclaim-for-mlxsw-workq.patch net-tls-fix-the-iv-leaks.patch net-strparser-partially-revert-strparser-call-skb_un.patch nfc-nci-add-some-bounds-checking-in-nci_hci_cmd_rece.patch nfc-nci-potential-off-by-one-in-pipes-array.patch x86-kprobes-avoid-kretprobe-recursion-bug.patch cw1200-fix-missing-unlock-on-error-in-cw1200_hw_scan.patch mwl8k-fix-rate_idx-underflow.patch rtlwifi-rtl8723ae-fix-missing-break-in-switch-statement.patch don-t-jump-to-compute_result-state-from-check_result-state.patch Compile testing --------------- We compiled the kernel for 4 architectures: aarch64: build options: -j25 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/aarch64/kernel-stable_queue_4.19-a… kernel build: https://artifacts.cki-project.org/builds/aarch64/kernel-stable_queue_4.19-a… ppc64le: build options: -j25 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable_queue_4.19-p… kernel build: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable_queue_4.19-p… s390x: build options: -j25 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/s390x/kernel-stable_queue_4.19-s39… kernel build: https://artifacts.cki-project.org/builds/s390x/kernel-stable_queue_4.19-s39… x86_64: build options: -j25 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/x86_64/kernel-stable_queue_4.19-x8… kernel build: https://artifacts.cki-project.org/builds/x86_64/kernel-stable_queue_4.19-x8… Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ AMTU (Abstract Machine Test Utility) [3] ✅ Ethernet drivers sanity [4] ✅ httpd: mod_ssl smoke sanity [5] ✅ iotop: sanity [6] ✅ tuned: tune-processes-through-perf [7] ✅ Usex - version 1.9-29 [8] ✅ lvm thinp sanity [9] ✅ Boot test [0] 🚧 ✅ audit: audit testsuite test [10] 🚧 ✅ stress: stress-ng [11] 🚧 ✅ selinux-policy: serge-testsuite [12] ppc64le: ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ AMTU (Abstract Machine Test Utility) [3] ✅ Ethernet drivers sanity [4] ✅ httpd: mod_ssl smoke sanity [5] ✅ iotop: sanity [6] ✅ tuned: tune-processes-through-perf [7] ✅ Usex - version 1.9-29 [8] ✅ lvm thinp sanity [9] ✅ Boot test [0] 🚧 ✅ audit: audit testsuite test [10] 🚧 ✅ stress: stress-ng [11] 🚧 ✅ selinux-policy: serge-testsuite [12] s390x: ✅ Boot test [0] ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ Ethernet drivers sanity [4] ✅ httpd: mod_ssl smoke sanity [5] ✅ iotop: sanity [6] ✅ tuned: tune-processes-through-perf [7] ✅ Usex - version 1.9-29 [8] ✅ lvm thinp sanity [9] 🚧 ✅ selinux-policy: serge-testsuite [12] 🚧 ✅ audit: audit testsuite test [10] 🚧 ✅ stress: stress-ng [11] x86_64: ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ AMTU (Abstract Machine Test Utility) [3] ✅ Ethernet drivers sanity [4] ✅ httpd: mod_ssl smoke sanity [5] ✅ iotop: sanity [6] ✅ tuned: tune-processes-through-perf [7] ✅ Usex - version 1.9-29 [8] ✅ lvm thinp sanity [9] ✅ Boot test [0] 🚧 ✅ audit: audit testsuite test [10] 🚧 ✅ stress: stress-ng [11] 🚧 ✅ selinux-policy: serge-testsuite [12] Test source: [0]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [1]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [2]: https://github.com/CKI-project/tests-beaker/archive/master.zip#filesystems/… [3]: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu [4]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [5]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/htt… [6]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/iot… [7]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/tun… [8]: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us… [9]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/lvm/… [10]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/aud… [11]: https://github.com/CKI-project/tests-beaker/archive/master.zip#stress/stres… [12]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/packages/se… Waived tests (marked with 🚧) ----------------------------- This test run included waived tests. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed.

5 years, 9 months

1
0
0 0

[PATCH] um: Don't hardcode path as it is architecture dependent

by Ritesh Raj Sarraf

Dear Stable Team, Request for inclusion into the stable branches of Linux. This change went into 4.20 but 4.19 is the LTS release that many of the Linux Vendors are rebasing on. Hence, it'd be nice to see this part of the LTS releases, at least 4.19. The current code fails to run on amd64 because of hardcoded reference to i386 Signed-off-by: Ritesh Raj Sarraf <rrs(a)researchut.com> Signed-off-by: Richard Weinberger <richard(a)nod.at> --- arch/um/drivers/port_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/um/drivers/port_user.c b/arch/um/drivers/port_user.c index 9a8e1b64c22e..5f56d11b886f 100644 --- a/arch/um/drivers/port_user.c +++ b/arch/um/drivers/port_user.c @@ -168,7 +168,7 @@ int port_connection(int fd, int *socket, int *pid_out) { int new, err; char *argv[] = { "/usr/sbin/in.telnetd", "-L", - "/usr/lib/uml/port-helper", NULL }; + OS_LIB_PATH "/uml/port-helper", NULL }; struct port_pre_exec_data data; new = accept(fd, NULL, 0); -- 2.20.1

5 years, 9 months

2
3
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror May 2019