May 2019 - Linux-stable-mirror

Re: [Bug 203597] New: kernel 4.9.175 fails to boot on a PowerMac G4 3,6 at early stage

by Christophe Leroy

Hi Greg, Could you please apply b45ba4a51cde29b2939365ef0c07ad34c8321789 to 4.9 since 51c3c62b58b357e8d35e4cc32f7b4ec907426fe3 was applied allthought marked for #4.13+ Thanks Christophe Le 13/05/2019 à 22:18, bugzilla-daemon(a)bugzilla.kernel.org a écrit : > https://bugzilla.kernel.org/show_bug.cgi?id=203597 > > Bug ID: 203597 > Summary: kernel 4.9.175 fails to boot on a PowerMac G4 3,6 at > early stage > Product: Platform Specific/Hardware > Version: 2.5 > Kernel Version: 4.9.175 > Hardware: PPC-32 > OS: Linux > Tree: Mainline > Status: NEW > Severity: normal > Priority: P1 > Component: PPC-32 > Assignee: platform_ppc-32(a)kernel-bugs.osdl.org > Reporter: erhard_f(a)mailbox.org > Regression: No > > Created attachment 282743 > --> https://bugzilla.kernel.org/attachment.cgi?id=282743&action=edit > kernel .config (PowerMac G4 MDD) > > Trying out older kernels on the G4 MDD I noticed recent 4.9.x freeze the > machine. Only message displayed in black letters on a white screen: > > done > found display : /pco@f0000000/ATY,AlteracParent@10/ATY,Alterac_B@1, > opening... > > > It's a hard freeze, RCU_CPU_STALL_TIMEOUT does not kick in. > > Tried other stable kernels, which all worked: > 4.19.37 > 4.14.114 > 4.4.179 > > So I suppose it's only a 4.9.x issue. Last working 4.9.x kernel I had in > service was 4.9.161. First one I spotted freezing was 4.9.171. A bisect gave me > the following commit: > > 1c38a84d45862be06ac418618981631eddbda741 is the first bad commit > commit 1c38a84d45862be06ac418618981631eddbda741 > Author: Michael Neuling <mikey(a)neuling.org> > Date: Thu Apr 11 21:45:59 2019 +1000 > > powerpc: Avoid code patching freed init sections > > commit 51c3c62b58b357e8d35e4cc32f7b4ec907426fe3 upstream. > > This stops us from doing code patching in init sections after they've > been freed. > > In this chain: > kvm_guest_init() -> > kvm_use_magic_page() -> > fault_in_pages_readable() -> > __get_user() -> > __get_user_nocheck() -> > barrier_nospec(); > > We have a code patching location at barrier_nospec() and > kvm_guest_init() is an init function. This whole chain gets inlined, > so when we free the init section (hence kvm_guest_init()), this code > goes away and hence should no longer be patched. > > We seen this as userspace memory corruption when using a memory > checker while doing partition migration testing on powervm (this > starts the code patching post migration via > /sys/kernel/mobility/migration). In theory, it could also happen when > using /sys/kernel/debug/powerpc/barrier_nospec. > > Cc: stable(a)vger.kernel.org # 4.13+ > Signed-off-by: Michael Neuling <mikey(a)neuling.org> > Reviewed-by: Nicholas Piggin <npiggin(a)gmail.com> > Reviewed-by: Christophe Leroy <christophe.leroy(a)c-s.fr> > Signed-off-by: Michael Ellerman <mpe(a)ellerman.id.au> > Signed-off-by: Sasha Levin <sashal(a)kernel.org> >

5 years, 9 months

2
1
0 0

✅ PASS: Stable queue: queue-4.19

by CKI Project

Hello, We ran automated tests on a patchset that was proposed for merging into this kernel tree. The patches were applied to: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 9c2556f428cf - Linux 4.19.42 The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Merge testing ------------- We cloned this repository and checked out the following commit: Repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 9c2556f428cf - Linux 4.19.42 We then merged the patchset with `git am`: bfq-update-internal-depth-state-when-queue-depth-cha.patch platform-x86-sony-laptop-fix-unintentional-fall-through.patch platform-x86-thinkpad_acpi-disable-bluetooth-for-some-machines.patch platform-x86-dell-laptop-fix-rfkill-functionality.patch hwmon-pwm-fan-disable-pwm-if-fetching-cooling-data-fails.patch kernfs-fix-barrier-usage-in-__kernfs_new_node.patch virt-vbox-sanity-check-parameter-types-for-hgcm-calls-coming-from-userspace.patch usb-serial-fix-unthrottle-races.patch iio-adc-xilinx-fix-potential-use-after-free-on-remov.patch iio-adc-xilinx-fix-potential-use-after-free-on-probe.patch iio-adc-xilinx-prevent-touching-unclocked-h-w-on-rem.patch acpi-nfit-always-dump-_dsm-output-payload.patch libnvdimm-namespace-fix-a-potential-null-pointer-der.patch hid-input-add-mapping-for-expose-overview-key.patch hid-input-add-mapping-for-keyboard-brightness-up-dow.patch hid-input-add-mapping-for-toggle-display-key.patch libnvdimm-btt-fix-a-kmemdup-failure-check.patch s390-dasd-fix-capacity-calculation-for-large-volumes.patch mac80211-fix-unaligned-access-in-mesh-table-hash-fun.patch mac80211-increase-max_msg_len.patch cfg80211-handle-wmm-rules-in-regulatory-domain-inter.patch mac80211-fix-memory-accounting-with-a-msdu-aggregati.patch nl80211-add-nl80211_flag_clear_skb-flag-for-other-nl.patch libnvdimm-pmem-fix-a-possible-oob-access-when-read-a.patch s390-3270-fix-lockdep-false-positive-on-view-lock.patch drm-amd-display-extending-aux-sw-timeout.patch clocksource-drivers-npcm-select-timer_of.patch clocksource-drivers-oxnas-fix-ox820-compatible.patch selftests-fib_tests-fix-command-line-is-not-complete.patch misdn-check-address-length-before-reading-address-fa.patch vxge-fix-return-of-a-free-d-memblock-on-a-failed-dma.patch qede-fix-write-to-free-d-pointer-error-and-double-fr.patch afs-unlock-pages-for-__pagevec_release.patch drm-amd-display-if-one-stream-full-updates-full-upda.patch s390-pkey-add-one-more-argument-space-for-debug-feat.patch x86-build-lto-fix-truncated-.bss-with-fdata-sections.patch x86-reboot-efi-use-efi-reboot-for-acer-travelmate-x5.patch kvm-fix-spectrev1-gadgets.patch kvm-x86-avoid-misreporting-level-triggered-irqs-as-e.patch tools-lib-traceevent-fix-missing-equality-check-for-.patch ipmi-ipmi_si_hardcode.c-init-si_type-array-to-fix-a-.patch ocelot-don-t-sleep-in-atomic-context-irqs_disabled.patch scsi-aic7xxx-fix-eisa-support.patch mm-fix-inactive-list-balancing-between-numa-nodes-an.patch init-initialize-jump-labels-before-command-line-opti.patch selftests-netfilter-check-icmp-pkttoobig-errors-are-.patch ipvs-do-not-schedule-icmp-errors-from-tunnels.patch netfilter-ctnetlink-don-t-use-conntrack-expect-objec.patch netfilter-nf_tables-prevent-shift-wrap-in-nft_chain_.patch mips-perf-ath79-fix-perfcount-irq-assignment.patch s390-ctcm-fix-ctcm_new_device-error-return-code.patch drm-sun4i-set-device-driver-data-at-bind-time-for-us.patch drm-sun4i-fix-component-unbinding-and-component-mast.patch selftests-net-correct-the-return-value-for-run_netso.patch netfilter-fix-nf_l4proto_log_invalid-to-log-invalid-.patch gpu-ipu-v3-dp-fix-csc-handling.patch drm-imx-don-t-skip-dp-channel-disable-for-background.patch arm-8856-1-nommu-fix-ccr-register-faulty-initializat.patch spi-micrel-eth-switch-declare-missing-of-table.patch spi-st-st95hf-nfc-declare-missing-of-table.patch drm-sun4i-unbind-components-before-releasing-drm-and.patch input-synaptics-rmi4-fix-possible-double-free.patch rdma-hns-bugfix-for-mapping-user-db.patch mm-memory_hotplug.c-drop-memory-device-reference-aft.patch powerpc-smp-fix-nmi-ipi-timeout.patch powerpc-smp-fix-nmi-ipi-xmon-timeout.patch net-dsa-mv88e6xxx-fix-few-issues-in-mv88e6390x_port_.patch mm-memory.c-fix-modifying-of-page-protection-by-inse.patch usb-typec-fix-unchecked-return-value.patch netfilter-nf_tables-use-after-free-in-dynamic-operat.patch netfilter-nf_tables-add-missing-release_ops-in-error.patch net-fec-manage-ahb-clock-in-runtime-pm.patch mlxsw-spectrum_switchdev-add-mdb-entries-in-prepare-.patch mlxsw-core-do-not-use-wq_mem_reclaim-for-emad-workqu.patch mlxsw-core-do-not-use-wq_mem_reclaim-for-mlxsw-order.patch mlxsw-core-do-not-use-wq_mem_reclaim-for-mlxsw-workq.patch net-tls-fix-the-iv-leaks.patch net-strparser-partially-revert-strparser-call-skb_un.patch nfc-nci-add-some-bounds-checking-in-nci_hci_cmd_rece.patch nfc-nci-potential-off-by-one-in-pipes-array.patch x86-kprobes-avoid-kretprobe-recursion-bug.patch Compile testing --------------- We compiled the kernel for 4 architectures: aarch64: build options: -j25 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/aarch64/kernel-stable_queue_4.19-a… kernel build: https://artifacts.cki-project.org/builds/aarch64/kernel-stable_queue_4.19-a… ppc64le: build options: -j25 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable_queue_4.19-p… kernel build: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable_queue_4.19-p… s390x: build options: -j25 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/s390x/kernel-stable_queue_4.19-s39… kernel build: https://artifacts.cki-project.org/builds/s390x/kernel-stable_queue_4.19-s39… x86_64: build options: -j25 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/x86_64/kernel-stable_queue_4.19-x8… kernel build: https://artifacts.cki-project.org/builds/x86_64/kernel-stable_queue_4.19-x8… Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: ✅ Boot test [0] ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ AMTU (Abstract Machine Test Utility) [3] ✅ Ethernet drivers sanity [4] ✅ httpd: mod_ssl smoke sanity [5] ✅ iotop: sanity [6] ✅ tuned: tune-processes-through-perf [7] ✅ Usex - version 1.9-29 [8] ✅ lvm thinp sanity [9] 🚧 ✅ selinux-policy: serge-testsuite [10] 🚧 ✅ audit: audit testsuite test [11] 🚧 ✅ stress: stress-ng [12] ppc64le: ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ AMTU (Abstract Machine Test Utility) [3] ✅ Ethernet drivers sanity [4] ✅ httpd: mod_ssl smoke sanity [5] ✅ iotop: sanity [6] ✅ tuned: tune-processes-through-perf [7] ✅ Usex - version 1.9-29 [8] ✅ lvm thinp sanity [9] ✅ Boot test [0] 🚧 ✅ audit: audit testsuite test [11] 🚧 ✅ stress: stress-ng [12] 🚧 ✅ selinux-policy: serge-testsuite [10] s390x: ✅ Boot test [0] ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ Ethernet drivers sanity [4] ✅ httpd: mod_ssl smoke sanity [5] ✅ iotop: sanity [6] ✅ tuned: tune-processes-through-perf [7] ✅ Usex - version 1.9-29 [8] ✅ lvm thinp sanity [9] 🚧 ✅ selinux-policy: serge-testsuite [10] 🚧 ✅ audit: audit testsuite test [11] 🚧 ✅ stress: stress-ng [12] x86_64: ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ AMTU (Abstract Machine Test Utility) [3] ✅ Ethernet drivers sanity [4] ✅ httpd: mod_ssl smoke sanity [5] ✅ iotop: sanity [6] ✅ tuned: tune-processes-through-perf [7] ✅ Usex - version 1.9-29 [8] ✅ lvm thinp sanity [9] ✅ Boot test [0] 🚧 ✅ audit: audit testsuite test [11] 🚧 ✅ stress: stress-ng [12] 🚧 ✅ selinux-policy: serge-testsuite [10] Test source: [0]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [1]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [2]: https://github.com/CKI-project/tests-beaker/archive/master.zip#filesystems/… [3]: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu [4]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [5]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/htt… [6]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/iot… [7]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/tun… [8]: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us… [9]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/lvm/… [10]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/packages/se… [11]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/aud… [12]: https://github.com/CKI-project/tests-beaker/archive/master.zip#stress/stres… Waived tests (marked with 🚧) ----------------------------- This test run included waived tests. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed.

5 years, 9 months

1
0
0 0

[patch 078/140] hugetlb: use same fault hash key for shared and private mappings

by akpm＠linux-foundation.org

From: Mike Kravetz <mike.kravetz(a)oracle.com> Subject: hugetlb: use same fault hash key for shared and private mappings hugetlb uses a fault mutex hash table to prevent page faults of the same pages concurrently. The key for shared and private mappings is different. Shared keys off address_space and file index. Private keys off mm and virtual address. Consider a private mappings of a populated hugetlbfs file. A fault will map the page from the file and if needed do a COW to map a writable page. Hugetlbfs hole punch uses the fault mutex to prevent mappings of file pages. It uses the address_space file index key. However, private mappings will use a different key and could race with this code to map the file page. This causes problems (BUG) for the page cache remove code as it expects the page to be unmapped. A sample stack is: page dumped because: VM_BUG_ON_PAGE(page_mapped(page)) kernel BUG at mm/filemap.c:169! ... RIP: 0010:unaccount_page_cache_page+0x1b8/0x200 ... Call Trace: __delete_from_page_cache+0x39/0x220 delete_from_page_cache+0x45/0x70 remove_inode_hugepages+0x13c/0x380 ? __add_to_page_cache_locked+0x162/0x380 hugetlbfs_fallocate+0x403/0x540 ? _cond_resched+0x15/0x30 ? __inode_security_revalidate+0x5d/0x70 ? selinux_file_permission+0x100/0x130 vfs_fallocate+0x13f/0x270 ksys_fallocate+0x3c/0x80 __x64_sys_fallocate+0x1a/0x20 do_syscall_64+0x5b/0x180 entry_SYSCALL_64_after_hwframe+0x44/0xa9 There seems to be another potential COW issue/race with this approach of different private and shared keys as noted in commit 8382d914ebf7 ("mm, hugetlb: improve page-fault scalability"). Since every hugetlb mapping (even anon and private) is actually a file mapping, just use the address_space index key for all mappings. This results in potentially more hash collisions. However, this should not be the common case. Link: http://lkml.kernel.org/r/20190328234704.27083-3-mike.kravetz@oracle.com Link: http://lkml.kernel.org/r/20190412165235.t4sscoujczfhuiyt@linux-r8p5 Fixes: b5cec28d36f5 ("hugetlbfs: truncate_hugepages() takes a range of pages") Signed-off-by: Mike Kravetz <mike.kravetz(a)oracle.com> Reviewed-by: Naoya Horiguchi <n-horiguchi(a)ah.jp.nec.com> Reviewed-by: Davidlohr Bueso <dbueso(a)suse.de> Cc: Joonsoo Kim <iamjoonsoo.kim(a)lge.com> Cc: "Kirill A . Shutemov" <kirill.shutemov(a)linux.intel.com> Cc: Michal Hocko <mhocko(a)kernel.org> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- fs/hugetlbfs/inode.c | 7 ++----- include/linux/hugetlb.h | 4 +--- mm/hugetlb.c | 22 ++++++---------------- mm/userfaultfd.c | 3 +-- 4 files changed, 10 insertions(+), 26 deletions(-) --- a/fs/hugetlbfs/inode.c~hugetlb-use-same-fault-hash-key-for-shared-and-private-mappings +++ a/fs/hugetlbfs/inode.c @@ -440,9 +440,7 @@ static void remove_inode_hugepages(struc u32 hash; index = page->index; - hash = hugetlb_fault_mutex_hash(h, current->mm, - &pseudo_vma, - mapping, index, 0); + hash = hugetlb_fault_mutex_hash(h, mapping, index, 0); mutex_lock(&hugetlb_fault_mutex_table[hash]); /* @@ -639,8 +637,7 @@ static long hugetlbfs_fallocate(struct f addr = index * hpage_size; /* mutex taken here, fault path and hole punch */ - hash = hugetlb_fault_mutex_hash(h, mm, &pseudo_vma, mapping, - index, addr); + hash = hugetlb_fault_mutex_hash(h, mapping, index, addr); mutex_lock(&hugetlb_fault_mutex_table[hash]); /* See if already present in mapping to avoid alloc/free */ --- a/include/linux/hugetlb.h~hugetlb-use-same-fault-hash-key-for-shared-and-private-mappings +++ a/include/linux/hugetlb.h @@ -123,9 +123,7 @@ void move_hugetlb_state(struct page *old void free_huge_page(struct page *page); void hugetlb_fix_reserve_counts(struct inode *inode); extern struct mutex *hugetlb_fault_mutex_table; -u32 hugetlb_fault_mutex_hash(struct hstate *h, struct mm_struct *mm, - struct vm_area_struct *vma, - struct address_space *mapping, +u32 hugetlb_fault_mutex_hash(struct hstate *h, struct address_space *mapping, pgoff_t idx, unsigned long address); pte_t *huge_pmd_share(struct mm_struct *mm, unsigned long addr, pud_t *pud); --- a/mm/hugetlb.c~hugetlb-use-same-fault-hash-key-for-shared-and-private-mappings +++ a/mm/hugetlb.c @@ -3824,8 +3824,7 @@ retry: * handling userfault. Reacquire after handling * fault to make calling code simpler. */ - hash = hugetlb_fault_mutex_hash(h, mm, vma, mapping, - idx, haddr); + hash = hugetlb_fault_mutex_hash(h, mapping, idx, haddr); mutex_unlock(&hugetlb_fault_mutex_table[hash]); ret = handle_userfault(&vmf, VM_UFFD_MISSING); mutex_lock(&hugetlb_fault_mutex_table[hash]); @@ -3933,21 +3932,14 @@ backout_unlocked: } #ifdef CONFIG_SMP -u32 hugetlb_fault_mutex_hash(struct hstate *h, struct mm_struct *mm, - struct vm_area_struct *vma, - struct address_space *mapping, +u32 hugetlb_fault_mutex_hash(struct hstate *h, struct address_space *mapping, pgoff_t idx, unsigned long address) { unsigned long key[2]; u32 hash; - if (vma->vm_flags & VM_SHARED) { - key[0] = (unsigned long) mapping; - key[1] = idx; - } else { - key[0] = (unsigned long) mm; - key[1] = address >> huge_page_shift(h); - } + key[0] = (unsigned long) mapping; + key[1] = idx; hash = jhash2((u32 *)&key, sizeof(key)/sizeof(u32), 0); @@ -3958,9 +3950,7 @@ u32 hugetlb_fault_mutex_hash(struct hsta * For uniprocesor systems we always use a single mutex, so just * return 0 and avoid the hashing overhead. */ -u32 hugetlb_fault_mutex_hash(struct hstate *h, struct mm_struct *mm, - struct vm_area_struct *vma, - struct address_space *mapping, +u32 hugetlb_fault_mutex_hash(struct hstate *h, struct address_space *mapping, pgoff_t idx, unsigned long address) { return 0; @@ -4005,7 +3995,7 @@ vm_fault_t hugetlb_fault(struct mm_struc * get spurious allocation failures if two CPUs race to instantiate * the same page in the page cache. */ - hash = hugetlb_fault_mutex_hash(h, mm, vma, mapping, idx, haddr); + hash = hugetlb_fault_mutex_hash(h, mapping, idx, haddr); mutex_lock(&hugetlb_fault_mutex_table[hash]); entry = huge_ptep_get(ptep); --- a/mm/userfaultfd.c~hugetlb-use-same-fault-hash-key-for-shared-and-private-mappings +++ a/mm/userfaultfd.c @@ -271,8 +271,7 @@ retry: */ idx = linear_page_index(dst_vma, dst_addr); mapping = dst_vma->vm_file->f_mapping; - hash = hugetlb_fault_mutex_hash(h, dst_mm, dst_vma, mapping, - idx, dst_addr); + hash = hugetlb_fault_mutex_hash(h, mapping, idx, dst_addr); mutex_lock(&hugetlb_fault_mutex_table[hash]); err = -ENOMEM; _

5 years, 9 months

1
0
0 0

[patch 008/140] ocfs2: fix ocfs2 read inode data panic in ocfs2_iget

by akpm＠linux-foundation.org

From: Shuning Zhang <sunny.s.zhang(a)oracle.com> Subject: ocfs2: fix ocfs2 read inode data panic in ocfs2_iget In some cases, ocfs2_iget() reads the data of inode, which has been deleted for some reason. That will make the system panic. So We should judge whether this inode has been deleted, and tell the caller that the inode is a bad inode. For example, the ocfs2 is used as the backed of nfs, and the client is nfsv3. This issue can be reproduced by the following steps. on the nfs server side, ..../patha/pathb Step 1: The process A was scheduled before calling the function fh_verify. Step 2: The process B is removing the 'pathb', and just completed the call to function dput. Then the dentry of 'pathb' has been deleted from the dcache, and all ancestors have been deleted also. The relationship of dentry and inode was deleted through the function hlist_del_init. The following is the call stack. dentry_iput->hlist_del_init(&dentry->d_u.d_alias) At this time, the inode is still in the dcache. Step 3: The process A call the function ocfs2_get_dentry, which get the inode from dcache. Then the refcount of inode is 1. The following is the call stack. nfsd3_proc_getacl->fh_verify->exportfs_decode_fh->fh_to_dentry(ocfs2_get_dentry) Step 4: Dirty pages are flushed by bdi threads. So the inode of 'patha' is evicted, and this directory was deleted. But the inode of 'pathb' can't be evicted, because the refcount of the inode was 1. Step 5: The process A keep running, and call the function reconnect_path(in exportfs_decode_fh), which call function ocfs2_get_parent of ocfs2. Get the block number of parent directory(patha) by the name of ... Then read the data from disk by the block number. But this inode has been deleted, so the system panic. Process A Process B 1. in nfsd3_proc_getacl | 2. | dput 3. fh_to_dentry(ocfs2_get_dentry) | 4. bdi flush dirty cache | 5. ocfs2_iget | [283465.542049] OCFS2: ERROR (device sdp): ocfs2_validate_inode_block: Invalid dinode #580640: OCFS2_VALID_FL not set [283465.545490] Kernel panic - not syncing: OCFS2: (device sdp): panic forced after error [283465.546889] CPU: 5 PID: 12416 Comm: nfsd Tainted: G W 4.1.12-124.18.6.el6uek.bug28762940v3.x86_64 #2 [283465.548382] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 09/21/2015 [283465.549657] 0000000000000000 ffff8800a56fb7b8 ffffffff816e839c ffffffffa0514758 [283465.550392] 000000000008dc20 ffff8800a56fb838 ffffffff816e62d3 0000000000000008 [283465.551056] ffff880000000010 ffff8800a56fb848 ffff8800a56fb7e8 ffff88005df9f000 [283465.551710] Call Trace: [283465.552516] [<ffffffff816e839c>] dump_stack+0x63/0x81 [283465.553291] [<ffffffff816e62d3>] panic+0xcb/0x21b [283465.554037] [<ffffffffa04e66b0>] ocfs2_handle_error+0xf0/0xf0 [ocfs2] [283465.554882] [<ffffffffa04e7737>] __ocfs2_error+0x67/0x70 [ocfs2] [283465.555768] [<ffffffffa049c0f9>] ocfs2_validate_inode_block+0x229/0x230 [ocfs2] [283465.556683] [<ffffffffa047bcbc>] ocfs2_read_blocks+0x46c/0x7b0 [ocfs2] [283465.557408] [<ffffffffa049bed0>] ? ocfs2_inode_cache_io_unlock+0x20/0x20 [ocfs2] [283465.557973] [<ffffffffa049f0eb>] ocfs2_read_inode_block_full+0x3b/0x60 [ocfs2] [283465.558525] [<ffffffffa049f5ba>] ocfs2_iget+0x4aa/0x880 [ocfs2] [283465.559082] [<ffffffffa049146e>] ocfs2_get_parent+0x9e/0x220 [ocfs2] [283465.559622] [<ffffffff81297c05>] reconnect_path+0xb5/0x300 [283465.560156] [<ffffffff81297f46>] exportfs_decode_fh+0xf6/0x2b0 [283465.560708] [<ffffffffa062faf0>] ? nfsd_proc_getattr+0xa0/0xa0 [nfsd] [283465.561262] [<ffffffff810a8196>] ? prepare_creds+0x26/0x110 [283465.561932] [<ffffffffa0630860>] fh_verify+0x350/0x660 [nfsd] [283465.562862] [<ffffffffa0637804>] ? nfsd_cache_lookup+0x44/0x630 [nfsd] [283465.563697] [<ffffffffa063a8b9>] nfsd3_proc_getattr+0x69/0xf0 [nfsd] [283465.564510] [<ffffffffa062cf60>] nfsd_dispatch+0xe0/0x290 [nfsd] [283465.565358] [<ffffffffa05eb892>] ? svc_tcp_adjust_wspace+0x12/0x30 [sunrpc] [283465.566272] [<ffffffffa05ea652>] svc_process_common+0x412/0x6a0 [sunrpc] [283465.567155] [<ffffffffa05eaa03>] svc_process+0x123/0x210 [sunrpc] [283465.568020] [<ffffffffa062c90f>] nfsd+0xff/0x170 [nfsd] [283465.568962] [<ffffffffa062c810>] ? nfsd_destroy+0x80/0x80 [nfsd] [283465.570112] [<ffffffff810a622b>] kthread+0xcb/0xf0 [283465.571099] [<ffffffff810a6160>] ? kthread_create_on_node+0x180/0x180 [283465.572114] [<ffffffff816f11b8>] ret_from_fork+0x58/0x90 [283465.573156] [<ffffffff810a6160>] ? kthread_create_on_node+0x180/0x180 Link: http://lkml.kernel.org/r/1554185919-3010-1-git-send-email-sunny.s.zhang@ora… Signed-off-by: Shuning Zhang <sunny.s.zhang(a)oracle.com> Reviewed-by: Joseph Qi <jiangqi903(a)gmail.com> Cc: Mark Fasheh <mark(a)fasheh.com> Cc: Joel Becker <jlbec(a)evilplan.org> Cc: Junxiao Bi <junxiao.bi(a)oracle.com> Cc: Changwei Ge <gechangwei(a)live.cn> Cc: piaojun <piaojun(a)huawei.com> Cc: "Gang He" <ghe(a)suse.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- fs/ocfs2/export.c | 30 +++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) --- a/fs/ocfs2/export.c~ocfs2-fix-ocfs2-read-inode-data-panic-in-ocfs2_iget +++ a/fs/ocfs2/export.c @@ -148,16 +148,24 @@ static struct dentry *ocfs2_get_parent(s u64 blkno; struct dentry *parent; struct inode *dir = d_inode(child); + int set; trace_ocfs2_get_parent(child, child->d_name.len, child->d_name.name, (unsigned long long)OCFS2_I(dir)->ip_blkno); + status = ocfs2_nfs_sync_lock(OCFS2_SB(dir->i_sb), 1); + if (status < 0) { + mlog(ML_ERROR, "getting nfs sync lock(EX) failed %d\n", status); + parent = ERR_PTR(status); + goto bail; + } + status = ocfs2_inode_lock(dir, NULL, 0); if (status < 0) { if (status != -ENOENT) mlog_errno(status); parent = ERR_PTR(status); - goto bail; + goto unlock_nfs_sync; } status = ocfs2_lookup_ino_from_name(dir, "..", 2, &blkno); @@ -166,11 +174,31 @@ static struct dentry *ocfs2_get_parent(s goto bail_unlock; } + status = ocfs2_test_inode_bit(OCFS2_SB(dir->i_sb), blkno, &set); + if (status < 0) { + if (status == -EINVAL) { + status = -ESTALE; + } else + mlog(ML_ERROR, "test inode bit failed %d\n", status); + parent = ERR_PTR(status); + goto bail_unlock; + } + + trace_ocfs2_get_dentry_test_bit(status, set); + if (!set) { + status = -ESTALE; + parent = ERR_PTR(status); + goto bail_unlock; + } + parent = d_obtain_alias(ocfs2_iget(OCFS2_SB(dir->i_sb), blkno, 0, 0)); bail_unlock: ocfs2_inode_unlock(dir, 0); +unlock_nfs_sync: + ocfs2_nfs_sync_unlock(OCFS2_SB(dir->i_sb), 1); + bail: trace_ocfs2_get_parent_end(parent); _

5 years, 9 months

1
0
0 0

[patch 002/140] mm/hugetlb.c: don't put_page in lock of hugetlb_lock

by akpm＠linux-foundation.org

From: Kai Shen <shenkai8(a)huawei.com> Subject: mm/hugetlb.c: don't put_page in lock of hugetlb_lock spinlock recursion happened when do LTP test: #!/bin/bash ./runltp -p -f hugetlb & ./runltp -p -f hugetlb & ./runltp -p -f hugetlb & ./runltp -p -f hugetlb & ./runltp -p -f hugetlb & The dtor returned by get_compound_page_dtor in __put_compound_page may be the function of free_huge_page which will lock the hugetlb_lock, so don't put_page in lock of hugetlb_lock. BUG: spinlock recursion on CPU#0, hugemmap05/1079 lock: hugetlb_lock+0x0/0x18, .magic: dead4ead, .owner: hugemmap05/1079, .owner_cpu: 0 Call trace: dump_backtrace+0x0/0x198 show_stack+0x24/0x30 dump_stack+0xa4/0xcc spin_dump+0x84/0xa8 do_raw_spin_lock+0xd0/0x108 _raw_spin_lock+0x20/0x30 free_huge_page+0x9c/0x260 __put_compound_page+0x44/0x50 __put_page+0x2c/0x60 alloc_surplus_huge_page.constprop.19+0xf0/0x140 hugetlb_acct_memory+0x104/0x378 hugetlb_reserve_pages+0xe0/0x250 hugetlbfs_file_mmap+0xc0/0x140 mmap_region+0x3e8/0x5b0 do_mmap+0x280/0x460 vm_mmap_pgoff+0xf4/0x128 ksys_mmap_pgoff+0xb4/0x258 __arm64_sys_mmap+0x34/0x48 el0_svc_common+0x78/0x130 el0_svc_handler+0x38/0x78 el0_svc+0x8/0xc Link: http://lkml.kernel.org/r/b8ade452-2d6b-0372-32c2-703644032b47@huawei.com Fixes: 9980d744a0 ("mm, hugetlb: get rid of surplus page accounting tricks") Signed-off-by: Kai Shen <shenkai8(a)huawei.com> Signed-off-by: Feilong Lin <linfeilong(a)huawei.com> Reported-by: Wang Wang <wangwang2(a)huawei.com> Reviewed-by: Oscar Salvador <osalvador(a)suse.de> Reviewed-by: Mike Kravetz <mike.kravetz(a)oracle.com> Reviewed-by: Andrew Morton <akpm(a)linux-foundation.org> Acked-by: Michal Hocko <mhocko(a)suse.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- mm/hugetlb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/mm/hugetlb.c~mm-hugetlb-dont-put_page-in-lock-of-hugetlb_lock +++ a/mm/hugetlb.c @@ -1574,8 +1574,9 @@ static struct page *alloc_surplus_huge_p */ if (h->surplus_huge_pages >= h->nr_overcommit_huge_pages) { SetPageHugeTemporary(page); + spin_unlock(&hugetlb_lock); put_page(page); - page = NULL; + return NULL; } else { h->surplus_huge_pages++; h->surplus_huge_pages_node[page_to_nid(page)]++; _

5 years, 9 months

1
0
0 0

[patch 001/140] mm/huge_memory: fix vmf_insert_pfn_{pmd, pud}() crash, handle unaligned addresses

by akpm＠linux-foundation.org

From: Dan Williams <dan.j.williams(a)intel.com> Subject: mm/huge_memory: fix vmf_insert_pfn_{pmd, pud}() crash, handle unaligned addresses Starting with c6f3c5ee40c1 ("mm/huge_memory.c: fix modifying of page protection by insert_pfn_pmd()") vmf_insert_pfn_pmd() internally calls pmdp_set_access_flags(). That helper enforces a pmd aligned @address argument via VM_BUG_ON() assertion. Update the implementation to take a 'struct vm_fault' argument directly and apply the address alignment fixup internally to fix crash signatures like: kernel BUG at arch/x86/mm/pgtable.c:515! invalid opcode: 0000 [#1] SMP NOPTI CPU: 51 PID: 43713 Comm: java Tainted: G OE 4.19.35 #1 [..] RIP: 0010:pmdp_set_access_flags+0x48/0x50 [..] Call Trace: vmf_insert_pfn_pmd+0x198/0x350 dax_iomap_fault+0xe82/0x1190 ext4_dax_huge_fault+0x103/0x1f0 ? __switch_to_asm+0x40/0x70 __handle_mm_fault+0x3f6/0x1370 ? __switch_to_asm+0x34/0x70 ? __switch_to_asm+0x40/0x70 handle_mm_fault+0xda/0x200 __do_page_fault+0x249/0x4f0 do_page_fault+0x32/0x110 ? page_fault+0x8/0x30 page_fault+0x1e/0x30 Link: http://lkml.kernel.org/r/155741946350.372037.11148198430068238140.stgit@dwi… Fixes: c6f3c5ee40c1 ("mm/huge_memory.c: fix modifying of page protection by insert_pfn_pmd()") Signed-off-by: Dan Williams <dan.j.williams(a)intel.com> Reported-by: Piotr Balcer <piotr.balcer(a)intel.com> Tested-by: Yan Ma <yan.ma(a)intel.com> Tested-by: Pankaj Gupta <pagupta(a)redhat.com> Reviewed-by: Matthew Wilcox <willy(a)infradead.org> Reviewed-by: Jan Kara <jack(a)suse.cz> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar(a)linux.ibm.com> Cc: Chandan Rajendra <chandan(a)linux.ibm.com> Cc: Souptick Joarder <jrdr.linux(a)gmail.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- drivers/dax/device.c | 6 ++---- fs/dax.c | 6 ++---- include/linux/huge_mm.h | 6 ++---- mm/huge_memory.c | 16 ++++++++++------ 4 files changed, 16 insertions(+), 18 deletions(-) --- a/drivers/dax/device.c~mm-huge_memory-fix-vmf_insert_pfn_pmd-pud-crash-handle-unaligned-addresses +++ a/drivers/dax/device.c @@ -184,8 +184,7 @@ static vm_fault_t __dev_dax_pmd_fault(st *pfn = phys_to_pfn_t(phys, dax_region->pfn_flags); - return vmf_insert_pfn_pmd(vmf->vma, vmf->address, vmf->pmd, *pfn, - vmf->flags & FAULT_FLAG_WRITE); + return vmf_insert_pfn_pmd(vmf, *pfn, vmf->flags & FAULT_FLAG_WRITE); } #ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD @@ -235,8 +234,7 @@ static vm_fault_t __dev_dax_pud_fault(st *pfn = phys_to_pfn_t(phys, dax_region->pfn_flags); - return vmf_insert_pfn_pud(vmf->vma, vmf->address, vmf->pud, *pfn, - vmf->flags & FAULT_FLAG_WRITE); + return vmf_insert_pfn_pud(vmf, *pfn, vmf->flags & FAULT_FLAG_WRITE); } #else static vm_fault_t __dev_dax_pud_fault(struct dev_dax *dev_dax, --- a/fs/dax.c~mm-huge_memory-fix-vmf_insert_pfn_pmd-pud-crash-handle-unaligned-addresses +++ a/fs/dax.c @@ -1575,8 +1575,7 @@ static vm_fault_t dax_iomap_pmd_fault(st } trace_dax_pmd_insert_mapping(inode, vmf, PMD_SIZE, pfn, entry); - result = vmf_insert_pfn_pmd(vma, vmf->address, vmf->pmd, pfn, - write); + result = vmf_insert_pfn_pmd(vmf, pfn, write); break; case IOMAP_UNWRITTEN: case IOMAP_HOLE: @@ -1686,8 +1685,7 @@ dax_insert_pfn_mkwrite(struct vm_fault * ret = vmf_insert_mixed_mkwrite(vmf->vma, vmf->address, pfn); #ifdef CONFIG_FS_DAX_PMD else if (order == PMD_ORDER) - ret = vmf_insert_pfn_pmd(vmf->vma, vmf->address, vmf->pmd, - pfn, true); + ret = vmf_insert_pfn_pmd(vmf, pfn, FAULT_FLAG_WRITE); #endif else ret = VM_FAULT_FALLBACK; --- a/include/linux/huge_mm.h~mm-huge_memory-fix-vmf_insert_pfn_pmd-pud-crash-handle-unaligned-addresses +++ a/include/linux/huge_mm.h @@ -47,10 +47,8 @@ extern bool move_huge_pmd(struct vm_area extern int change_huge_pmd(struct vm_area_struct *vma, pmd_t *pmd, unsigned long addr, pgprot_t newprot, int prot_numa); -vm_fault_t vmf_insert_pfn_pmd(struct vm_area_struct *vma, unsigned long addr, - pmd_t *pmd, pfn_t pfn, bool write); -vm_fault_t vmf_insert_pfn_pud(struct vm_area_struct *vma, unsigned long addr, - pud_t *pud, pfn_t pfn, bool write); +vm_fault_t vmf_insert_pfn_pmd(struct vm_fault *vmf, pfn_t pfn, bool write); +vm_fault_t vmf_insert_pfn_pud(struct vm_fault *vmf, pfn_t pfn, bool write); enum transparent_hugepage_flag { TRANSPARENT_HUGEPAGE_FLAG, TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, --- a/mm/huge_memory.c~mm-huge_memory-fix-vmf_insert_pfn_pmd-pud-crash-handle-unaligned-addresses +++ a/mm/huge_memory.c @@ -793,11 +793,13 @@ out_unlock: pte_free(mm, pgtable); } -vm_fault_t vmf_insert_pfn_pmd(struct vm_area_struct *vma, unsigned long addr, - pmd_t *pmd, pfn_t pfn, bool write) +vm_fault_t vmf_insert_pfn_pmd(struct vm_fault *vmf, pfn_t pfn, bool write) { + unsigned long addr = vmf->address & PMD_MASK; + struct vm_area_struct *vma = vmf->vma; pgprot_t pgprot = vma->vm_page_prot; pgtable_t pgtable = NULL; + /* * If we had pmd_special, we could avoid all these restrictions, * but we need to be consistent with PTEs and architectures that @@ -820,7 +822,7 @@ vm_fault_t vmf_insert_pfn_pmd(struct vm_ track_pfn_insert(vma, &pgprot, pfn); - insert_pfn_pmd(vma, addr, pmd, pfn, pgprot, write, pgtable); + insert_pfn_pmd(vma, addr, vmf->pmd, pfn, pgprot, write, pgtable); return VM_FAULT_NOPAGE; } EXPORT_SYMBOL_GPL(vmf_insert_pfn_pmd); @@ -869,10 +871,12 @@ out_unlock: spin_unlock(ptl); } -vm_fault_t vmf_insert_pfn_pud(struct vm_area_struct *vma, unsigned long addr, - pud_t *pud, pfn_t pfn, bool write) +vm_fault_t vmf_insert_pfn_pud(struct vm_fault *vmf, pfn_t pfn, bool write) { + unsigned long addr = vmf->address & PUD_MASK; + struct vm_area_struct *vma = vmf->vma; pgprot_t pgprot = vma->vm_page_prot; + /* * If we had pud_special, we could avoid all these restrictions, * but we need to be consistent with PTEs and architectures that @@ -889,7 +893,7 @@ vm_fault_t vmf_insert_pfn_pud(struct vm_ track_pfn_insert(vma, &pgprot, pfn); - insert_pfn_pud(vma, addr, pud, pfn, pgprot, write); + insert_pfn_pud(vma, addr, vmf->pud, pfn, pgprot, write); return VM_FAULT_NOPAGE; } EXPORT_SYMBOL_GPL(vmf_insert_pfn_pud); _

5 years, 9 months

1
0
0 0

✅ PASS: Stable queue: queue-4.19

by CKI Project

Hello, We ran automated tests on a patchset that was proposed for merging into this kernel tree. The patches were applied to: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 9c2556f428cf - Linux 4.19.42 The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Merge testing ------------- We cloned this repository and checked out the following commit: Repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 9c2556f428cf - Linux 4.19.42 We then merged the patchset with `git am`: bfq-update-internal-depth-state-when-queue-depth-cha.patch platform-x86-sony-laptop-fix-unintentional-fall-through.patch platform-x86-thinkpad_acpi-disable-bluetooth-for-some-machines.patch platform-x86-dell-laptop-fix-rfkill-functionality.patch hwmon-pwm-fan-disable-pwm-if-fetching-cooling-data-fails.patch kernfs-fix-barrier-usage-in-__kernfs_new_node.patch virt-vbox-sanity-check-parameter-types-for-hgcm-calls-coming-from-userspace.patch usb-serial-fix-unthrottle-races.patch iio-adc-xilinx-fix-potential-use-after-free-on-remov.patch iio-adc-xilinx-fix-potential-use-after-free-on-probe.patch iio-adc-xilinx-prevent-touching-unclocked-h-w-on-rem.patch acpi-nfit-always-dump-_dsm-output-payload.patch libnvdimm-namespace-fix-a-potential-null-pointer-der.patch hid-input-add-mapping-for-expose-overview-key.patch hid-input-add-mapping-for-keyboard-brightness-up-dow.patch hid-input-add-mapping-for-toggle-display-key.patch libnvdimm-btt-fix-a-kmemdup-failure-check.patch s390-dasd-fix-capacity-calculation-for-large-volumes.patch mac80211-fix-unaligned-access-in-mesh-table-hash-fun.patch mac80211-increase-max_msg_len.patch cfg80211-handle-wmm-rules-in-regulatory-domain-inter.patch mac80211-fix-memory-accounting-with-a-msdu-aggregati.patch nl80211-add-nl80211_flag_clear_skb-flag-for-other-nl.patch libnvdimm-pmem-fix-a-possible-oob-access-when-read-a.patch s390-3270-fix-lockdep-false-positive-on-view-lock.patch drm-amd-display-extending-aux-sw-timeout.patch clocksource-drivers-npcm-select-timer_of.patch clocksource-drivers-oxnas-fix-ox820-compatible.patch selftests-fib_tests-fix-command-line-is-not-complete.patch misdn-check-address-length-before-reading-address-fa.patch vxge-fix-return-of-a-free-d-memblock-on-a-failed-dma.patch qede-fix-write-to-free-d-pointer-error-and-double-fr.patch afs-unlock-pages-for-__pagevec_release.patch drm-amd-display-if-one-stream-full-updates-full-upda.patch s390-pkey-add-one-more-argument-space-for-debug-feat.patch x86-build-lto-fix-truncated-.bss-with-fdata-sections.patch x86-reboot-efi-use-efi-reboot-for-acer-travelmate-x5.patch kvm-x86-raise-gp-when-guest-vcpu-do-not-support-pmu.patch kvm-fix-spectrev1-gadgets.patch kvm-x86-avoid-misreporting-level-triggered-irqs-as-e.patch tools-lib-traceevent-fix-missing-equality-check-for-.patch ipmi-ipmi_si_hardcode.c-init-si_type-array-to-fix-a-.patch ocelot-don-t-sleep-in-atomic-context-irqs_disabled.patch scsi-aic7xxx-fix-eisa-support.patch mm-fix-inactive-list-balancing-between-numa-nodes-an.patch init-initialize-jump-labels-before-command-line-opti.patch selftests-netfilter-check-icmp-pkttoobig-errors-are-.patch ipvs-do-not-schedule-icmp-errors-from-tunnels.patch netfilter-ctnetlink-don-t-use-conntrack-expect-objec.patch netfilter-nf_tables-prevent-shift-wrap-in-nft_chain_.patch mips-perf-ath79-fix-perfcount-irq-assignment.patch s390-ctcm-fix-ctcm_new_device-error-return-code.patch drm-sun4i-set-device-driver-data-at-bind-time-for-us.patch drm-sun4i-fix-component-unbinding-and-component-mast.patch selftests-net-correct-the-return-value-for-run_netso.patch netfilter-fix-nf_l4proto_log_invalid-to-log-invalid-.patch gpu-ipu-v3-dp-fix-csc-handling.patch drm-imx-don-t-skip-dp-channel-disable-for-background.patch arm-8856-1-nommu-fix-ccr-register-faulty-initializat.patch spi-micrel-eth-switch-declare-missing-of-table.patch spi-st-st95hf-nfc-declare-missing-of-table.patch drm-sun4i-unbind-components-before-releasing-drm-and.patch input-synaptics-rmi4-fix-possible-double-free.patch rdma-hns-bugfix-for-mapping-user-db.patch mm-memory_hotplug.c-drop-memory-device-reference-aft.patch powerpc-smp-fix-nmi-ipi-timeout.patch powerpc-smp-fix-nmi-ipi-xmon-timeout.patch net-dsa-mv88e6xxx-fix-few-issues-in-mv88e6390x_port_.patch mm-memory.c-fix-modifying-of-page-protection-by-inse.patch usb-typec-fix-unchecked-return-value.patch netfilter-nf_tables-use-after-free-in-dynamic-operat.patch netfilter-nf_tables-add-missing-release_ops-in-error.patch net-fec-manage-ahb-clock-in-runtime-pm.patch mlxsw-spectrum_switchdev-add-mdb-entries-in-prepare-.patch mlxsw-core-do-not-use-wq_mem_reclaim-for-emad-workqu.patch mlxsw-core-do-not-use-wq_mem_reclaim-for-mlxsw-order.patch mlxsw-core-do-not-use-wq_mem_reclaim-for-mlxsw-workq.patch net-tls-fix-the-iv-leaks.patch net-strparser-partially-revert-strparser-call-skb_un.patch nfc-nci-add-some-bounds-checking-in-nci_hci_cmd_rece.patch nfc-nci-potential-off-by-one-in-pipes-array.patch x86-kprobes-avoid-kretprobe-recursion-bug.patch Compile testing --------------- We compiled the kernel for 4 architectures: aarch64: build options: -j25 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/aarch64/kernel-stable_queue_4.19-a… kernel build: https://artifacts.cki-project.org/builds/aarch64/kernel-stable_queue_4.19-a… ppc64le: build options: -j25 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable_queue_4.19-p… kernel build: https://artifacts.cki-project.org/builds/ppc64le/kernel-stable_queue_4.19-p… s390x: build options: -j25 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/s390x/kernel-stable_queue_4.19-s39… kernel build: https://artifacts.cki-project.org/builds/s390x/kernel-stable_queue_4.19-s39… x86_64: build options: -j25 INSTALL_MOD_STRIP=1 targz-pkg configuration: https://artifacts.cki-project.org/builds/x86_64/kernel-stable_queue_4.19-x8… kernel build: https://artifacts.cki-project.org/builds/x86_64/kernel-stable_queue_4.19-x8… Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: ✅ Boot test [0] ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ AMTU (Abstract Machine Test Utility) [3] ✅ Ethernet drivers sanity [4] ✅ httpd: mod_ssl smoke sanity [5] ✅ iotop: sanity [6] ✅ tuned: tune-processes-through-perf [7] ✅ Usex - version 1.9-29 [8] ✅ lvm thinp sanity [9] 🚧 ✅ selinux-policy: serge-testsuite [10] 🚧 ✅ audit: audit testsuite test [11] 🚧 ✅ stress: stress-ng [12] ppc64le: ✅ Boot test [0] ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ AMTU (Abstract Machine Test Utility) [3] ✅ Ethernet drivers sanity [4] ✅ httpd: mod_ssl smoke sanity [5] ✅ iotop: sanity [6] ✅ tuned: tune-processes-through-perf [7] ✅ Usex - version 1.9-29 [8] ✅ lvm thinp sanity [9] 🚧 ✅ selinux-policy: serge-testsuite [10] 🚧 ✅ audit: audit testsuite test [11] 🚧 ❎ stress: stress-ng [12] s390x: ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ Ethernet drivers sanity [4] ✅ httpd: mod_ssl smoke sanity [5] ✅ iotop: sanity [6] ✅ tuned: tune-processes-through-perf [7] ✅ Usex - version 1.9-29 [8] ✅ lvm thinp sanity [9] ✅ Boot test [0] 🚧 ✅ audit: audit testsuite test [11] 🚧 ✅ stress: stress-ng [12] 🚧 ✅ selinux-policy: serge-testsuite [10] x86_64: ✅ Boot test [0] ✅ Boot test [0] ✅ LTP lite [1] ✅ Loopdev Sanity [2] ✅ AMTU (Abstract Machine Test Utility) [3] ✅ Ethernet drivers sanity [4] ✅ httpd: mod_ssl smoke sanity [5] ✅ iotop: sanity [6] ✅ tuned: tune-processes-through-perf [7] ✅ Usex - version 1.9-29 [8] ✅ lvm thinp sanity [9] 🚧 ✅ selinux-policy: serge-testsuite [10] 🚧 ✅ audit: audit testsuite test [11] 🚧 ✅ stress: stress-ng [12] Test source: [0]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [1]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [2]: https://github.com/CKI-project/tests-beaker/archive/master.zip#filesystems/… [3]: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu [4]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [5]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/htt… [6]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/iot… [7]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/tun… [8]: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us… [9]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/lvm/… [10]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/packages/se… [11]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/aud… [12]: https://github.com/CKI-project/tests-beaker/archive/master.zip#stress/stres… Waived tests (marked with 🚧) ----------------------------- This test run included waived tests. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed.

5 years, 9 months

1
0
0 0

[PATCH] dm ioctl: fix hang in early create error condition

by Helen Koike

The dm_early_create() function (which deals with "dm-mod.create=" kernel command line option) calls dm_hash_insert() who gets an extra reference to the md object. In case of failure, this reference wasn't being released, causing dm_destroy() to hang, thus hanging the whole boot process. Fix this by calling __hash_remove() in the error path. Fixes: 6bbc923dfcf57d ("dm: add support to directly boot to a mapped device") Cc: stable(a)vger.kernel.org Signed-off-by: Helen Koike <helen.koike(a)collabora.com> --- Hi, I tested this patch by adding a new test case in the following test script: https://gitlab.collabora.com/koike/dm-cmdline-test/commit/d2d7a0ee4a49931cd… This test was failing, but with this patch it works correctly. Thanks Helen drivers/md/dm-ioctl.c | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c index c740153b4e52..31da18611a21 100644 --- a/drivers/md/dm-ioctl.c +++ b/drivers/md/dm-ioctl.c @@ -205,7 +205,8 @@ static void free_cell(struct hash_cell *hc) * The kdev_t and uuid of a device can never change once it is * initially inserted. */ -static int dm_hash_insert(const char *name, const char *uuid, struct mapped_device *md) +static struct hash_cell *dm_hash_insert(const char *name, const char *uuid, + struct mapped_device *md) { struct hash_cell *cell, *hc; @@ -214,7 +215,7 @@ static int dm_hash_insert(const char *name, const char *uuid, struct mapped_devi */ cell = alloc_cell(name, uuid, md); if (!cell) - return -ENOMEM; + return ERR_PTR(-ENOMEM); /* * Insert the cell into both hash tables. @@ -243,12 +244,12 @@ static int dm_hash_insert(const char *name, const char *uuid, struct mapped_devi mutex_unlock(&dm_hash_cells_mutex); up_write(&_hash_lock); - return 0; + return cell; bad: up_write(&_hash_lock); free_cell(cell); - return -EBUSY; + return ERR_PTR(-EBUSY); } static struct dm_table *__hash_remove(struct hash_cell *hc) @@ -747,6 +748,7 @@ static int dev_create(struct file *filp, struct dm_ioctl *param, size_t param_si { int r, m = DM_ANY_MINOR; struct mapped_device *md; + struct hash_cell *hc; r = check_name(param->name); if (r) @@ -759,11 +761,11 @@ static int dev_create(struct file *filp, struct dm_ioctl *param, size_t param_si if (r) return r; - r = dm_hash_insert(param->name, *param->uuid ? param->uuid : NULL, md); - if (r) { + hc = dm_hash_insert(param->name, *param->uuid ? param->uuid : NULL, md); + if (IS_ERR(hc)) { dm_put(md); dm_destroy(md); - return r; + return PTR_ERR(hc); } param->flags &= ~DM_INACTIVE_PRESENT_FLAG; @@ -2044,6 +2046,7 @@ int __init dm_early_create(struct dm_ioctl *dmi, int r, m = DM_ANY_MINOR; struct dm_table *t, *old_map; struct mapped_device *md; + struct hash_cell *hc; unsigned int i; if (!dmi->target_count) @@ -2062,14 +2065,14 @@ int __init dm_early_create(struct dm_ioctl *dmi, return r; /* hash insert */ - r = dm_hash_insert(dmi->name, *dmi->uuid ? dmi->uuid : NULL, md); - if (r) + hc = dm_hash_insert(dmi->name, *dmi->uuid ? dmi->uuid : NULL, md); + if (IS_ERR(hc)) goto err_destroy_dm; /* alloc table */ r = dm_table_create(&t, get_mode(dmi), dmi->target_count, md); if (r) - goto err_destroy_dm; + goto err_hash_remove; /* add targets */ for (i = 0; i < dmi->target_count; i++) { @@ -2116,6 +2119,8 @@ int __init dm_early_create(struct dm_ioctl *dmi, err_destroy_table: dm_table_destroy(t); +err_hash_remove: + __hash_remove(hc); err_destroy_dm: dm_put(md); dm_destroy(md); -- 2.20.1

5 years, 9 months

1
0
0 0

[tip:core/urgent] objtool: Fix function fallthrough detection

by tip-bot for Josh Poimboeuf

Commit-ID: e6f393bc939d566ce3def71232d8013de9aaadde Gitweb: https://git.kernel.org/tip/e6f393bc939d566ce3def71232d8013de9aaadde Author: Josh Poimboeuf <jpoimboe(a)redhat.com> AuthorDate: Mon, 13 May 2019 12:01:32 -0500 Committer: Ingo Molnar <mingo(a)kernel.org> CommitDate: Mon, 13 May 2019 20:31:17 +0200 objtool: Fix function fallthrough detection When a function falls through to the next function due to a compiler bug, objtool prints some obscure warnings. For example: drivers/regulator/core.o: warning: objtool: regulator_count_voltages()+0x95: return with modified stack frame drivers/regulator/core.o: warning: objtool: regulator_count_voltages()+0x0: stack state mismatch: cfa1=7+32 cfa2=7+8 Instead it should be printing: drivers/regulator/core.o: warning: objtool: regulator_supply_is_couple() falls through to next function regulator_count_voltages() This used to work, but was broken by the following commit: 13810435b9a7 ("objtool: Support GCC 8's cold subfunctions") The padding nops at the end of a function aren't actually part of the function, as defined by the symbol table. So the 'func' variable in validate_branch() is getting cleared to NULL when a padding nop is encountered, breaking the fallthrough detection. If the current instruction doesn't have a function associated with it, just consider it to be part of the previously detected function by not overwriting the previous value of 'func'. Reported-by: kbuild test robot <lkp(a)intel.com> Signed-off-by: Josh Poimboeuf <jpoimboe(a)redhat.com> Cc: Linus Torvalds <torvalds(a)linux-foundation.org> Cc: Peter Zijlstra <peterz(a)infradead.org> Cc: Thomas Gleixner <tglx(a)linutronix.de> Cc: <stable(a)vger.kernel.org> Fixes: 13810435b9a7 ("objtool: Support GCC 8's cold subfunctions") Link: http://lkml.kernel.org/r/546d143820cd08a46624ae8440d093dd6c902cae.155776671… Signed-off-by: Ingo Molnar <mingo(a)kernel.org> --- tools/objtool/check.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 90226791df6b..7325d89ccad9 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -1959,7 +1959,8 @@ static int validate_branch(struct objtool_file *file, struct instruction *first, return 1; } - func = insn->func ? insn->func->pfunc : NULL; + if (insn->func) + func = insn->func->pfunc; if (func && insn->ignore) { WARN_FUNC("BUG: why am I validating an ignored function?",

5 years, 9 months

1
0
0 0

Re: [PATCH] habanalabs: Avoid using a non-initialized MMU cache mutex

by Sasha Levin

On Mon, May 13, 2019 at 05:22:30PM +0300, Oded Gabbay wrote: >On Mon, May 13, 2019 at 5:10 PM Sasha Levin <sashal(a)kernel.org> wrote: >> >> Hi, >> >> [This is an automated email] >> >> This commit has been processed because it contains a -stable tag. >> The stable tag indicates that it's relevant for the following trees: all >> >> The bot has tested the following trees: v5.0.15, v4.19.42, v4.14.118, v4.9.175, v4.4.179, v3.18.139. >> >> v5.0.15: Failed to apply! Possible dependencies: >> 0861e41de530 ("habanalabs: add context and ASID modules") >> 839c48030d27 ("habanalabs: add basic Goya h/w initialization") >> 9494a8dd8d22 ("habanalabs: add h/w queues module") >> 99b9d7b4970c ("habanalabs: add basic Goya support") >> be5d926b5c10 ("habanalabs: add command buffer module") >> c4d66343a46a ("habanalabs: add skeleton driver") >> d91389bc839d ("habanalabs: add sysfs and hwmon support") >> eff6f4a0e70b ("habanalabs: add command submission module") >> >> v4.19.42: Failed to apply! Possible dependencies: >> 0861e41de530 ("habanalabs: add context and ASID modules") >> 839c48030d27 ("habanalabs: add basic Goya h/w initialization") >> 9494a8dd8d22 ("habanalabs: add h/w queues module") >> 99b9d7b4970c ("habanalabs: add basic Goya support") >> be5d926b5c10 ("habanalabs: add command buffer module") >> c4d66343a46a ("habanalabs: add skeleton driver") >> fcb418cd567f ("pvpanic: move pvpanic to misc as common driver") >> >> v4.14.118: Failed to apply! Possible dependencies: >> 01451ad47e27 ("powerpc/powermac: Use setup_timer() helper") >> 8275b77a1513 ("mfd: rts5249: Add support for RTS5250S power saving") >> 83ad1e6a1dc0 ("powerpc/oprofile: Use setup_timer() helper") >> 8d6b1bf20f61 ("powerpc/6xx: Use setup_timer() helper") >> 9494a8dd8d22 ("habanalabs: add h/w queues module") >> b1fc2839d2f9 ("drm/msm: Implement preemption for A5XX targets") >> b9eaf1872222 ("treewide: init_timer() -> setup_timer()") >> be5d926b5c10 ("habanalabs: add command buffer module") >> c4d66343a46a ("habanalabs: add skeleton driver") >> cd414f3d9316 ("drm/msm: Move memptrs to msm_gpu") >> e455b69ddf9b ("misc: rtsx: Move Realtek Card Reader Driver to misc") >> e629cfa36ea0 ("MIPS: Lasat: Use setup_timer() helper") >> e99e88a9d2b0 ("treewide: setup_timer() -> timer_setup()") >> f97decac5f4c ("drm/msm: Support multiple ringbuffers") >> >> v4.9.175: Failed to apply! Possible dependencies: >> 01451ad47e27 ("powerpc/powermac: Use setup_timer() helper") >> 118f6523793d ("mfd: rtsx: Convert forgotten dev_info() statement to pcr_dbg()") >> 53460c53b761 ("[media] au0828: Add timer to restart TS stream if no data arrives on bulk endpoint") >> 7c96f59e0caf ("[media] s5p-mfc: Fix initialization of internal structures") >> 8275b77a1513 ("mfd: rts5249: Add support for RTS5250S power saving") >> 83ad1e6a1dc0 ("powerpc/oprofile: Use setup_timer() helper") >> 87d284443d07 ("mfd: rtsx: Do retry when DMA transfer error") >> 8d6b1bf20f61 ("powerpc/6xx: Use setup_timer() helper") >> 9494a8dd8d22 ("habanalabs: add h/w queues module") >> b9eaf1872222 ("treewide: init_timer() -> setup_timer()") >> be5d926b5c10 ("habanalabs: add command buffer module") >> c4d66343a46a ("habanalabs: add skeleton driver") >> cf43e6be865a ("block: add scalable completion tracking of requests") >> e26ae3660b9c ("mfd: rtsx: Make arrays depth and cd_mask static const") >> e455b69ddf9b ("misc: rtsx: Move Realtek Card Reader Driver to misc") >> e629cfa36ea0 ("MIPS: Lasat: Use setup_timer() helper") >> e806402130c9 ("block: split out request-only flags into a new namespace") >> e99e88a9d2b0 ("treewide: setup_timer() -> timer_setup()") >> >> v4.4.179: Failed to apply! Possible dependencies: >> 118f6523793d ("mfd: rtsx: Convert forgotten dev_info() statement to pcr_dbg()") >> 53460c53b761 ("[media] au0828: Add timer to restart TS stream if no data arrives on bulk endpoint") >> 7c96f59e0caf ("[media] s5p-mfc: Fix initialization of internal structures") >> 80c1bce9aa31 ("[media] au0828: Refactoring for start_urb_transfer()") >> 8275b77a1513 ("mfd: rts5249: Add support for RTS5250S power saving") >> 87d284443d07 ("mfd: rtsx: Do retry when DMA transfer error") >> 9494a8dd8d22 ("habanalabs: add h/w queues module") >> 9815c7cf22da ("NFC: pn533: Separate physical layer from the core implementation") >> b9eaf1872222 ("treewide: init_timer() -> setup_timer()") >> be5d926b5c10 ("habanalabs: add command buffer module") >> c4d66343a46a ("habanalabs: add skeleton driver") >> e26ae3660b9c ("mfd: rtsx: Make arrays depth and cd_mask static const") >> e455b69ddf9b ("misc: rtsx: Move Realtek Card Reader Driver to misc") >> e99e88a9d2b0 ("treewide: setup_timer() -> timer_setup()") >> >> v3.18.139: Failed to apply! Possible dependencies: >> 0523b8f41473 ("mfd: rtsx: Using pcr_dbg replace dev_dbg") >> 0b271258544b ("mfd: rt5033: Add Richtek RT5033 driver core.") >> 19f3bd548f27 ("mfd: rtsx: Remove LCTLR defination") >> 338a12814297 ("mfd: Add support for Diolan DLN-2 devices") >> 5cb5d9616a47 ("mfd: rtsx: Fix PM suspend for 5227 & 5249") >> 663c425f2c8d ("mfd: rtsx: Add support for rts524A") >> 8275b77a1513 ("mfd: rts5249: Add support for RTS5250S power saving") >> 9494a8dd8d22 ("habanalabs: add h/w queues module") >> 9e33ce79f828 ("mfd: rtsx: Update PETXCFG address") >> a3b63979f8a3 ("mfd: rtsx: Add func to split u32 into register") >> b038538104d5 ("mfd: rtsx: Update phy register") >> b158b69a3765 ("mfd: rtsx: Simplify function return logic") >> be5d926b5c10 ("habanalabs: add command buffer module") >> c4d66343a46a ("habanalabs: add skeleton driver") >> ce6a5acc9387 ("mfd: rtsx: Add support for rts522A") >> e455b69ddf9b ("misc: rtsx: Move Realtek Card Reader Driver to misc") >> e89f231826a7 ("mfd: rtsx: Update driving settings") >> >> >> How should we proceed with this patch? >> >> -- >> Thanks, >> Sasha > >ok, I see my mistake. >How do I specify a specific kernel version ? >Because this applies only to future 5.1.X, that aren't available yet. Take a look at https://www.kernel.org/doc/Documentation/process/stable-kernel-rules.rst A "Fixes" tag also helps a lot. -- Thanks, Sasha

5 years, 9 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror May 2019