January 2020 - Linux-stable-mirror

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.5.1 release. There are 56 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat, 01 Feb 2020 18:35:06 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.5.1-rc1.… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.5.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.5.1-rc1 Paul Cercueil <paul(a)crapouillou.net> power/supply: ingenic-battery: Don't change scale if there's only one Johannes Berg <johannes.berg(a)intel.com> Revert "um: Enable CONFIG_CONSTRUCTORS" Andrew Murray <andrew.murray(a)arm.com> KVM: arm64: Write arch.mdcr_el2 changes since last vcpu_load on VHE Herbert Xu <herbert(a)gondor.apana.org.au> crypto: pcrypt - Fix user-after-free on module unload Iuliana Prodan <iuliana.prodan(a)nxp.com> crypto: caam - do not reset pointer size from MCFGR register Daniel Axtens <dja(a)axtens.net> crypto: vmx - reject xts inputs that are too short Herbert Xu <herbert(a)gondor.apana.org.au> crypto: af_alg - Use bh_lock_sock in sk_destruct Johan Hovold <johan(a)kernel.org> rsi: fix non-atomic allocation in completion handler Johan Hovold <johan(a)kernel.org> rsi: fix memory leak on failed URB submission Johan Hovold <johan(a)kernel.org> rsi: fix use-after-free on probe errors Johan Hovold <johan(a)kernel.org> rsi: fix use-after-free on failed probe and unbind David Howells <dhowells(a)redhat.com> rxrpc: Fix use-after-free in rxrpc_receive_data() Stephen Worley <sworley(a)cumulusnetworks.com> net: include struct nhmsg size in nh nlmsg size Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> mlxsw: minimal: Fix an error handling path in 'mlxsw_m_port_create()' Willem de Bruijn <willemb(a)google.com> udp: segment looped gso packets correctly Lorenzo Bianconi <lorenzo(a)kernel.org> net: socionext: fix xdp_result initialization in netsec_process_rx Lorenzo Bianconi <lorenzo(a)kernel.org> net: socionext: fix possible user-after-free in netsec_process_rx Cong Wang <xiyou.wangcong(a)gmail.com> net_sched: walk through all child classes in tc_bind_tclass() Cong Wang <xiyou.wangcong(a)gmail.com> net_sched: fix ops->bind_class() implementations Eric Dumazet <edumazet(a)google.com> net_sched: ematch: reject invalid TCF_EM_SIMPLE Sven Auhagen <sven.auhagen(a)voleatech.de> mvneta driver disallow XDP program on hardware buffer management Johan Hovold <johan(a)kernel.org> zd1211rw: fix storage endpoint lookup Johan Hovold <johan(a)kernel.org> rtl8xxxu: fix interface sanity check Johan Hovold <johan(a)kernel.org> brcmfmac: fix interface sanity check Johan Hovold <johan(a)kernel.org> ath9k: fix storage endpoint lookup Paulo Alcantara (SUSE) <pc(a)cjr.nz> cifs: Fix memory allocation in __smb2_handle_cancelled_cmd() Ronnie Sahlberg <lsahlber(a)redhat.com> cifs: set correct max-buffer-size for smb2_ioctl_init() Vincent Whitchurch <vincent.whitchurch(a)axis.com> CIFS: Fix task struct use-after-free on reconnect Eric Biggers <ebiggers(a)google.com> crypto: chelsio - fix writing tfm flags to wrong place Guenter Roeck <linux(a)roeck-us.net> driver core: Fix test_async_driver_probe if NUMA is disabled Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> iio: st_gyro: Correct data for LSM9DS0 gyro Olivier Moysan <olivier.moysan(a)st.com> iio: adc: stm32-dfsdm: fix single conversion Tomas Winkler <tomas.winkler(a)intel.com> mei: me: add jasper point DID Tomas Winkler <tomas.winkler(a)intel.com> mei: me: add comet point (lake) H device ids Tomas Winkler <tomas.winkler(a)intel.com> mei: hdcp: bind only with i915 on the same PCH Martin Fuzzey <martin.fuzzey(a)flowbird.group> binder: fix log spam for existing debugfs file creation. Lubomir Rintel <lkundrak(a)v3.sk> component: do not dereference opaque pointer in debugfs Eric Snowberg <eric.snowberg(a)oracle.com> debugfs: Return -EPERM when locked down Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> serial: imx: fix a race condition in receive path Lukas Wunner <lukas(a)wunner.de> serial: 8250_bcm2835aux: Fix line mismatch on driver unbind Malcolm Priestley <tvboxspy(a)gmail.com> staging: vt6656: Fix false Tx excessive retries reporting. Malcolm Priestley <tvboxspy(a)gmail.com> staging: vt6656: use NULLFUCTION stack on mac80211 Malcolm Priestley <tvboxspy(a)gmail.com> staging: vt6656: correct packet types for CTS protect, mode. Colin Ian King <colin.king(a)canonical.com> staging: wlan-ng: ensure error return is actually returned Andrey Shvetsov <andrey.shvetsov(a)k2l.de> staging: most: net: fix buffer overflow Thomas Hebb <tommyhebb(a)gmail.com> usb: typec: fusb302: fix "op-sink-microwatt" default that was in mW Thomas Hebb <tommyhebb(a)gmail.com> usb: typec: wcove: fix "op-sink-microwatt" default that was in mW Bin Liu <b-liu(a)ti.com> usb: dwc3: turn off VBUS when leaving host mode Johan Hovold <johan(a)kernel.org> USB: serial: ir-usb: fix IrLAP framing Johan Hovold <johan(a)kernel.org> USB: serial: ir-usb: fix link-speed handling Johan Hovold <johan(a)kernel.org> USB: serial: ir-usb: add missing endpoint sanity check Peter Robinson <pbrobinson(a)gmail.com> usb: host: xhci-tegra: set MODULE_FIRMWARE for tegra186 Heikki Krogerus <heikki.krogerus(a)linux.intel.com> usb: dwc3: pci: add ID for the Intel Comet Lake -V variant Johan Hovold <johan(a)kernel.org> rsi_91x_usb: fix interface sanity check Johan Hovold <johan(a)kernel.org> orinoco_usb: fix interface sanity check Johan Hovold <johan(a)kernel.org> Bluetooth: btusb: fix non-atomic allocation in completion handler ------------- Diffstat: Makefile | 4 +- arch/arm64/kvm/debug.c | 6 +- arch/um/include/asm/common.lds.S | 2 +- arch/um/kernel/dyn.lds.S | 1 + crypto/af_alg.c | 6 +- crypto/pcrypt.c | 3 +- drivers/android/binder.c | 37 +++--- drivers/base/component.c | 8 +- drivers/base/test/test_async_driver_probe.c | 3 +- drivers/bluetooth/btusb.c | 2 +- drivers/crypto/caam/ctrl.c | 6 +- drivers/crypto/chelsio/chcr_algo.c | 16 +-- drivers/crypto/vmx/aes_xts.c | 3 + drivers/iio/adc/stm32-dfsdm-adc.c | 2 + drivers/iio/gyro/st_gyro_core.c | 75 +++++++++++- drivers/misc/mei/hdcp/mei_hdcp.c | 33 ++++- drivers/misc/mei/hw-me-regs.h | 6 + drivers/misc/mei/pci-me.c | 4 + drivers/net/ethernet/marvell/mvneta.c | 6 + drivers/net/ethernet/mellanox/mlxsw/minimal.c | 2 +- drivers/net/ethernet/socionext/netsec.c | 4 +- drivers/net/wireless/ath/ath9k/hif_usb.c | 2 +- .../net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 4 +- .../net/wireless/intersil/orinoco/orinoco_usb.c | 4 +- .../net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 2 +- drivers/net/wireless/rsi/rsi_91x_hal.c | 12 +- drivers/net/wireless/rsi/rsi_91x_usb.c | 37 ++++-- drivers/net/wireless/zydas/zd1211rw/zd_usb.c | 2 +- drivers/power/supply/ingenic-battery.c | 15 ++- drivers/staging/most/net/net.c | 10 ++ drivers/staging/vt6656/device.h | 2 + drivers/staging/vt6656/int.c | 6 +- drivers/staging/vt6656/main_usb.c | 1 + drivers/staging/vt6656/rxtx.c | 26 ++-- drivers/staging/wlan-ng/prism2mgmt.c | 2 +- drivers/tty/serial/8250/8250_bcm2835aux.c | 2 +- drivers/tty/serial/imx.c | 51 ++++++-- drivers/usb/dwc3/core.c | 3 + drivers/usb/dwc3/dwc3-pci.c | 4 + drivers/usb/host/xhci-tegra.c | 1 + drivers/usb/serial/ir-usb.c | 136 ++++++++++++++++----- drivers/usb/typec/tcpm/fusb302.c | 2 +- drivers/usb/typec/tcpm/wcove.c | 2 +- fs/cifs/cifsglob.h | 1 + fs/cifs/smb2misc.c | 2 +- fs/cifs/smb2ops.c | 9 +- fs/cifs/smb2transport.c | 2 + fs/cifs/transport.c | 3 + fs/debugfs/file.c | 17 +-- include/linux/usb/irda.h | 13 +- include/net/pkt_cls.h | 33 ++--- include/net/sch_generic.h | 3 +- include/net/udp.h | 3 + init/Kconfig | 1 + kernel/gcov/Kconfig | 2 +- net/ipv4/nexthop.c | 4 +- net/rxrpc/input.c | 12 +- net/sched/cls_basic.c | 11 +- net/sched/cls_bpf.c | 11 +- net/sched/cls_flower.c | 11 +- net/sched/cls_fw.c | 11 +- net/sched/cls_matchall.c | 11 +- net/sched/cls_route.c | 11 +- net/sched/cls_rsvp.h | 11 +- net/sched/cls_tcindex.c | 11 +- net/sched/cls_u32.c | 11 +- net/sched/ematch.c | 3 + net/sched/sch_api.c | 47 +++++-- 68 files changed, 591 insertions(+), 218 deletions(-)

4 years, 10 months

6
65
0 0

[PATCH 4.19 00/55] 4.19.101-stable review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.101 release. There are 55 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat, 01 Feb 2020 18:35:06 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.101-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.19.101-rc1 Andrew Murray <andrew.murray(a)arm.com> KVM: arm64: Write arch.mdcr_el2 changes since last vcpu_load on VHE Dave Chinner <dchinner(a)redhat.com> block: fix 32 bit overflow in __blkdev_issue_discard() Ming Lei <ming.lei(a)redhat.com> block: cleanup __blkdev_issue_discard() Linus Torvalds <torvalds(a)linux-foundation.org> random: try to actively add entropy rather than passively wait for it Herbert Xu <herbert(a)gondor.apana.org.au> crypto: af_alg - Use bh_lock_sock in sk_destruct Johan Hovold <johan(a)kernel.org> rsi: fix non-atomic allocation in completion handler Johan Hovold <johan(a)kernel.org> rsi: fix memory leak on failed URB submission Johan Hovold <johan(a)kernel.org> rsi: fix use-after-free on probe errors Vincent Guittot <vincent.guittot(a)linaro.org> sched/fair: Fix insertion in rq->leaf_cfs_rq_list Peter Zijlstra <peterz(a)infradead.org> sched/fair: Add tmp_alone_branch assertion Laura Abbott <labbott(a)fedoraproject.org> usb-storage: Disable UAS on JMicron SATA enclosure Ben Dooks <ben.dooks(a)codethink.co.uk> ARM: OMAP2+: SmartReflex: add omap_sr_pdata definition Logan Gunthorpe <logang(a)deltatee.com> iommu/amd: Support multiple PCI DMA aliases in IRQ Remapping Slawomir Pawlowski <slawomir.pawlowski(a)intel.com> PCI: Add DMA alias quirk for Intel VCA NTB Pacien TRAN-GIRARD <pacien.trangirard(a)pacien.net> platform/x86: dell-laptop: disable kbd backlight on Inspiron 10xx Rodrigo Rivas Costa <rodrigorivascosta(a)gmail.com> HID: steam: Fix input device disappearing Arnd Bergmann <arnd(a)arndb.de> atm: eni: fix uninitialized variable warning Dmitry Osipenko <digetx(a)gmail.com> gpio: max77620: Add missing dependency on GPIOLIB_IRQCHIP Krzysztof Kozlowski <krzk(a)kernel.org> net: wan: sdla: Fix cast from pointer to integer of different size Fenghua Yu <fenghua.yu(a)intel.com> drivers/net/b44: Change to non-atomic bit operations on pwol_mask wuxu.wu <wuxu.wu(a)huawei.com> spi: spi-dw: Add lock protect dw_spi rx/tx to prevent concurrent calls Andreas Kemnade <andreas(a)kemnade.info> watchdog: rn5t618_wdt: fix module aliases David Engraf <david.engraf(a)sysgo.com> watchdog: max77620_wdt: fix potential build errors Tony Lindgren <tony(a)atomide.com> phy: cpcap-usb: Prevent USB line glitches from waking up modem Bjorn Andersson <bjorn.andersson(a)linaro.org> phy: qcom-qmp: Increase PHY ready timeout Pan Zhang <zhangpan26(a)huawei.com> drivers/hid/hid-multitouch.c: fix a possible null pointer access. Pavel Balan <admin(a)kryma.net> HID: Add quirk for incorrect input length on Lenovo Y720 Hans de Goede <hdegoede(a)redhat.com> HID: ite: Add USB id match for Acer SW5-012 keyboard dock Priit Laes <plaes(a)plaes.org> HID: Add quirk for Xin-Mo Dual Controller Randy Dunlap <rdunlap(a)infradead.org> arc: eznps: fix allmodconfig kconfig warning Aaron Ma <aaron.ma(a)canonical.com> HID: multitouch: Add LG MELF0410 I2C touchscreen support Cong Wang <xiyou.wangcong(a)gmail.com> net_sched: fix ops->bind_class() implementations Eric Dumazet <edumazet(a)google.com> net_sched: ematch: reject invalid TCF_EM_SIMPLE Johan Hovold <johan(a)kernel.org> zd1211rw: fix storage endpoint lookup Johan Hovold <johan(a)kernel.org> rtl8xxxu: fix interface sanity check Johan Hovold <johan(a)kernel.org> brcmfmac: fix interface sanity check Johan Hovold <johan(a)kernel.org> ath9k: fix storage endpoint lookup Paulo Alcantara (SUSE) <pc(a)cjr.nz> cifs: Fix memory allocation in __smb2_handle_cancelled_cmd() Eric Biggers <ebiggers(a)google.com> crypto: chelsio - fix writing tfm flags to wrong place Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> iio: st_gyro: Correct data for LSM9DS0 gyro Tomas Winkler <tomas.winkler(a)intel.com> mei: me: add comet point (lake) H device ids Lubomir Rintel <lkundrak(a)v3.sk> component: do not dereference opaque pointer in debugfs Lukas Wunner <lukas(a)wunner.de> serial: 8250_bcm2835aux: Fix line mismatch on driver unbind Malcolm Priestley <tvboxspy(a)gmail.com> staging: vt6656: Fix false Tx excessive retries reporting. Malcolm Priestley <tvboxspy(a)gmail.com> staging: vt6656: use NULLFUCTION stack on mac80211 Malcolm Priestley <tvboxspy(a)gmail.com> staging: vt6656: correct packet types for CTS protect, mode. Colin Ian King <colin.king(a)canonical.com> staging: wlan-ng: ensure error return is actually returned Andrey Shvetsov <andrey.shvetsov(a)k2l.de> staging: most: net: fix buffer overflow Bin Liu <b-liu(a)ti.com> usb: dwc3: turn off VBUS when leaving host mode Johan Hovold <johan(a)kernel.org> USB: serial: ir-usb: fix IrLAP framing Johan Hovold <johan(a)kernel.org> USB: serial: ir-usb: fix link-speed handling Johan Hovold <johan(a)kernel.org> USB: serial: ir-usb: add missing endpoint sanity check Heikki Krogerus <heikki.krogerus(a)linux.intel.com> usb: dwc3: pci: add ID for the Intel Comet Lake -V variant Johan Hovold <johan(a)kernel.org> rsi_91x_usb: fix interface sanity check Johan Hovold <johan(a)kernel.org> orinoco_usb: fix interface sanity check ------------- Diffstat: Makefile | 4 +- arch/arc/plat-eznps/Kconfig | 2 +- arch/arm64/kvm/debug.c | 6 +- block/blk-lib.c | 23 +--- crypto/af_alg.c | 6 +- drivers/atm/eni.c | 4 +- drivers/base/component.c | 8 +- drivers/char/random.c | 62 ++++++++- drivers/crypto/chelsio/chcr_algo.c | 16 +-- drivers/gpio/Kconfig | 1 + drivers/hid/hid-ids.h | 3 + drivers/hid/hid-ite.c | 3 + drivers/hid/hid-multitouch.c | 5 +- drivers/hid/hid-quirks.c | 1 + drivers/hid/hid-steam.c | 4 + drivers/hid/i2c-hid/i2c-hid-core.c | 16 ++- drivers/iio/gyro/st_gyro_core.c | 75 +++++++++- drivers/iommu/amd_iommu.c | 37 ++++- drivers/misc/mei/hw-me-regs.h | 4 + drivers/misc/mei/pci-me.c | 2 + drivers/net/ethernet/broadcom/b44.c | 9 +- drivers/net/wan/sdla.c | 2 +- drivers/net/wireless/ath/ath9k/hif_usb.c | 2 +- .../net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 4 +- .../net/wireless/intersil/orinoco/orinoco_usb.c | 4 +- .../net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 2 +- drivers/net/wireless/rsi/rsi_91x_hal.c | 12 +- drivers/net/wireless/rsi/rsi_91x_usb.c | 19 +-- drivers/net/wireless/zydas/zd1211rw/zd_usb.c | 2 +- drivers/pci/quirks.c | 34 +++++ drivers/phy/motorola/phy-cpcap-usb.c | 18 ++- drivers/phy/qualcomm/phy-qcom-qmp.c | 2 +- drivers/platform/x86/dell-laptop.c | 26 ++++ drivers/spi/spi-dw.c | 15 +- drivers/spi/spi-dw.h | 1 + drivers/staging/most/net/net.c | 10 ++ drivers/staging/vt6656/device.h | 2 + drivers/staging/vt6656/int.c | 6 +- drivers/staging/vt6656/main_usb.c | 1 + drivers/staging/vt6656/rxtx.c | 26 ++-- drivers/staging/wlan-ng/prism2mgmt.c | 2 +- drivers/tty/serial/8250/8250_bcm2835aux.c | 2 +- drivers/usb/dwc3/core.c | 3 + drivers/usb/dwc3/dwc3-pci.c | 4 + drivers/usb/serial/ir-usb.c | 136 +++++++++++++----- drivers/usb/storage/unusual_uas.h | 7 +- drivers/watchdog/Kconfig | 1 + drivers/watchdog/rn5t618_wdt.c | 1 + fs/cifs/smb2misc.c | 2 +- include/linux/power/smartreflex.h | 3 + include/linux/usb/irda.h | 13 +- include/net/pkt_cls.h | 33 +++-- include/net/sch_generic.h | 3 +- kernel/sched/fair.c | 153 +++++++++++++-------- net/sched/cls_basic.c | 11 +- net/sched/cls_bpf.c | 11 +- net/sched/cls_flower.c | 11 +- net/sched/cls_fw.c | 11 +- net/sched/cls_matchall.c | 11 +- net/sched/cls_route.c | 11 +- net/sched/cls_rsvp.h | 11 +- net/sched/cls_tcindex.c | 11 +- net/sched/cls_u32.c | 11 +- net/sched/ematch.c | 3 + net/sched/sch_api.c | 6 +- 65 files changed, 710 insertions(+), 240 deletions(-)

4 years, 10 months

9
65
0 0

[PATCH 5.4 000/110] 5.4.17-stable review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.4.17 release. There are 110 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat, 01 Feb 2020 18:35:06 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.17-rc1… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.4.17-rc1 Paul Cercueil <paul(a)crapouillou.net> power/supply: ingenic-battery: Don't change scale if there's only one Johannes Berg <johannes.berg(a)intel.com> Revert "um: Enable CONFIG_CONSTRUCTORS" Andrew Murray <andrew.murray(a)arm.com> KVM: arm64: Write arch.mdcr_el2 changes since last vcpu_load on VHE Herbert Xu <herbert(a)gondor.apana.org.au> crypto: pcrypt - Fix user-after-free on module unload Iuliana Prodan <iuliana.prodan(a)nxp.com> crypto: caam - do not reset pointer size from MCFGR register Daniel Axtens <dja(a)axtens.net> crypto: vmx - reject xts inputs that are too short Herbert Xu <herbert(a)gondor.apana.org.au> crypto: af_alg - Use bh_lock_sock in sk_destruct Johan Hovold <johan(a)kernel.org> rsi: fix non-atomic allocation in completion handler Johan Hovold <johan(a)kernel.org> rsi: fix memory leak on failed URB submission Johan Hovold <johan(a)kernel.org> rsi: fix use-after-free on probe errors Johan Hovold <johan(a)kernel.org> rsi: fix use-after-free on failed probe and unbind Tony Lindgren <tony(a)atomide.com> bus: ti-sysc: Fix missing force mstandby quirk handling Andre Heider <a.heider(a)gmail.com> Bluetooth: btbcm: Use the BDADDR_PROPERTY quirk Marcel Holtmann <marcel(a)holtmann.org> Bluetooth: Allow combination of BDADDR_PROPERTY and INVALID_BDADDR quirks Hui Wang <hui.wang(a)canonical.com> ALSA: hda/realtek - Move some alc236 pintbls to fallback table Laura Abbott <labbott(a)fedoraproject.org> usb-storage: Disable UAS on JMicron SATA enclosure Tony Lindgren <tony(a)atomide.com> bus: ti-sysc: Add module enable quirk for audio AESS Adrian Hunter <adrian.hunter(a)intel.com> mmc: sdhci-pci: Add support for Intel JSL Raul E Rangel <rrangel(a)chromium.org> mmc: sdhci-pci: Quirk for AMD SDHC Device 0x7906 Ben Dooks <ben.dooks(a)codethink.co.uk> ARM: OMAP2+: SmartReflex: add omap_sr_pdata definition Joel Stanley <joel(a)jms.id.au> ARM: config: aspeed-g5: Enable 8250_DW quirks Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> mfd: intel-lpss: Add Intel Comet Lake PCH-H PCI IDs Joakim Zhang <qiangqing.zhang(a)nxp.com> perf/imx_ddr: Add enhanced AXI ID filter support Logan Gunthorpe <logang(a)deltatee.com> iommu/amd: Support multiple PCI DMA aliases in IRQ Remapping Logan Gunthorpe <logang(a)deltatee.com> iommu/amd: Support multiple PCI DMA aliases in device table Jarkko Nikula <jarkko.nikula(a)linux.intel.com> spi: pxa2xx: Add support for Intel Comet Lake-H Tony Lindgren <tony(a)atomide.com> bus: ti-sysc: Use swsup quirks also for am335x musb Tony Lindgren <tony(a)atomide.com> bus: ti-sysc: Handle mstandby quirk and use it for musb Thomas Voegtle <tv(a)lio96.de> media: dvbsky: add support for eyeTV Geniatech T2 lite Slawomir Pawlowski <slawomir.pawlowski(a)intel.com> PCI: Add DMA alias quirk for Intel VCA NTB Pacien TRAN-GIRARD <pacien.trangirard(a)pacien.net> platform/x86: dell-laptop: disable kbd backlight on Inspiron 10xx Sergio Paracuellos <sergio.paracuellos(a)gmail.com> staging: mt7621-pci: add quirks for 'E2' revision using 'soc_device_attribute' Andrii Nakryiko <andriin(a)fb.com> libbpf: Fix BTF-defined map's __type macro handling of arrays Jiange Zhao <Jiange.Zhao(a)amd.com> drm/amdgpu/SRIOV: add navi12 pci id for SRIOV (v2) Sam McNally <sammc(a)chromium.org> ASoC: Intel: cht_bsw_rt5645: Add quirk for boards using pmc_plt_clk_0 Yauhen Kharuzhy <jekhor(a)gmail.com> extcon-intel-cht-wc: Don't reset USB data connection at probe Rodrigo Rivas Costa <rodrigorivascosta(a)gmail.com> HID: steam: Fix input device disappearing Arnd Bergmann <arnd(a)arndb.de> atm: eni: fix uninitialized variable warning Jiping Ma <jiping.ma2(a)windriver.com> stmmac: debugfs entry name is not be changed when udev rename device name. Thomas Anderson <thomasanderson(a)google.com> drm/amd/display: Reduce HDMI pixel encoding if max clock is exceeded Qian Cai <cai(a)lca.pw> iommu/dma: fix variable 'cookie' set but not used Dmitry Osipenko <digetx(a)gmail.com> gpio: max77620: Add missing dependency on GPIOLIB_IRQCHIP Krzysztof Kozlowski <krzk(a)kernel.org> net: wan: sdla: Fix cast from pointer to integer of different size Fenghua Yu <fenghua.yu(a)intel.com> drivers/net/b44: Change to non-atomic bit operations on pwol_mask Liran Alon <liran.alon(a)oracle.com> net: Google gve: Remove dma_wmb() before ringing doorbell wuxu.wu <wuxu.wu(a)huawei.com> spi: spi-dw: Add lock protect dw_spi rx/tx to prevent concurrent calls Sean Nyekjaer <sean(a)geanix.com> can: tcan4x5x: tcan4x5x_parse_config(): reset device before register access Paul Cercueil <paul(a)crapouillou.net> usb: musb: jz4740: Silence error if code is -EPROBE_DEFER Russell King <rmk+kernel(a)armlinux.org.uk> watchdog: orion: fix platform_get_irq() complaints Andreas Kemnade <andreas(a)kemnade.info> watchdog: rn5t618_wdt: fix module aliases David Engraf <david.engraf(a)sysgo.com> watchdog: max77620_wdt: fix potential build errors Srinivas Pandruvada <srinivas.pandruvada(a)linux.intel.com> HID: intel-ish-hid: ipc: Add Tiger Lake PCI device ID Tony Lindgren <tony(a)atomide.com> phy: cpcap-usb: Prevent USB line glitches from waking up modem Dragos Tarcatu <dragos_tarcatu(a)mentor.com> ASoC: topology: Prevent use-after-free in snd_soc_get_pcm_runtime() Chuhong Yuan <hslester96(a)gmail.com> ASoC: fsl_audmix: add missed pm_runtime_disable Bjorn Andersson <bjorn.andersson(a)linaro.org> phy: qcom-qmp: Increase PHY ready timeout Pan Zhang <zhangpan26(a)huawei.com> drivers/hid/hid-multitouch.c: fix a possible null pointer access. Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> ASoC: SOF: Intel: hda: hda-dai: fix oops on hda_link .hw_free Kai Vehmanen <kai.vehmanen(a)linux.intel.com> ASoC: SOF: fix fault at driver unload after failed probe Jason Gerecke <killertofu(a)gmail.com> HID: wacom: Recognize new MobileStudio Pro PID Even Xu <even.xu(a)intel.com> HID: intel-ish-hid: ipc: add CMP device id Pavel Balan <admin(a)kryma.net> HID: Add quirk for incorrect input length on Lenovo Y720 Hans de Goede <hdegoede(a)redhat.com> HID: asus: Ignore Asus vendor-page usage-code 0xff events Hans de Goede <hdegoede(a)redhat.com> HID: ite: Add USB id match for Acer SW5-012 keyboard dock Priit Laes <plaes(a)plaes.org> HID: Add quirk for Xin-Mo Dual Controller Randy Dunlap <rdunlap(a)infradead.org> arc: eznps: fix allmodconfig kconfig warning Aaron Ma <aaron.ma(a)canonical.com> HID: multitouch: Add LG MELF0410 I2C touchscreen support David Howells <dhowells(a)redhat.com> rxrpc: Fix use-after-free in rxrpc_receive_data() Stephen Worley <sworley(a)cumulusnetworks.com> net: include struct nhmsg size in nh nlmsg size Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> mlxsw: minimal: Fix an error handling path in 'mlxsw_m_port_create()' Willem de Bruijn <willemb(a)google.com> udp: segment looped gso packets correctly Lorenzo Bianconi <lorenzo(a)kernel.org> net: socionext: fix xdp_result initialization in netsec_process_rx Lorenzo Bianconi <lorenzo(a)kernel.org> net: socionext: fix possible user-after-free in netsec_process_rx Cong Wang <xiyou.wangcong(a)gmail.com> net_sched: walk through all child classes in tc_bind_tclass() Cong Wang <xiyou.wangcong(a)gmail.com> net_sched: fix ops->bind_class() implementations Eric Dumazet <edumazet(a)google.com> net_sched: ematch: reject invalid TCF_EM_SIMPLE Johan Hovold <johan(a)kernel.org> zd1211rw: fix storage endpoint lookup Johan Hovold <johan(a)kernel.org> rtl8xxxu: fix interface sanity check Johan Hovold <johan(a)kernel.org> brcmfmac: fix interface sanity check Johan Hovold <johan(a)kernel.org> ath9k: fix storage endpoint lookup Paulo Alcantara (SUSE) <pc(a)cjr.nz> cifs: Fix memory allocation in __smb2_handle_cancelled_cmd() Ronnie Sahlberg <lsahlber(a)redhat.com> cifs: set correct max-buffer-size for smb2_ioctl_init() Vincent Whitchurch <vincent.whitchurch(a)axis.com> CIFS: Fix task struct use-after-free on reconnect Eric Biggers <ebiggers(a)google.com> crypto: chelsio - fix writing tfm flags to wrong place Guenter Roeck <linux(a)roeck-us.net> driver core: Fix test_async_driver_probe if NUMA is disabled Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> iio: st_gyro: Correct data for LSM9DS0 gyro Olivier Moysan <olivier.moysan(a)st.com> iio: adc: stm32-dfsdm: fix single conversion Tomas Winkler <tomas.winkler(a)intel.com> mei: me: add comet point (lake) H device ids Tomas Winkler <tomas.winkler(a)intel.com> mei: hdcp: bind only with i915 on the same PCH Martin Fuzzey <martin.fuzzey(a)flowbird.group> binder: fix log spam for existing debugfs file creation. Lubomir Rintel <lkundrak(a)v3.sk> component: do not dereference opaque pointer in debugfs Eric Snowberg <eric.snowberg(a)oracle.com> debugfs: Return -EPERM when locked down Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> serial: imx: fix a race condition in receive path Lukas Wunner <lukas(a)wunner.de> serial: 8250_bcm2835aux: Fix line mismatch on driver unbind Malcolm Priestley <tvboxspy(a)gmail.com> staging: vt6656: Fix false Tx excessive retries reporting. Malcolm Priestley <tvboxspy(a)gmail.com> staging: vt6656: use NULLFUCTION stack on mac80211 Malcolm Priestley <tvboxspy(a)gmail.com> staging: vt6656: correct packet types for CTS protect, mode. Colin Ian King <colin.king(a)canonical.com> staging: wlan-ng: ensure error return is actually returned Andrey Shvetsov <andrey.shvetsov(a)k2l.de> staging: most: net: fix buffer overflow Thomas Hebb <tommyhebb(a)gmail.com> usb: typec: fusb302: fix "op-sink-microwatt" default that was in mW Thomas Hebb <tommyhebb(a)gmail.com> usb: typec: wcove: fix "op-sink-microwatt" default that was in mW Bin Liu <b-liu(a)ti.com> usb: dwc3: turn off VBUS when leaving host mode Johan Hovold <johan(a)kernel.org> USB: serial: ir-usb: fix IrLAP framing Johan Hovold <johan(a)kernel.org> USB: serial: ir-usb: fix link-speed handling Johan Hovold <johan(a)kernel.org> USB: serial: ir-usb: add missing endpoint sanity check Peter Robinson <pbrobinson(a)gmail.com> usb: host: xhci-tegra: set MODULE_FIRMWARE for tegra186 Heikki Krogerus <heikki.krogerus(a)linux.intel.com> usb: dwc3: pci: add ID for the Intel Comet Lake -V variant Johan Hovold <johan(a)kernel.org> rsi_91x_usb: fix interface sanity check Johan Hovold <johan(a)kernel.org> orinoco_usb: fix interface sanity check Johan Hovold <johan(a)kernel.org> Bluetooth: btusb: fix non-atomic allocation in completion handler ------------- Diffstat: Makefile | 4 +- arch/arc/plat-eznps/Kconfig | 2 +- arch/arm/configs/aspeed_g5_defconfig | 1 + arch/arm64/kvm/debug.c | 6 +- arch/um/include/asm/common.lds.S | 2 +- arch/um/kernel/dyn.lds.S | 1 + crypto/af_alg.c | 6 +- crypto/pcrypt.c | 3 +- drivers/android/binder.c | 37 ++--- drivers/atm/eni.c | 4 +- drivers/base/component.c | 8 +- drivers/base/test/test_async_driver_probe.c | 3 +- drivers/bluetooth/btbcm.c | 6 + drivers/bluetooth/btusb.c | 2 +- drivers/bus/ti-sysc.c | 27 +++- drivers/crypto/caam/ctrl.c | 6 +- drivers/crypto/chelsio/chcr_algo.c | 16 +- drivers/crypto/vmx/aes_xts.c | 3 + drivers/extcon/extcon-intel-cht-wc.c | 16 +- drivers/gpio/Kconfig | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 45 +++--- drivers/hid/hid-asus.c | 3 +- drivers/hid/hid-ids.h | 3 + drivers/hid/hid-ite.c | 3 + drivers/hid/hid-multitouch.c | 5 +- drivers/hid/hid-quirks.c | 1 + drivers/hid/hid-steam.c | 4 + drivers/hid/i2c-hid/i2c-hid-core.c | 16 +- drivers/hid/intel-ish-hid/ipc/hw-ish.h | 2 + drivers/hid/intel-ish-hid/ipc/pci-ish.c | 2 + drivers/hid/wacom_wac.c | 6 +- drivers/iio/adc/stm32-dfsdm-adc.c | 2 + drivers/iio/gyro/st_gyro_core.c | 75 ++++++++- drivers/iommu/amd_iommu.c | 170 +++++++++++---------- drivers/iommu/amd_iommu_types.h | 2 +- drivers/iommu/dma-iommu.c | 3 - drivers/media/usb/dvb-usb-v2/dvbsky.c | 3 + drivers/mfd/intel-lpss-pci.c | 13 +- drivers/misc/mei/hdcp/mei_hdcp.c | 33 +++- drivers/misc/mei/hw-me-regs.h | 4 + drivers/misc/mei/pci-me.c | 2 + drivers/mmc/host/sdhci-pci-core.c | 53 ++++++- drivers/mmc/host/sdhci-pci.h | 2 + drivers/net/can/m_can/tcan4x5x.c | 27 +++- drivers/net/ethernet/broadcom/b44.c | 9 +- drivers/net/ethernet/google/gve/gve_rx.c | 2 - drivers/net/ethernet/google/gve/gve_tx.c | 6 - drivers/net/ethernet/mellanox/mlxsw/minimal.c | 2 +- drivers/net/ethernet/socionext/netsec.c | 4 +- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 32 ++++ drivers/net/wan/sdla.c | 2 +- drivers/net/wireless/ath/ath9k/hif_usb.c | 2 +- .../net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 4 +- .../net/wireless/intersil/orinoco/orinoco_usb.c | 4 +- .../net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 2 +- drivers/net/wireless/rsi/rsi_91x_hal.c | 12 +- drivers/net/wireless/rsi/rsi_91x_usb.c | 37 +++-- drivers/net/wireless/zydas/zd1211rw/zd_usb.c | 2 +- drivers/pci/quirks.c | 34 +++++ drivers/perf/fsl_imx8_ddr_perf.c | 63 +++++--- drivers/phy/motorola/phy-cpcap-usb.c | 18 ++- drivers/phy/qualcomm/phy-qcom-qmp.c | 2 +- drivers/platform/x86/dell-laptop.c | 26 ++++ drivers/power/supply/ingenic-battery.c | 15 +- drivers/spi/spi-dw.c | 15 +- drivers/spi/spi-dw.h | 1 + drivers/spi/spi-pxa2xx.c | 4 + drivers/staging/most/net/net.c | 10 ++ drivers/staging/mt7621-pci/pci-mt7621.c | 23 ++- drivers/staging/vt6656/device.h | 2 + drivers/staging/vt6656/int.c | 6 +- drivers/staging/vt6656/main_usb.c | 1 + drivers/staging/vt6656/rxtx.c | 26 ++-- drivers/staging/wlan-ng/prism2mgmt.c | 2 +- drivers/tty/serial/8250/8250_bcm2835aux.c | 2 +- drivers/tty/serial/imx.c | 51 +++++-- drivers/usb/dwc3/core.c | 3 + drivers/usb/dwc3/dwc3-pci.c | 4 + drivers/usb/host/xhci-tegra.c | 1 + drivers/usb/musb/jz4740.c | 7 +- drivers/usb/serial/ir-usb.c | 136 +++++++++++++---- drivers/usb/storage/unusual_uas.h | 7 +- drivers/usb/typec/tcpm/fusb302.c | 2 +- drivers/usb/typec/tcpm/wcove.c | 2 +- drivers/watchdog/Kconfig | 1 + drivers/watchdog/orion_wdt.c | 4 +- drivers/watchdog/rn5t618_wdt.c | 1 + fs/cifs/cifsglob.h | 1 + fs/cifs/smb2misc.c | 2 +- fs/cifs/smb2ops.c | 9 +- fs/cifs/smb2transport.c | 2 + fs/cifs/transport.c | 3 + fs/debugfs/file.c | 17 ++- include/linux/platform_data/ti-sysc.h | 2 + include/linux/power/smartreflex.h | 3 + include/linux/usb/irda.h | 13 +- include/media/dvb-usb-ids.h | 1 + include/net/pkt_cls.h | 33 ++-- include/net/sch_generic.h | 3 +- include/net/udp.h | 3 + init/Kconfig | 1 + kernel/gcov/Kconfig | 2 +- net/bluetooth/hci_core.c | 26 +++- net/ipv4/nexthop.c | 4 +- net/rxrpc/input.c | 12 +- net/sched/cls_basic.c | 11 +- net/sched/cls_bpf.c | 11 +- net/sched/cls_flower.c | 11 +- net/sched/cls_fw.c | 11 +- net/sched/cls_matchall.c | 11 +- net/sched/cls_route.c | 11 +- net/sched/cls_rsvp.h | 11 +- net/sched/cls_tcindex.c | 11 +- net/sched/cls_u32.c | 11 +- net/sched/ematch.c | 3 + net/sched/sch_api.c | 47 ++++-- sound/pci/hda/patch_realtek.c | 17 +-- sound/soc/fsl/fsl_audmix.c | 9 +- sound/soc/intel/boards/cht_bsw_rt5645.c | 26 +++- sound/soc/soc-topology.c | 6 +- sound/soc/sof/intel/hda-dai.c | 11 +- sound/soc/sof/ipc.c | 3 + tools/testing/selftests/bpf/bpf_helpers.h | 2 +- .../selftests/bpf/progs/test_get_stack_rawtp.c | 3 +- 125 files changed, 1162 insertions(+), 424 deletions(-)

4 years, 10 months

6
115
0 0

stable/linux-4.19.y boot: 53 boots: 0 failed, 51 passed with 2 untried/unknown (v4.19.100)

by kernelci.org bot

stable/linux-4.19.y boot: 53 boots: 0 failed, 51 passed with 2 untried/unknown (v4.19.100) Full Boot Summary: https://kernelci.org/boot/all/job/stable/branch/linux-4.19.y/kernel/v4.19.1… Full Build Summary: https://kernelci.org/build/stable/branch/linux-4.19.y/kernel/v4.19.100/ Tree: stable Branch: linux-4.19.y Git Describe: v4.19.100 Git Commit: 7cdefde351b6911ec5ef39322980296c091f6c52 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tested: 41 unique boards, 14 SoC families, 13 builds out of 203 Boot Regressions Detected: arc: hsdk_defconfig: gcc-8: hsdk: lab-baylibre: new failure (last pass: v4.19.99) arm: versatile_defconfig: gcc-8: versatile-pb: lab-collabora: new failure (last pass: v4.19.99) --- For more info write to <info(a)kernelci.org>

4 years, 10 months

1
0
0 0

Re: [PATCH] HID: ite: Only bind to keyboard USB interface on Acer SW5-012 keyboard dock

by Benjamin Tissoires

On Fri, Jan 31, 2020 at 6:51 PM Z R <zdenda.rampas(a)gmail.com> wrote: > > libiniput record touchpad - with one small two finger scroll: > > root@debswitch:~# libinput record > Available devices: > /dev/input/event0: Video Bus > /dev/input/event1: Acer WMI hotkeys > /dev/input/event2: SYNA7508:00 06CB:10EB > /dev/input/event3: SYNA7508:00 06CB:10EB > /dev/input/event4: ITE Tech. Inc. ITE Device(8595) Keyboard > /dev/input/event5: ITE Tech. Inc. ITE Device(8595) Consumer Control > /dev/input/event6: ITE Tech. Inc. ITE Device(8595) Wireless Radio Control > /dev/input/event7: ITE Tech. Inc. ITE Device(8595) > /dev/input/event8: ITE Tech. Inc. ITE Device(8595) System Control > /dev/input/event9: PC Speaker > /dev/input/event10: ITE Tech. Inc. ITE Device(8595) Mouse > /dev/input/event11: Intel HDMI/DP LPE Audio HDMI/DP,pcm=0 > /dev/input/event12: Intel HDMI/DP LPE Audio HDMI/DP,pcm=1 > /dev/input/event13: SYNA7508:00 06CB:10EB Mouse > /dev/input/event14: ITE Tech. Inc. ITE Device(8595) Touchpad > /dev/input/event15: gpio-keys > /dev/input/event16: gpio-keys > /dev/input/event17: bytcr-rt5640 Headset > Select the device event number: 14 > Recording to 'stdout'. > version: 1 > ndevices: 1 > libinput: > version: "1.12.6" > git: "unknown" > system: > kernel: "5.5.0-vanilla+switch+revert8f18eca-debconf55rc5" > dmi: "dmi:bvnINSYDECorp.:bvrV1.20:bd03/01/2016:svnAcer:pnAspireSW5-012:pvrV1.20:rvnAcer:rnFendi2:rvrV1.20:cvnAcer:ct10:cvrChassisVersion:" > devices: > - node: /dev/input/event14 > evdev: > # Name: ITE Tech. Inc. ITE Device(8595) Touchpad > # ID: bus 0x3 vendor 0x6cb product 0x2968 version 0x110 > # Size in mm: 87x47 > # Supported Events: > # Event type 0 (EV_SYN) > # Event type 1 (EV_KEY) > # Event code 272 (BTN_LEFT) > # Event code 325 (BTN_TOOL_FINGER) > # Event code 330 (BTN_TOUCH) > # Event code 333 (BTN_TOOL_DOUBLETAP) > # Event code 334 (BTN_TOOL_TRIPLETAP) > # Event type 3 (EV_ABS) > # Event code 0 (ABS_X) > # Value 237 > # Min 0 > # Max 1051 > # Fuzz 0 > # Flat 0 > # Resolution 12 > # Event code 1 (ABS_Y) > # Value 166 > # Min 0 > # Max 571 > # Fuzz 0 > # Flat 0 > # Resolution 12 > # Event code 47 (ABS_MT_SLOT) > # Value 0 > # Min 0 > # Max 2 Thanks!, that means you have only up to 2 fingers that can be reported. FYI, first PR: https://gitlab.freedesktop.org/libevdev/hid-tools/merge_requests/69 (I need to update it with this max_contact information) Still working on the hid-ite.c regression tests. Cheers, Benjamin > # Fuzz 0 > # Flat 0 > # Resolution 0 > # Event code 53 (ABS_MT_POSITION_X) > # Value 0 > # Min 0 > # Max 1051 > # Fuzz 0 > # Flat 0 > # Resolution 12 > # Event code 54 (ABS_MT_POSITION_Y) > # Value 0 > # Min 0 > # Max 571 > # Fuzz 0 > # Flat 0 > # Resolution 12 > # Event code 55 (ABS_MT_TOOL_TYPE) > # Value 0 > # Min 0 > # Max 2 > # Fuzz 0 > # Flat 0 > # Resolution 0 > # Event code 57 (ABS_MT_TRACKING_ID) > # Value 0 > # Min 0 > # Max 65535 > # Fuzz 0 > # Flat 0 > # Resolution 0 > # Event type 4 (EV_MSC) > # Event code 5 (MSC_TIMESTAMP) > # Properties: > # Property 0 (INPUT_PROP_POINTER) > # Property 2 (INPUT_PROP_BUTTONPAD) > name: "ITE Tech. Inc. ITE Device(8595) Touchpad" > id: [3, 1739, 10600, 272] > codes: > 0: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15] # EV_SYN > 1: [272, 325, 330, 333, 334] # EV_KEY > 3: [0, 1, 47, 53, 54, 55, 57] # EV_ABS > 4: [5] # EV_MSC > absinfo: > 0: [0, 1051, 0, 0, 12] > 1: [0, 571, 0, 0, 12] > 47: [0, 2, 0, 0, 0] > 53: [0, 1051, 0, 0, 12] > 54: [0, 571, 0, 0, 12] > 55: [0, 2, 0, 0, 0] > 57: [0, 65535, 0, 0, 0] > properties: [0, 2] > udev: > properties: > - ID_INPUT=1 > - ID_INPUT_HEIGHT_MM=47 > - ID_INPUT_TOUCHPAD=1 > - ID_INPUT_TOUCHPAD_INTEGRATION=internal > - ID_INPUT_WIDTH_MM=87 > - LIBINPUT_DEVICE_GROUP=3/6cb/2968:usb-0000:00:14.0-1 > quirks: > events: > - evdev: > - [ 0, 0, 3, 57, 80] # EV_ABS / ABS_MT_TRACKING_ID 80 > - [ 0, 0, 3, 53, 608] # EV_ABS / ABS_MT_POSITION_X 608 > - [ 0, 0, 3, 54, 255] # EV_ABS / ABS_MT_POSITION_Y 255 > - [ 0, 0, 1, 330, 1] # EV_KEY / BTN_TOUCH 1 > - [ 0, 0, 1, 325, 1] # EV_KEY / BTN_TOOL_FINGER 1 > - [ 0, 0, 3, 0, 608] # EV_ABS / ABS_X 608 > - [ 0, 0, 3, 1, 255] # EV_ABS / ABS_Y 255 > - [ 0, 0, 4, 5, 0] # EV_MSC / MSC_TIMESTAMP 0 > - [ 0, 0, 0, 0, 0] # ------------ SYN_REPORT (0) ---------- +0ms > - evdev: > - [ 0, 9967, 3, 47, 1] # EV_ABS / ABS_MT_SLOT 1 > - [ 0, 9967, 3, 57, 81] # EV_ABS / ABS_MT_TRACKING_ID 81 > - [ 0, 9967, 3, 53, 326] # EV_ABS / ABS_MT_POSITION_X 326 > - [ 0, 9967, 3, 54, 324] # EV_ABS / ABS_MT_POSITION_Y 324 > - [ 0, 9967, 3, 47, 0] # EV_ABS / ABS_MT_SLOT 0 > - [ 0, 9967, 3, 53, 614] # EV_ABS / ABS_MT_POSITION_X 614 > - [ 0, 9967, 3, 54, 250] # EV_ABS / ABS_MT_POSITION_Y 250 > - [ 0, 9967, 1, 325, 0] # EV_KEY / BTN_TOOL_FINGER 0 > - [ 0, 9967, 1, 333, 1] # EV_KEY / BTN_TOOL_DOUBLETAP 1 > - [ 0, 9967, 3, 0, 614] # EV_ABS / ABS_X 614 > - [ 0, 9967, 3, 1, 250] # EV_ABS / ABS_Y 250 > - [ 0, 9967, 4, 5, 7200] # EV_MSC / MSC_TIMESTAMP 7200 > - [ 0, 9967, 0, 0, 0] # ------------ SYN_REPORT (0) ---------- +9ms > - evdev: > - [ 0, 16723, 3, 47, 1] # EV_ABS / ABS_MT_SLOT 1 > - [ 0, 16723, 3, 53, 323] # EV_ABS / ABS_MT_POSITION_X 323 > - [ 0, 16723, 3, 54, 309] # EV_ABS / ABS_MT_POSITION_Y 309 > - [ 0, 16723, 3, 47, 0] # EV_ABS / ABS_MT_SLOT 0 > - [ 0, 16723, 3, 53, 612] # EV_ABS / ABS_MT_POSITION_X 612 > - [ 0, 16723, 3, 54, 240] # EV_ABS / ABS_MT_POSITION_Y 240 > - [ 0, 16723, 3, 0, 612] # EV_ABS / ABS_X 612 > - [ 0, 16723, 3, 1, 240] # EV_ABS / ABS_Y 240 > - [ 0, 16723, 4, 5, 14500] # EV_MSC / MSC_TIMESTAMP 14500 > - [ 0, 16723, 0, 0, 0] # ------------ SYN_REPORT (0) ---------- +7ms > - evdev: > - [ 0, 24982, 3, 47, 1] # EV_ABS / ABS_MT_SLOT 1 > - [ 0, 24982, 3, 53, 321] # EV_ABS / ABS_MT_POSITION_X 321 > - [ 0, 24982, 3, 54, 294] # EV_ABS / ABS_MT_POSITION_Y 294 > - [ 0, 24982, 3, 47, 0] # EV_ABS / ABS_MT_SLOT 0 > - [ 0, 24982, 3, 53, 614] # EV_ABS / ABS_MT_POSITION_X 614 > - [ 0, 24982, 3, 54, 228] # EV_ABS / ABS_MT_POSITION_Y 228 > - [ 0, 24982, 3, 0, 614] # EV_ABS / ABS_X 614 > - [ 0, 24982, 3, 1, 228] # EV_ABS / ABS_Y 228 > - [ 0, 24982, 4, 5, 21900] # EV_MSC / MSC_TIMESTAMP 21900 > - [ 0, 24982, 0, 0, 0] # ------------ SYN_REPORT (0) ---------- +8ms > - evdev: > - [ 0, 32006, 3, 47, 1] # EV_ABS / ABS_MT_SLOT 1 > - [ 0, 32006, 3, 53, 320] # EV_ABS / ABS_MT_POSITION_X 320 > - [ 0, 32006, 3, 54, 286] # EV_ABS / ABS_MT_POSITION_Y 286 > - [ 0, 32006, 3, 47, 0] # EV_ABS / ABS_MT_SLOT 0 > - [ 0, 32006, 3, 54, 220] # EV_ABS / ABS_MT_POSITION_Y 220 > - [ 0, 32006, 3, 1, 220] # EV_ABS / ABS_Y 220 > - [ 0, 32006, 4, 5, 29200] # EV_MSC / MSC_TIMESTAMP 29200 > - [ 0, 32006, 0, 0, 0] # ------------ SYN_REPORT (0) ---------- +8ms > - evdev: > - [ 0, 38703, 3, 47, 1] # EV_ABS / ABS_MT_SLOT 1 > - [ 0, 38703, 3, 53, 317] # EV_ABS / ABS_MT_POSITION_X 317 > - [ 0, 38703, 3, 54, 276] # EV_ABS / ABS_MT_POSITION_Y 276 > - [ 0, 38703, 3, 47, 0] # EV_ABS / ABS_MT_SLOT 0 > - [ 0, 38703, 3, 54, 215] # EV_ABS / ABS_MT_POSITION_Y 215 > - [ 0, 38703, 3, 1, 215] # EV_ABS / ABS_Y 215 > - [ 0, 38703, 4, 5, 36400] # EV_MSC / MSC_TIMESTAMP 36400 > - [ 0, 38703, 0, 0, 0] # ------------ SYN_REPORT (0) ---------- +6ms > - evdev: > - [ 0, 46798, 3, 47, 1] # EV_ABS / ABS_MT_SLOT 1 > - [ 0, 46798, 3, 53, 315] # EV_ABS / ABS_MT_POSITION_X 315 > - [ 0, 46798, 3, 54, 268] # EV_ABS / ABS_MT_POSITION_Y 268 > - [ 0, 46798, 3, 47, 0] # EV_ABS / ABS_MT_SLOT 0 > - [ 0, 46798, 3, 54, 207] # EV_ABS / ABS_MT_POSITION_Y 207 > - [ 0, 46798, 3, 1, 207] # EV_ABS / ABS_Y 207 > - [ 0, 46798, 4, 5, 43700] # EV_MSC / MSC_TIMESTAMP 43700 > - [ 0, 46798, 0, 0, 0] # ------------ SYN_REPORT (0) ---------- +8ms > - evdev: > - [ 0, 53969, 3, 47, 1] # EV_ABS / ABS_MT_SLOT 1 > - [ 0, 53969, 3, 53, 313] # EV_ABS / ABS_MT_POSITION_X 313 > - [ 0, 53969, 3, 54, 258] # EV_ABS / ABS_MT_POSITION_Y 258 > - [ 0, 53969, 3, 47, 0] # EV_ABS / ABS_MT_SLOT 0 > - [ 0, 53969, 3, 54, 201] # EV_ABS / ABS_MT_POSITION_Y 201 > - [ 0, 53969, 3, 1, 201] # EV_ABS / ABS_Y 201 > - [ 0, 53969, 4, 5, 50900] # EV_MSC / MSC_TIMESTAMP 50900 > - [ 0, 53969, 0, 0, 0] # ------------ SYN_REPORT (0) ---------- +7ms > - evdev: > - [ 0, 60969, 3, 47, 1] # EV_ABS / ABS_MT_SLOT 1 > - [ 0, 60969, 3, 53, 312] # EV_ABS / ABS_MT_POSITION_X 312 > - [ 0, 60969, 3, 54, 255] # EV_ABS / ABS_MT_POSITION_Y 255 > - [ 0, 60969, 3, 47, 0] # EV_ABS / ABS_MT_SLOT 0 > - [ 0, 60969, 3, 54, 197] # EV_ABS / ABS_MT_POSITION_Y 197 > - [ 0, 60969, 3, 1, 197] # EV_ABS / ABS_Y 197 > - [ 0, 60969, 4, 5, 58100] # EV_MSC / MSC_TIMESTAMP 58100 > - [ 0, 60969, 0, 0, 0] # ------------ SYN_REPORT (0) ---------- +7ms > - evdev: > - [ 0, 69142, 3, 47, 1] # EV_ABS / ABS_MT_SLOT 1 > - [ 0, 69142, 3, 53, 310] # EV_ABS / ABS_MT_POSITION_X 310 > - [ 0, 69142, 3, 54, 251] # EV_ABS / ABS_MT_POSITION_Y 251 > - [ 0, 69142, 3, 47, 0] # EV_ABS / ABS_MT_SLOT 0 > - [ 0, 69142, 3, 54, 193] # EV_ABS / ABS_MT_POSITION_Y 193 > - [ 0, 69142, 3, 1, 193] # EV_ABS / ABS_Y 193 > - [ 0, 69142, 4, 5, 65400] # EV_MSC / MSC_TIMESTAMP 65400 > - [ 0, 69142, 0, 0, 0] # ------------ SYN_REPORT (0) ---------- +9ms > - evdev: > - [ 0, 76007, 3, 47, 1] # EV_ABS / ABS_MT_SLOT 1 > - [ 0, 76007, 3, 54, 246] # EV_ABS / ABS_MT_POSITION_Y 246 > - [ 0, 76007, 3, 47, 0] # EV_ABS / ABS_MT_SLOT 0 > - [ 0, 76007, 3, 53, 613] # EV_ABS / ABS_MT_POSITION_X 613 > - [ 0, 76007, 3, 0, 613] # EV_ABS / ABS_X 613 > - [ 0, 76007, 4, 5, 72600] # EV_MSC / MSC_TIMESTAMP 72600 > - [ 0, 76007, 0, 0, 0] # ------------ SYN_REPORT (0) ---------- +7ms > - evdev: > - [ 0, 83070, 3, 47, 1] # EV_ABS / ABS_MT_SLOT 1 > - [ 0, 83070, 3, 54, 241] # EV_ABS / ABS_MT_POSITION_Y 241 > - [ 0, 83070, 3, 47, 0] # EV_ABS / ABS_MT_SLOT 0 > - [ 0, 83070, 3, 54, 192] # EV_ABS / ABS_MT_POSITION_Y 192 > - [ 0, 83070, 3, 1, 192] # EV_ABS / ABS_Y 192 > - [ 0, 83070, 4, 5, 79900] # EV_MSC / MSC_TIMESTAMP 79900 > - [ 0, 83070, 0, 0, 0] # ------------ SYN_REPORT (0) ---------- +7ms > - evdev: > - [ 0, 89724, 3, 47, 1] # EV_ABS / ABS_MT_SLOT 1 > - [ 0, 89724, 3, 57, -1] # EV_ABS / ABS_MT_TRACKING_ID -1 > - [ 0, 89724, 3, 47, 0] # EV_ABS / ABS_MT_SLOT 0 > - [ 0, 89724, 3, 57, -1] # EV_ABS / ABS_MT_TRACKING_ID -1 > - [ 0, 89724, 1, 330, 0] # EV_KEY / BTN_TOUCH 0 > - [ 0, 89724, 1, 333, 0] # EV_KEY / BTN_TOOL_DOUBLETAP 0 > - [ 0, 89724, 4, 5, 87100] # EV_MSC / MSC_TIMESTAMP 87100 > - [ 0, 89724, 0, 0, 0] # ------------ SYN_REPORT (0) ---------- +6ms > # Touch device in neutral state >

4 years, 10 months

1
0
0 0

stable/linux-5.4.y boot: 81 boots: 1 failed, 79 passed with 1 untried/unknown (v5.4.16)

by kernelci.org bot

stable/linux-5.4.y boot: 81 boots: 1 failed, 79 passed with 1 untried/unknown (v5.4.16) Full Boot Summary: https://kernelci.org/boot/all/job/stable/branch/linux-5.4.y/kernel/v5.4.16/ Full Build Summary: https://kernelci.org/build/stable/branch/linux-5.4.y/kernel/v5.4.16/ Tree: stable Branch: linux-5.4.y Git Describe: v5.4.16 Git Commit: 60b6aa2b71efa7e0bd5393ce292ace4a0cf2e71b Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tested: 58 unique boards, 16 SoC families, 12 builds out of 175 Boot Regressions Detected: arc: hsdk_defconfig: gcc-8: hsdk: lab-baylibre: new failure (last pass: v5.4.15) Boot Failure Detected: arm64: defconfig: gcc-8: msm8998-mtp: 1 failed lab --- For more info write to <info(a)kernelci.org>

4 years, 10 months

1
0
0 0

stable-rc/linux-5.4.y boot: 85 boots: 0 failed, 77 passed with 7 offline, 1 untried/unknown (v5.4.16-111-g1bde1c513887)

by kernelci.org bot

stable-rc/linux-5.4.y boot: 85 boots: 0 failed, 77 passed with 7 offline, 1 untried/unknown (v5.4.16-111-g1bde1c513887) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-5.4.y/kernel/v5.4.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-5.4.y/kernel/v5.4.16-111-… Tree: stable-rc Branch: linux-5.4.y Git Describe: v5.4.16-111-g1bde1c513887 Git Commit: 1bde1c513887dd7bac46be466f1cd06fe3a64292 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 56 unique boards, 20 SoC families, 16 builds out of 162 Boot Regressions Detected: arm: davinci_all_defconfig: gcc-8: dm365evm,legacy: lab-baylibre-seattle: new failure (last pass: v5.4.16) multi_v7_defconfig: gcc-8: mt7629-rfb: lab-baylibre-seattle: new failure (last pass: v5.4.16) arm64: defconfig: gcc-8: meson-axg-s400: lab-baylibre-seattle: new failure (last pass: v5.4.16) Offline Platforms: arm: multi_v7_defconfig: gcc-8 mt7629-rfb: 1 offline lab qcom-apq8064-cm-qs600: 1 offline lab sun5i-r8-chip: 1 offline lab sunxi_defconfig: gcc-8 sun5i-r8-chip: 1 offline lab qcom_defconfig: gcc-8 qcom-apq8064-cm-qs600: 1 offline lab davinci_all_defconfig: gcc-8 dm365evm,legacy: 1 offline lab arm64: defconfig: gcc-8 meson-axg-s400: 1 offline lab --- For more info write to <info(a)kernelci.org>

4 years, 10 months

1
0
0 0

stable-rc/linux-4.9.y boot: 48 boots: 1 failed, 42 passed with 5 offline (v4.9.212-26-gc8f671aa81fa)

by kernelci.org bot

stable-rc/linux-4.9.y boot: 48 boots: 1 failed, 42 passed with 5 offline (v4.9.212-26-gc8f671aa81fa) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.9.y/kernel/v4.9.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.9.y/kernel/v4.9.212-26-… Tree: stable-rc Branch: linux-4.9.y Git Describe: v4.9.212-26-gc8f671aa81fa Git Commit: c8f671aa81faf69b2573521f6b97adde12b72925 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 29 unique boards, 15 SoC families, 14 builds out of 156 Boot Regressions Detected: arm: davinci_all_defconfig: gcc-8: dm365evm,legacy: lab-baylibre-seattle: new failure (last pass: v4.9.212) Boot Failure Detected: arm: multi_v7_defconfig: gcc-8: sun4i-a10-cubieboard: 1 failed lab Offline Platforms: arm: multi_v7_defconfig: gcc-8 qcom-apq8064-cm-qs600: 1 offline lab sun5i-r8-chip: 1 offline lab sunxi_defconfig: gcc-8 sun5i-r8-chip: 1 offline lab qcom_defconfig: gcc-8 qcom-apq8064-cm-qs600: 1 offline lab davinci_all_defconfig: gcc-8 dm365evm,legacy: 1 offline lab --- For more info write to <info(a)kernelci.org>

4 years, 10 months

1
0
0 0

stable-rc/linux-4.14.y boot: 67 boots: 1 failed, 61 passed with 5 offline (v4.14.169-33-ga3d2ee7a48e7)

by kernelci.org bot

stable-rc/linux-4.14.y boot: 67 boots: 1 failed, 61 passed with 5 offline (v4.14.169-33-ga3d2ee7a48e7) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.14.y/kernel/v4.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.14.y/kernel/v4.14.169-3… Tree: stable-rc Branch: linux-4.14.y Git Describe: v4.14.169-33-ga3d2ee7a48e7 Git Commit: a3d2ee7a48e78477fc9ad73102510602923091ae Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 40 unique boards, 15 SoC families, 12 builds out of 159 Boot Regressions Detected: arm: davinci_all_defconfig: gcc-8: dm365evm,legacy: lab-baylibre-seattle: new failure (last pass: v4.14.169) Boot Failure Detected: arm: multi_v7_defconfig: gcc-8: sun4i-a10-cubieboard: 1 failed lab Offline Platforms: arm: multi_v7_defconfig: gcc-8 qcom-apq8064-cm-qs600: 1 offline lab sun5i-r8-chip: 1 offline lab sunxi_defconfig: gcc-8 sun5i-r8-chip: 1 offline lab qcom_defconfig: gcc-8 qcom-apq8064-cm-qs600: 1 offline lab davinci_all_defconfig: gcc-8 dm365evm,legacy: 1 offline lab --- For more info write to <info(a)kernelci.org>

4 years, 10 months

1
0
0 0

Re: [PATCH] HID: ite: Only bind to keyboard USB interface on Acer SW5-012 keyboard dock

by Benjamin Tissoires

On Fri, Jan 31, 2020 at 6:17 PM Z R <zdenda.rampas(a)gmail.com> wrote: > > Hi Benjamin, > in last log touchpad.log (omg, should be keyboard.log), I pressed fn-f3 multiple times. I got one two liner: > > # ReportID: 3 / Wireless Radio Button: 0 | # > E: 000007.606583 2 03 00 great, thanks. > > every time i release f3. Does not matter what is happening with fn-key. (could be released already or still pushed down). This log was collected with last patch from Hans applied. Actually, it doesn't really matter if the patch from Hans was applied or not. I am looking at the raw event from the device before kernel processing :) May I ask you one more thing: can you run `libinput record` (as root) on the touchpad? I need to know how many fingers the touchpad is capable to detect, as right now, my tests are failing because of that. > > Sorry for the mess I caused :-) I still don't get how you guys manage to have your emails so well polished and readable. No worries. Having a responsive user is much more valuable than someone who takes ages to reply even in a clear and well polished message :) Cheers, Benjamin > > Bye > Zdeněk > > pá 31. 1. 2020 v 18:00 odesílatel Benjamin Tissoires <benjamin.tissoires(a)redhat.com> napsal: >> >> On Fri, Jan 31, 2020 at 5:09 PM Z R <zdenda.rampas(a)gmail.com> wrote: >> > >> > I believe I pressed wifi button on both replays for keyboard. >> >> Yep, I can see that. Just to double check, on the last log, you >> pressed the wifi button twice? >> >> Anyway, thanks for all the logs, I should have enough to implement the >> regression tests. >> >> Cheers, >> Benjamin >> >> > >> > With latest patch from Hans on top of v5.5.0 touchpads "two finger scrolling" is working again. Attaching current hid-record for keyboard with Wifi button pressed. Events in log appeared after f3 button was "released". >> > >> > Thanks >> > >> > Zdeněk >> > >> > pá 31. 1. 2020 v 16:45 odesílatel Hans de Goede <hdegoede(a)redhat.com> napsal: >> >> >> >> Hi, >> >> >> >> On 1/31/20 4:38 PM, Z R wrote: >> >> > Hi Benjamin, >> >> > hid-record for keyboard and touchpad. With Commit 8f18eca9ebc5 reverted and from unmodified kernel. >> >> > >> >> > I hope it is what you asked for :-) >> >> > >> >> > Currently waiting for reworked patch from Hans. >> >> >> >> I just send you the reworked patch. >> >> >> >> Does the recordning include pressing of the wlan on/off key (Fn + F3 I believe) ? >> >> That is the whole reason why the special hid-ite driver is necessary. >> >> >> >> Benjamin about the wlan on/off key. AFAICR on a press + release of the key a >> >> single hid input report for the generic-desktop Wireless Radio Controls group >> >> is send. This input-report only has the one button with usage code HID_GD_RFKILL_BTN >> >> in there and it is always 0. It is as if the input-report is only send on release >> >> and not on press. So the hid-ite code emulates a press + release whenever the >> >> input-report is send. >> >> >> >> IOW the receiving of the input report is (ab)used as indication of the button >> >> having been pressed. >> >> >> >> Regards, >> >> >> >> Hans >> >> >> >> >> >> > >> >> > Bye for now >> >> > Zdeněk >> >> > >> >> > pá 31. 1. 2020 v 15:12 odesílatel Benjamin Tissoires <benjamin.tissoires(a)redhat.com <mailto:benjamin.tissoires@redhat.com>> napsal: >> >> > >> >> > On Fri, Jan 31, 2020 at 3:04 PM Hans de Goede <hdegoede(a)redhat.com <mailto:hdegoede@redhat.com>> wrote: >> >> > > >> >> > > Hi, >> >> > > >> >> > > On 1/31/20 2:54 PM, Benjamin Tissoires wrote: >> >> > > > On Fri, Jan 31, 2020 at 2:41 PM Hans de Goede <hdegoede(a)redhat.com <mailto:hdegoede@redhat.com>> wrote: >> >> > > >> >> >> > > >> Hi, >> >> > > >> >> >> > > >> On 1/31/20 2:10 PM, Benjamin Tissoires wrote: >> >> > > >>> Hi Hans, >> >> > > >>> >> >> > > >>> On Fri, Jan 31, 2020 at 1:46 PM Hans de Goede <hdegoede(a)redhat.com <mailto:hdegoede@redhat.com>> wrote: >> >> > > >>>> >> >> > > >>>> Commit 8f18eca9ebc5 ("HID: ite: Add USB id match for Acer SW5-012 keyboard >> >> > > >>>> dock") added the USB id for the Acer SW5-012's keyboard dock to the >> >> > > >>>> hid-ite driver to fix the rfkill driver not working. >> >> > > >>>> >> >> > > >>>> Most keyboard docks with an ITE 8595 keyboard/touchpad controller have the >> >> > > >>>> "Wireless Radio Control" bits which need the special hid-ite driver on the >> >> > > >>>> second USB interface (the mouse interface) and their touchpad only supports >> >> > > >>>> mouse emulation, so using generic hid-input handling for anything but >> >> > > >>>> the "Wireless Radio Control" bits is fine. On these devices we simply bind >> >> > > >>>> to all USB interfaces. >> >> > > >>>> >> >> > > >>>> But unlike other ITE8595 using keyboard docks, the Acer Aspire Switch 10 >> >> > > >>>> (SW5-012)'s touchpad not only does mouse emulation it also supports >> >> > > >>>> HID-multitouch and all the keys including the "Wireless Radio Control" >> >> > > >>>> bits have been moved to the first USB interface (the keyboard intf). >> >> > > >>>> >> >> > > >>>> So we need hid-ite to handle the first (keyboard) USB interface and have >> >> > > >>>> it NOT bind to the second (mouse) USB interface so that that can be >> >> > > >>>> handled by hid-multitouch.c and we get proper multi-touch support. >> >> > > >>>> >> >> > > >>>> This commit adds a match callback to hid-ite which makes it only >> >> > > >>>> match the first USB interface when running on the Acer SW5-012, >> >> > > >>>> fixing the regression to mouse-emulation mode introduced by adding the >> >> > > >>>> keyboard dock USB id. >> >> > > >>>> >> >> > > >>>> Note the match function only does the special only bind to the first >> >> > > >>>> USB interface on the Acer SW5-012, on other devices the hid-ite driver >> >> > > >>>> actually must bind to the second interface as that is where the >> >> > > >>>> "Wireless Radio Control" bits are. >> >> > > >>> >> >> > > >>> This is not a full review, but a couple of things that popped out >> >> > > >>> while scrolling through the patch. >> >> > > >>> >> >> > > >>>> >> >> > > >>>> Cc: stable(a)vger.kernel.org <mailto:stable@vger.kernel.org> >> >> > > >>>> Fixes: 8f18eca9ebc5 ("HID: ite: Add USB id match for Acer SW5-012 keyboard dock") >> >> > > >>>> Reported-by: Zdeněk Rampas <zdenda.rampas(a)gmail.com <mailto:zdenda.rampas@gmail.com>> >> >> > > >>>> Signed-off-by: Hans de Goede <hdegoede(a)redhat.com <mailto:hdegoede@redhat.com>> >> >> > > >>>> --- >> >> > > >>>> drivers/hid/hid-ite.c | 34 ++++++++++++++++++++++++++++++++++ >> >> > > >>>> 1 file changed, 34 insertions(+) >> >> > > >>>> >> >> > > >>>> diff --git a/drivers/hid/hid-ite.c b/drivers/hid/hid-ite.c >> >> > > >>>> index c436e12feb23..69a4ddfd033d 100644 >> >> > > >>>> --- a/drivers/hid/hid-ite.c >> >> > > >>>> +++ b/drivers/hid/hid-ite.c >> >> > > >>>> @@ -8,9 +8,12 @@ >> >> > > >>>> #include <linux/input.h> >> >> > > >>>> #include <linux/hid.h> >> >> > > >>>> #include <linux/module.h> >> >> > > >>>> +#include <linux/usb.h> >> >> > > >>>> >> >> > > >>>> #include "hid-ids.h" >> >> > > >>>> >> >> > > >>>> +#define ITE8595_KBD_USB_INTF 0 >> >> > > >>>> + >> >> > > >>>> static int ite_event(struct hid_device *hdev, struct hid_field *field, >> >> > > >>>> struct hid_usage *usage, __s32 value) >> >> > > >>>> { >> >> > > >>>> @@ -37,6 +40,36 @@ static int ite_event(struct hid_device *hdev, struct hid_field *field, >> >> > > >>>> return 0; >> >> > > >>>> } >> >> > > >>>> >> >> > > >>>> +static bool ite_match(struct hid_device *hdev, bool ignore_special_driver) >> >> > > >>>> +{ >> >> > > >>>> + struct usb_interface *intf; >> >> > > >>>> + >> >> > > >>>> + if (ignore_special_driver) >> >> > > >>>> + return false; >> >> > > >>>> + >> >> > > >>>> + /* >> >> > > >>>> + * Most keyboard docks with an ITE 8595 keyboard/touchpad controller >> >> > > >>>> + * have the "Wireless Radio Control" bits which need this special >> >> > > >>>> + * driver on the second USB interface (the mouse interface). On >> >> > > >>>> + * these devices we simply bind to all USB interfaces. >> >> > > >>>> + * >> >> > > >>>> + * The Acer Aspire Switch 10 (SW5-012) is special, its touchpad >> >> > > >>>> + * not only does mouse emulation it also supports HID-multitouch >> >> > > >>>> + * and all the keys including the "Wireless Radio Control" bits >> >> > > >>>> + * have been moved to the first USB interface (the keyboard intf). >> >> > > >>>> + * >> >> > > >>>> + * We want the hid-multitouch driver to bind to the touchpad, so on >> >> > > >>>> + * the Acer SW5-012 we should only bind to the keyboard USB intf. >> >> > > >>>> + */ >> >> > > >>>> + if (hdev->bus != BUS_USB || hdev->vendor != USB_VENDOR_ID_SYNAPTICS || >> >> > > >>>> + hdev->product != USB_DEVICE_ID_SYNAPTICS_ACER_SWITCH5_012) >> >> > > >>> >> >> > > >>> Isn't there an existing matching function we can use here, instead of >> >> > > >>> checking each individual field? >> >> > > >> >> >> > > >> There is hid_match_one_id() but that is not exported (can be fixed) and it >> >> > > >> requires a struct hid_device_id, which either requires declaring an extra >> >> > > >> standalone struct hid_device_id for the SW5-012 kbd-dock, or hardcoding an >> >> > > >> index into the existing hid_device_id array for the driver (with the hardcoding >> >> > > >> being error prone, so not a good idea). >> >> > > >> >> >> > > >> Given the problems with using hid_match_one_id() I decided to just go with >> >> > > >> the above. >> >> > > > >> >> > > > right. An other solution would be to have a local macro/function that >> >> > > > does that. Because as soon as you start adding a quirk, an other comes >> >> > > > right after. >> >> > > > >> >> > > >> >> >> > > >> But see below. >> >> > > >> >> >> > > >>> >> >> > > >>>> + return true; >> >> > > >>>> + >> >> > > >>>> + intf = to_usb_interface(hdev->dev.parent); >> >> > > >>> >> >> > > >>> And this is oops-prone. You need: >> >> > > >>> - ensure hid_is_using_ll_driver(hdev, &usb_hid_driver) returns true. >> >> > > >>> - add a dependency on USBHID in the KConfig now that you are checking >> >> > > >>> on the USB transport layer. >> >> > > >>> >> >> > > >>> That being said, I would love instead: >> >> > > >>> - to have a non USB version of this match, where you decide which >> >> > > >>> component needs to be handled based on the report descriptor >> >> > > >> >> >> > > >> Actually your idea to use the desciptors is not bad, but since what >> >> > > >> we really want is to not bind to the interface which is marked for the >> >> > > >> hid-multitouch driver I just realized we can just check that. >> >> > > >> >> >> > > >> So how about: >> >> > > >> >> >> > > >> static bool ite_match(struct hid_device *hdev, bool ignore_special_driver) >> >> > > >> { >> >> > > >> if (ignore_special_driver) >> >> > > >> return false; >> >> > > >> >> >> > > >> /* >> >> > > >> * Some keyboard docks with an ITE 8595 keyboard/touchpad controller >> >> > > >> * support the HID multitouch protocol for the touchpad, in that >> >> > > >> * case the "Wireless Radio Control" bits which we care about are >> >> > > >> * on the other interface; and we should not bind to the multitouch >> >> > > >> * capable interface as that breaks multitouch support. >> >> > > >> */ >> >> > > >> return hdev->group != HID_GROUP_MULTITOUCH_WIN_8; >> >> > > >> } >> >> > > > >> >> > > > Yep, I like that very much :) >> >> > > >> >> > > Actually if we want to check the group and there are only 2 interfaces we do >> >> > > not need to use the match callback at all, w e can simply match on the >> >> > > group of the interface which we do want: >> >> > > >> >> > > diff --git a/drivers/hid/hid-ite.c b/drivers/hid/hid-ite.c >> >> > > index db0f35be5a8b..21bd48f16033 100644 >> >> > > --- a/drivers/hid/hid-ite.c >> >> > > +++ b/drivers/hid/hid-ite.c >> >> > > @@ -56,8 +56,9 @@ static const struct hid_device_id ite_devices[] = { >> >> > > { HID_USB_DEVICE(USB_VENDOR_ID_ITE, USB_DEVICE_ID_ITE8595) }, >> >> > > { HID_USB_DEVICE(USB_VENDOR_ID_258A, USB_DEVICE_ID_258A_6A88) }, >> >> > > /* ITE8595 USB kbd ctlr, with Synaptics touchpad connected to it. */ >> >> > > - { HID_USB_DEVICE(USB_VENDOR_ID_SYNAPTICS, >> >> > > - USB_DEVICE_ID_SYNAPTICS_ACER_SWITCH5_012) }, >> >> > > + { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC, >> >> > > + USB_VENDOR_ID_SYNAPTICS, >> >> > > + USB_DEVICE_ID_SYNAPTICS_ACER_SWITCH5_012) }, >> >> > > { } >> >> > > }; >> >> > > MODULE_DEVICE_TABLE(hid, ite_devices); >> >> > > >> >> > > Much cleaner >> >> > >> >> > yep >> >> > >> >> > > (and now I don't need to write a test, which is always >> >> > > a good motivation to come up with a cleaner solution :) >> >> > >> >> > Hehe, too bad, you already picked up my curiosity on this one, and I >> >> > really would like to see the report descriptors and some events of the >> >> > keys that are fixed by hid-ite.c. >> >> > <with a low voice>This will be a hard requirement to accept this patch </joke>. >> >> > >> >> > More seriously, Zdeněk, can you run hid-recorder from >> >> > https://gitlab.freedesktop.org/libevdev/hid-tools/ and provide me the >> >> > report descriptor for all of your ITE HID devices? I'll add the >> >> > matching tests in hid-tools and be sure we do not regress in the >> >> > future. >> >> > >> >> > > >> >> > > Let me turn this into a proper patch and then I will send that to >> >> > > Zdeněk (off-list) for him to test (note don't worry if you do >> >> > > not have time to test this weekend, then I'll do it on Monday). >> >> > > >> >> > > Regards, >> >> > > >> >> > > Hans >> >> > > >> >> > > p.s. >> >> > > >> >> > > 1. My train is approaching Brussels (Fosdem) so my email response >> >> > > time will soon become irregular. >> >> > >> >> > How dare you? :) >> >> > >> >> > > >> >> > > 2. Benjamin will you be at Fosdem too ? >> >> > > >> >> > >> >> > Unfortunately no. Already got my quota of meeting people for this year >> >> > between Kernel Recipes in September, XDC in October and LCA last week. >> >> > So I need to keep in a quiet environment for a little bit :) >> >> > >> >> > Cheers, >> >> > Benjamin >> >> > >> >> >>

4 years, 10 months

1
0
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror January 2020