September 2020 - Linux-stable-mirror

[PATCH] ext4: Fix checksum errors with indexed dirs

by Jan Kara

DIR_INDEX has been introduced as a compat ext4 feature. That means that even kernels / tools that don't understand the feature may modify the filesystem. This works because for kernels not understanding indexed dir format, internal htree nodes appear just as empty directory entries. Index dir aware kernels then check the htree structure is still consistent before using the data. This all worked reasonably well until metadata checksums were introduced. The problem is that these effectively made DIR_INDEX only ro-compatible because internal htree nodes store checksums in a different place than normal directory blocks. Thus any modification ignorant to DIR_INDEX (or just clearing EXT4_INDEX_FL from the inode) will effectively cause checksum mismatch and trigger kernel errors. So we have to be more careful when dealing with indexed directories on filesystems with checksumming enabled. 1) We just disallow loading and directory inodes with EXT4_INDEX_FL when DIR_INDEX is not enabled. This is harsh but it should be very rare (it means someone disabled DIR_INDEX on existing filesystem and didn't run e2fsck), e2fsck can fix the problem, and we don't want to answer the difficult question: "Should we rather corrupt the directory more or should we ignore that DIR_INDEX feature is not set?" 2) When we find out htree structure is corrupted (but the filesystem and the directory should in support htrees), we continue just ignoring htree information for reading but we refuse to add new entries to the directory to avoid corrupting it more. CC: stable(a)vger.kernel.org Fixes: dbe89444042a ("ext4: Calculate and verify checksums for htree nodes") Signed-off-by: Jan Kara <jack(a)suse.cz> --- fs/ext4/dir.c | 14 ++++++++------ fs/ext4/ext4.h | 5 ++++- fs/ext4/inode.c | 13 +++++++++++++ fs/ext4/namei.c | 7 +++++++ 4 files changed, 32 insertions(+), 7 deletions(-) diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c index 9f00fc0bf21d..cb9ea593b544 100644 --- a/fs/ext4/dir.c +++ b/fs/ext4/dir.c @@ -129,12 +129,14 @@ static int ext4_readdir(struct file *file, struct dir_context *ctx) if (err != ERR_BAD_DX_DIR) { return err; } - /* - * We don't set the inode dirty flag since it's not - * critical that it get flushed back to the disk. - */ - ext4_clear_inode_flag(file_inode(file), - EXT4_INODE_INDEX); + /* Can we just clear INDEX flag to ignore htree information? */ + if (!ext4_has_metadata_csum(sb)) { + /* + * We don't set the inode dirty flag since it's not + * critical that it gets flushed back to the disk. + */ + ext4_clear_inode_flag(inode, EXT4_INODE_INDEX); + } } if (ext4_has_inline_data(inode)) { diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index f8578caba40d..1fd6c1e2ce2a 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h @@ -2482,8 +2482,11 @@ void ext4_insert_dentry(struct inode *inode, struct ext4_filename *fname); static inline void ext4_update_dx_flag(struct inode *inode) { - if (!ext4_has_feature_dir_index(inode->i_sb)) + if (!ext4_has_feature_dir_index(inode->i_sb)) { + /* ext4_iget() should have caught this... */ + WARN_ON_ONCE(ext4_has_feature_metadata_csum(inode->i_sb)); ext4_clear_inode_flag(inode, EXT4_INODE_INDEX); + } } static const unsigned char ext4_filetype_table[] = { DT_UNKNOWN, DT_REG, DT_DIR, DT_CHR, DT_BLK, DT_FIFO, DT_SOCK, DT_LNK diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 629a25d999f0..d33135308c1b 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -4615,6 +4615,19 @@ struct inode *__ext4_iget(struct super_block *sb, unsigned long ino, ret = -EFSCORRUPTED; goto bad_inode; } + /* + * If dir_index is not enabled but there's dir with INDEX flag set, + * we'd normally treat htree data as empty space. But with metadata + * checksumming that corrupts checksums so forbid that. + */ + if (!ext4_has_feature_dir_index(sb) && ext4_has_metadata_csum(sb) && + ext4_test_inode_flag(inode, EXT4_INODE_INDEX)) { + ext4_error_inode(inode, function, line, 0, + "iget: Dir with htree data on filesystem " + "without dir_index feature."); + ret = -EFSCORRUPTED; + goto bad_inode; + } ei->i_disksize = inode->i_size; #ifdef CONFIG_QUOTA ei->i_reserved_quota = 0; diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 1cb42d940784..deb9f7a02976 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -2207,6 +2207,13 @@ static int ext4_add_entry(handle_t *handle, struct dentry *dentry, retval = ext4_dx_add_entry(handle, &fname, dir, inode); if (!retval || (retval != ERR_BAD_DX_DIR)) goto out; + /* Can we just ignore htree data? */ + if (ext4_has_metadata_csum(sb)) { + EXT4_ERROR_INODE(dir, + "Directory has corrupted htree index."); + retval = -EFSCORRUPTED; + goto out; + } ext4_clear_inode_flag(dir, EXT4_INODE_INDEX); dx_fallback++; ext4_mark_inode_dirty(handle, dir); -- 2.16.4

4 years, 2 months

3
5
0 0

[PATCH 2/3] drm/i915: Break up error capture compression loops with cond_resched()

by Chris Wilson

As the error capture will compress user buffers as directed to by the user, it can take an arbitrary amount of time and space. Break up the compression loops with a call to cond_resched(), that will allow other processes to schedule (avoiding the soft lockups) and also serve as a warning should we try to make this loop atomic in the future. Signed-off-by: Chris Wilson <chris(a)chris-wilson.co.uk> Cc: Mika Kuoppala <mika.kuoppala(a)linux.intel.com> Cc: stable(a)vger.kernel.org Reviewed-by: Mika Kuoppala <mika.kuoppala(a)linux.intel.com> --- drivers/gpu/drm/i915/i915_gpu_error.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c index 3e6cbb0d1150..a635ec8d0b94 100644 --- a/drivers/gpu/drm/i915/i915_gpu_error.c +++ b/drivers/gpu/drm/i915/i915_gpu_error.c @@ -311,6 +311,8 @@ static int compress_page(struct i915_vma_compress *c, if (zlib_deflate(zstream, Z_NO_FLUSH) != Z_OK) return -EIO; + + cond_resched(); } while (zstream->avail_in); /* Fallback to uncompressed if we increase size? */ @@ -397,6 +399,7 @@ static int compress_page(struct i915_vma_compress *c, if (!(wc && i915_memcpy_from_wc(ptr, src, PAGE_SIZE))) memcpy(ptr, src, PAGE_SIZE); dst->pages[dst->page_count++] = ptr; + cond_resched(); return 0; } -- 2.20.1

4 years, 3 months

3
2
0 0

[PATCH] usb: mtu3: fix panic in mtu3_gadget_disconnect()

by Macpaul Lin

This patch fixes a possible issue when mtu3_gadget_stop() already assigned NULL to mtu->gadget_driver during mtu_gadget_disconnect(). Backtrace: [<ffffff9008161974>] notifier_call_chain+0xa4/0x128 [<ffffff9008161fd4>] __atomic_notifier_call_chain+0x84/0x138 [<ffffff9008162ec0>] notify_die+0xb0/0x120 [<ffffff900809e340>] die+0x1f8/0x5d0 [<ffffff90080d03b4>] __do_kernel_fault+0x19c/0x280 [<ffffff90080d04dc>] do_bad_area+0x44/0x140 [<ffffff90080d0f9c>] do_translation_fault+0x4c/0x90 [<ffffff9008080a78>] do_mem_abort+0xb8/0x258 [<ffffff90080849d0>] el1_da+0x24/0x3c [<ffffff9009bde01c>] mtu3_gadget_disconnect+0xac/0x128 [<ffffff9009bd576c>] mtu3_irq+0x34c/0xc18 [<ffffff90082ac03c>] __handle_irq_event_percpu+0x2ac/0xcd0 [<ffffff90082acae0>] handle_irq_event_percpu+0x80/0x138 [<ffffff90082acc44>] handle_irq_event+0xac/0x148 [<ffffff90082b71cc>] handle_fasteoi_irq+0x234/0x568 [<ffffff90082a8708>] generic_handle_irq+0x48/0x68 [<ffffff90082a96ac>] __handle_domain_irq+0x264/0x1740 [<ffffff90080819f4>] gic_handle_irq+0x14c/0x250 [<ffffff9008084cec>] el1_irq+0xec/0x194 [<ffffff90085b985c>] dma_pool_alloc+0x6e4/0xae0 [<ffffff9008d7f890>] cmdq_mbox_pool_alloc_impl+0xb0/0x238 [<ffffff9008d80904>] cmdq_pkt_alloc_buf+0x2dc/0x7c0 [<ffffff9008d80f60>] cmdq_pkt_add_cmd_buffer+0x178/0x270 [<ffffff9008d82320>] cmdq_pkt_perf_begin+0x108/0x148 [<ffffff9008d824d8>] cmdq_pkt_create+0x178/0x1f0 [<ffffff9008f96230>] mtk_crtc_config_default_path+0x328/0x7a0 [<ffffff90090246cc>] mtk_drm_idlemgr_kick+0xa6c/0x1460 [<ffffff9008f9bbb4>] mtk_drm_crtc_atomic_begin+0x1a4/0x1a68 [<ffffff9008e8df9c>] drm_atomic_helper_commit_planes+0x154/0x878 [<ffffff9008f2fb70>] mtk_atomic_complete.isra.16+0xe80/0x19c8 [<ffffff9008f30910>] mtk_atomic_commit+0x258/0x898 [<ffffff9008ef142c>] drm_atomic_commit+0xcc/0x108 [<ffffff9008ef7cf0>] drm_mode_atomic_ioctl+0x1c20/0x2580 [<ffffff9008ebc768>] drm_ioctl_kernel+0x118/0x1b0 [<ffffff9008ebcde8>] drm_ioctl+0x5c0/0x920 [<ffffff900863b030>] do_vfs_ioctl+0x188/0x1820 [<ffffff900863c754>] SyS_ioctl+0x8c/0xa0 Signed-off-by: Macpaul Lin <macpaul.lin(a)mediatek.com> Cc: stable(a)vger.kernel.org --- drivers/usb/mtu3/mtu3_gadget.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/usb/mtu3/mtu3_gadget.c b/drivers/usb/mtu3/mtu3_gadget.c index 68ea4395f871..f20fb83b3239 100644 --- a/drivers/usb/mtu3/mtu3_gadget.c +++ b/drivers/usb/mtu3/mtu3_gadget.c @@ -843,7 +843,12 @@ void mtu3_gadget_disconnect(struct mtu3 *mtu) dev_dbg(mtu->dev, "gadget DISCONNECT\n"); if (mtu->gadget_driver && mtu->gadget_driver->disconnect) { spin_unlock(&mtu->lock); - mtu->gadget_driver->disconnect(&mtu->g); + /* + * avoid kernel panic because mtu3_gadget_stop() assigned NULL + * to mtu->gadget_driver. + */ + if (mtu->gadget_driver && mtu->gadget_driver->disconnect) + mtu->gadget_driver->disconnect(&mtu->g); spin_lock(&mtu->lock); } -- 2.18.0

4 years, 3 months

4
7
0 0

[PATCH] x86/mpx: fix recursive munmap() corruption

by Dave Hansen

This is a bit of a mess, to put it mildly. But, it's a bug that seems to have gone unticked up to now, probably because nobody uses MPX. The other alternative to this fix is to just deprecate MPX, even in -stable kernels. MPX has the arch_unmap() hook inside of munmap() because MPX uses bounds tables that protect other areas of memory. When memory is unmapped, there is also a need to unmap the MPX bounds tables. Barring this, unused bounds tables can eat 80% of the address space. But, the recursive do_munmap() that gets called vi arch_unmap() wreaks havoc with __do_munmap()'s state. It can result in freeing populated page tables, accessing bogus VMA state, double-freed VMAs and more. To fix this, call arch_unmap() before __do_unmap() has a chance to do anything meaningful. Also, remove the 'vma' argument and force the MPX code to do its own, independent VMA lookup. For the common success case this is functionally identical to what was there before. For the munmap() failure case, it's possible that some MPX tables will be zapped for memory that continues to be in use. But, this is an extraordinarily unlikely scenario and the harm would be that MPX provides no protection since the bounds table got reset (zeroed). I can't imagine anyone doing this: ptr = mmap(); // use ptr ret = munmap(ptr); if (ret) // oh, there was an error, I'll // keep using ptr. Because if you're doing munmap(), you are *done* with the memory. There's probably no good data in there _anyway_. This passes the original reproducer from Richard Biener as well as the existing mpx selftests/. ==== The long story: munmap() has a couple of pieces: 1. Find the affected VMA(s) 2. Split the start/end one(s) if neceesary 3. Pull the VMAs out of the rbtree 4. Actually zap the memory via unmap_region(), including freeing page tables (or queueing them to be freed). 5. Fixup some of the accounting (like fput()) and actually free the VMA itself. I decided to put the arch_unmap() call right afer #3. This was *just* before mmap_sem looked like it might get downgraded (it won't in this context), but it looked right. It wasn't. Richard Biener reported a test that shows this in dmesg: [1216548.787498] BUG: Bad rss-counter state mm:0000000017ce560b idx:1 val:551 [1216548.787500] BUG: non-zero pgtables_bytes on freeing mm: 24576 What triggered this was the recursive do_munmap() called via arch_unmap(). It was freeing page tables that has not been properly zapped. But, the problem was bigger than this. For one, arch_unmap() can free VMAs. But, the calling __do_munmap() has variables that *point* to VMAs and obviously can't handle them just getting freed while the pointer is still valid. I tried a couple of things here. First, I tried to fix the page table freeing problem in isolation, but I then found the VMA issue. I also tried having the MPX code return a flag if it modified the rbtree which would force __do_munmap() to re-walk to restart. That spiralled out of control in complexity pretty fast. Just moving arch_unmap() and accepting that the bonkers failure case might eat some bounds tables seems like the simplest viable fix. Reported-by: Richard Biener <rguenther(a)suse.de> Cc: Michal Hocko <mhocko(a)suse.com> Cc: Vlastimil Babka <vbabka(a)suse.cz> Cc: Andy Lutomirski <luto(a)amacapital.net> Cc: x86(a)kernel.org Cc: Andrew Morton <akpm(a)linux-foundation.org> Cc: linux-kernel(a)vger.kernel.org Cc: linux-mm(a)kvack.org Cc: stable(a)vger.kernel.org --- b/arch/x86/include/asm/mmu_context.h | 6 +++--- b/arch/x86/include/asm/mpx.h | 5 ++--- b/arch/x86/mm/mpx.c | 10 ++++++---- b/include/asm-generic/mm_hooks.h | 1 - b/mm/mmap.c | 15 ++++++++------- 5 files changed, 19 insertions(+), 18 deletions(-) diff -puN mm/mmap.c~mpx-rss-pass-no-vma mm/mmap.c --- a/mm/mmap.c~mpx-rss-pass-no-vma 2019-04-01 06:56:53.409411123 -0700 +++ b/mm/mmap.c 2019-04-01 06:56:53.423411123 -0700 @@ -2731,9 +2731,17 @@ int __do_munmap(struct mm_struct *mm, un return -EINVAL; len = PAGE_ALIGN(len); + end = start + len; if (len == 0) return -EINVAL; + /* + * arch_unmap() might do unmaps itself. It must be called + * and finish any rbtree manipulation before this code + * runs and also starts to manipulate the rbtree. + */ + arch_unmap(mm, start, end); + /* Find the first overlapping VMA */ vma = find_vma(mm, start); if (!vma) @@ -2742,7 +2750,6 @@ int __do_munmap(struct mm_struct *mm, un /* we have start < vma->vm_end */ /* if it doesn't overlap, we have nothing.. */ - end = start + len; if (vma->vm_start >= end) return 0; @@ -2812,12 +2819,6 @@ int __do_munmap(struct mm_struct *mm, un /* Detach vmas from rbtree */ detach_vmas_to_be_unmapped(mm, vma, prev, end); - /* - * mpx unmap needs to be called with mmap_sem held for write. - * It is safe to call it before unmap_region(). - */ - arch_unmap(mm, vma, start, end); - if (downgrade) downgrade_write(&mm->mmap_sem); diff -puN arch/x86/include/asm/mmu_context.h~mpx-rss-pass-no-vma arch/x86/include/asm/mmu_context.h --- a/arch/x86/include/asm/mmu_context.h~mpx-rss-pass-no-vma 2019-04-01 06:56:53.412411123 -0700 +++ b/arch/x86/include/asm/mmu_context.h 2019-04-01 06:56:53.423411123 -0700 @@ -277,8 +277,8 @@ static inline void arch_bprm_mm_init(str mpx_mm_init(mm); } -static inline void arch_unmap(struct mm_struct *mm, struct vm_area_struct *vma, - unsigned long start, unsigned long end) +static inline void arch_unmap(struct mm_struct *mm, unsigned long start, + unsigned long end) { /* * mpx_notify_unmap() goes and reads a rarely-hot @@ -298,7 +298,7 @@ static inline void arch_unmap(struct mm_ * consistently wrong. */ if (unlikely(cpu_feature_enabled(X86_FEATURE_MPX))) - mpx_notify_unmap(mm, vma, start, end); + mpx_notify_unmap(mm, start, end); } /* diff -puN include/asm-generic/mm_hooks.h~mpx-rss-pass-no-vma include/asm-generic/mm_hooks.h --- a/include/asm-generic/mm_hooks.h~mpx-rss-pass-no-vma 2019-04-01 06:56:53.414411123 -0700 +++ b/include/asm-generic/mm_hooks.h 2019-04-01 06:56:53.423411123 -0700 @@ -18,7 +18,6 @@ static inline void arch_exit_mmap(struct } static inline void arch_unmap(struct mm_struct *mm, - struct vm_area_struct *vma, unsigned long start, unsigned long end) { } diff -puN arch/x86/mm/mpx.c~mpx-rss-pass-no-vma arch/x86/mm/mpx.c --- a/arch/x86/mm/mpx.c~mpx-rss-pass-no-vma 2019-04-01 06:56:53.416411123 -0700 +++ b/arch/x86/mm/mpx.c 2019-04-01 06:56:53.423411123 -0700 @@ -881,9 +881,10 @@ static int mpx_unmap_tables(struct mm_st * the virtual address region start...end have already been split if * necessary, and the 'vma' is the first vma in this range (start -> end). */ -void mpx_notify_unmap(struct mm_struct *mm, struct vm_area_struct *vma, - unsigned long start, unsigned long end) +void mpx_notify_unmap(struct mm_struct *mm, unsigned long start, + unsigned long end) { + struct vm_area_struct *vma; int ret; /* @@ -902,11 +903,12 @@ void mpx_notify_unmap(struct mm_struct * * which should not occur normally. Being strict about it here * helps ensure that we do not have an exploitable stack overflow. */ - do { + vma = find_vma(mm, start); + while (vma && vma->vm_start < end) { if (vma->vm_flags & VM_MPX) return; vma = vma->vm_next; - } while (vma && vma->vm_start < end); + } ret = mpx_unmap_tables(mm, start, end); if (ret) diff -puN arch/x86/include/asm/mpx.h~mpx-rss-pass-no-vma arch/x86/include/asm/mpx.h --- a/arch/x86/include/asm/mpx.h~mpx-rss-pass-no-vma 2019-04-01 06:56:53.418411123 -0700 +++ b/arch/x86/include/asm/mpx.h 2019-04-01 06:56:53.424411123 -0700 @@ -78,8 +78,8 @@ static inline void mpx_mm_init(struct mm */ mm->context.bd_addr = MPX_INVALID_BOUNDS_DIR; } -void mpx_notify_unmap(struct mm_struct *mm, struct vm_area_struct *vma, - unsigned long start, unsigned long end); +void mpx_notify_unmap(struct mm_struct *mm, unsigned long start, + unsigned long end); unsigned long mpx_unmapped_area_check(unsigned long addr, unsigned long len, unsigned long flags); @@ -100,7 +100,6 @@ static inline void mpx_mm_init(struct mm { } static inline void mpx_notify_unmap(struct mm_struct *mm, - struct vm_area_struct *vma, unsigned long start, unsigned long end) { } _

4 years, 3 months

7
13
0 0

[PATCH 4.4 000/149] 4.4.233-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.4.233 release. There are 149 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat, 22 Aug 2020 09:21:01 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.233-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.4.233-rc1 WANG Cong <xiyou.wangcong(a)gmail.com> ipv6: check skb->protocol before lookup for nexthop Denis Efremov <efremov(a)linux.com> drm/radeon: fix fb_div check in ni_init_smc_spll_table() Geert Uytterhoeven <geert+renesas(a)glider.be> sh: landisk: Add missing initialization of sh_io_port_base Dinghao Liu <dinghao.liu(a)zju.edu.cn> ALSA: echoaudio: Fix potential Oops in snd_echo_resume() Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> mfd: dln2: Run event handler loop under spinlock Colin Ian King <colin.king(a)canonical.com> fs/ufs: avoid potential u32 multiplication overflow Jeffrey Mitchell <jeffrey.mitchell(a)starlab.io> nfs: Fix getxattr kernel panic and memory overflow Dan Carpenter <dan.carpenter(a)oracle.com> drm/vmwgfx: Fix two list_for_each loop exit tests Colin Ian King <colin.king(a)canonical.com> Input: sentelic - fix error return when fsp_reg_write fails Xu Wang <vulab(a)iscas.ac.cn> clk: clk-atlas6: fix return value check in atlas6_clk_init() Wolfram Sang <wsa+renesas(a)sang-engineering.com> i2c: rcar: slave: only send STOP event when we have been addressed Liu Yi L <yi.l.liu(a)intel.com> iommu/vt-d: Enforce PASID devTLB field mask Colin Ian King <colin.king(a)canonical.com> iommu/omap: Check for failure of a call to omap_iommu_dump_ctx Johan Hovold <johan(a)kernel.org> USB: serial: ftdi_sio: fix break and sysrq handling Johan Hovold <johan(a)kernel.org> USB: serial: ftdi_sio: clean up receive processing Johan Hovold <johan(a)kernel.org> USB: serial: ftdi_sio: make process-packet buffer unsigned Anton Blanchard <anton(a)ozlabs.org> pseries: Fix 64 bit logical memory block panic Muchun Song <songmuchun(a)bytedance.com> kprobes: Fix NULL pointer dereference at kprobe_ftrace_handler Junxiao Bi <junxiao.bi(a)oracle.com> ocfs2: change slot number type s16 to u16 Mikulas Patocka <mpatocka(a)redhat.com> ext2: fix missing percpu_counter_inc Huacai Chen <chenhc(a)lemote.com> MIPS: CPU#0 is not hotpluggable Johannes Berg <johannes.berg(a)intel.com> mac80211: fix misplaced while instead of if Coly Li <colyli(a)suse.de> bcache: allocate meta data pages as compound pages ChangSyun Peng <allenpeng(a)synology.com> md/raid5: Fix Force reconstruct-write io stuck in degraded raid5 Jonathan McDowell <noodles(a)earth.li> net: stmmac: dwmac1000: provide multicast filter fallback Jonathan McDowell <noodles(a)earth.li> net: ethernet: stmmac: Disable hardware multicast filter Michael Ellerman <mpe(a)ellerman.id.au> powerpc: Fix circular dependency between percpu.h and mmu.h Filipe Manana <fdmanana(a)suse.com> btrfs: fix memory leaks after failure to lookup checksums during inode logging Josef Bacik <josef(a)toxicpanda.com> btrfs: only search for left_info if there is no right_info in try_merge_free_space Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> PCI: hotplug: ACPI: Fix context refcounting in acpiphp_grab_context() Roger Pau Monne <roger.pau(a)citrix.com> xen/balloon: make the balloon wait interruptible Roger Pau Monne <roger.pau(a)citrix.com> xen/balloon: fix accounting in alloc_xenballooned_pages error path Nathan Huckleberry <nhuck(a)google.com> ARM: 8992/1: Fix unwind_frame for clang-built kernels Sven Schnelle <svens(a)stackframe.org> parisc: mask out enable and reserved bits from sba imask Zheng Bin <zhengbin13(a)huawei.com> 9p: Fix memory leak in v9fs_mount Hector Martin <marcan(a)marcan.st> ALSA: usb-audio: work around streaming quirk for MacroSilicon MS2109 Eric Biggers <ebiggers(a)google.com> fs/minix: reject too-large maximum file size Eric Biggers <ebiggers(a)google.com> fs/minix: don't allow getting deleted inodes Eric Biggers <ebiggers(a)google.com> fs/minix: check return value of sb_getblk() Tom Rix <trix(a)redhat.com> crypto: qat - fix double free in qat_uclo_create_batch_init_list Hector Martin <marcan(a)marcan.st> ALSA: usb-audio: add quirk for Pioneer DDJ-RB Hector Martin <marcan(a)marcan.st> ALSA: usb-audio: fix overeager device match for MacroSilicon MS2109 Mirko Dietrich <buzz(a)l4m1.de> ALSA: usb-audio: Creative USB X-Fi Pro SB1095 volume knob support Miaohe Lin <linmiaohe(a)huawei.com> net: Set fput_needed iff FDPUT_FPUT is set Qingyu Li <ieatmuttonchuan(a)gmail.com> net/nfc/rawsock.c: add CAP_NET_RAW check. Xie He <xie.he.0141(a)gmail.com> drivers/net/wan/lapbether: Added needed_headroom and a skb->len check Drew Fustini <drew(a)beagleboard.org> pinctrl-single: fix pcs_parse_pinconf() return value Wang Hai <wanghai38(a)huawei.com> dlm: Fix kobject memleak Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> net: spider_net: Fix the size used in a 'dma_free_coherent()' call Wang Hai <wanghai38(a)huawei.com> wl1251: fix always return 0 error Julian Wiedmann <jwi(a)linux.ibm.com> s390/qeth: don't process empty bridge port events Tom Rix <trix(a)redhat.com> power: supply: check if calc_soc succeeded in pm860x_init_battery Dan Carpenter <dan.carpenter(a)oracle.com> Smack: prevent underflow in smk_set_cipso() Dan Carpenter <dan.carpenter(a)oracle.com> Smack: fix another vsscanf out of bounds Finn Thain <fthain(a)telegraphics.com.au> scsi: mesh: Fix panic after host or bus reset Marek Szyprowski <m.szyprowski(a)samsung.com> usb: dwc2: Fix error path in gadget registration Xiongfeng Wang <wangxiongfeng2(a)huawei.com> PCI/ASPM: Add missing newline in sysfs 'policy' Milton Miller <miltonm(a)us.ibm.com> powerpc/vdso: Fix vdso cpu truncation Dan Carpenter <dan.carpenter(a)oracle.com> mwifiex: Prevent memory corruption handling keys Laurent Pinchart <laurent.pinchart+renesas(a)ideasonboard.com> drm: panel: simple: Fix bpc for LG LB070WV8 panel Chuhong Yuan <hslester96(a)gmail.com> media: exynos4-is: Add missed check for pinctrl_lookup_state() Dan Carpenter <dan.carpenter(a)oracle.com> media: firewire: Using uninitialized values in node_probe() Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> scsi: eesox: Fix different dev_id between request_irq() and free_irq() Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> scsi: powertec: Fix different dev_id between request_irq() and free_irq() Colin Ian King <colin.king(a)canonical.com> drm/radeon: fix array out-of-bounds read and write issues Wang Hai <wanghai38(a)huawei.com> cxl: Fix kobject memleak Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> scsi: cumana_2: Fix different dev_id between request_irq() and free_irq() Chuhong Yuan <hslester96(a)gmail.com> media: omap3isp: Add missed v4l2_ctrl_handler_free() for preview_init_entities() Arnd Bergmann <arnd(a)arndb.de> leds: lm355x: avoid enum conversion warning Tomasz Duszynski <tomasz.duszynski(a)octakon.com> iio: improve IIO_CONCENTRATION channel type description Dejin Zheng <zhengdejin5(a)gmail.com> console: newport_con: fix an issue about leak related system resources Dejin Zheng <zhengdejin5(a)gmail.com> video: fbdev: sm712fb: fix an issue about iounmap for a wrong address Qiushi Wu <wu000273(a)umn.edu> agp/intel: Fix a memory leak on module initialisation failure Erik Kaneda <erik.kaneda(a)intel.com> ACPICA: Do not increment operation_region reference counts for field units Coly Li <colyli(a)suse.de> bcache: fix super block seq numbers comparision in register_cache_set() Jim Cromie <jim.cromie(a)gmail.com> dyndbg: fix a BUG_ON in ddebug_describe_flags Sasi Kumar <sasi.kumar(a)broadcom.com> bdc: Fix bug causing crash after multiple disconnects Evgeny Novikov <novikov(a)ispras.ru> usb: gadget: net2280: fix memory leak on probe error handling paths Bolarinwa Olayemi Saheed <refactormyself(a)gmail.com> iwlegacy: Check the return value of pcie_capability_read_*() Prasanna Kerekoppa <prasanna.kerekoppa(a)cypress.com> brcmfmac: To fix Bss Info flag definition Bug Paul E. McKenney <paulmck(a)kernel.org> mm/mmap.c: Add cond_resched() for exit_mmap() CPU stalls Michael Tretter <m.tretter(a)pengutronix.de> drm/debugfs: fix plain echo to connector "force" attribute Aditya Pakki <pakki001(a)umn.edu> drm/nouveau: fix multiple instances of reference count leaks Evgeny Novikov <novikov(a)ispras.ru> video: fbdev: neofb: fix memory leak in neo_scan_monitor() Aditya Pakki <pakki001(a)umn.edu> drm/radeon: Fix reference count leaks caused by pm_runtime_get_sync Paul E. McKenney <paulmck(a)kernel.org> fs/btrfs: Add cond_resched() for try_release_extent_mapping() stalls Lihong Kou <koulihong(a)huawei.com> Bluetooth: add a mutex lock to avoid UAF in do_enale_set Tomi Valkeinen <tomi.valkeinen(a)ti.com> drm/tilcdc: fix leak & null ref in panel_connector_get_modes Yu Kuai <yukuai3(a)huawei.com> ARM: socfpga: PM: add missing put_device() call in socfpga_setup_ocram_self_refresh() yu kuai <yukuai3(a)huawei.com> ARM: at91: pm: add missing put_device() call in at91_pm_sram_init() Finn Thain <fthain(a)telegraphics.com.au> m68k: mac: Fix IOP status/control register writes Finn Thain <fthain(a)telegraphics.com.au> m68k: mac: Don't send IOP message until channel is idle Qiushi Wu <wu000273(a)umn.edu> EDAC: Fix reference count leaks Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> gpio: fix oops resulting from calling of_get_named_gpio(NULL, ...) Dexuan Cui <decui(a)microsoft.com> udp: drop corrupt packets earlier to avoid data corruption Nick Desaulniers <ndesaulniers(a)google.com> tracepoint: Mark __tracepoint_string's __used Eric Biggers <ebiggers(a)google.com> Smack: fix use-after-free in smk_write_relabel_self() Ido Schimmel <idosch(a)mellanox.com> vxlan: Ensure FDB dump is performed under RCU Rustam Kovhaev <rkovhaev(a)gmail.com> usb: hso: check for return value in hso_serial_common_create() Johan Hovold <johan(a)kernel.org> net: lan78xx: replace bogus endpoint lookup Hangbin Liu <liuhangbin(a)gmail.com> Revert "vxlan: fix tos value before xmit" Cong Wang <xiyou.wangcong(a)gmail.com> ipv6: fix memory leaks on IPV6_ADDRFORM path Ido Schimmel <idosch(a)mellanox.com> ipv4: Silence suspicious RCU usage warning Jann Horn <jannh(a)google.com> binder: Prevent context manager from incrementing ref 0 Philippe Duplessis-Guindon <pduplessis(a)efficios.com> tools lib traceevent: Fix memory leak in process_dynamic_array_len Xin Xiong <xiongx18(a)fudan.edu.cn> atm: fix atm_dev refcnt leaks in atmtcp_remove_persistent Francesco Ruggeri <fruggeri(a)arista.com> igb: reinit_locked() should be called with rtnl_lock Julian Squires <julian(a)cipht.net> cfg80211: check vendor command doit pointer before use Ben Skeggs <bskeggs(a)redhat.com> drm/nouveau/fbcon: fix module unload when fbcon init has failed for some reason Christoph Hellwig <hch(a)lst.de> net/9p: validate fds in p9_fd_open Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> mtd: properly check all write ioctls for permissions Yunhai Zhang <zhangyunhai(a)nsfocus.com> vgacon: Fix for missing check in scrollback handling Peilin Ye <yepeilin.cs(a)gmail.com> Bluetooth: Prevent out-of-bounds read in hci_inquiry_result_with_rssi_evt() Peilin Ye <yepeilin.cs(a)gmail.com> Bluetooth: Prevent out-of-bounds read in hci_inquiry_result_evt() Peilin Ye <yepeilin.cs(a)gmail.com> Bluetooth: Fix slab-out-of-bounds read in hci_extended_inquiry_result_evt() Takashi Iwai <tiwai(a)suse.de> ALSA: seq: oss: Serialize ioctls Erik Ekman <erik(a)kryo.se> USB: serial: qcserial: add EM7305 QDL product ID Jiang Ying <jiangying8582(a)126.com> ext4: fix direct I/O read error Linus Torvalds <torvalds(a)linux-foundation.org> random32: move the pseudo-random 32-bit definitions to prandom.h Linus Torvalds <torvalds(a)linux-foundation.org> random32: remove net_rand_state from the latent entropy gcc plugin Willy Tarreau <w(a)1wt.eu> random: fix circular include dependency on arm64 after addition of percpu.h Grygorii Strashko <grygorii.strashko(a)ti.com> ARM: percpu.h: fix build error Willy Tarreau <w(a)1wt.eu> random32: update the net random state on interrupt and activity Thomas Gleixner <tglx(a)linutronix.de> x86/i8259: Use printk_deferred() to prevent deadlock Andrea Righi <andrea.righi(a)canonical.com> xen-netfront: fix potential deadlock in xennet_remove() Raviteja Narayanam <raviteja.narayanam(a)xilinx.com> Revert "i2c: cadence: Fix the hold bit setting" Yoshihiro Shimoda <yoshihiro.shimoda.uh(a)renesas.com> net: ethernet: ravb: exit if re-initialization fails in tx timeout Navid Emamdoost <navid.emamdoost(a)gmail.com> nfc: s3fwrn5: add missing release on skb in s3fwrn5_recv_frame Remi Pommarel <repk(a)triplefau.lt> mac80211: mesh: Free ie data when leaving mesh Ido Schimmel <idosch(a)mellanox.com> mlxsw: core: Increase scope of RCU read-side critical section Johan Hovold <johan(a)kernel.org> net: lan78xx: fix transfer-buffer memory leak Johan Hovold <johan(a)kernel.org> net: lan78xx: add missing endpoint sanity check Michael Karcher <kernel(a)mkarcher.dialup.fu-berlin.de> sh: Fix validation of system call number YueHaibing <yuehaibing(a)huawei.com> net/x25: Fix null-ptr-deref in x25_disconnect Xiyu Yang <xiyuyang19(a)fudan.edu.cn> net/x25: Fix x25_neigh refcnt leak when x25 disconnect Peilin Ye <yepeilin.cs(a)gmail.com> rds: Prevent kernel-infoleak in rds_notify_queue_get() Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> fbdev: Detect integer underflow at "struct fbcon_ops"->clear_margins. Will Deacon <will(a)kernel.org> ARM: 8986/1: hw_breakpoint: Don't invoke overflow handler on uaccess watchpoints Sheng Yong <shengyong1(a)huawei.com> f2fs: check if file namelen exceeds max value Jaegeuk Kim <jaegeuk(a)kernel.org> f2fs: check memory boundary by insane namelen Steve Cohen <cohens(a)codeaurora.org> drm: hold gem reference until object is no longer accessed Peilin Ye <yepeilin.cs(a)gmail.com> drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl() Robert Hancock <hancockrwd(a)gmail.com> PCI/ASPM: Disable ASPM on ASMedia ASM1083/1085 PCIe-to-PCI bridge Andreas Gruenbacher <agruenba(a)redhat.com> nfs: Move call to security_inode_listsecurity into nfs_listxattr Navid Emamdoost <navid.emamdoost(a)gmail.com> ath9k: release allocated buffer if timed out Navid Emamdoost <navid.emamdoost(a)gmail.com> ath9k_htc: release allocated buffer if timed out Navid Emamdoost <navid.emamdoost(a)gmail.com> media: rc: prevent memory leak in cx23888_ir_probe Wei Yongjun <weiyongjun1(a)huawei.com> net: phy: mdio-bcm-unimac: fix potential NULL dereference in unimac_mdio_probe() Eric Sandeen <sandeen(a)sandeen.net> xfs: don't call xfs_da_shrink_inode with NULL bp ------------- Diffstat: Documentation/ABI/testing/sysfs-bus-iio | 3 +- Makefile | 4 +- arch/arm/include/asm/percpu.h | 2 + arch/arm/kernel/hw_breakpoint.c | 27 ++++- arch/arm/kernel/stacktrace.c | 24 +++++ arch/arm/mach-at91/pm.c | 11 +- arch/arm/mach-socfpga/pm.c | 8 +- arch/m68k/mac/iop.c | 21 ++-- arch/mips/kernel/topology.c | 2 +- arch/powerpc/include/asm/percpu.h | 4 +- arch/powerpc/kernel/vdso.c | 2 +- arch/powerpc/platforms/pseries/hotplug-memory.c | 2 +- arch/sh/boards/mach-landisk/setup.c | 3 + arch/sh/kernel/entry-common.S | 6 +- arch/x86/kernel/i8259.c | 2 +- drivers/acpi/acpica/exprep.c | 4 - drivers/acpi/acpica/utdelete.c | 6 +- drivers/android/binder.c | 9 ++ drivers/atm/atmtcp.c | 10 +- drivers/char/agp/intel-gtt.c | 4 +- drivers/char/random.c | 1 + drivers/clk/sirf/clk-atlas6.c | 2 +- drivers/crypto/qat/qat_common/qat_uclo.c | 9 +- drivers/edac/edac_device_sysfs.c | 1 + drivers/edac/edac_pci_sysfs.c | 2 +- drivers/gpio/gpiolib-of.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 3 +- drivers/gpu/drm/drm_debugfs.c | 8 +- drivers/gpu/drm/drm_gem.c | 10 +- drivers/gpu/drm/nouveau/nouveau_drm.c | 8 +- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 1 + drivers/gpu/drm/nouveau/nouveau_gem.c | 4 +- drivers/gpu/drm/panel/panel-simple.c | 2 +- drivers/gpu/drm/radeon/ci_dpm.c | 2 +- drivers/gpu/drm/radeon/ni_dpm.c | 2 +- drivers/gpu/drm/radeon/radeon_display.c | 4 +- drivers/gpu/drm/radeon/radeon_drv.c | 4 +- drivers/gpu/drm/radeon/radeon_kms.c | 4 +- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 6 +- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 8 +- drivers/i2c/busses/i2c-cadence.c | 9 +- drivers/i2c/busses/i2c-rcar.c | 7 +- drivers/input/mouse/sentelic.c | 2 +- drivers/iommu/omap-iommu-debug.c | 3 + drivers/leds/leds-lm355x.c | 7 +- drivers/md/bcache/bset.c | 2 +- drivers/md/bcache/btree.c | 2 +- drivers/md/bcache/journal.c | 4 +- drivers/md/bcache/super.c | 11 +- drivers/md/raid5.c | 3 +- drivers/media/firewire/firedtv-fw.c | 2 + drivers/media/pci/cx23885/cx23888-ir.c | 5 +- drivers/media/platform/exynos4-is/media-dev.c | 3 + drivers/media/platform/omap3isp/isppreview.c | 4 +- drivers/mfd/dln2.c | 4 + drivers/misc/cxl/sysfs.c | 5 +- drivers/mtd/mtdchar.c | 56 +++++++++-- drivers/net/ethernet/intel/igb/igb_main.c | 9 ++ drivers/net/ethernet/mellanox/mlxsw/core.c | 6 +- drivers/net/ethernet/renesas/ravb_main.c | 26 ++++- .../net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 1 + .../net/ethernet/stmicro/stmmac/dwmac1000_core.c | 3 + drivers/net/ethernet/toshiba/spider_net.c | 4 +- drivers/net/phy/mdio-bcm-unimac.c | 2 + drivers/net/usb/hso.c | 5 +- drivers/net/usb/lan78xx.c | 112 ++++++--------------- drivers/net/vxlan.c | 8 +- drivers/net/wan/lapbether.c | 10 +- drivers/net/wireless/ath/ath9k/htc_hst.c | 3 + drivers/net/wireless/ath/ath9k/wmi.c | 1 + .../net/wireless/brcm80211/brcmfmac/fwil_types.h | 2 +- drivers/net/wireless/iwlegacy/common.c | 4 +- drivers/net/wireless/mwifiex/sta_cmdresp.c | 22 ++-- drivers/net/wireless/ti/wl1251/event.c | 2 +- drivers/net/xen-netfront.c | 64 ++++++++---- drivers/nfc/s3fwrn5/core.c | 1 + drivers/parisc/sba_iommu.c | 2 +- drivers/pci/hotplug/acpiphp_glue.c | 14 ++- drivers/pci/pcie/aspm.c | 1 + drivers/pci/quirks.c | 13 +++ drivers/pinctrl/pinctrl-single.c | 11 +- drivers/power/88pm860x_battery.c | 6 +- drivers/s390/net/qeth_l2_main.c | 4 + drivers/scsi/arm/cumana_2.c | 2 +- drivers/scsi/arm/eesox.c | 2 +- drivers/scsi/arm/powertec.c | 2 +- drivers/scsi/mesh.c | 8 +- drivers/usb/dwc2/platform.c | 4 +- drivers/usb/gadget/udc/bdc/bdc_core.c | 4 + drivers/usb/gadget/udc/bdc/bdc_ep.c | 16 +-- drivers/usb/gadget/udc/net2280.c | 4 +- drivers/usb/serial/ftdi_sio.c | 57 ++++++----- drivers/usb/serial/qcserial.c | 1 + drivers/video/console/bitblit.c | 4 +- drivers/video/console/fbcon_ccw.c | 4 +- drivers/video/console/fbcon_cw.c | 4 +- drivers/video/console/fbcon_ud.c | 4 +- drivers/video/console/newport_con.c | 12 ++- drivers/video/console/vgacon.c | 4 + drivers/video/fbdev/neofb.c | 1 + drivers/video/fbdev/sm712fb.c | 2 + drivers/xen/balloon.c | 12 ++- fs/9p/v9fs.c | 5 +- fs/btrfs/extent_io.c | 2 + fs/btrfs/free-space-cache.c | 4 +- fs/btrfs/tree-log.c | 8 +- fs/dlm/lockspace.c | 6 +- fs/ext2/ialloc.c | 3 +- fs/ext4/inode.c | 7 ++ fs/f2fs/dir.c | 12 ++- fs/minix/inode.c | 36 ++++++- fs/minix/itree_common.c | 8 +- fs/nfs/nfs4proc.c | 55 ++++++---- fs/nfs/nfs4xdr.c | 6 +- fs/ocfs2/ocfs2.h | 4 +- fs/ocfs2/suballoc.c | 4 +- fs/ocfs2/super.c | 4 +- fs/ufs/super.c | 2 +- fs/xattr.c | 4 + fs/xfs/libxfs/xfs_attr_leaf.c | 5 +- include/linux/intel-iommu.h | 4 +- include/linux/prandom.h | 78 ++++++++++++++ include/linux/random.h | 63 +----------- include/linux/tracepoint.h | 2 +- include/net/addrconf.h | 1 + kernel/kprobes.c | 7 ++ kernel/time/timer.c | 8 ++ lib/dynamic_debug.c | 23 ++--- lib/random32.c | 2 +- mm/mmap.c | 1 + net/9p/trans_fd.c | 24 +++-- net/bluetooth/6lowpan.c | 5 + net/bluetooth/hci_event.c | 11 +- net/ipv4/fib_trie.c | 2 +- net/ipv4/udp.c | 3 +- net/ipv6/anycast.c | 17 +++- net/ipv6/ip6_tunnel.c | 32 +++--- net/ipv6/ipv6_sockglue.c | 1 + net/ipv6/udp.c | 6 +- net/mac80211/cfg.c | 1 + net/mac80211/sta_info.c | 2 +- net/nfc/rawsock.c | 7 +- net/rds/recv.c | 3 +- net/socket.c | 2 +- net/wireless/nl80211.c | 6 +- net/x25/x25_subr.c | 6 ++ security/smack/smack_lsm.c | 2 - security/smack/smackfs.c | 19 +++- sound/core/seq/oss/seq_oss.c | 8 +- sound/pci/echoaudio/echoaudio.c | 2 - sound/usb/card.h | 1 + sound/usb/mixer_quirks.c | 1 + sound/usb/pcm.c | 6 ++ sound/usb/quirks-table.h | 64 +++++++++++- sound/usb/quirks.c | 3 + sound/usb/stream.c | 1 + tools/lib/traceevent/event-parse.c | 1 + 157 files changed, 973 insertions(+), 476 deletions(-)

4 years, 3 months

7
163
0 0

[PATCH v2 0/1] concurrency handling for zoned null-blk

by Kanchan Joshi

Changes since v1: - applied the refactoring suggested by Damien Kanchan Joshi (1): null_blk: synchronization fix for zoned device drivers/block/null_blk.h | 1 + drivers/block/null_blk_zoned.c | 22 ++++++++++++++++++---- 2 files changed, 19 insertions(+), 4 deletions(-) -- 2.25.1

4 years, 3 months

5
7
0 0

[PATCH 4.19 000/125] 4.19.143-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.19.143 release. There are 125 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Thu, 03 Sep 2020 15:09:01 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.143-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.19.143-rc1 Hector Martin <marcan(a)marcan.st> ALSA: usb-audio: Update documentation comment for MS2109 quirk Peilin Ye <yepeilin.cs(a)gmail.com> HID: hiddev: Fix slab-out-of-bounds write in hiddev_ioctl_usage() Jarkko Sakkinen <jarkko.sakkinen(a)linux.intel.com> tpm: Unify the mismatching TPM space buffer sizes Thinh Nguyen <Thinh.Nguyen(a)synopsys.com> usb: dwc3: gadget: Handle ZLP for sg requests Thinh Nguyen <Thinh.Nguyen(a)synopsys.com> usb: dwc3: gadget: Fix handling ZLP Thinh Nguyen <Thinh.Nguyen(a)synopsys.com> usb: dwc3: gadget: Don't setup more than requested Josef Bacik <josef(a)toxicpanda.com> btrfs: check the right error variable in btrfs_del_dir_entries_in_log Alan Stern <stern(a)rowland.harvard.edu> usb: storage: Add unusual_uas entry for Sony PSZ drives Tom Rix <trix(a)redhat.com> USB: cdc-acm: rework notification_buffer resizing Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> USB: gadget: u_f: Unbreak offset calculation in VLAs Brooke Basile <brookebasile(a)gmail.com> USB: gadget: f_ncm: add bounds checks to ncm_unwrap_ntb() Brooke Basile <brookebasile(a)gmail.com> USB: gadget: u_f: add overflow checks to VLA macros Tang Bin <tangbin(a)cmss.chinamobile.com> usb: host: ohci-exynos: Fix error handling in exynos_ohci_probe() Cyril Roelandt <tipecaml(a)gmail.com> USB: Ignore UAS for JMicron JMS567 ATA/ATAPI Bridge Alan Stern <stern(a)rowland.harvard.edu> USB: quirks: Ignore duplicate endpoint on Sound Devices MixPre-D Kai-Heng Feng <kai.heng.feng(a)canonical.com> USB: quirks: Add no-lpm quirk for another Raydium touchscreen Thinh Nguyen <Thinh.Nguyen(a)synopsys.com> usb: uas: Add quirk for PNY Pro Elite Alan Stern <stern(a)rowland.harvard.edu> USB: yurex: Fix bad gfp argument Evan Quan <evan.quan(a)amd.com> drm/amd/pm: correct Vega12 swctf limit setting Evan Quan <evan.quan(a)amd.com> drm/amd/pm: correct Vega10 swctf limit setting Alex Deucher <alexander.deucher(a)amd.com> drm/amdgpu: Fix buffer overflow in INFO ioctl qiuguorui1 <qiuguorui1(a)huawei.com> irqchip/stm32-exti: Avoid losing interrupts due to clearing pending bits by mistake Thomas Gleixner <tglx(a)linutronix.de> genirq/matrix: Deal with the sillyness of for_each_cpu() on UP Heikki Krogerus <heikki.krogerus(a)linux.intel.com> device property: Fix the secondary firmware node handling in set_primary_fwnode() Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> PM: sleep: core: Fix the handling of pending runtime resume requests Ding Hui <dinghui(a)sangfor.com.cn> xhci: Always restore EP_SOFT_CLEAR_TOGGLE even if ep reset failed Kai-Heng Feng <kai.heng.feng(a)canonical.com> xhci: Do warm-reset when both CAS and XDEV_RESUME are set Li Jun <jun.li(a)nxp.com> usb: host: xhci: fix ep context print mismatch in debugfs Thomas Gleixner <tglx(a)linutronix.de> XEN uses irqdesc::irq_data_common::handler_data to store a per interrupt XEN data pointer which contains XEN specific information. Jan Kara <jack(a)suse.cz> writeback: Fix sync livelock due to b_dirty_time processing Jan Kara <jack(a)suse.cz> writeback: Avoid skipping inode writeback Jan Kara <jack(a)suse.cz> writeback: Protect inode->i_io_list with inode->i_lock Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com> serial: 8250: change lock order in serial8250_do_startup() Valmer Huhn <valmer.huhn(a)concurrent-rt.com> serial: 8250_exar: Fix number of ports for Commtech PCIe cards Lukas Wunner <lukas(a)wunner.de> serial: pl011: Don't leak amba_ports entry on driver register error Lukas Wunner <lukas(a)wunner.de> serial: pl011: Fix oops on -EPROBE_DEFER Tamseel Shams <m.shams(a)samsung.com> serial: samsung: Removes the IRQ not found warning George Kennedy <george.kennedy(a)oracle.com> vt_ioctl: change VT_RESIZEX ioctl to check for error return from vc_resize() Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> vt: defer kfree() of vc_screenbuf in vc_do_resize() Evgeny Novikov <novikov(a)ispras.ru> USB: lvtest: return proper error code in probe George Kennedy <george.kennedy(a)oracle.com> fbcon: prevent user font height or width change from causing potential out-of-bounds access Filipe Manana <fdmanana(a)suse.com> btrfs: fix space cache memory leak after transaction abort Marcos Paulo de Souza <mpdesouza(a)suse.com> btrfs: reset compression level for lzo on remount Ming Lei <ming.lei(a)redhat.com> blk-mq: order adding requests to hctx->dispatch and checking SCHED_RESTART Hans de Goede <hdegoede(a)redhat.com> HID: i2c-hid: Always sleep 60ms after I2C_HID_PWR_ON commands Ming Lei <ming.lei(a)redhat.com> block: loop: set discard granularity and alignment for block device backed loop Athira Rajeev <atrajeev(a)linux.vnet.ibm.com> powerpc/perf: Fix soft lockups due to missed interrupt accounting Sumera Priyadarsini <sylphrenadin(a)gmail.com> net: gianfar: Add of_node_put() before goto statement Alvin Šipraga <alsi(a)bang-olufsen.dk> macvlan: validate setting of multiple remote source MAC addresses Saurav Kashyap <skashyap(a)marvell.com> Revert "scsi: qla2xxx: Fix crash on qla2x00_mailbox_command" Quinn Tran <qutran(a)marvell.com> scsi: qla2xxx: Fix null pointer access during disconnect from subsystem Saurav Kashyap <skashyap(a)marvell.com> scsi: qla2xxx: Check if FW supports MQ before enabling Stanley Chu <stanley.chu(a)mediatek.com> scsi: ufs: Clean up completed request without interrupt notification Adrian Hunter <adrian.hunter(a)intel.com> scsi: ufs: Improve interrupt handling for shared interrupts Stanley Chu <stanley.chu(a)mediatek.com> scsi: ufs: Fix possible infinite loop in ufshcd_hold Mike Christie <michael.christie(a)oracle.com> scsi: fcoe: Fix I/O path allocation Sylwester Nawrocki <s.nawrocki(a)samsung.com> ASoC: wm8994: Avoid attempts to read unreadable registers Vineeth Vijayan <vneethv(a)linux.ibm.com> s390/cio: add cond_resched() in the slow_eval_known_fn() loop Amelie Delaunay <amelie.delaunay(a)st.com> spi: stm32: fix stm32_spi_prepare_mbr in case of odd clk_rate Xianting Tian <xianting_tian(a)126.com> fs: prevent BUG_ON in submit_bh_wbc() Jan Kara <jack(a)suse.cz> ext4: correctly restore system zone info when remount fails Jan Kara <jack(a)suse.cz> ext4: handle error of ext4_setup_system_zone() on remount Lukas Czerner <lczerner(a)redhat.com> ext4: handle option set by mount flags correctly zhangyi (F) <yi.zhang(a)huawei.com> jbd2: abort journal if free a async write error metadata buffer Lukas Czerner <lczerner(a)redhat.com> ext4: handle read only external journal device Jan Kara <jack(a)suse.cz> ext4: don't BUG on inconsistent journal feature Lukas Czerner <lczerner(a)redhat.com> jbd2: make sure jh have b_transaction set in refile/unfile_buffer Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> usb: gadget: f_tcm: Fix some resource leaks in some error paths Wolfram Sang <wsa+renesas(a)sang-engineering.com> i2c: rcar: in slave mode, clear NACK earlier Hou Pu <houpu(a)bytedance.com> null_blk: fix passing of REQ_FUA flag in null_handle_rq Tianjia Zhang <tianjia.zhang(a)linux.alibaba.com> nvme-fc: Fix wrong return value in __nvme_fc_init_request() Rob Clark <robdclark(a)chromium.org> drm/msm/adreno: fix updating ring fence Sean Young <sean(a)mess.org> media: gpio-ir-tx: improve precision of transmitted signal due to scheduling Zhi Chen <zhichen(a)codeaurora.org> Revert "ath10k: fix DMA related firmware crashes on multiple devices" Andrey Konovalov <andreyknvl(a)google.com> efi: provide empty efi_enter_virtual_mode implementation Changming Liu <charley.ashbringer(a)gmail.com> USB: sisusbvga: Fix a potential UB casued by left shifting a negative value Arnd Bergmann <arnd(a)arndb.de> powerpc/spufs: add CONFIG_COREDUMP dependency David Brazdil <dbrazdil(a)google.com> KVM: arm64: Fix symbol dependency in __hyp_call_panic_nvhe Evgeny Novikov <novikov(a)ispras.ru> media: davinci: vpif_capture: fix potential double free Jason Baron <jbaron(a)akamai.com> EDAC/ie31200: Fallback if host bridge device is already initialized Javed Hasan <jhasan(a)marvell.com> scsi: fcoe: Memory leak fix in fcoe_sysfs_fcf_del() Xiubo Li <xiubli(a)redhat.com> ceph: fix potential mdsc use-after-free crash Jing Xiangfeng <jingxiangfeng(a)huawei.com> scsi: iscsi: Do not put host in iscsi_set_flashnode_param() Qu Wenruo <wqu(a)suse.com> btrfs: file: reserve qgroup space after the hole punch range is locked Chris Wilson <chris(a)chris-wilson.co.uk> locking/lockdep: Fix overflow in presentation of average lock-time Aditya Pakki <pakki001(a)umn.edu> drm/nouveau: Fix reference count leak in nouveau_connector_detect Aditya Pakki <pakki001(a)umn.edu> drm/nouveau: fix reference count leak in nv50_disp_atomic_commit Aditya Pakki <pakki001(a)umn.edu> drm/nouveau/drm/noveau: fix reference count leak in nouveau_fbcon_open Li Guifu <bluce.liguifu(a)huawei.com> f2fs: fix use-after-free issue Ikjoon Jang <ikjn(a)chromium.org> HID: quirks: add NOGET quirk for Logitech GROUP Hans Verkuil <hverkuil-cisco(a)xs4all.nl> cec-api: prevent leaking memory through hole in structure Peng Fan <fanpeng(a)loongson.cn> mips/vdso: Fix resource leaks in genvdso.c Reto Schneider <code(a)reto-schneider.ch> rtlwifi: rtl8192cu: Prevent leaking urb Yangbo Lu <yangbo.lu(a)nxp.com> ARM: dts: ls1021a: output PPS signal on FIPER2 Qiushi Wu <wu000273(a)umn.edu> PCI: Fix pci_create_slot() reference count leak Aditya Pakki <pakki001(a)umn.edu> omapfb: fix multiple reference count leaks due to pm_runtime_get_sync Chao Yu <yuchao0(a)huawei.com> f2fs: fix error path in do_recover_data() Desnes A. Nunes do Rosario <desnesn(a)linux.ibm.com> selftests/powerpc: Purge extra count_pmc() calls of ebb selftests Dave Chinner <dchinner(a)redhat.com> xfs: Don't allow logging of XFS_ISTALE inodes Dick Kennedy <dick.kennedy(a)broadcom.com> scsi: lpfc: Fix shost refcount mismatch when deleting vport Navid Emamdoost <navid.emamdoost(a)gmail.com> drm/amdgpu/display: fix ref count leak when pm_runtime_get_sync fails Navid Emamdoost <navid.emamdoost(a)gmail.com> drm/amdgpu: fix ref count leak in amdgpu_display_crtc_set_config Navid Emamdoost <navid.emamdoost(a)gmail.com> drm/amd/display: fix ref count leak in amdgpu_drm_ioctl Navid Emamdoost <navid.emamdoost(a)gmail.com> drm/amdgpu: fix ref count leak in amdgpu_driver_open_kms Aditya Pakki <pakki001(a)umn.edu> drm/radeon: fix multiple reference count leak Qiushi Wu <wu000273(a)umn.edu> drm/amdkfd: Fix reference count leaks. Robin Murphy <robin.murphy(a)arm.com> iommu/iova: Don't BUG on invalid PFNs Bodo Stroesser <bstroesser(a)ts.fujitsu.com> scsi: target: tcmu: Fix crash on ARM during cmd completion Luis Chamberlain <mcgrof(a)kernel.org> blktrace: ensure our debugfs dir exists Jia-Ju Bai <baijiaju(a)tsinghua.edu.cn> media: pci: ttpci: av7110: fix possible buffer overflow caused by bad DMA value in debiirq() Alexey Kardashevskiy <aik(a)ozlabs.ru> powerpc/xive: Ignore kmemleak false positives Stephan Gerhold <stephan(a)gerhold.net> arm64: dts: qcom: msm8916: Pull down PDM GPIOs during sleep Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> mfd: intel-lpss: Add Intel Emmitsburg PCH PCI IDs Qiushi Wu <wu000273(a)umn.edu> ASoC: tegra: Fix reference count leaks. Qiushi Wu <wu000273(a)umn.edu> ASoC: img-parallel-out: Fix a reference count leak Qiushi Wu <wu000273(a)umn.edu> ASoC: img: Fix a reference count leak in img_i2s_in_set_fmt Randy Dunlap <rdunlap(a)infradead.org> ALSA: pci: delete repeated words in comments Mahesh Bandewar <maheshb(a)google.com> ipvlan: fix device features Shay Agroskin <shayagr(a)amazon.com> net: ena: Make missed_tx stat incremental Cong Wang <xiyou.wangcong(a)gmail.com> tipc: fix uninit skb->data in tipc_nl_compat_dumpit() Peilin Ye <yepeilin.cs(a)gmail.com> net/smc: Prevent kernel-infoleak in __smc_diag_dump() Necip Fazil Yildiran <necip(a)google.com> net: qrtr: fix usage of idr in port assignment to socket Miaohe Lin <linmiaohe(a)huawei.com> net: Fix potential wrong skb->protocol in skb_vlan_untag() Mark Tomlinson <mark.tomlinson(a)alliedtelesis.co.nz> gre6: Fix reception with IP6_TNL_F_RCV_DSCP_COPY Michael Ellerman <mpe(a)ellerman.id.au> powerpc/64s: Don't init FSCR_DSCR in __init_FSCR() ------------- Diffstat: Makefile | 4 +- arch/arm/boot/dts/ls1021a.dtsi | 2 +- arch/arm64/boot/dts/qcom/msm8916-pins.dtsi | 2 +- arch/arm64/kvm/hyp/switch.c | 2 +- arch/mips/vdso/genvdso.c | 10 ++ arch/powerpc/kernel/cpu_setup_power.S | 2 +- arch/powerpc/perf/core-book3s.c | 4 + arch/powerpc/platforms/cell/Kconfig | 1 + arch/powerpc/sysdev/xive/native.c | 2 + block/blk-mq-sched.c | 9 ++ block/blk-mq.c | 9 ++ drivers/base/core.c | 12 +- drivers/base/power/main.c | 16 +- drivers/block/loop.c | 33 ++-- drivers/block/null_blk_main.c | 2 +- drivers/char/tpm/tpm-chip.c | 9 +- drivers/char/tpm/tpm.h | 6 +- drivers/char/tpm/tpm2-space.c | 26 +-- drivers/char/tpm/tpmrm-dev.c | 2 +- drivers/edac/ie31200_edac.c | 50 +++++- drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 16 +- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 5 +- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 7 +- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 20 ++- .../gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c | 7 +- .../gpu/drm/amd/powerplay/hwmgr/vega12_thermal.c | 6 +- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- drivers/gpu/drm/nouveau/dispnv50/disp.c | 4 +- drivers/gpu/drm/nouveau/nouveau_connector.c | 4 +- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 4 +- drivers/gpu/drm/radeon/radeon_connectors.c | 20 ++- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-quirks.c | 1 + drivers/hid/i2c-hid/i2c-hid-core.c | 22 +-- drivers/hid/usbhid/hiddev.c | 4 + drivers/i2c/busses/i2c-rcar.c | 1 + drivers/iommu/iova.c | 4 +- drivers/irqchip/irq-stm32-exti.c | 14 +- drivers/media/cec/cec-api.c | 8 +- drivers/media/pci/ttpci/av7110.c | 5 +- drivers/media/platform/davinci/vpif_capture.c | 2 - drivers/media/rc/gpio-ir-tx.c | 7 +- drivers/mfd/intel-lpss-pci.c | 3 + drivers/net/ethernet/amazon/ena/ena_netdev.c | 5 +- drivers/net/ethernet/freescale/gianfar.c | 4 +- drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 2 +- drivers/net/ipvlan/ipvlan_main.c | 27 +++- drivers/net/macvlan.c | 21 ++- drivers/net/wireless/ath/ath10k/hw.h | 2 +- drivers/net/wireless/realtek/rtlwifi/usb.c | 5 +- drivers/nvme/host/fc.c | 4 +- drivers/pci/slot.c | 6 +- drivers/s390/cio/css.c | 5 + drivers/scsi/fcoe/fcoe_ctlr.c | 2 +- drivers/scsi/lpfc/lpfc_vport.c | 26 +-- drivers/scsi/qla2xxx/qla_mbx.c | 8 - drivers/scsi/qla2xxx/qla_nvme.c | 5 + drivers/scsi/qla2xxx/qla_os.c | 5 + drivers/scsi/scsi_transport_iscsi.c | 2 +- drivers/scsi/ufs/ufshcd.c | 14 +- drivers/spi/spi-stm32.c | 3 +- drivers/target/target_core_user.c | 9 +- drivers/tty/serial/8250/8250_exar.c | 24 ++- drivers/tty/serial/8250/8250_port.c | 9 +- drivers/tty/serial/amba-pl011.c | 16 +- drivers/tty/serial/samsung.c | 8 +- drivers/tty/vt/vt.c | 5 +- drivers/tty/vt/vt_ioctl.c | 12 +- drivers/usb/class/cdc-acm.c | 22 ++- drivers/usb/core/quirks.c | 7 + drivers/usb/dwc3/gadget.c | 104 +++++++++--- drivers/usb/gadget/function/f_ncm.c | 81 ++++++++-- drivers/usb/gadget/function/f_tcm.c | 7 +- drivers/usb/gadget/u_f.h | 38 +++-- drivers/usb/host/ohci-exynos.c | 5 +- drivers/usb/host/xhci-debugfs.c | 8 +- drivers/usb/host/xhci-hub.c | 19 +-- drivers/usb/host/xhci.c | 3 +- drivers/usb/misc/lvstest.c | 2 +- drivers/usb/misc/sisusbvga/sisusb.c | 2 +- drivers/usb/misc/yurex.c | 2 +- drivers/usb/storage/unusual_devs.h | 2 +- drivers/usb/storage/unusual_uas.h | 14 ++ drivers/video/fbdev/core/fbcon.c | 25 ++- drivers/video/fbdev/omap2/omapfb/dss/dispc.c | 7 +- drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 7 +- drivers/video/fbdev/omap2/omapfb/dss/dss.c | 7 +- drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c | 5 +- drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c | 5 +- drivers/video/fbdev/omap2/omapfb/dss/venc.c | 7 +- drivers/xen/events/events_base.c | 16 +- fs/btrfs/disk-io.c | 1 + fs/btrfs/file.c | 8 +- fs/btrfs/free-space-cache.c | 2 +- fs/btrfs/super.c | 1 + fs/btrfs/tree-log.c | 10 +- fs/buffer.c | 9 ++ fs/ceph/mds_client.c | 14 +- fs/ext4/block_validity.c | 8 - fs/ext4/super.c | 175 ++++++++++++++------- fs/f2fs/f2fs.h | 4 +- fs/f2fs/inline.c | 19 ++- fs/f2fs/node.c | 6 +- fs/f2fs/recovery.c | 10 +- fs/f2fs/super.c | 5 +- fs/fs-writeback.c | 83 +++++----- fs/jbd2/transaction.c | 26 +++ fs/xfs/xfs_icache.c | 3 +- fs/xfs/xfs_inode.c | 25 ++- fs/xfs/xfs_trans_inode.c | 2 + include/linux/efi.h | 4 + include/linux/fs.h | 8 +- include/trace/events/writeback.h | 13 +- kernel/irq/matrix.c | 7 + kernel/locking/lockdep_proc.c | 2 +- kernel/trace/blktrace.c | 12 ++ net/core/skbuff.c | 4 +- net/ipv6/ip6_tunnel.c | 10 +- net/qrtr/qrtr.c | 20 +-- net/smc/smc_diag.c | 16 +- net/tipc/netlink_compat.c | 12 +- sound/pci/cs46xx/cs46xx_lib.c | 2 +- sound/pci/cs46xx/dsp_spos_scb_lib.c | 2 +- sound/pci/hda/hda_codec.c | 2 +- sound/pci/hda/hda_generic.c | 2 +- sound/pci/hda/patch_sigmatel.c | 2 +- sound/pci/ice1712/prodigy192.c | 2 +- sound/pci/oxygen/xonar_dg.c | 2 +- sound/soc/codecs/wm8958-dsp2.c | 4 + sound/soc/img/img-i2s-in.c | 4 +- sound/soc/img/img-parallel-out.c | 4 +- sound/soc/tegra/tegra30_ahub.c | 4 +- sound/soc/tegra/tegra30_i2s.c | 4 +- sound/usb/quirks-table.h | 4 +- .../powerpc/pmu/ebb/back_to_back_ebbs_test.c | 2 - .../selftests/powerpc/pmu/ebb/cycles_test.c | 2 - .../powerpc/pmu/ebb/cycles_with_freeze_test.c | 2 - .../powerpc/pmu/ebb/cycles_with_mmcr2_test.c | 2 - tools/testing/selftests/powerpc/pmu/ebb/ebb.c | 2 - .../powerpc/pmu/ebb/ebb_on_willing_child_test.c | 2 - .../powerpc/pmu/ebb/lost_exception_test.c | 1 - .../selftests/powerpc/pmu/ebb/multi_counter_test.c | 7 - .../powerpc/pmu/ebb/multi_ebb_procs_test.c | 2 - .../selftests/powerpc/pmu/ebb/pmae_handling_test.c | 2 - .../powerpc/pmu/ebb/pmc56_overflow_test.c | 2 - 146 files changed, 1106 insertions(+), 474 deletions(-)

4 years, 3 months

11
146
0 0

[PATCH v3] ata: sata_rcar: Fix DMA boundary mask

by Geert Uytterhoeven

Before commit 9495b7e92f716ab2 ("driver core: platform: Initialize dma_parms for platform devices"), the R-Car SATA device didn't have DMA parameters. Hence the DMA boundary mask supplied by its driver was silently ignored, as __scsi_init_queue() doesn't check the return value of dma_set_seg_boundary(), and the default value of 0xffffffff was used. Now the device has gained DMA parameters, the driver-supplied value is used, and the following warning is printed on Salvator-XS: DMA-API: sata_rcar ee300000.sata: mapping sg segment across boundary [start=0x00000000ffffe000] [end=0x00000000ffffefff] [boundary=0x000000001ffffffe] WARNING: CPU: 5 PID: 38 at kernel/dma/debug.c:1233 debug_dma_map_sg+0x298/0x300 (the range of start/end values depend on whether IOMMU support is enabled or not) The issue here is that SATA_RCAR_DMA_BOUNDARY doesn't have bit 0 set, so any typical end value, which is odd, will trigger the check. Fix this by increasing the DMA boundary value by 1. This also fixes the following WRITE DMA EXT timeout issue: # dd if=/dev/urandom of=/mnt/de1/file1-1024M bs=1M count=1024 ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6 frozen ata1.00: failed command: WRITE DMA EXT ata1.00: cmd 35/00:00:00:e6:0c/00:0a:00:00:00/e0 tag 0 dma 1310720 out res 40/00:01:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout) ata1.00: status: { DRDY } as seen by Shimoda-san since commit 429120f3df2dba2b ("block: fix splitting segments on boundary masks"). Fixes: 8bfbeed58665dbbf ("sata_rcar: correct 'sata_rcar_sht'") Fixes: 9495b7e92f716ab2 ("driver core: platform: Initialize dma_parms for platform devices") Fixes: 429120f3df2dba2b ("block: fix splitting segments on boundary masks") Signed-off-by: Geert Uytterhoeven <geert+renesas(a)glider.be> Reviewed-by: Christoph Hellwig <hch(a)lst.de> Reviewed-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Reviewed-by: Sergei Shtylyov <sergei.shtylyov(a)cogentembedded.com> Reviewed-by: Ulf Hansson <ulf.hansson(a)linaro.org> Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj(a)bp.renesas.com> Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh(a)renesas.com> Cc: stable <stable(a)vger.kernel.org> --- v3: - Add Reviewed-by, Tested-by, - Augment description and Fixes: with Shimoda-san's problem report https://lore.kernel.org/r/1600255098-21411-1-git-send-email-yoshihiro.shimo…, v2: - Add Reviewed-by, Tested-by, Cc. --- drivers/ata/sata_rcar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c index 141ac600b64c87ef..44b0ed8f6bb8a120 100644 --- a/drivers/ata/sata_rcar.c +++ b/drivers/ata/sata_rcar.c @@ -120,7 +120,7 @@ /* Descriptor table word 0 bit (when DTA32M = 1) */ #define SATA_RCAR_DTEND BIT(0) -#define SATA_RCAR_DMA_BOUNDARY 0x1FFFFFFEUL +#define SATA_RCAR_DMA_BOUNDARY 0x1FFFFFFFUL /* Gen2 Physical Layer Control Registers */ #define RCAR_GEN2_PHY_CTL1_REG 0x1704 -- 2.17.1

4 years, 4 months

5
5
0 0

[PATCH AUTOSEL 5.8 01/20] device_cgroup: Fix RCU list debugging warning

by Sasha Levin

From: Amol Grover <frextrite(a)gmail.com> [ Upstream commit bc62d68e2a0a69fcdcf28aca8edb01abf306b698 ] exceptions may be traversed using list_for_each_entry_rcu() outside of an RCU read side critical section BUT under the protection of decgroup_mutex. Hence add the corresponding lockdep expression to fix the following false-positive warning: [ 2.304417] ============================= [ 2.304418] WARNING: suspicious RCU usage [ 2.304420] 5.5.4-stable #17 Tainted: G E [ 2.304422] ----------------------------- [ 2.304424] security/device_cgroup.c:355 RCU-list traversed in non-reader section!! Signed-off-by: Amol Grover <frextrite(a)gmail.com> Signed-off-by: James Morris <jmorris(a)namei.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- security/device_cgroup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/security/device_cgroup.c b/security/device_cgroup.c index 43ab0ad45c1b6..04375df52fc9a 100644 --- a/security/device_cgroup.c +++ b/security/device_cgroup.c @@ -354,7 +354,8 @@ static bool match_exception_partial(struct list_head *exceptions, short type, { struct dev_exception_item *ex; - list_for_each_entry_rcu(ex, exceptions, list) { + list_for_each_entry_rcu(ex, exceptions, list, + lockdep_is_held(&devcgroup_mutex)) { if ((type & DEVCG_DEV_BLOCK) && !(ex->type & DEVCG_DEV_BLOCK)) continue; if ((type & DEVCG_DEV_CHAR) && !(ex->type & DEVCG_DEV_CHAR)) -- 2.25.1

4 years, 4 months

6
30
0 0

[patch 04/15] shmem: shmem_writepage() split unlikely i915 THP

by Andrew Morton

From: Hugh Dickins <hughd(a)google.com> Subject: shmem: shmem_writepage() split unlikely i915 THP drivers/gpu/drm/i915/gem/i915_gem_shmem.c contains a shmem_writeback() which calls shmem_writepage() from a shrinker: that usually works well enough; but if /sys/kernel/mm/transparent_hugepage/shmem_enabled has been set to "force" (documented as "Force the huge option on for all - very useful for testing"), shmem_writepage() is surprised to be called with a huge page, and crashes on the VM_BUG_ON_PAGE(PageCompound) (I did not find out where the crash happens when CONFIG_DEBUG_VM is off). LRU page reclaim always splits the shmem huge page first: I'd prefer not to demand that of i915, so check and split compound in shmem_writepage(). Link: http://lkml.kernel.org/r/alpine.LSU.2.11.2008301401390.5954@eggly.anvils Fixes: 2d6692e642e7 ("drm/i915: Start writeback from the shrinker") Signed-off-by: Hugh Dickins <hughd(a)google.com> Reviewed-by: Shakeel Butt <shakeelb(a)google.com> Acked-by: Yang Shi <shy828301(a)gmail.com> Cc: Alex Shi <alex.shi(a)linux.alibaba.com> Cc: Johannes Weiner <hannes(a)cmpxchg.org> Cc: Michal Hocko <mhocko(a)suse.com> Cc: Mike Kravetz <mike.kravetz(a)oracle.com> Cc: Qian Cai <cai(a)lca.pw> Cc: <stable(a)vger.kernel.org> [5.3+] Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- mm/shmem.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) --- a/mm/shmem.c~shmem-shmem_writepage-split-unlikely-i915-thp +++ a/mm/shmem.c @@ -1362,7 +1362,15 @@ static int shmem_writepage(struct page * swp_entry_t swap; pgoff_t index; - VM_BUG_ON_PAGE(PageCompound(page), page); + /* + * If /sys/kernel/mm/transparent_hugepage/shmem_enabled is "force", + * then drivers/gpu/drm/i915/gem/i915_gem_shmem.c gets huge pages, + * and its shmem_writeback() needs them to be split when swapping. + */ + if (PageTransCompound(page)) + if (split_huge_page(page) < 0) + goto redirty; + BUG_ON(!PageLocked(page)); mapping = page->mapping; index = page->index; _

4 years, 4 months

4
9
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror September 2020