January 2021 - Linux-stable-mirror

Re: [PATCH] jffs2: check the validity of dstlen in jffs2_zlib_compress()

by Joakim Tjernlund

On Thu, 2021-01-28 at 02:55 -0800, menglong8.dong(a)gmail.com wrote: > From: Yang Yang <yang.yang29(a)zte.com.cn> > > KASAN reports a BUG when download file in jffs2 filesystem.It is > because when dstlen == 1, cpage_out will write array out of bounds. > Actually, data will not be compressed in jffs2_zlib_compress() if > data's length less than 4. Ouch, data corruption will ensue. Good find! I think this needs to go to stable as well. Jocke > > [ 393.799778] BUG: KASAN: slab-out-of-bounds in jffs2_rtime_compress+0x214/0x2f0 at addr ffff800062e3b281 > [ 393.809166] Write of size 1 by task tftp/2918 > [ 393.813526] CPU: 3 PID: 2918 Comm: tftp Tainted: G B 4.9.115-rt93-EMBSYS-CGEL-6.1.R6-dirty #1 > [ 393.823173] Hardware name: LS1043A RDB Board (DT) > [ 393.827870] Call trace: > [ 393.830322] [<ffff20000808c700>] dump_backtrace+0x0/0x2f0 > [ 393.835721] [<ffff20000808ca04>] show_stack+0x14/0x20 > [ 393.840774] [<ffff2000086ef700>] dump_stack+0x90/0xb0 > [ 393.845829] [<ffff20000827b19c>] kasan_object_err+0x24/0x80 > [ 393.851402] [<ffff20000827b404>] kasan_report_error+0x1b4/0x4d8 > [ 393.857323] [<ffff20000827bae8>] kasan_report+0x38/0x40 > [ 393.862548] [<ffff200008279d44>] __asan_store1+0x4c/0x58 > [ 393.867859] [<ffff2000084ce2ec>] jffs2_rtime_compress+0x214/0x2f0 > [ 393.873955] [<ffff2000084bb3b0>] jffs2_selected_compress+0x178/0x2a0 > [ 393.880308] [<ffff2000084bb530>] jffs2_compress+0x58/0x478 > [ 393.885796] [<ffff2000084c5b34>] jffs2_write_inode_range+0x13c/0x450 > [ 393.892150] [<ffff2000084be0b8>] jffs2_write_end+0x2a8/0x4a0 > [ 393.897811] [<ffff2000081f3008>] generic_perform_write+0x1c0/0x280 > [ 393.903990] [<ffff2000081f5074>] __generic_file_write_iter+0x1c4/0x228 > [ 393.910517] [<ffff2000081f5210>] generic_file_write_iter+0x138/0x288 > [ 393.916870] [<ffff20000829ec1c>] __vfs_write+0x1b4/0x238 > [ 393.922181] [<ffff20000829ff00>] vfs_write+0xd0/0x238 > [ 393.927232] [<ffff2000082a1ba8>] SyS_write+0xa0/0x110 > [ 393.932283] [<ffff20000808429c>] __sys_trace_return+0x0/0x4 > [ 393.937851] Object at ffff800062e3b280, in cache kmalloc-64 size: 64 > [ 393.944197] Allocated: > [ 393.946552] PID = 2918 > [ 393.948913] save_stack_trace_tsk+0x0/0x220 > [ 393.953096] save_stack_trace+0x18/0x20 > [ 393.956932] kasan_kmalloc+0xd8/0x188 > [ 393.960594] __kmalloc+0x144/0x238 > [ 393.963994] jffs2_selected_compress+0x48/0x2a0 > [ 393.968524] jffs2_compress+0x58/0x478 > [ 393.972273] jffs2_write_inode_range+0x13c/0x450 > [ 393.976889] jffs2_write_end+0x2a8/0x4a0 > [ 393.980810] generic_perform_write+0x1c0/0x280 > [ 393.985251] __generic_file_write_iter+0x1c4/0x228 > [ 393.990040] generic_file_write_iter+0x138/0x288 > [ 393.994655] __vfs_write+0x1b4/0x238 > [ 393.998228] vfs_write+0xd0/0x238 > [ 394.001543] SyS_write+0xa0/0x110 > [ 394.004856] __sys_trace_return+0x0/0x4 > [ 394.008684] Freed: > [ 394.010691] PID = 2918 > [ 394.013051] save_stack_trace_tsk+0x0/0x220 > [ 394.017233] save_stack_trace+0x18/0x20 > [ 394.021069] kasan_slab_free+0x88/0x188 > [ 394.024902] kfree+0x6c/0x1d8 > [ 394.027868] jffs2_sum_write_sumnode+0x2c4/0x880 > [ 394.032486] jffs2_do_reserve_space+0x198/0x598 > [ 394.037016] jffs2_reserve_space+0x3f8/0x4d8 > [ 394.041286] jffs2_write_inode_range+0xf0/0x450 > [ 394.045816] jffs2_write_end+0x2a8/0x4a0 > [ 394.049737] generic_perform_write+0x1c0/0x280 > [ 394.054179] __generic_file_write_iter+0x1c4/0x228 > [ 394.058968] generic_file_write_iter+0x138/0x288 > [ 394.063583] __vfs_write+0x1b4/0x238 > [ 394.067157] vfs_write+0xd0/0x238 > [ 394.070470] SyS_write+0xa0/0x110 > [ 394.073783] __sys_trace_return+0x0/0x4 > [ 394.077612] Memory state around the buggy address: > [ 394.082404] ffff800062e3b180: 00 00 00 00 00 00 00 00 fc fc fc fc fc fc fc fc > [ 394.089623] ffff800062e3b200: 00 00 00 00 00 00 00 00 fc fc fc fc fc fc fc fc > [ 394.096842] >ffff800062e3b280: 01 fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc > [ 394.104056] ^ > [ 394.107283] ffff800062e3b300: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc > [ 394.114502] ffff800062e3b380: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc > [ 394.121718] ================================================================== > > Signed-off-by: Yang Yang <yang.yang29(a)zte.com.cn> > --- > fs/jffs2/compr_rtime.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/jffs2/compr_rtime.c b/fs/jffs2/compr_rtime.c > index 406d9cc84ba8..79e771ab624f 100644 > --- a/fs/jffs2/compr_rtime.c > +++ b/fs/jffs2/compr_rtime.c > @@ -37,6 +37,9 @@ static int jffs2_rtime_compress(unsigned char *data_in, > int outpos = 0; > int pos=0; > > > > > + if (*dstlen <= 3) > + return -1; > + > memset(positions,0,sizeof(positions)); > > > > > while (pos < (*sourcelen) && outpos <= (*dstlen)-2) {

3 years, 5 months

2
1
0 0

[PATCH] watchdog: qcom: Remove incorrect usage of QCOM_WDT_ENABLE_IRQ

by Sai Prakash Ranjan

As per register documentation, QCOM_WDT_ENABLE_IRQ which is BIT(1) of watchdog control register is wakeup interrupt enable bit and not related to bark interrupt at all, BIT(0) is used for that. So remove incorrect usage of this bit when supporting bark irq for pre-timeout notification. Currently with this bit set and bark interrupt specified, pre-timeout notification and/or watchdog reset/bite does not occur. Fixes: 36375491a439 ("watchdog: qcom: support pre-timeout when the bark irq is available") Cc: stable(a)vger.kernel.org Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan(a)codeaurora.org> --- Reading the conversations from when qcom pre-timeout support was added [1], Bjorn already had mentioned it was not right to touch this bit, not sure which SoC the pre-timeout was tested on at that time, but I have tested this on SDM845, SM8150, SC7180 and watchdog bark and bite does not occur with enabling this bit with the bark irq specified in DT. [1] https://lore.kernel.org/linux-watchdog/20190906174009.GC11938@tuxbook-pro/ --- drivers/watchdog/qcom-wdt.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c index 7cf0f2ec649b..e38a87ffe5f5 100644 --- a/drivers/watchdog/qcom-wdt.c +++ b/drivers/watchdog/qcom-wdt.c @@ -22,7 +22,6 @@ enum wdt_reg { }; #define QCOM_WDT_ENABLE BIT(0) -#define QCOM_WDT_ENABLE_IRQ BIT(1) static const u32 reg_offset_data_apcs_tmr[] = { [WDT_RST] = 0x38, @@ -63,16 +62,6 @@ struct qcom_wdt *to_qcom_wdt(struct watchdog_device *wdd) return container_of(wdd, struct qcom_wdt, wdd); } -static inline int qcom_get_enable(struct watchdog_device *wdd) -{ - int enable = QCOM_WDT_ENABLE; - - if (wdd->pretimeout) - enable |= QCOM_WDT_ENABLE_IRQ; - - return enable; -} - static irqreturn_t qcom_wdt_isr(int irq, void *arg) { struct watchdog_device *wdd = arg; @@ -91,7 +80,7 @@ static int qcom_wdt_start(struct watchdog_device *wdd) writel(1, wdt_addr(wdt, WDT_RST)); writel(bark * wdt->rate, wdt_addr(wdt, WDT_BARK_TIME)); writel(wdd->timeout * wdt->rate, wdt_addr(wdt, WDT_BITE_TIME)); - writel(qcom_get_enable(wdd), wdt_addr(wdt, WDT_EN)); + writel(QCOM_WDT_ENABLE, wdt_addr(wdt, WDT_EN)); return 0; } -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

3 years, 5 months

4
6
0 0

Re: linux-5.10.11 build failure

by torvic9＠mailbox.org

Maybe you need something like this: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/e… Greetings, Tor

3 years, 5 months

1
0
0 0

[PATCH V2] Fix unsynchronized access to sev members through svm_register_enc_region

by Peter Gonda

Grab kvm->lock before pinning memory when registering an encrypted region; sev_pin_memory() relies on kvm->lock being held to ensure correctness when checking and updating the number of pinned pages. Add a lockdep assertion to help prevent future regressions. Cc: Thomas Gleixner <tglx(a)linutronix.de> Cc: Ingo Molnar <mingo(a)redhat.com> Cc: "H. Peter Anvin" <hpa(a)zytor.com> Cc: Paolo Bonzini <pbonzini(a)redhat.com> Cc: Joerg Roedel <joro(a)8bytes.org> Cc: Tom Lendacky <thomas.lendacky(a)amd.com> Cc: Brijesh Singh <brijesh.singh(a)amd.com> Cc: Sean Christopherson <seanjc(a)google.com> Cc: x86(a)kernel.org Cc: kvm(a)vger.kernel.org Cc: stable(a)vger.kernel.org Cc: linux-kernel(a)vger.kernel.org Fixes: 1e80fdc09d12 ("KVM: SVM: Pin guest memory when SEV is active") Signed-off-by: Peter Gonda <pgonda(a)google.com> V2 - Fix up patch description - Correct file paths svm.c -> sev.c - Add unlock of kvm->lock on sev_pin_memory error V1 - https://lore.kernel.org/kvm/20210126185431.1824530-1-pgonda@google.com/ --- arch/x86/kvm/svm/sev.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c index c8ffdbc81709..b80e9bf0a31b 100644 --- a/arch/x86/kvm/svm/sev.c +++ b/arch/x86/kvm/svm/sev.c @@ -342,6 +342,8 @@ static struct page **sev_pin_memory(struct kvm *kvm, unsigned long uaddr, unsigned long first, last; int ret; + lockdep_assert_held(&kvm->lock); + if (ulen == 0 || uaddr + ulen < uaddr) return ERR_PTR(-EINVAL); @@ -1119,12 +1121,20 @@ int svm_register_enc_region(struct kvm *kvm, if (!region) return -ENOMEM; + mutex_lock(&kvm->lock); region->pages = sev_pin_memory(kvm, range->addr, range->size, &region->npages, 1); if (IS_ERR(region->pages)) { ret = PTR_ERR(region->pages); + mutex_unlock(&kvm->lock); goto e_free; } + region->uaddr = range->addr; + region->size = range->size; + + list_add_tail(&region->list, &sev->regions_list); + mutex_unlock(&kvm->lock); + /* * The guest may change the memory encryption attribute from C=0 -> C=1 * or vice versa for this memory range. Lets make sure caches are @@ -1133,13 +1143,6 @@ int svm_register_enc_region(struct kvm *kvm, */ sev_clflush_pages(region->pages, region->npages); - region->uaddr = range->addr; - region->size = range->size; - - mutex_lock(&kvm->lock); - list_add_tail(&region->list, &sev->regions_list); - mutex_unlock(&kvm->lock); - return ret; e_free: -- 2.30.0.280.ga3ce27912f-goog

3 years, 5 months

4
3
0 0

linux-5.10.11 build failure

by Chris Clayton

Hi, Building 5.10.11 fails on my (x86-64) laptop thusly: .. AS arch/x86/entry/thunk_64.o CC arch/x86/entry/vsyscall/vsyscall_64.o AS arch/x86/realmode/rm/header.o CC arch/x86/mm/pat/set_memory.o CC arch/x86/events/amd/core.o CC arch/x86/kernel/fpu/init.o CC arch/x86/entry/vdso/vma.o CC kernel/sched/core.o arch/x86/entry/thunk_64.o: warning: objtool: missing symbol for insn at offset 0x3e AS arch/x86/realmode/rm/trampoline_64.o make[2]: *** [scripts/Makefile.build:360: arch/x86/entry/thunk_64.o] Error 255 make[2]: *** Deleting file 'arch/x86/entry/thunk_64.o' make[2]: *** Waiting for unfinished jobs.... .. Compiler is latest snapshot of gcc-10. Happy to test the fix but please cc me as I'm not subscribed Thanks, Chris

3 years, 5 months

3
3
0 0

[PATCH/RFC] xen-blkback: set ring->xenblkd to NULL after kthread_stop()

by Nobuhiro Iwamatsu

From: Pawel Wieczorkiewicz <wipawel(a)amazon.de> commit 1c728719a4da6e654afb9cc047164755072ed7c9 upstream. When xen_blkif_disconnect() is called, the kernel thread behind the block interface is stopped by calling kthread_stop(ring->xenblkd). The ring->xenblkd thread pointer being non-NULL determines if the thread has been already stopped. Normally, the thread's function xen_blkif_schedule() sets the ring->xenblkd to NULL, when the thread's main loop ends. However, when the thread has not been started yet (i.e. wake_up_process() has not been called on it), the xen_blkif_schedule() function would not be called yet. In such case the kthread_stop() call returns -EINTR and the ring->xenblkd remains dangling. When this happens, any consecutive call to xen_blkif_disconnect (for example in frontend_changed() callback) leads to a kernel crash in kthread_stop() (e.g. NULL pointer dereference in exit_creds()). This is XSA-350. Cc: <stable(a)vger.kernel.org> # 4.12 Fixes: a24fa22ce22a ("xen/blkback: don't use xen_blkif_get() in xen-blkback kthread") Reported-by: Olivier Benjamin <oliben(a)amazon.com> Reported-by: Pawel Wieczorkiewicz <wipawel(a)amazon.de> Signed-off-by: Pawel Wieczorkiewicz <wipawel(a)amazon.de> Reviewed-by: Julien Grall <jgrall(a)amazon.com> Reviewed-by: Juergen Gross <jgross(a)suse.com> Signed-off-by: Juergen Gross <jgross(a)suse.com> [iwamatsu: change from ring to blkif] Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu(a)toshiba.co.jp> --- drivers/block/xen-blkback/xenbus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c index 823f3480ebd19e..f974ed7c33b5df 100644 --- a/drivers/block/xen-blkback/xenbus.c +++ b/drivers/block/xen-blkback/xenbus.c @@ -219,6 +219,7 @@ static int xen_blkif_disconnect(struct xen_blkif *blkif) if (blkif->xenblkd) { kthread_stop(blkif->xenblkd); + blkif->xenblkd = NULL; wake_up(&blkif->shutdown_wq); } -- 2.30.0

3 years, 5 months

1
1
0 0

✅ PASS: Test report for kernel 5.10.11 (stable)

by CKI Project

Hello, We ran automated tests on a recent commit from this kernel tree: Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Commit: b97134d15127 - Linux 5.10.11 The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK All kernel binaries, config files, and logs are available for download here: https://arr-cki-prod-datawarehouse-public.s3.amazonaws.com/index.html?prefi… Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Compile testing --------------- We compiled the kernel for 4 architectures: aarch64: make options: make -j30 INSTALL_MOD_STRIP=1 targz-pkg ppc64le: make options: make -j30 INSTALL_MOD_STRIP=1 targz-pkg s390x: make options: make -j30 INSTALL_MOD_STRIP=1 targz-pkg x86_64: make options: make -j30 INSTALL_MOD_STRIP=1 targz-pkg Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: Host 1: ✅ Boot test ✅ selinux-policy: serge-testsuite ✅ storage: software RAID testing ✅ stress: stress-ng 🚧 ✅ xfstests - ext4 🚧 ✅ xfstests - xfs 🚧 ✅ xfstests - btrfs 🚧 ❌ IPMI driver test 🚧 ✅ IPMItool loop stress test 🚧 ✅ Storage blktests 🚧 ✅ Storage block - filesystem fio test 🚧 ✅ Storage block - queue scheduler test 🚧 ✅ Storage nvme - tcp 🚧 ✅ Storage: swraid mdadm raid_module test Host 2: ✅ Boot test ✅ ACPI table test ✅ ACPI enabled test ✅ LTP ✅ Loopdev Sanity ✅ Memory: fork_mem ✅ Memory function: memfd_create ✅ AMTU (Abstract Machine Test Utility) ✅ Networking bridge: sanity ✅ Networking socket: fuzz ✅ Networking: igmp conformance test ✅ Networking route: pmtu ✅ Networking route_func - local ✅ Networking route_func - forward ✅ Networking TCP: keepalive test ✅ Networking UDP: socket ✅ Networking tunnel: geneve basic test ✅ Networking tunnel: gre basic ✅ L2TP basic test ✅ Networking tunnel: vxlan basic ✅ Networking ipsec: basic netns - transport ✅ Networking ipsec: basic netns - tunnel ✅ Libkcapi AF_ALG test ✅ pciutils: update pci ids test ✅ ALSA PCM loopback test ✅ ALSA Control (mixer) Userspace Element test ✅ storage: SCSI VPD 🚧 ✅ CIFS Connectathon 🚧 ✅ POSIX pjd-fstest suites 🚧 ✅ Firmware test suite 🚧 ✅ jvm - jcstress tests 🚧 ✅ Memory function: kaslr 🚧 ✅ Ethernet drivers sanity 🚧 ✅ Networking firewall: basic netfilter test 🚧 ✅ audit: audit testsuite test 🚧 ✅ trace: ftrace/tracer 🚧 ❌ kdump - kexec_boot ppc64le: Host 1: ✅ Boot test ✅ selinux-policy: serge-testsuite ✅ storage: software RAID testing 🚧 ✅ xfstests - ext4 🚧 ✅ xfstests - xfs 🚧 ✅ xfstests - btrfs 🚧 ✅ IPMI driver test 🚧 ✅ IPMItool loop stress test 🚧 ✅ Storage blktests 🚧 ✅ Storage block - filesystem fio test 🚧 ✅ Storage block - queue scheduler test 🚧 ✅ Storage nvme - tcp 🚧 ✅ Storage: swraid mdadm raid_module test Host 2: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test ⚡⚡⚡ LTP ⚡⚡⚡ Loopdev Sanity ⚡⚡⚡ Memory: fork_mem ⚡⚡⚡ Memory function: memfd_create ⚡⚡⚡ AMTU (Abstract Machine Test Utility) ⚡⚡⚡ Networking bridge: sanity ⚡⚡⚡ Networking socket: fuzz ⚡⚡⚡ Networking route: pmtu ⚡⚡⚡ Networking route_func - local ⚡⚡⚡ Networking route_func - forward ⚡⚡⚡ Networking TCP: keepalive test ⚡⚡⚡ Networking UDP: socket ⚡⚡⚡ Networking tunnel: geneve basic test ⚡⚡⚡ Networking tunnel: gre basic ⚡⚡⚡ L2TP basic test ⚡⚡⚡ Networking tunnel: vxlan basic ⚡⚡⚡ Networking ipsec: basic netns - tunnel ⚡⚡⚡ Libkcapi AF_ALG test ⚡⚡⚡ pciutils: update pci ids test ⚡⚡⚡ ALSA PCM loopback test ⚡⚡⚡ ALSA Control (mixer) Userspace Element test 🚧 ⚡⚡⚡ CIFS Connectathon 🚧 ⚡⚡⚡ POSIX pjd-fstest suites 🚧 ⚡⚡⚡ jvm - jcstress tests 🚧 ⚡⚡⚡ Memory function: kaslr 🚧 ⚡⚡⚡ Ethernet drivers sanity 🚧 ⚡⚡⚡ Networking firewall: basic netfilter test 🚧 ⚡⚡⚡ audit: audit testsuite test 🚧 ⚡⚡⚡ trace: ftrace/tracer Host 3: ✅ Boot test ✅ LTP ✅ Loopdev Sanity ✅ Memory: fork_mem ✅ Memory function: memfd_create ✅ AMTU (Abstract Machine Test Utility) ✅ Networking bridge: sanity ✅ Networking socket: fuzz ✅ Networking route: pmtu ✅ Networking route_func - local ✅ Networking route_func - forward ✅ Networking TCP: keepalive test ✅ Networking UDP: socket ✅ Networking tunnel: geneve basic test ✅ Networking tunnel: gre basic ✅ L2TP basic test ✅ Networking tunnel: vxlan basic ✅ Networking ipsec: basic netns - tunnel ✅ Libkcapi AF_ALG test ✅ pciutils: update pci ids test ✅ ALSA PCM loopback test ✅ ALSA Control (mixer) Userspace Element test 🚧 ✅ CIFS Connectathon 🚧 ✅ POSIX pjd-fstest suites 🚧 ✅ jvm - jcstress tests 🚧 ✅ Memory function: kaslr 🚧 ✅ Ethernet drivers sanity 🚧 ✅ Networking firewall: basic netfilter test 🚧 ✅ audit: audit testsuite test 🚧 ✅ trace: ftrace/tracer s390x: Host 1: ⏱ Boot test ⏱ LTP ⏱ Loopdev Sanity ⏱ Memory: fork_mem ⏱ Memory function: memfd_create ⏱ AMTU (Abstract Machine Test Utility) ⏱ Networking bridge: sanity ⏱ Networking route: pmtu ⏱ Networking route_func - local ⏱ Networking route_func - forward ⏱ Networking TCP: keepalive test ⏱ Networking UDP: socket ⏱ Networking tunnel: geneve basic test ⏱ Networking tunnel: gre basic ⏱ L2TP basic test ⏱ Networking tunnel: vxlan basic ⏱ Networking ipsec: basic netns - transport ⏱ Networking ipsec: basic netns - tunnel ⏱ Libkcapi AF_ALG test ⏱ CIFS Connectathon ⏱ POSIX pjd-fstest suites ⏱ jvm - jcstress tests ⏱ Memory function: kaslr ⏱ Ethernet drivers sanity ⏱ Networking firewall: basic netfilter test ⏱ audit: audit testsuite test ⏱ trace: ftrace/tracer ⏱ kdump - kexec_boot Host 2: ⏱ Boot test ⏱ selinux-policy: serge-testsuite ⏱ stress: stress-ng ⏱ Storage blktests ⏱ Storage nvme - tcp ⏱ Storage: swraid mdadm raid_module test Host 3: ⏱ Boot test ⏱ kdump - sysrq-c ⏱ kdump - file-load x86_64: Host 1: ✅ Boot test ✅ ACPI table test ✅ LTP ✅ Loopdev Sanity ✅ Memory: fork_mem ✅ Memory function: memfd_create ✅ AMTU (Abstract Machine Test Utility) ✅ Networking bridge: sanity ✅ Networking socket: fuzz ✅ Networking: igmp conformance test ✅ Networking route: pmtu ✅ Networking route_func - local ✅ Networking route_func - forward ✅ Networking TCP: keepalive test ✅ Networking UDP: socket ✅ Networking tunnel: geneve basic test ✅ Networking tunnel: gre basic ✅ L2TP basic test ✅ Networking tunnel: vxlan basic ✅ Networking ipsec: basic netns - transport ✅ Networking ipsec: basic netns - tunnel ✅ Libkcapi AF_ALG test ✅ pciutils: sanity smoke test ✅ pciutils: update pci ids test ✅ ALSA PCM loopback test ✅ ALSA Control (mixer) Userspace Element test ✅ storage: SCSI VPD 🚧 ✅ CIFS Connectathon 🚧 ✅ POSIX pjd-fstest suites 🚧 ✅ Firmware test suite 🚧 ✅ jvm - jcstress tests 🚧 ✅ Memory function: kaslr 🚧 ✅ Ethernet drivers sanity 🚧 ✅ Networking firewall: basic netfilter test 🚧 ✅ audit: audit testsuite test 🚧 ✅ trace: ftrace/tracer 🚧 ❌ kdump - kexec_boot Host 2: ✅ Boot test ✅ selinux-policy: serge-testsuite ✅ storage: software RAID testing ✅ stress: stress-ng 🚧 ❌ CPU: Frequency Driver Test 🚧 ✅ CPU: Idle Test 🚧 ✅ xfstests - ext4 🚧 ✅ xfstests - xfs 🚧 ✅ xfstests - btrfs 🚧 ✅ xfstests - nfsv4.2 🚧 ✅ xfstests - cifsv3.11 🚧 ❌ IPMI driver test 🚧 ✅ IPMItool loop stress test 🚧 ✅ Storage blktests 🚧 ✅ Storage block - filesystem fio test 🚧 ✅ Storage block - queue scheduler test 🚧 ✅ Storage nvme - tcp 🚧 ✅ Storage: swraid mdadm raid_module test Host 3: ✅ Boot test 🚧 ✅ kdump - sysrq-c 🚧 ✅ kdump - file-load Test sources: https://gitlab.com/cki-project/kernel-tests 💚 Pull requests are welcome for new tests or improvements to existing tests! Aborted tests ------------- Tests that didn't complete running successfully are marked with ⚡⚡⚡. If this was caused by an infrastructure issue, we try to mark that explicitly in the report. Waived tests ------------ If the test run included waived tests, they are marked with 🚧. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed. Testing timeout --------------- We aim to provide a report within reasonable timeframe. Tests that haven't finished running yet are marked with ⏱.

3 years, 5 months

1
0
0 0

[PATCH] f2fs: flush data when enabling checkpoint back

by Jaegeuk Kim

During checkpoint=disable period, f2fs bypasses all the synchronous IOs such as sync and fsync. So, when enabling it back, we must flush all of them in order to keep the data persistent. Otherwise, suddern power-cut right after enabling checkpoint will cause data loss. Fixes: 4354994f097d ("f2fs: checkpoint disabling") Cc: stable(a)vger.kernel.org Signed-off-by: Jaegeuk Kim <jaegeuk(a)kernel.org> --- fs/f2fs/super.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index 359cc5a2f8f5..073b51af62c8 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -1887,6 +1887,9 @@ static int f2fs_disable_checkpoint(struct f2fs_sb_info *sbi) static void f2fs_enable_checkpoint(struct f2fs_sb_info *sbi) { + /* we should flush all the data to keep data consistency */ + sync_inodes_sb(sbi->sb); + down_write(&sbi->gc_lock); f2fs_dirty_to_prefree(sbi); -- 2.30.0.280.ga3ce27912f-goog

3 years, 5 months

2
1
0 0

[PATCH v3] kdb: Make memory allocations more robust

by Sumit Garg

Currently kdb uses in_interrupt() to determine whether its library code has been called from the kgdb trap handler or from a saner calling context such as driver init. This approach is broken because in_interrupt() alone isn't able to determine kgdb trap handler entry from normal task context. This can happen during normal use of basic features such as breakpoints and can also be trivially reproduced using: echo g > /proc/sysrq-trigger We can improve this by adding check for in_dbg_master() instead which explicitly determines if we are running in debugger context. Cc: stable(a)vger.kernel.org Signed-off-by: Sumit Garg <sumit.garg(a)linaro.org> --- Changes in v3: - Refined commit description and Cc: stable(a)vger.kernel.org. Changes in v2: - Get rid of redundant in_atomic() check. kernel/debug/kdb/kdb_private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/debug/kdb/kdb_private.h b/kernel/debug/kdb/kdb_private.h index 7a4a181..344eb0d 100644 --- a/kernel/debug/kdb/kdb_private.h +++ b/kernel/debug/kdb/kdb_private.h @@ -231,7 +231,7 @@ extern struct task_struct *kdb_curr_task(int); #define kdb_task_has_cpu(p) (task_curr(p)) -#define GFP_KDB (in_interrupt() ? GFP_ATOMIC : GFP_KERNEL) +#define GFP_KDB (in_dbg_master() ? GFP_ATOMIC : GFP_KERNEL) extern void *debug_kmalloc(size_t size, gfp_t flags); extern void debug_kfree(void *); -- 2.7.4

3 years, 5 months

3
4
0 0

[PATCH] hwmon: (dell-smm) Add XPS 15 L502X to fan control blacklist

by Thomas Hebb

It has been reported[0] that the Dell XPS 15 L502X exhibits similar freezing behavior to the other systems[1] on this blacklist. The issue was exposed by a prior change of mine to automatically load dell_smm_hwmon on a wider set of XPS models. To fix the regression, add this model to the blacklist. [0] https://bugzilla.kernel.org/show_bug.cgi?id=211081 [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751 Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models") Cc: stable(a)vger.kernel.org Reported-by: Bob Hepple <bob.hepple(a)gmail.com> Tested-by: Bob Hepple <bob.hepple(a)gmail.com> Signed-off-by: Thomas Hebb <tommyhebb(a)gmail.com> --- drivers/hwmon/dell-smm-hwmon.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c index ec448f5f2dc3..73b9db9e3aab 100644 --- a/drivers/hwmon/dell-smm-hwmon.c +++ b/drivers/hwmon/dell-smm-hwmon.c @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = { DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"), }, }, + { + .ident = "Dell XPS 15 L502X", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"), + }, + }, { } }; -- 2.30.0

3 years, 5 months

5
8
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror January 2021