September 2021 - Linux-stable-mirror

[PATCH v3 1/4] drm/rockchip: dsi: Hold pm-runtime across bind/unbind

by Brian Norris

In commit 43c2de1002d2, we moved most HW configuration to bind(), but we didn't move the runtime PM management. Therefore, depending on initial boot state, runtime-PM workqueue delays, and other timing factors, we may disable our power domain in between the hardware configuration (bind()) and when we enable the display. This can cause us to lose hardware state and fail to configure our display. For example: dw-mipi-dsi-rockchip ff968000.mipi: failed to write command FIFO panel-innolux-p079zca ff960000.mipi.0: failed to write command 0 or: dw-mipi-dsi-rockchip ff968000.mipi: failed to write command FIFO panel-kingdisplay-kd097d04 ff960000.mipi.0: failed write init cmds: -110 We should match the runtime PM to the lifetime of the bind()/unbind() cycle. Tested on Acer Chrometab 10 (RK3399 Gru-Scarlet), with panel drivers built either as modules or built-in. Side notes: it seems one is more likely to see this problem when the panel driver is built into the kernel. I've also seen this problem bisect down to commits that simply changed Kconfig dependencies, because it changed the order in which driver init functions were compiled into the kernel, and therefore the ordering and timing of built-in device probe. Fixes: 43c2de1002d2 ("drm/rockchip: dsi: move all lane config except LCDC mux to bind()") Link: https://lore.kernel.org/linux-rockchip/9aedfb528600ecf871885f7293ca4207c84d… Reported-by: <aleksandr.o.makarov(a)gmail.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Brian Norris <briannorris(a)chromium.org> Tested-by: Nícolas F. R. A. Prado <nfraprado(a)collabora.com> --- (no changes since v2) Changes in v2: - Clean up pm-runtime state in error cases. - Correct git hash for Fixes. .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 37 ++++++++++--------- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c index a2262bee5aa4..45676b23c019 100644 --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c @@ -773,10 +773,6 @@ static void dw_mipi_dsi_encoder_enable(struct drm_encoder *encoder) if (mux < 0) return; - pm_runtime_get_sync(dsi->dev); - if (dsi->slave) - pm_runtime_get_sync(dsi->slave->dev); - /* * For the RK3399, the clk of grf must be enabled before writing grf * register. And for RK3288 or other soc, this grf_clk must be NULL, @@ -795,20 +791,10 @@ static void dw_mipi_dsi_encoder_enable(struct drm_encoder *encoder) clk_disable_unprepare(dsi->grf_clk); } -static void dw_mipi_dsi_encoder_disable(struct drm_encoder *encoder) -{ - struct dw_mipi_dsi_rockchip *dsi = to_dsi(encoder); - - if (dsi->slave) - pm_runtime_put(dsi->slave->dev); - pm_runtime_put(dsi->dev); -} - static const struct drm_encoder_helper_funcs dw_mipi_dsi_encoder_helper_funcs = { .atomic_check = dw_mipi_dsi_encoder_atomic_check, .enable = dw_mipi_dsi_encoder_enable, - .disable = dw_mipi_dsi_encoder_disable, }; static int rockchip_dsi_drm_create_encoder(struct dw_mipi_dsi_rockchip *dsi, @@ -938,10 +924,14 @@ static int dw_mipi_dsi_rockchip_bind(struct device *dev, put_device(second); } + pm_runtime_get_sync(dsi->dev); + if (dsi->slave) + pm_runtime_get_sync(dsi->slave->dev); + ret = clk_prepare_enable(dsi->pllref_clk); if (ret) { DRM_DEV_ERROR(dev, "Failed to enable pllref_clk: %d\n", ret); - return ret; + goto out_pm_runtime; } /* @@ -953,7 +943,7 @@ static int dw_mipi_dsi_rockchip_bind(struct device *dev, ret = clk_prepare_enable(dsi->grf_clk); if (ret) { DRM_DEV_ERROR(dsi->dev, "Failed to enable grf_clk: %d\n", ret); - return ret; + goto out_pm_runtime; } dw_mipi_dsi_rockchip_config(dsi); @@ -965,16 +955,23 @@ static int dw_mipi_dsi_rockchip_bind(struct device *dev, ret = rockchip_dsi_drm_create_encoder(dsi, drm_dev); if (ret) { DRM_DEV_ERROR(dev, "Failed to create drm encoder\n"); - return ret; + goto out_pm_runtime; } ret = dw_mipi_dsi_bind(dsi->dmd, &dsi->encoder); if (ret) { DRM_DEV_ERROR(dev, "Failed to bind: %d\n", ret); - return ret; + goto out_pm_runtime; } return 0; + +out_pm_runtime: + pm_runtime_put(dsi->dev); + if (dsi->slave) + pm_runtime_put(dsi->slave->dev); + + return ret; } static void dw_mipi_dsi_rockchip_unbind(struct device *dev, @@ -989,6 +986,10 @@ static void dw_mipi_dsi_rockchip_unbind(struct device *dev, dw_mipi_dsi_unbind(dsi->dmd); clk_disable_unprepare(dsi->pllref_clk); + + pm_runtime_put(dsi->dev); + if (dsi->slave) + pm_runtime_put(dsi->slave->dev); } static const struct component_ops dw_mipi_dsi_rockchip_ops = { -- 2.33.0.685.g46640cef36-goog

2 years, 8 months

2
1
0 0

[PATCH 5.4 00/68] 5.4.150-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.4.150 release. There are 68 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 29 Sep 2021 17:02:05 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.150-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.4.150-rc1 Linus Torvalds <torvalds(a)linux-foundation.org> qnx4: work around gcc false positive warning bug Juergen Gross <jgross(a)suse.com> xen/balloon: fix balloon kthread freezing Pali Rohár <pali(a)kernel.org> arm64: dts: marvell: armada-37xx: Extend PCIe MEM space Antoine Tenart <atenart(a)kernel.org> thermal/drivers/int340x: Do not set a wrong tcc offset on resume Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri(a)xilinx.com> EDAC/synopsys: Fix wrong value type assignment for edac_mode Linus Torvalds <torvalds(a)linux-foundation.org> spi: Fix tegra20 build with CONFIG_PM=n Guenter Roeck <linux(a)roeck-us.net> net: 6pack: Fix tx timeout and slot time Guenter Roeck <linux(a)roeck-us.net> alpha: Declare virt_to_phys and virt_to_bus parameter as pointer to volatile Dan Li <ashimida(a)linux.alibaba.com> arm64: Mark __stack_chk_guard as __ro_after_init Helge Deller <deller(a)gmx.de> parisc: Use absolute_pointer() to define PAGE0 Linus Torvalds <torvalds(a)linux-foundation.org> qnx4: avoid stringop-overread errors Linus Torvalds <torvalds(a)linux-foundation.org> sparc: avoid stringop-overread errors Guenter Roeck <linux(a)roeck-us.net> net: i825xx: Use absolute_pointer for memcpy from fixed memory location Guenter Roeck <linux(a)roeck-us.net> compiler.h: Introduce absolute_pointer macro Li Jinlin <lijinlin3(a)huawei.com> blk-cgroup: fix UAF by grabbing blkcg lock before destroying blkg pd Andreas Larsson <andreas(a)gaisler.com> sparc32: page align size in arch_dma_alloc Anton Eidelman <anton.eidelman(a)gmail.com> nvme-multipath: fix ANA state updates when a namespace is not present Juergen Gross <jgross(a)suse.com> xen/balloon: use a kernel thread instead a workqueue Bixuan Cui <cuibixuan(a)huawei.com> bpf: Add oversize check before call kvcalloc() zhang kai <zhangkaiheb(a)126.com> ipv6: delay fib6_sernum increase in fib6_add Guenter Roeck <linux(a)roeck-us.net> m68k: Double cast io functions to unsigned long Jesper Nilsson <jesper.nilsson(a)axis.com> net: stmmac: allow CSR clock of 300MHz Tong Zhang <ztong0001(a)gmail.com> net: macb: fix use after free on rmmod Zhihao Cheng <chengzhihao1(a)huawei.com> blktrace: Fix uaf in blk_trace access after removing by sysfs Christoph Hellwig <hch(a)lst.de> md: fix a lock order reversal in md_alloc Kaige Fu <kaige.fu(a)linux.alibaba.com> irqchip/gic-v3-its: Fix potential VPE leak on error Randy Dunlap <rdunlap(a)infradead.org> irqchip/goldfish-pic: Select GENERIC_IRQ_CHIP to fix build Dan Carpenter <dan.carpenter(a)oracle.com> scsi: lpfc: Use correct scnprintf() limit Dmitry Bogdanov <d.bogdanov(a)yadro.com> scsi: qla2xxx: Restore initiator in dual mode Dan Carpenter <dan.carpenter(a)oracle.com> cifs: fix a sign extension bug Dan Carpenter <dan.carpenter(a)oracle.com> thermal/core: Potential buffer overflow in thermal_build_list_of_policies() Jiapeng Chong <jiapeng.chong(a)linux.alibaba.com> fpga: machxo2-spi: Fix missing error code in machxo2_write_complete() Tom Rix <trix(a)redhat.com> fpga: machxo2-spi: Return an error on failure Randy Dunlap <rdunlap(a)infradead.org> tty: synclink_gt: rename a conflicting function name Jiri Slaby <jslaby(a)suse.cz> tty: synclink_gt, drop unneeded forward declarations Baokun Li <libaokun1(a)huawei.com> scsi: iscsi: Adjust iface sysfs attr detection Aya Levin <ayal(a)nvidia.com> net/mlx4_en: Don't allow aRFS for encapsulated packets Shai Malin <smalin(a)marvell.com> qed: rdma - don't wait for resources under hw error recovery flow Kunihiko Hayashi <hayashi.kunihiko(a)socionext.com> gpio: uniphier: Fix void functions to remove return value Karsten Graul <kgraul(a)linux.ibm.com> net/smc: add missing error check in smc_clc_prfx_set() Michael Chan <michael.chan(a)broadcom.com> bnxt_en: Fix TX timeout when TX ring size is set to the smallest Claudiu Manoil <claudiu.manoil(a)nxp.com> enetc: Fix illegal access when reading affinity_hint Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> platform/x86/intel: punit_ipc: Drop wrong use of ACPI_PTR() David Howells <dhowells(a)redhat.com> afs: Fix incorrect triggering of sillyrename on 3rd-party invalidation Johan Hovold <johan(a)kernel.org> net: hso: fix muxed tty registration Pali Rohár <pali(a)kernel.org> serial: mvebu-uart: fix driver's tx_empty callback Kishon Vijay Abraham I <kishon(a)ti.com> xhci: Set HCD flag to defer primary roothub registration Qu Wenruo <wqu(a)suse.com> btrfs: prevent __btrfs_dump_space_info() to underflow its free space Gao Xiang <hsiangkao(a)linux.alibaba.com> erofs: fix up erofs_lookup tracepoint Dan Carpenter <dan.carpenter(a)oracle.com> mcb: fix error handling in mcb_alloc_bus() Slark Xiao <slark_xiao(a)163.com> USB: serial: option: add device id for Foxconn T99W265 Krzysztof Kozlowski <krzysztof.kozlowski(a)canonical.com> USB: serial: option: remove duplicate USB device ID Carlo Lobrano <c.lobrano(a)gmail.com> USB: serial: option: add Telit LN920 compositions Krzysztof Kozlowski <krzysztof.kozlowski(a)canonical.com> USB: serial: mos7840: remove duplicated 0xac24 device ID Kishon Vijay Abraham I <kishon(a)ti.com> usb: core: hcd: Add support for deferring roothub registration Julian Sikorski <belegdol(a)gmail.com> Re-enable UAS for LaCie Rugged USB3-FW with fk quirk Johan Hovold <johan(a)kernel.org> staging: greybus: uart: fix tty use after free Todd Kjos <tkjos(a)google.com> binder: make sure fd closes complete Johan Hovold <johan(a)kernel.org> USB: cdc-acm: fix minor-number release Uwe Brandt <uwe.brandt(a)gmail.com> USB: serial: cp210x: add ID for GW Instek GDM-834x Digital Multimeter Ondrej Zary <linux(a)zary.sk> usb-storage: Add quirk for ScanLogic SL11R-IDE older than 2.6c Jan Beulich <jbeulich(a)suse.com> xen/x86: fix PV trap handling on secondary processors Steve French <stfrench(a)microsoft.com> cifs: fix incorrect check for null pointer in header_assemble Dan Carpenter <dan.carpenter(a)oracle.com> usb: musb: tusb6010: uninitialized data in tusb_fifo_write_unaligned() Minas Harutyunyan <Minas.Harutyunyan(a)synopsys.com> usb: dwc2: gadget: Fix ISOC transfer complete handling for DDMA Minas Harutyunyan <Minas.Harutyunyan(a)synopsys.com> usb: dwc2: gadget: Fix ISOC flow for BDMA and Slave Dan Carpenter <dan.carpenter(a)oracle.com> usb: gadget: r8a66597: fix a loop in set_feature() Wengang Wang <wen.gang.wang(a)oracle.com> ocfs2: drop acl cache for directories too ------------- Diffstat: Makefile | 4 +- arch/alpha/include/asm/io.h | 6 +- .../boot/dts/marvell/armada-3720-turris-mox.dts | 17 ++ arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 11 +- arch/arm64/kernel/process.c | 2 +- arch/m68k/include/asm/raw_io.h | 20 +-- arch/parisc/include/asm/page.h | 2 +- arch/sparc/kernel/ioport.c | 4 +- arch/sparc/kernel/mdesc.c | 3 +- arch/x86/xen/enlighten_pv.c | 15 +- block/blk-cgroup.c | 8 + drivers/android/binder.c | 23 ++- drivers/edac/synopsys_edac.c | 2 +- drivers/fpga/machxo2-spi.c | 6 +- drivers/gpio/gpio-uniphier.c | 4 +- drivers/irqchip/Kconfig | 1 + drivers/irqchip/irq-gic-v3-its.c | 2 +- drivers/mcb/mcb-core.c | 12 +- drivers/md/md.c | 5 - drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 +- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 5 + drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +- drivers/net/ethernet/cadence/macb_pci.c | 2 +- drivers/net/ethernet/freescale/enetc/enetc.c | 5 +- drivers/net/ethernet/i825xx/82596.c | 2 +- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 3 + drivers/net/ethernet/qlogic/qed/qed_iwarp.c | 8 + drivers/net/ethernet/qlogic/qed/qed_roce.c | 8 + drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- drivers/net/hamradio/6pack.c | 4 +- drivers/net/usb/hso.c | 12 +- drivers/nvme/host/multipath.c | 7 +- drivers/platform/x86/intel_punit_ipc.c | 3 +- drivers/scsi/lpfc/lpfc_attr.c | 3 +- drivers/scsi/qla2xxx/qla_init.c | 3 +- drivers/scsi/scsi_transport_iscsi.c | 8 +- drivers/spi/spi-tegra20-slink.c | 4 +- drivers/staging/greybus/uart.c | 62 +++---- .../int340x_thermal/processor_thermal_device.c | 5 +- drivers/thermal/thermal_core.c | 7 +- drivers/tty/serial/mvebu-uart.c | 2 +- drivers/tty/synclink_gt.c | 101 +++-------- drivers/usb/class/cdc-acm.c | 7 +- drivers/usb/class/cdc-acm.h | 2 + drivers/usb/core/hcd.c | 29 +++- drivers/usb/dwc2/gadget.c | 193 ++++++++++++--------- drivers/usb/gadget/udc/r8a66597-udc.c | 2 +- drivers/usb/host/xhci.c | 1 + drivers/usb/musb/tusb6010.c | 1 + drivers/usb/serial/cp210x.c | 1 + drivers/usb/serial/mos7840.c | 2 - drivers/usb/serial/option.c | 11 +- drivers/usb/storage/unusual_devs.h | 9 +- drivers/usb/storage/unusual_uas.h | 2 +- drivers/xen/balloon.c | 62 +++++-- fs/afs/dir.c | 46 +---- fs/btrfs/space-info.c | 5 +- fs/cifs/connect.c | 5 +- fs/cifs/file.c | 2 +- fs/ocfs2/dlmglue.c | 3 +- fs/qnx4/dir.c | 69 ++++++-- include/linux/compiler.h | 2 + include/linux/usb/hcd.h | 2 + include/trace/events/erofs.h | 6 +- kernel/bpf/verifier.c | 2 + kernel/trace/blktrace.c | 8 + net/ipv6/ip6_fib.c | 3 +- net/smc/smc_clc.c | 3 +- 68 files changed, 509 insertions(+), 382 deletions(-)

2 years, 8 months

7
74
0 0

stable-rc/queue/4.4 baseline: 78 runs, 8 regressions (v4.4.285-24-gad37b725027a)

by kernelci.org bot

stable-rc/queue/4.4 baseline: 78 runs, 8 regressions (v4.4.285-24-gad37b725027a) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions --------------------+------+---------------+----------+---------------------+------------ beagle-xm | arm | lab-baylibre | gcc-8 | omap2plus_defconfig | 2 qemu_arm-virt-gicv2 | arm | lab-baylibre | gcc-8 | multi_v7_defconfig | 1 qemu_arm-virt-gicv2 | arm | lab-cip | gcc-8 | multi_v7_defconfig | 1 qemu_arm-virt-gicv2 | arm | lab-collabora | gcc-8 | multi_v7_defconfig | 1 qemu_arm-virt-gicv3 | arm | lab-baylibre | gcc-8 | multi_v7_defconfig | 1 qemu_arm-virt-gicv3 | arm | lab-cip | gcc-8 | multi_v7_defconfig | 1 qemu_arm-virt-gicv3 | arm | lab-collabora | gcc-8 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F4.4/kernel/v4.4.285-… Test: baseline Tree: stable-rc Branch: queue/4.4 Describe: v4.4.285-24-gad37b725027a URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: ad37b725027a8c3c822ed45a3eed50d761df6bc6 Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions --------------------+------+---------------+----------+---------------------+------------ beagle-xm | arm | lab-baylibre | gcc-8 | omap2plus_defconfig | 2 Details: https://kernelci.org/test/plan/id/61538301fc998b774699a307 Results: 3 PASS, 2 FAIL, 1 SKIP Full config: omap2plus_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.4/v4.4.285-24-gad37b725027a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.4/v4.4.285-24-gad37b725027a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-6-g8983f3b7… * baseline.dmesg.crit: https://kernelci.org/test/case/id/61538301fc998b774699a30d new failure (last pass: v4.4.285-24-g0a5ad79130e2) 1 lines 2021-09-28T21:02:38.686625 / # 2021-09-28T21:02:38.791062 # 2021-09-28T21:02:38.791929 2021-09-28T21:02:38.893426 / # #export SHELL=/bin/sh 2021-09-28T21:02:38.894006 2021-09-28T21:02:38.995149 / # export SHELL=/bin/sh. /lava-896148/environment 2021-09-28T21:02:38.995737 2021-09-28T21:02:39.097140 / # . /lava-896148/environment/lava-896148/bin/lava-test-runner /lava-896148/0 2021-09-28T21:02:39.098587 2021-09-28T21:02:39.099409 / # /lava-896148/bin/lava-test-runner /lava-896148/0 ... (8 line(s) more) * baseline.dmesg.emerg: https://kernelci.org/test/case/id/61538301fc998b774699a30f new failure (last pass: v4.4.285-24-g0a5ad79130e2) 28 lines 2021-09-28T21:02:39.557685 [ 49.998443] <LAVA_SIGNAL_TESTCASE TEST_CASE_ID=alert RESULT=pass UNITS=lines MEASUREMENT=0> 2021-09-28T21:02:39.609143 kern :emerg : Internal error: Oops - BUG: 0 [#1] SMP ARM 2021-09-28T21:02:39.614879 kern :emerg : Process udevd (pid: 109, stack limit = 0xcb950218) 2021-09-28T21:02:39.619357 kern :emerg : Stack: (0xcb951d10 to 0xcb952000) 2021-09-28T21:02:39.627520 kern :emerg : 1d00: bf02b83c bf010b84 cb969010 bf02b8c8 platform | arch | lab | compiler | defconfig | regressions --------------------+------+---------------+----------+---------------------+------------ qemu_arm-virt-gicv2 | arm | lab-baylibre | gcc-8 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/plan/id/61538058f7349f486099a2f7 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: multi_v7_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.4/v4.4.285-24-gad37b725027a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.4/v4.4.285-24-gad37b725027a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-6-g8983f3b7… * baseline.login: https://kernelci.org/test/case/id/61538058f7349f486099a2f8 failing since 319 days (last pass: v4.4.243-18-gfc7e8c68369a, first fail: v4.4.243-19-g71b6c961c7fe) platform | arch | lab | compiler | defconfig | regressions --------------------+------+---------------+----------+---------------------+------------ qemu_arm-virt-gicv2 | arm | lab-cip | gcc-8 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/plan/id/61538077764f94bbb299a2f0 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: multi_v7_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.4/v4.4.285-24-gad37b725027a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.4/v4.4.285-24-gad37b725027a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-6-g8983f3b7… * baseline.login: https://kernelci.org/test/case/id/61538077764f94bbb299a2f1 failing since 319 days (last pass: v4.4.243-18-gfc7e8c68369a, first fail: v4.4.243-19-g71b6c961c7fe) platform | arch | lab | compiler | defconfig | regressions --------------------+------+---------------+----------+---------------------+------------ qemu_arm-virt-gicv2 | arm | lab-collabora | gcc-8 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/plan/id/6153814cb018f1bfbd99a302 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: multi_v7_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.4/v4.4.285-24-gad37b725027a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.4/v4.4.285-24-gad37b725027a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-6-g8983f3b7… * baseline.login: https://kernelci.org/test/case/id/6153814cb018f1bfbd99a303 failing since 319 days (last pass: v4.4.243-18-gfc7e8c68369a, first fail: v4.4.243-19-g71b6c961c7fe) platform | arch | lab | compiler | defconfig | regressions --------------------+------+---------------+----------+---------------------+------------ qemu_arm-virt-gicv3 | arm | lab-baylibre | gcc-8 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/plan/id/615380bc49e6e3e6b799a2ec Results: 0 PASS, 1 FAIL, 0 SKIP Full config: multi_v7_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.4/v4.4.285-24-gad37b725027a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.4/v4.4.285-24-gad37b725027a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-6-g8983f3b7… * baseline.login: https://kernelci.org/test/case/id/615380bc49e6e3e6b799a2ed failing since 319 days (last pass: v4.4.243-18-gfc7e8c68369a, first fail: v4.4.243-19-g71b6c961c7fe) platform | arch | lab | compiler | defconfig | regressions --------------------+------+---------------+----------+---------------------+------------ qemu_arm-virt-gicv3 | arm | lab-cip | gcc-8 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/plan/id/6153810510842b268499a2e4 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: multi_v7_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.4/v4.4.285-24-gad37b725027a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.4/v4.4.285-24-gad37b725027a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-6-g8983f3b7… * baseline.login: https://kernelci.org/test/case/id/6153810510842b268499a2e5 failing since 319 days (last pass: v4.4.243-18-gfc7e8c68369a, first fail: v4.4.243-19-g71b6c961c7fe) platform | arch | lab | compiler | defconfig | regressions --------------------+------+---------------+----------+---------------------+------------ qemu_arm-virt-gicv3 | arm | lab-collabora | gcc-8 | multi_v7_defconfig | 1 Details: https://kernelci.org/test/plan/id/615383413e2ed4b23799a30c Results: 0 PASS, 1 FAIL, 0 SKIP Full config: multi_v7_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.4/v4.4.285-24-gad37b725027a… HTML log: https://storage.kernelci.org//stable-rc/queue-4.4/v4.4.285-24-gad37b725027a… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-6-g8983f3b7… * baseline.login: https://kernelci.org/test/case/id/615383413e2ed4b23799a30d failing since 319 days (last pass: v4.4.243-18-gfc7e8c68369a, first fail: v4.4.243-19-g71b6c961c7fe)

2 years, 8 months

1
0
0 0

[PATCH MANUALSEL 5.14] net: core: Correct the sock::sk_lock.owned lockdep annotations

by Sasha Levin

From: Thomas Gleixner <tglx(a)linutronix.de> [ Upstream commit 2dcb96bacce36021c2f3eaae0cef607b5bb71ede ] lock_sock_fast() and lock_sock_nested() contain lockdep annotations for the sock::sk_lock.owned 'mutex'. sock::sk_lock.owned is not a regular mutex. It is just lockdep wise equivalent. In fact it's an open coded trivial mutex implementation with some interesting features. sock::sk_lock.slock is a regular spinlock protecting the 'mutex' representation sock::sk_lock.owned which is a plain boolean. If 'owned' is true, then some other task holds the 'mutex', otherwise it is uncontended. As this locking construct is obviously endangered by lock ordering issues as any other locking primitive it got lockdep annotated via a dedicated dependency map sock::sk_lock.dep_map which has to be updated at the lock and unlock sites. lock_sock_nested() is a straight forward 'mutex' lock operation: might_sleep(); spin_lock_bh(sock::sk_lock.slock) while (!try_lock(sock::sk_lock.owned)) { spin_unlock_bh(sock::sk_lock.slock); wait_for_release(); spin_lock_bh(sock::sk_lock.slock); } The lockdep annotation for sock::sk_lock.owned is for unknown reasons _after_ the lock has been acquired, i.e. after the code block above and after releasing sock::sk_lock.slock, but inside the bottom halves disabled region: spin_unlock(sock::sk_lock.slock); mutex_acquire(&sk->sk_lock.dep_map, subclass, 0, _RET_IP_); local_bh_enable(); The placement after the unlock is obvious because otherwise the mutex_acquire() would nest into the spin lock held region. But that's from the lockdep perspective still the wrong place: 1) The mutex_acquire() is issued _after_ the successful acquisition which is pointless because in a dead lock scenario this point is never reached which means that if the deadlock is the first instance of exposing the wrong lock order lockdep does not have a chance to detect it. 2) It only works because lockdep is rather lax on the context from which the mutex_acquire() is issued. Acquiring a mutex inside a bottom halves and therefore non-preemptible region is obviously invalid, except for a trylock which is clearly not the case here. This 'works' stops working on RT enabled kernels where the bottom halves serialization is done via a local lock, which exposes this misplacement because the 'mutex' and the local lock nest the wrong way around and lockdep complains rightfully about a lock inversion. The placement is wrong since the initial commit a5b5bb9a053a ("[PATCH] lockdep: annotate sk_locks") which introduced this. Fix it by moving the mutex_acquire() in front of the actual lock acquisition, which is what the regular mutex_lock() operation does as well. lock_sock_fast() is not that straight forward. It looks at the first glance like a convoluted trylock operation: spin_lock_bh(sock::sk_lock.slock) if (!sock::sk_lock.owned) return false; while (!try_lock(sock::sk_lock.owned)) { spin_unlock_bh(sock::sk_lock.slock); wait_for_release(); spin_lock_bh(sock::sk_lock.slock); } spin_unlock(sock::sk_lock.slock); mutex_acquire(&sk->sk_lock.dep_map, subclass, 0, _RET_IP_); local_bh_enable(); return true; But that's not the case: lock_sock_fast() is an interesting optimization for short critical sections which can run with bottom halves disabled and sock::sk_lock.slock held. This allows to shortcut the 'mutex' operation in the non contended case by preventing other lockers to acquire sock::sk_lock.owned because they are blocked on sock::sk_lock.slock, which in turn avoids the overhead of doing the heavy processing in release_sock() including waking up wait queue waiters. In the contended case, i.e. when sock::sk_lock.owned == true the behavior is the same as lock_sock_nested(). Semantically this shortcut means, that the task acquired the 'mutex' even if it does not touch the sock::sk_lock.owned field in the non-contended case. Not telling lockdep about this shortcut acquisition is hiding potential lock ordering violations in the fast path. As a consequence the same reasoning as for the above lock_sock_nested() case vs. the placement of the lockdep annotation applies. The current placement of the lockdep annotation was just copied from the original lock_sock(), now renamed to lock_sock_nested(), implementation. Fix this by moving the mutex_acquire() in front of the actual lock acquisition and adding the corresponding mutex_release() into unlock_sock_fast(). Also document the fast path return case with a comment. Reported-by: Sebastian Siewior <bigeasy(a)linutronix.de> Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de> Cc: netdev(a)vger.kernel.org Cc: "David S. Miller" <davem(a)davemloft.net> Cc: Jakub Kicinski <kuba(a)kernel.org> Cc: Eric Dumazet <edumazet(a)google.com> Signed-off-by: David S. Miller <davem(a)davemloft.net> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- include/net/sock.h | 1 + net/core/sock.c | 37 +++++++++++++++++++++++-------------- 2 files changed, 24 insertions(+), 14 deletions(-) diff --git a/include/net/sock.h b/include/net/sock.h index f23cb259b0e2..e9ef47c0cfce 100644 --- a/include/net/sock.h +++ b/include/net/sock.h @@ -1641,6 +1641,7 @@ static inline void unlock_sock_fast(struct sock *sk, bool slow) release_sock(sk); __release(&sk->sk_lock.slock); } else { + mutex_release(&sk->sk_lock.dep_map, _RET_IP_); spin_unlock_bh(&sk->sk_lock.slock); } } diff --git a/net/core/sock.c b/net/core/sock.c index a3eea6e0b30a..54b8eeccbdf4 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -3158,17 +3158,15 @@ EXPORT_SYMBOL(sock_init_data); void lock_sock_nested(struct sock *sk, int subclass) { + /* The sk_lock has mutex_lock() semantics here. */ + mutex_acquire(&sk->sk_lock.dep_map, subclass, 0, _RET_IP_); + might_sleep(); spin_lock_bh(&sk->sk_lock.slock); if (sk->sk_lock.owned) __lock_sock(sk); sk->sk_lock.owned = 1; - spin_unlock(&sk->sk_lock.slock); - /* - * The sk_lock has mutex_lock() semantics here: - */ - mutex_acquire(&sk->sk_lock.dep_map, subclass, 0, _RET_IP_); - local_bh_enable(); + spin_unlock_bh(&sk->sk_lock.slock); } EXPORT_SYMBOL(lock_sock_nested); @@ -3206,24 +3204,35 @@ EXPORT_SYMBOL(release_sock); */ bool lock_sock_fast(struct sock *sk) __acquires(&sk->sk_lock.slock) { + /* The sk_lock has mutex_lock() semantics here. */ + mutex_acquire(&sk->sk_lock.dep_map, 0, 0, _RET_IP_); + might_sleep(); spin_lock_bh(&sk->sk_lock.slock); - if (!sk->sk_lock.owned) + if (!sk->sk_lock.owned) { /* - * Note : We must disable BH + * Fast path return with bottom halves disabled and + * sock::sk_lock.slock held. + * + * The 'mutex' is not contended and holding + * sock::sk_lock.slock prevents all other lockers to + * proceed so the corresponding unlock_sock_fast() can + * avoid the slow path of release_sock() completely and + * just release slock. + * + * From a semantical POV this is equivalent to 'acquiring' + * the 'mutex', hence the corresponding lockdep + * mutex_release() has to happen in the fast path of + * unlock_sock_fast(). */ return false; + } __lock_sock(sk); sk->sk_lock.owned = 1; - spin_unlock(&sk->sk_lock.slock); - /* - * The sk_lock has mutex_lock() semantics here: - */ - mutex_acquire(&sk->sk_lock.dep_map, 0, 0, _RET_IP_); __acquire(&sk->sk_lock.slock); - local_bh_enable(); + spin_unlock_bh(&sk->sk_lock.slock); return true; } EXPORT_SYMBOL(lock_sock_fast); -- 2.33.0

2 years, 8 months

1
0
0 0

stable-rc/queue/4.9 baseline: 78 runs, 3 regressions (v4.9.284-31-g4bf84f7dee1f)

by kernelci.org bot

stable-rc/queue/4.9 baseline: 78 runs, 3 regressions (v4.9.284-31-g4bf84f7dee1f) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions ---------------------+------+---------------+----------+---------------------+------------ qemu_arm-versatilepb | arm | lab-baylibre | gcc-8 | versatile_defconfig | 1 qemu_arm-versatilepb | arm | lab-cip | gcc-8 | versatile_defconfig | 1 qemu_arm-versatilepb | arm | lab-collabora | gcc-8 | versatile_defconfig | 1 Details: https://kernelci.org/test/job/stable-rc/branch/queue%2F4.9/kernel/v4.9.284-… Test: baseline Tree: stable-rc Branch: queue/4.9 Describe: v4.9.284-31-g4bf84f7dee1f URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git SHA: 4bf84f7dee1fa59c524f60a45a8e308589535c2e Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions ---------------------+------+---------------+----------+---------------------+------------ qemu_arm-versatilepb | arm | lab-baylibre | gcc-8 | versatile_defconfig | 1 Details: https://kernelci.org/test/plan/id/61537bbaccc2da9e3b99a2fd Results: 0 PASS, 1 FAIL, 0 SKIP Full config: versatile_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.284-31-g4bf84f7dee1f… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.284-31-g4bf84f7dee1f… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-6-g8983f3b7… * baseline.login: https://kernelci.org/test/case/id/61537bbaccc2da9e3b99a2fe failing since 318 days (last pass: v4.9.243-16-gd8d67e375b0a, first fail: v4.9.243-25-ga01fe8e99a22) platform | arch | lab | compiler | defconfig | regressions ---------------------+------+---------------+----------+---------------------+------------ qemu_arm-versatilepb | arm | lab-cip | gcc-8 | versatile_defconfig | 1 Details: https://kernelci.org/test/plan/id/6153788171f31c48a099a2f0 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: versatile_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.284-31-g4bf84f7dee1f… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.284-31-g4bf84f7dee1f… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-6-g8983f3b7… * baseline.login: https://kernelci.org/test/case/id/6153788171f31c48a099a2f1 failing since 318 days (last pass: v4.9.243-16-gd8d67e375b0a, first fail: v4.9.243-25-ga01fe8e99a22) platform | arch | lab | compiler | defconfig | regressions ---------------------+------+---------------+----------+---------------------+------------ qemu_arm-versatilepb | arm | lab-collabora | gcc-8 | versatile_defconfig | 1 Details: https://kernelci.org/test/plan/id/61537ba806023b850399a348 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: versatile_defconfig Compiler: gcc-8 (arm-linux-gnueabihf-gcc (Debian 8.3.0-2) 8.3.0) Plain log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.284-31-g4bf84f7dee1f… HTML log: https://storage.kernelci.org//stable-rc/queue-4.9/v4.9.284-31-g4bf84f7dee1f… Rootfs: http://storage.kernelci.org/images/rootfs/buildroot/kci-2020.05-6-g8983f3b7… * baseline.login: https://kernelci.org/test/case/id/61537ba806023b850399a349 failing since 318 days (last pass: v4.9.243-16-gd8d67e375b0a, first fail: v4.9.243-25-ga01fe8e99a22)

2 years, 8 months

1
0
0 0

✅ PASS: Test report for kernel 5.14.8 (stable-queue, c91145f2)

by CKI Project

Hello, We ran automated tests on a recent commit from this kernel tree: Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Commit: c91145f28005 - usb: gadget: f_uac2: Populate SS descriptors' wBytesPerInterval The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK Targeted tests: NO All kernel binaries, config files, and logs are available for download here: https://arr-cki-prod-datawarehouse-public.s3.amazonaws.com/index.html?prefi… Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Compile testing --------------- We compiled the kernel for 4 architectures: aarch64: make options: make -j24 INSTALL_MOD_STRIP=1 targz-pkg ppc64le: make options: make -j24 INSTALL_MOD_STRIP=1 targz-pkg s390x: make options: make -j24 INSTALL_MOD_STRIP=1 targz-pkg x86_64: make options: make -j24 INSTALL_MOD_STRIP=1 targz-pkg Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: Host 1: ✅ Boot test ✅ Reboot test 🚧 ❌ Storage blktests - nvmeof-mp Host 2: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test ⚡⚡⚡ Reboot test ⚡⚡⚡ xfstests - ext4 ⚡⚡⚡ xfstests - xfs ⚡⚡⚡ IPMI driver test ⚡⚡⚡ IPMItool loop stress test ⚡⚡⚡ selinux-policy: serge-testsuite ⚡⚡⚡ Storage blktests - blk ⚡⚡⚡ Storage block - filesystem fio test ⚡⚡⚡ Storage block - queue scheduler test ⚡⚡⚡ storage: software RAID testing ⚡⚡⚡ Storage: swraid mdadm raid_module test 🚧 ⚡⚡⚡ Podman system test - as root 🚧 ⚡⚡⚡ Podman system test - as user 🚧 ⚡⚡⚡ xfstests - btrfs 🚧 ⚡⚡⚡ Storage blktests - nvme-tcp 🚧 ⚡⚡⚡ stress: stress-ng - interrupt 🚧 ⚡⚡⚡ stress: stress-ng - cpu 🚧 ⚡⚡⚡ stress: stress-ng - cpu-cache 🚧 ⚡⚡⚡ stress: stress-ng - memory 🚧 ⚡⚡⚡ stress: stress-ng - os Host 3: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test ⚡⚡⚡ Reboot test 🚧 ⚡⚡⚡ Storage blktests - srp Host 4: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test ⚡⚡⚡ Reboot test ⚡⚡⚡ Networking bridge: sanity - mlx5 ⚡⚡⚡ Ethernet drivers sanity - mlx5 Host 5: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test ✅ Reboot test ✅ ACPI table test ✅ ACPI enabled test ⚡⚡⚡ LTP - cve ⚡⚡⚡ LTP - sched ⚡⚡⚡ LTP - syscalls ⚡⚡⚡ LTP - can ⚡⚡⚡ LTP - commands ⚡⚡⚡ LTP - containers ⚡⚡⚡ LTP - dio ⚡⚡⚡ LTP - fs ⚡⚡⚡ LTP - fsx ⚡⚡⚡ LTP - math ⚡⚡⚡ LTP - hugetlb ⚡⚡⚡ LTP - mm ⚡⚡⚡ LTP - nptl ⚡⚡⚡ LTP - pty ⚡⚡⚡ LTP - ipc ⚡⚡⚡ LTP - tracing ⚡⚡⚡ CIFS Connectathon ⚡⚡⚡ POSIX pjd-fstest suites ⚡⚡⚡ NFS Connectathon ⚡⚡⚡ Loopdev Sanity ⚡⚡⚡ jvm - jcstress tests ⚡⚡⚡ Memory: fork_mem ⚡⚡⚡ Memory function: memfd_create ⚡⚡⚡ AMTU (Abstract Machine Test Utility) ⚡⚡⚡ Networking bridge: sanity ⚡⚡⚡ Ethernet drivers sanity ⚡⚡⚡ Networking socket: fuzz ⚡⚡⚡ Networking route: pmtu ⚡⚡⚡ Networking route_func - local ⚡⚡⚡ Networking route_func - forward ⚡⚡⚡ Networking TCP: keepalive test ⚡⚡⚡ Networking UDP: socket ⚡⚡⚡ Networking cki netfilter test ⚡⚡⚡ Networking tunnel: geneve basic test ⚡⚡⚡ Networking tunnel: gre basic ⚡⚡⚡ L2TP basic test ⚡⚡⚡ Networking tunnel: vxlan basic ⚡⚡⚡ Networking ipsec: basic netns - transport ⚡⚡⚡ Networking ipsec: basic netns - tunnel ⚡⚡⚡ Libkcapi AF_ALG test ⚡⚡⚡ pciutils: update pci ids test ⚡⚡⚡ ALSA PCM loopback test ⚡⚡⚡ ALSA Control (mixer) Userspace Element test ⚡⚡⚡ storage: dm/common ⚡⚡⚡ storage: SCSI VPD ⚡⚡⚡ trace: ftrace/tracer 🚧 ⚡⚡⚡ xarray-idr-radixtree-test 🚧 ⚡⚡⚡ i2c: i2cdetect sanity 🚧 ⚡⚡⚡ Firmware test suite 🚧 ⚡⚡⚡ Memory function: kaslr 🚧 ⚡⚡⚡ Networking: igmp conformance test 🚧 ⚡⚡⚡ audit: audit testsuite test 🚧 ⚡⚡⚡ lvm cache test 🚧 ⚡⚡⚡ lvm snapper test Host 6: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test ⚡⚡⚡ Reboot test ⚡⚡⚡ xfstests - ext4 ⚡⚡⚡ xfstests - xfs ⚡⚡⚡ IPMI driver test ⚡⚡⚡ IPMItool loop stress test ⚡⚡⚡ selinux-policy: serge-testsuite ⚡⚡⚡ Storage blktests - blk ⚡⚡⚡ Storage block - filesystem fio test ⚡⚡⚡ Storage block - queue scheduler test ⚡⚡⚡ storage: software RAID testing ⚡⚡⚡ Storage: swraid mdadm raid_module test 🚧 ⚡⚡⚡ Podman system test - as root 🚧 ⚡⚡⚡ Podman system test - as user 🚧 ⚡⚡⚡ xfstests - btrfs 🚧 ⚡⚡⚡ Storage blktests - nvme-tcp 🚧 ⚡⚡⚡ stress: stress-ng - interrupt 🚧 ⚡⚡⚡ stress: stress-ng - cpu 🚧 ⚡⚡⚡ stress: stress-ng - cpu-cache 🚧 ⚡⚡⚡ stress: stress-ng - memory 🚧 ⚡⚡⚡ stress: stress-ng - os Host 7: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test ⚡⚡⚡ Reboot test ⚡⚡⚡ Networking bridge: sanity - mlx5 ⚡⚡⚡ Ethernet drivers sanity - mlx5 ppc64le: Host 1: ✅ Boot test ✅ Reboot test 🚧 ❌ Storage blktests - srp Host 2: ✅ Boot test ✅ Reboot test 🚧 ❌ Storage blktests - nvmeof-mp Host 3: ✅ Boot test ✅ Reboot test ✅ LTP - cve ✅ LTP - sched ✅ LTP - syscalls ✅ LTP - can ✅ LTP - commands ✅ LTP - containers ✅ LTP - dio ✅ LTP - fs ✅ LTP - fsx ✅ LTP - math ✅ LTP - hugetlb ✅ LTP - mm ✅ LTP - nptl ✅ LTP - pty ✅ LTP - ipc ✅ LTP - tracing ✅ CIFS Connectathon ✅ POSIX pjd-fstest suites ✅ NFS Connectathon ✅ Loopdev Sanity ✅ jvm - jcstress tests ✅ Memory: fork_mem ✅ Memory function: memfd_create ✅ AMTU (Abstract Machine Test Utility) ✅ Networking bridge: sanity ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ Networking route: pmtu ✅ Networking route_func - local ✅ Networking route_func - forward ✅ Networking TCP: keepalive test ✅ Networking UDP: socket ✅ Networking cki netfilter test ✅ Networking tunnel: geneve basic test ✅ Networking tunnel: gre basic ✅ L2TP basic test ✅ Networking tunnel: vxlan basic ✅ Networking ipsec: basic netns - tunnel ✅ Libkcapi AF_ALG test ✅ pciutils: update pci ids test ✅ ALSA PCM loopback test ✅ ALSA Control (mixer) Userspace Element test ✅ storage: dm/common ✅ trace: ftrace/tracer 🚧 ✅ xarray-idr-radixtree-test 🚧 ✅ Memory function: kaslr 🚧 ✅ audit: audit testsuite test 🚧 ✅ lvm cache test 🚧 ✅ lvm snapper test Host 4: ✅ Boot test ✅ Reboot test ✅ xfstests - ext4 ✅ xfstests - xfs ✅ IPMI driver test ✅ IPMItool loop stress test ✅ selinux-policy: serge-testsuite ✅ Storage blktests - blk ✅ Storage block - filesystem fio test ✅ Storage block - queue scheduler test ✅ storage: software RAID testing ✅ Storage: swraid mdadm raid_module test 🚧 ❌ Podman system test - as root 🚧 ✅ Podman system test - as user 🚧 ✅ xfstests - btrfs 🚧 ✅ Storage blktests - nvme-tcp 🚧 ✅ Storage: lvm device-mapper test - upstream s390x: Host 1: ✅ Boot test ✅ Reboot test 🚧 ❌ Storage blktests - nvmeof-mp Host 2: ✅ Boot test ✅ Reboot test ✅ LTP - cve ✅ LTP - sched ✅ LTP - syscalls ✅ LTP - can ✅ LTP - commands ✅ LTP - containers ✅ LTP - dio ✅ LTP - fs ✅ LTP - fsx ✅ LTP - math ✅ LTP - hugetlb ✅ LTP - mm ✅ LTP - nptl ✅ LTP - pty ✅ LTP - ipc ✅ LTP - tracing ✅ CIFS Connectathon ✅ POSIX pjd-fstest suites ✅ NFS Connectathon ✅ Loopdev Sanity ✅ jvm - jcstress tests ✅ Memory: fork_mem ✅ Memory function: memfd_create ✅ AMTU (Abstract Machine Test Utility) ✅ Networking bridge: sanity ✅ Ethernet drivers sanity ✅ Networking route: pmtu ✅ Networking route_func - local ✅ Networking route_func - forward ✅ Networking TCP: keepalive test ✅ Networking UDP: socket ✅ Networking cki netfilter test ✅ Networking tunnel: geneve basic test ✅ Networking tunnel: gre basic ✅ L2TP basic test ✅ Networking tunnel: vxlan basic ✅ Networking ipsec: basic netns - transport ✅ Networking ipsec: basic netns - tunnel ✅ Libkcapi AF_ALG test ✅ storage: dm/common ✅ trace: ftrace/tracer 🚧 ❌ xarray-idr-radixtree-test 🚧 ✅ Memory function: kaslr 🚧 ✅ audit: audit testsuite test 🚧 ✅ lvm cache test 🚧 ✅ lvm snapper test Host 3: ✅ Boot test ✅ Reboot test 🚧 ❌ Storage blktests - srp Host 4: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test ✅ Reboot test ✅ selinux-policy: serge-testsuite ✅ Storage blktests - blk ✅ Storage: swraid mdadm raid_module test 🚧 ✅ Podman system test - as root 🚧 ✅ Podman system test - as user 🚧 ✅ Storage blktests - nvme-tcp 🚧 ✅ stress: stress-ng - interrupt 🚧 ✅ stress: stress-ng - cpu 🚧 ✅ stress: stress-ng - cpu-cache 🚧 ✅ stress: stress-ng - memory 🚧 ⚡⚡⚡ stress: stress-ng - os x86_64: Host 1: ✅ Boot test ✅ Reboot test 🚧 ❌ Storage blktests - srp Host 2: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test ✅ Reboot test ✅ ACPI table test ✅ LTP - cve ✅ LTP - sched ⚡⚡⚡ LTP - syscalls ⚡⚡⚡ LTP - can ⚡⚡⚡ LTP - commands ⚡⚡⚡ LTP - containers ⚡⚡⚡ LTP - dio ⚡⚡⚡ LTP - fs ⚡⚡⚡ LTP - fsx ⚡⚡⚡ LTP - math ⚡⚡⚡ LTP - hugetlb ⚡⚡⚡ LTP - mm ⚡⚡⚡ LTP - nptl ⚡⚡⚡ LTP - pty ⚡⚡⚡ LTP - ipc ⚡⚡⚡ LTP - tracing ⚡⚡⚡ CIFS Connectathon ⚡⚡⚡ POSIX pjd-fstest suites ⚡⚡⚡ NFS Connectathon ⚡⚡⚡ Loopdev Sanity ⚡⚡⚡ jvm - jcstress tests ⚡⚡⚡ Memory: fork_mem ⚡⚡⚡ Memory function: memfd_create ⚡⚡⚡ AMTU (Abstract Machine Test Utility) ⚡⚡⚡ Networking bridge: sanity ⚡⚡⚡ Ethernet drivers sanity ⚡⚡⚡ Networking socket: fuzz ⚡⚡⚡ Networking route: pmtu ⚡⚡⚡ Networking route_func - local ⚡⚡⚡ Networking route_func - forward ⚡⚡⚡ Networking TCP: keepalive test ⚡⚡⚡ Networking UDP: socket ⚡⚡⚡ Networking cki netfilter test ⚡⚡⚡ Networking tunnel: geneve basic test ⚡⚡⚡ Networking tunnel: gre basic ⚡⚡⚡ L2TP basic test ⚡⚡⚡ Networking tunnel: vxlan basic ⚡⚡⚡ Networking ipsec: basic netns - transport ⚡⚡⚡ Networking ipsec: basic netns - tunnel ⚡⚡⚡ Libkcapi AF_ALG test ⚡⚡⚡ pciutils: sanity smoke test ⚡⚡⚡ pciutils: update pci ids test ⚡⚡⚡ ALSA PCM loopback test ⚡⚡⚡ ALSA Control (mixer) Userspace Element test ⚡⚡⚡ storage: dm/common ⚡⚡⚡ storage: SCSI VPD ⚡⚡⚡ trace: ftrace/tracer 🚧 ⚡⚡⚡ xarray-idr-radixtree-test 🚧 ⚡⚡⚡ i2c: i2cdetect sanity 🚧 ⚡⚡⚡ Firmware test suite 🚧 ⚡⚡⚡ Memory function: kaslr 🚧 ⚡⚡⚡ Networking: igmp conformance test 🚧 ⚡⚡⚡ audit: audit testsuite test 🚧 ⚡⚡⚡ lvm cache test 🚧 ⚡⚡⚡ lvm snapper test Host 3: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test ⚡⚡⚡ Reboot test ⚡⚡⚡ xfstests - ext4 ⚡⚡⚡ xfstests - xfs ⚡⚡⚡ xfstests - nfsv4.2 ⚡⚡⚡ xfstests - cifsv3.11 ⚡⚡⚡ IPMI driver test ⚡⚡⚡ IPMItool loop stress test ⚡⚡⚡ selinux-policy: serge-testsuite ⚡⚡⚡ power-management: cpupower/sanity test ⚡⚡⚡ Storage blktests - blk ⚡⚡⚡ Storage block - filesystem fio test ⚡⚡⚡ Storage block - queue scheduler test ⚡⚡⚡ storage: software RAID testing ⚡⚡⚡ Storage: swraid mdadm raid_module test 🚧 ⚡⚡⚡ Podman system test - as root 🚧 ⚡⚡⚡ Podman system test - as user 🚧 ⚡⚡⚡ CPU: Idle Test 🚧 ⚡⚡⚡ xfstests - btrfs 🚧 ⚡⚡⚡ Storage blktests - nvme-tcp 🚧 ⚡⚡⚡ Storage: lvm device-mapper test - upstream 🚧 ⚡⚡⚡ stress: stress-ng - interrupt 🚧 ⚡⚡⚡ stress: stress-ng - cpu 🚧 ⚡⚡⚡ stress: stress-ng - cpu-cache 🚧 ⚡⚡⚡ stress: stress-ng - memory 🚧 ⚡⚡⚡ stress: stress-ng - os Host 4: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test ⚡⚡⚡ Reboot test 🚧 ⚡⚡⚡ Storage blktests - nvmeof-mp Host 5: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test ⚡⚡⚡ Reboot test 🚧 ⚡⚡⚡ Storage blktests - nvmeof-mp Host 6: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test ⚡⚡⚡ Reboot test ⚡⚡⚡ xfstests - ext4 ⚡⚡⚡ xfstests - xfs ⚡⚡⚡ xfstests - nfsv4.2 ⚡⚡⚡ xfstests - cifsv3.11 ⚡⚡⚡ IPMI driver test ⚡⚡⚡ IPMItool loop stress test ⚡⚡⚡ selinux-policy: serge-testsuite ⚡⚡⚡ power-management: cpupower/sanity test ⚡⚡⚡ Storage blktests - blk ⚡⚡⚡ Storage block - filesystem fio test ⚡⚡⚡ Storage block - queue scheduler test ⚡⚡⚡ storage: software RAID testing ⚡⚡⚡ Storage: swraid mdadm raid_module test 🚧 ⚡⚡⚡ Podman system test - as root 🚧 ⚡⚡⚡ Podman system test - as user 🚧 ⚡⚡⚡ CPU: Idle Test 🚧 ⚡⚡⚡ xfstests - btrfs 🚧 ⚡⚡⚡ Storage blktests - nvme-tcp 🚧 ⚡⚡⚡ Storage: lvm device-mapper test - upstream 🚧 ⚡⚡⚡ stress: stress-ng - interrupt 🚧 ⚡⚡⚡ stress: stress-ng - cpu 🚧 ⚡⚡⚡ stress: stress-ng - cpu-cache 🚧 ⚡⚡⚡ stress: stress-ng - memory 🚧 ⚡⚡⚡ stress: stress-ng - os Test sources: https://gitlab.com/cki-project/kernel-tests 💚 Pull requests are welcome for new tests or improvements to existing tests! Aborted tests ------------- Tests that didn't complete running successfully are marked with ⚡⚡⚡. If this was caused by an infrastructure issue, we try to mark that explicitly in the report. Waived tests ------------ If the test run included waived tests, they are marked with 🚧. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed. Testing timeout --------------- We aim to provide a report within reasonable timeframe. Tests that haven't finished running yet are marked with ⏱. Targeted tests -------------- Test runs for patches always include a set of base tests, plus some tests chosen based on the file paths modified by the patch. The latter are called "targeted tests". If no targeted tests are run, that means no patch-specific tests are available. Please, consider contributing a targeted test for related patches to increase test coverage. See https://docs.engineering.redhat.com/x/_wEZB for more details.

2 years, 8 months

1
0
0 0

[PATCH 9/9] mtd: rawnand: xway: Keep the driver compatible with on-die ECC engines

by Miquel Raynal

Following the introduction of the generic ECC engine infrastructure, it was necessary to reorganize the code and move the ECC configuration in the ->attach_chip() hook. Failing to do that properly lead to a first series of fixes supposed to stabilize the situation. Unfortunately, this only fixed the use of software ECC engines, preventing any other kind of engine to be used, including on-die ones. It is now time to (finally) fix the situation by ensuring that we still provide a default (eg. software ECC) but will still support different ECC engines such as on-die ECC engines if properly described in the device tree. There are no changes needed on the core side in order to do this, but we just need to leverage the logic there which allows: 1- a subsystem default (set to Host engines in the raw NAND world) 2- a driver specific default (here set to software ECC engines) 3- any type of engine requested by the user (ie. described in the DT) As the raw NAND subsystem has not yet been fully converted to the ECC engine infrastructure, in order to provide a default ECC engine for this driver we need to set chip->ecc.engine_type *before* calling nand_scan(). During the initialization step, the core will consider this entry as the default engine for this driver. This value may of course be overloaded by the user if the usual DT properties are provided. Fixes: d525914b5bd8 ("mtd: rawnand: xway: Move the ECC initialization to ->attach_chip()") Cc: stable(a)vger.kernel.org Cc: Jan Hoffmann <jan(a)3e8.eu> Cc: Kestrel seventyfour <kestrelseventyfour(a)gmail.com> Signed-off-by: Miquel Raynal <miquel.raynal(a)bootlin.com> --- drivers/mtd/nand/raw/xway_nand.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/raw/xway_nand.c b/drivers/mtd/nand/raw/xway_nand.c index 26751976e502..236fd8c5a958 100644 --- a/drivers/mtd/nand/raw/xway_nand.c +++ b/drivers/mtd/nand/raw/xway_nand.c @@ -148,9 +148,8 @@ static void xway_write_buf(struct nand_chip *chip, const u_char *buf, int len) static int xway_attach_chip(struct nand_chip *chip) { - chip->ecc.engine_type = NAND_ECC_ENGINE_TYPE_SOFT; - - if (chip->ecc.algo == NAND_ECC_ALGO_UNKNOWN) + if (chip->ecc.engine_type == NAND_ECC_ENGINE_TYPE_SOFT && + chip->ecc.algo == NAND_ECC_ALGO_UNKNOWN) chip->ecc.algo = NAND_ECC_ALGO_HAMMING; return 0; @@ -219,6 +218,13 @@ static int xway_nand_probe(struct platform_device *pdev) | NAND_CON_SE_P | NAND_CON_WP_P | NAND_CON_PRE_P | cs_flag, EBU_NAND_CON); + /* + * This driver assumes that the default ECC engine should be TYPE_SOFT. + * Set ->engine_type before registering the NAND devices in order to + * provide a driver specific default value. + */ + data->chip.ecc.engine_type = NAND_ECC_ENGINE_TYPE_SOFT; + /* Scan to find existence of the device */ err = nand_scan(&data->chip, 1); if (err) -- 2.27.0

2 years, 8 months

1
0
0 0

[PATCH 8/9] mtd: rawnand: socrates: Keep the driver compatible with on-die ECC engines

by Miquel Raynal

Following the introduction of the generic ECC engine infrastructure, it was necessary to reorganize the code and move the ECC configuration in the ->attach_chip() hook. Failing to do that properly lead to a first series of fixes supposed to stabilize the situation. Unfortunately, this only fixed the use of software ECC engines, preventing any other kind of engine to be used, including on-die ones. It is now time to (finally) fix the situation by ensuring that we still provide a default (eg. software ECC) but will still support different ECC engines such as on-die ECC engines if properly described in the device tree. There are no changes needed on the core side in order to do this, but we just need to leverage the logic there which allows: 1- a subsystem default (set to Host engines in the raw NAND world) 2- a driver specific default (here set to software ECC engines) 3- any type of engine requested by the user (ie. described in the DT) As the raw NAND subsystem has not yet been fully converted to the ECC engine infrastructure, in order to provide a default ECC engine for this driver we need to set chip->ecc.engine_type *before* calling nand_scan(). During the initialization step, the core will consider this entry as the default engine for this driver. This value may of course be overloaded by the user if the usual DT properties are provided. Fixes: b36bf0a0fe5d ("mtd: rawnand: socrates: Move the ECC initialization to ->attach_chip()") Cc: stable(a)vger.kernel.org Signed-off-by: Miquel Raynal <miquel.raynal(a)bootlin.com> --- drivers/mtd/nand/raw/socrates_nand.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/raw/socrates_nand.c b/drivers/mtd/nand/raw/socrates_nand.c index 70f8305c9b6e..fb39cc7ebce0 100644 --- a/drivers/mtd/nand/raw/socrates_nand.c +++ b/drivers/mtd/nand/raw/socrates_nand.c @@ -119,9 +119,8 @@ static int socrates_nand_device_ready(struct nand_chip *nand_chip) static int socrates_attach_chip(struct nand_chip *chip) { - chip->ecc.engine_type = NAND_ECC_ENGINE_TYPE_SOFT; - - if (chip->ecc.algo == NAND_ECC_ALGO_UNKNOWN) + if (chip->ecc.engine_type == NAND_ECC_ENGINE_TYPE_SOFT && + chip->ecc.algo == NAND_ECC_ALGO_UNKNOWN) chip->ecc.algo = NAND_ECC_ALGO_HAMMING; return 0; @@ -175,6 +174,13 @@ static int socrates_nand_probe(struct platform_device *ofdev) /* TODO: I have no idea what real delay is. */ nand_chip->legacy.chip_delay = 20; /* 20us command delay time */ + /* + * This driver assumes that the default ECC engine should be TYPE_SOFT. + * Set ->engine_type before registering the NAND devices in order to + * provide a driver specific default value. + */ + nand_chip->ecc.engine_type = NAND_ECC_ENGINE_TYPE_SOFT; + dev_set_drvdata(&ofdev->dev, host); res = nand_scan(nand_chip, 1); -- 2.27.0

2 years, 8 months

1
0
0 0

[PATCH 7/9] mtd: rawnand: plat_nand: Keep the driver compatible with on-die ECC engines

by Miquel Raynal

Following the introduction of the generic ECC engine infrastructure, it was necessary to reorganize the code and move the ECC configuration in the ->attach_chip() hook. Failing to do that properly lead to a first series of fixes supposed to stabilize the situation. Unfortunately, this only fixed the use of software ECC engines, preventing any other kind of engine to be used, including on-die ones. It is now time to (finally) fix the situation by ensuring that we still provide a default (eg. software ECC) but will still support different ECC engines such as on-die ECC engines if properly described in the device tree. There are no changes needed on the core side in order to do this, but we just need to leverage the logic there which allows: 1- a subsystem default (set to Host engines in the raw NAND world) 2- a driver specific default (here set to software ECC engines) 3- any type of engine requested by the user (ie. described in the DT) As the raw NAND subsystem has not yet been fully converted to the ECC engine infrastructure, in order to provide a default ECC engine for this driver we need to set chip->ecc.engine_type *before* calling nand_scan(). During the initialization step, the core will consider this entry as the default engine for this driver. This value may of course be overloaded by the user if the usual DT properties are provided. Fixes: 612e048e6aab ("mtd: rawnand: plat_nand: Move the ECC initialization to ->attach_chip()") Cc: stable(a)vger.kernel.org Signed-off-by: Miquel Raynal <miquel.raynal(a)bootlin.com> --- drivers/mtd/nand/raw/plat_nand.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/raw/plat_nand.c b/drivers/mtd/nand/raw/plat_nand.c index 7711e1020c21..0ee08c42cc35 100644 --- a/drivers/mtd/nand/raw/plat_nand.c +++ b/drivers/mtd/nand/raw/plat_nand.c @@ -21,9 +21,8 @@ struct plat_nand_data { static int plat_nand_attach_chip(struct nand_chip *chip) { - chip->ecc.engine_type = NAND_ECC_ENGINE_TYPE_SOFT; - - if (chip->ecc.algo == NAND_ECC_ALGO_UNKNOWN) + if (chip->ecc.engine_type == NAND_ECC_ENGINE_TYPE_SOFT && + chip->ecc.algo == NAND_ECC_ALGO_UNKNOWN) chip->ecc.algo = NAND_ECC_ALGO_HAMMING; return 0; @@ -94,6 +93,13 @@ static int plat_nand_probe(struct platform_device *pdev) goto out; } + /* + * This driver assumes that the default ECC engine should be TYPE_SOFT. + * Set ->engine_type before registering the NAND devices in order to + * provide a driver specific default value. + */ + data->chip.ecc.engine_type = NAND_ECC_ENGINE_TYPE_SOFT; + /* Scan to find existence of the device */ err = nand_scan(&data->chip, pdata->chip.nr_chips); if (err) -- 2.27.0

2 years, 8 months

1
0
0 0

[PATCH 6/9] mtd: rawnand: pasemi: Keep the driver compatible with on-die ECC engines

by Miquel Raynal

Following the introduction of the generic ECC engine infrastructure, it was necessary to reorganize the code and move the ECC configuration in the ->attach_chip() hook. Failing to do that properly lead to a first series of fixes supposed to stabilize the situation. Unfortunately, this only fixed the use of software ECC engines, preventing any other kind of engine to be used, including on-die ones. It is now time to (finally) fix the situation by ensuring that we still provide a default (eg. software ECC) but will still support different ECC engines such as on-die ECC engines if properly described in the device tree. There are no changes needed on the core side in order to do this, but we just need to leverage the logic there which allows: 1- a subsystem default (set to Host engines in the raw NAND world) 2- a driver specific default (here set to software ECC engines) 3- any type of engine requested by the user (ie. described in the DT) As the raw NAND subsystem has not yet been fully converted to the ECC engine infrastructure, in order to provide a default ECC engine for this driver we need to set chip->ecc.engine_type *before* calling nand_scan(). During the initialization step, the core will consider this entry as the default engine for this driver. This value may of course be overloaded by the user if the usual DT properties are provided. Fixes: 8fc6f1f042b2 ("mtd: rawnand: pasemi: Move the ECC initialization to ->attach_chip()") Cc: stable(a)vger.kernel.org Signed-off-by: Miquel Raynal <miquel.raynal(a)bootlin.com> --- drivers/mtd/nand/raw/pasemi_nand.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/raw/pasemi_nand.c b/drivers/mtd/nand/raw/pasemi_nand.c index 789f33312c15..c176036453ed 100644 --- a/drivers/mtd/nand/raw/pasemi_nand.c +++ b/drivers/mtd/nand/raw/pasemi_nand.c @@ -75,9 +75,8 @@ static int pasemi_device_ready(struct nand_chip *chip) static int pasemi_attach_chip(struct nand_chip *chip) { - chip->ecc.engine_type = NAND_ECC_ENGINE_TYPE_SOFT; - - if (chip->ecc.algo == NAND_ECC_ALGO_UNKNOWN) + if (chip->ecc.engine_type == NAND_ECC_ENGINE_TYPE_SOFT && + chip->ecc.algo == NAND_ECC_ALGO_UNKNOWN) chip->ecc.algo = NAND_ECC_ALGO_HAMMING; return 0; @@ -154,6 +153,13 @@ static int pasemi_nand_probe(struct platform_device *ofdev) /* Enable the following for a flash based bad block table */ chip->bbt_options = NAND_BBT_USE_FLASH; + /* + * This driver assumes that the default ECC engine should be TYPE_SOFT. + * Set ->engine_type before registering the NAND devices in order to + * provide a driver specific default value. + */ + chip->ecc.engine_type = NAND_ECC_ENGINE_TYPE_SOFT; + /* Scan to find existence of the device */ err = nand_scan(chip, 1); if (err) -- 2.27.0

2 years, 8 months

1
0
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror September 2021