The patch titled
Subject: mm/z3fold.c: use kref to prevent page free/compact race
has been added to the -mm tree. Its filename is
z3fold-use-kref-to-prevent-page-free-compact-race.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/z3fold-use-kref-to-prevent-page-fr…
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/z3fold-use-kref-to-prevent-page-fr…
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Vitaly Wool <vitalywool(a)gmail.com>
Subject: mm/z3fold.c: use kref to prevent page free/compact race
There is a race in the current z3fold implementation between do_compact()
called in a work queue context and the page release procedure when page's
kref goes to 0. do_compact() may be waiting for page lock, which is
released by release_z3fold_page_locked right before putting the page onto
the "stale" list, and then the page may be freed as do_compact() modifies
its contents.
The mechanism currently implemented to handle that (checking the
PAGE_STALE flag) is not reliable enough. Instead, we'll use page's kref
counter to guarantee that the page is not released if its compaction is
scheduled. It then becomes compaction function's responsibility to
decrease the counter and quit immediately if the page was actually freed.
Link: http://lkml.kernel.org/r/20171117092032.00ea56f42affbed19f4fcc6c@gmail.com
Signed-off-by: Vitaly Wool <vitaly.wool(a)sonymobile.com>
Cc: <Oleksiy.Avramchenko(a)sony.com>
Cc: <stable(a)vger.kernel.org>
Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org>
---
mm/z3fold.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff -puN mm/z3fold.c~z3fold-use-kref-to-prevent-page-free-compact-race mm/z3fold.c
--- a/mm/z3fold.c~z3fold-use-kref-to-prevent-page-free-compact-race
+++ a/mm/z3fold.c
@@ -404,8 +404,7 @@ static void do_compact_page(struct z3fol
WARN_ON(z3fold_page_trylock(zhdr));
else
z3fold_page_lock(zhdr);
- if (test_bit(PAGE_STALE, &page->private) ||
- !test_and_clear_bit(NEEDS_COMPACTING, &page->private)) {
+ if (WARN_ON(!test_and_clear_bit(NEEDS_COMPACTING, &page->private))) {
z3fold_page_unlock(zhdr);
return;
}
@@ -413,6 +412,11 @@ static void do_compact_page(struct z3fol
list_del_init(&zhdr->buddy);
spin_unlock(&pool->lock);
+ if (kref_put(&zhdr->refcount, release_z3fold_page_locked)) {
+ atomic64_dec(&pool->pages_nr);
+ return;
+ }
+
z3fold_compact_page(zhdr);
unbuddied = get_cpu_ptr(pool->unbuddied);
fchunks = num_free_chunks(zhdr);
@@ -753,9 +757,11 @@ static void z3fold_free(struct z3fold_po
list_del_init(&zhdr->buddy);
spin_unlock(&pool->lock);
zhdr->cpu = -1;
+ kref_get(&zhdr->refcount);
do_compact_page(zhdr, true);
return;
}
+ kref_get(&zhdr->refcount);
queue_work_on(zhdr->cpu, pool->compact_wq, &zhdr->work);
z3fold_page_unlock(zhdr);
}
_
Patches currently in -mm which might be from vitalywool(a)gmail.com are
z3fold-use-kref-to-prevent-page-free-compact-race.patch
A new field was introduced in 74d46992e0d9dee7f1f376de0d56d31614c8a17a,
bi_partno, instead of using bdev->bd_contains and encoding the partition
information in the bi_bdev field. __bio_clone_fast was changed to copy
the disk information, but not the partition information. At minimum,
this regressed bcache and caused data corruption.
Signed-off-by: Michael Lyle <mlyle(a)lyle.org>
Fixes: 74d46992e0d9dee7f1f376de0d56d31614c8a17a
Reported-by: Pavel Goran <via-bcache(a)pvgoran.name>
Reported-by: Campbell Steven <casteven(a)gmail.com>
Cc: Christoph Hellwig <hch(a)lst.de>
Cc: Jens Axboe <axboe(a)kernel.dk>
Cc: <stable(a)vger.kernel.org>
---
block/bio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/bio.c b/block/bio.c
index 101c2a9b5481..33fa6b4af312 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -597,6 +597,7 @@ void __bio_clone_fast(struct bio *bio, struct bio *bio_src)
* so we don't set nor calculate new physical/hw segment counts here
*/
bio->bi_disk = bio_src->bi_disk;
+ bio->bi_partno = bio_src->bi_partno;
bio_set_flag(bio, BIO_CLONED);
bio->bi_opf = bio_src->bi_opf;
bio->bi_write_hint = bio_src->bi_write_hint;
--
2.14.1
Resending as the first attempt is not showing up in the list archive.
This patch converts several network drivers to use smp_rmb
rather than read_barrier_depends. The initial issue was
discovered with ixgbe on a Power machine which resulted
in skb list corruption due to fetching a stale skb pointer.
More details can be found in the ixgbe patch description.
Brian King (7):
ixgbe: Fix skb list corruption on Power systems
i40e: Use smp_rmb rather than read_barrier_depends
ixgbevf: Use smp_rmb rather than read_barrier_depends
igbvf: Use smp_rmb rather than read_barrier_depends
igb: Use smp_rmb rather than read_barrier_depends
fm10k: Use smp_rmb rather than read_barrier_depends
i40evf: Use smp_rmb rather than read_barrier_depends
drivers/net/ethernet/intel/fm10k/fm10k_main.c | 2 +-
drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-
drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +-
drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 2 +-
drivers/net/ethernet/intel/igb/igb_main.c | 2 +-
drivers/net/ethernet/intel/igbvf/netdev.c | 2 +-
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 ++-
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 +-
8 files changed, 9 insertions(+), 8 deletions(-)
--
1.8.3.1
This is the start of the stable review cycle for the 4.9.63 release.
There are 39 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Sat Nov 18 17:42:01 UTC 2017.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.63-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
Linux 4.9.63-rc1
Willy Tarreau <w(a)1wt.eu>
misc: panel: properly restore atomic counter on error path
Nicholas Bellinger <nab(a)linux-iscsi.org>
qla2xxx: Fix incorrect tcm_qla2xxx_free_cmd use during TMR ABORT (v2)
Bart Van Assche <bart.vanassche(a)sandisk.com>
target/iscsi: Fix iSCSI task reassignment handling
Chi-hsien Lin <Chi-Hsien.Lin(a)cypress.com>
brcmfmac: remove setting IBSS mode when stopping AP
Bilal Amarni <bilal.amarni(a)gmail.com>
security/keys: add CONFIG_KEYS_COMPAT to Kconfig
Florian Westphal <fw(a)strlen.de>
netfilter: nat: Revert "netfilter: nat: convert nat bysrc hash to rhashtable"
Florian Westphal <fw(a)strlen.de>
netfilter: nat: avoid use of nf_conn_nat extension
Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
Revert "ARM: dts: imx53-qsb-common: fix FEC pinmux config"
Takashi Iwai <tiwai(a)suse.de>
ALSA: seq: Cancel pending autoload work at unbinding device
Dmitry Torokhov <dmitry.torokhov(a)gmail.com>
Input: ims-psu - check if CDC union descriptor is sane
Alan Stern <stern(a)rowland.harvard.edu>
usb: usbtest: fix NULL pointer dereference
Johannes Berg <johannes.berg(a)intel.com>
mac80211: don't compare TKIP TX MIC key in reinstall prevention
Jason A. Donenfeld <Jason(a)zx2c4.com>
mac80211: use constant time comparison with keys
Johannes Berg <johannes.berg(a)intel.com>
mac80211: accept key reinstall without changing anything
Guillaume Nault <g.nault(a)alphalink.fr>
ppp: fix race in ppp device destruction
Cong Wang <xiyou.wangcong(a)gmail.com>
net_sched: avoid matching qdisc with zero handle
Xin Long <lucien.xin(a)gmail.com>
sctp: reset owner sk for data chunks on out queues when migrating a sock
Julien Gomes <julien(a)arista.com>
tun: allow positive return values on dev_get_valid_name() call
Xin Long <lucien.xin(a)gmail.com>
ip6_gre: update dst pmtu if dev mtu has been updated by toobig in __gre6_xmit
Xin Long <lucien.xin(a)gmail.com>
ip6_gre: only increase err_count for some certain type icmpv6 in ip6gre_err
Xin Long <lucien.xin(a)gmail.com>
ipip: only increase err_count for some certain type icmp in ipip_err
Girish Moodalbail <girish.moodalbail(a)oracle.com>
tap: double-free in error path in tap_open()
Andrei Vagin <avagin(a)openvz.org>
net/unix: don't show information about sockets from other namespaces
Eric Dumazet <edumazet(a)google.com>
tcp/dccp: fix other lockdep splats accessing ireq_opt
Eric Dumazet <edumazet(a)google.com>
tcp/dccp: fix lockdep splat in inet_csk_route_req()
Laszlo Toth <laszlth(a)gmail.com>
sctp: full support for ipv6 ip_nonlocal_bind & IP_FREEBIND
Eric Dumazet <edumazet(a)google.com>
ipv6: flowlabel: do not leave opt->tot_len with garbage
Craig Gallek <kraig(a)google.com>
soreuseport: fix initialization race
Eric Dumazet <edumazet(a)google.com>
packet: avoid panic in packet_getsockopt()
Eric Dumazet <edumazet(a)google.com>
tcp/dccp: fix ireq->opt races
Xin Long <lucien.xin(a)gmail.com>
sctp: add the missing sock_owned_by_user check in sctp_icmp_redirect
Cong Wang <xiyou.wangcong(a)gmail.com>
tun: call dev_get_valid_name() before register_netdevice()
Guillaume Nault <g.nault(a)alphalink.fr>
l2tp: check ps->sock before running pppol2tp_session_ioctl()
Eric Dumazet <edumazet(a)google.com>
tcp: fix tcp_mtu_probe() vs highest_sack
Eric Dumazet <edumazet(a)google.com>
net: call cgroup_sk_alloc() earlier in sk_clone_lock()
Jason A. Donenfeld <Jason(a)zx2c4.com>
netlink: do not set cb_running if dump's start() errs
Eric Dumazet <edumazet(a)google.com>
ipv6: addrconf: increment ifp refcount before ipv6_del_addr()
Craig Gallek <kraig(a)google.com>
tun/tap: sanitize TUNSETSNDBUF input
Alexey Kodanev <alexey.kodanev(a)oracle.com>
gso: fix payload length when gso_size is zero
-------------
Diffstat:
Makefile | 4 +-
arch/arm/boot/dts/imx53-qsb-common.dtsi | 20 +--
arch/powerpc/Kconfig | 5 -
arch/s390/Kconfig | 3 -
arch/sparc/Kconfig | 3 -
arch/x86/Kconfig | 4 -
drivers/input/misc/ims-pcu.c | 16 ++-
drivers/misc/panel.c | 23 +++-
drivers/net/macvtap.c | 20 +--
drivers/net/ppp/ppp_generic.c | 20 +++
drivers/net/tun.c | 7 +
.../broadcom/brcm80211/brcmfmac/cfg80211.c | 3 -
drivers/scsi/qla2xxx/tcm_qla2xxx.c | 33 -----
drivers/target/iscsi/iscsi_target.c | 19 +--
drivers/usb/misc/usbtest.c | 5 +-
include/linux/netdevice.h | 3 +
include/net/inet_sock.h | 8 +-
include/net/netfilter/nf_conntrack.h | 3 +-
include/net/netfilter/nf_nat.h | 1 -
include/net/tcp.h | 6 +-
include/target/target_core_base.h | 1 +
net/core/dev.c | 6 +-
net/core/sock.c | 3 +-
net/core/sock_reuseport.c | 12 +-
net/dccp/ipv4.c | 13 +-
net/ipv4/cipso_ipv4.c | 24 +---
net/ipv4/gre_offload.c | 2 +-
net/ipv4/inet_connection_sock.c | 9 +-
net/ipv4/inet_hashtables.c | 5 +-
net/ipv4/ipip.c | 59 ++++++---
net/ipv4/syncookies.c | 2 +-
net/ipv4/tcp_input.c | 2 +-
net/ipv4/tcp_ipv4.c | 21 +--
net/ipv4/tcp_output.c | 3 +-
net/ipv4/udp.c | 5 +-
net/ipv4/udp_offload.c | 2 +-
net/ipv6/addrconf.c | 1 +
net/ipv6/ip6_flowlabel.c | 1 +
net/ipv6/ip6_gre.c | 20 ++-
net/ipv6/ip6_offload.c | 2 +-
net/ipv6/ip6_output.c | 4 +-
net/l2tp/l2tp_ppp.c | 3 +
net/mac80211/key.c | 54 +++++++-
net/netfilter/nf_conntrack_core.c | 2 +-
net/netfilter/nf_nat_core.c | 146 ++++++++-------------
net/netlink/af_netlink.c | 13 +-
net/packet/af_packet.c | 24 ++--
net/sched/sch_api.c | 2 +
net/sctp/input.c | 2 +-
net/sctp/ipv6.c | 6 +-
net/sctp/socket.c | 32 +++++
net/unix/diag.c | 2 +
security/keys/Kconfig | 4 +
sound/core/seq/seq_device.c | 3 +
54 files changed, 403 insertions(+), 293 deletions(-)
This is the start of the stable review cycle for the 4.4.99 release.
There are 28 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Sat Nov 18 17:41:29 UTC 2017.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.99-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
Linux 4.4.99-rc1
Willy Tarreau <w(a)1wt.eu>
misc: panel: properly restore atomic counter on error path
Nicholas Bellinger <nab(a)linux-iscsi.org>
target: Fix node_acl demo-mode + uncached dynamic shutdown regression
Bart Van Assche <bart.vanassche(a)sandisk.com>
target/iscsi: Fix iSCSI task reassignment handling
Chi-hsien Lin <Chi-Hsien.Lin(a)cypress.com>
brcmfmac: remove setting IBSS mode when stopping AP
Richard Alpe <richard.alpe(a)ericsson.com>
tipc: fix link attribute propagation bug
Bilal Amarni <bilal.amarni(a)gmail.com>
security/keys: add CONFIG_KEYS_COMPAT to Kconfig
Eric Dumazet <edumazet(a)google.com>
tcp/dccp: fix other lockdep splats accessing ireq_opt
Eric Dumazet <edumazet(a)google.com>
tcp/dccp: fix lockdep splat in inet_csk_route_req()
Eric Dumazet <edumazet(a)google.com>
tcp/dccp: fix ireq->opt races
Xin Long <lucien.xin(a)gmail.com>
ipip: only increase err_count for some certain type icmp in ipip_err
Guillaume Nault <g.nault(a)alphalink.fr>
ppp: fix race in ppp device destruction
Xin Long <lucien.xin(a)gmail.com>
sctp: reset owner sk for data chunks on out queues when migrating a sock
Julien Gomes <julien(a)arista.com>
tun: allow positive return values on dev_get_valid_name() call
Xin Long <lucien.xin(a)gmail.com>
ip6_gre: only increase err_count for some certain type icmpv6 in ip6gre_err
Andrei Vagin <avagin(a)openvz.org>
net/unix: don't show information about sockets from other namespaces
Eric Dumazet <edumazet(a)google.com>
ipv6: flowlabel: do not leave opt->tot_len with garbage
Eric Dumazet <edumazet(a)google.com>
packet: avoid panic in packet_getsockopt()
Xin Long <lucien.xin(a)gmail.com>
sctp: add the missing sock_owned_by_user check in sctp_icmp_redirect
Cong Wang <xiyou.wangcong(a)gmail.com>
tun: call dev_get_valid_name() before register_netdevice()
Guillaume Nault <g.nault(a)alphalink.fr>
l2tp: check ps->sock before running pppol2tp_session_ioctl()
Eric Dumazet <edumazet(a)google.com>
tcp: fix tcp_mtu_probe() vs highest_sack
Craig Gallek <kraig(a)google.com>
tun/tap: sanitize TUNSETSNDBUF input
Takashi Iwai <tiwai(a)suse.de>
ALSA: seq: Cancel pending autoload work at unbinding device
Dmitry Torokhov <dmitry.torokhov(a)gmail.com>
Input: ims-psu - check if CDC union descriptor is sane
Alan Stern <stern(a)rowland.harvard.edu>
usb: usbtest: fix NULL pointer dereference
Johannes Berg <johannes.berg(a)intel.com>
mac80211: don't compare TKIP TX MIC key in reinstall prevention
Jason A. Donenfeld <Jason(a)zx2c4.com>
mac80211: use constant time comparison with keys
Johannes Berg <johannes.berg(a)intel.com>
mac80211: accept key reinstall without changing anything
-------------
Diffstat:
Makefile | 4 +-
arch/powerpc/Kconfig | 5 --
arch/s390/Kconfig | 3 --
arch/sparc/Kconfig | 3 --
arch/x86/Kconfig | 4 --
drivers/input/misc/ims-pcu.c | 16 +++++-
drivers/net/macvtap.c | 2 +
drivers/net/ppp/ppp_generic.c | 20 ++++++++
drivers/net/tun.c | 7 +++
drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c | 3 --
drivers/staging/panel/panel.c | 23 +++++++--
drivers/target/iscsi/iscsi_target.c | 19 +++----
drivers/target/target_core_tpg.c | 4 +-
drivers/target/target_core_transport.c | 4 +-
drivers/usb/misc/usbtest.c | 5 +-
include/linux/netdevice.h | 3 ++
include/net/inet_sock.h | 8 ++-
include/net/tcp.h | 6 +--
include/target/target_core_base.h | 1 +
net/core/dev.c | 6 +--
net/dccp/ipv4.c | 13 +++--
net/ipv4/cipso_ipv4.c | 24 +++------
net/ipv4/inet_connection_sock.c | 9 ++--
net/ipv4/ipip.c | 58 ++++++++++++++++------
net/ipv4/syncookies.c | 2 +-
net/ipv4/tcp_input.c | 2 +-
net/ipv4/tcp_ipv4.c | 21 ++++----
net/ipv4/tcp_output.c | 3 +-
net/ipv6/ip6_flowlabel.c | 1 +
net/ipv6/ip6_gre.c | 11 ++--
net/ipv6/ip6_output.c | 4 +-
net/l2tp/l2tp_ppp.c | 3 ++
net/mac80211/key.c | 53 ++++++++++++++++++--
net/packet/af_packet.c | 24 ++++++---
net/sctp/input.c | 2 +-
net/sctp/socket.c | 32 ++++++++++++
net/tipc/link.c | 28 +++--------
net/tipc/link.h | 1 -
net/unix/diag.c | 2 +
security/keys/Kconfig | 4 ++
sound/core/seq/seq_device.c | 3 ++
41 files changed, 299 insertions(+), 147 deletions(-)
On Thu, Nov 16, 2017 at 08:28:28PM +0000, James Cowgill wrote:
> Hi,
>
> On 16/11/17 19:04, Ben Hutchings wrote:
> > On Wed, 2017-11-15 at 16:50 +0000, James Cowgill wrote:
> >> Since I was a little puzzled as to why keyutils built previously on
> >> mips, I found this commit to 4.8 which caused the need for KEYS_COMPAT:
> >>
> >> commit 20f06ed9f61a185c6dabd662c310bed6189470df
> >> Author: David Howells <dhowells(a)redhat.com>
> >> Date: Wed Jul 27 11:43:37 2016 +0100
> >>
> >> KEYS: 64-bit MIPS needs to use compat_sys_keyctl for 32-bit userspace
> >>
> >> MIPS64 needs to use compat_sys_keyctl for 32-bit userspace rather than
> >> calling sys_keyctl. The latter will work in a lot of cases, thereby hiding
> >> the issue.
> >>
> >> Now I'm thinking maybe this can be argued as a bugfix for the above
> >> commit and put in upstream 4.9?
> >
> > Greg, please queue up these two for 4.9:
> >
> > 5c2a625937ba arm64: support keyctl() system call in 32-bit mode
> > 47b2c3fff493 security/keys: add CONFIG_KEYS_COMPAT to Kconfig
>
> Sorry, I asked for this in two places. I think it's already queued up
> for 4.9 now.
Well, close, but not quite. The second patch there reverts the first
patch, and adds the "generic" work. As I already handled that in the
merge of the second patch, the first one is not needed, and the end
result should be the same.
So all is good. Or at least I think so, someone verifying I got this
all right would be appreciated :)
thanks,
greg k-h
On Tue, Oct 10, 2017 at 10:31 AM, Julia Lawall <julia.lawall(a)lip6.fr> wrote:
>
>
> On Tue, 10 Oct 2017, Levin, Alexander (Sasha Levin) wrote:
>
>> (Cc'ed Julia)
>>
>> On Mon, Oct 09, 2017 at 09:33:01AM -0700, Laura Abbott wrote:
>> >On 10/06/2017 08:10 PM, Levin, Alexander (Sasha Levin) wrote:
>> >> We are experimenting with using neural network to aid with patch
>> >> selection for stable kernel trees. There are quite a few commits that
>> >> were not marked for stable, but are stable material, and we're trying
>> >> to get them into their appropriate kernel trees.
>> >>
>> >
>> >Apart from the practical which has been covered, I'd be interested
>> >in hearing about the details of how this works if you can share
>> >them.
>>
>> This work is based on Julia's work
>> (https://soarsmu.github.io/papers/icse12-patch.pdf) to identify
>> commits that fix bugs.
>>
>> Essentially, my approach to this is to extract as much information as
>> possbile form the commit, including things such as:
>>
>> - How many times a certain word appeared in the message
>> - Who is the author
>> - Code metrics
>> - etc
>>
>> In my case, I end up with about 30,000 of these "inputs", and train a
>> neural network based on whether a given commit was included in a
>> stable tree or not.
>>
>> This approach has a few drawbacks compared to the one Julia
>> described in her paper:
>>
>> - Not every bug fixing commit ends up in stable (some end up in -rc
>> fixing a bug from the current merge window).
>> - Same as above, but for commits we miss and fail to add to stable.
>> - Sometimes commits get added to stable even though they don't follow
>> the rules at all (security fixes are a simple example).
>>
>> But it does seem to be effective at finding bug fixing commits that
>> should be in stable.
>>
>> At this stage we are still trying to figure out what a "bug fixing"
>> commit really is. For example, an observation we recently made was
>> that the code metrics actually don't have much weight in determining
>> whether a commit should be in stable or not.
>>
>> As we just started, I'm still experimenting with a few approaches, and
>> I belive Julia is waiting for a new student to take over this, so we
>> don't have any big insights to share just yet :)
>
> That's a good summary of the current status. Thanks!
>
> julia
I just started noticing the AUTOSEL tags yesterday and I think that's
a great idea to tag patches, but was there any thought to also putting
something in the commit message this way they're easily identifiable
in the git logs? I think it would be useful if there was some metadata
in the commit message which identified that it was selected through
some automated system. That way if I find a regression and it
identifies one of these commits I can know that maybe it was chosen
incorrectly, and also would allow me to alert the owner of the
selection script to better help refine its selection process.
Otherwise I'd have to track back through the mailing lists to see how
it landed in the stable release.
Just a thought. Also, thank you for trying to improve the stable kernels!
--
Josh