- Linux-stable-mirror - lists.linaro.org

Re: [PATCH v1] virtio_blk: Fix disk deletion hang on device surprise removal

by Michael S. Tsirkin

On Wed, May 21, 2025 at 06:37:41AM +0000, Parav Pandit wrote: > When the PCI device is surprise removed, requests may not complete > the device as the VQ is marked as broken. Due to this, the disk > deletion hangs. > > Fix it by aborting the requests when the VQ is broken. > > With this fix now fio completes swiftly. > An alternative of IO timeout has been considered, however > when the driver knows about unresponsive block device, swiftly clearing > them enables users and upper layers to react quickly. > > Verified with multiple device unplug iterations with pending requests in > virtio used ring and some pending with the device. > > Fixes: 43bb40c5b926 ("virtio_pci: Support surprise removal of virtio pci device") > Cc: stable(a)vger.kernel.org > Reported-by: lirongqing(a)baidu.com > Closes: https://lore.kernel.org/virtualization/c45dd68698cd47238c55fb73ca9b4741@bai… > Reviewed-by: Max Gurtovoy <mgurtovoy(a)nvidia.com> > Reviewed-by: Israel Rukshin <israelr(a)nvidia.com> > Signed-off-by: Parav Pandit <parav(a)nvidia.com> > --- > changelog: > v0->v1: > - Fixed comments from Stefan to rename a cleanup function > - Improved logic for handling any outstanding requests > in bio layer > - improved cancel callback to sync with ongoing done() thanks for the patch! questions: > --- > drivers/block/virtio_blk.c | 95 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 95 insertions(+) > > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c > index 7cffea01d868..5212afdbd3c7 100644 > --- a/drivers/block/virtio_blk.c > +++ b/drivers/block/virtio_blk.c > @@ -435,6 +435,13 @@ static blk_status_t virtio_queue_rq(struct blk_mq_hw_ctx *hctx, > blk_status_t status; > int err; > > + /* Immediately fail all incoming requests if the vq is broken. > + * Once the queue is unquiesced, upper block layer flushes any pending > + * queued requests; fail them right away. > + */ > + if (unlikely(virtqueue_is_broken(vblk->vqs[qid].vq))) > + return BLK_STS_IOERR; > + > status = virtblk_prep_rq(hctx, vblk, req, vbr); > if (unlikely(status)) > return status; just below this: spin_lock_irqsave(&vblk->vqs[qid].lock, flags); err = virtblk_add_req(vblk->vqs[qid].vq, vbr); if (err) { and virtblk_add_req calls virtqueue_add_sgs, so it will fail on a broken vq. Why do we need to check it one extra time here? > @@ -508,6 +515,11 @@ static void virtio_queue_rqs(struct rq_list *rqlist) > while ((req = rq_list_pop(rqlist))) { > struct virtio_blk_vq *this_vq = get_virtio_blk_vq(req->mq_hctx); > > + if (unlikely(virtqueue_is_broken(this_vq->vq))) { > + rq_list_add_tail(&requeue_list, req); > + continue; > + } > + > if (vq && vq != this_vq) > virtblk_add_req_batch(vq, &submit_list); > vq = this_vq; similarly > @@ -1554,6 +1566,87 @@ static int virtblk_probe(struct virtio_device *vdev) > return err; > } > > +static bool virtblk_request_cancel(struct request *rq, void *data) > +{ > + struct virtblk_req *vbr = blk_mq_rq_to_pdu(rq); > + struct virtio_blk *vblk = data; > + struct virtio_blk_vq *vq; > + unsigned long flags; > + > + vq = &vblk->vqs[rq->mq_hctx->queue_num]; > + > + spin_lock_irqsave(&vq->lock, flags); > + > + vbr->in_hdr.status = VIRTIO_BLK_S_IOERR; > + if (blk_mq_request_started(rq) && !blk_mq_request_completed(rq)) > + blk_mq_complete_request(rq); > + > + spin_unlock_irqrestore(&vq->lock, flags); > + return true; > +} > + > +static void virtblk_broken_device_cleanup(struct virtio_blk *vblk) > +{ > + struct request_queue *q = vblk->disk->queue; > + > + if (!virtqueue_is_broken(vblk->vqs[0].vq)) > + return; > + > + /* Start freezing the queue, so that new requests keeps waitng at the > + * door of bio_queue_enter(). We cannot fully freeze the queue because > + * freezed queue is an empty queue and there are pending requests, so > + * only start freezing it. > + */ > + blk_freeze_queue_start(q); > + > + /* When quiescing completes, all ongoing dispatches have completed > + * and no new dispatch will happen towards the driver. > + * This ensures that later when cancel is attempted, then are not > + * getting processed by the queue_rq() or queue_rqs() handlers. > + */ > + blk_mq_quiesce_queue(q); > + > + /* > + * Synchronize with any ongoing VQ callbacks, effectively quiescing > + * the device and preventing it from completing further requests > + * to the block layer. Any outstanding, incomplete requests will be > + * completed by virtblk_request_cancel(). > + */ > + virtio_synchronize_cbs(vblk->vdev); > + > + /* At this point, no new requests can enter the queue_rq() and > + * completion routine will not complete any new requests either for the > + * broken vq. Hence, it is safe to cancel all requests which are > + * started. > + */ > + blk_mq_tagset_busy_iter(&vblk->tag_set, virtblk_request_cancel, vblk); > + blk_mq_tagset_wait_completed_request(&vblk->tag_set); > + > + /* All pending requests are cleaned up. Time to resume so that disk > + * deletion can be smooth. Start the HW queues so that when queue is > + * unquiesced requests can again enter the driver. > + */ > + blk_mq_start_stopped_hw_queues(q, true); > + > + /* Unquiescing will trigger dispatching any pending requests to the > + * driver which has crossed bio_queue_enter() to the driver. > + */ > + blk_mq_unquiesce_queue(q); > + > + /* Wait for all pending dispatches to terminate which may have been > + * initiated after unquiescing. > + */ > + blk_mq_freeze_queue_wait(q); > + > + /* Mark the disk dead so that once queue unfreeze, the requests > + * waiting at the door of bio_queue_enter() can be aborted right away. > + */ > + blk_mark_disk_dead(vblk->disk); > + > + /* Unfreeze the queue so that any waiting requests will be aborted. */ > + blk_mq_unfreeze_queue_nomemrestore(q); > +} > + > static void virtblk_remove(struct virtio_device *vdev) > { > struct virtio_blk *vblk = vdev->priv; > @@ -1561,6 +1654,8 @@ static void virtblk_remove(struct virtio_device *vdev) > /* Make sure no work handler is accessing the device. */ > flush_work(&vblk->config_work); > > + virtblk_broken_device_cleanup(vblk); > + > del_gendisk(vblk->disk); > blk_mq_free_tag_set(&vblk->tag_set); > > -- > 2.34.1

1 month, 2 weeks

2
8
0 0

FAILED: patch "[PATCH] drm/amdgpu: read back register after written for VCN v4.0.5" failed to apply to 6.12-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.12-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.12.y git checkout FETCH_HEAD git cherry-pick -x ee7360fc27d6045510f8fe459b5649b2af27811a # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2025052140-handsaw-train-2343@gregkh' --subject-prefix 'PATCH 6.12.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From ee7360fc27d6045510f8fe459b5649b2af27811a Mon Sep 17 00:00:00 2001 From: "David (Ming Qiang) Wu" <David.Wu3(a)amd.com> Date: Mon, 12 May 2025 15:14:43 -0400 Subject: [PATCH] drm/amdgpu: read back register after written for VCN v4.0.5 On VCN v4.0.5 there is a race condition where the WPTR is not updated after starting from idle when doorbell is used. Adding register read-back after written at function end is to ensure all register writes are done before they can be used. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12528 Signed-off-by: David (Ming Qiang) Wu <David.Wu3(a)amd.com> Reviewed-by: Mario Limonciello <mario.limonciello(a)amd.com> Tested-by: Mario Limonciello <mario.limonciello(a)amd.com> Reviewed-by: Alex Deucher <alexander.deucher(a)amd.com> Reviewed-by: Ruijing Dong <ruijing.dong(a)amd.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> (cherry picked from commit 07c9db090b86e5211188e1b351303fbc673378cf) Cc: stable(a)vger.kernel.org diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c index a1171e6152ed..f11df9c2ec13 100644 --- a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c @@ -1023,6 +1023,10 @@ static int vcn_v4_0_5_start_dpg_mode(struct amdgpu_vcn_inst *vinst, ring->doorbell_index << VCN_RB1_DB_CTRL__OFFSET__SHIFT | VCN_RB1_DB_CTRL__EN_MASK); + /* Keeping one read-back to ensure all register writes are done, otherwise + * it may introduce race conditions */ + RREG32_SOC15(VCN, inst_idx, regVCN_RB1_DB_CTRL); + return 0; } @@ -1205,6 +1209,10 @@ static int vcn_v4_0_5_start(struct amdgpu_vcn_inst *vinst) WREG32_SOC15(VCN, i, regVCN_RB_ENABLE, tmp); fw_shared->sq.queue_mode &= ~(FW_QUEUE_RING_RESET | FW_QUEUE_DPG_HOLD_OFF); + /* Keeping one read-back to ensure all register writes are done, otherwise + * it may introduce race conditions */ + RREG32_SOC15(VCN, i, regVCN_RB_ENABLE); + return 0; }

1 month, 2 weeks

1
0
0 0

FAILED: patch "[PATCH] drm/amdgpu: read back register after written for VCN v4.0.5" failed to apply to 6.14-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.14-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.14.y git checkout FETCH_HEAD git cherry-pick -x ee7360fc27d6045510f8fe459b5649b2af27811a # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2025052139-turkey-gumminess-1680@gregkh' --subject-prefix 'PATCH 6.14.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From ee7360fc27d6045510f8fe459b5649b2af27811a Mon Sep 17 00:00:00 2001 From: "David (Ming Qiang) Wu" <David.Wu3(a)amd.com> Date: Mon, 12 May 2025 15:14:43 -0400 Subject: [PATCH] drm/amdgpu: read back register after written for VCN v4.0.5 On VCN v4.0.5 there is a race condition where the WPTR is not updated after starting from idle when doorbell is used. Adding register read-back after written at function end is to ensure all register writes are done before they can be used. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12528 Signed-off-by: David (Ming Qiang) Wu <David.Wu3(a)amd.com> Reviewed-by: Mario Limonciello <mario.limonciello(a)amd.com> Tested-by: Mario Limonciello <mario.limonciello(a)amd.com> Reviewed-by: Alex Deucher <alexander.deucher(a)amd.com> Reviewed-by: Ruijing Dong <ruijing.dong(a)amd.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> (cherry picked from commit 07c9db090b86e5211188e1b351303fbc673378cf) Cc: stable(a)vger.kernel.org diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c index a1171e6152ed..f11df9c2ec13 100644 --- a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c @@ -1023,6 +1023,10 @@ static int vcn_v4_0_5_start_dpg_mode(struct amdgpu_vcn_inst *vinst, ring->doorbell_index << VCN_RB1_DB_CTRL__OFFSET__SHIFT | VCN_RB1_DB_CTRL__EN_MASK); + /* Keeping one read-back to ensure all register writes are done, otherwise + * it may introduce race conditions */ + RREG32_SOC15(VCN, inst_idx, regVCN_RB1_DB_CTRL); + return 0; } @@ -1205,6 +1209,10 @@ static int vcn_v4_0_5_start(struct amdgpu_vcn_inst *vinst) WREG32_SOC15(VCN, i, regVCN_RB_ENABLE, tmp); fw_shared->sq.queue_mode &= ~(FW_QUEUE_RING_RESET | FW_QUEUE_DPG_HOLD_OFF); + /* Keeping one read-back to ensure all register writes are done, otherwise + * it may introduce race conditions */ + RREG32_SOC15(VCN, i, regVCN_RB_ENABLE); + return 0; }

1 month, 2 weeks

1
0
0 0

FAILED: patch "[PATCH] drm/amd/display: Defer BW-optimization-blocked DRR" failed to apply to 6.1-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 6.1-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y git checkout FETCH_HEAD git cherry-pick -x 874697e127931bf50a37ce9d96ee80f3a08a0c38 # <resolve conflicts, build, test, etc.> git commit -s git send-email --to '<stable(a)vger.kernel.org>' --in-reply-to '2025051956-disdain-foyer-a53c@gregkh' --subject-prefix 'PATCH 6.1.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ From 874697e127931bf50a37ce9d96ee80f3a08a0c38 Mon Sep 17 00:00:00 2001 From: John Olender <john.olender(a)gmail.com> Date: Wed, 16 Apr 2025 02:54:26 -0400 Subject: [PATCH] drm/amd/display: Defer BW-optimization-blocked DRR adjustments [Why & How] Instead of dropping DRR updates, defer them. This fixes issues where monitor continues to see incorrect refresh rate after VRR was turned off by userspace. Fixes: 32953485c558 ("drm/amd/display: Do not update DRR while BW optimizations pending") Link: https://gitlab.freedesktop.org/drm/amd/-/issues/3546 Reviewed-by: Sun peng Li <sunpeng.li(a)amd.com> Signed-off-by: John Olender <john.olender(a)gmail.com> Signed-off-by: Aurabindo Pillai <aurabindo.pillai(a)amd.com> Signed-off-by: Ray Wu <ray.wu(a)amd.com> Tested-by: Daniel Wheeler <daniel.wheeler(a)amd.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> (cherry picked from commit 53761b7ecd83e6fbb9f2206f8c980a6aa308c844) Cc: stable(a)vger.kernel.org diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 1525c408d452..cc01b9c68b47 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -372,6 +372,8 @@ get_crtc_by_otg_inst(struct amdgpu_device *adev, static inline bool is_dc_timing_adjust_needed(struct dm_crtc_state *old_state, struct dm_crtc_state *new_state) { + if (new_state->stream->adjust.timing_adjust_pending) + return true; if (new_state->freesync_config.state == VRR_STATE_ACTIVE_FIXED) return true; else if (amdgpu_dm_crtc_vrr_active(old_state) != amdgpu_dm_crtc_vrr_active(new_state)) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c index 28d1353f403d..ba4ce8a63158 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c @@ -439,9 +439,12 @@ bool dc_stream_adjust_vmin_vmax(struct dc *dc, * Don't adjust DRR while there's bandwidth optimizations pending to * avoid conflicting with firmware updates. */ - if (dc->ctx->dce_version > DCE_VERSION_MAX) - if (dc->optimized_required || dc->wm_optimized_required) + if (dc->ctx->dce_version > DCE_VERSION_MAX) { + if (dc->optimized_required || dc->wm_optimized_required) { + stream->adjust.timing_adjust_pending = true; return false; + } + } dc_exit_ips_for_hw_access(dc); @@ -3168,7 +3171,8 @@ static void copy_stream_update_to_stream(struct dc *dc, if (update->crtc_timing_adjust) { if (stream->adjust.v_total_min != update->crtc_timing_adjust->v_total_min || - stream->adjust.v_total_max != update->crtc_timing_adjust->v_total_max) + stream->adjust.v_total_max != update->crtc_timing_adjust->v_total_max || + stream->adjust.timing_adjust_pending) update->crtc_timing_adjust->timing_adjust_pending = true; stream->adjust = *update->crtc_timing_adjust; update->crtc_timing_adjust->timing_adjust_pending = false;

1 month, 2 weeks

2
1
0 0

Random Crashes in Linux Kernel 6.1.139 on Intel Cascadelake/Icelake Due to ITS Mitigation

by Jinpu Wang

Hi Folks, Bug Description: When running Linux kernel version 6.1.139 on Intel Cascadelake/Icelake processors, systems experience random crashes related to mitigation. These crashes do not occur when booted with indirect_target_selection=off or when using kernel version 6.12.29. The crashes manifest as page faults leading to a kernel panic. System Details: Kernel Version: 6.1.139 or 6.1.118 with the ITS migration patches from 6.1.139 Hardware: Intel Cascadelake/Icelake Steps to Reproduce: Boot a system with Intel Cascadelake/Icelake processors using Linux kernel 6.1.139. Allow the system to run standard operations; crashes appear randomly. Notice that crashes do not occur when booted with indirect_target_selection=off. also works fine on Intel servers with Broadwell or Skylake CPU linux kernel 6.1.139 crash due to its mitigation on Intel Cascadelake/Icelake, the crash seems random, eg I've seen crashing like below: May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.207823] BUG: unable to handle page fault for address: ff1ac0d89d45f8c0 May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.212762] #PF: supervisor write access in kernel mode May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.217741] #PF: error_code(0x0003) - permissions violation May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.222708] PGD 5341c01067 P4D 5341c02067 PUD 211835063 PMD 21d44f063 PTE 800000021d45f161 May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.227831] Oops: 0003 [#1] PREEMPT SMP May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.233002] CPU: 12 PID: 0 Comm: swapper/12 Kdump: loaded Tainted: G O 6.1.139-pserver #6.1.139-1+feature+linux+6.1.y+20250521.1015+45a526cf~deb12 May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.244731] Hardware name: Dell Inc. PowerEdge R650/0PYXKY, BIOS 1.9.2 11/17/2022 May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.250583] RIP: 0010:__build_skb_around+0x79/0xc0 May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.256492] Code: 00 00 00 00 89 85 bc 00 00 00 66 89 95 b6 00 00 00 66 89 8d b2 00 00 00 65 8b 15 c2 5b 90 48 48 8d 34 03 66 89 95 a0 00 00 00 <48> c7 06 00 00 00 00 48 c7 46 08 00 00 00 00 48 c7 46 10 00 00 00 May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.269200] RSP: 0018:ff409de44cdf4d28 EFLAGS: 00010206 May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.275492] RAX: 00000000000006c0 RBX: ff1ac0d89d45f200 RCX: 00000000ffffffff May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.281987] RDX: 000000000000000c RSI: ff1ac0d89d45f8c0 RDI: ff1ac0d7886a8000 May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.288943] RBP: ff1ac0d7886a8000 R08: 0000000000000006 R09: ff1ac11708ffc0b8 May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.295838] R10: ffffffffb86060c0 R11: ff1ac0d8c02d7000 R12: ff1ac0d89d45f200 May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.302796] R13: ff1ac0d839a20000 R14: ff1ac0d89d1241d0 R15: 0000000000000000 May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.309496] FS: 0000000000000000(0000) GS:ff1ac116fef80000(0000) knlGS:0000000000000000 May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.315978] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.322411] CR2: ff1ac0d89d45f8c0 CR3: 000000534060a005 CR4: 0000000000771ee0 May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.329030] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.336289] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.343624] PKRU: 55555554 May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.350175] Call Trace: May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.356777] <IRQ> May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.363585] build_skb+0x41/0xe0 May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.370198] mlx5e_skb_from_cqe_nonlinear+0x20a/0x3b0 [mlx5_core] May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.377107] mlx5i_handle_rx_cqe+0x311/0x450 [mlx5_core] May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.384273] mlx5e_poll_rx_cq+0x437/0x450 [mlx5_core] May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.392409] mlx5e_napi_poll+0xe4/0x710 [mlx5_core] May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.399293] __napi_poll+0x28/0x160 May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.406107] net_rx_action+0x29c/0x2f0 May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.412790] handle_softirqs+0xcf/0x270 May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.419895] irq_exit_rcu+0x85/0xb0 May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.427245] common_interrupt+0x82/0xa0 May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.434181] </IRQ> May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.442032] <TASK> May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.448577] asm_common_interrupt+0x22/0x40 May 21 13:03:00 ps404a-62.stg.profitbricks.net >>> [ 241.455431] RIP: 0010:cpuidle_enter_state+0xd8/0x420 and below: kern.alert: May 21 05:59:31 ps404a-1 kernel: [ 35.775609] #PF: error_code(0x0003) - permissions violation kern.info: May 21 05:59:31 ps404a-1 kernel: [ 35.775740] PGD 251ac01067 P4D 251ac01067 PUD 1b17dd063 PMD 6098b1f063 PTE 8000000153faf161 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.775910] Oops: 0003 [#1] PREEMPT SMP kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.776036] CPU: 54 PID: 3109 Comm: (spawn) Tainted: G O 6.1.118-pserver #6.1.118-9+develop+20250520.1233+48c89f78~deb 12 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.776218] Hardware name: RAUSCH CoreVPS-Gen2-STG/X11DDW-NT, BIOS 3.3 02/21/2020 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.776382] RIP: 0010:__tlb_remove_page_size+0x64/0x90 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.776515] Code: c3 cc cc cc cc 83 7f 1c 13 74 39 31 f6 bf 00 28 00 00 e8 3f 27 01 00 48 85 c0 74 28 48 b9 00 00 00 00 fe 01 00 00 83 43 1c 01 <48> c7 00 00 00 00 00 48 89 48 08 48 8b 53 20 48 89 02 48 89 43 20 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.776746] RSP: 0018:ffffb15a5d563a70 EFLAGS: 00010202 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.776876] RAX: ffff8ad4d3faf000 RBX: ffffb15a5d563c88 RCX: 000001fe00000000 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.777013] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff8b3240b317c0 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.777149] RBP: 000055a0e8f5f000 R08: 0000000000000100 R09: 000055a0e9011fff kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.777285] R10: ffffb15a5d563a08 R11: 0000000000000025 R12: ffffeff344443300 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.777421] R13: ffffb15a5d563b90 R14: ffff8ad50c2faaf8 R15: 00000001110cc025 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.777557] FS: 0000000000000000(0000) GS:ffff8b3240b00000(0000) knlGS:0000000000000000 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.777724] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.777855] CR2: ffff8ad4d3faf000 CR3: 000000018c2f8002 CR4: 00000000007706e0 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.777991] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.778126] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.778262] PKRU: 55555554 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.778382] Call Trace: kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.778502] <TASK> kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.778621] ? __die_body.cold+0x1a/0x1f kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.778749] ? page_fault_oops+0x15a/0x2b0 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.778875] ? search_module_extables+0x15/0x60 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.779004] ? search_bpf_extables+0x5b/0x80 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.779150] ? exc_page_fault+0x8d/0x120 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.779277] ? asm_exc_page_fault+0x22/0x30 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.779536] unmap_page_range+0x8f0/0x1370 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.779667] unmap_vmas+0xea/0x180 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.779794] exit_mmap+0xcb/0x2e0 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.779919] __mmput+0x3d/0x110 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.780045] begin_new_exec+0x46f/0xaf0 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.780173] ? load_elf_phdrs+0x6c/0xc0 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.780312] load_elf_binary+0x2c2/0x1750 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.780438] ? __kernel_read+0x195/0x290 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.780564] bprm_execve+0x27f/0x650 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.780689] do_execveat_common.isra.0+0x1ad/0x220 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.780818] __x64_sys_execve+0x32/0x40 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.780944] do_syscall_64+0x34/0x80 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.781070] entry_SYSCALL_64_after_hwframe+0x6e/0xd8 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.781200] RIP: 0033:0x7f1d66e70ad7 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.781325] Code: Unable to access opcode bytes at 0x7f1d66e70aad. kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.789385] RSP: 002b:00007ffceeb31338 EFLAGS: 00000206 ORIG_RAX: 000000000000003b kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.789552] RAX: ffffffffffffffda RBX: 000055a11a55e4b0 RCX: 00007f1d66e70ad7 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.789688] RDX: 000055a11a50f200 RSI: 000055a11a6c2d60 RDI: 000055a11a5748c0 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.789825] RBP: 00007ffceeb31570 R08: 0000000000000007 R09: 000055a11a6b1fa0 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.789962] R10: 0000000000000000 R11: 0000000000000206 R12: 00007ffceeb35570 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.790098] R13: 000000000aba9500 R14: 00007ffceeb313b0 R15: 000055a11a6c2d60 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.790237] </TASK> kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.790367] Modules linked in: mei watchdog led_class pcc_cpufreq(-) dca acpi_pad button andbd_shared(O+) 8021q garp stp mrp llc dm_mod dax fuse ip_tables x_tables autofs4 loop raid10 raid456 async_raid6_recov async_memcpy async_pq async_xor async_tx xor raid6_pq libcrc32c raid1 raid0 linear md_mod mlx5_core i2c_i801 crc32c_intel xhci_pci mlxfw i2c_smbus i40e lpc_ich i2c_core mfd_core xhci_hcd kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.790742] CR2: ffff8ad4d3faf000 kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 35.790864] ---[ end trace 0000000000000000 ]--- kern.warning: May 21 05:59:31 ps404a-1 kernel: [ 36.457953] RIP: 0010:__tlb_remove_page_size+0x64/0x90 Any idea what went wrong and how to fix it? Thanks! Jinpu Wang

1 month, 2 weeks

1
0
0 0

[PATCH 0/2] usb: usbtmc: Fix read/get_stb and timeout in get_stb

by Dave Penkler

Patch 1: Fixes a regression introduced by a previous commit where the changed return value of usbtmc_get_stb caused usbtmc488_ioctl_read_stb and the USBTMC_IOCTL_GET_STB ioctl to fail. Patch 2: Fixes the units of the timeout value passed to wait_event_interruptible_timeout in usbtmc_get_stb. Dave Penkler (2): usb: usbtmc: Fix read_stb function and get_stb ioctl usb: usbtmc: Fix timeout value in get_stb drivers/usb/class/usbtmc.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) -- 2.49.0

1 month, 2 weeks

1
3
0 0

patch "iio: adc: ad7944: mask high bits on direct read" added to char-misc-next

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled iio: adc: ad7944: mask high bits on direct read to my char-misc git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git in the char-misc-next branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will also be merged in the next major kernel release during the merge window. If you have any questions about this process, please let me know. From 7cdfbc0113d087348b8e65dd79276d0f57b89a10 Mon Sep 17 00:00:00 2001 From: David Lechner <dlechner(a)baylibre.com> Date: Mon, 5 May 2025 13:28:40 -0500 Subject: iio: adc: ad7944: mask high bits on direct read MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Apply a mask to the raw value received over the SPI bus for unsigned direct reads. As we found recently, SPI controllers may not set unused bits to 0 when reading with bits_per_word != {8,16,32}. The ad7944 uses bits_per_word of 14 and 18, so we need to mask the value to be sure we returning the correct value to userspace during a direct read. Fixes: d1efcf8871db ("iio: adc: ad7944: add driver for AD7944/AD7985/AD7986") Signed-off-by: David Lechner <dlechner(a)baylibre.com> Reviewed-by: Nuno Sá <nuno.sa(a)analog.com> Link: https://patch.msgid.link/20250505-iio-adc-ad7944-max-high-bits-on-direct-re… Cc: <Stable(a)vger.kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron(a)huawei.com> --- drivers/iio/adc/ad7944.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iio/adc/ad7944.c b/drivers/iio/adc/ad7944.c index 2f949fe55873..37a137bd8357 100644 --- a/drivers/iio/adc/ad7944.c +++ b/drivers/iio/adc/ad7944.c @@ -377,6 +377,8 @@ static int ad7944_single_conversion(struct ad7944_adc *adc, if (chan->scan_type.sign == 's') *val = sign_extend32(*val, chan->scan_type.realbits - 1); + else + *val &= GENMASK(chan->scan_type.realbits - 1, 0); return IIO_VAL_INT; } -- 2.49.0

1 month, 2 weeks

1
0
0 0

patch "iio: imu: inv_icm42600: Fix temperature calculation" added to char-misc-next

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled iio: imu: inv_icm42600: Fix temperature calculation to my char-misc git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git in the char-misc-next branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will also be merged in the next major kernel release during the merge window. If you have any questions about this process, please let me know. From e2f820014239df9360064079ae93f838ff3b7f8c Mon Sep 17 00:00:00 2001 From: Sean Nyekjaer <sean(a)geanix.com> Date: Fri, 2 May 2025 11:37:26 +0200 Subject: iio: imu: inv_icm42600: Fix temperature calculation >From the documentation: "offset to be added to <type>[Y]_raw prior toscaling by <type>[Y]_scale" Offset should be applied before multiplying scale, so divide offset by scale to make this correct. Fixes: bc3eb0207fb5 ("iio: imu: inv_icm42600: add temperature sensor support") Signed-off-by: Sean Nyekjaer <sean(a)geanix.com> Acked-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol(a)tdk.com> Link: https://patch.msgid.link/20250502-imu-v1-1-129b8391a4e3@geanix.com Cc: <Stable(a)vger.kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron(a)huawei.com> --- drivers/iio/imu/inv_icm42600/inv_icm42600_temp.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_temp.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_temp.c index 213cce1c3111..91f0f381082b 100644 --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_temp.c +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_temp.c @@ -67,16 +67,18 @@ int inv_icm42600_temp_read_raw(struct iio_dev *indio_dev, return IIO_VAL_INT; /* * T°C = (temp / 132.48) + 25 - * Tm°C = 1000 * ((temp * 100 / 13248) + 25) + * Tm°C = 1000 * ((temp / 132.48) + 25) + * Tm°C = 7.548309 * temp + 25000 + * Tm°C = (temp + 3312) * 7.548309 * scale: 100000 / 13248 ~= 7.548309 - * offset: 25000 + * offset: 3312 */ case IIO_CHAN_INFO_SCALE: *val = 7; *val2 = 548309; return IIO_VAL_INT_PLUS_MICRO; case IIO_CHAN_INFO_OFFSET: - *val = 25000; + *val = 3312; return IIO_VAL_INT; default: return -EINVAL; -- 2.49.0

1 month, 2 weeks

1
0
0 0

patch "iio: adc: ad7606_spi: fix reg write value mask" added to char-misc-next

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled iio: adc: ad7606_spi: fix reg write value mask to my char-misc git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git in the char-misc-next branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will also be merged in the next major kernel release during the merge window. If you have any questions about this process, please let me know. From 89944d88f8795c6c89b9514cb365998145511cd4 Mon Sep 17 00:00:00 2001 From: David Lechner <dlechner(a)baylibre.com> Date: Mon, 28 Apr 2025 20:55:34 -0500 Subject: iio: adc: ad7606_spi: fix reg write value mask Fix incorrect value mask for register write. Register values are 8-bit, not 9. If this function was called with a value > 0xFF and an even addr, it would cause writing to the next register. Fixes: f2a22e1e172f ("iio: adc: ad7606: Add support for software mode for ad7616") Signed-off-by: David Lechner <dlechner(a)baylibre.com> Reviewed-by: Angelo Dureghello <adureghello(a)baylibre.com> Link: https://patch.msgid.link/20250428-iio-adc-ad7606_spi-fix-write-value-mask-v… Cc: <Stable(a)vger.kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron(a)huawei.com> --- drivers/iio/adc/ad7606_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/ad7606_spi.c b/drivers/iio/adc/ad7606_spi.c index 179115e90988..b37458ce3c70 100644 --- a/drivers/iio/adc/ad7606_spi.c +++ b/drivers/iio/adc/ad7606_spi.c @@ -155,7 +155,7 @@ static int ad7606_spi_reg_write(struct ad7606_state *st, struct spi_device *spi = to_spi_device(st->dev); st->d16[0] = cpu_to_be16((st->bops->rd_wr_cmd(addr, 1) << 8) | - (val & 0x1FF)); + (val & 0xFF)); return spi_write(spi, &st->d16[0], sizeof(st->d16[0])); } -- 2.49.0

1 month, 2 weeks

1
0
0 0

patch "iio: adc: ad7173: fix compiling without gpiolib" added to char-misc-next

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled iio: adc: ad7173: fix compiling without gpiolib to my char-misc git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git in the char-misc-next branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will also be merged in the next major kernel release during the merge window. If you have any questions about this process, please let me know. From c553aa1b03719400a30d9387477190d4743fc1de Mon Sep 17 00:00:00 2001 From: David Lechner <dlechner(a)baylibre.com> Date: Tue, 22 Apr 2025 15:12:27 -0500 Subject: iio: adc: ad7173: fix compiling without gpiolib Fix compiling the ad7173 driver when CONFIG_GPIOLIB is not set by selecting GPIOLIB to be always enabled and remove the #if. Commit 031bdc8aee01 ("iio: adc: ad7173: add calibration support") placed unrelated code in the middle of the #if IS_ENABLED(CONFIG_GPIOLIB) block which caused the reported compile error. However, later commit 7530ed2aaa3f ("iio: adc: ad7173: add openwire detection support for single conversions") makes use of the gpio regmap even when we aren't providing gpio controller support. So it makes more sense to always enable GPIOLIB rather than trying to make it optional. Reported-by: kernel test robot <lkp(a)intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202504220824.HVrTVov1-lkp@intel.com/ Fixes: 031bdc8aee01 ("iio: adc: ad7173: add calibration support") Signed-off-by: David Lechner <dlechner(a)baylibre.com> Link: https://patch.msgid.link/20250422-iio-adc-ad7173-fix-compile-without-gpioli… Cc: <Stable(a)vger.kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron(a)huawei.com> --- drivers/iio/adc/Kconfig | 5 +++-- drivers/iio/adc/ad7173.c | 15 +-------------- 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index 6529df1a498c..ba746754a816 100644 --- a/drivers/iio/adc/Kconfig +++ b/drivers/iio/adc/Kconfig @@ -129,8 +129,9 @@ config AD7173 tristate "Analog Devices AD7173 driver" depends on SPI_MASTER select AD_SIGMA_DELTA - select GPIO_REGMAP if GPIOLIB - select REGMAP_SPI if GPIOLIB + select GPIOLIB + select GPIO_REGMAP + select REGMAP_SPI help Say yes here to build support for Analog Devices AD7173 and similar ADC Currently supported models: diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c index 69de5886474c..b3e6bd2a55d7 100644 --- a/drivers/iio/adc/ad7173.c +++ b/drivers/iio/adc/ad7173.c @@ -230,10 +230,8 @@ struct ad7173_state { unsigned long long *config_cnts; struct clk *ext_clk; struct clk_hw int_clk_hw; -#if IS_ENABLED(CONFIG_GPIOLIB) struct regmap *reg_gpiocon_regmap; struct gpio_regmap *gpio_regmap; -#endif }; static unsigned int ad4115_sinc5_data_rates[] = { @@ -288,8 +286,6 @@ static const char *const ad7173_clk_sel[] = { "ext-clk", "xtal" }; -#if IS_ENABLED(CONFIG_GPIOLIB) - static const struct regmap_range ad7173_range_gpio[] = { regmap_reg_range(AD7173_REG_GPIO, AD7173_REG_GPIO), }; @@ -543,12 +539,6 @@ static int ad7173_gpio_init(struct ad7173_state *st) return 0; } -#else -static int ad7173_gpio_init(struct ad7173_state *st) -{ - return 0; -} -#endif /* CONFIG_GPIOLIB */ static struct ad7173_state *ad_sigma_delta_to_ad7173(struct ad_sigma_delta *sd) { @@ -1797,10 +1787,7 @@ static int ad7173_probe(struct spi_device *spi) if (ret) return ret; - if (IS_ENABLED(CONFIG_GPIOLIB)) - return ad7173_gpio_init(st); - - return 0; + return ad7173_gpio_init(st); } static const struct of_device_id ad7173_of_match[] = { -- 2.49.0

1 month, 2 weeks

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror