Linux-stable-mirror

linux-stable-mirror@lists.linaro.org

289 participants
124122 discussions

Start a nNew thread

Re: [PATCH] Coccinelle: Add dummy report mode to add_namespace.cocci

by Markus Elfring

> … when run trough I hope that a typo will be avoided for the final change description. Regards, Markus

5 years, 7 months

[PATCH 1/3] KVM: arm64: Save the host's PtrAuth keys in non-preemptible context

by Marc Zyngier

When using the PtrAuth feature in a guest, we need to save the host's keys before allowing the guest to program them. For that, we dump them in a per-CPU data structure (the so called host context). But both call sites that do this are in preemptible context, which may end up in disaster should the vcpu thread get preempted before reentering the guest. Instead, save the keys eagerly on each vcpu_load(). This has an increased overhead, but is at least safe. Cc: stable(a)vger.kernel.org Signed-off-by: Marc Zyngier <maz(a)kernel.org> --- arch/arm64/include/asm/kvm_emulate.h | 6 ------ arch/arm64/kvm/arm.c | 18 +++++++++++++++++- arch/arm64/kvm/handle_exit.c | 19 ++----------------- 3 files changed, 19 insertions(+), 24 deletions(-) diff --git a/arch/arm64/include/asm/kvm_emulate.h b/arch/arm64/include/asm/kvm_emulate.h index a30b4eec7cb4..977843e4d5fb 100644 --- a/arch/arm64/include/asm/kvm_emulate.h +++ b/arch/arm64/include/asm/kvm_emulate.h @@ -112,12 +112,6 @@ static inline void vcpu_ptrauth_disable(struct kvm_vcpu *vcpu) vcpu->arch.hcr_el2 &= ~(HCR_API | HCR_APK); } -static inline void vcpu_ptrauth_setup_lazy(struct kvm_vcpu *vcpu) -{ - if (vcpu_has_ptrauth(vcpu)) - vcpu_ptrauth_disable(vcpu); -} - static inline unsigned long vcpu_get_vsesr(struct kvm_vcpu *vcpu) { return vcpu->arch.vsesr_el2; diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c index d6988401c22a..152049c5055d 100644 --- a/arch/arm64/kvm/arm.c +++ b/arch/arm64/kvm/arm.c @@ -337,6 +337,12 @@ void kvm_arch_vcpu_unblocking(struct kvm_vcpu *vcpu) preempt_enable(); } +#define __ptrauth_save_key(regs, key) \ +({ \ + regs[key ## KEYLO_EL1] = read_sysreg_s(SYS_ ## key ## KEYLO_EL1); \ + regs[key ## KEYHI_EL1] = read_sysreg_s(SYS_ ## key ## KEYHI_EL1); \ +}) + void kvm_arch_vcpu_load(struct kvm_vcpu *vcpu, int cpu) { int *last_ran; @@ -370,7 +376,17 @@ void kvm_arch_vcpu_load(struct kvm_vcpu *vcpu, int cpu) else vcpu_set_wfx_traps(vcpu); - vcpu_ptrauth_setup_lazy(vcpu); + if (vcpu_has_ptrauth(vcpu)) { + struct kvm_cpu_context *ctxt = vcpu->arch.host_cpu_context; + + __ptrauth_save_key(ctxt->sys_regs, APIA); + __ptrauth_save_key(ctxt->sys_regs, APIB); + __ptrauth_save_key(ctxt->sys_regs, APDA); + __ptrauth_save_key(ctxt->sys_regs, APDB); + __ptrauth_save_key(ctxt->sys_regs, APGA); + + vcpu_ptrauth_disable(vcpu); + } } void kvm_arch_vcpu_put(struct kvm_vcpu *vcpu) diff --git a/arch/arm64/kvm/handle_exit.c b/arch/arm64/kvm/handle_exit.c index eb194696ef62..065251efa2e6 100644 --- a/arch/arm64/kvm/handle_exit.c +++ b/arch/arm64/kvm/handle_exit.c @@ -162,31 +162,16 @@ static int handle_sve(struct kvm_vcpu *vcpu, struct kvm_run *run) return 1; } -#define __ptrauth_save_key(regs, key) \ -({ \ - regs[key ## KEYLO_EL1] = read_sysreg_s(SYS_ ## key ## KEYLO_EL1); \ - regs[key ## KEYHI_EL1] = read_sysreg_s(SYS_ ## key ## KEYHI_EL1); \ -}) - /* * Handle the guest trying to use a ptrauth instruction, or trying to access a * ptrauth register. */ void kvm_arm_vcpu_ptrauth_trap(struct kvm_vcpu *vcpu) { - struct kvm_cpu_context *ctxt; - - if (vcpu_has_ptrauth(vcpu)) { + if (vcpu_has_ptrauth(vcpu)) vcpu_ptrauth_enable(vcpu); - ctxt = vcpu->arch.host_cpu_context; - __ptrauth_save_key(ctxt->sys_regs, APIA); - __ptrauth_save_key(ctxt->sys_regs, APIB); - __ptrauth_save_key(ctxt->sys_regs, APDA); - __ptrauth_save_key(ctxt->sys_regs, APDB); - __ptrauth_save_key(ctxt->sys_regs, APGA); - } else { + else kvm_inject_undefined(vcpu); - } } /* -- 2.26.2

5 years, 7 months

Patches to apply to stable releases [6/3/2020]

by Guenter Roeck

Hi, Please consider applying the following patches to the listed stable releases. The following patches were found to be missing in stable releases by the Chrome OS missing patch robot. The patches meet the following criteria. - The patch includes a Fixes: tag Note that the Fixes: tag does not always point to the correct upstream SHA. In that case the correct upstream SHA is listed below. - The patch referenced in the Fixes: tag has been applied to the listed stable release - The patch has not been applied to that stable release All patches have been applied to the listed stable releases and to at least one Chrome OS branch. Resulting images have been build- and runtime-tested (where applicable) on real hardware and with virtual hardware on kerneltests.org. Thanks, Guenter --- Upstream commit 0e0bf1ea1147 ("perf stat: Zero all the 'ena' and 'run' array slot stats for interval mode") upstream: ToT Fixes: 51fd2df1e882 ("perf stat: Fix interval output values") in linux-4.4.y: 7629c7ef5291 upstream: v4.5-rc4 Affected branches: linux-4.4.y linux-4.9.y linux-4.14.y linux-4.19.y linux-5.4.y linux-5.6.y Presumably also linux-5.7.y but not checked/tested Upstream commit b8018b973c7c ("scsi: scsi_devinfo: fixup string compare") upstream: v4.15-rc1 Fixes: 5e7ff2ca7f2d ("SCSI: fix new bug in scsi_dev_info_list string matching") in linux-4.4.y: c4c2a8f5b740 upstream: v4.7-rc7 Affected branches: linux-4.4.y linux-4.9.y linux-4.14.y Fixed by: ba69ead9e9e9 ("scsi: scsi_devinfo: handle non-terminated strings") [This patch needs to be applied as well] Upstream commit e87581fe0509 ("usb: gadget: f_uac2: fix error handling in afunc_bind (again)") upstream: v4.18-rc7 Fixes: f1d3861d63a5 ("usb: gadget: f_uac2: fix error handling at afunc_bind") in linux-4.4.y: c67c2ed829f3 in linux-4.9.y: 5180169dae85 upstream: v4.10-rc1 Affected branches: linux-4.4.y linux-4.9.y linux-4.14.y (already applied) Upstream commit f9ac89f5ad61 ("platform/x86: acer-wmi: setup accelerometer when ACPI device was found") upstream: v4.12-rc1 Fixes: 98d610c3739a ("platform/x86: acer-wmi: setup accelerometer when machine has appropriate notify event") in linux-4.4.y: ccf0904c49b1 in linux-4.9.y: 03470ba96a96 upstream: v4.11-rc1 Affected branches: linux-4.4.y linux-4.9.y (already applied) Upstream commit 7284fdf39a91 ("esp6: fix memleak on error path in esp6_input") upstream: v4.18-rc8 Fixes: 3f29770723fe ("ipsec: check return value of skb_to_sgvec always") in linux-4.4.y: d55d38496455 in linux-4.9.y: 753b04d213ec upstream: v4.13-rc1 Affected branches: linux-4.4.y linux-4.9.y linux-4.14.y (already applied) Upstream commit 3dc7c7badb75 ("IB/mlx4: Fix an error handling path in 'mlx4_ib_rereg_user_mr()'") upstream: v4.18-rc2 Fixes: d8f9cc328c88 ("IB/mlx4: Mark user MR as writable if actual virtual memory is writable") in linux-4.4.y: d803aa2fe665 in linux-4.9.y: e2ba7bf19727 in linux-4.14.y: 1c82abc1b26a upstream: v4.18-rc1 Affected branches: linux-4.4.y linux-4.9.y (already applied) linux-4.14.y (already applied) Upstream commit fa16b69f1299 ("ALSA: hda - No loopback on ALC299 codec") upstream: v4.12-rc3 Fixes: 28f1f9b26cee ("ALSA: hda/realtek - Add new codec ID ALC299") in linux-4.4.y: e2d12bdaed6b in linux-4.9.y: f6e94c2c16fe upstream: v4.11-rc1 Affected branches: linux-4.4.y linux-4.9.y (already applied) Upstream commit 86aa66687442 ("libnvdimm: Fix endian conversion issues ") upstream: v5.4-rc1 Fixes: 9dedc73a4658 ("libnvdimm/btt: Fix LBA masking during 'free list' population") in linux-4.14.y: bf87f274fe9f in linux-4.19.y: 4e160b91c776 upstream: v5.1-rc1 Affected branches: linux-4.14.y linux-4.19.y Upstream commit e2abfc0448a4 ("x86/cpu/amd: Make erratum #1054 a legacy erratum") upstream: ToT Fixes: 21b5ee59ef18 ("x86/cpu/amd: Enable the fixed Instructions Retired counter IRPERF") in linux-4.19.y: f28ec250579c in linux-5.4.y: e0253c422024 upstream: v5.6-rc3 Affected branches: linux-4.19.y linux-5.4.y linux-5.6.y Presumably also linux-5.7.y but not checked/tested

5 years, 7 months

Re: [PATCH 1/1] dvbdev: Fix tuner->demod media controller link

by Sean Young

On Thu, May 14, 2020 at 11:40:43AM -0500, Brad Love wrote: > Fixes bug exposed by: > > [a3fbc2e6bb0: media: mc-entity.c: use WARN_ON, validate link pads] This patch was merged for v5.8, but should have been merged for v5.7 as well. Please can it be merged into v5.7 stable. The upstream commit is 9f984cacf4f4d53fd8a3f44d7f13528b81c1f6a8. Thanks, Sean > > The dvbdev incorrectly requests a tuner sink pad to connect to a demux > sink pad. The media controller failure percolates back and the dvb device > creation fails. Fix this by requesting a tuner source pad. Instead of > forcing that pad to be index zero, check if a negative integer error > is returned. A note is added that first source pad found is chosen. > > Affected bridges cx231xx and em28xx printed the below warning[s] > when a variety of media controller dvb enabled devices were connected. > The warning returns an error causing all affected devices to fail DVB > device creation. > > > [ 253.138332] ------------[ cut here ]------------ > [ 253.138339] WARNING: CPU: 0 PID: 1550 at drivers/media/mc/mc-entity.c:669 media_create_pad_link+0x1e0/0x200 [mc] > [ 253.138339] Modules linked in: si2168 em28xx_dvb(+) em28xx si2157 lgdt3306a cx231xx_dvb dvb_core cx231xx_alsa cx25840 cx231xx tveeprom cx2341x i2c_mux videobuf2_vmalloc videobuf2_memops videobuf2_v4l2 videobuf2_common videodev mc ir_rc5_decoder rc_hauppauge mceusb rc_core eda > c_mce_amd kvm nls_iso8859_1 crct10dif_pclmul crc32_pclmul ghash_clmulni_intel aesni_intel crypto_simd cryptd glue_helper efi_pstore wmi_bmof k10temp asix usbnet mii nouveau snd_hda_codec_realtek snd_hda_codec_generic input_leds ledtrig_audio snd_hda_codec_hdmi mxm_wmi snd_hda_in > tel video snd_intel_dspcfg ttm snd_hda_codec drm_kms_helper snd_hda_core drm snd_hwdep snd_seq_midi snd_seq_midi_event i2c_algo_bit snd_pcm snd_rawmidi fb_sys_fops snd_seq syscopyarea sysfillrect snd_seq_device sysimgblt snd_timer snd soundcore ccp mac_hid sch_fq_codel parport_p > c ppdev lp parport ip_tables x_tables autofs4 vfio_pci irqbypass vfio_virqfd vfio_iommu_type1 vfio hid_generic usbhid hid i2c_piix4 ahci libahci wmi gpio_amdpt > [ 253.138370] gpio_generic > [ 253.138372] CPU: 0 PID: 1550 Comm: modprobe Tainted: G W 5.7.0-rc2+ #181 > [ 253.138373] Hardware name: MSI MS-7A39/B350M GAMING PRO (MS-7A39), BIOS 2.G0 04/27/2018 > [ 253.138376] RIP: 0010:media_create_pad_link+0x1e0/0x200 [mc] > [ 253.138378] Code: 26 fd ff ff 44 8b 4d d0 eb d9 0f 0b 41 b9 ea ff ff ff 44 89 c8 c3 0f 0b 41 b9 ea ff ff ff eb f2 0f 0b 41 b9 ea ff ff ff eb e8 <0f> 0b 41 b9 ea ff ff ff eb af 0f 0b 41 b9 ea ff ff ff eb a5 66 90 > [ 253.138379] RSP: 0018:ffffb9ecc0ee7a78 EFLAGS: 00010246 > [ 253.138380] RAX: ffff943f706c99d8 RBX: 0000000000000000 RCX: 0000000000000000 > [ 253.138381] RDX: ffff943f613e0180 RSI: 0000000000000000 RDI: ffff943f706c9958 > [ 253.138381] RBP: ffffb9ecc0ee7ab0 R08: 0000000000000001 R09: ffff943f613e0180 > [ 253.138382] R10: ffff943f613e0180 R11: ffff943f706c9400 R12: 0000000000000000 > [ 253.138383] R13: 0000000000000001 R14: ffff943f706c9958 R15: 0000000000000001 > [ 253.138384] FS: 00007f3cd29ba540(0000) GS:ffff943f8ec00000(0000) knlGS:0000000000000000 > [ 253.138385] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 253.138385] CR2: 000055f7de0ca830 CR3: 00000003dd208000 CR4: 00000000003406f0 > [ 253.138386] Call Trace: > [ 253.138392] media_create_pad_links+0x104/0x1b0 [mc] > [ 253.138397] dvb_create_media_graph+0x350/0x5f0 [dvb_core] > [ 253.138402] em28xx_dvb_init+0x5ea/0x2600 [em28xx_dvb] > [ 253.138408] em28xx_register_extension+0x63/0xc0 [em28xx] > [ 253.138410] ? 0xffffffffc039c000 > [ 253.138412] em28xx_dvb_register+0x15/0x1000 [em28xx_dvb] > [ 253.138416] do_one_initcall+0x71/0x250 > [ 253.138418] ? do_init_module+0x27/0x22e > [ 253.138421] ? _cond_resched+0x1a/0x50 > [ 253.138423] ? kmem_cache_alloc_trace+0x1ec/0x270 > [ 253.138425] ? __vunmap+0x1e3/0x240 > [ 253.138427] do_init_module+0x5f/0x22e > [ 253.138430] load_module+0x2525/0x2d40 > [ 253.138436] __do_sys_finit_module+0xe5/0x120 > [ 253.138438] ? __do_sys_finit_module+0xe5/0x120 > [ 253.138442] __x64_sys_finit_module+0x1a/0x20 > [ 253.138443] do_syscall_64+0x57/0x1b0 > [ 253.138445] entry_SYSCALL_64_after_hwframe+0x44/0xa9 > [ 253.138446] RIP: 0033:0x7f3cd24dc839 > [ 253.138448] Code: 00 f3 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 1f f6 2c 00 f7 d8 64 89 01 48 > [ 253.138449] RSP: 002b:00007ffe4fc514d8 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 > [ 253.138450] RAX: ffffffffffffffda RBX: 000055a9237f63f0 RCX: 00007f3cd24dc839 > [ 253.138451] RDX: 0000000000000000 RSI: 000055a922c3ad2e RDI: 0000000000000000 > [ 253.138451] RBP: 000055a922c3ad2e R08: 0000000000000000 R09: 0000000000000000 > [ 253.138452] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 > [ 253.138453] R13: 000055a9237f5550 R14: 0000000000040000 R15: 000055a9237f63f0 > [ 253.138456] ---[ end trace a60f19c54aa96ec4 ]--- > > > [ 234.915628] ------------[ cut here ]------------ > [ 234.915640] WARNING: CPU: 0 PID: 1502 at drivers/media/mc/mc-entity.c:669 media_create_pad_link+0x1e0/0x200 [mc] > [ 234.915641] Modules linked in: si2157 lgdt3306a cx231xx_dvb(+) dvb_core cx231xx_alsa cx25840 cx231xx tveeprom cx2341x i2c_mux videobuf2_vmalloc videobuf2_memops videobuf2_v4l2 videobuf2_common videodev mc ir_rc5_decoder rc_hauppauge mceusb rc_core edac_mce_amd kvm nls_iso8859 > _1 crct10dif_pclmul crc32_pclmul ghash_clmulni_intel aesni_intel crypto_simd cryptd glue_helper efi_pstore wmi_bmof k10temp asix usbnet mii nouveau snd_hda_codec_realtek snd_hda_codec_generic input_leds ledtrig_audio snd_hda_codec_hdmi mxm_wmi snd_hda_intel video snd_intel_dspcf > g ttm snd_hda_codec drm_kms_helper snd_hda_core drm snd_hwdep snd_seq_midi snd_seq_midi_event i2c_algo_bit snd_pcm snd_rawmidi fb_sys_fops snd_seq syscopyarea sysfillrect snd_seq_device sysimgblt snd_timer snd soundcore ccp mac_hid sch_fq_codel parport_pc ppdev lp parport ip_tab > les x_tables autofs4 vfio_pci irqbypass vfio_virqfd vfio_iommu_type1 vfio hid_generic usbhid hid i2c_piix4 ahci libahci wmi gpio_amdpt gpio_generic > [ 234.915700] CPU: 0 PID: 1502 Comm: modprobe Not tainted 5.7.0-rc2+ #181 > [ 234.915702] Hardware name: MSI MS-7A39/B350M GAMING PRO (MS-7A39), BIOS 2.G0 04/27/2018 > [ 234.915709] RIP: 0010:media_create_pad_link+0x1e0/0x200 [mc] > [ 234.915712] Code: 26 fd ff ff 44 8b 4d d0 eb d9 0f 0b 41 b9 ea ff ff ff 44 89 c8 c3 0f 0b 41 b9 ea ff ff ff eb f2 0f 0b 41 b9 ea ff ff ff eb e8 <0f> 0b 41 b9 ea ff ff ff eb af 0f 0b 41 b9 ea ff ff ff eb a5 66 90 > [ 234.915714] RSP: 0018:ffffb9ecc1b6fa50 EFLAGS: 00010246 > [ 234.915717] RAX: ffff943f8c94a9d8 RBX: 0000000000000000 RCX: 0000000000000000 > [ 234.915719] RDX: ffff943f613e0900 RSI: 0000000000000000 RDI: ffff943f8c94a958 > [ 234.915721] RBP: ffffb9ecc1b6fa88 R08: 0000000000000001 R09: ffff943f613e0900 > [ 234.915723] R10: ffff943f613e0900 R11: ffff943f6b590c00 R12: 0000000000000000 > [ 234.915724] R13: 0000000000000001 R14: ffff943f8c94a958 R15: 0000000000000001 > [ 234.915727] FS: 00007f4ca3646540(0000) GS:ffff943f8ec00000(0000) knlGS:0000000000000000 > [ 234.915729] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 234.915731] CR2: 00007fff7a53ba18 CR3: 00000003da614000 CR4: 00000000003406f0 > [ 234.915733] Call Trace: > [ 234.915745] media_create_pad_links+0x104/0x1b0 [mc] > [ 234.915756] dvb_create_media_graph+0x350/0x5f0 [dvb_core] > [ 234.915766] dvb_init.part.4+0x691/0x1360 [cx231xx_dvb] > [ 234.915780] dvb_init+0x1a/0x20 [cx231xx_dvb] > [ 234.915787] cx231xx_register_extension+0x71/0xa0 [cx231xx] > [ 234.915791] ? 0xffffffffc042f000 > [ 234.915796] cx231xx_dvb_register+0x15/0x1000 [cx231xx_dvb] > [ 234.915802] do_one_initcall+0x71/0x250 > [ 234.915807] ? do_init_module+0x27/0x22e > [ 234.915811] ? _cond_resched+0x1a/0x50 > [ 234.915816] ? kmem_cache_alloc_trace+0x1ec/0x270 > [ 234.915820] ? __vunmap+0x1e3/0x240 > [ 234.915826] do_init_module+0x5f/0x22e > [ 234.915831] load_module+0x2525/0x2d40 > [ 234.915848] __do_sys_finit_module+0xe5/0x120 > [ 234.915850] ? __do_sys_finit_module+0xe5/0x120 > [ 234.915862] __x64_sys_finit_module+0x1a/0x20 > [ 234.915865] do_syscall_64+0x57/0x1b0 > [ 234.915870] entry_SYSCALL_64_after_hwframe+0x44/0xa9 > [ 234.915872] RIP: 0033:0x7f4ca3168839 > [ 234.915876] Code: 00 f3 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 1f f6 2c 00 f7 d8 64 89 01 48 > [ 234.915878] RSP: 002b:00007ffcea3db3b8 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 > [ 234.915881] RAX: ffffffffffffffda RBX: 000055af22c29340 RCX: 00007f4ca3168839 > [ 234.915882] RDX: 0000000000000000 RSI: 000055af22c38390 RDI: 0000000000000001 > [ 234.915884] RBP: 000055af22c38390 R08: 0000000000000000 R09: 0000000000000000 > [ 234.915885] R10: 0000000000000001 R11: 0000000000000246 R12: 0000000000000000 > [ 234.915887] R13: 000055af22c29060 R14: 0000000000040000 R15: 0000000000000000 > [ 234.915896] ---[ end trace a60f19c54aa96ec3 ]--- > > > Signed-off-by: Brad Love <brad(a)nextdimension.cc> > --- > drivers/media/dvb-core/dvbdev.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c > index 80b6a71aa33e..1cd2dc7e4168 100644 > --- a/drivers/media/dvb-core/dvbdev.c > +++ b/drivers/media/dvb-core/dvbdev.c > @@ -707,9 +707,10 @@ int dvb_create_media_graph(struct dvb_adapter *adap, > } > > if (ntuner && ndemod) { > - pad_source = media_get_pad_index(tuner, true, > + /* NOTE: first found tuner source pad presumed correct */ > + pad_source = media_get_pad_index(tuner, false, > PAD_SIGNAL_ANALOG); > - if (pad_source) > + if (pad_source < 0) > return -EINVAL; > ret = media_create_pad_links(mdev, > MEDIA_ENT_F_TUNER, > -- > 2.23.0

5 years, 7 months

[PATCH v3] usb: host: xhci-mtk: avoid runtime suspend when removing hcd

by Macpaul Lin

When runtime suspend was enabled, runtime suspend might happened when xhci is removing hcd. This might cause kernel panic when hcd has been freed but runtime pm suspend related handle need to reference it. Signed-off-by: Macpaul Lin <macpaul.lin(a)mediatek.com> Reviewed-by: Chunfeng Yun <chunfeng.yun(a)mediatek.com> --- Changes for v3: - Replace better sequence for disabling the pm_runtime suspend. drivers/usb/host/xhci-mtk.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c index bfbdb3c..641d24e 100644 --- a/drivers/usb/host/xhci-mtk.c +++ b/drivers/usb/host/xhci-mtk.c @@ -587,6 +587,9 @@ static int xhci_mtk_remove(struct platform_device *dev) struct xhci_hcd *xhci = hcd_to_xhci(hcd); struct usb_hcd *shared_hcd = xhci->shared_hcd; + pm_runtime_put_noidle(&dev->dev); + pm_runtime_disable(&dev->dev); + usb_remove_hcd(shared_hcd); xhci->shared_hcd = NULL; device_init_wakeup(&dev->dev, false); @@ -597,8 +600,6 @@ static int xhci_mtk_remove(struct platform_device *dev) xhci_mtk_sch_exit(mtk); xhci_mtk_clks_disable(mtk); xhci_mtk_ldos_disable(mtk); - pm_runtime_put_sync(&dev->dev); - pm_runtime_disable(&dev->dev); return 0; } -- 1.7.9.5

5 years, 7 months

[PATCH] drm/tidss: fix modeset init for DPI panels

by Tomi Valkeinen

The connector type for DISPC's DPI videoport was set the LVDS instead of DPI. This causes any DPI panel setup to fail with tidss, making all DPI panels unusable. Fix this by using correct connector type. Signed-off-by: Tomi Valkeinen <tomi.valkeinen(a)ti.com> Fixes: 32a1795f57eecc39749017 ("drm/tidss: New driver for TI Keystone platform Display SubSystem") Cc: stable(a)vger.kernel.org # v5.7+ --- drivers/gpu/drm/tidss/tidss_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tidss/tidss_kms.c b/drivers/gpu/drm/tidss/tidss_kms.c index 7d419960b030..74467f6eafee 100644 --- a/drivers/gpu/drm/tidss/tidss_kms.c +++ b/drivers/gpu/drm/tidss/tidss_kms.c @@ -154,7 +154,7 @@ static int tidss_dispc_modeset_init(struct tidss_device *tidss) break; case DISPC_VP_DPI: enc_type = DRM_MODE_ENCODER_DPI; - conn_type = DRM_MODE_CONNECTOR_LVDS; + conn_type = DRM_MODE_CONNECTOR_DPI; break; default: WARN_ON(1); -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

5 years, 7 months

[PATCH] ovl: explicitly initialize error in ovl_copy_xattr()

by glider＠google.com

Under certain circumstances (we found this out running Docker on a Clang-built kernel with CONFIG_INIT_STACK_ALL) ovl_copy_xattr() may return uninitialized value of |error| from ovl_copy_xattr(). It is then returned by ovl_create() to lookup_open(), which casts it to an invalid dentry pointer, that can be further read or written by the lookup_open() callers. Signed-off-by: Alexander Potapenko <glider(a)google.com> Cc: Kees Cook <keescook(a)chromium.org> Cc: Roy Yang <royyang(a)google.com> Cc: <stable(a)vger.kernel.org> # 4.1 --- It's unclear to me whether error should be initially 0 or some error code (both seem to work), but I thought returning an error makes sense, as the situation wasn't anticipated by the code authors. The bug seem to date back to at least v4.1 where the annotation has been introduced (i.e. the compilers started noticing error could be used before being initialized). I hovever didn't try to prove that the problem is actually reproducible on such ancient kernels. We've seen it on a real machine running v4.4 as well. --- fs/overlayfs/copy_up.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c index 9709cf22cab3..428d43e2d016 100644 --- a/fs/overlayfs/copy_up.c +++ b/fs/overlayfs/copy_up.c @@ -47,7 +47,7 @@ int ovl_copy_xattr(struct dentry *old, struct dentry *new) { ssize_t list_size, size, value_size = 0; char *buf, *name, *value = NULL; - int uninitialized_var(error); + int error = -EINVAL; size_t slen; if (!(old->d_inode->i_opflags & IOP_XATTR) || -- 2.27.0.rc2.251.g90737beb825-goog

5 years, 7 months

[PATCH] net/mlx5: DR, Fix freeing in dr_create_rc_qp()

by Denis Efremov

Variable "in" in dr_create_rc_qp() is allocated with kvzalloc() and should be freed with kvfree(). Fixes: 297cccebdc5a ("net/mlx5: DR, Expose an internal API to issue RDMA operations") Cc: stable(a)vger.kernel.org Signed-off-by: Denis Efremov <efremov(a)linux.com> --- drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c index 18719acb7e54..eff8bb64899d 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c @@ -181,7 +181,7 @@ static struct mlx5dr_qp *dr_create_rc_qp(struct mlx5_core_dev *mdev, in, pas)); err = mlx5_core_create_qp(mdev, &dr_qp->mqp, in, inlen); - kfree(in); + kvfree(in); if (err) { mlx5_core_warn(mdev, " Can't create QP\n"); -- 2.26.2

5 years, 7 months

[PATCH] exfat: fix incorrect update of stream entry in __exfat_truncate()

by Namjae Jeon

At truncate, there is a problem of incorrect updating in the file entry pointer instead of stream entry. This will cause the problem of overwriting the time field of the file entry to new_size. Fix it to update stream entry. Fixes: 98d917047e8b ("exfat: add file operations") Cc: stable(a)vger.kernel.org # v5.7 Signed-off-by: Namjae Jeon <namjae.jeon(a)samsung.com> --- fs/exfat/file.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/exfat/file.c b/fs/exfat/file.c index 8e3f0eef45d7..fce03f318787 100644 --- a/fs/exfat/file.c +++ b/fs/exfat/file.c @@ -171,11 +171,11 @@ int __exfat_truncate(struct inode *inode, loff_t new_size) /* File size should be zero if there is no cluster allocated */ if (ei->start_clu == EXFAT_EOF_CLUSTER) { - ep->dentry.stream.valid_size = 0; - ep->dentry.stream.size = 0; + ep2->dentry.stream.valid_size = 0; + ep2->dentry.stream.size = 0; } else { - ep->dentry.stream.valid_size = cpu_to_le64(new_size); - ep->dentry.stream.size = ep->dentry.stream.valid_size; + ep2->dentry.stream.valid_size = cpu_to_le64(new_size); + ep2->dentry.stream.size = ep->dentry.stream.valid_size; } if (new_size == 0) { -- 2.17.1

5 years, 7 months

[patch 051/131] mm: call cond_resched() from deferred_init_memmap()

by Andrew Morton

From: Pavel Tatashin <pasha.tatashin(a)soleen.com> Subject: mm: call cond_resched() from deferred_init_memmap() Now that deferred pages are initialized with interrupts enabled we can replace touch_nmi_watchdog() with cond_resched(), as it was before 3a2d7fa8a3d5. For now, we cannot do the same in deferred_grow_zone() as it is still initializes pages with interrupts disabled. This change fixes RCU problem described in https://lkml.kernel.org/r/20200401104156.11564-2-david@redhat.com [ 60.474005] rcu: INFO: rcu_sched detected stalls on CPUs/tasks: [ 60.475000] rcu: 1-...0: (0 ticks this GP) idle=02a/1/0x4000000000000000 softirq=1/1 fqs=15000 [ 60.475000] rcu: (detected by 0, t=60002 jiffies, g=-1199, q=1) [ 60.475000] Sending NMI from CPU 0 to CPUs 1: [ 1.760091] NMI backtrace for cpu 1 [ 1.760091] CPU: 1 PID: 20 Comm: pgdatinit0 Not tainted 4.18.0-147.9.1.el8_1.x86_64 #1 [ 1.760091] Hardware name: Red Hat KVM, BIOS 1.13.0-1.module+el8.2.0+5520+4e5817f3 04/01/2014 [ 1.760091] RIP: 0010:__init_single_page.isra.65+0x10/0x4f [ 1.760091] Code: 48 83 cf 63 48 89 f8 0f 1f 40 00 48 89 c6 48 89 d7 e8 6b 18 80 ff 66 90 5b c3 31 c0 b9 10 00 00 00 49 89 f8 48 c1 e6 33 f3 ab <b8> 07 00 00 00 48 c1 e2 36 41 c7 40 34 01 00 00 00 48 c1 e0 33 41 [ 1.760091] RSP: 0000:ffffba783123be40 EFLAGS: 00000006 [ 1.760091] RAX: 0000000000000000 RBX: fffffad34405e300 RCX: 0000000000000000 [ 1.760091] RDX: 0000000000000000 RSI: 0010000000000000 RDI: fffffad34405e340 [ 1.760091] RBP: 0000000033f3177e R08: fffffad34405e300 R09: 0000000000000002 [ 1.760091] R10: 000000000000002b R11: ffff98afb691a500 R12: 0000000000000002 [ 1.760091] R13: 0000000000000000 R14: 000000003f03ea00 R15: 000000003e10178c [ 1.760091] FS: 0000000000000000(0000) GS:ffff9c9ebeb00000(0000) knlGS:0000000000000000 [ 1.760091] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 1.760091] CR2: 00000000ffffffff CR3: 000000a1cf20a001 CR4: 00000000003606e0 [ 1.760091] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 1.760091] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 1.760091] Call Trace: [ 1.760091] deferred_init_pages+0x8f/0xbf [ 1.760091] deferred_init_memmap+0x184/0x29d [ 1.760091] ? deferred_free_pages.isra.97+0xba/0xba [ 1.760091] kthread+0x112/0x130 [ 1.760091] ? kthread_flush_work_fn+0x10/0x10 [ 1.760091] ret_from_fork+0x35/0x40 [ 89.123011] node 0 initialised, 1055935372 pages in 88650ms Link: http://lkml.kernel.org/r/20200403140952.17177-4-pasha.tatashin@soleen.com Fixes: 3a2d7fa8a3d5 ("mm: disable interrupts while initializing deferred pages") Reported-by: Yiqian Wei <yiwei(a)redhat.com> Tested-by: David Hildenbrand <david(a)redhat.com> Signed-off-by: Pavel Tatashin <pasha.tatashin(a)soleen.com> Reviewed-by: Daniel Jordan <daniel.m.jordan(a)oracle.com> Acked-by: Michal Hocko <mhocko(a)suse.com> Reviewed-by: David Hildenbrand <david(a)redhat.com> Reviewed-by: Pankaj Gupta <pankaj.gupta.linux(a)gmail.com> Cc: Dan Williams <dan.j.williams(a)intel.com> Cc: James Morris <jmorris(a)namei.org> Cc: Kirill Tkhai <ktkhai(a)virtuozzo.com> Cc: Sasha Levin <sashal(a)kernel.org> Cc: Shile Zhang <shile.zhang(a)linux.alibaba.com> Cc: Vlastimil Babka <vbabka(a)suse.cz> Cc: <stable(a)vger.kernel.org> [4.17+] Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/page_alloc.c~mm-call-cond_resched-from-deferred_init_memmap +++ a/mm/page_alloc.c @@ -1870,7 +1870,7 @@ static int __init deferred_init_memmap(v */ while (spfn < epfn) { nr_pages += deferred_init_maxorder(&i, zone, &spfn, &epfn); - touch_nmi_watchdog(); + cond_resched(); } zone_empty: /* Sanity check that the next zone really is unpopulated */ _

5 years, 7 months

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror