- Linux-stable-mirror - lists.linaro.org

[PATCH] xen/netback: fix error path of xenvif_connect_data()

by Juergen Gross

xenvif_connect_data() calls module_put() in case of error. This is wrong as there is no related module_get(). Remove the superfluous module_put(). Fixes: 279f438e36c0a7 ("xen-netback: Don't destroy the netdev until the vif is shut down") Cc: <stable(a)vger.kernel.org> # 3.12 Signed-off-by: Juergen Gross <jgross(a)suse.com> Reviewed-by: Paul Durrant <paul(a)xen.org> --- drivers/net/xen-netback/interface.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c index 240f762b3749..103ed00775eb 100644 --- a/drivers/net/xen-netback/interface.c +++ b/drivers/net/xen-netback/interface.c @@ -719,7 +719,6 @@ int xenvif_connect_data(struct xenvif_queue *queue, xenvif_unmap_frontend_data_rings(queue); netif_napi_del(&queue->napi); err: - module_put(THIS_MODULE); return err; } -- 2.16.4

5 years, 8 months

3
2
0 0

[PATCH v2 11/11] net: wireless: ti: remove local VENDOR_ID and DEVICE_ID definitions

by H. Nikolaus Schaller

They are already included from mmc/sdio_ids.h and do not need a local definition. Fixes: 884f38607897 ("mmc: core: move some sdio IDs out of quirks file") Signed-off-by: H. Nikolaus Schaller <hns(a)goldelico.com> Acked-by: Kalle Valo <kvalo(a)codeaurora.org> Cc: <stable(a)vger.kernel.org> # 4.11.0 --- drivers/net/wireless/ti/wl1251/sdio.c | 8 -------- drivers/net/wireless/ti/wlcore/sdio.c | 8 -------- 2 files changed, 16 deletions(-) diff --git a/drivers/net/wireless/ti/wl1251/sdio.c b/drivers/net/wireless/ti/wl1251/sdio.c index 42b55f3a50df..3c4d5e38c66c 100644 --- a/drivers/net/wireless/ti/wl1251/sdio.c +++ b/drivers/net/wireless/ti/wl1251/sdio.c @@ -22,14 +22,6 @@ #include "wl1251.h" -#ifndef SDIO_VENDOR_ID_TI -#define SDIO_VENDOR_ID_TI 0x104c -#endif - -#ifndef SDIO_DEVICE_ID_TI_WL1251 -#define SDIO_DEVICE_ID_TI_WL1251 0x9066 -#endif - struct wl1251_sdio { struct sdio_func *func; u32 elp_val; diff --git a/drivers/net/wireless/ti/wlcore/sdio.c b/drivers/net/wireless/ti/wlcore/sdio.c index 7afaf35f2453..9fd8cf2d270c 100644 --- a/drivers/net/wireless/ti/wlcore/sdio.c +++ b/drivers/net/wireless/ti/wlcore/sdio.c @@ -26,14 +26,6 @@ #include "wl12xx_80211.h" #include "io.h" -#ifndef SDIO_VENDOR_ID_TI -#define SDIO_VENDOR_ID_TI 0x0097 -#endif - -#ifndef SDIO_DEVICE_ID_TI_WL1271 -#define SDIO_DEVICE_ID_TI_WL1271 0x4076 -#endif - static bool dump = false; struct wl12xx_sdio_glue { -- 2.19.1

5 years, 8 months

1
0
0 0

[PATCH v2 10/11] net: wireless: ti: wl1251 use new SDIO_VENDOR_ID_TI_WL1251 definition

by H. Nikolaus Schaller

SDIO_VENDOR_ID_TI_WL1251 is now defined in mmc/sdio_ids.h separately from SDIO_VENDOR_ID_TI for wl1271. Fixes: 884f38607897 ("mmc: core: move some sdio IDs out of quirks file") Signed-off-by: H. Nikolaus Schaller <hns(a)goldelico.com> Acked-by: Kalle Valo <kvalo(a)codeaurora.org> Cc: <stable(a)vger.kernel.org> # 4.11.0 --- drivers/net/wireless/ti/wl1251/sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ti/wl1251/sdio.c b/drivers/net/wireless/ti/wl1251/sdio.c index c54a273713ed..42b55f3a50df 100644 --- a/drivers/net/wireless/ti/wl1251/sdio.c +++ b/drivers/net/wireless/ti/wl1251/sdio.c @@ -52,7 +52,7 @@ static void wl1251_sdio_interrupt(struct sdio_func *func) } static const struct sdio_device_id wl1251_devices[] = { - { SDIO_DEVICE(SDIO_VENDOR_ID_TI, SDIO_DEVICE_ID_TI_WL1251) }, + { SDIO_DEVICE(SDIO_VENDOR_ID_TI_WL1251, SDIO_DEVICE_ID_TI_WL1251) }, {} }; MODULE_DEVICE_TABLE(sdio, wl1251_devices); -- 2.19.1

5 years, 8 months

1
0
0 0

[PATCH v2 09/11] mmc: core: fix wl1251 sdio quirks

by H. Nikolaus Schaller

wl1251 and wl1271 have different vendor id and device id. So we need to handle both with sdio quirks. Fixes: 884f38607897 ("mmc: core: move some sdio IDs out of quirks file") Signed-off-by: H. Nikolaus Schaller <hns(a)goldelico.com> Cc: <stable(a)vger.kernel.org> # 4.11.0 --- drivers/mmc/core/quirks.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h index 2d2d9ea8be4f..3dba15bccce2 100644 --- a/drivers/mmc/core/quirks.h +++ b/drivers/mmc/core/quirks.h @@ -119,7 +119,14 @@ static const struct mmc_fixup mmc_ext_csd_fixups[] = { END_FIXUP }; + static const struct mmc_fixup sdio_fixup_methods[] = { + SDIO_FIXUP(SDIO_VENDOR_ID_TI_WL1251, SDIO_DEVICE_ID_TI_WL1251, + add_quirk, MMC_QUIRK_NONSTD_FUNC_IF), + + SDIO_FIXUP(SDIO_VENDOR_ID_TI_WL1251, SDIO_DEVICE_ID_TI_WL1251, + add_quirk, MMC_QUIRK_DISABLE_CD), + SDIO_FIXUP(SDIO_VENDOR_ID_TI, SDIO_DEVICE_ID_TI_WL1271, add_quirk, MMC_QUIRK_NONSTD_FUNC_IF), -- 2.19.1

5 years, 8 months

1
0
0 0

[PATCH v2 08/11] mmc: sdio: fix wl1251 vendor id

by H. Nikolaus Schaller

v4.11-rc1 did introduce a patch series that rearranged the sdio quirks into a header file. Unfortunately this did forget to handle SDIO_VENDOR_ID_TI differently between wl1251 and wl1271 with the result that although the wl1251 was found on the sdio bus, the firmware did not load any more and there was no interface registration. This patch defines separate constants to be used by sdio quirks and drivers. Fixes: 884f38607897 ("mmc: core: move some sdio IDs out of quirks file") Signed-off-by: H. Nikolaus Schaller <hns(a)goldelico.com> Cc: <stable(a)vger.kernel.org> # 4.11.0 --- include/linux/mmc/sdio_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h index d1a5d5df02f5..08b25c02b5a1 100644 --- a/include/linux/mmc/sdio_ids.h +++ b/include/linux/mmc/sdio_ids.h @@ -71,6 +71,8 @@ #define SDIO_VENDOR_ID_TI 0x0097 #define SDIO_DEVICE_ID_TI_WL1271 0x4076 +#define SDIO_VENDOR_ID_TI_WL1251 0x104c +#define SDIO_DEVICE_ID_TI_WL1251 0x9066 #define SDIO_VENDOR_ID_STE 0x0020 #define SDIO_DEVICE_ID_STE_CW1200 0x2280 -- 2.19.1

5 years, 8 months

1
0
0 0

[PATCH v2 06/11] omap: pdata-quirks: remove openpandora quirks for mmc3 and wl1251

by H. Nikolaus Schaller

With a wl1251 child node of mmc3 in the device tree decoded in omap_hsmmc.c to handle special wl1251 initialization, we do no longer need to instantiate the mmc3 through pdata quirks. We also can remove the wlan regulator and reset/interrupt definitions and do them through device tree. Fixes: 81eef6ca9201 ("mmc: omap_hsmmc: Use dma_request_chan() for requesting DMA channel") Signed-off-by: H. Nikolaus Schaller <hns(a)goldelico.com> Cc: <stable(a)vger.kernel.org> # 4.7.0 --- arch/arm/mach-omap2/pdata-quirks.c | 93 ------------------------------ 1 file changed, 93 deletions(-) diff --git a/arch/arm/mach-omap2/pdata-quirks.c b/arch/arm/mach-omap2/pdata-quirks.c index 89734ef9ab1e..ecc1ef632951 100644 --- a/arch/arm/mach-omap2/pdata-quirks.c +++ b/arch/arm/mach-omap2/pdata-quirks.c @@ -303,108 +303,15 @@ static void __init omap3_logicpd_torpedo_init(void) } /* omap3pandora legacy devices */ -#define PANDORA_WIFI_IRQ_GPIO 21 -#define PANDORA_WIFI_NRESET_GPIO 23 static struct platform_device pandora_backlight = { .name = "pandora-backlight", .id = -1, }; -static struct regulator_consumer_supply pandora_vmmc3_supply[] = { - REGULATOR_SUPPLY("vmmc", "omap_hsmmc.2"), -}; - -static struct regulator_init_data pandora_vmmc3 = { - .constraints = { - .valid_ops_mask = REGULATOR_CHANGE_STATUS, - }, - .num_consumer_supplies = ARRAY_SIZE(pandora_vmmc3_supply), - .consumer_supplies = pandora_vmmc3_supply, -}; - -static struct fixed_voltage_config pandora_vwlan = { - .supply_name = "vwlan", - .microvolts = 1800000, /* 1.8V */ - .gpio = PANDORA_WIFI_NRESET_GPIO, - .startup_delay = 50000, /* 50ms */ - .enable_high = 1, - .init_data = &pandora_vmmc3, -}; - -static struct platform_device pandora_vwlan_device = { - .name = "reg-fixed-voltage", - .id = 1, - .dev = { - .platform_data = &pandora_vwlan, - }, -}; - -static void pandora_wl1251_init_card(struct mmc_card *card) -{ - /* - * We have TI wl1251 attached to MMC3. Pass this information to - * SDIO core because it can't be probed by normal methods. - */ - if (card->type == MMC_TYPE_SDIO || card->type == MMC_TYPE_SD_COMBO) { - card->quirks |= MMC_QUIRK_NONSTD_SDIO; - card->cccr.wide_bus = 1; - card->cis.vendor = 0x104c; - card->cis.device = 0x9066; - card->cis.blksize = 512; - card->cis.max_dtr = 24000000; - card->ocr = 0x80; - } -} - -static struct omap2_hsmmc_info pandora_mmc3[] = { - { - .mmc = 3, - .caps = MMC_CAP_4_BIT_DATA | MMC_CAP_POWER_OFF_CARD, - .gpio_cd = -EINVAL, - .gpio_wp = -EINVAL, - .init_card = pandora_wl1251_init_card, - }, - {} /* Terminator */ -}; - -static void __init pandora_wl1251_init(void) -{ - struct wl1251_platform_data pandora_wl1251_pdata; - int ret; - - memset(&pandora_wl1251_pdata, 0, sizeof(pandora_wl1251_pdata)); - - pandora_wl1251_pdata.power_gpio = -1; - - ret = gpio_request_one(PANDORA_WIFI_IRQ_GPIO, GPIOF_IN, "wl1251 irq"); - if (ret < 0) - goto fail; - - pandora_wl1251_pdata.irq = gpio_to_irq(PANDORA_WIFI_IRQ_GPIO); - if (pandora_wl1251_pdata.irq < 0) - goto fail_irq; - - pandora_wl1251_pdata.use_eeprom = true; - ret = wl1251_set_platform_data(&pandora_wl1251_pdata); - if (ret < 0) - goto fail_irq; - - return; - -fail_irq: - gpio_free(PANDORA_WIFI_IRQ_GPIO); -fail: - pr_err("wl1251 board initialisation failed\n"); -} - static void __init omap3_pandora_legacy_init(void) { platform_device_register(&pandora_backlight); - platform_device_register(&pandora_vwlan_device); - omap_hsmmc_init(pandora_mmc3); - omap_hsmmc_late_init(pandora_mmc3); - pandora_wl1251_init(); } #endif /* CONFIG_ARCH_OMAP3 */ -- 2.19.1

5 years, 8 months

1
0
0 0

❌ FAIL: Test report for kernel 5.4.0-rc3-404590a.cki (stable-next)

by CKI Project

Hello, We ran automated tests on a recent commit from this kernel tree: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git Commit: 404590aa1984 - scsi: core: try to get module before removing device The results of these automated tests are provided below. Overall result: FAILED (see details below) Merge: OK Compile: OK Tests: FAILED All kernel binaries, config files, and logs are available for download here: https://artifacts.cki-project.org/pipelines/235237 One or more kernel tests failed: ppc64le: ❌ Boot test ❌ Boot test aarch64: ❌ Boot test ❌ Boot test x86_64: ❌ Boot test ❌ Boot test ❌ Boot test ❌ Boot test ❌ Boot test We hope that these logs can help you find the problem quickly. For the full detail on our testing procedures, please scroll to the bottom of this message. Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Compile testing --------------- We compiled the kernel for 3 architectures: aarch64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg ppc64le: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg x86_64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: Host 1: ❌ Boot test ⚡⚡⚡ Podman system integration test (as root) ⚡⚡⚡ Podman system integration test (as user) ⚡⚡⚡ LTP lite ⚡⚡⚡ Loopdev Sanity ⚡⚡⚡ jvm test suite ⚡⚡⚡ Memory function: memfd_create ⚡⚡⚡ Memory function: kaslr ⚡⚡⚡ AMTU (Abstract Machine Test Utility) ⚡⚡⚡ LTP: openposix test suite ⚡⚡⚡ Ethernet drivers sanity ⚡⚡⚡ Networking MACsec: sanity ⚡⚡⚡ Networking socket: fuzz ⚡⚡⚡ Networking sctp-auth: sockopts test ⚡⚡⚡ Networking: igmp conformance test ⚡⚡⚡ Networking TCP: keepalive test ⚡⚡⚡ Networking UDP: socket ⚡⚡⚡ Networking tunnel: gre basic ⚡⚡⚡ L2TP basic test ⚡⚡⚡ Networking tunnel: vxlan basic ⚡⚡⚡ audit: audit testsuite test ⚡⚡⚡ httpd: mod_ssl smoke sanity ⚡⚡⚡ iotop: sanity ⚡⚡⚡ tuned: tune-processes-through-perf ⚡⚡⚡ ALSA PCM loopback test ⚡⚡⚡ ALSA Control (mixer) Userspace Element test ⚡⚡⚡ Usex - version 1.9-29 ⚡⚡⚡ storage: SCSI VPD ⚡⚡⚡ stress: stress-ng ⚡⚡⚡ trace: ftrace/tracer 🚧 ⚡⚡⚡ CIFS Connectathon 🚧 ⚡⚡⚡ POSIX pjd-fstest suites 🚧 ⚡⚡⚡ Networking bridge: sanity 🚧 ⚡⚡⚡ Networking route: pmtu 🚧 ⚡⚡⚡ Networking tunnel: geneve basic test 🚧 ⚡⚡⚡ Networking vnic: ipvlan/basic 🚧 ⚡⚡⚡ storage: dm/common 🚧 ⚡⚡⚡ Networking route_func: local 🚧 ⚡⚡⚡ Networking route_func: forward 🚧 ⚡⚡⚡ Networking ipsec: basic netns transport 🚧 ⚡⚡⚡ Networking ipsec: basic netns tunnel Host 2: ❌ Boot test ⚡⚡⚡ xfstests: ext4 ⚡⚡⚡ xfstests: xfs ⚡⚡⚡ selinux-policy: serge-testsuite ⚡⚡⚡ lvm thinp sanity ⚡⚡⚡ storage: software RAID testing 🚧 ⚡⚡⚡ Storage blktests ppc64le: Host 1: ❌ Boot test ⚡⚡⚡ Podman system integration test (as root) ⚡⚡⚡ Podman system integration test (as user) ⚡⚡⚡ LTP lite ⚡⚡⚡ Loopdev Sanity ⚡⚡⚡ jvm test suite ⚡⚡⚡ Memory function: memfd_create ⚡⚡⚡ Memory function: kaslr ⚡⚡⚡ AMTU (Abstract Machine Test Utility) ⚡⚡⚡ LTP: openposix test suite ⚡⚡⚡ Ethernet drivers sanity ⚡⚡⚡ Networking MACsec: sanity ⚡⚡⚡ Networking socket: fuzz ⚡⚡⚡ Networking sctp-auth: sockopts test ⚡⚡⚡ Networking TCP: keepalive test ⚡⚡⚡ Networking UDP: socket ⚡⚡⚡ Networking tunnel: gre basic ⚡⚡⚡ L2TP basic test ⚡⚡⚡ Networking tunnel: vxlan basic ⚡⚡⚡ audit: audit testsuite test ⚡⚡⚡ httpd: mod_ssl smoke sanity ⚡⚡⚡ iotop: sanity ⚡⚡⚡ tuned: tune-processes-through-perf ⚡⚡⚡ ALSA PCM loopback test ⚡⚡⚡ ALSA Control (mixer) Userspace Element test ⚡⚡⚡ Usex - version 1.9-29 ⚡⚡⚡ trace: ftrace/tracer 🚧 ⚡⚡⚡ CIFS Connectathon 🚧 ⚡⚡⚡ POSIX pjd-fstest suites 🚧 ⚡⚡⚡ Networking bridge: sanity 🚧 ⚡⚡⚡ Networking route: pmtu 🚧 ⚡⚡⚡ Networking tunnel: geneve basic test 🚧 ⚡⚡⚡ Networking ipsec: basic netns tunnel 🚧 ⚡⚡⚡ Networking vnic: ipvlan/basic 🚧 ⚡⚡⚡ storage: dm/common 🚧 ⚡⚡⚡ Networking route_func: local 🚧 ⚡⚡⚡ Networking route_func: forward Host 2: ❌ Boot test ⚡⚡⚡ xfstests: ext4 ⚡⚡⚡ xfstests: xfs ⚡⚡⚡ selinux-policy: serge-testsuite ⚡⚡⚡ lvm thinp sanity ⚡⚡⚡ storage: software RAID testing 🚧 ⚡⚡⚡ Storage blktests x86_64: Host 1: ❌ Boot test ⚡⚡⚡ xfstests: ext4 ⚡⚡⚡ xfstests: xfs ⚡⚡⚡ selinux-policy: serge-testsuite ⚡⚡⚡ lvm thinp sanity ⚡⚡⚡ storage: software RAID testing 🚧 ⚡⚡⚡ IOMMU boot test 🚧 ⚡⚡⚡ Storage blktests Host 2: ❌ Boot test ⚡⚡⚡ Podman system integration test (as root) ⚡⚡⚡ Podman system integration test (as user) ⚡⚡⚡ LTP lite ⚡⚡⚡ Loopdev Sanity ⚡⚡⚡ jvm test suite ⚡⚡⚡ Memory function: memfd_create ⚡⚡⚡ Memory function: kaslr ⚡⚡⚡ AMTU (Abstract Machine Test Utility) ⚡⚡⚡ LTP: openposix test suite ⚡⚡⚡ Ethernet drivers sanity ⚡⚡⚡ Networking MACsec: sanity ⚡⚡⚡ Networking socket: fuzz ⚡⚡⚡ Networking sctp-auth: sockopts test ⚡⚡⚡ Networking: igmp conformance test ⚡⚡⚡ Networking TCP: keepalive test ⚡⚡⚡ Networking UDP: socket ⚡⚡⚡ Networking tunnel: gre basic ⚡⚡⚡ L2TP basic test ⚡⚡⚡ Networking tunnel: vxlan basic ⚡⚡⚡ audit: audit testsuite test ⚡⚡⚡ httpd: mod_ssl smoke sanity ⚡⚡⚡ iotop: sanity ⚡⚡⚡ tuned: tune-processes-through-perf ⚡⚡⚡ pciutils: sanity smoke test ⚡⚡⚡ ALSA PCM loopback test ⚡⚡⚡ ALSA Control (mixer) Userspace Element test ⚡⚡⚡ Usex - version 1.9-29 ⚡⚡⚡ storage: SCSI VPD ⚡⚡⚡ stress: stress-ng ⚡⚡⚡ trace: ftrace/tracer 🚧 ⚡⚡⚡ CIFS Connectathon 🚧 ⚡⚡⚡ POSIX pjd-fstest suites 🚧 ⚡⚡⚡ Networking bridge: sanity 🚧 ⚡⚡⚡ Networking route: pmtu 🚧 ⚡⚡⚡ Networking tunnel: geneve basic test 🚧 ⚡⚡⚡ Networking vnic: ipvlan/basic 🚧 ⚡⚡⚡ storage: dm/common 🚧 ⚡⚡⚡ Networking route_func: local 🚧 ⚡⚡⚡ Networking route_func: forward 🚧 ⚡⚡⚡ Networking ipsec: basic netns transport 🚧 ⚡⚡⚡ Networking ipsec: basic netns tunnel Host 3: ❌ Boot test ⚡⚡⚡ Storage SAN device stress - megaraid_sas Host 4: ❌ Boot test 🚧 ⚡⚡⚡ IPMI driver test 🚧 ⚡⚡⚡ IPMItool loop stress test Host 5: ❌ Boot test ⚡⚡⚡ Storage SAN device stress - mpt3sas driver Test sources: https://github.com/CKI-project/tests-beaker 💚 Pull requests are welcome for new tests or improvements to existing tests! Waived tests ------------ If the test run included waived tests, they are marked with 🚧. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed. Testing timeout --------------- We aim to provide a report within reasonable timeframe. Tests that haven't finished running are marked with ⏱. Reports for non-upstream kernels have a Beaker recipe linked to next to each host.

5 years, 8 months

1
0
0 0

Re: [PATCH 5/9] omap: pdata-quirks: remove openpandora quirks for mmc3 and wl1251

by Tony Lindgren

* H. Nikolaus Schaller <hns(a)goldelico.com> [191019 15:18]: > > > Am 19.10.2019 um 15:36 schrieb Sasha Levin <sashal(a)kernel.org>: > > > > Hi, > > > > [This is an automated email] > > > > This commit has been processed because it contains a "Fixes:" tag, > > fixing commit: 81eef6ca92014 mmc: omap_hsmmc: Use dma_request_chan() for requesting DMA channel. > > > > The bot has tested the following trees: v5.3.6, v4.19.79, v4.14.149, v4.9.196. > > > > v5.3.6: Build OK! > > v4.19.79: Failed to apply! Possible dependencies: > > Unable to calculate > > > > v4.14.149: Failed to apply! Possible dependencies: > > 0486738928bf0 ("ARM: OMAP1: ams-delta: add GPIO lookup tables") > > 0920ca103f8d8 ("ARM: sa1100: provide infrastructure to support generic CF sockets") > > 29786e9b6551b ("ARM: sa1100/assabet: convert to generic CF sockets") > > 2bcb1be092370 ("Input: ams_delta_serio: Replace power GPIO with regulator") > > 56de7570b3264 ("Input: ams_delta_serio: use private structure") > > 7be893aa2d6a1 ("pcmcia: sa1100: provide generic CF support") > > b51af86559d4b ("ARM: sa1100/shannon: convert to generic CF sockets") > > b955153bfa68d ("ARM: sa1100/assabet: add BCR/BSR GPIO driver") > > c2f9b05fd5c12 ("media: arch: sh: ecovec: Use new renesas-ceu camera driver") > > df88c57689278 ("Input: ams_delta_serio: convert to platform driver") > > efdfeb079cc3b ("regulator: fixed: Convert to use GPIO descriptor only") > > ^^^ this is the relevant one. > > > > > v4.9.196: Failed to apply! Possible dependencies: > > 0486738928bf0 ("ARM: OMAP1: ams-delta: add GPIO lookup tables") > > 072f58af1dfbc ("ARM: dts: Add devicetree for the Raspberry Pi 3, for arm32 (v6)") > > 1aa1d858f582c ("ARM: dts: bcm283x: Add dtsi for OTG mode") > > 29786e9b6551b ("ARM: sa1100/assabet: convert to generic CF sockets") > > 2bcb1be092370 ("Input: ams_delta_serio: Replace power GPIO with regulator") > > 3bfe25fa9f8a5 ("ARM: dts: bcm283x: Move the BCM2837 DT contents from arm64 to arm.") > > 56de7570b3264 ("Input: ams_delta_serio: use private structure") > > 6c1b417adc8fa ("ARM: pxa: ezx: use the new pxa_camera platform_data") > > 7ade445c26269 ("ARM: pxa: magician: Add support for ADS7846 touchscreen") > > 8f9bafbb92c03 ("ARM: dts: aspeed: Add Romulus BMC platform") > > b24413180f560 ("License cleanup: add SPDX GPL-2.0 license identifier to files with no license") > > b5478c1b67bcd ("alpha: add asm/extable.h") > > b955153bfa68d ("ARM: sa1100/assabet: add BCR/BSR GPIO driver") > > d9fa04725f27f ("ARM: pxa: em-x270: use the new pxa_camera platform_data") > > df88c57689278 ("Input: ams_delta_serio: convert to platform driver") > > efdfeb079cc3b ("regulator: fixed: Convert to use GPIO descriptor only") > > fe7bf9dcfff5b ("ARM: dts: add a devicetree for Raidsonic NAS IB-4220-B") > > > > > > NOTE: The patch will not be queued to stable trees until it is upstream. > > > > How should we proceed with this patch? > > I have checked and the reason is that > > efdfeb079cc3b ("regulator: fixed: Convert to use GPIO descriptor only") > > was introduced after v.4.19 which was also partially reverted by this patch > if based on mainline. > > I have split it up into the partial revert of efdfeb079cc3b for mainline > and the real patch which now applies to all relevant stable trees. > > So I'll sent a v2 asap. Please also remove arch/arm/mach-omap2/hsmmc.[ch] as I think that can be now done :) Regards, Tony

5 years, 8 months

1
0
0 0

✅ PASS: Stable queue: queue-5.3

by CKI Project

Hello, We ran automated tests on a patchset that was proposed for merging into this kernel tree. The patches were applied to: Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 365dab61f74e - Linux 5.3.7 The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK All kernel binaries, config files, and logs are available for download here: https://artifacts.cki-project.org/pipelines/234049 Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Merge testing ------------- We cloned this repository and checked out the following commit: Repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 365dab61f74e - Linux 5.3.7 We grabbed the 8790a8b4e158 commit of the stable queue repository. We then merged the patchset with `git am`: drm-free-the-writeback_job-when-it-with-an-empty-fb.patch drm-clear-the-fence-pointer-when-writeback-job-signa.patch clk-ti-dra7-fix-mcasp8-clock-bits.patch arm-dts-fix-wrong-clocks-for-dra7-mcasp.patch nvme-pci-fix-a-race-in-controller-removal.patch scsi-ufs-skip-shutdown-if-hba-is-not-powered.patch scsi-megaraid-disable-device-when-probe-failed-after.patch scsi-qla2xxx-silence-fwdump-template-message.patch scsi-qla2xxx-fix-unbound-sleep-in-fcport-delete-path.patch scsi-qla2xxx-fix-stale-mem-access-on-driver-unload.patch scsi-qla2xxx-fix-n2n-link-reset.patch scsi-qla2xxx-fix-n2n-link-up-fail.patch arm-dts-fix-gpio0-flags-for-am335x-icev2.patch arm-omap2-fix-missing-reset-done-flag-for-am3-and-am.patch arm-omap2-add-missing-lcdc-midlemode-for-am335x.patch arm-omap2-fix-warnings-with-broken-omap2_set_init_vo.patch nvme-tcp-fix-wrong-stop-condition-in-io_work.patch nvme-pci-save-pci-state-before-putting-drive-into-de.patch nvme-fix-an-error-code-in-nvme_init_subsystem.patch nvme-rdma-fix-max_hw_sectors-calculation.patch added-quirks-for-adata-xpg-sx8200-pro-512gb.patch nvme-add-quirk-for-kingston-nvme-ssd-running-fw-e8fk.patch nvme-allow-64-bit-results-in-passthru-commands.patch drm-komeda-prevent-memory-leak-in-komeda_wb_connecto.patch nvme-rdma-fix-possible-use-after-free-in-connect-tim.patch blk-mq-honor-io-scheduler-for-multiqueue-devices.patch ieee802154-ca8210-prevent-memory-leak.patch arm-dts-am4372-set-memory-bandwidth-limit-for-dispc.patch net-dsa-qca8k-use-up-to-7-ports-for-all-operations.patch mips-dts-ar9331-fix-interrupt-controller-size.patch xen-efi-set-nonblocking-callbacks.patch loop-change-queue-block-size-to-match-when-using-dio.patch nl80211-fix-null-pointer-dereference.patch mac80211-fix-txq-null-pointer-dereference.patch netfilter-nft_connlimit-disable-bh-on-garbage-collec.patch net-mscc-ocelot-add-missing-of_node_put-after-callin.patch net-dsa-rtl8366rb-add-missing-of_node_put-after-call.patch net-stmmac-xgmac-not-all-unicast-addresses-may-be-av.patch net-stmmac-dwmac4-always-update-the-mac-hash-filter.patch net-stmmac-correctly-take-timestamp-for-ptpv2.patch net-stmmac-do-not-stop-phy-if-wol-is-enabled.patch net-ag71xx-fix-mdio-subnode-support.patch risc-v-clear-load-reservations-while-restoring-hart-.patch riscv-fix-memblock-reservation-for-device-tree-blob.patch drm-amdgpu-fix-multiple-memory-leaks-in-acp_hw_init.patch drm-amd-display-memory-leak.patch mips-loongson-fix-the-link-time-qualifier-of-serial_.patch net-hisilicon-fix-usage-of-uninitialized-variable-in.patch net-stmmac-avoid-deadlock-on-suspend-resume.patch selftests-kvm-fix-libkvm-build-error.patch lib-textsearch-fix-escapes-in-example-code.patch s390-mm-fix-wunused-but-set-variable-warnings.patch r8152-set-macpassthru-in-reset_resume-callback.patch net-phy-allow-for-reset-line-to-be-tied-to-a-sleepy-.patch net-phy-fix-write-to-mii-ctrl1000-register.patch namespace-fix-namespace.pl-script-to-support-relativ.patch convert-filldir-64-from-__put_user-to-unsafe_put_use.patch elf-don-t-use-map_fixed_noreplace-for-elf-executable.patch Compile testing --------------- We compiled the kernel for 3 architectures: aarch64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg ppc64le: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg x86_64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: Host 1: ✅ Boot test ✅ xfstests: xfs ✅ selinux-policy: serge-testsuite ✅ lvm thinp sanity ✅ storage: software RAID testing 🚧 ✅ Storage blktests Host 2: ✅ Boot test ✅ Podman system integration test (as root) ✅ Podman system integration test (as user) ✅ LTP lite ✅ Loopdev Sanity ✅ jvm test suite ✅ AMTU (Abstract Machine Test Utility) ✅ LTP: openposix test suite ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ audit: audit testsuite test ✅ httpd: mod_ssl smoke sanity ✅ iotop: sanity ✅ tuned: tune-processes-through-perf ✅ Usex - version 1.9-29 ✅ storage: SCSI VPD ✅ stress: stress-ng 🚧 ✅ POSIX pjd-fstest suites ppc64le: Host 1: ✅ Boot test ✅ Podman system integration test (as root) ✅ Podman system integration test (as user) ✅ LTP lite ✅ Loopdev Sanity ✅ jvm test suite ✅ AMTU (Abstract Machine Test Utility) ✅ LTP: openposix test suite ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ audit: audit testsuite test ✅ httpd: mod_ssl smoke sanity ✅ iotop: sanity ✅ tuned: tune-processes-through-perf ✅ Usex - version 1.9-29 🚧 ✅ POSIX pjd-fstest suites Host 2: ✅ Boot test ✅ xfstests: xfs ✅ selinux-policy: serge-testsuite ✅ lvm thinp sanity ✅ storage: software RAID testing 🚧 ✅ Storage blktests x86_64: Host 1: ✅ Boot test ✅ Podman system integration test (as root) ✅ Podman system integration test (as user) ✅ LTP lite ✅ Loopdev Sanity ✅ jvm test suite ✅ AMTU (Abstract Machine Test Utility) ✅ LTP: openposix test suite ✅ Ethernet drivers sanity ✅ Networking socket: fuzz ✅ audit: audit testsuite test ✅ httpd: mod_ssl smoke sanity ✅ iotop: sanity ✅ tuned: tune-processes-through-perf ✅ pciutils: sanity smoke test ✅ Usex - version 1.9-29 ✅ storage: SCSI VPD ✅ stress: stress-ng 🚧 ✅ POSIX pjd-fstest suites Host 2: ✅ Boot test ✅ xfstests: xfs ✅ selinux-policy: serge-testsuite ✅ lvm thinp sanity ✅ storage: software RAID testing 🚧 ✅ Storage blktests Test sources: https://github.com/CKI-project/tests-beaker 💚 Pull requests are welcome for new tests or improvements to existing tests! Waived tests ------------ If the test run included waived tests, they are marked with 🚧. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed. Testing timeout --------------- We aim to provide a report within reasonable timeframe. Tests that haven't finished running are marked with ⏱. Reports for non-upstream kernels have a Beaker recipe linked to next to each host.

5 years, 8 months

1
0
0 0

[patch 17/26] zram: fix race between backing_dev_show and backing_dev_store

by akpm＠linux-foundation.org

From: Chenwandun <chenwandun(a)huawei.com> Subject: zram: fix race between backing_dev_show and backing_dev_store CPU0: CPU1: backing_dev_show backing_dev_store ...... ...... file = zram->backing_dev; down_read(&zram->init_lock); down_read(&zram->init_init_lock) file_path(file, ...); zram->backing_dev = backing_dev; up_read(&zram->init_lock); up_read(&zram->init_lock); gets the value of zram->backing_dev too early in backing_dev_show, which resultin the value being NULL at the beginning, and not NULL later. backtrace: [<ffffff8570e0f3ec>] d_path+0xcc/0x174 [<ffffff8570decd90>] file_path+0x10/0x18 [<ffffff85712f7630>] backing_dev_show+0x40/0xb4 [<ffffff85712c776c>] dev_attr_show+0x20/0x54 [<ffffff8570e835e4>] sysfs_kf_seq_show+0x9c/0x10c [<ffffff8570e82b98>] kernfs_seq_show+0x28/0x30 [<ffffff8570e1c580>] seq_read+0x184/0x488 [<ffffff8570e81ec4>] kernfs_fop_read+0x5c/0x1a4 [<ffffff8570dee0fc>] __vfs_read+0x44/0x128 [<ffffff8570dee310>] vfs_read+0xa0/0x138 [<ffffff8570dee860>] SyS_read+0x54/0xb4 Link: http://lkml.kernel.org/r/1571046839-16814-1-git-send-email-chenwandun@huawe… Signed-off-by: Chenwandun <chenwandun(a)huawei.com> Acked-by: Minchan Kim <minchan(a)kernel.org> Cc: Sergey Senozhatsky <sergey.senozhatsky.work(a)gmail.com> Cc: Jens Axboe <axboe(a)kernel.dk> Cc: <stable(a)vger.kernel.org> [4.14+] Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- drivers/block/zram/zram_drv.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/block/zram/zram_drv.c~zram-fix-race-between-backing_dev_show-and-backing_dev_store +++ a/drivers/block/zram/zram_drv.c @@ -413,13 +413,14 @@ static void reset_bdev(struct zram *zram static ssize_t backing_dev_show(struct device *dev, struct device_attribute *attr, char *buf) { + struct file *file; struct zram *zram = dev_to_zram(dev); - struct file *file = zram->backing_dev; char *p; ssize_t ret; down_read(&zram->init_lock); - if (!zram->backing_dev) { + file = zram->backing_dev; + if (!file) { memcpy(buf, "none\n", 5); up_read(&zram->init_lock); return 5; _

5 years, 8 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror