- Linux-stable-mirror - lists.linaro.org

[PATCH 01/10] drm/i915/dp: Fix dsc bpp calculations.

by Maarten Lankhorst

There was a integer wraparound when mode_clock became too high, and we didn't correct for the FEC overhead factor when dividing, also the calculations would break at HBR3. As a result our calculated bpp was way too high, and the link width bpp limitation never came into effect. Print out the resulting bpp calcululations as a sanity check, just in case we ever have to debug it later on again. Signed-off-by: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> Fixes: d9218c8f6cf4 ("drm/i915/dp: Add helpers for Compressed BPP and Slice Count for DSC") Cc: <stable(a)vger.kernel.org> # v5.0+ Cc: Manasi Navare <manasi.d.navare(a)intel.com> --- drivers/gpu/drm/i915/display/intel_dp.c | 16 +++++++++------- drivers/gpu/drm/i915/display/intel_dp.h | 4 ++-- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 921ad0a2f7ba..614a25911f07 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -4323,10 +4323,10 @@ intel_dp_get_sink_irq_esi(struct intel_dp *intel_dp, u8 *sink_irq_vector) DP_DPRX_ESI_LEN; } -u16 intel_dp_dsc_get_output_bpp(int link_clock, u8 lane_count, - int mode_clock, int mode_hdisplay) +u16 intel_dp_dsc_get_output_bpp(u32 link_clock, u8 lane_count, + u32 mode_clock, u32 mode_hdisplay) { - u16 bits_per_pixel, max_bpp_small_joiner_ram; + u32 bits_per_pixel, max_bpp_small_joiner_ram; int i; /* @@ -4335,13 +4335,14 @@ u16 intel_dp_dsc_get_output_bpp(int link_clock, u8 lane_count, * FECOverhead = 2.4%, for SST -> TimeSlotsPerMTP is 1, * for MST -> TimeSlotsPerMTP has to be calculated */ - bits_per_pixel = (link_clock * lane_count * 8 * - DP_DSC_FEC_OVERHEAD_FACTOR) / - mode_clock; + bits_per_pixel = div_u64((u64)link_clock * lane_count * 8 * + DP_DSC_FEC_OVERHEAD_FACTOR, 1000ULL * mode_clock); + DRM_DEBUG_KMS("Max link bpp: %u\n", bits_per_pixel); /* Small Joiner Check: output bpp <= joiner RAM (bits) / Horiz. width */ max_bpp_small_joiner_ram = DP_DSC_MAX_SMALL_JOINER_RAM_BUFFER / mode_hdisplay; + DRM_DEBUG_KMS("Max small joiner bpp: %u\n", max_bpp_small_joiner_ram); /* * Greatest allowed DSC BPP = MIN (output BPP from avaialble Link BW @@ -4351,7 +4352,8 @@ u16 intel_dp_dsc_get_output_bpp(int link_clock, u8 lane_count, /* Error out if the max bpp is less than smallest allowed valid bpp */ if (bits_per_pixel < valid_dsc_bpp[0]) { - DRM_DEBUG_KMS("Unsupported BPP %d\n", bits_per_pixel); + DRM_DEBUG_KMS("Unsupported BPP %u, min %u\n", + bits_per_pixel, valid_dsc_bpp[0]); return 0; } diff --git a/drivers/gpu/drm/i915/display/intel_dp.h b/drivers/gpu/drm/i915/display/intel_dp.h index 657bbb1f5ed0..007d1981a33b 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.h +++ b/drivers/gpu/drm/i915/display/intel_dp.h @@ -102,8 +102,8 @@ bool intel_dp_source_supports_hbr2(struct intel_dp *intel_dp); bool intel_dp_source_supports_hbr3(struct intel_dp *intel_dp); bool intel_dp_get_link_status(struct intel_dp *intel_dp, u8 *link_status); -u16 intel_dp_dsc_get_output_bpp(int link_clock, u8 lane_count, - int mode_clock, int mode_hdisplay); +u16 intel_dp_dsc_get_output_bpp(u32 link_clock, u8 lane_count, + u32 mode_clock, u32 mode_hdisplay); u8 intel_dp_dsc_get_slice_count(struct intel_dp *intel_dp, int mode_clock, int mode_hdisplay); -- 2.20.1

5 years, 8 months

3
4
0 0

[PATCH 5.1] iwlwifi: mvm: disable TX-AMSDU on older NICs

by Luca Coelho

From: Johannes Berg <johannes.berg(a)intel.com> commit cfb21b11b891b08b79be07be57c40a85bb926668 upstream. On older NICs, we occasionally see issues with A-MSDU support, where the commands in the FIFO get confused and then we see an assert EDC because the next command in the FIFO isn't TX. We've tried to isolate this issue and understand where it comes from, but haven't found any errors in building the A-MSDU in software. At least for now, disable A-MSDU support on older hardware so that users can use it again without fearing the assert. This fixes https://bugzilla.kernel.org/show_bug.cgi?id=203315. Signed-off-by: Johannes Berg <johannes.berg(a)intel.com> Signed-off-by: Luca Coelho <luciano.coelho(a)intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c index 5caadaef707d..a74079b3e4bb 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c @@ -473,7 +473,19 @@ int iwl_mvm_mac_setup_register(struct iwl_mvm *mvm) ieee80211_hw_set(hw, SUPPORTS_VHT_EXT_NSS_BW); ieee80211_hw_set(hw, BUFF_MMPDU_TXQ); ieee80211_hw_set(hw, STA_MMPDU_TXQ); - ieee80211_hw_set(hw, TX_AMSDU); + /* + * On older devices, enabling TX A-MSDU occasionally leads to + * something getting messed up, the command read from the FIFO + * gets out of sync and isn't a TX command, so that we have an + * assert EDC. + * + * It's not clear where the bug is, but since we didn't used to + * support A-MSDU until moving the mac80211 iTXQs, just leave it + * for older devices. We also don't see this issue on any newer + * devices. + */ + if (mvm->cfg->device_family >= IWL_DEVICE_FAMILY_9000) + ieee80211_hw_set(hw, TX_AMSDU); ieee80211_hw_set(hw, TX_FRAG_LIST); if (iwl_mvm_has_tlc_offload(mvm)) { -- 2.23.0.rc1

5 years, 8 months

2
1
0 0

FAILED: patch "[PATCH] mm, page_owner: handle THP splits correctly" failed to apply to 4.19-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.19-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From f7da677bc6e72033f0981b9d58b5c5d409fa641e Mon Sep 17 00:00:00 2001 From: Vlastimil Babka <vbabka(a)suse.cz> Date: Sat, 24 Aug 2019 17:54:59 -0700 Subject: [PATCH] mm, page_owner: handle THP splits correctly THP splitting path is missing the split_page_owner() call that split_page() has. As a result, split THP pages are wrongly reported in the page_owner file as order-9 pages. Furthermore when the former head page is freed, the remaining former tail pages are not listed in the page_owner file at all. This patch fixes that by adding the split_page_owner() call into __split_huge_page(). Link: http://lkml.kernel.org/r/20190820131828.22684-2-vbabka@suse.cz Fixes: a9627bc5e34e ("mm/page_owner: introduce split_page_owner and replace manual handling") Reported-by: Kirill A. Shutemov <kirill(a)shutemov.name> Signed-off-by: Vlastimil Babka <vbabka(a)suse.cz> Cc: Michal Hocko <mhocko(a)kernel.org> Cc: Mel Gorman <mgorman(a)techsingularity.net> Cc: Matthew Wilcox <willy(a)infradead.org> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds(a)linux-foundation.org> diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 738065f765ab..de1f15969e27 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -32,6 +32,7 @@ #include <linux/shmem_fs.h> #include <linux/oom.h> #include <linux/numa.h> +#include <linux/page_owner.h> #include <asm/tlb.h> #include <asm/pgalloc.h> @@ -2516,6 +2517,9 @@ static void __split_huge_page(struct page *page, struct list_head *list, } ClearPageCompound(head); + + split_page_owner(head, HPAGE_PMD_ORDER); + /* See comment in __split_huge_page_tail() */ if (PageAnon(head)) { /* Additional pin to swap cache */

5 years, 8 months

2
1
0 0

FAILED: patch "[PATCH] mm, page_owner: handle THP splits correctly" failed to apply to 4.14-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.14-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From f7da677bc6e72033f0981b9d58b5c5d409fa641e Mon Sep 17 00:00:00 2001 From: Vlastimil Babka <vbabka(a)suse.cz> Date: Sat, 24 Aug 2019 17:54:59 -0700 Subject: [PATCH] mm, page_owner: handle THP splits correctly THP splitting path is missing the split_page_owner() call that split_page() has. As a result, split THP pages are wrongly reported in the page_owner file as order-9 pages. Furthermore when the former head page is freed, the remaining former tail pages are not listed in the page_owner file at all. This patch fixes that by adding the split_page_owner() call into __split_huge_page(). Link: http://lkml.kernel.org/r/20190820131828.22684-2-vbabka@suse.cz Fixes: a9627bc5e34e ("mm/page_owner: introduce split_page_owner and replace manual handling") Reported-by: Kirill A. Shutemov <kirill(a)shutemov.name> Signed-off-by: Vlastimil Babka <vbabka(a)suse.cz> Cc: Michal Hocko <mhocko(a)kernel.org> Cc: Mel Gorman <mgorman(a)techsingularity.net> Cc: Matthew Wilcox <willy(a)infradead.org> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds(a)linux-foundation.org> diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 738065f765ab..de1f15969e27 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -32,6 +32,7 @@ #include <linux/shmem_fs.h> #include <linux/oom.h> #include <linux/numa.h> +#include <linux/page_owner.h> #include <asm/tlb.h> #include <asm/pgalloc.h> @@ -2516,6 +2517,9 @@ static void __split_huge_page(struct page *page, struct list_head *list, } ClearPageCompound(head); + + split_page_owner(head, HPAGE_PMD_ORDER); + /* See comment in __split_huge_page_tail() */ if (PageAnon(head)) { /* Additional pin to swap cache */

5 years, 8 months

1
0
0 0

FAILED: patch "[PATCH] mm, page_owner: handle THP splits correctly" failed to apply to 4.9-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.9-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From f7da677bc6e72033f0981b9d58b5c5d409fa641e Mon Sep 17 00:00:00 2001 From: Vlastimil Babka <vbabka(a)suse.cz> Date: Sat, 24 Aug 2019 17:54:59 -0700 Subject: [PATCH] mm, page_owner: handle THP splits correctly THP splitting path is missing the split_page_owner() call that split_page() has. As a result, split THP pages are wrongly reported in the page_owner file as order-9 pages. Furthermore when the former head page is freed, the remaining former tail pages are not listed in the page_owner file at all. This patch fixes that by adding the split_page_owner() call into __split_huge_page(). Link: http://lkml.kernel.org/r/20190820131828.22684-2-vbabka@suse.cz Fixes: a9627bc5e34e ("mm/page_owner: introduce split_page_owner and replace manual handling") Reported-by: Kirill A. Shutemov <kirill(a)shutemov.name> Signed-off-by: Vlastimil Babka <vbabka(a)suse.cz> Cc: Michal Hocko <mhocko(a)kernel.org> Cc: Mel Gorman <mgorman(a)techsingularity.net> Cc: Matthew Wilcox <willy(a)infradead.org> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds(a)linux-foundation.org> diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 738065f765ab..de1f15969e27 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -32,6 +32,7 @@ #include <linux/shmem_fs.h> #include <linux/oom.h> #include <linux/numa.h> +#include <linux/page_owner.h> #include <asm/tlb.h> #include <asm/pgalloc.h> @@ -2516,6 +2517,9 @@ static void __split_huge_page(struct page *page, struct list_head *list, } ClearPageCompound(head); + + split_page_owner(head, HPAGE_PMD_ORDER); + /* See comment in __split_huge_page_tail() */ if (PageAnon(head)) { /* Additional pin to swap cache */

5 years, 8 months

1
0
0 0

[tip: x86/urgent] x86/apic: Include the LDR when clearing out APIC registers

by tip-bot2 for Bandan Das

The following commit has been merged into the x86/urgent branch of tip: Commit-ID: cfa16294b1c5b320c0a0e1cac37c784b92366c87 Gitweb: https://git.kernel.org/tip/cfa16294b1c5b320c0a0e1cac37c784b92366c87 Author: Bandan Das <bsd(a)redhat.com> AuthorDate: Mon, 26 Aug 2019 06:15:13 -04:00 Committer: Thomas Gleixner <tglx(a)linutronix.de> CommitterDate: Mon, 26 Aug 2019 17:47:24 +02:00 x86/apic: Include the LDR when clearing out APIC registers Although APIC initialization will typically clear out the LDR before setting it, the APIC cleanup code should reset the LDR. This was discovered with a 32-bit KVM guest jumping into a kdump kernel. The stale bits in the LDR triggered a bug in the KVM APIC implementation which caused the destination mapping for VCPUs to be corrupted. Note that this isn't intended to paper over the KVM APIC bug. The kernel has to clear the LDR when resetting the APIC registers except when X2APIC is enabled. This lacks a Fixes tag because missing to clear LDR goes way back into pre git history. Signed-off-by: Bandan Das <bsd(a)redhat.com> Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de> Cc: stable(a)vger.kernel.org Link: https://lkml.kernel.org/r20190826101513.5080-3-bsd@redhat.com --- arch/x86/kernel/apic/apic.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index aa5495d..e75f378 100644 --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -1179,6 +1179,10 @@ void clear_local_APIC(void) apic_write(APIC_LVT0, v | APIC_LVT_MASKED); v = apic_read(APIC_LVT1); apic_write(APIC_LVT1, v | APIC_LVT_MASKED); + if (!x2apic_enabled) { + v = apic_read(APIC_LDR) & ~APIC_LDR_MASK; + apic_write(APIC_LDR, v); + } if (maxlvt >= 4) { v = apic_read(APIC_LVTPC); apic_write(APIC_LVTPC, v | APIC_LVT_MASKED);

5 years, 8 months

1
0
0 0

[tip: x86/urgent] x86/apic: Do not initialize LDR and DFR for bigsmp

by tip-bot2 for Bandan Das

The following commit has been merged into the x86/urgent branch of tip: Commit-ID: 9cfe98a6dbfb2a72ae29831e57b406eab7668da8 Gitweb: https://git.kernel.org/tip/9cfe98a6dbfb2a72ae29831e57b406eab7668da8 Author: Bandan Das <bsd(a)redhat.com> AuthorDate: Mon, 26 Aug 2019 06:15:12 -04:00 Committer: Thomas Gleixner <tglx(a)linutronix.de> CommitterDate: Mon, 26 Aug 2019 17:45:22 +02:00 x86/apic: Do not initialize LDR and DFR for bigsmp Legacy apic init uses bigsmp for smp systems with 8 and more CPUs. The bigsmp APIC implementation uses physical destination mode, but it nevertheless initializes LDR and DFR. The LDR even ends up incorrectly with multiple bit being set. This does not cause a functional problem because LDR and DFR are ignored when physical destination mode is active, but it triggered a problem on a 32-bit KVM guest which jumps into a kdump kernel. The multiple bits set unearthed a bug in the KVM APIC implementation. The code which creates the logical destination map for VCPUs ignores the disabled state of the APIC and ends up overwriting an existing valid entry and as a result, APIC calibration hangs in the guest during kdump initialization. Remove the bogus LDR/DFR initialization. This is not intended to work around the KVM APIC bug. The LDR/DFR ininitalization is wrong on its own. The issue goes back into the pre git history. The fixes tag is the commit in the bitkeeper import which introduced bigsmp support in 2003. git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git Fixes: db7b9e9f26b8 ("[PATCH] Clustered APIC setup for >8 CPU systems") Suggested-by: Thomas Gleixner <tglx(a)linutronix.de> Signed-off-by: Bandan Das <bsd(a)redhat.com> Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de> Cc: stable(a)vger.kernel.org Link: https://lkml.kernel.org/r20190826101513.5080-2-bsd@redhat.com --- arch/x86/kernel/apic/bigsmp_32.c | 24 ++---------------------- 1 file changed, 2 insertions(+), 22 deletions(-) diff --git a/arch/x86/kernel/apic/bigsmp_32.c b/arch/x86/kernel/apic/bigsmp_32.c index afee386..caedd8d 100644 --- a/arch/x86/kernel/apic/bigsmp_32.c +++ b/arch/x86/kernel/apic/bigsmp_32.c @@ -38,32 +38,12 @@ static int bigsmp_early_logical_apicid(int cpu) return early_per_cpu(x86_cpu_to_apicid, cpu); } -static inline unsigned long calculate_ldr(int cpu) -{ - unsigned long val, id; - - val = apic_read(APIC_LDR) & ~APIC_LDR_MASK; - id = per_cpu(x86_bios_cpu_apicid, cpu); - val |= SET_APIC_LOGICAL_ID(id); - - return val; -} - /* - * Set up the logical destination ID. - * - * Intel recommends to set DFR, LDR and TPR before enabling - * an APIC. See e.g. "AP-388 82489DX User's Manual" (Intel - * document number 292116). So here it goes... + * bigsmp enables physical destination mode + * and doesn't use LDR and DFR */ static void bigsmp_init_apic_ldr(void) { - unsigned long val; - int cpu = smp_processor_id(); - - apic_write(APIC_DFR, APIC_DFR_FLAT); - val = calculate_ldr(cpu); - apic_write(APIC_LDR, val); } static void bigsmp_setup_apic_routing(void)

5 years, 8 months

1
0
0 0

✅ PASS: Stable queue: queue-5.2

by CKI Project

Hello, We ran automated tests on a patchset that was proposed for merging into this kernel tree. The patches were applied to: Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: f7d5b3dc4792 - Linux 5.2.10 The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK All kernel binaries, config files, and logs are available for download here: https://artifacts.cki-project.org/pipelines/124897 Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Merge testing ------------- We cloned this repository and checked out the following commit: Repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: f7d5b3dc4792 - Linux 5.2.10 We grabbed the d344b8b51408 commit of the stable queue repository. We then merged the patchset with `git am`: asoc-simple_card_utils.h-care-null-dai-at-asoc_simpl.patch asoc-simple-card-fix-an-use-after-free-in-simple_dai.patch asoc-simple-card-fix-an-use-after-free-in-simple_for.patch asoc-audio-graph-card-fix-use-after-free-in-graph_da.patch asoc-audio-graph-card-fix-an-use-after-free-in-graph.patch asoc-audio-graph-card-add-missing-const-at-graph_get.patch regulator-axp20x-fix-dcdca-and-dcdcd-for-axp806.patch regulator-axp20x-fix-dcdc5-and-dcdc6-for-axp803.patch asoc-samsung-odroid-fix-an-use-after-free-issue-for-.patch asoc-samsung-odroid-fix-a-double-free-issue-for-cpu_.patch asoc-intel-bytcht_es8316-add-quirk-for-irbis-nb41-ne.patch hid-logitech-hidpp-add-usb-pid-for-a-few-more-suppor.patch hid-add-044f-b320-thrustmaster-inc.-2-in-1-dt.patch mips-kernel-only-use-i8253-clocksource-with-periodic.patch mips-fix-cacheinfo.patch libbpf-sanitize-var-to-conservative-1-byte-int.patch netfilter-ebtables-fix-a-memory-leak-bug-in-compat.patch asoc-dapm-fix-handling-of-custom_stop_condition-on-d.patch asoc-sof-use-__u32-instead-of-uint32_t-in-uapi-heade.patch spi-pxa2xx-balance-runtime-pm-enable-disable-on-erro.patch bpf-sockmap-sock_map_delete-needs-to-use-xchg.patch bpf-sockmap-synchronize_rcu-before-free-ing-map.patch bpf-sockmap-only-create-entry-if-ulp-is-not-already-.patch selftests-bpf-fix-sendmsg6_prog-on-s390.patch asoc-dapm-fix-a-memory-leak-bug.patch bonding-force-slave-speed-check-after-link-state-rec.patch net-mvpp2-don-t-check-for-3-consecutive-idle-frames-.patch selftests-forwarding-gre_multipath-enable-ipv4-forwa.patch selftests-forwarding-gre_multipath-fix-flower-filter.patch selftests-bpf-add-another-gso_segs-access.patch libbpf-fix-using-uninitialized-ioctl-results.patch can-dev-call-netif_carrier_off-in-register_candev.patch can-mcp251x-add-error-check-when-wq-alloc-failed.patch can-gw-fix-error-path-of-cgw_module_init.patch asoc-fail-card-instantiation-if-dai-format-setup-fai.patch staging-fbtft-fix-gpio-handling.patch libbpf-silence-gcc8-warning-about-string-truncation.patch st21nfca_connectivity_event_received-null-check-the-.patch st_nci_hci_connectivity_event_received-null-check-th.patch nl-mac-80211-fix-interface-combinations-on-crypto-co.patch asoc-ti-davinci-mcasp-fix-clk-pdir-handling-for-i2s-.patch asoc-rockchip-fix-mono-capture.patch asoc-ti-davinci-mcasp-correct-slot_width-posed-const.patch net-usb-qmi_wwan-add-the-broadmobi-bm818-card.patch qed-rdma-fix-the-hw_ver-returned-in-device-attribute.patch isdn-misdn-hfcsusb-fix-possible-null-pointer-derefer.patch habanalabs-fix-f-w-download-in-be-architecture.patch mac80211_hwsim-fix-possible-null-pointer-dereference.patch net-stmmac-manage-errors-returned-by-of_get_mac_addr.patch netfilter-ipset-actually-allow-destination-mac-addre.patch netfilter-ipset-copy-the-right-mac-address-in-bitmap.patch netfilter-ipset-fix-rename-concurrency-with-listing.patch rxrpc-fix-potential-deadlock.patch rxrpc-fix-the-lack-of-notification-when-sendmsg-fail.patch nvmem-use-the-same-permissions-for-eeprom-as-for-nvm.patch iwlwifi-mvm-avoid-races-in-rate-init-and-rate-perfor.patch iwlwifi-dbg_ini-move-iwl_dbg_tlv_load_bin-out-of-deb.patch iwlwifi-dbg_ini-move-iwl_dbg_tlv_free-outside-of-deb.patch iwlwifi-fix-locking-in-delayed-gtk-setting.patch iwlwifi-mvm-send-lq-command-always-async.patch enetc-fix-build-error-without-phylib.patch isdn-hfcsusb-fix-misdn-driver-crash-caused-by-transf.patch net-phy-phy_led_triggers-fix-a-possible-null-pointer.patch perf-bench-numa-fix-cpu0-binding.patch spi-pxa2xx-add-support-for-intel-tiger-lake.patch can-sja1000-force-the-string-buffer-null-terminated.patch can-peak_usb-force-the-string-buffer-null-terminated.patch asoc-amd-acp3x-use-dma_ops-of-parent-device-for-acp3.patch net-ethernet-qlogic-qed-force-the-string-buffer-null.patch enetc-select-phylib-while-config_fsl_enetc_vf-is-set.patch nfsv4-fix-a-credential-refcount-leak-in-nfs41_check_.patch nfsv4-when-recovering-state-fails-with-eagain-retry-.patch nfsv4.1-fix-open-stateid-recovery.patch nfsv4.1-only-reap-expired-delegations.patch nfsv4-fix-a-potential-sleep-while-atomic-in-nfs4_do_.patch nfs-fix-regression-whereby-fscache-errors-are-appear.patch hid-quirks-set-the-increment_usage_on_duplicate-quir.patch hid-input-fix-a4tech-horizontal-wheel-custom-usage.patch drm-rockchip-suspend-dp-late.patch smb3-fix-potential-memory-leak-when-processing-compo.patch smb3-kernel-oops-mounting-a-encryptdata-share-with-c.patch sched-deadline-fix-double-accounting-of-rq-running-b.patch sched-psi-reduce-psimon-fifo-priority.patch sched-psi-do-not-require-setsched-permission-from-th.patch s390-protvirt-avoid-memory-sharing-for-diag-308-set-.patch s390-mm-fix-dump_pagetables-top-level-page-table-wal.patch s390-put-_stext-and-_etext-into-.text-section.patch ata-rb532_cf-fix-unused-variable-warning-in-rb532_pa.patch net-cxgb3_main-fix-a-resource-leak-in-a-error-path-i.patch net-stmmac-fix-issues-when-number-of-queues-4.patch net-stmmac-tc-do-not-return-a-fragment-entry.patch drm-amdgpu-pin-the-csb-buffer-on-hw-init-for-gfx-v8.patch net-hisilicon-make-hip04_tx_reclaim-non-reentrant.patch net-hisilicon-fix-hip04-xmit-never-return-tx_busy.patch net-hisilicon-fix-dma_map_single-failed-on-arm64.patch nfsv4-ensure-state-recovery-handles-etimedout-correc.patch libata-have-ata_scsi_rw_xlat-fail-invalid-passthroug.patch libata-add-sg-safety-checks-in-sff-pio-transfers.patch x86-lib-cpu-address-missing-prototypes-warning.patch drm-vmwgfx-fix-memory-leak-when-too-many-retries-hav.patch block-aoe-fix-kernel-crash-due-to-atomic-sleep-when-.patch block-bfq-handle-null-return-value-by-bfq_init_rq.patch perf-ftrace-fix-failure-to-set-cpumask-when-only-one.patch perf-cpumap-fix-writing-to-illegal-memory-in-handlin.patch perf-pmu-events-fix-missing-cpu_clk_unhalted.core-ev.patch dt-bindings-riscv-fix-the-schema-compatible-string-f.patch kvm-arm64-don-t-write-junk-to-sysregs-on-reset.patch kvm-arm-don-t-write-junk-to-cp15-registers-on-reset.patch selftests-kvm-adding-config-fragments.patch iwlwifi-mvm-disable-tx-amsdu-on-older-nics.patch hid-wacom-correct-misreported-ekr-ring-values.patch hid-wacom-correct-distance-scale-for-2nd-gen-intuos-devices.patch revert-kvm-x86-mmu-zap-only-the-relevant-pages-when-removing-a-memslot.patch revert-dm-bufio-fix-deadlock-with-loop-device.patch clk-socfpga-stratix10-fix-rate-caclulationg-for-cnt_clks.patch ceph-clear-page-dirty-before-invalidate-page.patch ceph-don-t-try-fill-file_lock-on-unsuccessful-getfilelock-reply.patch libceph-fix-pg-split-vs-osd-re-connect-race.patch drm-amdgpu-gfx9-update-pg_flags-after-determining-if-gfx-off-is-possible.patch drm-nouveau-don-t-retry-infinitely-when-receiving-no-data-on-i2c-over-aux.patch scsi-ufs-fix-null-pointer-dereference-in-ufshcd_config_vreg_hpm.patch gpiolib-never-report-open-drain-source-lines-as-input-to-user-space.patch drivers-hv-vmbus-fix-virt_to_hvpfn-for-x86_pae.patch userfaultfd_release-always-remove-uffd-flags-and-clear-vm_userfaultfd_ctx.patch x86-retpoline-don-t-clobber-rflags-during-call_nospec-on-i386.patch x86-apic-handle-missing-global-clockevent-gracefully.patch x86-cpu-amd-clear-rdrand-cpuid-bit-on-amd-family-15h-16h.patch x86-boot-save-fields-explicitly-zero-out-everything-else.patch x86-boot-fix-boot-regression-caused-by-bootparam-sanitizing.patch ib-hfi1-unsafe-psn-checking-for-tid-rdma-read-resp-packet.patch ib-hfi1-add-additional-checks-when-handling-tid-rdma-read-resp-packet.patch ib-hfi1-add-additional-checks-when-handling-tid-rdma-write-data-packet.patch ib-hfi1-drop-stale-tid-rdma-packets-that-cause-tiderr.patch psi-get-poll_work-to-run-when-calling-poll-syscall-next-time.patch dm-kcopyd-always-complete-failed-jobs.patch dm-dust-use-dust-block-size-for-badblocklist-index.patch dm-btree-fix-order-of-block-initialization-in-btree_split_beneath.patch dm-integrity-fix-a-crash-due-to-bug_on-in-__journal_read_write.patch dm-raid-add-missing-cleanup-in-raid_ctr.patch dm-space-map-metadata-fix-missing-store-of-apply_bops-return-value.patch dm-table-fix-invalid-memory-accesses-with-too-high-sector-number.patch Compile testing --------------- We compiled the kernel for 3 architectures: aarch64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg ppc64le: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg x86_64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: Host 1: ✅ Boot test [0] ✅ xfstests: xfs [1] ✅ selinux-policy: serge-testsuite [2] ✅ lvm thinp sanity [3] ✅ storage: software RAID testing [4] 🚧 ✅ Storage blktests [5] Host 2: ✅ Boot test [0] ✅ Podman system integration test (as root) [6] ✅ Podman system integration test (as user) [6] ✅ LTP lite [7] ✅ Loopdev Sanity [8] ✅ jvm test suite [9] ✅ AMTU (Abstract Machine Test Utility) [10] ✅ LTP: openposix test suite [11] ✅ Ethernet drivers sanity [12] ✅ Networking socket: fuzz [13] ✅ audit: audit testsuite test [14] ✅ httpd: mod_ssl smoke sanity [15] ✅ iotop: sanity [16] ✅ tuned: tune-processes-through-perf [17] ✅ Usex - version 1.9-29 [18] ✅ storage: SCSI VPD [19] ✅ stress: stress-ng [20] ppc64le: Host 1: ✅ Boot test [0] ✅ xfstests: xfs [1] ✅ selinux-policy: serge-testsuite [2] ✅ lvm thinp sanity [3] ✅ storage: software RAID testing [4] 🚧 ✅ Storage blktests [5] Host 2: ✅ Boot test [0] ✅ Podman system integration test (as root) [6] ✅ Podman system integration test (as user) [6] ✅ LTP lite [7] ✅ Loopdev Sanity [8] ✅ jvm test suite [9] ✅ AMTU (Abstract Machine Test Utility) [10] ✅ LTP: openposix test suite [11] ✅ Ethernet drivers sanity [12] ✅ Networking socket: fuzz [13] ✅ audit: audit testsuite test [14] ✅ httpd: mod_ssl smoke sanity [15] ✅ iotop: sanity [16] ✅ tuned: tune-processes-through-perf [17] ✅ Usex - version 1.9-29 [18] x86_64: Host 1: ✅ Boot test [0] ✅ Podman system integration test (as root) [6] ✅ Podman system integration test (as user) [6] ✅ LTP lite [7] ✅ Loopdev Sanity [8] ✅ jvm test suite [9] ✅ AMTU (Abstract Machine Test Utility) [10] ✅ LTP: openposix test suite [11] ✅ Ethernet drivers sanity [12] ✅ Networking socket: fuzz [13] ✅ audit: audit testsuite test [14] ✅ httpd: mod_ssl smoke sanity [15] ✅ iotop: sanity [16] ✅ tuned: tune-processes-through-perf [17] ✅ pciutils: sanity smoke test [21] ✅ Usex - version 1.9-29 [18] ✅ storage: SCSI VPD [19] ✅ stress: stress-ng [20] Host 2: ✅ Boot test [0] ✅ xfstests: xfs [1] ✅ selinux-policy: serge-testsuite [2] ✅ lvm thinp sanity [3] ✅ storage: software RAID testing [4] 🚧 ✅ Storage blktests [5] Test source: 💚 Pull requests are welcome for new tests or improvements to existing tests! [0]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [1]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… [2]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/packages/se… [3]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/lvm/… [4]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/swra… [5]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/blk [6]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/container/p… [7]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [8]: https://github.com/CKI-project/tests-beaker/archive/master.zip#filesystems/… [9]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/jvm [10]: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu [11]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [12]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [13]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [14]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/aud… [15]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/htt… [16]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/iot… [17]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/tun… [18]: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us… [19]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/scsi… [20]: https://github.com/CKI-project/tests-beaker/archive/master.zip#stress/stres… [21]: https://github.com/CKI-project/tests-beaker/archive/master.zip#pciutils/san… Waived tests ------------ If the test run included waived tests, they are marked with 🚧. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed.

5 years, 8 months

1
0
0 0

Re: [PATCH] phy: qcom-qmp: Correct ready status, again

by Kishon Vijay Abraham I

Hi Sasha, On 06/08/19 9:20 PM, Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: 885bd765963b phy: qcom-qmp: Correct READY_STATUS poll break condition. > > The bot has tested the following trees: v5.2.6. > > v5.2.6: Failed to apply! Possible dependencies: > 520602640419 ("phy: qcom-qmp: Raise qcom_qmp_phy_enable() polling delay") > > > NOTE: The patch will not be queued to stable trees until it is upstream. > > How should we proceed with this patch? Merging of this patch got delayed. Bjorn, Is it okay if this patch gets merged in the next merge window and backported to stable releases then? Thanks Kishon

5 years, 8 months

2
1
0 0

[tip: x86/urgent] uprobes/x86: Fix detection of 32-bit user mode

by tip-bot2 for Sebastian Mayr

The following commit has been merged into the x86/urgent branch of tip: Commit-ID: 9212ec7d8357ea630031e89d0d399c761421c83b Gitweb: https://git.kernel.org/tip/9212ec7d8357ea630031e89d0d399c761421c83b Author: Sebastian Mayr <me(a)sam.st> AuthorDate: Sun, 28 Jul 2019 17:26:17 +02:00 Committer: Thomas Gleixner <tglx(a)linutronix.de> CommitterDate: Mon, 26 Aug 2019 15:55:09 +02:00 uprobes/x86: Fix detection of 32-bit user mode 32-bit processes running on a 64-bit kernel are not always detected correctly, causing the process to crash when uretprobes are installed. The reason for the crash is that in_ia32_syscall() is used to determine the process's mode, which only works correctly when called from a syscall. In the case of uretprobes, however, the function is called from a exception and always returns 'false' on a 64-bit kernel. In consequence this leads to corruption of the process's return address. Fix this by using user_64bit_mode() instead of in_ia32_syscall(), which is correct in any situation. [ tglx: Add a comment and the following historical info ] This should have been detected by the rename which happened in commit abfb9498ee13 ("x86/entry: Rename is_{ia32,x32}_task() to in_{ia32,x32}_syscall()") which states in the changelog: The is_ia32_task()/is_x32_task() function names are a big misnomer: they suggests that the compat-ness of a system call is a task property, which is not true, the compatness of a system call purely depends on how it was invoked through the system call layer. ..... and then it went and blindly renamed every call site. Sadly enough this was already mentioned here: 8faaed1b9f50 ("uprobes/x86: Introduce sizeof_long(), cleanup adjust_ret_addr() and arch_uretprobe_hijack_return_addr()") where the changelog says: TODO: is_ia32_task() is not what we actually want, TS_COMPAT does not necessarily mean 32bit. Fortunately syscall-like insns can't be probed so it actually works, but it would be better to rename and use is_ia32_frame(). and goes all the way back to: 0326f5a94dde ("uprobes/core: Handle breakpoint and singlestep exceptions") Oh well. 7+ years until someone actually tried a uretprobe on a 32bit process on a 64bit kernel.... Fixes: 0326f5a94dde ("uprobes/core: Handle breakpoint and singlestep exceptions") Signed-off-by: Sebastian Mayr <me(a)sam.st> Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de> Cc: Masami Hiramatsu <mhiramat(a)kernel.org> Cc: Dmitry Safonov <dsafonov(a)virtuozzo.com> Cc: Oleg Nesterov <oleg(a)redhat.com> Cc: Srikar Dronamraju <srikar(a)linux.vnet.ibm.com> Cc: stable(a)vger.kernel.org Link: https://lkml.kernel.org/r/20190728152617.7308-1-me@sam.st --- arch/x86/kernel/uprobes.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/arch/x86/kernel/uprobes.c b/arch/x86/kernel/uprobes.c index d8359eb..8cd745e 100644 --- a/arch/x86/kernel/uprobes.c +++ b/arch/x86/kernel/uprobes.c @@ -508,9 +508,12 @@ struct uprobe_xol_ops { void (*abort)(struct arch_uprobe *, struct pt_regs *); }; -static inline int sizeof_long(void) +static inline int sizeof_long(struct pt_regs *regs) { - return in_ia32_syscall() ? 4 : 8; + /* + * Check registers for mode as in_xxx_syscall() does not apply here. + */ + return user_64bit_mode(regs) ? 8 : 4; } static int default_pre_xol_op(struct arch_uprobe *auprobe, struct pt_regs *regs) @@ -521,9 +524,9 @@ static int default_pre_xol_op(struct arch_uprobe *auprobe, struct pt_regs *regs) static int emulate_push_stack(struct pt_regs *regs, unsigned long val) { - unsigned long new_sp = regs->sp - sizeof_long(); + unsigned long new_sp = regs->sp - sizeof_long(regs); - if (copy_to_user((void __user *)new_sp, &val, sizeof_long())) + if (copy_to_user((void __user *)new_sp, &val, sizeof_long(regs))) return -EFAULT; regs->sp = new_sp; @@ -556,7 +559,7 @@ static int default_post_xol_op(struct arch_uprobe *auprobe, struct pt_regs *regs long correction = utask->vaddr - utask->xol_vaddr; regs->ip += correction; } else if (auprobe->defparam.fixups & UPROBE_FIX_CALL) { - regs->sp += sizeof_long(); /* Pop incorrect return address */ + regs->sp += sizeof_long(regs); /* Pop incorrect return address */ if (emulate_push_stack(regs, utask->vaddr + auprobe->defparam.ilen)) return -ERESTART; } @@ -675,7 +678,7 @@ static int branch_post_xol_op(struct arch_uprobe *auprobe, struct pt_regs *regs) * "call" insn was executed out-of-line. Just restore ->sp and restart. * We could also restore ->ip and try to call branch_emulate_op() again. */ - regs->sp += sizeof_long(); + regs->sp += sizeof_long(regs); return -ERESTART; } @@ -1056,7 +1059,7 @@ bool arch_uprobe_skip_sstep(struct arch_uprobe *auprobe, struct pt_regs *regs) unsigned long arch_uretprobe_hijack_return_addr(unsigned long trampoline_vaddr, struct pt_regs *regs) { - int rasize = sizeof_long(), nleft; + int rasize = sizeof_long(regs), nleft; unsigned long orig_ret_vaddr = 0; /* clear high bits for 32-bit apps */ if (copy_from_user(&orig_ret_vaddr, (void __user *)regs->sp, rasize))

5 years, 8 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror