- Linux-stable-mirror - lists.linaro.org

[PATCH for 4.14.y] mtd: cfi_cmdset_0002: Use chip_good() to retry in do_write_oneword()

by Tokunori Ikegami

As reported by the OpenWRT team, write requests sometimes fail on some platforms. Currently to check the state chip_ready() is used correctly as described by the flash memory S29GL256P11TFI01 datasheet. Also chip_good() is used to check if the write is succeeded and it was implemented by the commit fb4a90bfcd6d8 ("[MTD] CFI-0002 - Improve error checking"). But actually the write failure is caused on some platforms and also it can be fixed by using chip_good() to check the state and retry instead. Also it seems that it is caused after repeated about 1,000 times to retry the write one word with the reset command. By using chip_good() to check the state to be done it can be reduced the retry with reset. It is depended on the actual flash chip behavior so the root cause is unknown. Cc: Chris Packham <chris.packham(a)alliedtelesis.co.nz> Cc: Joakim Tjernlund <Joakim.Tjernlund(a)infinera.com> Cc: linux-mtd(a)lists.infradead.org Cc: stable(a)vger.kernel.org Reported-by: Fabio Bettoni <fbettoni(a)gmail.com> Signed-off-by: Felix Fietkau <nbd(a)nbd.name> Signed-off-by: Hauke Mehrtens <hauke(a)hauke-m.de> Signed-off-by: Tokunori Ikegami <ikegami.t(a)gmail.com> [vigneshr(a)ti.com: Fix a checkpatch warning] Signed-off-by: Vignesh Raghavendra <vigneshr(a)ti.com> --- drivers/mtd/chips/cfi_cmdset_0002.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) mode change 100644 => 100755 drivers/mtd/chips/cfi_cmdset_0002.c diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c old mode 100644 new mode 100755 index af3d207c9cc4..e773dc6fdd3c --- a/drivers/mtd/chips/cfi_cmdset_0002.c +++ b/drivers/mtd/chips/cfi_cmdset_0002.c @@ -1628,29 +1628,35 @@ static int __xipram do_write_oneword(struct map_info *map, struct flchip *chip, continue; } - if (time_after(jiffies, timeo) && !chip_ready(map, adr)){ + /* + * We check "time_after" and "!chip_good" before checking + * "chip_good" to avoid the failure due to scheduling. + */ + if (time_after(jiffies, timeo) && !chip_good(map, adr, datum)) { xip_enable(map, chip, adr); printk(KERN_WARNING "MTD %s(): software timeout\n", __func__); xip_disable(map, chip, adr); + ret = -EIO; break; } - if (chip_ready(map, adr)) + if (chip_good(map, adr, datum)) break; /* Latency issues. Drop the lock, wait a while and retry */ UDELAY(map, chip, adr, 1); } + /* Did we succeed? */ - if (!chip_good(map, adr, datum)) { + if (ret) { /* reset on all failures. */ map_write( map, CMD(0xF0), chip->start ); /* FIXME - should have reset delay before continuing */ - if (++retry_cnt <= MAX_RETRIES) + if (++retry_cnt <= MAX_RETRIES) { + ret = 0; goto retry; - - ret = -EIO; + } } xip_enable(map, chip, adr); op_done: -- 2.11.0

5 years, 12 months

1
0
0 0

[PATCH for 4.19.y] mtd: cfi_cmdset_0002: Use chip_good() to retry in do_write_oneword()

by Tokunori Ikegami

As reported by the OpenWRT team, write requests sometimes fail on some platforms. Currently to check the state chip_ready() is used correctly as described by the flash memory S29GL256P11TFI01 datasheet. Also chip_good() is used to check if the write is succeeded and it was implemented by the commit fb4a90bfcd6d8 ("[MTD] CFI-0002 - Improve error checking"). But actually the write failure is caused on some platforms and also it can be fixed by using chip_good() to check the state and retry instead. Also it seems that it is caused after repeated about 1,000 times to retry the write one word with the reset command. By using chip_good() to check the state to be done it can be reduced the retry with reset. It is depended on the actual flash chip behavior so the root cause is unknown. Cc: Chris Packham <chris.packham(a)alliedtelesis.co.nz> Cc: Joakim Tjernlund <Joakim.Tjernlund(a)infinera.com> Cc: linux-mtd(a)lists.infradead.org Cc: stable(a)vger.kernel.org Reported-by: Fabio Bettoni <fbettoni(a)gmail.com> Signed-off-by: Felix Fietkau <nbd(a)nbd.name> Signed-off-by: Hauke Mehrtens <hauke(a)hauke-m.de> Signed-off-by: Tokunori Ikegami <ikegami.t(a)gmail.com> [vigneshr(a)ti.com: Fix a checkpatch warning] Signed-off-by: Vignesh Raghavendra <vigneshr(a)ti.com> --- drivers/mtd/chips/cfi_cmdset_0002.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) mode change 100644 => 100755 drivers/mtd/chips/cfi_cmdset_0002.c diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c old mode 100644 new mode 100755 index 72428b6bfc47..ba44ea6d497e --- a/drivers/mtd/chips/cfi_cmdset_0002.c +++ b/drivers/mtd/chips/cfi_cmdset_0002.c @@ -1627,29 +1627,35 @@ static int __xipram do_write_oneword(struct map_info *map, struct flchip *chip, continue; } - if (time_after(jiffies, timeo) && !chip_ready(map, adr)){ + /* + * We check "time_after" and "!chip_good" before checking + * "chip_good" to avoid the failure due to scheduling. + */ + if (time_after(jiffies, timeo) && !chip_good(map, adr, datum)) { xip_enable(map, chip, adr); printk(KERN_WARNING "MTD %s(): software timeout\n", __func__); xip_disable(map, chip, adr); + ret = -EIO; break; } - if (chip_ready(map, adr)) + if (chip_good(map, adr, datum)) break; /* Latency issues. Drop the lock, wait a while and retry */ UDELAY(map, chip, adr, 1); } + /* Did we succeed? */ - if (!chip_good(map, adr, datum)) { + if (ret) { /* reset on all failures. */ map_write(map, CMD(0xF0), chip->start); /* FIXME - should have reset delay before continuing */ - if (++retry_cnt <= MAX_RETRIES) + if (++retry_cnt <= MAX_RETRIES) { + ret = 0; goto retry; - - ret = -EIO; + } } xip_enable(map, chip, adr); op_done: -- 2.11.0

5 years, 12 months

1
0
0 0

[PATCH 1/3] staging/fbtft: Depend on OF

by Noralf Trønnes

Commit c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface") removed setting gpios via platform data. This means that fbtft will now only work with Device Tree so set the dependency. This also prevents a NULL pointer deref on non-DT platform because fbtftops.request_gpios is not set in that case anymore. Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface") Cc: stable <stable(a)vger.kernel.org> Signed-off-by: Noralf Trønnes <noralf(a)tronnes.org> --- drivers/staging/fbtft/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/Kconfig b/drivers/staging/fbtft/Kconfig index 8ec524a95ec8..4e5d860fd788 100644 --- a/drivers/staging/fbtft/Kconfig +++ b/drivers/staging/fbtft/Kconfig @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 menuconfig FB_TFT tristate "Support for small TFT LCD display modules" - depends on FB && SPI + depends on FB && SPI && OF depends on GPIOLIB || COMPILE_TEST select FB_SYS_FILLRECT select FB_SYS_COPYAREA -- 2.20.1

5 years, 12 months

1
0
0 0

✅ PASS: Test report for kernel 5.2.16-rc1-08e7f5e.cki (stable)

by CKI Project

Hello, We ran automated tests on a recent commit from this kernel tree: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Commit: 08e7f5e8f180 - Linux 5.2.16-rc1 The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK All kernel binaries, config files, and logs are available for download here: https://artifacts.cki-project.org/pipelines/169018 Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Compile testing --------------- We compiled the kernel for 4 architectures: aarch64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg ppc64le: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg s390x: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg x86_64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ppc64le: Host 1: ✅ Boot test [0] ✅ xfstests: ext4 [1] ✅ xfstests: xfs [1] ✅ selinux-policy: serge-testsuite [2] ✅ lvm thinp sanity [3] ✅ storage: software RAID testing [4] 🚧 ✅ Storage blktests [5] Host 2: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test [0] ✅ Podman system integration test (as root) [6] ✅ Podman system integration test (as user) [6] ⚡⚡⚡ Loopdev Sanity [7] ✅ jvm test suite [8] ✅ Memory function: memfd_create [9] ✅ AMTU (Abstract Machine Test Utility) [10] ✅ LTP: openposix test suite [11] ✅ Ethernet drivers sanity [12] ✅ Networking socket: fuzz [13] ✅ Networking sctp-auth: sockopts test [14] ✅ Networking TCP: keepalive test [15] ✅ Networking UDP: socket [16] ✅ Networking tunnel: gre basic [17] ✅ Networking tunnel: vxlan basic [18] ✅ audit: audit testsuite test [19] ✅ httpd: mod_ssl smoke sanity [20] ✅ iotop: sanity [21] ✅ tuned: tune-processes-through-perf [22] ✅ Usex - version 1.9-29 [23] 🚧 ✅ LTP lite [24] 🚧 ✅ CIFS Connectathon [25] 🚧 ✅ Memory function: kaslr [26] 🚧 ✅ Networking bridge: sanity [27] 🚧 ✅ Networking MACsec: sanity [28] 🚧 ✅ Networking route: pmtu [29] 🚧 ✅ Networking tunnel: geneve basic test [30] 🚧 ✅ Networking ipsec: basic netns tunnel [31] 🚧 ✅ Networking vnic: ipvlan/basic [32] 🚧 ✅ ALSA PCM loopback test [33] 🚧 ✅ ALSA Control (mixer) Userspace Element test [34] 🚧 ✅ trace: ftrace/tracer [35] 🚧 ✅ Networking route_func: local [36] 🚧 ✅ Networking route_func: forward [36] s390x: Host 1: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test [0] ⚡⚡⚡ Podman system integration test (as root) [6] ⚡⚡⚡ Podman system integration test (as user) [6] ⚡⚡⚡ Loopdev Sanity [7] ⚡⚡⚡ jvm test suite [8] ⚡⚡⚡ Memory function: memfd_create [9] ⚡⚡⚡ LTP: openposix test suite [11] ⚡⚡⚡ Ethernet drivers sanity [12] ⚡⚡⚡ Networking sctp-auth: sockopts test [14] ⚡⚡⚡ Networking TCP: keepalive test [15] ⚡⚡⚡ Networking UDP: socket [16] ⚡⚡⚡ Networking tunnel: gre basic [17] ⚡⚡⚡ Networking tunnel: vxlan basic [18] ⚡⚡⚡ audit: audit testsuite test [19] ⚡⚡⚡ httpd: mod_ssl smoke sanity [20] ⚡⚡⚡ iotop: sanity [21] ⚡⚡⚡ tuned: tune-processes-through-perf [22] ⚡⚡⚡ Usex - version 1.9-29 [23] ⚡⚡⚡ stress: stress-ng [37] 🚧 ⚡⚡⚡ LTP lite [24] 🚧 ⚡⚡⚡ CIFS Connectathon [25] 🚧 ⚡⚡⚡ Memory function: kaslr [26] 🚧 ⚡⚡⚡ Networking bridge: sanity [27] 🚧 ⚡⚡⚡ Networking MACsec: sanity [28] 🚧 ⚡⚡⚡ Networking route: pmtu [29] 🚧 ⚡⚡⚡ Networking tunnel: geneve basic test [30] 🚧 ⚡⚡⚡ Networking vnic: ipvlan/basic [32] 🚧 ⚡⚡⚡ ALSA PCM loopback test [33] 🚧 ⚡⚡⚡ ALSA Control (mixer) Userspace Element test [34] 🚧 ⚡⚡⚡ trace: ftrace/tracer [35] 🚧 ⚡⚡⚡ Networking route_func: local [36] 🚧 ⚡⚡⚡ Networking route_func: forward [36] 🚧 ⚡⚡⚡ Networking ipsec: basic netns transport [31] 🚧 ⚡⚡⚡ Networking ipsec: basic netns tunnel [31] Host 2: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test [0] ⚡⚡⚡ selinux-policy: serge-testsuite [2] 🚧 ⚡⚡⚡ Storage blktests [5] x86_64: Host 1: ✅ Boot test [0] ✅ Storage SAN device stress - mpt3sas driver [38] Host 2: ✅ Boot test [0] ✅ xfstests: ext4 [1] ✅ xfstests: xfs [1] ✅ selinux-policy: serge-testsuite [2] ✅ lvm thinp sanity [3] ✅ storage: software RAID testing [4] 🚧 ✅ Storage blktests [5] 🚧 ❌ IOMMU boot test [39] Host 3: ✅ Boot test [0] ✅ Storage SAN device stress - megaraid_sas [38] Host 4: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test [0] ✅ Podman system integration test (as root) [6] ✅ Podman system integration test (as user) [6] ⚡⚡⚡ Loopdev Sanity [7] ✅ jvm test suite [8] ✅ Memory function: memfd_create [9] ✅ AMTU (Abstract Machine Test Utility) [10] ✅ LTP: openposix test suite [11] ✅ Ethernet drivers sanity [12] ✅ Networking socket: fuzz [13] ✅ Networking sctp-auth: sockopts test [14] ✅ Networking: igmp conformance test [40] ✅ Networking TCP: keepalive test [15] ✅ Networking UDP: socket [16] ✅ Networking tunnel: gre basic [17] ✅ Networking tunnel: vxlan basic [18] ✅ audit: audit testsuite test [19] ✅ httpd: mod_ssl smoke sanity [20] ✅ iotop: sanity [21] ✅ tuned: tune-processes-through-perf [22] ✅ pciutils: sanity smoke test [41] ✅ Usex - version 1.9-29 [23] ✅ storage: SCSI VPD [42] ✅ stress: stress-ng [37] 🚧 ✅ LTP lite [24] 🚧 ✅ CIFS Connectathon [25] 🚧 ✅ Memory function: kaslr [26] 🚧 ✅ Networking bridge: sanity [27] 🚧 ✅ Networking MACsec: sanity [28] 🚧 ✅ Networking route: pmtu [29] 🚧 ✅ Networking tunnel: geneve basic test [30] 🚧 ✅ Networking vnic: ipvlan/basic [32] 🚧 ✅ ALSA PCM loopback test [33] 🚧 ✅ ALSA Control (mixer) Userspace Element test [34] 🚧 ✅ trace: ftrace/tracer [35] 🚧 ✅ Networking route_func: local [36] 🚧 ✅ Networking route_func: forward [36] 🚧 ✅ Networking ipsec: basic netns transport [31] 🚧 ✅ Networking ipsec: basic netns tunnel [31] Test source: 💚 Pull requests are welcome for new tests or improvements to existing tests! [0]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [1]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… [2]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/packages/se… [3]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/lvm/… [4]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/swra… [5]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/blk [6]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/container/p… [7]: https://github.com/CKI-project/tests-beaker/archive/master.zip#filesystems/… [8]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/jvm [9]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/memory/func… [10]: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu [11]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [12]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [13]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [14]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/s… [15]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/t… [16]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/u… [17]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [18]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [19]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/aud… [20]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/htt… [21]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/iot… [22]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/tun… [23]: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us… [24]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [25]: https://github.com/CKI-project/tests-beaker/archive/master.zip#filesystems/… [26]: https://github.com/CKI-project/tests-beaker/archive/master.zip#memory/funct… [27]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/b… [28]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/m… [29]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [30]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [31]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [32]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/v… [33]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/sound/aloop [34]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/sound/user-… [35]: https://github.com/CKI-project/tests-beaker/archive/master.zip#trace/ftrace… [36]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [37]: https://github.com/CKI-project/tests-beaker/archive/master.zip#stress/stres… [38]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/hba/… [39]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/iommu/boot [40]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/i… [41]: https://github.com/CKI-project/tests-beaker/archive/master.zip#pciutils/san… [42]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/scsi… Waived tests ------------ If the test run included waived tests, they are marked with 🚧. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed.

5 years, 12 months

1
0
0 0

[PATCH] ath10k: Fix HOST capability QMI incompatibility

by Bjorn Andersson

The introduction of 768ec4c012ac ("ath10k: update HOST capability QMI message") served the purpose of supporting the new and extended HOST capability QMI message. But while the new message adds a slew of optional members it changes the data type of the "daemon_support" member, which means that older versions of the firmware will fail to decode the incoming request message. There is no way to detect this breakage from Linux and there's no way to recover from sending the wrong message (i.e. we can't just try one format and then fallback to the other), so a quirk is introduced in DeviceTree to indicate to the driver that the firmware requires the 8bit version of this message. Cc: stable(a)vger.kernel.org Fixes: 768ec4c012ac ("ath10k: update HOST capability qmi message") Signed-off-by: Bjorn Andersson <bjorn.andersson(a)linaro.org> --- .../bindings/net/wireless/qcom,ath10k.txt | 6 +++++ drivers/net/wireless/ath/ath10k/qmi.c | 13 ++++++++--- .../net/wireless/ath/ath10k/qmi_wlfw_v01.c | 22 +++++++++++++++++++ .../net/wireless/ath/ath10k/qmi_wlfw_v01.h | 1 + drivers/net/wireless/ath/ath10k/snoc.c | 11 ++++++++++ drivers/net/wireless/ath/ath10k/snoc.h | 1 + 6 files changed, 51 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt index ae661e65354e..f9499b20d840 100644 --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt @@ -81,6 +81,12 @@ Optional properties: Definition: Name of external front end module used. Some valid FEM names for example: "microsemi-lx5586", "sky85703-11" and "sky85803" etc. +- qcom,snoc-host-cap-8bit-quirk: + Usage: Optional + Value type: <empty> + Definition: Quirk specifying that the firmware expects the 8bit version + of the host capability QMI request + Example (to supply PCI based wifi block details): diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/ath/ath10k/qmi.c index 3b63b6257c43..545ac1f06997 100644 --- a/drivers/net/wireless/ath/ath10k/qmi.c +++ b/drivers/net/wireless/ath/ath10k/qmi.c @@ -581,22 +581,29 @@ static int ath10k_qmi_host_cap_send_sync(struct ath10k_qmi *qmi) { struct wlfw_host_cap_resp_msg_v01 resp = {}; struct wlfw_host_cap_req_msg_v01 req = {}; + struct qmi_elem_info *req_ei; struct ath10k *ar = qmi->ar; + struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar); struct qmi_txn txn; int ret; req.daemon_support_valid = 1; req.daemon_support = 0; - ret = qmi_txn_init(&qmi->qmi_hdl, &txn, - wlfw_host_cap_resp_msg_v01_ei, &resp); + ret = qmi_txn_init(&qmi->qmi_hdl, &txn, wlfw_host_cap_resp_msg_v01_ei, + &resp); if (ret < 0) goto out; + if (test_bit(ATH10K_SNOC_FLAG_8BIT_HOST_CAP_QUIRK, &ar_snoc->flags)) + req_ei = wlfw_host_cap_8bit_req_msg_v01_ei; + else + req_ei = wlfw_host_cap_req_msg_v01_ei; + ret = qmi_send_request(&qmi->qmi_hdl, NULL, &txn, QMI_WLFW_HOST_CAP_REQ_V01, WLFW_HOST_CAP_REQ_MSG_V01_MAX_MSG_LEN, - wlfw_host_cap_req_msg_v01_ei, &req); + req_ei, &req); if (ret < 0) { qmi_txn_cancel(&txn); ath10k_err(ar, "failed to send host capability request: %d\n", ret); diff --git a/drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.c b/drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.c index 1fe05c6218c3..86fcf4e1de5f 100644 --- a/drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.c +++ b/drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.c @@ -1988,6 +1988,28 @@ struct qmi_elem_info wlfw_host_cap_req_msg_v01_ei[] = { {} }; +struct qmi_elem_info wlfw_host_cap_8bit_req_msg_v01_ei[] = { + { + .data_type = QMI_OPT_FLAG, + .elem_len = 1, + .elem_size = sizeof(u8), + .array_type = NO_ARRAY, + .tlv_type = 0x10, + .offset = offsetof(struct wlfw_host_cap_req_msg_v01, + daemon_support_valid), + }, + { + .data_type = QMI_UNSIGNED_1_BYTE, + .elem_len = 1, + .elem_size = sizeof(u8), + .array_type = NO_ARRAY, + .tlv_type = 0x10, + .offset = offsetof(struct wlfw_host_cap_req_msg_v01, + daemon_support), + }, + {} +}; + struct qmi_elem_info wlfw_host_cap_resp_msg_v01_ei[] = { { .data_type = QMI_STRUCT, diff --git a/drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h b/drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h index bca1186e1560..4d107e1364a8 100644 --- a/drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h +++ b/drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h @@ -575,6 +575,7 @@ struct wlfw_host_cap_req_msg_v01 { #define WLFW_HOST_CAP_REQ_MSG_V01_MAX_MSG_LEN 189 extern struct qmi_elem_info wlfw_host_cap_req_msg_v01_ei[]; +extern struct qmi_elem_info wlfw_host_cap_8bit_req_msg_v01_ei[]; struct wlfw_host_cap_resp_msg_v01 { struct qmi_response_type_v01 resp; diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c index b491361e6ed4..fc15a0037f0e 100644 --- a/drivers/net/wireless/ath/ath10k/snoc.c +++ b/drivers/net/wireless/ath/ath10k/snoc.c @@ -1261,6 +1261,15 @@ static int ath10k_snoc_resource_init(struct ath10k *ar) return ret; } +static void ath10k_snoc_quirks_init(struct ath10k *ar) +{ + struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar); + struct device *dev = &ar_snoc->dev->dev; + + if (of_property_read_bool(dev->of_node, "qcom,snoc-host-cap-8bit-quirk")) + set_bit(ATH10K_SNOC_FLAG_8BIT_HOST_CAP_QUIRK, &ar_snoc->flags); +} + int ath10k_snoc_fw_indication(struct ath10k *ar, u64 type) { struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar); @@ -1678,6 +1687,8 @@ static int ath10k_snoc_probe(struct platform_device *pdev) ar->ce_priv = &ar_snoc->ce; msa_size = drv_data->msa_size; + ath10k_snoc_quirks_init(ar); + ret = ath10k_snoc_resource_init(ar); if (ret) { ath10k_warn(ar, "failed to initialize resource: %d\n", ret); diff --git a/drivers/net/wireless/ath/ath10k/snoc.h b/drivers/net/wireless/ath/ath10k/snoc.h index d62f53501fbb..9db823e46314 100644 --- a/drivers/net/wireless/ath/ath10k/snoc.h +++ b/drivers/net/wireless/ath/ath10k/snoc.h @@ -63,6 +63,7 @@ enum ath10k_snoc_flags { ATH10K_SNOC_FLAG_REGISTERED, ATH10K_SNOC_FLAG_UNREGISTERING, ATH10K_SNOC_FLAG_RECOVERY, + ATH10K_SNOC_FLAG_8BIT_HOST_CAP_QUIRK, }; struct ath10k_snoc { -- 2.18.0

5 years, 12 months

3
2
0 0

[PATCH] drm/amd/display: Restore backlight brightness after system resume

by Kai-Heng Feng

Laptops with AMD APU doesn't restore display backlight brightness after system resume. This issue started when DC was introduced. Let's use BL_CORE_SUSPENDRESUME so the backlight core calls update_status callback after system resume to restore the backlight level. Tested on Dell Inspiron 3180 (Stoney Ridge) and Dell Latitude 5495 (Raven Ridge). Cc: <stable(a)vger.kernel.org> Signed-off-by: Kai-Heng Feng <kai.heng.feng(a)canonical.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 1b0949dd7808..183ef18ac6f3 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -2111,6 +2111,7 @@ static int amdgpu_dm_backlight_get_brightness(struct backlight_device *bd) } static const struct backlight_ops amdgpu_dm_backlight_ops = { + .options = BL_CORE_SUSPENDRESUME, .get_brightness = amdgpu_dm_backlight_get_brightness, .update_status = amdgpu_dm_backlight_update_status, }; -- 2.17.1

5 years, 12 months

2
1
0 0

✅ PASS: Stable queue: queue-5.2

by CKI Project

Hello, We ran automated tests on a patchset that was proposed for merging into this kernel tree. The patches were applied to: Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 6e282ba6ff6b - Linux 5.2.15 The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK All kernel binaries, config files, and logs are available for download here: https://artifacts.cki-project.org/pipelines/169017 Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Merge testing ------------- We cloned this repository and checked out the following commit: Repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 6e282ba6ff6b - Linux 5.2.15 We grabbed the 210459e9afbb commit of the stable queue repository. We then merged the patchset with `git am`: bridge-mdb-remove-wrong-use-of-nlm_f_multi.patch cdc_ether-fix-rndis-support-for-mediatek-based-smartphones.patch ipv6-fix-the-link-time-qualifier-of-ping_v6_proc_exit_net.patch isdn-capi-check-message-length-in-capi_write.patch ixgbe-fix-secpath-usage-for-ipsec-tx-offload.patch ixgbevf-fix-secpath-usage-for-ipsec-tx-offload.patch net-fix-null-de-reference-of-device-refcount.patch net-gso-fix-skb_segment-splat-when-splitting-gso_size-mangled-skb-having-linear-headed-frag_list.patch net-phylink-fix-flow-control-resolution.patch net-sched-fix-reordering-issues.patch sch_hhf-ensure-quantum-and-hhf_non_hh_weight-are-non-zero.patch sctp-fix-the-link-time-qualifier-of-sctp_ctrlsock_exit.patch sctp-use-transport-pf_retrans-in-sctp_do_8_2_transport_strike.patch tcp-fix-tcp_ecn_withdraw_cwr-to-clear-tcp_ecn_queue_cwr.patch tipc-add-null-pointer-check-before-calling-kfree_rcu.patch tun-fix-use-after-free-when-register-netdev-failed.patch net-ipv6-fix-excessive-rtf_addrconf-flag-on-1-128-local-route-and-others.patch ipv6-addrconf_f6i_alloc-fix-non-null-pointer-check-to-is_err.patch net-fixed_phy-add-forward-declaration-for-struct-gpio_desc.patch sctp-fix-the-missing-put_user-when-dumping-transport-thresholds.patch net-sock_map-fix-missing-ulp-check-in-sock-hash-case.patch gpiolib-acpi-add-gpiolib_acpi_run_edge_events_on_boot-option-and-blacklist.patch gpio-mockup-add-missing-single_release.patch gpio-fix-line-flag-validation-in-linehandle_create.patch gpio-fix-line-flag-validation-in-lineevent_create.patch btrfs-fix-assertion-failure-during-fsync-and-use-of-stale-transaction.patch cgroup-freezer-fix-frozen-state-inheritance.patch revert-mmc-bcm2835-terminate-timeout-work-synchronously.patch revert-mmc-sdhci-remove-unneeded-quirk2-flag-of-o2-sd-host-controller.patch mmc-tmio-fixup-runtime-pm-management-during-probe.patch mmc-tmio-fixup-runtime-pm-management-during-remove.patch drm-lima-fix-lima_gem_wait-return-value.patch drm-i915-limit-mst-to-8bpc-once-again.patch drm-i915-restore-relaxed-padding-ocl_oob_suppres_enable-for-skl.patch ipc-fix-semtimedop-for-generic-32-bit-architectures.patch ipc-fix-sparc64-ipc-wrapper.patch ixgbe-fix-double-clean-of-tx-descriptors-with-xdp.patch ixgbe-prevent-u8-wrapping-of-itr-value-to-something-less-than-10us.patch revert-rt2800-enable-tx_pin_cfg_lna_pe_-bits-per-band.patch mt76-mt76x0e-disable-5ghz-band-for-mt7630e.patch genirq-prevent-null-pointer-dereference-in-resend_irqs.patch regulator-twl-voltage-lists-for-vdd1-2-on-twl4030.patch kvm-s390-kvm_s390_vm_start_migration-check-dirty_bitmap-before-using-it-as-target-for-memset.patch kvm-s390-do-not-leak-kernel-stack-data-in-the-kvm_s390_interrupt-ioctl.patch kvm-x86-work-around-leak-of-uninitialized-stack-contents.patch kvm-x86-mmu-reintroduce-fast-invalidate-zap-for-flushing-memslot.patch kvm-nvmx-handle-page-fault-in-vmread.patch x86-purgatory-change-compiler-flags-from-mcmodel-kernel-to-mcmodel-large-to-fix-kexec-relocation-errors.patch Compile testing --------------- We compiled the kernel for 4 architectures: aarch64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg ppc64le: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg s390x: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg x86_64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: Host 1: ✅ Boot test [0] ✅ selinux-policy: serge-testsuite [1] Host 2: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test [0] ⚡⚡⚡ Podman system integration test (as root) [2] ⚡⚡⚡ Podman system integration test (as user) [2] ⚡⚡⚡ Loopdev Sanity [3] ⚡⚡⚡ jvm test suite [4] ⚡⚡⚡ AMTU (Abstract Machine Test Utility) [5] ⚡⚡⚡ LTP: openposix test suite [6] ⚡⚡⚡ Ethernet drivers sanity [7] ⚡⚡⚡ Networking socket: fuzz [8] ⚡⚡⚡ Networking sctp-auth: sockopts test [9] ⚡⚡⚡ Networking TCP: keepalive test [10] ⚡⚡⚡ audit: audit testsuite test [11] ⚡⚡⚡ httpd: mod_ssl smoke sanity [12] ⚡⚡⚡ iotop: sanity [13] ⚡⚡⚡ tuned: tune-processes-through-perf [14] ⚡⚡⚡ Usex - version 1.9-29 [15] ⚡⚡⚡ stress: stress-ng [16] 🚧 ⚡⚡⚡ LTP lite [17] 🚧 ⚡⚡⚡ Networking bridge: sanity [18] 🚧 ⚡⚡⚡ Networking route: pmtu [19] 🚧 ⚡⚡⚡ Networking route_func: local [20] 🚧 ⚡⚡⚡ Networking route_func: forward [20] ppc64le: Host 1: ✅ Boot test [0] ✅ selinux-policy: serge-testsuite [1] Host 2: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test [0] ✅ Podman system integration test (as root) [2] ✅ Podman system integration test (as user) [2] ⚡⚡⚡ Loopdev Sanity [3] ✅ jvm test suite [4] ✅ AMTU (Abstract Machine Test Utility) [5] ✅ LTP: openposix test suite [6] ✅ Ethernet drivers sanity [7] ✅ Networking socket: fuzz [8] ✅ Networking sctp-auth: sockopts test [9] ✅ Networking TCP: keepalive test [10] ✅ audit: audit testsuite test [11] ✅ httpd: mod_ssl smoke sanity [12] ✅ iotop: sanity [13] ✅ tuned: tune-processes-through-perf [14] ✅ Usex - version 1.9-29 [15] 🚧 ✅ LTP lite [17] 🚧 ✅ Networking bridge: sanity [18] 🚧 ✅ Networking route: pmtu [19] 🚧 ✅ Networking route_func: local [20] 🚧 ✅ Networking route_func: forward [20] s390x: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. x86_64: Host 1: ✅ Boot test [0] ✅ selinux-policy: serge-testsuite [1] Host 2: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test [0] ✅ Podman system integration test (as root) [2] ✅ Podman system integration test (as user) [2] ⚡⚡⚡ Loopdev Sanity [3] ✅ jvm test suite [4] ✅ AMTU (Abstract Machine Test Utility) [5] ✅ LTP: openposix test suite [6] ✅ Ethernet drivers sanity [7] ✅ Networking socket: fuzz [8] ✅ Networking sctp-auth: sockopts test [9] ✅ Networking TCP: keepalive test [10] ✅ audit: audit testsuite test [11] ✅ httpd: mod_ssl smoke sanity [12] ✅ iotop: sanity [13] ✅ tuned: tune-processes-through-perf [14] ✅ pciutils: sanity smoke test [21] ✅ Usex - version 1.9-29 [15] ✅ stress: stress-ng [16] 🚧 ✅ LTP lite [17] 🚧 ✅ Networking bridge: sanity [18] 🚧 ✅ Networking route: pmtu [19] 🚧 ✅ Networking route_func: local [20] 🚧 ✅ Networking route_func: forward [20] Test source: 💚 Pull requests are welcome for new tests or improvements to existing tests! [0]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [1]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/packages/se… [2]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/container/p… [3]: https://github.com/CKI-project/tests-beaker/archive/master.zip#filesystems/… [4]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/jvm [5]: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu [6]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [7]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [8]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [9]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/s… [10]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/t… [11]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/aud… [12]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/htt… [13]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/iot… [14]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/tun… [15]: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us… [16]: https://github.com/CKI-project/tests-beaker/archive/master.zip#stress/stres… [17]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [18]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/b… [19]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [20]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [21]: https://github.com/CKI-project/tests-beaker/archive/master.zip#pciutils/san… Waived tests ------------ If the test run included waived tests, they are marked with 🚧. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed.

5 years, 12 months

1
0
0 0

❌ FAIL: Test report for kernel 5.2.15-6e282ba.cki (stable)

by CKI Project

Hello, We ran automated tests on a recent commit from this kernel tree: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Commit: 6e282ba6ff6b - Linux 5.2.15 The results of these automated tests are provided below. Overall result: FAILED (see details below) Merge: OK Compile: OK Tests: FAILED All kernel binaries, config files, and logs are available for download here: https://artifacts.cki-project.org/pipelines/168102 One or more kernel tests failed: aarch64: ❌ Boot test ❌ Boot test We hope that these logs can help you find the problem quickly. For the full detail on our testing procedures, please scroll to the bottom of this message. Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Compile testing --------------- We compiled the kernel for 4 architectures: aarch64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg ppc64le: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg s390x: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg x86_64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: Host 1: ❌ Boot test [0] ✅ xfstests: ext4 [1] ✅ xfstests: xfs [1] ✅ selinux-policy: serge-testsuite [2] ✅ lvm thinp sanity [3] ✅ storage: software RAID testing [4] 🚧 ✅ Storage blktests [5] Host 2: ❌ Boot test [0] ⚡⚡⚡ Podman system integration test (as root) [6] ⚡⚡⚡ Podman system integration test (as user) [6] ⚡⚡⚡ Loopdev Sanity [7] ⚡⚡⚡ jvm test suite [8] ⚡⚡⚡ Memory function: memfd_create [9] ⚡⚡⚡ AMTU (Abstract Machine Test Utility) [10] ⚡⚡⚡ LTP: openposix test suite [11] ⚡⚡⚡ Ethernet drivers sanity [12] ⚡⚡⚡ Networking socket: fuzz [13] ⚡⚡⚡ Networking sctp-auth: sockopts test [14] ⚡⚡⚡ Networking: igmp conformance test [15] ⚡⚡⚡ Networking TCP: keepalive test [16] ⚡⚡⚡ Networking UDP: socket [17] ⚡⚡⚡ Networking tunnel: gre basic [18] ⚡⚡⚡ Networking tunnel: vxlan basic [19] ⚡⚡⚡ audit: audit testsuite test [20] ⚡⚡⚡ httpd: mod_ssl smoke sanity [21] ⚡⚡⚡ iotop: sanity [22] ⚡⚡⚡ tuned: tune-processes-through-perf [23] ⚡⚡⚡ Usex - version 1.9-29 [24] ⚡⚡⚡ storage: SCSI VPD [25] ⚡⚡⚡ stress: stress-ng [26] 🚧 ⚡⚡⚡ LTP lite [27] 🚧 ⚡⚡⚡ CIFS Connectathon [28] 🚧 ⚡⚡⚡ Memory function: kaslr [29] 🚧 ⚡⚡⚡ Networking bridge: sanity [30] 🚧 ⚡⚡⚡ Networking MACsec: sanity [31] 🚧 ⚡⚡⚡ Networking route: pmtu [32] 🚧 ⚡⚡⚡ Networking tunnel: geneve basic test [33] 🚧 ⚡⚡⚡ Networking vnic: ipvlan/basic [34] 🚧 ⚡⚡⚡ ALSA PCM loopback test [35] 🚧 ⚡⚡⚡ ALSA Control (mixer) Userspace Element test [36] 🚧 ⚡⚡⚡ trace: ftrace/tracer [37] 🚧 ⚡⚡⚡ Networking route_func: local [38] 🚧 ⚡⚡⚡ Networking route_func: forward [38] 🚧 ⚡⚡⚡ Networking ipsec: basic netns transport [39] 🚧 ⚡⚡⚡ Networking ipsec: basic netns tunnel [39] ppc64le: Host 1: ✅ Boot test [0] ✅ xfstests: ext4 [1] ✅ xfstests: xfs [1] ✅ selinux-policy: serge-testsuite [2] ✅ lvm thinp sanity [3] ✅ storage: software RAID testing [4] 🚧 ✅ Storage blktests [5] Host 2: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test [0] ✅ Podman system integration test (as root) [6] ✅ Podman system integration test (as user) [6] ⚡⚡⚡ Loopdev Sanity [7] ✅ jvm test suite [8] ✅ Memory function: memfd_create [9] ✅ AMTU (Abstract Machine Test Utility) [10] ✅ LTP: openposix test suite [11] ✅ Ethernet drivers sanity [12] ✅ Networking socket: fuzz [13] ✅ Networking sctp-auth: sockopts test [14] ✅ Networking TCP: keepalive test [16] ✅ Networking UDP: socket [17] ✅ Networking tunnel: gre basic [18] ✅ Networking tunnel: vxlan basic [19] ✅ audit: audit testsuite test [20] ✅ httpd: mod_ssl smoke sanity [21] ✅ iotop: sanity [22] ✅ tuned: tune-processes-through-perf [23] ✅ Usex - version 1.9-29 [24] 🚧 ✅ LTP lite [27] 🚧 ✅ CIFS Connectathon [28] 🚧 ✅ Memory function: kaslr [29] 🚧 ✅ Networking bridge: sanity [30] 🚧 ✅ Networking MACsec: sanity [31] 🚧 ✅ Networking route: pmtu [32] 🚧 ✅ Networking tunnel: geneve basic test [33] 🚧 ✅ Networking ipsec: basic netns tunnel [39] 🚧 ✅ Networking vnic: ipvlan/basic [34] 🚧 ✅ ALSA PCM loopback test [35] 🚧 ✅ ALSA Control (mixer) Userspace Element test [36] 🚧 ✅ trace: ftrace/tracer [37] 🚧 ✅ Networking route_func: local [38] 🚧 ✅ Networking route_func: forward [38] s390x: Host 1: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test [0] ⚡⚡⚡ Podman system integration test (as root) [6] ⚡⚡⚡ Podman system integration test (as user) [6] ⚡⚡⚡ Loopdev Sanity [7] ⚡⚡⚡ jvm test suite [8] ⚡⚡⚡ Memory function: memfd_create [9] ⚡⚡⚡ LTP: openposix test suite [11] ⚡⚡⚡ Ethernet drivers sanity [12] ⚡⚡⚡ Networking sctp-auth: sockopts test [14] ⚡⚡⚡ Networking TCP: keepalive test [16] ⚡⚡⚡ Networking UDP: socket [17] ⚡⚡⚡ Networking tunnel: gre basic [18] ⚡⚡⚡ Networking tunnel: vxlan basic [19] ⚡⚡⚡ audit: audit testsuite test [20] ⚡⚡⚡ httpd: mod_ssl smoke sanity [21] ⚡⚡⚡ iotop: sanity [22] ⚡⚡⚡ tuned: tune-processes-through-perf [23] ⚡⚡⚡ Usex - version 1.9-29 [24] ⚡⚡⚡ stress: stress-ng [26] 🚧 ⚡⚡⚡ LTP lite [27] 🚧 ⚡⚡⚡ CIFS Connectathon [28] 🚧 ⚡⚡⚡ Memory function: kaslr [29] 🚧 ⚡⚡⚡ Networking bridge: sanity [30] 🚧 ⚡⚡⚡ Networking MACsec: sanity [31] 🚧 ⚡⚡⚡ Networking route: pmtu [32] 🚧 ⚡⚡⚡ Networking tunnel: geneve basic test [33] 🚧 ⚡⚡⚡ Networking vnic: ipvlan/basic [34] 🚧 ⚡⚡⚡ ALSA PCM loopback test [35] 🚧 ⚡⚡⚡ ALSA Control (mixer) Userspace Element test [36] 🚧 ⚡⚡⚡ trace: ftrace/tracer [37] 🚧 ⚡⚡⚡ Networking route_func: local [38] 🚧 ⚡⚡⚡ Networking route_func: forward [38] 🚧 ⚡⚡⚡ Networking ipsec: basic netns transport [39] 🚧 ⚡⚡⚡ Networking ipsec: basic netns tunnel [39] Host 2: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ⚡⚡⚡ Boot test [0] ⚡⚡⚡ selinux-policy: serge-testsuite [2] 🚧 ⚡⚡⚡ Storage blktests [5] x86_64: Host 1: ✅ Boot test [0] ✅ Storage SAN device stress - megaraid_sas [40] Host 2: ✅ Boot test [0] ✅ Storage SAN device stress - mpt3sas driver [40] Host 3: ✅ Boot test [0] ✅ xfstests: ext4 [1] ✅ xfstests: xfs [1] ✅ selinux-policy: serge-testsuite [2] ✅ lvm thinp sanity [3] ✅ storage: software RAID testing [4] 🚧 ✅ Storage blktests [5] 🚧 ✅ IOMMU boot test [41] Host 4: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test [0] ✅ Podman system integration test (as root) [6] ✅ Podman system integration test (as user) [6] ⚡⚡⚡ Loopdev Sanity [7] ✅ jvm test suite [8] ✅ Memory function: memfd_create [9] ✅ AMTU (Abstract Machine Test Utility) [10] ✅ LTP: openposix test suite [11] ✅ Ethernet drivers sanity [12] ✅ Networking socket: fuzz [13] ✅ Networking sctp-auth: sockopts test [14] ✅ Networking: igmp conformance test [15] ✅ Networking TCP: keepalive test [16] ✅ Networking UDP: socket [17] ✅ Networking tunnel: gre basic [18] ✅ Networking tunnel: vxlan basic [19] ✅ audit: audit testsuite test [20] ✅ httpd: mod_ssl smoke sanity [21] ✅ iotop: sanity [22] ✅ tuned: tune-processes-through-perf [23] ✅ pciutils: sanity smoke test [42] ✅ Usex - version 1.9-29 [24] ✅ storage: SCSI VPD [25] ✅ stress: stress-ng [26] 🚧 ✅ LTP lite [27] 🚧 ✅ CIFS Connectathon [28] 🚧 ✅ Memory function: kaslr [29] 🚧 ✅ Networking bridge: sanity [30] 🚧 ✅ Networking MACsec: sanity [31] 🚧 ✅ Networking route: pmtu [32] 🚧 ✅ Networking tunnel: geneve basic test [33] 🚧 ✅ Networking vnic: ipvlan/basic [34] 🚧 ✅ ALSA PCM loopback test [35] 🚧 ✅ ALSA Control (mixer) Userspace Element test [36] 🚧 ✅ trace: ftrace/tracer [37] 🚧 ✅ Networking route_func: local [38] 🚧 ✅ Networking route_func: forward [38] 🚧 ✅ Networking ipsec: basic netns transport [39] 🚧 ✅ Networking ipsec: basic netns tunnel [39] Test source: 💚 Pull requests are welcome for new tests or improvements to existing tests! [0]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [1]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… [2]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/packages/se… [3]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/lvm/… [4]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/swra… [5]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/blk [6]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/container/p… [7]: https://github.com/CKI-project/tests-beaker/archive/master.zip#filesystems/… [8]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/jvm [9]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/memory/func… [10]: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu [11]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [12]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [13]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [14]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/s… [15]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/i… [16]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/t… [17]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/u… [18]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [19]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [20]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/aud… [21]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/htt… [22]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/iot… [23]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/tun… [24]: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us… [25]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/scsi… [26]: https://github.com/CKI-project/tests-beaker/archive/master.zip#stress/stres… [27]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [28]: https://github.com/CKI-project/tests-beaker/archive/master.zip#filesystems/… [29]: https://github.com/CKI-project/tests-beaker/archive/master.zip#memory/funct… [30]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/b… [31]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/m… [32]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [33]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [34]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/v… [35]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/sound/aloop [36]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/sound/user-… [37]: https://github.com/CKI-project/tests-beaker/archive/master.zip#trace/ftrace… [38]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [39]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [40]: https://github.com/CKI-project/tests-beaker/archive/master.zip#storage/hba/… [41]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/iommu/boot [42]: https://github.com/CKI-project/tests-beaker/archive/master.zip#pciutils/san… Waived tests ------------ If the test run included waived tests, they are marked with 🚧. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed.

5 years, 12 months

2
1
0 0

✅ PASS: Stable queue: queue-5.2

by CKI Project

Hello, We ran automated tests on a patchset that was proposed for merging into this kernel tree. The patches were applied to: Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 6e282ba6ff6b - Linux 5.2.15 The results of these automated tests are provided below. Overall result: PASSED Merge: OK Compile: OK Tests: OK All kernel binaries, config files, and logs are available for download here: https://artifacts.cki-project.org/pipelines/168682 Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Merge testing ------------- We cloned this repository and checked out the following commit: Repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git Commit: 6e282ba6ff6b - Linux 5.2.15 We grabbed the 6ce8f5d40fdb commit of the stable queue repository. We then merged the patchset with `git am`: bridge-mdb-remove-wrong-use-of-nlm_f_multi.patch cdc_ether-fix-rndis-support-for-mediatek-based-smartphones.patch ipv6-fix-the-link-time-qualifier-of-ping_v6_proc_exit_net.patch isdn-capi-check-message-length-in-capi_write.patch ixgbe-fix-secpath-usage-for-ipsec-tx-offload.patch ixgbevf-fix-secpath-usage-for-ipsec-tx-offload.patch net-fix-null-de-reference-of-device-refcount.patch net-gso-fix-skb_segment-splat-when-splitting-gso_size-mangled-skb-having-linear-headed-frag_list.patch net-phylink-fix-flow-control-resolution.patch net-sched-fix-reordering-issues.patch sch_hhf-ensure-quantum-and-hhf_non_hh_weight-are-non-zero.patch sctp-fix-the-link-time-qualifier-of-sctp_ctrlsock_exit.patch sctp-use-transport-pf_retrans-in-sctp_do_8_2_transport_strike.patch tcp-fix-tcp_ecn_withdraw_cwr-to-clear-tcp_ecn_queue_cwr.patch tipc-add-null-pointer-check-before-calling-kfree_rcu.patch tun-fix-use-after-free-when-register-netdev-failed.patch net-ipv6-fix-excessive-rtf_addrconf-flag-on-1-128-local-route-and-others.patch ipv6-addrconf_f6i_alloc-fix-non-null-pointer-check-to-is_err.patch net-fixed_phy-add-forward-declaration-for-struct-gpio_desc.patch sctp-fix-the-missing-put_user-when-dumping-transport-thresholds.patch net-sock_map-fix-missing-ulp-check-in-sock-hash-case.patch gpiolib-acpi-add-gpiolib_acpi_run_edge_events_on_boot-option-and-blacklist.patch gpio-mockup-add-missing-single_release.patch gpio-fix-line-flag-validation-in-linehandle_create.patch gpio-fix-line-flag-validation-in-lineevent_create.patch btrfs-fix-assertion-failure-during-fsync-and-use-of-stale-transaction.patch cgroup-freezer-fix-frozen-state-inheritance.patch revert-mmc-bcm2835-terminate-timeout-work-synchronously.patch revert-mmc-sdhci-remove-unneeded-quirk2-flag-of-o2-sd-host-controller.patch mmc-tmio-fixup-runtime-pm-management-during-probe.patch mmc-tmio-fixup-runtime-pm-management-during-remove.patch drm-lima-fix-lima_gem_wait-return-value.patch drm-i915-limit-mst-to-8bpc-once-again.patch drm-i915-restore-relaxed-padding-ocl_oob_suppres_enable-for-skl.patch ipc-fix-semtimedop-for-generic-32-bit-architectures.patch ipc-fix-sparc64-ipc-wrapper.patch ixgbe-fix-double-clean-of-tx-descriptors-with-xdp.patch ixgbe-prevent-u8-wrapping-of-itr-value-to-something-less-than-10us.patch revert-rt2800-enable-tx_pin_cfg_lna_pe_-bits-per-band.patch mt76-mt76x0e-disable-5ghz-band-for-mt7630e.patch genirq-prevent-null-pointer-dereference-in-resend_irqs.patch regulator-twl-voltage-lists-for-vdd1-2-on-twl4030.patch kvm-s390-kvm_s390_vm_start_migration-check-dirty_bitmap-before-using-it-as-target-for-memset.patch kvm-s390-do-not-leak-kernel-stack-data-in-the-kvm_s390_interrupt-ioctl.patch kvm-x86-work-around-leak-of-uninitialized-stack-contents.patch kvm-x86-mmu-reintroduce-fast-invalidate-zap-for-flushing-memslot.patch kvm-nvmx-handle-page-fault-in-vmread.patch Compile testing --------------- We compiled the kernel for 4 architectures: aarch64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg ppc64le: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg s390x: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg x86_64: make options: -j30 INSTALL_MOD_STRIP=1 targz-pkg Hardware testing ---------------- We booted each kernel and ran the following tests: aarch64: Host 1: ✅ Boot test [0] ✅ selinux-policy: serge-testsuite [1] Host 2: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test [0] ✅ Podman system integration test (as root) [2] ✅ Podman system integration test (as user) [2] ⚡⚡⚡ Loopdev Sanity [3] ✅ jvm test suite [4] ✅ AMTU (Abstract Machine Test Utility) [5] ✅ LTP: openposix test suite [6] ✅ Ethernet drivers sanity [7] ✅ Networking socket: fuzz [8] ✅ Networking sctp-auth: sockopts test [9] ✅ Networking TCP: keepalive test [10] ✅ audit: audit testsuite test [11] ✅ httpd: mod_ssl smoke sanity [12] ✅ iotop: sanity [13] ✅ tuned: tune-processes-through-perf [14] ✅ Usex - version 1.9-29 [15] ✅ stress: stress-ng [16] 🚧 ✅ LTP lite [17] 🚧 ✅ Networking bridge: sanity [18] 🚧 ✅ Networking route: pmtu [19] 🚧 ✅ Networking route_func: local [20] 🚧 ✅ Networking route_func: forward [20] ppc64le: Host 1: ✅ Boot test [0] ✅ selinux-policy: serge-testsuite [1] Host 2: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test [0] ✅ Podman system integration test (as root) [2] ✅ Podman system integration test (as user) [2] ⚡⚡⚡ Loopdev Sanity [3] ✅ jvm test suite [4] ✅ AMTU (Abstract Machine Test Utility) [5] ✅ LTP: openposix test suite [6] ✅ Ethernet drivers sanity [7] ✅ Networking socket: fuzz [8] ✅ Networking sctp-auth: sockopts test [9] ✅ Networking TCP: keepalive test [10] ✅ audit: audit testsuite test [11] ✅ httpd: mod_ssl smoke sanity [12] ✅ iotop: sanity [13] ✅ tuned: tune-processes-through-perf [14] ✅ Usex - version 1.9-29 [15] 🚧 ✅ LTP lite [17] 🚧 ✅ Networking bridge: sanity [18] 🚧 ✅ Networking route: pmtu [19] 🚧 ✅ Networking route_func: local [20] 🚧 ✅ Networking route_func: forward [20] s390x: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. x86_64: Host 1: ✅ Boot test [0] ✅ selinux-policy: serge-testsuite [1] Host 2: ⚡ Internal infrastructure issues prevented one or more tests (marked with ⚡⚡⚡) from running on this architecture. This is not the fault of the kernel that was tested. ✅ Boot test [0] ✅ Podman system integration test (as root) [2] ✅ Podman system integration test (as user) [2] ⚡⚡⚡ Loopdev Sanity [3] ✅ jvm test suite [4] ✅ AMTU (Abstract Machine Test Utility) [5] ✅ LTP: openposix test suite [6] ✅ Ethernet drivers sanity [7] ✅ Networking socket: fuzz [8] ✅ Networking sctp-auth: sockopts test [9] ✅ Networking TCP: keepalive test [10] ✅ audit: audit testsuite test [11] ✅ httpd: mod_ssl smoke sanity [12] ✅ iotop: sanity [13] ✅ tuned: tune-processes-through-perf [14] ✅ pciutils: sanity smoke test [21] ✅ Usex - version 1.9-29 [15] ✅ stress: stress-ng [16] 🚧 ✅ LTP lite [17] 🚧 ✅ Networking bridge: sanity [18] 🚧 ✅ Networking route: pmtu [19] 🚧 ✅ Networking route_func: local [20] 🚧 ✅ Networking route_func: forward [20] Test source: 💚 Pull requests are welcome for new tests or improvements to existing tests! [0]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [1]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/packages/se… [2]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/container/p… [3]: https://github.com/CKI-project/tests-beaker/archive/master.zip#filesystems/… [4]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/jvm [5]: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu [6]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [7]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [8]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [9]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/s… [10]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/t… [11]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/aud… [12]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/htt… [13]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/iot… [14]: https://github.com/CKI-project/tests-beaker/archive/master.zip#packages/tun… [15]: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us… [16]: https://github.com/CKI-project/tests-beaker/archive/master.zip#stress/stres… [17]: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… [18]: https://github.com/CKI-project/tests-beaker/archive/master.zip#networking/b… [19]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [20]: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… [21]: https://github.com/CKI-project/tests-beaker/archive/master.zip#pciutils/san… Waived tests ------------ If the test run included waived tests, they are marked with 🚧. Such tests are executed but their results are not taken into account. Tests are waived when their results are not reliable enough, e.g. when they're just introduced or are being fixed.

5 years, 12 months

1
0
0 0

[PATCH 2/4] CVE-2016-9777: KVM: x86: fix out-of-bounds accesses of rtc_eoi map

by Jackie Liu

From: Radim Krčmář <rkrcmar(a)redhat.com> KVM was using arrays of size KVM_MAX_VCPUS with vcpu_id, but ID can be bigger that the maximal number of VCPUs, resulting in out-of-bounds access. Found by syzkaller: BUG: KASAN: slab-out-of-bounds in __apic_accept_irq+0xb33/0xb50 at addr [...] Write of size 1 by task a.out/27101 CPU: 1 PID: 27101 Comm: a.out Not tainted 4.9.0-rc5+ #49 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 [...] Call Trace: [...] __apic_accept_irq+0xb33/0xb50 arch/x86/kvm/lapic.c:905 [...] kvm_apic_set_irq+0x10e/0x180 arch/x86/kvm/lapic.c:495 [...] kvm_irq_delivery_to_apic+0x732/0xc10 arch/x86/kvm/irq_comm.c:86 [...] ioapic_service+0x41d/0x760 arch/x86/kvm/ioapic.c:360 [...] ioapic_set_irq+0x275/0x6c0 arch/x86/kvm/ioapic.c:222 [...] kvm_ioapic_inject_all arch/x86/kvm/ioapic.c:235 [...] kvm_set_ioapic+0x223/0x310 arch/x86/kvm/ioapic.c:670 [...] kvm_vm_ioctl_set_irqchip arch/x86/kvm/x86.c:3668 [...] kvm_arch_vm_ioctl+0x1a08/0x23c0 arch/x86/kvm/x86.c:3999 [...] kvm_vm_ioctl+0x1fa/0x1a70 arch/x86/kvm/../../../virt/kvm/kvm_main.c:3099 Reported-by: Dmitry Vyukov <dvyukov(a)google.com> Cc: stable(a)vger.kernel.org Fixes: af1bae5497b9 ("KVM: x86: bump KVM_MAX_VCPU_ID to 1023") Reviewed-by: Paolo Bonzini <pbonzini(a)redhat.com> Reviewed-by: David Hildenbrand <david(a)redhat.com> Signed-off-by: Radim Krčmář <rkrcmar(a)redhat.com> Signed-off-by: Jackie Liu <liuyun01(a)kylinos.cn> --- arch/x86/kvm/ioapic.c | 2 +- arch/x86/kvm/ioapic.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kvm/ioapic.c b/arch/x86/kvm/ioapic.c index ec62df3..d25cbac 100644 --- a/arch/x86/kvm/ioapic.c +++ b/arch/x86/kvm/ioapic.c @@ -94,7 +94,7 @@ static unsigned long ioapic_read_indirect(struct kvm_ioapic *ioapic, static void rtc_irq_eoi_tracking_reset(struct kvm_ioapic *ioapic) { ioapic->rtc_status.pending_eoi = 0; - bitmap_zero(ioapic->rtc_status.dest_map.map, KVM_MAX_VCPUS); + bitmap_zero(ioapic->rtc_status.dest_map.map, KVM_MAX_VCPU_ID); } static void kvm_rtc_eoi_tracking_restore_all(struct kvm_ioapic *ioapic); diff --git a/arch/x86/kvm/ioapic.h b/arch/x86/kvm/ioapic.h index 7d2692a..1cc6e54 100644 --- a/arch/x86/kvm/ioapic.h +++ b/arch/x86/kvm/ioapic.h @@ -42,13 +42,13 @@ struct kvm_vcpu; struct dest_map { /* vcpu bitmap where IRQ has been sent */ - DECLARE_BITMAP(map, KVM_MAX_VCPUS); + DECLARE_BITMAP(map, KVM_MAX_VCPU_ID); /* * Vector sent to a given vcpu, only valid when * the vcpu's bit in map is set */ - u8 vectors[KVM_MAX_VCPUS]; + u8 vectors[KVM_MAX_VCPU_ID]; }; -- 2.7.4

5 years, 12 months

1
1
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror