- Linux-stable-mirror - lists.linaro.org

[PATCH V3] fscrypt: don't set policy for a dead directory

by Hongjie Fang

the directory maybe has been removed when enter fscrypt_ioctl_set_policy(). if so, the empty_dir() check will return error for ext4 file system. ext4_rmdir() sets i_size = 0, then ext4_empty_dir() reports an error because 'inode->i_size < EXT4_DIR_REC_LEN(1) + EXT4_DIR_REC_LEN(2)'. if the fs is mounted with errors=panic, it will trigger a panic issue. add the check IS_DEADDIR() to fix this problem. Fixes: 9bd8212f981e ("ext4 crypto: add encryption policy and password salt support") Cc: <stable(a)vger.kernel.org> # v4.1+ Signed-off-by: Hongjie Fang <hongjiefang(a)asrmicro.com> --- fs/crypto/policy.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/crypto/policy.c b/fs/crypto/policy.c index d536889..4941fe8 100644 --- a/fs/crypto/policy.c +++ b/fs/crypto/policy.c @@ -81,6 +81,8 @@ int fscrypt_ioctl_set_policy(struct file *filp, const void __user *arg) if (ret == -ENODATA) { if (!S_ISDIR(inode->i_mode)) ret = -ENOTDIR; + else if (IS_DEADDIR(inode)) + ret = -ENOENT; else if (!inode->i_sb->s_cop->empty_dir(inode)) ret = -ENOTEMPTY; else -- 1.9.1

5 years, 12 months

2
1
0 0

[PATCH] MIPS: pistachio: Build uImage.gz by default

by Paul Burton

The pistachio platform uses the U-Boot bootloader & generally boots a kernel in the uImage format. As such it's useful to build one when building the kernel, but to do so currently requires the user to manually specify a uImage target on the make command line. Make uImage.gz the pistachio platform's default build target, so that the default is to build a kernel image that we can actually boot on a board such as the MIPS Creator Ci40. Marked for stable backport as far as v4.1 where pistachio support was introduced. This is primarily useful for CI systems such as kernelci.org which will benefit from us building a suitable image which can then be booted as part of automated testing, extending our test coverage to the affected stable branches. Signed-off-by: Paul Burton <paul.burton(a)mips.com> Reviewed-by: Kevin Hilman <khilman(a)baylibre.com> Tested-by: Kevin Hilman <khilman(a)baylibre.com> URL: https://groups.io/g/kernelci/message/388 Cc: stable(a)vger.kernel.org # v4.1+ --- arch/mips/pistachio/Platform | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/mips/pistachio/Platform b/arch/mips/pistachio/Platform index d80cd612df1f..c3592b374ad2 100644 --- a/arch/mips/pistachio/Platform +++ b/arch/mips/pistachio/Platform @@ -6,3 +6,4 @@ cflags-$(CONFIG_MACH_PISTACHIO) += \ -I$(srctree)/arch/mips/include/asm/mach-pistachio load-$(CONFIG_MACH_PISTACHIO) += 0xffffffff80400000 zload-$(CONFIG_MACH_PISTACHIO) += 0xffffffff81000000 +all-$(CONFIG_MACH_PISTACHIO) := uImage.gz -- 2.21.0

5 years, 12 months

2
2
0 0

patch "usbip: usbip_host: fix stub_dev lock context imbalance regression" added to usb-linus

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled usbip: usbip_host: fix stub_dev lock context imbalance regression to my usb git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the usb-linus branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will hopefully also be merged in Linus's tree for the next -rc kernel release. If you have any questions about this process, please let me know. >From 3ea3091f1bd8586125848c62be295910e9802af0 Mon Sep 17 00:00:00 2001 From: Shuah Khan <skhan(a)linuxfoundation.org> Date: Wed, 29 May 2019 13:46:15 -0600 Subject: usbip: usbip_host: fix stub_dev lock context imbalance regression MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix the following sparse context imbalance regression introduced in a patch that fixed sleeping function called from invalid context bug. kbuild test robot reported on: tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-linus Regressions in current branch: drivers/usb/usbip/stub_dev.c:399:9: sparse: sparse: context imbalance in 'stub_probe' - different lock contexts for basic block drivers/usb/usbip/stub_dev.c:418:13: sparse: sparse: context imbalance in 'stub_disconnect' - different lock contexts for basic block drivers/usb/usbip/stub_dev.c:464:1-10: second lock on line 476 Error ids grouped by kconfigs: recent_errors ├── i386-allmodconfig │ └── drivers-usb-usbip-stub_dev.c:second-lock-on-line ├── x86_64-allmodconfig │ ├── drivers-usb-usbip-stub_dev.c:sparse:sparse:context-imbalance-in-stub_disconnect-different-lock-contexts-for-basic-block │ └── drivers-usb-usbip-stub_dev.c:sparse:sparse:context-imbalance-in-stub_probe-different-lock-contexts-for-basic-block └── x86_64-allyesconfig └── drivers-usb-usbip-stub_dev.c:second-lock-on-line This is a real problem in an error leg where spin_lock() is called on an already held lock. Fix the imbalance in stub_probe() and stub_disconnect(). Signed-off-by: Shuah Khan <skhan(a)linuxfoundation.org> Fixes: 0c9e8b3cad65 ("usbip: usbip_host: fix BUG: sleeping function called from invalid context") Cc: stable <stable(a)vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/usb/usbip/stub_dev.c | 36 +++++++++++++++++++++++------------- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git a/drivers/usb/usbip/stub_dev.c b/drivers/usb/usbip/stub_dev.c index d094c96643d2..7931e6cecc70 100644 --- a/drivers/usb/usbip/stub_dev.c +++ b/drivers/usb/usbip/stub_dev.c @@ -326,14 +326,17 @@ static int stub_probe(struct usb_device *udev) * See driver_probe_device() in driver/base/dd.c */ rc = -ENODEV; - goto sdev_free; + if (!busid_priv) + goto sdev_free; + + goto call_put_busid_priv; } if (udev->descriptor.bDeviceClass == USB_CLASS_HUB) { dev_dbg(&udev->dev, "%s is a usb hub device... skip!\n", udev_busid); rc = -ENODEV; - goto sdev_free; + goto call_put_busid_priv; } if (!strcmp(udev->bus->bus_name, "vhci_hcd")) { @@ -342,7 +345,7 @@ static int stub_probe(struct usb_device *udev) udev_busid); rc = -ENODEV; - goto sdev_free; + goto call_put_busid_priv; } @@ -361,6 +364,9 @@ static int stub_probe(struct usb_device *udev) save_status = busid_priv->status; busid_priv->status = STUB_BUSID_ALLOC; + /* release the busid_lock */ + put_busid_priv(busid_priv); + /* * Claim this hub port. * It doesn't matter what value we pass as owner @@ -373,9 +379,6 @@ static int stub_probe(struct usb_device *udev) goto err_port; } - /* release the busid_lock */ - put_busid_priv(busid_priv); - rc = stub_add_files(&udev->dev); if (rc) { dev_err(&udev->dev, "stub_add_files for %s\n", udev_busid); @@ -395,11 +398,17 @@ static int stub_probe(struct usb_device *udev) spin_lock(&busid_priv->busid_lock); busid_priv->sdev = NULL; busid_priv->status = save_status; -sdev_free: - stub_device_free(sdev); + spin_unlock(&busid_priv->busid_lock); + /* lock is released - go to free */ + goto sdev_free; + +call_put_busid_priv: /* release the busid_lock */ put_busid_priv(busid_priv); +sdev_free: + stub_device_free(sdev); + return rc; } @@ -435,7 +444,9 @@ static void stub_disconnect(struct usb_device *udev) /* get stub_device */ if (!sdev) { dev_err(&udev->dev, "could not get device"); - goto call_put_busid_priv; + /* release busid_lock */ + put_busid_priv(busid_priv); + return; } dev_set_drvdata(&udev->dev, NULL); @@ -465,7 +476,7 @@ static void stub_disconnect(struct usb_device *udev) if (!busid_priv->shutdown_busid) busid_priv->shutdown_busid = 1; /* release busid_lock */ - put_busid_priv(busid_priv); + spin_unlock(&busid_priv->busid_lock); /* shutdown the current connection */ shutdown_busid(busid_priv); @@ -480,10 +491,9 @@ static void stub_disconnect(struct usb_device *udev) if (busid_priv->status == STUB_BUSID_ALLOC) busid_priv->status = STUB_BUSID_ADDED; - -call_put_busid_priv: /* release busid_lock */ - put_busid_priv(busid_priv); + spin_unlock(&busid_priv->busid_lock); + return; } #ifdef CONFIG_PM -- 2.21.0

5 years, 12 months

1
0
0 0

[PATCH AUTOSEL 5.0 001/317] gfs2: Fix lru_count going negative

by Sasha Levin

From: Ross Lagerwall <ross.lagerwall(a)citrix.com> [ Upstream commit 7881ef3f33bb80f459ea6020d1e021fc524a6348 ] Under certain conditions, lru_count may drop below zero resulting in a large amount of log spam like this: vmscan: shrink_slab: gfs2_dump_glock+0x3b0/0x630 [gfs2] \ negative objects to delete nr=-1 This happens as follows: 1) A glock is moved from lru_list to the dispose list and lru_count is decremented. 2) The dispose function calls cond_resched() and drops the lru lock. 3) Another thread takes the lru lock and tries to add the same glock to lru_list, checking if the glock is on an lru list. 4) It is on a list (actually the dispose list) and so it avoids incrementing lru_count. 5) The glock is moved to lru_list. 5) The original thread doesn't dispose it because it has been re-added to the lru list but the lru_count has still decreased by one. Fix by checking if the LRU flag is set on the glock rather than checking if the glock is on some list and rearrange the code so that the LRU flag is added/removed precisely when the glock is added/removed from lru_list. Signed-off-by: Ross Lagerwall <ross.lagerwall(a)citrix.com> Signed-off-by: Andreas Gruenbacher <agruenba(a)redhat.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- fs/gfs2/glock.c | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index 4b038f25f2564..2d25d89e77f9b 100644 --- a/fs/gfs2/glock.c +++ b/fs/gfs2/glock.c @@ -183,15 +183,19 @@ static int demote_ok(const struct gfs2_glock *gl) void gfs2_glock_add_to_lru(struct gfs2_glock *gl) { + if (!(gl->gl_ops->go_flags & GLOF_LRU)) + return; + spin_lock(&lru_lock); - if (!list_empty(&gl->gl_lru)) - list_del_init(&gl->gl_lru); - else + list_del(&gl->gl_lru); + list_add_tail(&gl->gl_lru, &lru_list); + + if (!test_bit(GLF_LRU, &gl->gl_flags)) { + set_bit(GLF_LRU, &gl->gl_flags); atomic_inc(&lru_count); + } - list_add_tail(&gl->gl_lru, &lru_list); - set_bit(GLF_LRU, &gl->gl_flags); spin_unlock(&lru_lock); } @@ -201,7 +205,7 @@ static void gfs2_glock_remove_from_lru(struct gfs2_glock *gl) return; spin_lock(&lru_lock); - if (!list_empty(&gl->gl_lru)) { + if (test_bit(GLF_LRU, &gl->gl_flags)) { list_del_init(&gl->gl_lru); atomic_dec(&lru_count); clear_bit(GLF_LRU, &gl->gl_flags); @@ -1159,8 +1163,7 @@ void gfs2_glock_dq(struct gfs2_holder *gh) !test_bit(GLF_DEMOTE, &gl->gl_flags)) fast_path = 1; } - if (!test_bit(GLF_LFLUSH, &gl->gl_flags) && demote_ok(gl) && - (glops->go_flags & GLOF_LRU)) + if (!test_bit(GLF_LFLUSH, &gl->gl_flags) && demote_ok(gl)) gfs2_glock_add_to_lru(gl); trace_gfs2_glock_queue(gh, 0); @@ -1456,6 +1459,7 @@ __acquires(&lru_lock) if (!spin_trylock(&gl->gl_lockref.lock)) { add_back_to_lru: list_add(&gl->gl_lru, &lru_list); + set_bit(GLF_LRU, &gl->gl_flags); atomic_inc(&lru_count); continue; } @@ -1463,7 +1467,6 @@ __acquires(&lru_lock) spin_unlock(&gl->gl_lockref.lock); goto add_back_to_lru; } - clear_bit(GLF_LRU, &gl->gl_flags); gl->gl_lockref.count++; if (demote_ok(gl)) handle_callback(gl, LM_ST_UNLOCKED, 0, false); @@ -1498,6 +1501,7 @@ static long gfs2_scan_glock_lru(int nr) if (!test_bit(GLF_LOCK, &gl->gl_flags)) { list_move(&gl->gl_lru, &dispose); atomic_dec(&lru_count); + clear_bit(GLF_LRU, &gl->gl_flags); freed++; continue; } -- 2.20.1

5 years, 12 months

3
106
0 0

[PATCH] block: Fix read-only block device setting after revalidate

by Martin K. Petersen

Commit 20bd1d026aac ("scsi: sd: Keep disk read-only when re-reading partition") addressed a long-standing problem with user read-only policy being overridden as a result of a device-initiated revalidate. The commit has since been reverted due to a regression that left some USB devices read-only indefinitely. To fix the underlying problems with revalidate we need to keep track of hardware state and user policy separately. Every time the state is changed, either via a hardware event or the BLKROSET ioctl, the per-partition read-only state is updated based on the combination of device state and policy. The resulting active state is stored in a separate hd_struct flag to avoid introducing additional lookups in the I/O hot path. The gendisk has been updated to reflect the current hardware state set by the device driver. This is done to allow returning the device to the hardware state once the user clears the BLKROSET flag. For partitions, the existing hd_struct 'policy' flag is split into two: - 'read_only' indicates the currently active read-only state of a whole disk device or partition. - 'ro_policy' indicates the whether the user has administratively set the whole disk or partition read-only via the BLKROSET ioctl. The resulting semantics are as follows: - If BLKROSET is used to set a whole-disk device read-only, any partitions will end up in a read-only state until the user explicitly clears the flag. - If BLKROSET sets a given partition read-only, that partition will remain read-only even if the underlying storage stack initiates a revalidate. However, the BLKRRPART ioctl will cause the partition table to be dropped and any user policy on partitions will be lost. - If BLKROSET has not been set, both the whole disk device and any partitions will reflect the current write-protect state of the underlying device. Cc: <stable(a)vger.kernel.org> Cc: Jeremy Cline <jeremy(a)jcline.org> Cc: Ewan D. Milne <emilne(a)redhat.com> Reported-by: Oleksii Kurochko <olkuroch(a)cisco.com> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=201221 Signed-off-by: Martin K. Petersen <martin.petersen(a)oracle.com> --- block/blk-core.c | 2 +- block/genhd.c | 69 +++++++++++++++++++++++++++++---------- block/partition-generic.c | 4 +-- include/linux/genhd.h | 10 +++--- 4 files changed, 61 insertions(+), 24 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index 4673ebe42255..932f179a9095 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -792,7 +792,7 @@ static inline bool bio_check_ro(struct bio *bio, struct hd_struct *part) { const int op = bio_op(bio); - if (part->policy && op_is_write(op)) { + if (part->read_only && op_is_write(op)) { char b[BDEVNAME_SIZE]; if (op_is_flush(bio->bi_opf) && !bio_sectors(bio)) diff --git a/block/genhd.c b/block/genhd.c index 703267865f14..75138cf5540d 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -1539,38 +1539,73 @@ static void set_disk_ro_uevent(struct gendisk *gd, int ro) kobject_uevent_env(&disk_to_dev(gd)->kobj, KOBJ_CHANGE, envp); } -void set_device_ro(struct block_device *bdev, int flag) -{ - bdev->bd_part->policy = flag; -} - -EXPORT_SYMBOL(set_device_ro); - -void set_disk_ro(struct gendisk *disk, int flag) +/** + * update_part_ro_state - iterate over partitions to update read-only state + * @disk: The disk device + * + * This function updates the read-only state for all partitions on a + * given disk device. This is required every time a hardware event + * signals that the device write-protect state has changed. It is also + * necessary when the user sets or clears the read-only flag on the + * whole-disk device. + */ +static void update_part_ro_state(struct gendisk *disk) { struct disk_part_iter piter; struct hd_struct *part; - if (disk->part0.policy != flag) { - set_disk_ro_uevent(disk, flag); - disk->part0.policy = flag; - } - - disk_part_iter_init(&piter, disk, DISK_PITER_INCL_EMPTY); + disk_part_iter_init(&piter, disk, DISK_PITER_INCL_EMPTY_PART0); while ((part = disk_part_iter_next(&piter))) - part->policy = flag; + if (disk->read_only || disk->part0.ro_policy || part->ro_policy) + part->read_only = true; + else + part->read_only = false; disk_part_iter_exit(&piter); } +/** + * set_device_ro - set a block device read-only + * @bdev: The block device (whole disk or partition) + * @state: true or false + * + * This function is used to specify the read-only policy for a + * block_device (whole disk or partition). set_device_ro() is called + * by the BLKROSET ioctl. + */ +void set_device_ro(struct block_device *bdev, bool state) +{ + bdev->bd_part->read_only = bdev->bd_part->ro_policy = state; + if (bdev->bd_part->partno == 0) + update_part_ro_state(bdev->bd_disk); +} +EXPORT_SYMBOL(set_device_ro); + +/** + * set_disk_ro - set a gendisk read-only + * @disk: The disk device + * @state: true or false + * + * This function is used to indicate whether a given disk device + * should have its read-only flag set. set_disk_ro() is typically used + * by device drivers to indicate whether the underlying physical + * device is write-protected. + */ +void set_disk_ro(struct gendisk *disk, bool state) +{ + if (disk->read_only == state) + return; + set_disk_ro_uevent(disk, state); + disk->read_only = state; + update_part_ro_state(disk); +} EXPORT_SYMBOL(set_disk_ro); int bdev_read_only(struct block_device *bdev) { if (!bdev) return 0; - return bdev->bd_part->policy; + return bdev->bd_part->read_only; } - EXPORT_SYMBOL(bdev_read_only); int invalidate_partition(struct gendisk *disk, int partno) diff --git a/block/partition-generic.c b/block/partition-generic.c index 8e596a8dff32..8c55b90c918d 100644 --- a/block/partition-generic.c +++ b/block/partition-generic.c @@ -98,7 +98,7 @@ static ssize_t part_ro_show(struct device *dev, struct device_attribute *attr, char *buf) { struct hd_struct *p = dev_to_part(dev); - return sprintf(buf, "%d\n", p->policy ? 1 : 0); + return sprintf(buf, "%u\n", p->read_only ? 1 : 0); } static ssize_t part_alignment_offset_show(struct device *dev, @@ -338,7 +338,7 @@ struct hd_struct *add_partition(struct gendisk *disk, int partno, queue_limit_discard_alignment(&disk->queue->limits, start); p->nr_sects = len; p->partno = partno; - p->policy = get_disk_ro(disk); + p->read_only = get_disk_ro(disk); if (info) { struct partition_meta_info *pinfo = alloc_part_info(disk); diff --git a/include/linux/genhd.h b/include/linux/genhd.h index 06c0fd594097..3ebd94f520cc 100644 --- a/include/linux/genhd.h +++ b/include/linux/genhd.h @@ -118,7 +118,8 @@ struct hd_struct { unsigned int discard_alignment; struct device __dev; struct kobject *holder_dir; - int policy, partno; + bool read_only, ro_policy; + int partno; struct partition_meta_info *info; #ifdef CONFIG_FAIL_MAKE_REQUEST int make_it_fail; @@ -183,6 +184,7 @@ struct gendisk { char disk_name[DISK_NAME_LEN]; /* name of major driver */ char *(*devnode)(struct gendisk *gd, umode_t *mode); + bool read_only; /* device read-only state */ unsigned int events; /* supported events */ unsigned int async_events; /* async events, subset of all */ @@ -431,12 +433,12 @@ extern void del_gendisk(struct gendisk *gp); extern struct gendisk *get_gendisk(dev_t dev, int *partno); extern struct block_device *bdget_disk(struct gendisk *disk, int partno); -extern void set_device_ro(struct block_device *bdev, int flag); -extern void set_disk_ro(struct gendisk *disk, int flag); +extern void set_device_ro(struct block_device *bdev, bool state); +extern void set_disk_ro(struct gendisk *disk, bool state); static inline int get_disk_ro(struct gendisk *disk) { - return disk->part0.policy; + return disk->part0.read_only; } extern void disk_block_events(struct gendisk *disk); -- 2.21.0

5 years, 12 months

2
1
0 0

[PATCH v4] fs/ocfs2: fix race in ocfs2_dentry_attach_lock

by Wengang Wang

ocfs2_dentry_attach_lock() can be executed in parallel threads against the same dentry. Make that race safe. The race is like this: thread A thread B (A1) enter ocfs2_dentry_attach_lock, seeing dentry->d_fsdata is NULL, and no alias found by ocfs2_find_local_alias, so kmalloc a new ocfs2_dentry_lock structure to local variable "dl", dl1 ..... (B1) enter ocfs2_dentry_attach_lock, seeing dentry->d_fsdata is NULL, and no alias found by ocfs2_find_local_alias so kmalloc a new ocfs2_dentry_lock structure to local variable "dl", dl2. ...... (A2) set dentry->d_fsdata with dl1, call ocfs2_dentry_lock() and increase dl1->dl_lockres.l_ro_holders to 1 on success. ...... (B2) set dentry->d_fsdata with dl2 call ocfs2_dentry_lock() and increase dl2->dl_lockres.l_ro_holders to 1 on success. ...... (A3) call ocfs2_dentry_unlock() and decrease dl2->dl_lockres.l_ro_holders to 0 on success. .... (B3) call ocfs2_dentry_unlock(), decreasing dl2->dl_lockres.l_ro_holders, but see it's zero now, panic Signed-off-by: Wengang Wang <wen.gang.wang(a)oracle.com> Reported-by: Daniel Sobe <daniel.sobe(a)nxp.com> Tested-by: Daniel Sobe <daniel.sobe(a)nxp.com> Reviewed-by: Changwei Ge <gechangwei(a)live.cn> --- v4: return in place on race detection. v3: add Reviewed-by, Reported-by and Tested-by only v2: 1) removed lock on dentry_attach_lock at the first access of dentry->d_fsdata since it helps very little. 2) do cleanups before freeing the duplicated dl 3) return after freeing the duplicated dl found. --- fs/ocfs2/dcache.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/fs/ocfs2/dcache.c b/fs/ocfs2/dcache.c index 290373024d9d..e8ace3b54e9c 100644 --- a/fs/ocfs2/dcache.c +++ b/fs/ocfs2/dcache.c @@ -310,6 +310,18 @@ int ocfs2_dentry_attach_lock(struct dentry *dentry, out_attach: spin_lock(&dentry_attach_lock); + if (unlikely(dentry->d_fsdata && !alias)) { + /* d_fsdata is set by a racing thread which is doing + * the same thing as this thread is doing. Leave the racing + * thread going ahead and we return here. + */ + spin_unlock(&dentry_attach_lock); + iput(dl->dl_inode); + ocfs2_lock_res_free(&dl->dl_lockres); + kfree(dl); + return 0; + } + dentry->d_fsdata = dl; dl->dl_count++; spin_unlock(&dentry_attach_lock); -- 2.13.6

5 years, 12 months

3
2
0 0

Linux 3.18 no longer boots under Xen, Xen CI dropping it

by Ian Jackson

Linux 3.18 no longer boots under Xen. This has been true for over half a year. The Xen project CI has been sending automatic mails including bisection reports (see below). I emailed Xen kernel folks and got no takers for fixing this. Unless this is fixed soon, or at least someone shows some inclination to investigate this regression, I intend to drop all testing of this "stable" branch. It has rotted and no-one is fixing it. > >> > *** Found and reproduced problem changeset *** > >> > > >> > Bug is in tree: linux > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git > >> > Bug introduced: 6b1ae527b1fdee86e81da0cb26ced75731c6c0fa > >> > Bug not present: ba6984fc0162f24a510ebc34e881b546b69c553b > >> > Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/136574/ > > > > It seems that there is something wrong with the IGB driver. Additionally, Jan Beulich writes: > Which in turn reminds me of a patch of mine that was backported > (and spotted by an earlier bisection), and that I've suggested > (twice already iirc) was either backported in error, or without some > further necessary changes. Iirc the stable tree maintainer for that > branch was Cc-ed back then, and if so I'd conclude he doesn't care. Thanks, Ian.

5 years, 12 months

3
2
0 0

[PATCH] Tools: turbostat. Build Failure. Both -4.4.180 & -4.9.179

by Alan Bartlett

[Please CC me, as I am not subscribed to the list.] Attempting to build the tools/power/x86/turbostat/ binary fails: [linux-4.4.180]$ make -C tools/power/x86/turbostat/ make: Entering directory `/linux-stable/linux-4.4.180/tools/power/x86/turbostat' gcc -Wall -I../../../include -DMSRHEADER='"../../../../arch/x86/include/asm/msr-index.h"' turbostat.c -o /linux-stable/linux-4.4.180/tools/power/x86/turbostat/turbostat In file included from turbostat.c:23:0: ../../../../arch/x86/include/asm/msr-index.h:4:24: fatal error: linux/bits.h: No such file or directory #include <linux/bits.h> ^ compilation terminated. make: *** [turbostat] Error 1 make: Leaving directory `/linux-stable/linux-4.4.180/tools/power/x86/turbostat' [linux-4.4.180]$ A bisection showed: 683f9fba8c27817b6c2f7320a4095ca353022651 is the first bad commit commit 683f9fba8c27817b6c2f7320a4095ca353022651 Author: Thomas Gleixner <tglx(a)linutronix.de> Date: Thu Feb 21 12:36:50 2019 +0100 x86/msr-index: Cleanup bit defines commit d8eabc37310a92df40d07c5a8afc53cebf996716 upstream. Greg pointed out that speculation related bit defines are using (1 << N) format instead of BIT(N). Aside of that (1 << N) is wrong as it should use 1UL at least. Clean it up. [ Josh Poimboeuf: Fix tools build ] Reported-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de> Reviewed-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Reviewed-by: Borislav Petkov <bp(a)suse.de> Reviewed-by: Frederic Weisbecker <frederic(a)kernel.org> Reviewed-by: Jon Masters <jcm(a)redhat.com> Tested-by: Jon Masters <jcm(a)redhat.com> [bwh: Backported to 4.4: - Drop change to x86_energy_perf_policy, which doesn't use msr-index.h here - Drop changes to flush MSRs which we haven't defined] Signed-off-by: Ben Hutchings <ben(a)decadent.org.uk> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> :040000 040000 0ce430a14e73eef1007bf1558693e75e95ffe39a 3ab5675ed0798fc61e7d67ade87ac58dbbf33756 M arch :040000 040000 d45f1a90570a44d8924711e56280cde7041328de c603a03d7801225fb15869d1386224f793f1ba1d M tools Fix by modifying the turbostat/Makefile CFLAGS and one #include line of the turbostat.c file. Signed-off-by: Alan Bartlett <ajb(a)elrepo.org> Tested-by: Akemi Yagi <toracat(a)elrepo.org> Reviewed-by: Philip J Perry <phil(a)elrepo.org> --- diff -Npru a/tools/power/x86/turbostat/Makefile b/tools/power/x86/turbostat/Makefile --- a/tools/power/x86/turbostat/Makefile 2019-05-16 13:45:18.000000000 -0400 +++ b/tools/power/x86/turbostat/Makefile 2019-05-21 10:19:21.580477034 -0400 @@ -8,8 +8,7 @@ ifeq ("$(origin O)", "command line") endif turbostat : turbostat.c -CFLAGS += -Wall -I../../../include -CFLAGS += -DMSRHEADER='"../../../../arch/x86/include/asm/msr-index.h"' +CFLAGS += -Wall %: %.c @mkdir -p $(BUILD_OUTPUT) diff -Npru a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c --- a/tools/power/x86/turbostat/turbostat.c 2019-05-16 13:45:18.000000000 -0400 +++ b/tools/power/x86/turbostat/turbostat.c 2019-05-21 10:29:58.007236178 -0400 @@ -20,7 +20,7 @@ */ #define _GNU_SOURCE -#include MSRHEADER +#include <asm/msr-index.h> #include <stdarg.h> #include <stdio.h> #include <err.h>

5 years, 12 months

1
0
0 0

Re: [REVIEW][PATCH 01/26] signal: Correct namespace fixups of si_pid and si_uid

by ebiederm＠xmission.com

Sasha Levin <sashal(a)kernel.org> writes: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: 6588c1e3ff014 signals: SI_USER: Masquerade si_pid when crossing pid ns boundary. > > The bot has tested the following trees: v5.1.4, v5.0.18, v4.19.45, v4.14.121, v4.9.178, v4.4.180, v3.18.140. > > v5.1.4: Build OK! > v5.0.18: Build OK! > v4.19.45: Failed to apply! Possible dependencies: > 4cd2e0e70af68 ("signal: Introduce copy_siginfo_from_user and use it's return value") > ae7795bc6187a ("signal: Distinguish between kernel_siginfo and siginfo") > efc463adbccf7 ("signal: Simplify tracehook_report_syscall_exit") > > v4.14.121: Failed to apply! Possible dependencies: > 212a36a17efe4 ("signal: Unify and correct copy_siginfo_from_user32") > 3eb0f5193b497 ("signal: Ensure every siginfo we send has all bits initialized") > 3f7c86b2382ea ("arm64: Update fault_info table with new exception types") > 526c3ddb6aa27 ("signal/arm64: Document conflicts with SI_USER and SIGFPE,SIGTRAP,SIGBUS") > 532826f3712b6 ("arm64: Mirror arm for unimplemented compat syscalls") > 6b4f3d01052a4 ("usb, signal, security: only pass the cred, not the secid, to kill_pid_info_as_cred and security_task_kill") > 92ff0674f5d80 ("arm64: mm: Rework unhandled user pagefaults to call arm64_force_sig_info") > ae7795bc6187a ("signal: Distinguish between kernel_siginfo and siginfo") > af40ff687bc9d ("arm64: signal: Ensure si_code is valid for all fault signals") > b713da69e4c91 ("signal: unify compat_siginfo_t") > ea64d5acc8f03 ("signal: Unify and correct copy_siginfo_to_user32") > efc463adbccf7 ("signal: Simplify tracehook_report_syscall_exit") > > v4.9.178: Failed to apply! Possible dependencies: > 359566faefa85 ("kernel_wait4()/kernel_waitid(): delay copying status to userland") > 4c48abe91be03 ("waitid(): switch copyout of siginfo to unsafe_put_user()") > 4e2648db9c5f7 ("ARM: remove indirection of asm/mach-types.h") > 4f4ddad395b04 ("nios2: put setup.h in uapi") > 53d3eaa315082 ("posix_cpu_timers: Move the add_device_randomness() call to a proper place") > 67d7ddded322d ("waitid(2): leave copyout of siginfo to syscall itself") > 6bc51cbaa9d75 ("signal: Remove non-uapi <asm/siginfo.h>") > 7e95a225901a5 ("move compat wait4 and waitid next to native variants") > 80dce5e374930 ("signal/ia64: Document a conflict with SI_USER with SIGFPE") > 8f95c90ceb541 ("sched/wait, RCU: Introduce rcuwait machinery") > 96a8fae0fe094 ("ARM: convert to generated system call tables") > ae7795bc6187a ("signal: Distinguish between kernel_siginfo and siginfo") > b9253a43370e8 ("signal: Move copy_siginfo_to_user to <linux/signal.h>") > cc731525f26af ("signal: Remove kernel interal si_code magic") > cc9f72e474a4d ("signal/sparc: Document a conflict with SI_USER with SIGFPE") > ce72a16fa705f ("wait4(2)/waitid(2): separate copying rusage to userland") > d08477aa975e9 ("fcntl: Don't use ambiguous SIG_POLL si_codes") > e2bd64d92a10f ("signal/alpha: Document a conflict with SI_USER for SIGTRAP") > ea1b75cf91380 ("signal/mips: Document a conflict with SI_USER with SIGFPE") > ea64d5acc8f03 ("signal: Unify and correct copy_siginfo_to_user32") > > v4.4.180: Failed to apply! Possible dependencies: > 2b5e869ecfcb3 ("MIPS: ELF: Interpret the NAN2008 file header flag") > 4f4acc9472e54 ("parisc: Fix SIGSYS signals in compat case") > 5050e91fa650e ("MIPS: Support sending SIG_SYS to 32bit userspace from 64bit kernel") > 5fa393c857195 ("MIPS: Break down cacheops.h definitions") > 6846351052e68 ("x86/signal: Add SA_{X32,IA32}_ABI sa_flags") > 694977006a7ba ("MIPS: Use enums to make asm/pgtable-bits.h readable") > 745f355878462 ("MIPS: mm: Unify pte_page definition") > 780602d740fc0 ("MIPS: mm: Standardise on _PAGE_NO_READ, drop _PAGE_READ") > 7939469da29a8 ("MIPS64: signal: Fix o32 sigaction syscall") > 7b2cb64f91f25 ("MIPS: mm: Fix MIPS32 36b physical addressing (alchemy, netlogic)") > 80dce5e374930 ("signal/ia64: Document a conflict with SI_USER with SIGFPE") > 97f2645f358b4 ("tree-wide: replace config_enabled() with IS_ENABLED()") > a4455082dc6f0 ("x86/signals: Add missing signal_compat code for x86 features") > a60ae81e5e591 ("MIPS: CM: Fix mips_cm_max_vp_width for UP kernels") > ae7795bc6187a ("signal: Distinguish between kernel_siginfo and siginfo") > b1b4fad5cc678 ("MIPS: seccomp: Support compat with both O32 and N32") > b27873702b060 ("mips, thp: remove infrastructure for handling splitting PMDs") > b2edcfc814017 ("MIPS: Loongson: Add Loongson-3A R2 basic support") > cc731525f26af ("signal: Remove kernel interal si_code magic") > cc9f72e474a4d ("signal/sparc: Document a conflict with SI_USER with SIGFPE") > e2bd64d92a10f ("signal/alpha: Document a conflict with SI_USER for SIGTRAP") > ea1b75cf91380 ("signal/mips: Document a conflict with SI_USER with SIGFPE") > ea64d5acc8f03 ("signal: Unify and correct copy_siginfo_to_user32") > > v3.18.140: Failed to apply! Possible dependencies: > 1a3d59579b9f4 ("MIPS: Tidy up FPU context switching") > 304acb717e5b6 ("MIPS: Set `si_code' for SIGFPE signals sent from emulation too") > 4227a2d4efc9c ("MIPS: Support for hybrid FPRs") > 443c44032a54f ("MIPS: Always clear FCSR cause bits after emulation") > 4a7c2371823a4 ("MIPS: Reindent R6 RI exception emulation") > 53f037b08b5be ("ia64: Sync struct siginfo with general version") > 5a1aca4469fdc ("MIPS: Fix FCSR Cause bit handling for correct SIGFPE issue") > 5f9f41c474bef ("MIPS: kernel: Prepare the JR instruction for emulation on MIPS R6") > 7c151d3d5d7a0 ("MIPS: Make use of the ERETNC instruction on MIPS R6") > 80dce5e374930 ("signal/ia64: Document a conflict with SI_USER with SIGFPE") > 9cc719ab3f4f6 ("MIPS: MSA: bugfix - disable MSA correctly for new threads/processes.") > ae7795bc6187a ("signal: Distinguish between kernel_siginfo and siginfo") > b0a668fb2038d ("MIPS: kernel: mips-r2-to-r6-emul: Add R2 emulator for MIPS R6") > cc5e9097c9aad ("arm64: add SIGSYS siginfo for compat task") > cc731525f26af ("signal: Remove kernel interal si_code magic") > e2bd64d92a10f ("signal/alpha: Document a conflict with SI_USER for SIGTRAP") > ea1b75cf91380 ("signal/mips: Document a conflict with SI_USER with SIGFPE") > ea64d5acc8f03 ("signal: Unify and correct copy_siginfo_to_user32") > ed2d72c1eb364 ("MIPS: Respect the FCSR exception mask for `si_code'") > f51246efee2b6 ("MIPS: Get rid of finish_arch_switch().") > fad0bfdb893ac ("MIPS: mips-r2-to-r6-emul.h: Inline empty `mipsr2_decoder'") > > > How should we proceed with this patch? I have not had any reports of anyone having problems, and this only triggers when signals traverse a pid or a user namespace boundary. So while this is indeed a fix I think the usual best effort backport will be fine. If backporting further is desired it looks like the only real dependency is the addition of the function siginfo_layout. So it should not be as difficult as the automated scripts suggests. Eric

5 years, 12 months

1
0
0 0

Re: [PATCH] binfmt_flat: make load_flat_shared_library() work

by Jann Horn

On Wed, May 29, 2019 at 3:15 PM Sasha Levin <sashal(a)kernel.org> wrote: > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: 287980e49ffc0 remove lots of IS_ERR_VALUE abuses. > > The bot has tested the following trees: v5.1.4, v5.0.18, v4.19.45, v4.14.121, v4.9.178. > > v5.1.4: Build OK! > v5.0.18: Build OK! > v4.19.45: Build OK! > v4.14.121: Build OK! > v4.9.178: Failed to apply! Possible dependencies: [...] > ddb4a1442def2 ("exec: Rename bprm->cred_prepared to called_set_creds") [...] > How should we proceed with this patch? I think the dependency is on ddb4a1442def2; but the simplest way is probably to manually adjust the fix, it's basically the same in 4.9.

5 years, 12 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror