- Linux-stable-mirror - lists.linaro.org

FAILED: patch "[PATCH] NFC: nfcmrvl_uart: fix OF child-node lookup" failed to apply to 4.14-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.14-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 5bf59773aaf36dd62117dc83d50e1bbf9ef432da Mon Sep 17 00:00:00 2001 From: Johan Hovold <johan(a)kernel.org> Date: Mon, 27 Aug 2018 10:21:52 +0200 Subject: [PATCH] NFC: nfcmrvl_uart: fix OF child-node lookup Use the new of_get_compatible_child() helper to lookup the nfc child node instead of using of_find_compatible_node(), which searches the entire tree from a given start node and thus can return an unrelated (i.e. non-child) node. This also addresses a potential use-after-free (e.g. after probe deferral) as the tree-wide helper drops a reference to its first argument (i.e. the parent node). Fixes: e097dc624f78 ("NFC: nfcmrvl: add UART driver") Fixes: d8e018c0b321 ("NFC: nfcmrvl: update device tree bindings for Marvell NFC") Cc: stable <stable(a)vger.kernel.org> # 4.2 Cc: Vincent Cuissard <cuissard(a)marvell.com> Cc: Samuel Ortiz <sameo(a)linux.intel.com> Signed-off-by: Johan Hovold <johan(a)kernel.org> Signed-off-by: Rob Herring <robh(a)kernel.org> diff --git a/drivers/nfc/nfcmrvl/uart.c b/drivers/nfc/nfcmrvl/uart.c index 91162f8e0366..9a22056e8d9e 100644 --- a/drivers/nfc/nfcmrvl/uart.c +++ b/drivers/nfc/nfcmrvl/uart.c @@ -73,10 +73,9 @@ static int nfcmrvl_uart_parse_dt(struct device_node *node, struct device_node *matched_node; int ret; - matched_node = of_find_compatible_node(node, NULL, "marvell,nfc-uart"); + matched_node = of_get_compatible_child(node, "marvell,nfc-uart"); if (!matched_node) { - matched_node = of_find_compatible_node(node, NULL, - "mrvl,nfc-uart"); + matched_node = of_get_compatible_child(node, "mrvl,nfc-uart"); if (!matched_node) return -ENODEV; }

6 years, 9 months

3
2
0 0

FAILED: patch "[PATCH] net: bcmgenet: fix OF child-node lookup" failed to apply to 4.14-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.14-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From d397dbe606120a1ea1b11b0020c3f7a3852da5ac Mon Sep 17 00:00:00 2001 From: Johan Hovold <johan(a)kernel.org> Date: Mon, 27 Aug 2018 10:21:50 +0200 Subject: [PATCH] net: bcmgenet: fix OF child-node lookup Use the new of_get_compatible_child() helper to lookup the mdio child node instead of using of_find_compatible_node(), which searches the entire tree from a given start node and thus can return an unrelated (i.e. non-child) node. This also addresses a potential use-after-free (e.g. after probe deferral) as the tree-wide helper drops a reference to its first argument (i.e. the node of the device being probed). Fixes: aa09677cba42 ("net: bcmgenet: add MDIO routines") Cc: stable <stable(a)vger.kernel.org> # 3.15 Cc: David S. Miller <davem(a)davemloft.net> Reviewed-by: Florian Fainelli <f.fainelli(a)gmail.com> Signed-off-by: Johan Hovold <johan(a)kernel.org> Signed-off-by: Rob Herring <robh(a)kernel.org> diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c index 5333274a283c..87fc65560ceb 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c @@ -333,7 +333,7 @@ static struct device_node *bcmgenet_mii_of_find_mdio(struct bcmgenet_priv *priv) if (!compat) return NULL; - priv->mdio_dn = of_find_compatible_node(dn, NULL, compat); + priv->mdio_dn = of_get_compatible_child(dn, compat); kfree(compat); if (!priv->mdio_dn) { dev_err(kdev, "unable to find MDIO bus node\n");

6 years, 9 months

3
2
0 0

FAILED: patch "[PATCH] net: bcmgenet: fix OF child-node lookup" failed to apply to 4.4-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From d397dbe606120a1ea1b11b0020c3f7a3852da5ac Mon Sep 17 00:00:00 2001 From: Johan Hovold <johan(a)kernel.org> Date: Mon, 27 Aug 2018 10:21:50 +0200 Subject: [PATCH] net: bcmgenet: fix OF child-node lookup Use the new of_get_compatible_child() helper to lookup the mdio child node instead of using of_find_compatible_node(), which searches the entire tree from a given start node and thus can return an unrelated (i.e. non-child) node. This also addresses a potential use-after-free (e.g. after probe deferral) as the tree-wide helper drops a reference to its first argument (i.e. the node of the device being probed). Fixes: aa09677cba42 ("net: bcmgenet: add MDIO routines") Cc: stable <stable(a)vger.kernel.org> # 3.15 Cc: David S. Miller <davem(a)davemloft.net> Reviewed-by: Florian Fainelli <f.fainelli(a)gmail.com> Signed-off-by: Johan Hovold <johan(a)kernel.org> Signed-off-by: Rob Herring <robh(a)kernel.org> diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c index 5333274a283c..87fc65560ceb 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c @@ -333,7 +333,7 @@ static struct device_node *bcmgenet_mii_of_find_mdio(struct bcmgenet_priv *priv) if (!compat) return NULL; - priv->mdio_dn = of_find_compatible_node(dn, NULL, compat); + priv->mdio_dn = of_get_compatible_child(dn, compat); kfree(compat); if (!priv->mdio_dn) { dev_err(kdev, "unable to find MDIO bus node\n");

6 years, 9 months

3
2
0 0

FAILED: patch "[PATCH] net: bcmgenet: fix OF child-node lookup" failed to apply to 4.9-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.9-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From d397dbe606120a1ea1b11b0020c3f7a3852da5ac Mon Sep 17 00:00:00 2001 From: Johan Hovold <johan(a)kernel.org> Date: Mon, 27 Aug 2018 10:21:50 +0200 Subject: [PATCH] net: bcmgenet: fix OF child-node lookup Use the new of_get_compatible_child() helper to lookup the mdio child node instead of using of_find_compatible_node(), which searches the entire tree from a given start node and thus can return an unrelated (i.e. non-child) node. This also addresses a potential use-after-free (e.g. after probe deferral) as the tree-wide helper drops a reference to its first argument (i.e. the node of the device being probed). Fixes: aa09677cba42 ("net: bcmgenet: add MDIO routines") Cc: stable <stable(a)vger.kernel.org> # 3.15 Cc: David S. Miller <davem(a)davemloft.net> Reviewed-by: Florian Fainelli <f.fainelli(a)gmail.com> Signed-off-by: Johan Hovold <johan(a)kernel.org> Signed-off-by: Rob Herring <robh(a)kernel.org> diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c index 5333274a283c..87fc65560ceb 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c @@ -333,7 +333,7 @@ static struct device_node *bcmgenet_mii_of_find_mdio(struct bcmgenet_priv *priv) if (!compat) return NULL; - priv->mdio_dn = of_find_compatible_node(dn, NULL, compat); + priv->mdio_dn = of_get_compatible_child(dn, compat); kfree(compat); if (!priv->mdio_dn) { dev_err(kdev, "unable to find MDIO bus node\n");

6 years, 9 months

3
2
0 0

FAILED: patch "[PATCH] NFC: nfcmrvl_uart: fix OF child-node lookup" failed to apply to 4.9-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.9-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 5bf59773aaf36dd62117dc83d50e1bbf9ef432da Mon Sep 17 00:00:00 2001 From: Johan Hovold <johan(a)kernel.org> Date: Mon, 27 Aug 2018 10:21:52 +0200 Subject: [PATCH] NFC: nfcmrvl_uart: fix OF child-node lookup Use the new of_get_compatible_child() helper to lookup the nfc child node instead of using of_find_compatible_node(), which searches the entire tree from a given start node and thus can return an unrelated (i.e. non-child) node. This also addresses a potential use-after-free (e.g. after probe deferral) as the tree-wide helper drops a reference to its first argument (i.e. the parent node). Fixes: e097dc624f78 ("NFC: nfcmrvl: add UART driver") Fixes: d8e018c0b321 ("NFC: nfcmrvl: update device tree bindings for Marvell NFC") Cc: stable <stable(a)vger.kernel.org> # 4.2 Cc: Vincent Cuissard <cuissard(a)marvell.com> Cc: Samuel Ortiz <sameo(a)linux.intel.com> Signed-off-by: Johan Hovold <johan(a)kernel.org> Signed-off-by: Rob Herring <robh(a)kernel.org> diff --git a/drivers/nfc/nfcmrvl/uart.c b/drivers/nfc/nfcmrvl/uart.c index 91162f8e0366..9a22056e8d9e 100644 --- a/drivers/nfc/nfcmrvl/uart.c +++ b/drivers/nfc/nfcmrvl/uart.c @@ -73,10 +73,9 @@ static int nfcmrvl_uart_parse_dt(struct device_node *node, struct device_node *matched_node; int ret; - matched_node = of_find_compatible_node(node, NULL, "marvell,nfc-uart"); + matched_node = of_get_compatible_child(node, "marvell,nfc-uart"); if (!matched_node) { - matched_node = of_find_compatible_node(node, NULL, - "mrvl,nfc-uart"); + matched_node = of_get_compatible_child(node, "mrvl,nfc-uart"); if (!matched_node) return -ENODEV; }

6 years, 9 months

3
2
0 0

[PATCH for-3.18.y 0/5] Stable candidates for linux-3.18.y

by Amit Pundir

Hi Greg, Few stable candidates for 3.18.y for your consideration. Cherry picked and build tested on linux-3.18.127 for ARCH=arm/arm64 + allmodconfig. Regards, Amit Pundir Johannes Thumshirn (1): cw1200: Don't leak memory if krealloc failes Mauricio Faria de Oliveira (1): scsi: qla2xxx: do not queue commands when unloading Subhash Jadavani (1): scsi: ufs: fix race between clock gating and devfreq scaling work Venkat Gopalakrishnan (1): scsi: ufshcd: Fix race between clk scaling and ungate work Yaniv Gardi (1): scsi: ufs: fix bugs related to null pointer access and array size drivers/net/wireless/cw1200/wsm.c | 16 +++++---- drivers/net/wireless/mwifiex/pcie.c | 9 +++-- drivers/scsi/qla2xxx/qla_os.c | 14 ++++++++ drivers/scsi/ufs/ufs.h | 3 +- drivers/scsi/ufs/ufshcd.c | 72 +++++++++++++++++++++++++++++++++---- 5 files changed, 97 insertions(+), 17 deletions(-) -- 2.7.4

6 years, 9 months

1
5
0 0

FAILED: patch "[PATCH] NFC: nfcmrvl_uart: fix OF child-node lookup" failed to apply to 4.4-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 5bf59773aaf36dd62117dc83d50e1bbf9ef432da Mon Sep 17 00:00:00 2001 From: Johan Hovold <johan(a)kernel.org> Date: Mon, 27 Aug 2018 10:21:52 +0200 Subject: [PATCH] NFC: nfcmrvl_uart: fix OF child-node lookup Use the new of_get_compatible_child() helper to lookup the nfc child node instead of using of_find_compatible_node(), which searches the entire tree from a given start node and thus can return an unrelated (i.e. non-child) node. This also addresses a potential use-after-free (e.g. after probe deferral) as the tree-wide helper drops a reference to its first argument (i.e. the parent node). Fixes: e097dc624f78 ("NFC: nfcmrvl: add UART driver") Fixes: d8e018c0b321 ("NFC: nfcmrvl: update device tree bindings for Marvell NFC") Cc: stable <stable(a)vger.kernel.org> # 4.2 Cc: Vincent Cuissard <cuissard(a)marvell.com> Cc: Samuel Ortiz <sameo(a)linux.intel.com> Signed-off-by: Johan Hovold <johan(a)kernel.org> Signed-off-by: Rob Herring <robh(a)kernel.org> diff --git a/drivers/nfc/nfcmrvl/uart.c b/drivers/nfc/nfcmrvl/uart.c index 91162f8e0366..9a22056e8d9e 100644 --- a/drivers/nfc/nfcmrvl/uart.c +++ b/drivers/nfc/nfcmrvl/uart.c @@ -73,10 +73,9 @@ static int nfcmrvl_uart_parse_dt(struct device_node *node, struct device_node *matched_node; int ret; - matched_node = of_find_compatible_node(node, NULL, "marvell,nfc-uart"); + matched_node = of_get_compatible_child(node, "marvell,nfc-uart"); if (!matched_node) { - matched_node = of_find_compatible_node(node, NULL, - "mrvl,nfc-uart"); + matched_node = of_get_compatible_child(node, "mrvl,nfc-uart"); if (!matched_node) return -ENODEV; }

6 years, 9 months

3
2
0 0

Re: NULL pointer dereference in smb2_queryfs with v4.19.2

by Steve French

At first glance it looks like it is missing from the 4.19 stable tree On Tue, Nov 20, 2018 at 2:14 PM Steve French <smfrench(a)gmail.com> wrote: > > Do you know if you are running with this patch (which was marked for stable) > > commit 32a1fb36f6e50183871c2c1fcf5493c633e84732 > Author: Ronnie Sahlberg <lsahlber(a)redhat.com> > Date: Wed Oct 24 11:50:33 2018 +1000 > > cifs: allow calling SMB2_xxx_free(NULL) > > Change these free functions to allow passing NULL as the argument and > treat it as a no-op just like free(NULL) would. > Or, if rqst->rq_iov is NULL. > > The second scenario could happen for smb2_queryfs() if the call > to SMB2_query_info_init() fails and we go to qfs_exit to clean up > and free all resources. > In that case we have not yet assigned rqst[2].rq_iov and thus > the rq_iov dereference in SMB2_close_free() will cause a NULL pointer > dereference. > > Fixes: 1eb9fb52040f ("cifs: create SMB2_open_init()/SMB2_open_free() helper > s") > > Signed-off-by: Ronnie Sahlberg <lsahlber(a)redhat.com> > Signed-off-by: Steve French <stfrench(a)microsoft.com> > Reviewed-by: Aurelien Aptel <aaptel(a)suse.com> > CC: Stable <stable(a)vger.kernel.org> > On Tue, Nov 20, 2018 at 9:38 AM Stijn Tintel <stijn(a)linux-ipv6.be> wrote: > > > > Hi, > > > > My machine just rebooted after the connection to the Samba server > > hosting a CIFS mount was lost. Kernel version 4.19.2. The oops was > > recorded in pstore: > > > > <3>[533816.847894] CIFS VFS: Server store has not responded in 120 > > seconds. Reconnecting... > > <1>[533925.390079] BUG: unable to handle kernel NULL pointer dereference > > at 0000000000000000 > > <6>[533925.390082] PGD 0 P4D 0 > > <4>[533925.390085] Oops: 0000 [#1] PREEMPT SMP PTI > > <4>[533925.390087] CPU: 1 PID: 30794 Comm: sadc Tainted: P > > O 4.19.2-gentoo #1 > > <4>[533925.390088] Hardware name: System manufacturer System Product > > Name/P9X79 WS, BIOS 4802 06/02/2015 > > <4>[533925.390099] RIP: 0010:SMB2_close_free+0x8/0x10 [cifs] > > <4>[533925.390100] Code: 65 48 33 1c 25 28 00 00 00 75 09 48 83 c4 18 5b > > 5d 41 5c c3 e8 89 ac 29 e0 66 0f 1f 84 00 00 00 00 00 66 66 66 66 90 48 > > 8b 07 <48> 8b 38 e9 50 8d fe ff 66 66 66 66 90 4c 8d 54 24 08 48 83 e4 f0 > > <4>[533925.390101] RSP: 0018:ffffc9002c2dfbb8 EFLAGS: 00010246 > > <4>[533925.390102] RAX: 0000000000000000 RBX: ffff880fae7e5800 RCX: > > 0000000000000000 > > <4>[533925.390104] RDX: ffff880fdf521180 RSI: 0000000000000206 RDI: > > ffffc9002c2dfd68 > > <4>[533925.390105] RBP: ffffc9002c2dfdf0 R08: 0000000000000000 R09: > > 00000000002503ee > > <4>[533925.390106] R10: ffffc9002c2dfbc0 R11: 00000000000f4240 R12: > > ffffc9002c2dfc50 > > <4>[533925.390107] R13: ffff880fad03a200 R14: ffff880fdf521000 R15: > > 0000000000000000 > > <4>[533925.390108] FS: 00007fb5cff85740(0000) GS:ffff88100f840000(0000) > > knlGS:0000000000000000 > > <4>[533925.390109] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > <4>[533925.390110] CR2: 0000000000000000 CR3: 0000000118d32001 CR4: > > 00000000000626e0 > > <4>[533925.390111] Call Trace: > > <4>[533925.390119] smb2_queryfs+0x162/0x360 [cifs] > > <4>[533925.390124] ? lookup_fast+0xc8/0x2d0 > > <4>[533925.390126] ? legitimize_path.isra.8+0x28/0x50 > > <4>[533925.390127] ? __vfs_getxattr+0x2a/0x70 > > <4>[533925.390130] ? get_vfs_caps_from_disk+0x65/0x170 > > <4>[533925.390135] ? cifs_statfs+0x97/0x1f0 [cifs] > > <4>[533925.390140] ? smb2_set_next_command+0x60/0x60 [cifs] > > <4>[533925.390144] cifs_statfs+0x97/0x1f0 [cifs] > > <4>[533925.390147] statfs_by_dentry+0x42/0x60 > > <4>[533925.390148] vfs_statfs+0x16/0xc0 > > <4>[533925.390150] user_statfs+0x54/0xa0 > > <4>[533925.390151] __se_sys_statfs+0x25/0x60 > > <4>[533925.390153] do_syscall_64+0x5c/0x160 > > <4>[533925.390156] entry_SYSCALL_64_after_hwframe+0x44/0xa9 > > <4>[533925.390158] RIP: 0033:0x7fb5cf8ca467 > > <4>[533925.390159] Code: 2c 00 64 c7 00 16 00 00 00 b8 ff ff ff ff eb b8 > > e8 6e 4f 02 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 b8 89 00 00 00 > > 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d f1 e9 2c 00 f7 d8 64 89 01 48 > > <4>[533925.390160] RSP: 002b:00007ffc47a0c7f8 EFLAGS: 00000246 ORIG_RAX: > > 0000000000000089 > > <4>[533925.390162] RAX: ffffffffffffffda RBX: 00007ffc47a0c9a0 RCX: > > 00007fb5cf8ca467 > > <4>[533925.390163] RDX: 00007ffc47a0c9a9 RSI: 00007ffc47a0c800 RDI: > > 00007ffc47a0c9a0 > > <4>[533925.390164] RBP: 00007ffc47a0c800 R08: 0000000000000000 R09: > > 000000000000000d > > <4>[533925.390165] R10: 00007fb5cfb9a560 R11: 0000000000000246 R12: > > 00007ffc47a0c8b0 > > <4>[533925.390166] R13: 000000000000000b R14: 0000561829c584d4 R15: > > 00007ffc47a0c920 > > <4>[533925.390167] Modules linked in: xt_nat hfsplus hfs msdos > > nfnetlink_queue nfnetlink_log cp210x usbserial squashfs cfg80211 drbg > > seqiv xfrm6_mode_tunnel xfrm4_mode_tunnel nvidia_uvm(PO) rfcomm > > xt_CHECKSUM iptable_mangle ipt_REJECT nf_reject_ipv4 xt_tcpudp devlink > > ebtable_filter ebtables ip6table_filter ip6_tables ipt_MASQUERADE > > nf_conntrack_netlink nfnetlink iptable_nat xt_addrtype iptable_filter > > ip_tables bpfilter xt_conntrack x_tables br_netfilter bridge stp llc > > arc4 md4 md5 xfrm_user xfrm4_tunnel tunnel4 ipcomp xfrm_ipcomp esp4 ah4 > > af_key cmac xfrm_algo nls_utf8 cifs ccm sctp bnep nvidia_drm(PO) > > algif_skcipher nvidia_modeset(PO) nls_iso8859_1 nls_cp437 vfat fat > > joydev amdkfd iTCO_wdt nvidia(PO) evdev iTCO_vendor_support uinput > > intel_rapl amdgpu snd_hda_codec_realtek x86_pkg_temp_thermal > > intel_powerclamp > > <4>[533925.390197] snd_hda_codec_hdmi snd_hda_codec_generic > > crct10dif_pclmul crc32_pclmul crc32c_intel ghash_clmulni_intel > > snd_usb_audio pcbc snd_hda_intel chash snd_usbmidi_lib aesni_intel > > snd_hda_codec snd_rawmidi gpu_sched snd_seq_device crypto_simd ttm > > snd_hda_core bcache btusb snd_hwdep drm_kms_helper btrtl cryptd snd_pcm > > btbcm uas glue_helper btintel crc64 drm snd_timer intel_cstate bluetooth > > drm_panel_orientation_quirks snd intel_uncore syscopyarea soundcore > > i2c_i801 efi_pstore wmi_bmof intel_rapl_perf efivars sysfillrect e1000e > > ecdh_generic sysimgblt lpc_ich mei_me fb_sys_fops button firewire_ohci > > sch_fq_codel nct6775 hwmon_vid coretemp openvswitch nsh nf_nat_ipv6 > > nf_nat_ipv4 nf_conncount nf_nat nf_conntrack nf_defrag_ipv6 > > nf_defrag_ipv4 vhost_net tun vhost tap kvm_intel kvm irqbypass msr cpuid > > <4>[533925.390226] efivarfs virtio_ring virtio xts aes_x86_64 ecb cbc > > sha1_generic iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi > > bonding vxlan ip6_udp_tunnel udp_tunnel macvlan igb i2c_algo_bit dca > > e1000 fuse overlay nfs lockd grace sunrpc ext4 mbcache jbd2 fscrypto > > multipath linear raid10 raid1 raid0 dm_raid raid456 async_raid6_recov > > async_memcpy async_pq async_xor async_tx md_mod dm_snapshot dm_bufio > > dm_crypt dm_mirror dm_region_hash dm_log dm_mod hid_sony hid_samsung > > hid_petalynx hid_monterey hid_microsoft hid_logitech ff_memless > > hid_gyration hid_ezkey hid_cypress hid_chicony hid_cherry hid_belkin > > hid_apple hid_a4tech hid_generic usbhid ohci_pci ohci_hcd uhci_hcd hid > > arcmsr sr_mod cdrom sg usb_storage xhci_pci ehci_pci xhci_hcd ehci_hcd > > ptp usbcore firewire_core pps_core crc_itu_t usb_common > > <4>[533925.390259] CR2: 0000000000000000 > > <4>[533925.390260] ---[ end trace 66b5055ad278750a ]--- > > > > CIFS kernel options: > > > > CONFIG_CIFS=m > > # CONFIG_CIFS_STATS2 is not set > > # CONFIG_CIFS_ALLOW_INSECURE_LEGACY is not set > > # CONFIG_CIFS_UPCALL is not set > > CONFIG_CIFS_XATTR=y > > CONFIG_CIFS_POSIX=y > > CONFIG_CIFS_ACL=y > > CONFIG_CIFS_DEBUG=y > > # CONFIG_CIFS_DEBUG2 is not set > > # CONFIG_CIFS_DEBUG_DUMP_KEYS is not set > > CONFIG_CIFS_DFS_UPCALL=y > > # CONFIG_CIFS_FSCACHE is not set > > > > Please include me when replying. > > > > Thanks, > > Stijn > > > > > -- > Thanks, > > Steve -- Thanks, Steve

6 years, 9 months

3
4
0 0

[PATCH] IB/core: Fix for core panic

by Mike Marciniszyn

From: Alex Estrin <alex.estrin(a)intel.com> Upstream commit e6f9bc34d3779cb7b6a337afed5de8be3f0fab77. Build with the latest patches resulted in panic: 11384.486289] BUG: unable to handle kernel NULL pointer dereference at (null) [11384.486293] IP: (null) [11384.486295] PGD 0 [11384.486295] P4D 0 [11384.486296] [11384.486299] Oops: 0010 [#1] SMP ......... snip ...... [11384.486401] CPU: 0 PID: 3389 Comm: kworker/0:2H Not tainted 4.9.136 #1 [11384.486402] Hardware name: Intel Corporation S2600WT2R/S2600WT2R, BIOS SE5C610.86B.01.01.0014.121820151719 12/18/2015 [11384.486418] Workqueue: ib-comp-wq ib_cq_poll_work [ib_core] [11384.486419] task: ffff880850579680 task.stack: ffffc90007fec000 [11384.486420] RIP: 0010: (null) [11384.486420] RSP: 0018:ffffc90007fef970 EFLAGS: 00010206 [11384.486421] RAX: ffff88084cfe8000 RBX: ffff88084dce4000 RCX: ffffc90007fef978 [11384.486422] RDX: 0000000000000000 RSI: 0000000000000001 RDI: ffff88084cfe8000 [11384.486422] RBP: ffffc90007fefab0 R08: 0000000000000000 R09: ffff88084dce4080 [11384.486423] R10: ffffffffa02d7f60 R11: 0000000000000000 R12: ffff88105af65a00 [11384.486423] R13: ffff88084dce4000 R14: 000000000000c000 R15: 000000000000c000 [11384.486424] FS: 0000000000000000(0000) GS:ffff88085f400000(0000) knlGS:0000000000000000 [11384.486425] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [11384.486425] CR2: 0000000000000000 CR3: 0000000001c09000 CR4: 00000000001406f0 [11384.486426] Call Trace: [11384.486431] ? is_valid_mcast_lid.isra.21+0xfb/0x110 [ib_core] [11384.486436] ib_attach_mcast+0x6f/0xa0 [ib_core] [11384.486441] ipoib_mcast_attach+0x81/0x190 [ib_ipoib] [11384.486443] ipoib_mcast_join_complete+0x354/0xb40 [ib_ipoib] [11384.486448] mcast_work_handler+0x330/0x6c0 [ib_core] [11384.486452] join_handler+0x101/0x220 [ib_core] [11384.486455] ib_sa_mcmember_rec_callback+0x54/0x80 [ib_core] [11384.486459] recv_handler+0x3a/0x60 [ib_core] [11384.486462] ib_mad_recv_done+0x423/0x9b0 [ib_core] [11384.486466] __ib_process_cq+0x5d/0xb0 [ib_core] [11384.486469] ib_cq_poll_work+0x20/0x60 [ib_core] [11384.486472] process_one_work+0x149/0x360 [11384.486474] worker_thread+0x4d/0x3c0 [11384.486487] kthread+0x109/0x140 [11384.486488] ? rescuer_thread+0x380/0x380 [11384.486489] ? kthread_park+0x60/0x60 [11384.486490] ? kthread_park+0x60/0x60 [11384.486493] ret_from_fork+0x25/0x30 [11384.486493] Code: Bad RIP value. [11384.486493] Code: Bad RIP value. [11384.486496] RIP: (null) RSP: ffffc90007fef970 [11384.486497] CR2: 0000000000000000 [11384.486531] ---[ end trace b1acec6fb4ff6e75 ]--- [11384.532133] Kernel panic - not syncing: Fatal exception [11384.536541] Kernel Offset: disabled [11384.969491] ---[ end Kernel panic - not syncing: Fatal exception [11384.976875] sched: Unexpected reschedule of offline CPU#1! [11384.983646] ------------[ cut here ]------------ Rdma device driver may not have implemented (*get_link_layer)() so it can not be called directly. Should use appropriate helper function. [cherry-picked from the upstream commit] Reviewed-by: Yuval Shaia <yuval.shaia(a)oracle.com> Fixes: 523633359224 ("IB/core: Fix the validations of a multicast LID in attach or detach operations") Cc: stable(a)kernel.org # 4.9 Reviewed-by: Dennis Dalessandro <dennis.dalessandro(a)intel.com> Signed-off-by: Alex Estrin <alex.estrin(a)intel.com> Signed-off-by: Dennis Dalessandro <dennis.dalessandro(a)intel.com> Reviewed-by: Leon Romanovsky <leonro(a)mellanox.com> Signed-off-by: Doug Ledford <dledford(a)redhat.com> --- drivers/infiniband/core/verbs.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c index d28c4cf..dc92dc4 100644 --- a/drivers/infiniband/core/verbs.c +++ b/drivers/infiniband/core/verbs.c @@ -1522,7 +1522,7 @@ static bool is_valid_mcast_lid(struct ib_qp *qp, u16 lid) */ if (!ib_query_qp(qp, &attr, IB_QP_STATE | IB_QP_PORT, &init_attr)) { if (attr.qp_state >= IB_QPS_INIT) { - if (qp->device->get_link_layer(qp->device, attr.port_num) != + if (rdma_port_get_link_layer(qp->device, attr.port_num) != IB_LINK_LAYER_INFINIBAND) return true; goto lid_check; @@ -1531,7 +1531,7 @@ static bool is_valid_mcast_lid(struct ib_qp *qp, u16 lid) /* Can't get a quick answer, iterate over all ports */ for (port = 0; port < qp->device->phys_port_cnt; port++) - if (qp->device->get_link_layer(qp->device, port) != + if (rdma_port_get_link_layer(qp->device, port) != IB_LINK_LAYER_INFINIBAND) num_eth_ports++;

6 years, 9 months

3
2
0 0

[PATCH (backport)] fanotify: fix handling of events on child sub-directory

by Miklos Szeredi

Hi Amir, Here's a backport of this patch to 4.18 and earlier. Tested good with ltp/fanotify09. I didn't quite understand the relevance of masking against ALL_FSNOTIFY_EVENTS in __fsnotify_parent() and the backport in fsnotify() is also not quite trivial. So, can you please review? Thanks, Miklos --- From: Amir Goldstein <amir73il(a)gmail.com> Date: Tue, 30 Oct 2018 20:29:53 +0200 Subject: [PATCH] fanotify: fix handling of events on child sub-directory When an event is reported on a sub-directory and the parent inode has a mark mask with FS_EVENT_ON_CHILD|FS_ISDIR, the event will be sent to fsnotify() even if the event type is not in the parent mark mask (e.g. FS_OPEN). Further more, if that event happened on a mount or a filesystem with a mount/sb mark that does have that event type in their mask, the "on child" event will be reported on the mount/sb mark. That is not desired, because user will get a duplicate event for the same action. Note that the event reported on the victim inode is never merged with the event reported on the parent inode, because of the check in should_merge(): old_fsn->inode == new_fsn->inode. Fix this by looking for a match of an actual event type (i.e. not just FS_ISDIR) in parent's inode mark mask and by not reporting an "on child" event to group if event type is only found on mount/sb marks. [backport hint: The bug seems to have always been in fanotify, but this patch will only apply cleanly to v4.19.y] Cc: <stable(a)vger.kernel.org> # v4.19 Signed-off-by: Amir Goldstein <amir73il(a)gmail.com> Signed-off-by: Jan Kara <jack(a)suse.cz> (cherry picked from commit b469e7e47c8a075cc08bcd1e85d4365134bdcdd5) --- fs/notify/fanotify/fanotify.c | 10 +++++----- fs/notify/fsnotify.c | 8 ++++++-- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/fs/notify/fanotify/fanotify.c b/fs/notify/fanotify/fanotify.c index f90842efea13..78126bd7c162 100644 --- a/fs/notify/fanotify/fanotify.c +++ b/fs/notify/fanotify/fanotify.c @@ -113,12 +113,12 @@ static bool fanotify_should_send_event(struct fsnotify_iter_info *iter_info, continue; mark = iter_info->marks[type]; /* - * if the event is for a child and this inode doesn't care about - * events on the child, don't send it! + * If the event is for a child and this mark doesn't care about + * events on a child, don't send it! */ - if (type == FSNOTIFY_OBJ_TYPE_INODE && - (event_mask & FS_EVENT_ON_CHILD) && - !(mark->mask & FS_EVENT_ON_CHILD)) + if (event_mask & FS_EVENT_ON_CHILD && + (type != FSNOTIFY_OBJ_TYPE_INODE || + !(mark->mask & FS_EVENT_ON_CHILD))) continue; marks_mask |= mark->mask; diff --git a/fs/notify/fsnotify.c b/fs/notify/fsnotify.c index ababdbfab537..46d27b357226 100644 --- a/fs/notify/fsnotify.c +++ b/fs/notify/fsnotify.c @@ -158,9 +158,9 @@ int __fsnotify_parent(const struct path *path, struct dentry *dentry, __u32 mask parent = dget_parent(dentry); p_inode = parent->d_inode; - if (unlikely(!fsnotify_inode_watches_children(p_inode))) + if (unlikely(!fsnotify_inode_watches_children(p_inode))) { __fsnotify_update_child_dentry_flags(p_inode); - else if (p_inode->i_fsnotify_mask & mask) { + } else if (p_inode->i_fsnotify_mask & mask & ~FS_EVENT_ON_CHILD) { struct name_snapshot name; /* we are notifying a parent so come up with the new mask which @@ -329,6 +329,10 @@ int fsnotify(struct inode *to_tell, __u32 mask, const void *data, int data_is, else mnt = NULL; + /* An event "on child" is not intended for a mount mark */ + if (mask & FS_EVENT_ON_CHILD) + mnt = NULL; + /* * Optimization: srcu_read_lock() has a memory barrier which can * be expensive. It protects walking the *_fsnotify_marks lists. -- 2.14.5

6 years, 9 months

5
10
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror