On Tue, Sep 02, 2025 at 12:27:45PM +0200, Johan Hovold wrote:
On Tue, Sep 02, 2025 at 11:16:46AM +0100, Sudeep Holla wrote:
On Tue, Sep 02, 2025 at 11:59:24AM +0200, Johan Hovold wrote:
On Fri, Aug 29, 2025 at 04:29:48PM +0200, Johan Hovold wrote:
On Fri, Aug 29, 2025 at 03:21:52PM +0200, Johan Hovold wrote:
The quirk version range is typically a string constant and must not be modified (e.g. as it may be stored in read-only memory):
Unable to handle kernel write to read-only memory at virtual address ffffc036d998a947
Fix the range parsing so that it operates on a copy of the version range string, and mark all the quirk strings as const to reduce the risk of introducing similar future issues.
With Jan's permission, let's add:
Reported-by: Jan Palus jpalus@fastmail.com
I was hoping to hear back, but I assume silence is kind of acceptance.
I sent the reply with the tag after making sure off-list that Jan was OK with it. Sorry if that was not clear.
Please don't do such (non-trivial) changes without making that clear in the commit message before your Signed-off-by tag:
[ sudeep: rewrite commit message; switch to cleanup helpers ]
Sorry I meant to do that when I replied and asked you if you are OK with cleanup helpers. Also yes I planned to add a line like something above before finalizing.
Sounds like a mail has gotten lost since I never saw that question from you.
No I hadn't sent it yet, generally wait for builder report to finalise the commit. Sometimes -next integration happens before build sends build report for my branch and that happened this time.