Re: [PATCH v2 2/2] tracing: Resize tgid_map to pid_max, not PID_MAX_DEFAULT

On Thu, 1 Jul 2021 10:24:07 -0700 Paul Burton paulburton@google.com wrote:

+static int *trace_find_tgid_ptr(int pid) +{

• // Pairs with the smp_store_release in set_tracer_flag() to ensure that
• // if we observe a non-NULL tgid_map then we also observe the correct
• // tgid_map_max.

BTW, it's against the Linux kernel coding style to use // for comments.

I can take this patch, but I need to change this to:

/* * Pairs with the smp_store_release in set_tracer_flag() to ensure that * if we observe a non-NULL tgid_map then we also observe the correct * tgid_map_max. */

Same with the other comments. Please follow coding style that can be found in:

Documentation/process/coding-style.rst

And see section 8 on Commenting.

Thanks,

-- Steve

• int *map = smp_load_acquire(&tgid_map);
• if (unlikely(!map || pid > tgid_map_max))

• return NULL;
  

• return &map[pid];

+}