3.16.62-rc1 review patch. If anyone has any objections, please let me know.
------------------
From: Ladislav Michl ladis@linux-mips.org
commit de4b74bda8e87a4ed45ebc2c26cc3e2eaae38429 upstream.
These warnings comes from times of driver development and do not carry any usefull debugging information.
Signed-off-by: Ladislav Michl ladis@linux-mips.org Cc: Bernie Thompson bernie@plugable.com Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnierkie@samsung.com [bwh: Backported to 3.16: adjust context] Signed-off-by: Ben Hutchings ben@decadent.org.uk --- drivers/video/fbdev/udlfb.c | 20 -------------------- 1 file changed, 20 deletions(-)
--- a/drivers/video/fbdev/udlfb.c +++ b/drivers/video/fbdev/udlfb.c @@ -924,11 +924,7 @@ static void dlfb_free(struct kref *kref)
if (dev->backing_buffer) vfree(dev->backing_buffer); - kfree(dev->edid); - - pr_warn("freeing dlfb_data %p\n", dev); - kfree(dev); }
@@ -945,8 +941,6 @@ static void dlfb_free_framebuffer(struct struct fb_info *info = dev->info;
if (info) { - int node = info->node; - unregister_framebuffer(info);
if (info->cmap.len != 0) @@ -962,8 +956,6 @@ static void dlfb_free_framebuffer(struct
/* Assume info structure is freed after this point */ framebuffer_release(info); - - pr_warn("fb_info for /dev/fb%d has been freed\n", node); }
/* ref taken in probe() as part of registering framebfufer */ @@ -1064,8 +1056,6 @@ static int dlfb_ops_set_par(struct fb_in u16 *pix_framebuffer; int i;
- pr_notice("set_par mode %dx%d\n", info->var.xres, info->var.yres); - result = dlfb_set_video_mode(dev, &info->var);
if ((result == 0) && (dev->fb_count == 0)) { @@ -1168,8 +1158,6 @@ static int dlfb_realloc_framebuffer(stru unsigned char *new_fb; unsigned char *new_back = NULL;
- pr_warn("Reallocating framebuffer. Addresses will change!\n"); - new_len = info->fix.line_length * info->var.yres;
if (PAGE_ALIGN(new_len) > old_len) { @@ -1420,9 +1408,6 @@ static ssize_t edid_show( if (off + count > dev->edid_size) count = dev->edid_size - off;
- pr_info("sysfs edid copy %p to %p, %d bytes\n", - dev->edid, buf, (int) count); - memcpy(buf, dev->edid, count);
return count; @@ -1448,7 +1433,6 @@ static ssize_t edid_store( if (!dev->edid || memcmp(src, dev->edid, src_size)) return -EINVAL;
- pr_info("sysfs written EDID is new default\n"); dlfb_ops_set_par(fb_info); return src_size; } @@ -1831,8 +1815,6 @@ static void dlfb_free_urb_list(struct dl int ret; unsigned long flags;
- pr_notice("Freeing all render urbs\n"); - /* keep waiting and freeing, until we've got 'em all */ while (count--) {
@@ -1911,8 +1893,6 @@ static int dlfb_alloc_urb_list(struct dl dev->urbs.count = i; dev->urbs.available = i;
- pr_notice("allocated %d %d byte urbs\n", i, (int) size); - return i; }