On Monday 25 January 2021 12:19:38 Guenter Roeck wrote:
On Mon, Jan 25, 2021 at 11:05:40AM +0100, Pali Rohár wrote:
On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote:
It has been reported[0] that the Dell XPS 15 L502X exhibits similar freezing behavior to the other systems[1] on this blacklist. The issue was exposed by a prior change of mine to automatically load dell_smm_hwmon on a wider set of XPS models. To fix the regression, add this model to the blacklist.
[0] https://bugzilla.kernel.org/show_bug.cgi?id=211081 [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models") Cc: stable@vger.kernel.org Reported-by: Bob Hepple bob.hepple@gmail.com Tested-by: Bob Hepple bob.hepple@gmail.com Signed-off-by: Thomas Hebb tommyhebb@gmail.com
drivers/hwmon/dell-smm-hwmon.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c index ec448f5f2dc3..73b9db9e3aab 100644 --- a/drivers/hwmon/dell-smm-hwmon.c +++ b/drivers/hwmon/dell-smm-hwmon.c @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = { DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"), }, },
- {
.ident = "Dell XPS 15 L502X",.matches = {DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),Hello! Are you sure that it is required to completely disable fan support? And not only access to fan type label for which is different blaclist i8k_blacklist_fan_type_dmi_table?
I'll drop this patch from my branch. Please send a Reviewed-by: or Acked-by: tag if/when I should apply it.
Of course! We will just wait for Bob test results.
Thanks, Guenter