From: Robert Foss robert.foss@linaro.org
[ Upstream commit bd03d440e2589b9c328f40ce60203adf2b19d2e2 ]
The return value of drm_bridge_attach() is ignored during the it66121_bridge_attach() call, which is incorrect.
Fixes: 988156dc2fc9 ("drm: bridge: add it66121 driver") Signed-off-by: Robert Foss robert.foss@linaro.org Acked-by: Jernej Skrabec jernej.skrabec@gmail.com Link: https://patchwork.freedesktop.org/patch/msgid/20210805185039.402178-1-robert... Link: https://patchwork.freedesktop.org/patch/msgid/20210805185039.402178-1-robert... Signed-off-by: Sasha Levin sashal@kernel.org --- drivers/gpu/drm/bridge/ite-it66121.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c index 7149ed40af83..2f2a09adb4bc 100644 --- a/drivers/gpu/drm/bridge/ite-it66121.c +++ b/drivers/gpu/drm/bridge/ite-it66121.c @@ -536,6 +536,8 @@ static int it66121_bridge_attach(struct drm_bridge *bridge, return -EINVAL;
ret = drm_bridge_attach(bridge->encoder, ctx->next_bridge, bridge, flags); + if (ret) + return ret;
ret = regmap_write_bits(ctx->regmap, IT66121_CLK_BANK_REG, IT66121_CLK_BANK_PWROFF_RCLK, 0);