Re: [PATCH v2 2/2] media: staging/intel-ipu3: Fix set_fmt error handling

On Mon, Mar 15, 2021 at 01:34:06PM +0100, Ricardo Ribalda wrote:

If there in an error during a set_fmt, do not overwrite the previous sizes with the invalid config.

[ 38.662975] ipu3-imgu 0000:00:05.0: swiotlb buffer is full (sz: 4096 bytes) [ 38.662980] DMA: Out of SW-IOMMU space for 4096 bytes at device 0000:00:05.0 [ 38.663010] general protection fault: 0000 [#1] PREEMPT SMP

Cc: stable@vger.kernel.org Fixes: 6d5f26f2e045 ("media: staging/intel-ipu3-v4l: reduce kernel stack usage") Signed-off-by: Ricardo Ribalda ribalda@chromium.org

---

drivers/staging/media/ipu3/ipu3-v4l2.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-)

Reviewed-by: Tomasz Figa tfiga@chromium.org

Best regards, Tomasz