On Wed, Feb 23, 2022 at 04:14:32PM -0700, dann frazier wrote:
From: Heiner Kallweit hkallweit1@gmail.com
[ Upstream commit ddb826c2c92d461f290a7bab89e7c28696191875 ]
Usage of phy_ethtool_get_link_ksettings() in the link status change handler isn't needed, and in combination with the referenced change it results in a deadlock. Simply remove the call and replace it with direct access to phydev->speed. The duplex argument of lan743x_phy_update_flowcontrol() isn't used and can be removed.
Fixes: c10a485c3de5 ("phy: phy_ethtool_ksettings_get: Lock the phy for consistency") Reported-by: Alessandro B Maurici abmaurici@gmail.com Tested-by: Alessandro B Maurici abmaurici@gmail.com Signed-off-by: Heiner Kallweit hkallweit1@gmail.com Reviewed-by: Andrew Lunn andrew@lunn.ch Link: https://lore.kernel.org/r/40e27f76-0ba3-dcef-ee32-a78b9df38b0f@gmail.com Signed-off-by: Jakub Kicinski kuba@kernel.org [dannf: adjust context] Signed-off-by: dann frazier dann.frazier@canonical.com
The patch this Fixes: was applied back through 5.4.y. But this fix for it was only applied back through 5.10.y. It did require some minor context adjustment for 5.4.y, perhaps that is why? At any rate, this looks to be a fix for a problem one of our users reported on our 5.4-based kernel.
Now queued up, thanks.
greg k-h