On Thu, Jul 01, 2021 at 02:07:54PM -0400, Steven Rostedt wrote:
On Thu, 1 Jul 2021 10:31:59 -0700 Paul Burton paulburton@google.com wrote:
I was tempted to just add the redundant checks anyway (pick your battles and all) but for show() in particular it wound up making things seem non-sensical to me ("display the value describing this non-NULL pointer into tgid_map only if tgid_map is not NULL?").
I agree with your assessment, and will actually take your first patch, as I don't think the comment is that helpful,
Thanks - agreed, the comment doesn't add much.
not to mention, we don't use '//' comments in the kernel, so that would have to be changed.
D'oh! Apparently a year away from the kernel melted my internal style checker. Interestingly though, checkpatch didn't complain about this as I would have expected...
Thanks, Paul