Perhaps targeting all QCA Rome chipsets in the original patch was a bit overkill. I'll try adding the quirk USB_QUIRK_RESET_RESUME for my device (0cf3:e300) in usb core and will report back.
-Leif Liddy
https://bugzilla.kernel.org/show_bug.cgi?id=193571
On Wed, Dec 27, 2017 at 1:52 PM, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Tue, Dec 26, 2017 at 10:01:46PM +0100, Marcel Holtmann wrote:
Hi Greg,
Commit ("fd865802c66bc451dc515ed89360f84376ce1a56 Bluetooth: btusb: fix QCA Rome suspend/resume") enables reset_resume in btusb_probe(). This makes the device resets during btusb_open(), firmware loading gets interrupted as a result.
We still want to reset the device to solve the original issue, but we should do it before btusb_open().
Hence, add reset-resume quirk in usb core intead of btusb.
Cc: stable@vger.kernel.org Cc: Leif Liddy leif.linux@gmail.com Cc: Matthias Kaehlcke mka@chromium.org Cc: Brian Norris briannorris@chromium.org Cc: Daniel Drake drake@endlessm.com Signed-off-by: Kai-Heng Feng kai.heng.feng@canonical.com
drivers/usb/core/quirks.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index a10b346b9777..96951104c45b 100644 --- a/drivers/usb/core/quirks.c +++ b/drivers/usb/core/quirks.c @@ -197,6 +197,9 @@ static const struct usb_device_id usb_quirk_list[] = { { USB_DEVICE(0x0b05, 0x17e0), .driver_info = USB_QUIRK_IGNORE_REMOTE_WAKEUP },
- /* QCA Rome Bluetooth in Dell DW1820 wireless module */
- { USB_DEVICE(0x0cf3, 0xe007), .driver_info = USB_QUIRK_RESET_RESUME },
can I get an ACK from you to take this patch through bluetooth-next tree? Or are you planning to take it?
It's not in my queue at all, so I didn't even have the chance to take it :)
Acked-by: Greg Kroah-Hartman gregkh@linuxfoundation.org