On Tue, Feb 2, 2021 at 2:06 PM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Mon, Feb 01, 2021 at 08:50:52PM +0100, Sedat Dilek wrote:
Hi,
you have in Linux 5.10.13-rc1:
"x86/entry: Emit a symbol for register restoring thunk"
While that discussion Boris and Peter recommended to remove unused code via:
"x86/entry: Remove put_ret_addr_in_rdi THUNK macro argument" ( upstream commit 0bab9cb2d980d7c075cffb9216155f7835237f98 )
OK, this has no CC:stable but I have both as a series in my local Git and both were git-pulled from [1]. What do you think?
What bug is this fixing that requires this in 5.10?
Commit 0bab9cb2d980d7c075cffb9216155f7835237f98 removed unused logic.
So-to-say: Fixes: 320100a5ffe5 ("x86/entry: Remove the TRACE_IRQS cruft")
The commit was first introduced with Linux v5.8-rc1:
$ git describe --contains 320100a5ffe5 v5.8-rc1~21^2~28
As Linux v5.10.y is an LTS IMHO I hoped it is worth removing unused code. You better know the rules for stable-linux, so I leave it to you, Greg.
- Sedat -