On Thu, Mar 5, 2020 at 10:41 AM Linus Torvalds torvalds@linux-foundation.org wrote:
On Thu, Mar 5, 2020 at 12:20 PM Andrei Vagin avagin@gmail.com wrote:
After this change, one more criu test became flaky. This is due to one of corner cases, so I am not sure that we need to fix something in the kernel. I have fixed this issue in the test. I am not sure that this will affect any real applications.
It's an interesting test-case, but it's really not doing anything you should rely on.
I'm agree with this.
But if CRIU itself depends on this behavior (rather than just a test), then I guess we need to.
So is it just a test-case, or does CRIU itself depend on that "reads get full buffers"? As mentioned, that really _is_ fundamentally broken if there is any chance of signals..
No, it doesn't. I'm agree that we can wait an report from a real app.
Thanks! Andrei