27 Feb
2023
27 Feb
'23
3:06 p.m.
On 2/27/23 06:58, Mario Limonciello wrote: [ ... ]
+ version = ((u64)val1 << 32) | val2; + if ((version >> 48) == 6) { + if (version >= 0x0006000000180006ULL) + return false; + } else if ((version >> 48) == 3) { + if (version >= 0x0003005700000005ULL) + return false; + } else + return false;
checkpatch:
CHECK: braces {} should be used on all arms of this statement #200: FILE: drivers/char/tpm/tpm-chip.c:557: + if ((version >> 48) == 6) { [...] + } else if ((version >> 48) == 3) { [...] + } else [...]
It was requested by Jarko explicitly in v1 to do it this way.
Interesting. We live and learn.
Guenter