3.16.63-rc1 review patch. If anyone has any objections, please let me know.
------------------
From: Nicolas Dichtel nicolas.dichtel@6wind.com
commit 35b827b6d06199841a83839e8bb69c0cd13a28be upstream.
It's not supported right now (the goal of the initial patch was to support 'ip link del' only).
Before the patch: $ ip link add foo type tun [ 239.632660] BUG: unable to handle kernel NULL pointer dereference at 0000000000000000 [snip] [ 239.636410] RIP: 0010:register_netdevice+0x8e/0x3a0
This panic occurs because dev->netdev_ops is not set by tun_setup(). But to have something usable, it will require more than just setting netdev_ops.
Fixes: f019a7a594d9 ("tun: Implement ip link del tunXXX") CC: Eric W. Biederman ebiederm@xmission.com Signed-off-by: Nicolas Dichtel nicolas.dichtel@6wind.com Signed-off-by: David S. Miller davem@davemloft.net [bwh: Backported to 3.16: Don't use extack] Signed-off-by: Ben Hutchings ben@decadent.org.uk --- --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -1415,9 +1415,7 @@ static void tun_setup(struct net_device */ static int tun_validate(struct nlattr *tb[], struct nlattr *data[]) { - if (!data) - return 0; - return -EINVAL; + return -EOPNOTSUPP; }
static struct rtnl_link_ops tun_link_ops __read_mostly = {