On Thu, May 23, 2019 at 03:46:26PM +0200, Daniel Borkmann wrote:
On 05/23/2019 12:27 PM, Rantala, Tommi T. (Nokia - FI/Espoo) wrote:
On Thu, 2019-04-04 at 10:48 +0200, Greg Kroah-Hartman wrote:
4.19-stable review patch. If anyone has any objections, please let me know.
[ Upstream commit 8184d44c9a577a2f1842ed6cc844bfd4a9981d8e ]
Use recently introduced bpf_probe_prog_type() to skip tests in the test_verifier() if bpf_verify_program() fails. The skipped test is indicated in the output.
Hi, this patch added in 4.19.34 causes test_verifier build failure, as bpf_probe_prog_type() is not available:
gcc -Wall -O2 -I../../../include/uapi -I../../../lib -I../../../lib/bpf -I../../../../include/generated -DHAVE_GENHDR -I../../../include test_verifier.c /root/linux- 4.19.44/tools/testing/selftests/bpf/libbpf.a -lcap -lelf -lrt -lpthread -o /root/linux-4.19.44/tools/testing/selftests/bpf/test_verifier test_verifier.c: In function ‘do_test_single’: test_verifier.c:12775:22: warning: implicit declaration of function ‘bpf_probe_prog_type’; did you mean ‘bpf_program__set_type’? [- Wimplicit-function-declaration] if (fd_prog < 0 && !bpf_probe_prog_type(prog_type, 0)) { ^~~~~~~~~~~~~~~~~~~ bpf_program__set_type /usr/bin/ld: /tmp/ccEtyLhk.o: in function `do_test_single': test_verifier.c:(.text+0xa19): undefined reference to `bpf_probe_prog_type' collect2: error: ld returned 1 exit status make[1]: *** [../lib.mk:152: /root/linux- 4.19.44/tools/testing/selftests/bpf/test_verifier] Error 1
Looks like this kselftest one got auto-selected for stable? It's not strictly needed, so totally fine to drop.
Ok, will go revert this, sorry for the breakage.
greg k-h