This is the start of the stable review cycle for the 5.4.288 release.
There are 24 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Thu, 19 Dec 2024 17:05:03 +0000.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.288-rc…
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
Linux 5.4.288-rc1
Dan Carpenter <dan.carpenter(a)linaro.org>
ALSA: usb-audio: Fix a DMA to stack memory bug
Juergen Gross <jgross(a)suse.com>
xen/netfront: fix crash when removing device
Nikolay Kuratov <kniv(a)yandex-team.ru>
tracing/kprobes: Skip symbol counting logic for module symbols in create_local_trace_kprobe()
Raghavendra Rao Ananta <rananta(a)google.com>
KVM: arm64: Ignore PMCNTENSET_EL0 while checking for overflow status
Nathan Chancellor <nathan(a)kernel.org>
blk-iocost: Avoid using clamp() on inuse in __propagate_weights()
Tejun Heo <tj(a)kernel.org>
blk-iocost: fix weight updates of inner active iocgs
Tejun Heo <tj(a)kernel.org>
blk-iocost: clamp inuse and skip noops in __propagate_weights()
Daniil Tatianin <d-tatianin(a)yandex-team.ru>
ACPICA: events/evxfregn: don't release the ContextMutex that was never acquired
Martin Ottens <martin.ottens(a)fau.de>
net/sched: netem: account for backlog updates from child qdisc
Stefan Wahren <wahrenst(a)gmx.net>
qca_spi: Make driver probing reliable
Stefan Wahren <wahrenst(a)gmx.net>
qca_spi: Fix clock speed for multiple QCA7000
Ilpo Järvinen <ilpo.jarvinen(a)linux.intel.com>
ACPI: resource: Fix memory resource type union access
Eric Dumazet <edumazet(a)google.com>
net: lapb: increase LAPB_HEADER_LEN
Eric Dumazet <edumazet(a)google.com>
tipc: fix NULL deref in cleanup_bearer()
Remi Pommarel <repk(a)triplefau.lt>
batman-adv: Do not let TT changes list grows indefinitely
Remi Pommarel <repk(a)triplefau.lt>
batman-adv: Remove uninitialized data in full table TT response
Remi Pommarel <repk(a)triplefau.lt>
batman-adv: Do not send uninitialized TT changes
Michal Luczaj <mhal(a)rbox.co>
bpf, sockmap: Fix update element with same
Darrick J. Wong <djwong(a)kernel.org>
xfs: don't drop errno values when we fail to ficlone the entire range
Lianqin Hu <hulianqin(a)vivo.com>
usb: gadget: u_serial: Fix the issue that gs_start_io crashed due to accessing null pointer
Vitalii Mordan <mordan(a)ispras.ru>
usb: ehci-hcd: fix call balance of clocks handling routines
Stefan Wahren <wahrenst(a)gmx.net>
usb: dwc2: hcd: Fix GetPortStatus & SetPortFeature
Joe Hattori <joe(a)pf.is.s.u-tokyo.ac.jp>
ata: sata_highbank: fix OF node reference leak in highbank_initialize_phys()
Mark Tomlinson <mark.tomlinson(a)alliedtelesis.co.nz>
usb: host: max3421-hcd: Correctly abort a USB request.
-------------
Diffstat:
Makefile | 4 +--
block/blk-iocost.c | 24 ++++++++++++--
drivers/acpi/acpica/evxfregn.c | 2 --
drivers/acpi/resource.c | 6 ++--
drivers/ata/sata_highbank.c | 1 +
drivers/net/ethernet/qualcomm/qca_spi.c | 26 +++++++--------
drivers/net/ethernet/qualcomm/qca_spi.h | 1 -
drivers/net/xen-netfront.c | 5 ++-
drivers/usb/dwc2/hcd.c | 16 ++++-----
drivers/usb/gadget/function/u_serial.c | 9 +++--
drivers/usb/host/ehci-sh.c | 9 +++--
drivers/usb/host/max3421-hcd.c | 16 ++++++---
fs/xfs/xfs_file.c | 8 +++++
include/net/lapb.h | 2 +-
kernel/trace/trace_kprobe.c | 2 +-
net/batman-adv/translation-table.c | 58 +++++++++++++++++++++++----------
net/core/sock_map.c | 1 +
net/sched/sch_netem.c | 22 +++++++++----
net/tipc/udp_media.c | 7 +++-
sound/usb/quirks.c | 31 ++++++++++++------
virt/kvm/arm/pmu.c | 1 -
21 files changed, 167 insertions(+), 84 deletions(-)
Total jobs: 97
Total errors: 17 (17.53%)
LAVA errors: 0 (0.00%)
Test errors: 17 (17.53%)
Job errors: 0 (0.00%)
Infra errors: 0 (0.00%)
Canceled jobs: 0 (0.00%)
Device type: qrb5165-rb5
Total jobs: 91
Total errors: 14 (15.38%)
Error type: Test
Error count: 14 (15.38%)
Error: No match for error type 'Test', message 'tradefed - adb device lost[f11b68eb]'
Count: 1 (1.10%)
IDs:
rb5-05:
8040557
Error: Device NOT found!
Count: 3 (3.30%)
IDs:
rb5-03:
8039372 8039421 8040473
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 598 seconds'
Count: 4 (4.40%)
IDs:
rb5-03:
8039368 8039475 8040471
rb5-06:
8039400
Error: No match for error type 'Test', message 'tradefed - adb device lost[74d67c95]'
Count: 2 (2.20%)
IDs:
rb5-03:
8040208 8040370
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 293 seconds'
Count: 1 (1.10%)
IDs:
rb5-07:
8040364
Error: No match for error type 'Test', message 'tradefed - adb device lost[4fc7b22]'
Count: 1 (1.10%)
IDs:
rb5-06:
8039449
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 597 seconds'
Count: 1 (1.10%)
IDs:
rb5-06:
8039447
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 592 seconds'
Count: 1 (1.10%)
IDs:
rb5-03:
8039377
Device type: x86
Total jobs: 1
Total errors: 1 (100.00%)
Error type: Test
Error count: 1 (100.00%)
Error: lava-test-shell timed out
Count: 1 (100.00%)
IDs:
x86-05:
8040525
Device type: hi960-hikey
Total jobs: 3
Total errors: 2 (66.67%)
Error type: Test
Error count: 2 (66.67%)
Error: No match for error type 'Test', message 'tradefed - adb device lost[279ABF68159019FF]'
Count: 1 (33.33%)
IDs:
hi960-hikey-03:
8040191
Error: No match for error type 'Test', message 'tradefed - adb device lost[47D27933024424E6]'
Count: 1 (33.33%)
IDs:
hi960-hikey-04:
8039472
Device type: juno-r2
Total jobs: 1
Total errors: 0 (0.00%)
Device type: dragonboard-845c
Total jobs: 1
Total errors: 0 (0.00%)
Total jobs: 209
Total errors: 10 (4.78%)
LAVA errors: 0 (0.00%)
Test errors: 0 (0.00%)
Job errors: 10 (4.78%)
Infra errors: 0 (0.00%)
Canceled jobs: 0 (0.00%)
Device type: dragonboard-410c
Total jobs: 9
Total errors: 8 (88.89%)
Error type: Job
Error count: 8 (88.89%)
Error: No match for error type 'Job', message 'Unable to update image rootfs: 'mount: mount exited with status 32: mount: /sysroot: wrong fs type, bad option, bad superblock on /dev/sda, missing codepage or helper program, or other error.\n dmesg(1) may have more information after failed mount system call.''
Count: 8 (88.89%)
IDs:
dragonboard-410c-01:
4119804 4119814 4119850 4119853 4119910
4119938 4119957 4119980
Device type: dragonboard-845c
Total jobs: 10
Total errors: 0 (0.00%)
Device type: x15
Total jobs: 25
Total errors: 0 (0.00%)
Device type: beaglebone-black
Total jobs: 84
Total errors: 0 (0.00%)
Device type: bcm2837-rpi-3-b-32
Total jobs: 68
Total errors: 1 (1.47%)
Error type: Job
Error count: 1 (1.47%)
Error: No match for error type 'Job', message 'No time left for remaining 4 retries. 1 retries out of 5 failed for uboot-action'
Count: 1 (1.47%)
IDs:
rpi3-b-32-03:
4119767
Device type: qemu
Total jobs: 4
Total errors: 0 (0.00%)
Device type: frdm-kw41z
Total jobs: 2
Total errors: 0 (0.00%)
Device type: frdm-k64f
Total jobs: 3
Total errors: 0 (0.00%)
Device type: docker
Total jobs: 2
Total errors: 0 (0.00%)
Device type: x15-bl
Total jobs: 1
Total errors: 1 (100.00%)
Error type: Job
Error count: 1 (100.00%)
Error: No match for error type 'Job', message 'Unable to flash the device'
Count: 1 (100.00%)
IDs:
x15-bl-01:
4119775
Device type: hi6220-hikey-r2
Total jobs: 1
Total errors: 0 (0.00%)
Hello,
On Sat, 14 Dec 2024, David Laight wrote:
> The 'max_avail' value is calculated from the system memory
> size using order_base_2().
> order_base_2(x) is defined as '(x) ? fn(x) : 0'.
> The compiler generates two copies of the code that follows
> and then expands clamp(max, min, PAGE_SHIFT - 12) (11 on 32bit).
> This triggers a compile-time assert since min is 5.
8 ?
>
> In reality a system would have to have less than 512MB memory
> for the bounds passed to clamp to be reversed.
>
> Swap the order of the arguments to clamp() to avoid the warning.
>
> Replace the clamp_val() on the line below with clamp().
> clamp_val() is just 'an accident waiting to happen' and not needed here.
>
> Detected by compile time checks added to clamp(), specifically:
> minmax.h: use BUILD_BUG_ON_MSG() for the lo < hi test in clamp()
>
> Reported-by: Linux Kernel Functional Testing <lkft(a)linaro.org>
> Closes: https://lore.kernel.org/all/CA+G9fYsT34UkGFKxus63H6UVpYi5GRZkezT9MRLfAbM3f6…
> Fixes: 4f325e26277b ("ipvs: dynamically limit the connection hash table")
> Tested-by: Bartosz Golaszewski <bartosz.golaszewski(a)linaro.org>
> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski(a)linaro.org>
> Signed-off-by: David Laight <david.laight(a)aculab.com>
Looks good to me, thanks to everyone!
Acked-by: Julian Anastasov <ja(a)ssi.bg>
Pablo, Simon, probably, this should be applied
to the 'nf' tree as it fixes a build failure...
> ---
>
> Julian seems to be waiting for a 'v2' from me.
> Changed target tree to 'net-next'.
> I've re-written the commit message.
> Copied Andrew Morton - he might want to take the change through the 'mm' tree.
> Plausibly the 'fixes' tag should refer to the minmax.h change?
> This will need back-porting if the minmax set get back-ported.
>
> I'm not sure whether there ought to be an attribution to Dan Carpenter <dan.carpenter(a)linaro.org>
>
> net/netfilter/ipvs/ip_vs_conn.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/netfilter/ipvs/ip_vs_conn.c b/net/netfilter/ipvs/ip_vs_conn.c
> index 98d7dbe3d787..c0289f83f96d 100644
> --- a/net/netfilter/ipvs/ip_vs_conn.c
> +++ b/net/netfilter/ipvs/ip_vs_conn.c
> @@ -1495,8 +1495,8 @@ int __init ip_vs_conn_init(void)
> max_avail -= 2; /* ~4 in hash row */
> max_avail -= 1; /* IPVS up to 1/2 of mem */
> max_avail -= order_base_2(sizeof(struct ip_vs_conn));
> - max = clamp(max, min, max_avail);
> - ip_vs_conn_tab_bits = clamp_val(ip_vs_conn_tab_bits, min, max);
> + max = clamp(max_avail, min, max);
> + ip_vs_conn_tab_bits = clamp(ip_vs_conn_tab_bits, min, max);
> ip_vs_conn_tab_size = 1 << ip_vs_conn_tab_bits;
> ip_vs_conn_tab_mask = ip_vs_conn_tab_size - 1;
>
> --
> 2.17.1
Regards
--
Julian Anastasov <ja(a)ssi.bg>