The alloc_mem() function is supposed to test out of memory conditions.
How it works is it calls mmap() on a giant chunk of memory.
It's either LENGTH (2GB) or "TESTMEM * 2 + TST_MB" (3GB) bytes.
This mmap() is generally supposed to succeed. Then at the bottom of
the alloc_mem() function when we actually try to use all the memory,
the thread is supposed to die with a SIGKILL.
The problem is that length is signed so on a 32-bit system it will be
negative. That means that at the bottom of the function when we loop
through the memory, the for loop is a no-op and there is no SIGKILL.
Fix this by changing the type to size_t which is unsigned.
Signed-off-by: Ben Copeland <ben.copeland(a)linaro.org>
---
testcases/kernel/mem/oom/oom.h | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/testcases/kernel/mem/oom/oom.h b/testcases/kernel/mem/oom/oom.h
index 41cc681f9..42ed181b0 100644
--- a/testcases/kernel/mem/oom/oom.h
+++ b/testcases/kernel/mem/oom/oom.h
@@ -62,13 +62,14 @@ static inline void set_global_mempolicy(int mempolicy)
static void set_global_mempolicy(int mempolicy LTP_ATTRIBUTE_UNUSED) { }
#endif
-static int alloc_mem(long int length, int testcase)
+static int alloc_mem(size_t length, int testcase)
{
char *s;
- long i, pagesz = getpagesize();
+ size_t i;
+ long pagesz = getpagesize();
int loop = 10;
- tst_res(TINFO, "thread (%lx), allocating %ld bytes.",
+ tst_res(TINFO, "thread (%lx), allocating %zu bytes.",
(unsigned long) pthread_self(), length);
s = mmap(NULL, length, PROT_READ | PROT_WRITE,
@@ -111,7 +112,7 @@ static void child_alloc(int testcase, int lite, int threads)
pthread_t *th;
if (lite) {
- int ret = alloc_mem(TESTMEM * 2 + TST_MB, testcase);
+ int ret = alloc_mem((size_t)TESTMEM * 2 + TST_MB, testcase);
exit(ret);
}
--
2.51.0
The overcommit test uses sum_total, the sum (memory and swap) to test
the overcommit settings.
This fixes two problems on 32-bit systems. The first is seen with a
integer overflow can occur when calculating sum_total * 2, if the
sum_total is larger than 2GB. The second is limited virtual address
space (2-3GB) means the test can fail from address space exhaustion
before overcommit has been tested.
Now the test runs correctly on low-memory 32-bit systems while avoiding
both the overflow bug and virtual address space issues.
Signed-off-by: Ben Copeland <ben.copeland(a)linaro.org>
Acked-by: Arnd Bergmann <arnd(a)arndb.de>
Reviewed-by: Petr Vorel <pvorel(a)suse.cz>
---
.../kernel/mem/tunable/overcommit_memory.c | 33 +++++++++++++++----
1 file changed, 27 insertions(+), 6 deletions(-)
diff --git a/testcases/kernel/mem/tunable/overcommit_memory.c b/testcases/kernel/mem/tunable/overcommit_memory.c
index 9b2cb479d..7ff5a98d0 100644
--- a/testcases/kernel/mem/tunable/overcommit_memory.c
+++ b/testcases/kernel/mem/tunable/overcommit_memory.c
@@ -131,24 +131,45 @@ static void overcommit_memory_test(void)
TST_SYS_CONF_LONG_SET(OVERCOMMIT_MEMORY, 2, 1);
update_mem_commit();
- alloc_and_check(commit_left * 2, EXPECT_FAIL);
- alloc_and_check(commit_limit + total_batch_size, EXPECT_FAIL);
+ /* Skip tests that would overflow or exceed 32-bit address space */
+ if (tst_kernel_bits() == 64 || (unsigned long)commit_left <= TST_GB / TST_KB) {
+ alloc_and_check(commit_left * 2, EXPECT_FAIL);
+ alloc_and_check(commit_limit + total_batch_size, EXPECT_FAIL);
+ } else {
+ tst_res(TCONF, "Skipping large allocation tests due to address space limits");
+ }
update_mem_commit();
- alloc_and_check(commit_left / 2, EXPECT_PASS);
+ if (tst_kernel_bits() == 64 || (unsigned long)commit_left <= TST_GB / TST_KB) {
+ alloc_and_check(commit_left / 2, EXPECT_PASS);
+ } else {
+ tst_res(TCONF, "Skipping commit_left/2 allocation test due to address space limits");
+ }
/* start to test overcommit_memory=0 */
TST_SYS_CONF_LONG_SET(OVERCOMMIT_MEMORY, 0, 1);
update_mem();
alloc_and_check(free_total / 2, EXPECT_PASS);
- alloc_and_check(sum_total * 2, EXPECT_FAIL);
+ /* Skip if sum_total * 2 would exceed address space.
+ * On 32-bit, skip when sum_total > ULONG_MAX/4 (~1GB).
+ * Most 32-bit systems with <=1GB RAM can map 2x that in 3GB vaddr space.
+ * Systems with 2GB+ RAM likely cannot fit allocations in vaddr space. */
+ if (tst_kernel_bits() == 64 || (unsigned long)sum_total <= TST_GB / TST_KB) {
+ alloc_and_check(sum_total * 2, EXPECT_FAIL);
+ } else {
+ tst_res(TCONF, "Skipping large allocation test due to address space limits");
+ }
/* start to test overcommit_memory=1 */
TST_SYS_CONF_LONG_SET(OVERCOMMIT_MEMORY, 1, 1);
alloc_and_check(sum_total / 2, EXPECT_PASS);
- alloc_and_check(sum_total, EXPECT_PASS);
- alloc_and_check(sum_total * 2, EXPECT_PASS);
+ if (tst_kernel_bits() == 64 || (unsigned long)sum_total <= TST_GB / TST_KB) {
+ alloc_and_check(sum_total, EXPECT_PASS);
+ alloc_and_check(sum_total * 2, EXPECT_PASS);
+ } else {
+ tst_res(TCONF, "Skipping large allocation tests due to address space limits");
+ }
}
--
2.51.0
Total jobs: 265
Total errors: 91 (34.34%)
LAVA errors: 0 (0.00%)
Test errors: 84 (31.70%)
Job errors: 1 (0.38%)
Infra errors: 6 (2.26%)
Canceled jobs: 0 (0.00%)
Device type: dragonboard-845c
Total jobs: 135
Total errors: 35 (25.93%)
Error type: Test
Error count: 35 (25.93%)
Error: Device NOT found!
Count: 3 (2.22%)
IDs:
db845c-04:
8491509 8492682
db845c-06:
8492659
Error: No match for error type 'Test', message 'tradefed - adb device lost[d966d3f5]'
Count: 3 (2.22%)
IDs:
db845c-03:
8491511 8491614 8492669
Error: No match for error type 'Test', message 'tradefed - adb device lost[a6622a22]'
Count: 8 (5.93%)
IDs:
db845c-09:
8491467 8491516 8491536 8491717 8491742
8491771 8491777 8492612
Error: No match for error type 'Test', message 'Device NOT found after DUT booted up! adb wait-for-device timed out after 300s'
Count: 12 (8.89%)
IDs:
db845c-04:
8491543 8491643 8491675 8491728
db845c-06:
8491440 8491593 8491665
db845c-09:
8491352 8491661 8491774 8492566
db845c-10:
8491609
Error: No match for error type 'Test', message 'tradefed - adb device lost[30e1e2ee]'
Count: 1 (0.74%)
IDs:
db845c-08:
8491781
Error: No match for error type 'Test', message 'tradefed - adb device lost[dd3b965f]'
Count: 2 (1.48%)
IDs:
db845c-02:
8491729 8491773
Error: No match for error type 'Test', message 'tradefed - adb device lost[476f370a]'
Count: 3 (2.22%)
IDs:
db845c-10:
8491454 8491469 8491730
Error: No match for error type 'Test', message 'tradefed - adb device lost[f3a58ae3]'
Count: 3 (2.22%)
IDs:
db845c-04:
8491357 8491453 8491510
Device type: qrb5165-rb5
Total jobs: 101
Total errors: 40 (39.60%)
Error type: Test
Error count: 33 (32.67%)
Error: No match for error type 'Test', message 'tradefed - adb device lost[74d67c95]'
Count: 7 (6.93%)
IDs:
rb5-03:
8491459 8491534 8491541 8491568 8491760
8492369 8492681
Error: Device NOT found!
Count: 3 (2.97%)
IDs:
rb5-01:
8491759 8492619 8492673
Error: No match for error type 'Test', message 'tradefed - adb device lost[d8a1879f]'
Count: 3 (2.97%)
IDs:
rb5-07:
8491589 8492387 8492618
Error: No match for error type 'Test', message 'tradefed - adb device lost[93dcfd96]'
Count: 1 (0.99%)
IDs:
rb5-01:
8492407
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 298 seconds'
Count: 1 (0.99%)
IDs:
rb5-07:
8491923
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 296 seconds'
Count: 1 (0.99%)
IDs:
rb5-03:
8491755
Error: No match for error type 'Test', message 'Device NOT found after DUT booted up! adb wait-for-device timed out after 300s'
Count: 13 (12.87%)
IDs:
rb5-01:
8491458 8491462 8491526 8491527 8491613
8491624 8491698
rb5-07:
8491476 8491525 8491538 8491580 8491725
8491737
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 898 seconds'
Count: 1 (0.99%)
IDs:
rb5-01:
8491724
Error: No match for error type 'Test', message 'tradefed - adb device lost[4fc7b22]'
Count: 3 (2.97%)
IDs:
rb5-06:
8491524 8491544 8491555
Error type: Infrastructure
Error count: 6 (5.94%)
Error: Connection closed
Count: 6 (5.94%)
IDs:
rb5-01:
8491461 8491475 8491523 8491573 8491697
8492570
Error type: Job
Error count: 1 (0.99%)
Error: No match for error type 'Job', message 'login-action timed out after 873 seconds'
Count: 1 (0.99%)
IDs:
rb5-01:
8491722
Device type: sm8550-hdk
Total jobs: 18
Total errors: 8 (44.44%)
Error type: Test
Error count: 8 (44.44%)
Error: No match for error type 'Test', message 'tradefed - adb device lost[124d1c34]'
Count: 2 (11.11%)
IDs:
sm8550-hdk-01:
8491748 8492379
Error: No match for error type 'Test', message 'Device NOT found after DUT booted up! adb wait-for-device timed out after 300s'
Count: 5 (27.78%)
IDs:
sm8550-hdk-01:
8491479 8491654 8491657 8491744 8491746
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 28798 seconds'
Count: 1 (5.56%)
IDs:
sm8550-hdk-01:
8491482
Device type: x86
Total jobs: 1
Total errors: 0 (0.00%)
Device type: hi6220-hikey-r2
Total jobs: 9
Total errors: 8 (88.89%)
Error type: Test
Error count: 8 (88.89%)
Error: No match for error type 'Test', message 'tradefed - adb device lost[8D6E5F00030E051]'
Count: 2 (22.22%)
IDs:
hikey-6220-r2-02:
8491548 8491797
Error: No match for error type 'Test', message 'tradefed - adb device lost[4595FE84003F72FC]'
Count: 2 (22.22%)
IDs:
hikey-6220-r2-04:
8491578 8491796
Error: No match for error type 'Test', message 'The network seems not available, as the ping command failed'
Count: 1 (11.11%)
IDs:
hikey-6220-r2-01:
8491711
Error: No match for error type 'Test', message 'Device NOT found after DUT booted up! adb wait-for-device timed out after 300s'
Count: 2 (22.22%)
IDs:
hikey-6220-r2-03:
8491710
hikey-6220-r2-05:
8491681
Error: No match for error type 'Test', message 'tradefed - adb device lost[235D989C003B0752]'
Count: 1 (11.11%)
IDs:
hikey-6220-r2-03:
8491503
Device type: dragonboard-410c
Total jobs: 1
Total errors: 0 (0.00%)