Total jobs: 156
Total errors: 17 (10.90%)
LAVA errors: 0 (0.00%)
Test errors: 0 (0.00%)
Job errors: 16 (10.26%)
Infra errors: 1 (0.64%)
Canceled jobs: 0 (0.00%)
Device type: x15
Total jobs: 43
Total errors: 3 (6.98%)
Error type: Job
Error count: 3 (6.98%)
Error: No match for error type 'Job', message 'login-action timed out after 275 seconds'
Count: 1 (2.33%)
IDs:
x15-01:
4154363
Error: No match for error type 'Job', message 'login-action timed out after 274 seconds'
Count: 2 (4.65%)
IDs:
x15-01:
4154243 4154346
Device type: dragonboard-410c
Total jobs: 14
Total errors: 13 (92.86%)
Error type: Job
Error count: 13 (92.86%)
Error: No match for error type 'Job', message 'Unable to update image rootfs: 'mount: mount exited with status 32: mount: /sysroot: wrong fs type, bad option, bad superblock on /dev/sda, missing codepage or helper program, or other error.\n dmesg(1) may have more information after failed mount system call.''
Count: 13 (92.86%)
IDs:
dragonboard-410c-01:
4154166 4154173 4154186 4154193 4154219
4154247 4154258 4154283 4154306 4154319
4154326 4154340 4154370
Device type: dragonboard-845c
Total jobs: 17
Total errors: 1 (5.88%)
Error type: Infrastructure
Error count: 1 (5.88%)
Error: Connection closed
Count: 1 (5.88%)
IDs:
dragonboard-845c-04:
4154342
Device type: beaglebone-black
Total jobs: 53
Total errors: 0 (0.00%)
Device type: bcm2837-rpi-3-b-32
Total jobs: 27
Total errors: 0 (0.00%)
Device type: hi6220-hikey-r2
Total jobs: 1
Total errors: 0 (0.00%)
Device type: imx93-11x11-evk
Total jobs: 1
Total errors: 0 (0.00%)
Total jobs: 152
Total errors: 16 (10.53%)
LAVA errors: 0 (0.00%)
Test errors: 0 (0.00%)
Job errors: 15 (9.87%)
Infra errors: 1 (0.66%)
Canceled jobs: 0 (0.00%)
Device type: bcm2837-rpi-3-b-32
Total jobs: 27
Total errors: 0 (0.00%)
Device type: beaglebone-black
Total jobs: 51
Total errors: 0 (0.00%)
Device type: x15
Total jobs: 42
Total errors: 4 (9.52%)
Error type: Job
Error count: 4 (9.52%)
Error: No match for error type 'Job', message 'login-action timed out after 275 seconds'
Count: 1 (2.38%)
IDs:
x15-01:
4154090
Error: No match for error type 'Job', message 'login-action timed out after 274 seconds'
Count: 3 (7.14%)
IDs:
x15-01:
4153955 4154073 4154089
Device type: dragonboard-845c
Total jobs: 18
Total errors: 1 (5.56%)
Error type: Infrastructure
Error count: 1 (5.56%)
Error: Connection closed
Count: 1 (5.56%)
IDs:
dragonboard-845c-04:
4154116
Device type: dragonboard-410c
Total jobs: 12
Total errors: 11 (91.67%)
Error type: Job
Error count: 11 (91.67%)
Error: No match for error type 'Job', message 'Unable to update image rootfs: 'mount: mount exited with status 32: mount: /sysroot: wrong fs type, bad option, bad superblock on /dev/sda, missing codepage or helper program, or other error.\n dmesg(1) may have more information after failed mount system call.''
Count: 11 (91.67%)
IDs:
dragonboard-410c-01:
4153968 4153980 4154011 4154018 4154037
4154061 4154065 4154095 4154112 4154132
4154140
Device type: hi6220-hikey-r2
Total jobs: 1
Total errors: 0 (0.00%)
Device type: imx93-11x11-evk
Total jobs: 1
Total errors: 0 (0.00%)
From: Masami Hiramatsu (Google) <mhiramat(a)kernel.org>
Since smp_text_poke_single() does not expect there is another
text_poke request is queued, it can make text_poke_array not
sorted or cause a buffer overflow on the text_poke_array.vec[].
This will cause an Oops in int3 because of bsearch failing;
CPU 0 CPU 1 CPU 2
----- ----- -----
smp_text_poke_batch_add()
smp_text_poke_single() <<-- Adds out of order
<int3>
[Fails o find address
in text_poke_array ]
OOPS!
Or unhandled page fault because of a buffer overflow;
CPU 0 CPU 1
----- -----
smp_text_poke_batch_add() <<+
... |
smp_text_poke_batch_add() <<-- Adds TEXT_POKE_ARRAY_MAX times.
smp_text_poke_single() {
__smp_text_poke_batch_add() <<-- Adds entry at
TEXT_POKE_ARRAY_MAX + 1
smp_text_poke_batch_finish()
[Unhandled page fault because
text_poke_array.nr_entries is
overwritten]
BUG!
}
Use smp_text_poke_batch_add() instead of __smp_text_poke_batch_add()
so that it correctly flush the queue if needed.
Reported-by: Linux Kernel Functional Testing <lkft(a)linaro.org>
Closes: https://lore.kernel.org/all/CA+G9fYsLu0roY3DV=tKyqP7FEKbOEETRvTDhnpPxJGbA=C…
Fixes: c8976ade0c1b ("x86/alternatives: Simplify smp_text_poke_single() by using tp_vec and existing APIs")
Signed-off-by: Masami Hiramatsu (Google) <mhiramat(a)kernel.org>
Reviewed-by: Steven Rostedt (Google) <rostedt(a)goodmis.org>
Tested-by: Linux Kernel Functional Testing <lkft(a)linaro.org>
---
arch/x86/kernel/alternative.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
index ecfe7b497cad..8038951650c6 100644
--- a/arch/x86/kernel/alternative.c
+++ b/arch/x86/kernel/alternative.c
@@ -3107,6 +3107,6 @@ void __ref smp_text_poke_batch_add(void *addr, const void *opcode, size_t len, c
*/
void __ref smp_text_poke_single(void *addr, const void *opcode, size_t len, const void *emulate)
{
- __smp_text_poke_batch_add(addr, opcode, len, emulate);
+ smp_text_poke_batch_add(addr, opcode, len, emulate);
smp_text_poke_batch_finish();
}
Total jobs: 207
Total errors: 58 (28.02%)
LAVA errors: 0 (0.00%)
Test errors: 36 (17.39%)
Job errors: 10 (4.83%)
Infra errors: 12 (5.80%)
Canceled jobs: 0 (0.00%)
Device type: qrb5165-rb5
Total jobs: 86
Total errors: 34 (39.53%)
Error type: Test
Error count: 24 (27.91%)
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 597 seconds'
Count: 2 (2.33%)
IDs:
rb5-03:
8318188 8319986
Error: Device NOT found!
Count: 9 (10.47%)
IDs:
rb5-03:
8317645 8317724 8318220 8318272 8318313
8319586 8319621 8319952
rb5-07:
8318124
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 596 seconds'
Count: 1 (1.16%)
IDs:
rb5-07:
8319931
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 598 seconds'
Count: 7 (8.14%)
IDs:
rb5-03:
8317619 8318184 8318315 8319576 8319603
rb5-07:
8318154 8318233
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 593 seconds'
Count: 1 (1.16%)
IDs:
rb5-03:
8318276
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 296 seconds'
Count: 1 (1.16%)
IDs:
rb5-07:
8318274
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 298 seconds'
Count: 2 (2.33%)
IDs:
rb5-07:
8317621 8318270
Error: No match for error type 'Test', message 'tradefed - adb device lost[74d67c95]'
Count: 1 (1.16%)
IDs:
rb5-03:
8317633
Error type: Infrastructure
Error count: 9 (10.47%)
Error: Connection closed
Count: 8 (9.30%)
IDs:
rb5-01:
8318182 8318314 8319601 8319957 8319965
8319966 8319968 8319975
Error: Reboot failed
Count: 1 (1.16%)
IDs:
rb5-07:
8319937
Error type: Job
Error count: 1 (1.16%)
Error: No match for error type 'Job', message 'Post-processing of downloads failed'
Count: 1 (1.16%)
IDs:
rb5-01:
8317640
Device type: x86
Total jobs: 2
Total errors: 0 (0.00%)
Device type: x15
Total jobs: 1
Total errors: 1 (100.00%)
Error type: Infrastructure
Error count: 1 (100.00%)
Error: No match for error type 'Infrastructure', message 'Unable to run: ['docker', 'exec', 'lava-8318626-2.6.3-dd8f62be-9701-4afb-87fc-a6778310298a', 'fastboot', '-s', '1900d01537bc0802', 'flash', 'super', '/var/lib/lava/dispatcher/tmp/8318626/fastboot-deploy-efn_uqa9/rootfs.img']'
Count: 1 (100.00%)
IDs:
x15-08:
8318626
Device type: dragonboard-845c
Total jobs: 96
Total errors: 23 (23.96%)
Error type: Test
Error count: 12 (12.50%)
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 295 seconds'
Count: 1 (1.04%)
IDs:
db845c-07:
8318553
Error: No match for error type 'Test', message 'tradefed - adb device lost[d966d3f5]'
Count: 1 (1.04%)
IDs:
db845c-03:
8318551
Error: No match for error type 'Test', message 'tradefed - adb device lost[b6b742b9]'
Count: 1 (1.04%)
IDs:
db845c-01:
8318322
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 598 seconds'
Count: 2 (2.08%)
IDs:
db845c-01:
8318207
db845c-02:
8317513
Error: No match for error type 'Test', message 'tradefed - adb device lost[c7cf1849]'
Count: 1 (1.04%)
IDs:
db845c-07:
8318178
Error: No match for error type 'Test', message 'tradefed - adb device lost[dd3b965f]'
Count: 2 (2.08%)
IDs:
db845c-02:
8317517 8318144
Error: Device NOT found!
Count: 2 (2.08%)
IDs:
db845c-02:
8317511
db845c-07:
8317637
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 597 seconds'
Count: 1 (1.04%)
IDs:
db845c-07:
8317605
Error: No match for error type 'Test', message 'lava-docker-test-shell timed out after 593 seconds'
Count: 1 (1.04%)
IDs:
db845c-01:
8317603
Error type: Job
Error count: 9 (9.38%)
Error: No match for error type 'Job', message 'login-action timed out after 875 seconds'
Count: 1 (1.04%)
IDs:
db845c-01:
8318192
Error: No match for error type 'Job', message 'login-action timed out after 873 seconds'
Count: 2 (2.08%)
IDs:
db845c-01:
8317570 8317646
Error: No match for error type 'Job', message 'login-action timed out after 872 seconds'
Count: 1 (1.04%)
IDs:
db845c-01:
8317569
Error: No match for error type 'Job', message 'Post-processing of downloads failed'
Count: 5 (5.21%)
IDs:
db845c-03:
8317540
db845c-04:
8317534 8317536 8317537
db845c-06:
8317539
Error type: Infrastructure
Error count: 2 (2.08%)
Error: No match for error type 'Infrastructure', message 'boot-fastboot timed out after 730 seconds'
Count: 1 (1.04%)
IDs:
db845c-07:
8317610
Error: Connection closed
Count: 1 (1.04%)
IDs:
db845c-01:
8317575
Device type: hi960-hikey
Total jobs: 2
Total errors: 0 (0.00%)
Device type: sm8550-hdk
Total jobs: 20
Total errors: 0 (0.00%)