On Wed Oct 22, 2025 at 6:29 AM UTC, Bala-Vignesh-Reddy wrote:
The previous change centralizing kselftest.h include path in lib.mk caused x86 selftests to fail, as x86 Makefile overwrites CFLAGS using ":=", dropping the include path added in lib.mk. Therefore, helpers.h could not find kselftest.h during compilation.
Fix this by adding the tools/testing/sefltest to CFLAGS in x86 Makefile.
Fixes: 4d89827dfb27 ("selftests: complete kselftest include centralization") Reported-by: Linux Kernel Functional Testing lkft@linaro.org Closes: https://lore.kernel.org/lkml/CA+G9fYvKjQcCBMfXA-z2YuL2L+3Qd-pJjEUDX8PDdz2-EE...
Signed-off-by: Bala-Vignesh-Reddy reddybalavignesh9979@gmail.com
Thanks, this fixes the issue I reported here:
https://lore.kernel.org/lkml/DFHI984SEFV3.2JL88CLHNT2SO@google.com/
Tested-by: Brendan Jackman jackmanb@google.com
Shuah, does this go via the kselftests tree? If not, Boris can you take it via x86?