On Tue, Sep 14, 2021 at 10:48 PM Brendan Higgins brendanhiggins@google.com wrote:
On Mon, Sep 13, 2021 at 1:55 PM Shuah Khan skhan@linuxfoundation.org wrote:
On 9/8/21 3:24 PM, Brendan Higgins wrote: Brendan,
Would you like to send me the fix with Suggested-by for Arnd or Kees?
So it looks like Arnd's fix was accepted (whether by him or someone else) for property-entry-test and Linus already fixed thunderbolt, so the only remaining of Arnd's patches is for the bitfield test, so I'll resend that one in a bit.
Also, I haven't actually tried Linus' suggestion yet, but the logic is sound and the change *should* be fairly unintrusive - I am going to give that a try and report back (but I will get the bitfield structleak disable patch out first since I already got that applying).
Looking at my randconfig tree, I find these six instances:
$ git grep -w DISABLE_STRUCTLEAK_PLUGIN drivers/base/test/Makefile:CFLAGS_property-entry-test.o += $(DISABLE_STRUCTLEAK_PLUGIN) drivers/iio/test/Makefile:CFLAGS_iio-test-format.o += $(DISABLE_STRUCTLEAK_PLUGIN) drivers/mmc/host/Makefile:CFLAGS_sdhci-of-aspeed.o += $(DISABLE_STRUCTLEAK_PLUGIN) drivers/thunderbolt/Makefile:CFLAGS_test.o += $(DISABLE_STRUCTLEAK_PLUGIN) lib/Makefile:CFLAGS_test_scanf.o += $(DISABLE_STRUCTLEAK_PLUGIN) lib/Makefile:CFLAGS_bitfield_kunit.o += $(DISABLE_STRUCTLEAK_PLUGIN) scripts/Makefile.gcc-plugins: DISABLE_STRUCTLEAK_PLUGIN += -fplugin-arg-structleak_plugin-disable scripts/Makefile.gcc-plugins:export DISABLE_STRUCTLEAK_PLUGIN
Sorry for failing to submit these as a proper patch. If you send a new version, I think you need to make sure you cover all of the above, using whichever change you like best.
Arnd