On Fri, May 08, 2020 at 08:21:19AM +0200, Johan Hovold wrote:
On Fri, May 08, 2020 at 03:35:02AM +0530, Naresh Kamboju wrote:
On Thu, 7 May 2020 at 16:43, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
<trim> > > > > > > Greg, 3f65047c853a ("of_mdio: add helper to deregister fixed-link > > > PHYs") needs to be backported as well for these. > > > > > > Original series can be found here: > > > > > > https://lkml.kernel.org/r/1480357509-28074-1-git-send-email-johan@kernel.org > > > > Ah, thanks for that, I thought I dropped all of the ones that caused > > build errors, but missed the above one. I'll go take the whole series > > instead. > > This should now all be fixed up, thanks.
While building kernel Image for arm architecture on stable-rc 4.4 branch the following build error found.
of_mdio: add helper to deregister fixed-link PHYs commit 3f65047c853a2a5abcd8ac1984af3452b5df4ada upstream.
Add helper to deregister fixed-link PHYs registered using of_phy_register_fixed_link().
Convert the two drivers that care to deregister their fixed-link PHYs to use the new helper, but note that most drivers currently fail to do so.
Signed-off-by: Johan Hovold johan@kernel.org Signed-off-by: David S. Miller davem@davemloft.net [only take helper function for 4.4.y - gregkh]
# make -sk KBUILD_BUILD_USER=TuxBuild -C/linux -j16 ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- HOSTCC=gcc CC="sccache arm-linux-gnueabihf-gcc" O=build zImage 70 # 71 ../drivers/of/of_mdio.c: In function ‘of_phy_deregister_fixed_link’: 72 ../drivers/of/of_mdio.c:379:2: error: implicit declaration of function ‘fixed_phy_unregister’; did you mean ‘fixed_phy_register’? [-Werror=implicit-function-declaration] 73 379 | fixed_phy_unregister(phydev); 74 | ^~~~~~~~~~~~~~~~~~~~ 75 | fixed_phy_register 76 ../drivers/of/of_mdio.c:381:22: error: ‘struct phy_device’ has no member named ‘mdio’; did you mean ‘mdix’? 77 381 | put_device(&phydev->mdio.dev); /* of_phy_find_device() */ 78 | ^~~~ 79 | mdix
Another dependency: 5bcbe0f35fb1 ("phy: fixed: Fix removal of phys.")
Greg, these patches are from four years ago so can't really remember if there are other dependencies or reasons against backporting them (the missing stable tags are per Dave's preference), sorry.
The cover letter also mentions another dependency, but that may just have been some context conflict.
Perhaps you better drop these unless you want to review them closer.
Good idea, I've dropped them all for now, sorry for the noise.
greg k-h