On Mon, Aug 03, 2020 at 10:58:55PM -0700, Guenter Roeck wrote:
On Mon, Aug 03, 2020 at 08:12:51PM -0700, Linus Torvalds wrote:
On Mon, Aug 3, 2020 at 8:01 PM Guenter Roeck linux@roeck-us.net wrote:
The bisect log below applies to both the sparc and the powerpc build failures.
Does the attached fix it?
LinusFrom 780c8591bce09bbdd2908b7c07b3baba883a1ce6 Mon Sep 17 00:00:00 2001 From: Linus Torvalds torvalds@linux-foundation.org Date: Fri, 31 Jul 2020 07:51:14 +0200 Subject: [PATCH] random32: move the pseudo-random 32-bit definitions to prandom.h
The addition of percpu.h to the list of includes in random.h revealed some circular dependencies on arm64 and possibly other platforms. This include was added solely for the pseudo-random definitions, which have nothing to do with the rest of the definitions in this file but are still there for legacy reasons.
This patch moves the pseudo-random parts to linux/prandom.h and the percpu.h include with it, which is now guarded by _LINUX_PRANDOM_H and protected against recursive inclusion.
A further cleanup step would be to remove this from <linux/random.h> entirely, and make people who use the prandom infrastructure include just the new header file. That's a bit of a churn patch, but grepping for "prandom_" and "next_pseudo_random32" should catch most users.
Acked-by: Willy Tarreau w@1wt.eu Signed-off-by: Linus Torvalds torvalds@linux-foundation.org
With this patch applied on top of v5.8:
Build results: total: 151 pass: 151 fail: 0 Qemu test results: total: 430 pass: 430 fail: 0
Tested-by: Guenter Roeck linux@roeck-us.net
Thanks for this, I'll go queue it up in a bit and push out some new -rc2 releases.
greg k-h