On Mon, 1 Mar 2021 at 21:19, Neal Cardwell ncardwell@google.com wrote:
Hi,
Thanks for the report!
You are welcome !
What exact kernel version are you testing?
We are running on Linux mainline master.
We can offer advice, but I'm afraid our team does not have cycles to track down and fix those test failures in your environment.
No. We are not expecting that. We would like to understand your testing environment (Testing board setup / Interfaces / userspace tools ) and Kconfigs that you are building with. I have attached the Kconfig file that we are building at our end.
In some cases, you will probably want to update your environment. For example, I would recommend enabling CONFIG_SYN_COOKIES, since that should give a much more robust and typical Linux TCP stack.
The config CONFIG_SYN_COOKIES is enabled now in our test CI.
In other cases, your kernels may have different behavior, for various reasons (local patches or atypical .config), that will require you to modify the tests to expect your behavior.
We (Linaro) are testing on the tip of Linux mainline and Linux next master branches and stable branch kernels. Packetdrill is not yet added to LKFT [1] test plan.
In other cases the upstream net-next behavior may have diverged from what these tests in the github packetdrill repo expect. If someone in the Linux networking community wants to submit pull requests to update the tests to expect the latest net-next behavior, we are happy to review and merge those. Our team has cycles to maintain our internal branches of these tests to match the behavior in our environment, but unfortunately does not have time to strictly keep all upstream tests up-to-date with respect to matching net-next behavior.
I completely understand that.
While running tests we have seen python errors, @Anders fixed this problem. The patch attached here.
Complaining that print is missing parentheses.
File ". packetdrill run_all.py", line 114 print 'stdout: ' ^ SyntaxError: Missing parentheses in call to 'print'. Did you mean print'stdout: '?
I have parsed the results in a LAVA[2] friendly way.
Results link, [1] https://lkft.linaro.org/tests/ [2] https://lavalab.nxp.com/results/285999/0_packetdrill?search=&length=1000...
- Naresh