This is the start of the stable review cycle for the 4.19.209 release. There are 95 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 06 Oct 2021 12:50:17 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.209-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
------------- Pseudo-Shortlog of commits:
Greg Kroah-Hartman gregkh@linuxfoundation.org Linux 4.19.209-rc1
Yanfei Xu yanfei.xu@windriver.com net: mdiobus: Fix memory leak in __mdiobus_register
Anirudh Rayabharam mail@anirudhrb.com HID: usbhid: free raw_report buffers in usbhid_stop
Jozsef Kadlecsik kadlec@netfilter.org netfilter: ipset: Fix oversized kvmalloc() calls
F.A.Sulaiman asha.16@itfac.mrt.ac.lk HID: betop: fix slab-out-of-bounds Write in betop_probe
Dan Carpenter dan.carpenter@oracle.com crypto: ccp - fix resource leaks in ccp_run_aes_gcm_cmd()
Dongliang Mu mudongliangabcd@gmail.com usb: hso: remove the bailout parameter
Dongliang Mu mudongliangabcd@gmail.com usb: hso: fix error handling code of hso_create_net_device
Oliver Neukum oneukum@suse.com hso: fix bailout in error case of probe
Alex Sverdlin alexander.sverdlin@nokia.com ARM: 9098/1: ftrace: MODULE_PLT: Fix build problem without DYNAMIC_FTRACE
Alex Sverdlin alexander.sverdlin@nokia.com ARM: 9079/1: ftrace: Add MODULE_PLTS support
Alex Sverdlin alexander.sverdlin@nokia.com ARM: 9078/1: Add warn suppress parameter to arm_gen_branch_link()
Alex Sverdlin alexander.sverdlin@nokia.com ARM: 9077/1: PLT: Move struct plt_entries definition to header
Sai Krishna Potthuri lakshmi.sai.krishna.potthuri@xilinx.com EDAC/synopsys: Fix wrong value type assignment for edac_mode
Eric Dumazet edumazet@google.com net: udp: annotate data race around udp_sk(sk)->corkflag
yangerkun yangerkun@huawei.com ext4: fix potential infinite loop in ext4_dx_readdir()
Johan Hovold johan@kernel.org ipack: ipoctal: fix module reference leak
Johan Hovold johan@kernel.org ipack: ipoctal: fix missing allocation-failure check
Johan Hovold johan@kernel.org ipack: ipoctal: fix tty-registration error handling
Johan Hovold johan@kernel.org ipack: ipoctal: fix tty registration race
Johan Hovold johan@kernel.org ipack: ipoctal: fix stack information leak
Chen Jingwen chenjingwen6@huawei.com elf: don't use MAP_FIXED_NOREPLACE for elf interpreter mappings
Eric Dumazet edumazet@google.com af_unix: fix races in sk_peer_pid and sk_peer_cred accesses
Rahul Lakkireddy rahul.lakkireddy@chelsio.com scsi: csiostor: Add module softdep on cxgb4
Jens Axboe axboe@kernel.dk Revert "block, bfq: honor already-setup queue merges"
Jacob Keller jacob.e.keller@intel.com e100: fix buffer overrun in e100_get_regs
Jacob Keller jacob.e.keller@intel.com e100: fix length calculation in e100_get_regs_len
Paul Fertser fercerpav@gmail.com hwmon: (tmp421) fix rounding for negative values
Paul Fertser fercerpav@gmail.com hwmon: (tmp421) report /PVLD condition as fault
Guenter Roeck linux@roeck-us.net hwmon: (tmp421) Replace S_<PERMS> with octal values
Xin Long lucien.xin@gmail.com sctp: break out if skb_header_pointer returns NULL in sctp_rcv_ootb
Lorenzo Bianconi lorenzo@kernel.org mac80211: limit injected vht mcs/nss in ieee80211_parse_tx_radiotap
Chih-Kang Chang gary.chang@realtek.com mac80211: Fix ieee80211_amsdu_aggregate frag_tail bug
Vadim Pasternak vadimp@nvidia.com hwmon: (mlxreg-fan) Return non-zero value when fan current state is enforced from sysfs
Andrea Claudi aclaudi@redhat.com ipvs: check that ip_vs_conn_tab_bits is between 8 and 20
Charlene Liu Charlene.Liu@amd.com drm/amd/display: Pass PCI deviceid into DC
Zelin Deng zelin.deng@linux.alibaba.com x86/kvmclock: Move this_cpu_pvti into kvmclock.h
Johannes Berg johannes.berg@intel.com mac80211: fix use-after-free in CCMP/GCMP RX
James Morse james.morse@arm.com cpufreq: schedutil: Destroy mutex before kobject_put() frees the memory
Kevin Hao haokexin@gmail.com cpufreq: schedutil: Use kobject release() method to free sugov_tunables
Igor Matheus Andrade Torrente igormtorrente@gmail.com tty: Fix out-of-bound vmalloc access in imageblit
Linus Torvalds torvalds@linux-foundation.org qnx4: work around gcc false positive warning bug
Juergen Gross jgross@suse.com xen/balloon: fix balloon kthread freezing
Eric Dumazet edumazet@google.com tcp: adjust rto_base in retransmits_timed_out()
Yuchung Cheng ycheng@google.com tcp: create a helper to model exponential backoff
Yuchung Cheng ycheng@google.com tcp: always set retrans_stamp on recovery
Eric Dumazet edumazet@google.com tcp: address problems caused by EDT misshaps
Evan Wang xswang@marvell.com PCI: aardvark: Fix checking for PIO status
Pali Rohár pali@kernel.org arm64: dts: marvell: armada-37xx: Extend PCIe MEM space
Gao Xiang hsiangkao@linux.alibaba.com erofs: fix up erofs_lookup tracepoint
Linus Torvalds torvalds@linux-foundation.org spi: Fix tegra20 build with CONFIG_PM=n
Guenter Roeck linux@roeck-us.net net: 6pack: Fix tx timeout and slot time
Guenter Roeck linux@roeck-us.net alpha: Declare virt_to_phys and virt_to_bus parameter as pointer to volatile
Dan Li ashimida@linux.alibaba.com arm64: Mark __stack_chk_guard as __ro_after_init
Helge Deller deller@gmx.de parisc: Use absolute_pointer() to define PAGE0
Linus Torvalds torvalds@linux-foundation.org qnx4: avoid stringop-overread errors
Linus Torvalds torvalds@linux-foundation.org sparc: avoid stringop-overread errors
Guenter Roeck linux@roeck-us.net net: i825xx: Use absolute_pointer for memcpy from fixed memory location
Guenter Roeck linux@roeck-us.net compiler.h: Introduce absolute_pointer macro
Anton Eidelman anton.eidelman@gmail.com nvme-multipath: fix ANA state updates when a namespace is not present
Juergen Gross jgross@suse.com xen/balloon: use a kernel thread instead a workqueue
Guenter Roeck linux@roeck-us.net m68k: Double cast io functions to unsigned long
Jesper Nilsson jesper.nilsson@axis.com net: stmmac: allow CSR clock of 300MHz
Tong Zhang ztong0001@gmail.com net: macb: fix use after free on rmmod
Zhihao Cheng chengzhihao1@huawei.com blktrace: Fix uaf in blk_trace access after removing by sysfs
Christoph Hellwig hch@lst.de md: fix a lock order reversal in md_alloc
Kaige Fu kaige.fu@linux.alibaba.com irqchip/gic-v3-its: Fix potential VPE leak on error
Randy Dunlap rdunlap@infradead.org irqchip/goldfish-pic: Select GENERIC_IRQ_CHIP to fix build
Dan Carpenter dan.carpenter@oracle.com thermal/core: Potential buffer overflow in thermal_build_list_of_policies()
Jiapeng Chong jiapeng.chong@linux.alibaba.com fpga: machxo2-spi: Fix missing error code in machxo2_write_complete()
Tom Rix trix@redhat.com fpga: machxo2-spi: Return an error on failure
Randy Dunlap rdunlap@infradead.org tty: synclink_gt: rename a conflicting function name
Jiri Slaby jslaby@suse.cz tty: synclink_gt, drop unneeded forward declarations
Baokun Li libaokun1@huawei.com scsi: iscsi: Adjust iface sysfs attr detection
Aya Levin ayal@nvidia.com net/mlx4_en: Don't allow aRFS for encapsulated packets
Kunihiko Hayashi hayashi.kunihiko@socionext.com gpio: uniphier: Fix void functions to remove return value
Karsten Graul kgraul@linux.ibm.com net/smc: add missing error check in smc_clc_prfx_set()
Michael Chan michael.chan@broadcom.com bnxt_en: Fix TX timeout when TX ring size is set to the smallest
Johan Hovold johan@kernel.org net: hso: fix muxed tty registration
Pali Rohár pali@kernel.org serial: mvebu-uart: fix driver's tx_empty callback
Dan Carpenter dan.carpenter@oracle.com mcb: fix error handling in mcb_alloc_bus()
Slark Xiao slark_xiao@163.com USB: serial: option: add device id for Foxconn T99W265
Krzysztof Kozlowski krzysztof.kozlowski@canonical.com USB: serial: option: remove duplicate USB device ID
Carlo Lobrano c.lobrano@gmail.com USB: serial: option: add Telit LN920 compositions
Krzysztof Kozlowski krzysztof.kozlowski@canonical.com USB: serial: mos7840: remove duplicated 0xac24 device ID
Julian Sikorski belegdol@gmail.com Re-enable UAS for LaCie Rugged USB3-FW with fk quirk
Johan Hovold johan@kernel.org staging: greybus: uart: fix tty use after free
Johan Hovold johan@kernel.org USB: cdc-acm: fix minor-number release
Uwe Brandt uwe.brandt@gmail.com USB: serial: cp210x: add ID for GW Instek GDM-834x Digital Multimeter
Ondrej Zary linux@zary.sk usb-storage: Add quirk for ScanLogic SL11R-IDE older than 2.6c
Jan Beulich jbeulich@suse.com xen/x86: fix PV trap handling on secondary processors
Steve French stfrench@microsoft.com cifs: fix incorrect check for null pointer in header_assemble
Dan Carpenter dan.carpenter@oracle.com usb: musb: tusb6010: uninitialized data in tusb_fifo_write_unaligned()
Minas Harutyunyan Minas.Harutyunyan@synopsys.com usb: dwc2: gadget: Fix ISOC transfer complete handling for DDMA
Dan Carpenter dan.carpenter@oracle.com usb: gadget: r8a66597: fix a loop in set_feature()
Wengang Wang wen.gang.wang@oracle.com ocfs2: drop acl cache for directories too
-------------
Diffstat:
Makefile | 4 +- arch/alpha/include/asm/io.h | 6 +- arch/arm/include/asm/ftrace.h | 3 + arch/arm/include/asm/insn.h | 8 +- arch/arm/include/asm/module.h | 10 ++ arch/arm/kernel/ftrace.c | 50 ++++++++-- arch/arm/kernel/insn.c | 19 ++-- arch/arm/kernel/module-plts.c | 49 +++++++--- arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 11 ++- arch/arm64/kernel/process.c | 2 +- arch/m68k/include/asm/raw_io.h | 20 ++-- arch/parisc/include/asm/page.h | 2 +- arch/sparc/kernel/mdesc.c | 3 +- arch/x86/include/asm/kvmclock.h | 14 +++ arch/x86/kernel/kvmclock.c | 13 +-- arch/x86/xen/enlighten_pv.c | 15 +-- block/bfq-iosched.c | 16 +--- drivers/cpufreq/cpufreq_governor_attr_set.c | 2 +- drivers/crypto/ccp/ccp-ops.c | 14 +-- drivers/edac/synopsys_edac.c | 2 +- drivers/fpga/machxo2-spi.c | 6 +- drivers/gpio/gpio-uniphier.c | 4 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + drivers/hid/hid-betopff.c | 13 ++- drivers/hid/usbhid/hid-core.c | 13 ++- drivers/hwmon/mlxreg-fan.c | 12 ++- drivers/hwmon/tmp421.c | 35 +++---- drivers/ipack/devices/ipoctal.c | 63 +++++++++---- drivers/irqchip/Kconfig | 1 + drivers/irqchip/irq-gic-v3-its.c | 2 +- drivers/mcb/mcb-core.c | 12 +-- drivers/md/md.c | 5 - drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 +- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 5 + drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +- drivers/net/ethernet/cadence/macb_pci.c | 2 +- drivers/net/ethernet/i825xx/82596.c | 2 +- drivers/net/ethernet/intel/e100.c | 22 +++-- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 3 + drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- drivers/net/hamradio/6pack.c | 4 +- drivers/net/phy/mdio_bus.c | 1 + drivers/net/usb/hso.c | 45 +++++---- drivers/nvme/host/multipath.c | 7 +- drivers/pci/controller/pci-aardvark.c | 62 +++++++++++-- drivers/scsi/csiostor/csio_init.c | 1 + drivers/scsi/scsi_transport_iscsi.c | 8 +- drivers/spi/spi-tegra20-slink.c | 4 +- drivers/staging/erofs/include/trace/events/erofs.h | 6 +- drivers/staging/greybus/uart.c | 62 +++++++------ drivers/thermal/thermal_core.c | 7 +- drivers/tty/serial/mvebu-uart.c | 2 +- drivers/tty/synclink_gt.c | 101 +++++---------------- drivers/tty/vt/vt.c | 21 ++++- drivers/usb/class/cdc-acm.c | 7 +- drivers/usb/class/cdc-acm.h | 2 + drivers/usb/dwc2/gadget.c | 4 +- drivers/usb/gadget/udc/r8a66597-udc.c | 2 +- drivers/usb/musb/tusb6010.c | 1 + drivers/usb/serial/cp210x.c | 1 + drivers/usb/serial/mos7840.c | 2 - drivers/usb/serial/option.c | 11 ++- drivers/usb/storage/unusual_devs.h | 9 +- drivers/usb/storage/unusual_uas.h | 2 +- drivers/xen/balloon.c | 62 +++++++++---- fs/binfmt_elf.c | 2 +- fs/cifs/connect.c | 5 +- fs/ext4/dir.c | 6 +- fs/ocfs2/dlmglue.c | 3 +- fs/qnx4/dir.c | 69 ++++++++++---- include/linux/compiler.h | 2 + include/net/sock.h | 2 + kernel/sched/cpufreq_schedutil.c | 16 +++- kernel/trace/blktrace.c | 8 ++ net/core/sock.c | 32 +++++-- net/ipv4/tcp_input.c | 16 ++-- net/ipv4/tcp_output.c | 9 +- net/ipv4/tcp_timer.c | 63 ++++++------- net/ipv4/udp.c | 10 +- net/ipv6/udp.c | 2 +- net/mac80211/tx.c | 12 +++ net/mac80211/wpa.c | 6 ++ net/netfilter/ipset/ip_set_hash_gen.h | 4 +- net/netfilter/ipvs/ip_vs_conn.c | 4 + net/sctp/input.c | 2 +- net/smc/smc_clc.c | 3 +- net/unix/af_unix.c | 34 +++++-- 87 files changed, 775 insertions(+), 445 deletions(-)
On Mon, 4 Oct 2021 at 18:32, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.209 release. There are 95 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 06 Oct 2021 12:50:17 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.209-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Regression found on arm, arm64, i386 and x86. following kernel crash reported on stable-rc linux-4.19.y.
metadata: git branch: linux-4.19.y git repo: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc git commit: ee3e528d83e91547f386a30677ccb96c28e78218 git describe: v4.19.208-96-gee3e528d83e9 make_kernelversion: 4.19.209-rc1 kernel-config: https://builds.tuxbuild.com/1z2izwX1xMgF2OSYM5EN6ELHEij/config
Kernel crash: -------------- [ 14.900875] BUG: unable to handle kernel NULL pointer dereference at 0000000000000000 [ 14.908699] PGD 0 P4D 0 [ 14.911230] Oops: 0002 [#1] SMP PTI [ 14.914714] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.19.209-rc1 #1 [ 14.921147] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS 2.2 05/23/2018 [ 14.928531] RIP: 0010:__sk_destruct+0xb9/0x190 [ 14.932965] Code: 48 8b 47 08 48 8d 50 ff a8 01 48 0f 45 fa f0 ff 4f 34 0f 84 d9 00 00 00 48 c7 83 00 ff ff ff 00 00 00 00 48 8b bb 78 ff ff ff <f0> ff 0f 0f 84 a0 00 00 00 48 8b bb 70 ff ff ff e8 32 41 6d ff f6 [ 14.951704] RSP: 0000:ffff9e242f803dc0 EFLAGS: 00010246 [ 14.956920] RAX: 0000000000000000 RBX: ffff9e242cfc82c0 RCX: 0000000000000001 [ 14.964043] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 [ 14.971167] RBP: ffff9e242f803de0 R08: ffff9e242cfc8000 R09: 0000000000000000 [ 14.978291] R10: 0000000000000000 R11: 0000000000000000 R12: ffff9e242cfc8000 [ 14.985415] R13: ffff9e242cfc82c0 R14: ffff9e242cde8600 R15: 00000000ffffff0c [ 14.992540] FS: 0000000000000000(0000) GS:ffff9e242f800000(0000) knlGS:0000000000000000 [ 15.000617] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 15.006359] CR2: 0000000000000000 CR3: 0000000013c0a001 CR4: 00000000003606f0 [ 15.013504] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 15.020628] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 15.027752] Call Trace: [ 15.030198] <IRQ> [ 15.032207] __sk_free+0x71/0x110 [ 15.035518] __sock_wfree+0x2c/0x30 [ 15.039002] skb_release_head_state+0x56/0xa0 [ 15.043359] napi_consume_skb+0x5a/0x140 [ 15.047297] igb_poll+0xc7/0xf30 [ 15.050522] net_rx_action+0x13a/0x3a0 [ 15.054273] ? __napi_schedule+0x54/0x70 [ 15.058189] __do_softirq+0xf6/0x2ed [ 15.061760] irq_exit+0xab/0xe0 [ 15.064897] do_IRQ+0x86/0xe0 [ 15.067862] common_interrupt+0xf/0xf [ 15.071519] </IRQ> [ 15.073618] RIP: 0010:cpuidle_enter_state+0x119/0x2c0 [ 15.078669] Code: 77 ff 80 7d c7 00 74 12 9c 58 f6 c4 02 0f 85 8e 01 00 00 31 ff e8 07 1d 7d ff e8 b2 84 82 ff fb 48 ba cf f7 53 e3 a5 9b c4 20 <4c> 2b 7d c8 4c 89 f8 49 c1 ff 3f 48 f7 ea b8 ff ff ff 7f 48 c1 fa [ 15.097405] RSP: 0000:ffffffff9ce03e00 EFLAGS: 00000282 ORIG_RAX: ffffffffffffffdc [ 15.104961] RAX: ffffffff9ce03e40 RBX: ffff9e242d6ce000 RCX: 000000000000001f [ 15.112085] RDX: 20c49ba5e353f7cf RSI: ffffffff9c028777 RDI: ffffffff9c02858e [ 15.119210] RBP: ffffffff9ce03e40 R08: 0000000378293f7f R09: 0000000000000022 [ 15.126358] R10: 0000000000000034 R11: ffff9e242f81ed08 R12: 0000000000000001 [ 15.133510] R13: ffffffff9ceca620 R14: ffffffff9ceca680 R15: 0000000378293f7f [ 15.140636] ? cpuidle_enter+0x17/0x20 [ 15.144415] ? cpuidle_enter_state+0x10e/0x2c0 [ 15.148859] cpuidle_enter+0x17/0x20 [ 15.152430] call_cpuidle+0x23/0x40 [ 15.155914] do_idle+0x1b9/0x240 [ 15.159138] cpu_startup_entry+0x73/0x80 [ 15.163055] rest_init+0xa3/0xa5 [ 15.166280] start_kernel+0x483/0x4a5 [ 15.169937] x86_64_start_reservations+0x24/0x26 [ 15.174547] x86_64_start_kernel+0x70/0x74 [ 15.178637] secondary_startup_64+0xa4/0xb0 [ 15.182813] Modules linked in: [ 15.185866] CR2: 0000000000000000 [ 15.189177] ---[ end trace 87e25bcdd88d2b4b ]--- [ 15.193785] RIP: 0010:__sk_destruct+0xb9/0x190 [ 15.198222] Code: 48 8b 47 08 48 8d 50 ff a8 01 48 0f 45 fa f0 ff 4f 34 0f 84 d9 00 00 00 48 c7 83 00 ff ff ff 00 00 00 00 48 8b bb 78 ff ff ff <f0> ff 0f 0f 84 a0 00 00 00 48 8b bb 70 ff ff ff e8 32 41 6d ff f6 [ 15.216960] RSP: 0000:ffff9e242f803dc0 EFLAGS: 00010246 [ 15.222176] RAX: 0000000000000000 RBX: ffff9e242cfc82c0 RCX: 0000000000000001 [ 15.229302] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 [ 15.236424] RBP: ffff9e242f803de0 R08: ffff9e242cfc8000 R09: 0000000000000000 [ 15.243548] R10: 0000000000000000 R11: 0000000000000000 R12: ffff9e242cfc8000 [ 15.250673] R13: ffff9e242cfc82c0 R14: ffff9e242cde8600 R15: 00000000ffffff0c [ 15.257796] FS: 0000000000000000(0000) GS:ffff9e242f800000(0000) knlGS:0000000000000000 [ 15.265872] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 15.271613] CR2: 0000000000000000 CR3: 0000000013c0a001 CR4: 00000000003606f0 [ 15.278734] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 15.285858] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 15.292982] Kernel panic - not syncing: Fatal exception in interrupt [ 15.299375] Kernel Offset: 0x1a600000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff)
Reported-by: Linux Kernel Functional Testing lkft@linaro.org
ref: https://lkft.validation.linaro.org/scheduler/job/3657592#L928 https://lkft.validation.linaro.org/scheduler/job/3657638#L933 https://lkft.validation.linaro.org/scheduler/job/3657762#L949 https://lkft.validation.linaro.org/scheduler/job/3657822#L1899
-- Linaro LKFT https://lkft.linaro.org
On Mon, Oct 4, 2021 at 10:40 AM Naresh Kamboju naresh.kamboju@linaro.org wrote:
On Mon, 4 Oct 2021 at 18:32, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.209 release. There are 95 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 06 Oct 2021 12:50:17 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.209-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Regression found on arm, arm64, i386 and x86. following kernel crash reported on stable-rc linux-4.19.y.
Stable teams should backport cred: allow get_cred() and put_cred() to be given NULL.
f06bc03339ad4c1baa964a5f0606247ac1c3c50b
Or they should have tweaked my patch before backporting it.
metadata: git branch: linux-4.19.y git repo: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc git commit: ee3e528d83e91547f386a30677ccb96c28e78218 git describe: v4.19.208-96-gee3e528d83e9 make_kernelversion: 4.19.209-rc1 kernel-config: https://builds.tuxbuild.com/1z2izwX1xMgF2OSYM5EN6ELHEij/config
Kernel crash:
[ 14.900875] BUG: unable to handle kernel NULL pointer dereference at 0000000000000000 [ 14.908699] PGD 0 P4D 0 [ 14.911230] Oops: 0002 [#1] SMP PTI [ 14.914714] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.19.209-rc1 #1 [ 14.921147] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS 2.2 05/23/2018 [ 14.928531] RIP: 0010:__sk_destruct+0xb9/0x190 [ 14.932965] Code: 48 8b 47 08 48 8d 50 ff a8 01 48 0f 45 fa f0 ff 4f 34 0f 84 d9 00 00 00 48 c7 83 00 ff ff ff 00 00 00 00 48 8b bb 78 ff ff ff <f0> ff 0f 0f 84 a0 00 00 00 48 8b bb 70 ff ff ff e8 32 41 6d ff f6 [ 14.951704] RSP: 0000:ffff9e242f803dc0 EFLAGS: 00010246 [ 14.956920] RAX: 0000000000000000 RBX: ffff9e242cfc82c0 RCX: 0000000000000001 [ 14.964043] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 [ 14.971167] RBP: ffff9e242f803de0 R08: ffff9e242cfc8000 R09: 0000000000000000 [ 14.978291] R10: 0000000000000000 R11: 0000000000000000 R12: ffff9e242cfc8000 [ 14.985415] R13: ffff9e242cfc82c0 R14: ffff9e242cde8600 R15: 00000000ffffff0c [ 14.992540] FS: 0000000000000000(0000) GS:ffff9e242f800000(0000) knlGS:0000000000000000 [ 15.000617] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 15.006359] CR2: 0000000000000000 CR3: 0000000013c0a001 CR4: 00000000003606f0 [ 15.013504] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 15.020628] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 15.027752] Call Trace: [ 15.030198] <IRQ> [ 15.032207] __sk_free+0x71/0x110 [ 15.035518] __sock_wfree+0x2c/0x30 [ 15.039002] skb_release_head_state+0x56/0xa0 [ 15.043359] napi_consume_skb+0x5a/0x140 [ 15.047297] igb_poll+0xc7/0xf30 [ 15.050522] net_rx_action+0x13a/0x3a0 [ 15.054273] ? __napi_schedule+0x54/0x70 [ 15.058189] __do_softirq+0xf6/0x2ed [ 15.061760] irq_exit+0xab/0xe0 [ 15.064897] do_IRQ+0x86/0xe0 [ 15.067862] common_interrupt+0xf/0xf [ 15.071519] </IRQ> [ 15.073618] RIP: 0010:cpuidle_enter_state+0x119/0x2c0 [ 15.078669] Code: 77 ff 80 7d c7 00 74 12 9c 58 f6 c4 02 0f 85 8e 01 00 00 31 ff e8 07 1d 7d ff e8 b2 84 82 ff fb 48 ba cf f7 53 e3 a5 9b c4 20 <4c> 2b 7d c8 4c 89 f8 49 c1 ff 3f 48 f7 ea b8 ff ff ff 7f 48 c1 fa [ 15.097405] RSP: 0000:ffffffff9ce03e00 EFLAGS: 00000282 ORIG_RAX: ffffffffffffffdc [ 15.104961] RAX: ffffffff9ce03e40 RBX: ffff9e242d6ce000 RCX: 000000000000001f [ 15.112085] RDX: 20c49ba5e353f7cf RSI: ffffffff9c028777 RDI: ffffffff9c02858e [ 15.119210] RBP: ffffffff9ce03e40 R08: 0000000378293f7f R09: 0000000000000022 [ 15.126358] R10: 0000000000000034 R11: ffff9e242f81ed08 R12: 0000000000000001 [ 15.133510] R13: ffffffff9ceca620 R14: ffffffff9ceca680 R15: 0000000378293f7f [ 15.140636] ? cpuidle_enter+0x17/0x20 [ 15.144415] ? cpuidle_enter_state+0x10e/0x2c0 [ 15.148859] cpuidle_enter+0x17/0x20 [ 15.152430] call_cpuidle+0x23/0x40 [ 15.155914] do_idle+0x1b9/0x240 [ 15.159138] cpu_startup_entry+0x73/0x80 [ 15.163055] rest_init+0xa3/0xa5 [ 15.166280] start_kernel+0x483/0x4a5 [ 15.169937] x86_64_start_reservations+0x24/0x26 [ 15.174547] x86_64_start_kernel+0x70/0x74 [ 15.178637] secondary_startup_64+0xa4/0xb0 [ 15.182813] Modules linked in: [ 15.185866] CR2: 0000000000000000 [ 15.189177] ---[ end trace 87e25bcdd88d2b4b ]--- [ 15.193785] RIP: 0010:__sk_destruct+0xb9/0x190 [ 15.198222] Code: 48 8b 47 08 48 8d 50 ff a8 01 48 0f 45 fa f0 ff 4f 34 0f 84 d9 00 00 00 48 c7 83 00 ff ff ff 00 00 00 00 48 8b bb 78 ff ff ff <f0> ff 0f 0f 84 a0 00 00 00 48 8b bb 70 ff ff ff e8 32 41 6d ff f6 [ 15.216960] RSP: 0000:ffff9e242f803dc0 EFLAGS: 00010246 [ 15.222176] RAX: 0000000000000000 RBX: ffff9e242cfc82c0 RCX: 0000000000000001 [ 15.229302] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 [ 15.236424] RBP: ffff9e242f803de0 R08: ffff9e242cfc8000 R09: 0000000000000000 [ 15.243548] R10: 0000000000000000 R11: 0000000000000000 R12: ffff9e242cfc8000 [ 15.250673] R13: ffff9e242cfc82c0 R14: ffff9e242cde8600 R15: 00000000ffffff0c [ 15.257796] FS: 0000000000000000(0000) GS:ffff9e242f800000(0000) knlGS:0000000000000000 [ 15.265872] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 15.271613] CR2: 0000000000000000 CR3: 0000000013c0a001 CR4: 00000000003606f0 [ 15.278734] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 15.285858] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 15.292982] Kernel panic - not syncing: Fatal exception in interrupt [ 15.299375] Kernel Offset: 0x1a600000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff)
Reported-by: Linux Kernel Functional Testing lkft@linaro.org
ref: https://lkft.validation.linaro.org/scheduler/job/3657592#L928 https://lkft.validation.linaro.org/scheduler/job/3657638#L933 https://lkft.validation.linaro.org/scheduler/job/3657762#L949 https://lkft.validation.linaro.org/scheduler/job/3657822#L1899
-- Linaro LKFT https://lkft.linaro.org
On 10/4/21 11:44 AM, Eric Dumazet wrote:
On Mon, Oct 4, 2021 at 10:40 AM Naresh Kamboju naresh.kamboju@linaro.org wrote:
On Mon, 4 Oct 2021 at 18:32, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.209 release. There are 95 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 06 Oct 2021 12:50:17 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.209-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Regression found on arm, arm64, i386 and x86. following kernel crash reported on stable-rc linux-4.19.y.
Stable teams should backport cred: allow get_cred() and put_cred() to be given NULL.
f06bc03339ad4c1baa964a5f0606247ac1c3c50b
Or they should have tweaked my patch before backporting it.
Seeing the same problem on my test system as well.
Patch applied with fuzz. Didn't need any tweaks. Compiling now. Will let you know soon.
thanks, -- Shuah
On 10/4/21 1:49 PM, Shuah Khan wrote:
On 10/4/21 11:44 AM, Eric Dumazet wrote:
On Mon, Oct 4, 2021 at 10:40 AM Naresh Kamboju naresh.kamboju@linaro.org wrote:
On Mon, 4 Oct 2021 at 18:32, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.209 release. There are 95 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 06 Oct 2021 12:50:17 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.209-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Regression found on arm, arm64, i386 and x86. following kernel crash reported on stable-rc linux-4.19.y.
Stable teams should backport cred: allow get_cred() and put_cred() to be given NULL.
f06bc03339ad4c1baa964a5f0606247ac1c3c50b
Or they should have tweaked my patch before backporting it.
Seeing the same problem on my test system as well.
Patch applied with fuzz. Didn't need any tweaks. Compiling now. Will let you know soon.
With f06bc03339ad4c1baa964a5f0606247ac1c3c50b
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan skhan@linuxfoundation.org
-----------------------------------------------------------------------
diff --git a/include/linux/cred.h b/include/linux/cred.h index 1dc351d8548b..4b081e4911c8 100644 --- a/include/linux/cred.h +++ b/include/linux/cred.h @@ -240,7 +240,7 @@ static inline struct cred *get_new_cred(struct cred *cred) * @cred: The credentials to reference * * Get a reference on the specified set of credentials. The caller must - * release the reference. + * release the reference. If %NULL is passed, it is returned with no action. * * This is used to deal with a committed set of credentials. Although the * pointer is const, this will temporarily discard the const and increment the @@ -251,6 +251,8 @@ static inline struct cred *get_new_cred(struct cred *cred) static inline const struct cred *get_cred(const struct cred *cred) { struct cred *nonconst_cred = (struct cred *) cred; + if (!cred) + return cred; validate_creds(cred); nonconst_cred->non_rcu = 0; return get_new_cred(nonconst_cred); @@ -261,7 +263,7 @@ static inline const struct cred *get_cred(const struct cred *cred) * @cred: The credentials to release * * Release a reference to a set of credentials, deleting them when the last ref - * is released. + * is released. If %NULL is passed, nothing is done. * * This takes a const pointer to a set of credentials because the credentials * on task_struct are attached by const pointers to prevent accidental @@ -271,9 +273,11 @@ static inline void put_cred(const struct cred *_cred) { struct cred *cred = (struct cred *) _cred;
- validate_creds(cred); - if (atomic_dec_and_test(&(cred)->usage)) - __put_cred(cred); + if (cred) { + validate_creds(cred); + if (atomic_dec_and_test(&(cred)->usage)) + __put_cred(cred); + } }
/**
-----------------------------------------------------------------------
thanks, -- Shuah
On Mon, Oct 04, 2021 at 10:44:50AM -0700, Eric Dumazet wrote:
On Mon, Oct 4, 2021 at 10:40 AM Naresh Kamboju naresh.kamboju@linaro.org wrote:
On Mon, 4 Oct 2021 at 18:32, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.209 release. There are 95 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 06 Oct 2021 12:50:17 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.209-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Regression found on arm, arm64, i386 and x86. following kernel crash reported on stable-rc linux-4.19.y.
Stable teams should backport cred: allow get_cred() and put_cred() to be given NULL.
f06bc03339ad4c1baa964a5f0606247ac1c3c50b
Or they should have tweaked my patch before backporting it.
Thanks, I have now queued that up, it was not obvious that was a prerequisite for your change :)
greg k-h
Hi!
This is the start of the stable review cycle for the 4.19.209 release. There are 95 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 06 Oct 2021 12:50:17 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.209-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Regression found on arm, arm64, i386 and x86. following kernel crash reported on stable-rc linux-4.19.y.
metadata: git branch: linux-4.19.y git repo: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc git commit: ee3e528d83e91547f386a30677ccb96c28e78218 git describe: v4.19.208-96-gee3e528d83e9 make_kernelversion: 4.19.209-rc1 kernel-config: https://builds.tuxbuild.com/1z2izwX1xMgF2OSYM5EN6ELHEij/config
Kernel crash:
[ 14.900875] BUG: unable to handle kernel NULL pointer dereference at 0000000000000000 [ 14.908699] PGD 0 P4D 0 [ 14.911230] Oops: 0002 [#1] SMP PTI [ 14.914714] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.19.209-rc1 #1 [ 14.921147] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS 2.2 05/23/2018 [ 14.928531] RIP: 0010:__sk_destruct+0xb9/0x190 [ 14.932965] Code: 48 8b 47 08 48 8d 50 ff a8 01 48 0f 45 fa f0 ff 4f 34 0f 84 d9 00 00 00 48 c7 83 00 ff ff ff 00 00 00 00 48 8b bb 78 ff ff ff <f0> ff 0f 0f 84 a0 00 00 00 48 8b bb 70 ff ff ff e8 32 41 6d ff f6
I believe we see the same failure in testing:
https://lava.ciplatform.org/scheduler/job/455022
[ 0.000000] Booting Linux on physical CPU 0x0 [ 0.000000] Linux version 4.19.209-rc1-gee3e528d83e9-dirty (root@runner-ryfx8chz-project-14394223-concurrent-0xchkx) () #1 SMP Mon Oct 4 17:14:39 UTC 2021 [ 0.000000] CPU: ARMv7 Processor [413fc0f2] revision 2 (ARMv7), cr=10c5387d [ 0.000000] CPU: div instructions available: patching division code ... [ 7.215118] nameserver0=192.168.1.1 [ 7.228063] Unable to handle kernel NULL pointer dereference at virtual address 00000000 [ 7.236165] pgd = (ptrval) [ 7.238867] [00000000] *pgd=00000000 [ 7.242442] Internal error: Oops: 5 [#1] SMP ARM [ 7.247055] Modules linked in: [ 7.250110] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.19.209-rc1-gee3e528d83e9-dirty #1 [ 7.258286] Hardware name: Generic RZ/G1 (Flattened Device Tree) [ 7.264318] PC is at __sk_destruct+0xa8/0x11c [ 7.268690] LR is at __sk_destruct+0x4c/0x11c [ 7.273058] pc : [<c0ce244c>] lr : [<c0ce23f0>] psr: 60000113
Best regards, Pavel
On Mon, Oct 04, 2021 at 02:51:30PM +0200, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 4.19.209 release. There are 95 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 06 Oct 2021 12:50:17 +0000. Anything received after that time might be too late.
Build results: total: 155 pass: 155 fail: 0 Qemu test results: total: 439 pass: 5 fail: 434 Failed tests: <many>
Again, presumably the same crash as reported by everyone else.
Guenter