This is the start of the stable review cycle for the 4.19.4 release. There are 42 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri Nov 23 18:31:31 UTC 2018. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.4-rc1.... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
------------- Pseudo-Shortlog of commits:
Greg Kroah-Hartman gregkh@linuxfoundation.org Linux 4.19.4-rc1
Greg Kroah-Hartman gregkh@linuxfoundation.org Revert "x86/speculation: Enable cross-hyperthread spectre v2 STIBP mitigation"
Frieder Schrempf frieder.schrempf@kontron.de usbnet: smsc95xx: disable carrier check while suspending
David Howells dhowells@redhat.com rxrpc: Fix lockup due to no error backoff after ack transmit error
Stefan Wahren stefan.wahren@i2se.com net: smsc95xx: Fix MTU range
Shalom Toledo shalomt@mellanox.com mlxsw: spectrum: Fix IP2ME CPU policer configuration
Xin Long lucien.xin@gmail.com sctp: not increase stream's incnt before sending addstrm_in request
Martin Schiller ms@dev.tdt.de net: phy: mdio-gpio: Fix working over slow can_sleep GPIOs
Xin Long lucien.xin@gmail.com sctp: fix strchange_flags name for Stream Change Event
Tristram Ha Tristram.Ha@microchip.com net: dsa: microchip: initialize mutex before use
Subash Abhinov Kasiviswanathan subashab@codeaurora.org net: qualcomm: rmnet: Fix incorrect assignment of real_dev
Xin Long lucien.xin@gmail.com sctp: define SCTP_SS_DEFAULT for Stream schedulers
Holger Hoffstätte holger@applied-asynchrony.com net: phy: realtek: fix RTL8201F sysfs name
Andrew Lunn andrew@lunn.ch net: dsa: mv88e6xxx: Fix clearing of stats counters
Denis Drozdov denisd@mellanox.com net/mlx5e: IPoIB, Reset QP after channels are closed
Raed Salem raeds@mellanox.com net/mlx5: IPSec, Fix the SA context hash key
Xin Long lucien.xin@gmail.com l2tp: fix a sock refcnt leak in l2tp_tunnel_register
Eric Dumazet edumazet@google.com inet: frags: better deal with smp races
Shay Agroskin shayag@mellanox.com net/mlx5e: Removed unnecessary warnings in FEC caps query
Valentine Fatiev valentinef@mellanox.com net/mlx5e: Fix selftest for small MTUs
Or Gerlitz ogerlitz@mellanox.com net/mlx5e: Always use the match level enum when parsing TC rule match
Xin Long lucien.xin@gmail.com Revert "sctp: remove sctp_transport_pmtu_check"
Moshe Shemesh moshe@mellanox.com net/mlx5e: RX, verify received packet size in Linear Striding RQ
Yuval Avnery yuvalav@mellanox.com net/mlx5e: Adjust to max number of channles when re-attaching
Or Gerlitz ogerlitz@mellanox.com net/mlx5e: Claim TC hw offloads support only under a proper build config
Or Gerlitz ogerlitz@mellanox.com net/mlx5e: Don't match on vlan non-existence if ethertype is wildcarded
Jon Maloy donmalo99@gmail.com tipc: fix link re-establish failure
Jakub Kicinski jakub.kicinski@netronome.com net: sched: cls_flower: validate nested enc_opts_policy to avoid warning
Davide Caratti dcaratti@redhat.com net/sched: act_pedit: fix memory leak when IDR allocation fails
Florian Fainelli f.fainelli@gmail.com net: systemport: Protect stop from timeout
Matthew Cover werekraken@gmail.com tuntap: fix multiqueue rx
Jon Maloy donmalo99@gmail.com tipc: fix lockdep warning when reinitilaizing sockets
Jon Maloy donmalo99@gmail.com tipc: don't assume linear buffer when reading ancillary data
Siva Reddy Kallam siva.kallam@broadcom.com tg3: Add PHY reset for 5717/5719/5720 in change ring and flow control paths
Stephen Mallon stephen.mallon@sydney.edu.au tcp: Fix SOF_TIMESTAMPING_RX_HARDWARE to use the latest timestamp during TCP coalescing
Xin Long lucien.xin@gmail.com sctp: not allow to set asoc prsctp_enable by sockopt
Eric Dumazet edumazet@google.com net-gro: reset skb->pkt_type in napi_reuse_skb()
Doug Berger opendmb@gmail.com net: bcmgenet: protect stop from timeout
David Ahern dsahern@gmail.com ipv6: Fix PMTU updates for UDP/raw sockets in presence of VRF
Xin Long lucien.xin@gmail.com ipv6: fix a dst leak when removing its exception
Sabrina Dubroca sd@queasysnail.net ip_tunnel: don't force DF when MTU is locked
Michał Mirosław mirq-linux@rere.qmqm.pl ibmvnic: fix accelerated VLAN handling
배석진 soukjin.bae@samsung.com flow_dissector: do not dissect l4 ports for fragments
-------------
Diffstat:
Makefile | 4 +- arch/x86/kernel/cpu/bugs.c | 57 ++---------------- drivers/net/dsa/microchip/ksz_common.c | 10 ++-- drivers/net/dsa/mv88e6xxx/global1.c | 2 + drivers/net/ethernet/broadcom/bcmsysport.c | 15 +++-- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 13 +++-- drivers/net/ethernet/broadcom/tg3.c | 18 +++++- drivers/net/ethernet/ibm/ibmvnic.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en.h | 1 + drivers/net/ethernet/mellanox/mlx5/core/en/port.c | 4 +- .../ethernet/mellanox/mlx5/core/en/port_buffer.c | 4 +- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 37 ++++++++++-- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 6 ++ .../net/ethernet/mellanox/mlx5/core/en_selftest.c | 26 ++++----- drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 3 + drivers/net/ethernet/mellanox/mlx5/core/en_stats.h | 2 + drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 67 +++++++++++----------- .../net/ethernet/mellanox/mlx5/core/fpga/ipsec.c | 10 +++- .../net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c | 2 +- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 1 - drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 6 +- drivers/net/phy/mdio-gpio.c | 10 ++-- drivers/net/phy/realtek.c | 2 +- drivers/net/tun.c | 6 +- drivers/net/usb/smsc95xx.c | 9 +++ include/net/sctp/sctp.h | 12 ++++ include/uapi/linux/sctp.h | 3 + kernel/cpu.c | 11 +--- net/core/dev.c | 4 ++ net/core/flow_dissector.c | 4 +- net/ipv4/inet_fragment.c | 29 +++++----- net/ipv4/ip_tunnel_core.c | 2 +- net/ipv4/tcp_input.c | 1 + net/ipv6/route.c | 14 +++-- net/l2tp/l2tp_core.c | 9 ++- net/rxrpc/ar-internal.h | 1 + net/rxrpc/call_event.c | 18 ++++-- net/rxrpc/output.c | 35 +++++++++-- net/sched/act_pedit.c | 3 +- net/sched/cls_flower.c | 14 ++++- net/sctp/output.c | 3 + net/sctp/outqueue.c | 2 +- net/sctp/socket.c | 26 ++------- net/sctp/stream.c | 1 - net/tipc/discover.c | 19 +++--- net/tipc/link.c | 11 ++-- net/tipc/net.c | 45 ++++++++++++--- net/tipc/net.h | 2 +- net/tipc/socket.c | 15 +++-- 49 files changed, 356 insertions(+), 245 deletions(-)
stable-rc/linux-4.19.y boot: 96 boots: 0 failed, 93 passed with 3 offline (v4.19.3-43-g2b8db8734888)
Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.19.y/kernel/v4.19... Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.19.y/kernel/v4.19.3-43-g...
Tree: stable-rc Branch: linux-4.19.y Git Describe: v4.19.3-43-g2b8db8734888 Git Commit: 2b8db8734888b00156c6afb235eda91aa71da503 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 55 unique boards, 21 SoC families, 15 builds out of 198
Offline Platforms:
arm:
multi_v7_defconfig: stih410-b2120: 1 offline lab
arm64:
defconfig: meson-gxl-s905d-p230: 1 offline lab meson-gxl-s905x-p212: 1 offline lab
--- For more info write to info@kernelci.org
On 22 November 2018 12:35:36 AM IST, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.4 release. There are 42 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri Nov 23 18:31:31 UTC 2018. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.4-rc1.... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Built and booted on the Lenovo IdeaPad 330-15ARR, no dmesg regressions.
On Thu, Nov 22, 2018 at 12:45:42PM +0530, Harsh Shandilya wrote:
On 22 November 2018 12:35:36 AM IST, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.4 release. There are 42 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri Nov 23 18:31:31 UTC 2018. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.4-rc1.... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Built and booted on the Lenovo IdeaPad 330-15ARR, no dmesg regressions.
Wonderful, thanks for testing and letting me know.
greg k-h
On 11/21/18 11:05 AM, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 4.19.4 release. There are 42 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri Nov 23 18:31:31 UTC 2018. Anything received after that time might be too late.
Build results: total: 135 pass: 135 fail: 0 Qemu test results: total: 291 pass: 291 fail: 0
Details are available at https://kerneltests.org/builders/.
Guenter
On Thu, Nov 22, 2018 at 08:36:12AM -0800, Guenter Roeck wrote:
On 11/21/18 11:05 AM, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 4.19.4 release. There are 42 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri Nov 23 18:31:31 UTC 2018. Anything received after that time might be too late.
Build results: total: 135 pass: 135 fail: 0 Qemu test results: total: 291 pass: 291 fail: 0
Details are available at https://kerneltests.org/builders/.
Thanks for testing all of these and letting me know.
greg k-h
Doesn't compile for me on OpenSuSE 15.0 (gcc 7.3.1):
CALL scripts/checksyscalls.sh DESCEND objtool CHK include/generated/compile.h CC [M] drivers/gpu/drm/i915/i915_gem_gtt.o drivers/gpu/drm/i915/i915_gem_gtt.c: In function ‘gen6_dump_ppgtt’: drivers/gpu/drm/i915/i915_gem_gtt.c:1771:41: error: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘long unsigned int’ [-Werror=format=] seq_printf(m, "\t\t(%03d, %04d) %08llx: ", ~~~~~^ %08lx cc1: all warnings being treated as errors make[4]: *** [scripts/Makefile.build:306: drivers/gpu/drm/i915/i915_gem_gtt.o] Error 1 make[3]: *** [scripts/Makefile.build:546: drivers/gpu/drm/i915] Error 2 make[2]: *** [scripts/Makefile.build:546: drivers/gpu/drm] Error 2 make[1]: *** [scripts/Makefile.build:546: drivers/gpu] Error 2 make: *** [Makefile:1052: drivers] Error 2
4.19.3 is broken for me, too. 4.19.2 is works. 4.20-rc tree works.
Config attached.
Thomas
On Thu, 22 Nov 2018, Thomas Voegtle wrote:
Doesn't compile for me on OpenSuSE 15.0 (gcc 7.3.1):
CALL scripts/checksyscalls.sh DESCEND objtool CHK include/generated/compile.h CC [M] drivers/gpu/drm/i915/i915_gem_gtt.o drivers/gpu/drm/i915/i915_gem_gtt.c: In function ‘gen6_dump_ppgtt’: drivers/gpu/drm/i915/i915_gem_gtt.c:1771:41: error: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘long unsigned int’ [-Werror=format=] seq_printf(m, "\t\t(%03d, %04d) %08llx: ", ~~~~~ ^ %08lx cc1: all warnings being treated as errors make[4]: *** [scripts/Makefile.build:306: drivers/gpu/drm/i915/i915_gem_gtt.o] Error 1 make[3]: *** [scripts/Makefile.build:546: drivers/gpu/drm/i915] Error 2 make[2]: *** [scripts/Makefile.build:546: drivers/gpu/drm] Error 2 make[1]: *** [scripts/Makefile.build:546: drivers/gpu] Error 2 make: *** [Makefile:1052: drivers] Error 2
4.19.3 is broken for me, too. 4.19.2 is works. 4.20-rc tree works.
Config attached.
quick bisect shows problem is:
commit 1a25e1a1be71a49ee7f34fb14b5a26191e6cf501 Author: Chris Wilson chris@chris-wilson.co.uk Date: Thu Oct 25 10:18:22 2018 +0100
drm/i915: Mark up GTT sizes as u64
commit c58281056a8b26d5d9dc15c19859a7880835ef44 upstream.
reverted on 4.19.4-rc1 it compiles for me. I guess something is missing here?
Thomas
On 11/22/18 2:01 PM, Thomas Voegtle wrote:
On Thu, 22 Nov 2018, Thomas Voegtle wrote:
Doesn't compile for me on OpenSuSE 15.0 (gcc 7.3.1):
CALL scripts/checksyscalls.sh DESCEND objtool CHK include/generated/compile.h CC [M] drivers/gpu/drm/i915/i915_gem_gtt.o drivers/gpu/drm/i915/i915_gem_gtt.c: In function ‘gen6_dump_ppgtt’: drivers/gpu/drm/i915/i915_gem_gtt.c:1771:41: error: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘long unsigned int’ [-Werror=format=] seq_printf(m, "\t\t(%03d, %04d) %08llx: ", ~~~~~ ^ %08lx cc1: all warnings being treated as errors make[4]: *** [scripts/Makefile.build:306: drivers/gpu/drm/i915/i915_gem_gtt.o] Error 1 make[3]: *** [scripts/Makefile.build:546: drivers/gpu/drm/i915] Error 2 make[2]: *** [scripts/Makefile.build:546: drivers/gpu/drm] Error 2 make[1]: *** [scripts/Makefile.build:546: drivers/gpu] Error 2 make: *** [Makefile:1052: drivers] Error 2
4.19.3 is broken for me, too. 4.19.2 is works. 4.20-rc tree works.
Config attached.
quick bisect shows problem is:
commit 1a25e1a1be71a49ee7f34fb14b5a26191e6cf501 Author: Chris Wilson chris@chris-wilson.co.uk Date: Thu Oct 25 10:18:22 2018 +0100
drm/i915: Mark up GTT sizes as u64
commit c58281056a8b26d5d9dc15c19859a7880835ef44 upstream.
reverted on 4.19.4-rc1 it compiles for me. I guess something is missing here?
AFAICS someone was not careful with the backport. Upstream doesn't have %llx at that place.
Guenter
On Thu, Nov 22, 2018 at 02:30:58PM -0800, Guenter Roeck wrote:
On 11/22/18 2:01 PM, Thomas Voegtle wrote:
On Thu, 22 Nov 2018, Thomas Voegtle wrote:
Doesn't compile for me on OpenSuSE 15.0 (gcc 7.3.1):
CALL scripts/checksyscalls.sh DESCEND objtool CHK include/generated/compile.h CC [M] drivers/gpu/drm/i915/i915_gem_gtt.o drivers/gpu/drm/i915/i915_gem_gtt.c: In function ‘gen6_dump_ppgtt’: drivers/gpu/drm/i915/i915_gem_gtt.c:1771:41: error: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘long unsigned int’ [-Werror=format=] seq_printf(m, "\t\t(%03d, %04d) %08llx: ", ~~~~~ ^ %08lx cc1: all warnings being treated as errors make[4]: *** [scripts/Makefile.build:306: drivers/gpu/drm/i915/i915_gem_gtt.o] Error 1 make[3]: *** [scripts/Makefile.build:546: drivers/gpu/drm/i915] Error 2 make[2]: *** [scripts/Makefile.build:546: drivers/gpu/drm] Error 2 make[1]: *** [scripts/Makefile.build:546: drivers/gpu] Error 2 make: *** [Makefile:1052: drivers] Error 2
4.19.3 is broken for me, too. 4.19.2 is works. 4.20-rc tree works.
Config attached.
quick bisect shows problem is:
commit 1a25e1a1be71a49ee7f34fb14b5a26191e6cf501 Author: Chris Wilson chris@chris-wilson.co.uk Date: Thu Oct 25 10:18:22 2018 +0100
drm/i915: Mark up GTT sizes as u64
commit c58281056a8b26d5d9dc15c19859a7880835ef44 upstream.
reverted on 4.19.4-rc1 it compiles for me. I guess something is missing here?
AFAICS someone was not careful with the backport. Upstream doesn't have %llx at that place.
Ugh, odd. I'll go fix this up for the next round after this release, thans for tracking it down.
greg k-h
On Thu, Nov 22, 2018 at 02:30:58PM -0800, Guenter Roeck wrote:
On 11/22/18 2:01 PM, Thomas Voegtle wrote:
On Thu, 22 Nov 2018, Thomas Voegtle wrote:
Doesn't compile for me on OpenSuSE 15.0 (gcc 7.3.1):
CALL scripts/checksyscalls.sh DESCEND objtool CHK include/generated/compile.h CC [M] drivers/gpu/drm/i915/i915_gem_gtt.o drivers/gpu/drm/i915/i915_gem_gtt.c: In function ‘gen6_dump_ppgtt’: drivers/gpu/drm/i915/i915_gem_gtt.c:1771:41: error: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘long unsigned int’ [-Werror=format=] seq_printf(m, "\t\t(%03d, %04d) %08llx: ", ~~~~~ ^ %08lx cc1: all warnings being treated as errors make[4]: *** [scripts/Makefile.build:306: drivers/gpu/drm/i915/i915_gem_gtt.o] Error 1 make[3]: *** [scripts/Makefile.build:546: drivers/gpu/drm/i915] Error 2 make[2]: *** [scripts/Makefile.build:546: drivers/gpu/drm] Error 2 make[1]: *** [scripts/Makefile.build:546: drivers/gpu] Error 2 make: *** [Makefile:1052: drivers] Error 2
4.19.3 is broken for me, too. 4.19.2 is works. 4.20-rc tree works.
Config attached.
quick bisect shows problem is:
commit 1a25e1a1be71a49ee7f34fb14b5a26191e6cf501 Author: Chris Wilson chris@chris-wilson.co.uk Date: Thu Oct 25 10:18:22 2018 +0100
drm/i915: Mark up GTT sizes as u64
commit c58281056a8b26d5d9dc15c19859a7880835ef44 upstream.
reverted on 4.19.4-rc1 it compiles for me. I guess something is missing here?
AFAICS someone was not careful with the backport. Upstream doesn't have %llx at that place.
Yes it does, unless I'm reading the code wrong?
It seems that this does not trigger on upstream due to f6e35cda6614 ("drm/i915: Replace some PAGE_SIZE with I915_GTT_PAGE_SIZE") being there, which changed the type of the variable being displayed here.
I've now backported that as well, as it should help out over time, and the build warning seems to be gone.
thanks,
greg k-h
On 11/22/18 11:45 PM, Greg Kroah-Hartman wrote:
On Thu, Nov 22, 2018 at 02:30:58PM -0800, Guenter Roeck wrote:
On 11/22/18 2:01 PM, Thomas Voegtle wrote:
On Thu, 22 Nov 2018, Thomas Voegtle wrote:
Doesn't compile for me on OpenSuSE 15.0 (gcc 7.3.1):
CALL scripts/checksyscalls.sh DESCEND objtool CHK include/generated/compile.h CC [M] drivers/gpu/drm/i915/i915_gem_gtt.o drivers/gpu/drm/i915/i915_gem_gtt.c: In function ‘gen6_dump_ppgtt’: drivers/gpu/drm/i915/i915_gem_gtt.c:1771:41: error: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘long unsigned int’ [-Werror=format=] seq_printf(m, "\t\t(%03d, %04d) %08llx: ", ~~~~~ ^ %08lx cc1: all warnings being treated as errors make[4]: *** [scripts/Makefile.build:306: drivers/gpu/drm/i915/i915_gem_gtt.o] Error 1 make[3]: *** [scripts/Makefile.build:546: drivers/gpu/drm/i915] Error 2 make[2]: *** [scripts/Makefile.build:546: drivers/gpu/drm] Error 2 make[1]: *** [scripts/Makefile.build:546: drivers/gpu] Error 2 make: *** [Makefile:1052: drivers] Error 2
4.19.3 is broken for me, too. 4.19.2 is works. 4.20-rc tree works.
Config attached.
quick bisect shows problem is:
commit 1a25e1a1be71a49ee7f34fb14b5a26191e6cf501 Author: Chris Wilson chris@chris-wilson.co.uk Date: Thu Oct 25 10:18:22 2018 +0100
drm/i915: Mark up GTT sizes as u64
commit c58281056a8b26d5d9dc15c19859a7880835ef44 upstream.
reverted on 4.19.4-rc1 it compiles for me. I guess something is missing here?
AFAICS someone was not careful with the backport. Upstream doesn't have %llx at that place.
Yes it does, unless I'm reading the code wrong?
Ah, I was looking at v4.20-rc1, which didn't have it. Wrong branch, sorry.
It seems that this does not trigger on upstream due to f6e35cda6614 ("drm/i915: Replace some PAGE_SIZE with I915_GTT_PAGE_SIZE") being there, which changed the type of the variable being displayed here.
I've now backported that as well, as it should help out over time, and
the build warning seems to be gone.
Makes sense.
Thanks, Guenter
On Thu, Nov 22, 2018 at 09:53:35PM +0100, Thomas Voegtle wrote:
Doesn't compile for me on OpenSuSE 15.0 (gcc 7.3.1):
CALL scripts/checksyscalls.sh DESCEND objtool CHK include/generated/compile.h CC [M] drivers/gpu/drm/i915/i915_gem_gtt.o drivers/gpu/drm/i915/i915_gem_gtt.c: In function ‘gen6_dump_ppgtt’: drivers/gpu/drm/i915/i915_gem_gtt.c:1771:41: error: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘long unsigned int’ [-Werror=format=] seq_printf(m, "\t\t(%03d, %04d) %08llx: ", ~~~~~^ %08lx cc1: all warnings being treated as errors
Warnings treated as errors? That's rough, sorry, don't do that :)
I did see this, need to track it down, got distracted by other things...
thanks,
greg k-h
On Fri, 23 Nov 2018, Greg Kroah-Hartman wrote:
On Thu, Nov 22, 2018 at 09:53:35PM +0100, Thomas Voegtle wrote:
Doesn't compile for me on OpenSuSE 15.0 (gcc 7.3.1):
CALL scripts/checksyscalls.sh DESCEND objtool CHK include/generated/compile.h CC [M] drivers/gpu/drm/i915/i915_gem_gtt.o drivers/gpu/drm/i915/i915_gem_gtt.c: In function ‘gen6_dump_ppgtt’: drivers/gpu/drm/i915/i915_gem_gtt.c:1771:41: error: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘long unsigned int’ [-Werror=format=] seq_printf(m, "\t\t(%03d, %04d) %08llx: ", ~~~~~^ %08lx cc1: all warnings being treated as errors
Warnings treated as errors? That's rough, sorry, don't do that :)
I had CONFIG_DRM_I915_WERROR=y for whatever reason. The whole thing confused me a lot. Sorry.
Thomas
From: Thomas Voegtle
Sent: 23 November 2018 15:41 On Fri, 23 Nov 2018, Greg Kroah-Hartman wrote:
On Thu, Nov 22, 2018 at 09:53:35PM +0100, Thomas Voegtle wrote:
Doesn't compile for me on OpenSuSE 15.0 (gcc 7.3.1):
CALL scripts/checksyscalls.sh DESCEND objtool CHK include/generated/compile.h CC [M] drivers/gpu/drm/i915/i915_gem_gtt.o drivers/gpu/drm/i915/i915_gem_gtt.c: In function ‘gen6_dump_ppgtt’: drivers/gpu/drm/i915/i915_gem_gtt.c:1771:41: error: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘long unsigned int’ [-Werror=format=] seq_printf(m, "\t\t(%03d, %04d) %08llx: ", ~~~~~^ %08lx cc1: all warnings being treated as errors
Warnings treated as errors? That's rough, sorry, don't do that :)
I had CONFIG_DRM_I915_WERROR=y for whatever reason. The whole thing confused me a lot. Sorry.
Well, if you compile that code for a 32bit architecture it is likely to print garbage.
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
On Thu, 22 Nov 2018 at 00:36, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.4 release. There are 42 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri Nov 23 18:31:31 UTC 2018. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.4-rc1.... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Results from Linaro’s test farm. No regressions on arm64, arm, x86_64, and i386.
Summary ------------------------------------------------------------------------
kernel: 4.19.4-rc1 git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git git branch: linux-4.19.y git commit: 2b8db8734888b00156c6afb235eda91aa71da503 git describe: v4.19.3-43-g2b8db8734888 Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.19-oe/build/v4.19.3-43-...
No regressions (compared to build v4.19.2-206-g73aa1c86c6ec)
No fixes (compared to build v4.19.2-206-g73aa1c86c6ec)
Ran 18944 total tests in the following environments and test suites.
Environments -------------- - dragonboard-410c - arm64 - hi6220-hikey - arm64 - i386 - juno-r2 - arm64 - qemu_arm - qemu_arm64 - qemu_i386 - qemu_x86_64 - x15 - arm - x86_64
Test Suites ----------- * boot * install-android-platform-tools-r2600 * kselftest * libhugetlbfs * ltp-cap_bounds-tests * ltp-containers-tests * ltp-cve-tests * ltp-fcntl-locktests-tests * ltp-filecaps-tests * ltp-fs-tests * ltp-fs_bind-tests * ltp-fs_perms_simple-tests * ltp-fsx-tests * ltp-io-tests * ltp-ipc-tests * ltp-math-tests * ltp-nptl-tests * ltp-pty-tests * ltp-sched-tests * ltp-securebits-tests * ltp-syscalls-tests * ltp-timers-tests * ltp-hugetlb-tests * ltp-open-posix-tests * kselftest-vsyscall-mode-native * kselftest-vsyscall-mode-none
-
David Laight -
Greg Kroah-Hartman -
Guenter Roeck -
Harsh Shandilya -
kernelci.org bot -
Naresh Kamboju -
Thomas Voegtle