Regression found on arm gcc-11 build. Following build warnings / errors reported on Linux next 20211007.

On Mon, 4 Oct 2021 at 12:29, Prabhakar Kushwaha pkushwaha@marvell.com wrote:

The qed_hsi.h has been updated to support new FW version 8.59.1.0 with changes.

• Updates FW HSI (Hardware Software interface) structures.
• Addition/update in function declaration and defines as per HSI.
• Add generic infrastructure for FW error reporting as part of common event queue handling.
• Move malicious VF error reporting to FW error reporting infrastructure.
• Move consolidation queue initialization from FW context to ramrod message.

qed_hsi.h header file changes lead to change in many files to ensure compilation.

This patch also fixes the existing checkpatch warnings and few important checks.

<trim>

+static int qed_fw_err_handler(struct qed_hwfn *p_hwfn,

•                         u8 opcode,
  

•                         u16 echo,
  

•                         union event_ring_data *data, u8 fw_return_code)
  

+{

•   if (fw_return_code != COMMON_ERR_CODE_ERROR)
  

•           goto eqe_unexpected;
  

•   if (data->err_data.recovery_scope == ERR_SCOPE_FUNC &&
  

•       le16_to_cpu(data->err_data.entity_id) >= MAX_NUM_PFS) {
  

•           qed_sriov_vfpf_malicious(p_hwfn, &data->err_data);
  

•           return 0;
  

•   }
  

metadata: git_describe: next-20211007 git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next git_short_log: f8dc23b3dc0c (\Add linux-next specific files for 20211007) target_arch: arm toolchain: gcc-11

build error : -------------- drivers/net/ethernet/qlogic/qed/qed_dev.c: In function 'qed_fw_err_handler': drivers/net/ethernet/qlogic/qed/qed_dev.c:2390:17: error: implicit declaration of function 'qed_sriov_vfpf_malicious' [-Werror=implicit-function-declaration] 2390 | qed_sriov_vfpf_malicious(p_hwfn, &data->err_data); | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/qlogic/qed/qed_dev.c: In function 'qed_common_eqe_event': drivers/net/ethernet/qlogic/qed/qed_dev.c:2410:24: error: implicit declaration of function 'qed_sriov_eqe_event'; did you mean 'qed_common_eqe_event'? [-Werror=implicit-function-declaration] 2410 | return qed_sriov_eqe_event(p_hwfn, opcode, echo, data, | ^~~~~~~~~~~~~~~~~~~ | qed_common_eqe_event cc1: some warnings being treated as errors make[6]: *** [scripts/Makefile.build:288: drivers/net/ethernet/qlogic/qed/qed_dev.o] Error 1 make[6]: Target '__build' not remade because of errors. make[5]: *** [scripts/Makefile.build:571: drivers/net/ethernet/qlogic/qed] Error 2

Reported-by: Linux Kernel Functional Testing lkft@linaro.org

build link: ----------- https://builds.tuxbuild.com/1zAeXBdIL6bf5zawzmHpVFEQ3wV/build.log

build config: ------------- https://builds.tuxbuild.com/1zAeXBdIL6bf5zawzmHpVFEQ3wV/config

# To install tuxmake on your system globally # sudo pip3 install -U tuxmake tuxmake --runtime podman --target-arch arm --toolchain gcc-11 --kconfig defconfig --kconfig-add https://builds.tuxbuild.com/1zAeXBdIL6bf5zawzmHpVFEQ3wV/config