packetdrill i386 build failed due to below warnings and errors. Building with gcc version 7.3.
tcp_options_iterator.c run_system_call.c: In function 'cmsg_expect_eq': run_system_call.c:860:38: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'size_t {aka unsigned int}' [-Werror=format=] "Bad len in cmsg %d: expected=%lu actual=%lu", ~~^ %u i, ecm->cmsg_len, acm->cmsg_len); ~~~~~~~~~~~~~ run_system_call.c:860:49: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t {aka unsigned int}' [-Werror=format=] "Bad len in cmsg %d: expected=%lu actual=%lu", ~~^ %u i, ecm->cmsg_len, acm->cmsg_len); ~~~~~~~~~~~~~ run_system_call.c: In function 'get_epoll_event_from_expr': run_system_call.c:2924:21: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] event->data.ptr = (void *)epollev_expr->ptr->value.num; ^ run_system_call.c: In function 'syscall_epoll_wait': run_system_call.c:3129:6: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'uint64_t {aka long long unsigned int}' [-Werror=format=] "epoll_event->data does not match script: " ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ run_system_call.c:3132:6: event_script.data.u64, ~~~~~~~~~~~~~~~~~~~~~ run_system_call.c:3130:19: note: format string is defined here "expected: %lu " ~~^ %llu run_system_call.c:3129:6: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'uint64_t {aka long long unsigned int}' [-Werror=format=] "epoll_event->data does not match script: " ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ run_system_call.c:3133:6: event_live->data.u64); ~~~~~~~~~~~~~~~~~~~~ run_system_call.c:3131:17: note: format string is defined here "actual: %lu\n", ~~^ %llu run_system_call.c: In function 'syscall_splice': run_system_call.c:3249:31: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] result = splice(fd_in_live, (loff_t *) off_in, fd_out_live, ^ run_system_call.c:3250:5: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] (loff_t *) off_out, len, flags); ^
Full log link, https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-mainline/DISTRO=...
-- Linaro LKFT https://lkft.linaro.org
Thanks for the report. If you want to propose a patch that can allow packetdrill to build on i386 Linux while still compiling on 64-bit x86 Linux/FreeBSD/OpenBSD/NetBSD, please feel free to submit a patch:
https://github.com/google/packetdrill#how-to-submit-a-patch-for-packetdrill
thanks, neal
On Mon, Apr 19, 2021 at 6:55 AM Naresh Kamboju naresh.kamboju@linaro.org wrote:
packetdrill i386 build failed due to below warnings and errors. Building with gcc version 7.3.
tcp_options_iterator.c run_system_call.c: In function 'cmsg_expect_eq': run_system_call.c:860:38: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'size_t {aka unsigned int}' [-Werror=format=] "Bad len in cmsg %d: expected=%lu actual=%lu", ~~^ %u i, ecm->cmsg_len, acm->cmsg_len); ~~~~~~~~~~~~~ run_system_call.c:860:49: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t {aka unsigned int}' [-Werror=format=] "Bad len in cmsg %d: expected=%lu actual=%lu", ~~^ %u i, ecm->cmsg_len, acm->cmsg_len); ~~~~~~~~~~~~~ run_system_call.c: In function 'get_epoll_event_from_expr': run_system_call.c:2924:21: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] event->data.ptr = (void *)epollev_expr->ptr->value.num; ^ run_system_call.c: In function 'syscall_epoll_wait': run_system_call.c:3129:6: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'uint64_t {aka long long unsigned int}' [-Werror=format=] "epoll_event->data does not match script: " ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ run_system_call.c:3132:6: event_script.data.u64, ~~~~~~~~~~~~~~~~~~~~~ run_system_call.c:3130:19: note: format string is defined here "expected: %lu " ~~^ %llu run_system_call.c:3129:6: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'uint64_t {aka long long unsigned int}' [-Werror=format=] "epoll_event->data does not match script: " ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ run_system_call.c:3133:6: event_live->data.u64); ~~~~~~~~~~~~~~~~~~~~ run_system_call.c:3131:17: note: format string is defined here "actual: %lu\n", ~~^ %llu run_system_call.c: In function 'syscall_splice': run_system_call.c:3249:31: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] result = splice(fd_in_live, (loff_t *) off_in, fd_out_live, ^ run_system_call.c:3250:5: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] (loff_t *) off_out, len, flags); ^
Full log link,
https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-mainline/DISTRO=...
-- Linaro LKFT https://lkft.linaro.org
Hi Neal,
On Mon, 19 Apr 2021 at 19:11, Neal Cardwell ncardwell@google.com wrote:
Thanks for the report. If you want to propose a patch that can allow packetdrill to build on i386 Linux while still compiling on 64-bit x86 Linux/FreeBSD/OpenBSD/NetBSD, please feel free to submit a patch:
Please review this pull request from Anders,
Fix 32bit builds https://github.com/google/packetdrill/pull/50
- Naresh
On Wed, Apr 28, 2021 at 10:14 AM Naresh Kamboju naresh.kamboju@linaro.org wrote:
Hi Neal,
On Mon, 19 Apr 2021 at 19:11, Neal Cardwell ncardwell@google.com wrote:
Thanks for the report. If you want to propose a patch that can allow
packetdrill to build on i386 Linux while still compiling on 64-bit x86 Linux/FreeBSD/OpenBSD/NetBSD, please feel free to submit a patch:
Please review this pull request from Anders,
Fix 32bit builds https://github.com/google/packetdrill/pull/50
Thanks, I have posted a review for that patch series.
best, neal
- Naresh
On 2021-04-29 10:32, Neal Cardwell wrote:
Ni Neal,
On Wed, Apr 28, 2021 at 10:14 AM Naresh Kamboju naresh.kamboju@linaro.org wrote:
Hi Neal,
On Mon, 19 Apr 2021 at 19:11, Neal Cardwell ncardwell@google.com wrote:
Thanks for the report. If you want to propose a patch that can allow
packetdrill to build on i386 Linux while still compiling on 64-bit x86 Linux/FreeBSD/OpenBSD/NetBSD, please feel free to submit a patch:
Please review this pull request from Anders,
Fix 32bit builds https://github.com/google/packetdrill/pull/50
Thanks, I have posted a review for that patch series.
Thank you for your comments.
What's the best way to contribute to packetdrill?
My PR have been sitting there for 14 days now with questions.
Cheers, Anders