This is the start of the stable review cycle for the 4.19.135 release. There are 86 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 29 Jul 2020 13:48:51 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.135-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
------------- Pseudo-Shortlog of commits:
Greg Kroah-Hartman gregkh@linuxfoundation.org Linux 4.19.135-rc1
Mark O'Donovan shiftee@posteo.net ath9k: Fix regression with Atheros 9271
Qiujun Huang hqjagain@gmail.com ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb
Mikulas Patocka mpatocka@redhat.com dm integrity: fix integrity recalculation that is improperly skipped
Geert Uytterhoeven geert@linux-m68k.org ASoC: qcom: Drop HAS_DMA dependency to fix link failure
Hans de Goede hdegoede@redhat.com ASoC: rt5670: Add new gpio1_is_ext_spk_en quirk and enable it on the Lenovo Miix 2 10
Joerg Roedel jroedel@suse.de x86, vmlinux.lds: Page-align end of ..page_aligned sections
John David Anglin dave.anglin@bell.net parisc: Add atomic64_set_release() define to avoid CPU soft lockups
Qiu Wenbo qiuwenbo@phytium.com.cn drm/amd/powerplay: fix a crash when overclocking Vega M
Paweł Gronowski me@woland.xyz drm/amdgpu: Fix NULL dereference in dpm sysfs handlers
Michael J. Ruhl michael.j.ruhl@intel.com io-mapping: indicate mapping failure
Muchun Song songmuchun@bytedance.com mm: memcg/slab: fix memory leak at non-root kmem_cache destroy
Hugh Dickins hughd@google.com mm/memcg: fix refcount error while moving and swapping
Fangrui Song maskray@google.com Makefile: Fix GCC_TOOLCHAIN_DIR prefix for Clang cross compilation
Tetsuo Handa penguin-kernel@I-love.SAKURA.ne.jp vt: Reject zero-sized screen buffer size.
Tetsuo Handa penguin-kernel@I-love.SAKURA.ne.jp fbdev: Detect integer underflow at "struct fbcon_ops"->clear_margins.
Serge Semin Sergey.Semin@baikalelectronics.ru serial: 8250_mtk: Fix high-speed baud rates clamping
Yang Yingliang yangyingliang@huawei.com serial: 8250: fix null-ptr-deref in serial8250_start_tx()
Ian Abbott abbotti@mev.co.uk staging: comedi: addi_apci_1564: check INSN_CONFIG_DIGITAL_TRIG shift
Ian Abbott abbotti@mev.co.uk staging: comedi: addi_apci_1500: check INSN_CONFIG_DIGITAL_TRIG shift
Ian Abbott abbotti@mev.co.uk staging: comedi: ni_6527: fix INSN_CONFIG_DIGITAL_TRIG support
Ian Abbott abbotti@mev.co.uk staging: comedi: addi_apci_1032: check INSN_CONFIG_DIGITAL_TRIG shift
Rustam Kovhaev rkovhaev@gmail.com staging: wlan-ng: properly check endpoint types
Steve French stfrench@microsoft.com Revert "cifs: Fix the target file was deleted when rename failed."
Forest Crossman cyrozap@gmail.com usb: xhci: Fix ASM2142/ASM3142 DMA addressing
Chunfeng Yun chunfeng.yun@mediatek.com usb: xhci-mtk: fix the failure of bandwidth allocation
Tetsuo Handa penguin-kernel@i-love.sakura.ne.jp binder: Don't use mmput() from shrinker function.
Palmer Dabbelt palmerdabbelt@google.com RISC-V: Upgrade smp_mb__after_spinlock() to iorw,iorw
Arnd Bergmann arnd@arndb.de x86: math-emu: Fix up 'cmp' insn for clang ias
Will Deacon will@kernel.org arm64: Use test_tsk_thread_flag() for checking TIF_SINGLESTEP
Cristian Marussi cristian.marussi@arm.com hwmon: (scmi) Fix potential buffer overflow in scmi_hwmon_probe()
Chu Lin linchuyuan@google.com hwmon: (adm1275) Make sure we are reading enough data for different chips
Evgeny Novikov novikov@ispras.ru usb: gadget: udc: gr_udc: fix memleak on error handling path in gr_ep_init()
Derek Basehore dbasehore@chromium.org Input: elan_i2c - only increment wakeup count on touch
Ilya Katsnelson me@0upti.me Input: synaptics - enable InterTouch for ThinkPad X1E 1st gen
Leonid Ravich Leonid.Ravich@emc.com dmaengine: ioat setting ioat timeout as module parameter
Evgeny Novikov novikov@ispras.ru hwmon: (aspeed-pwm-tacho) Avoid possible buffer overflow
Marc Kleine-Budde mkl@pengutronix.de regmap: dev_get_regmap_match(): fix string comparison
leilk.liu leilk.liu@mediatek.com spi: mediatek: use correct SPI_CFG2_REG MACRO
Merlijn Wajer merlijn@wizzup.org Input: add `SW_MACHINE_COVER`
Dinghao Liu dinghao.liu@zju.edu.cn dmaengine: tegra210-adma: Fix runtime PM imbalance on error
Hans de Goede hdegoede@redhat.com HID: apple: Disable Fn-key key-re-mapping on clone keyboards
Rodrigo Rivas Costa rodrigorivascosta@gmail.com HID: steam: fixes race in handling device list.
Caiyuan Xie caiyuan.xie@cn.alps.com HID: alps: support devices with report id 2
Federico Ricchiuto fed.ricchiuto@gmail.com HID: i2c-hid: add Mediacom FlexBook edge13 to descriptor override
Stefano Garzarella sgarzare@redhat.com scripts/gdb: fix lx-symbols 'gdb.error' while loading modules
Pi-Hsun Shih pihsun@chromium.org scripts/decode_stacktrace: strip basepath from all paths
Matthew Howell matthew.howell@sealevel.com serial: exar: Fix GPIO configuration for Sealevel cards based on XR17V35X
Cong Wang xiyou.wangcong@gmail.com bonding: check return value of register_netdevice() in bond_newlink()
Wolfram Sang wsa+renesas@sang-engineering.com i2c: rcar: always clear ICSAR to avoid side effects
Wang Hai wanghai38@huawei.com net: ethernet: ave: Fix error returns in ave_init
guodeqing geffrey.guo@huawei.com ipvs: fix the connection sync failed in some cases
Alexander Lobakin alobakin@marvell.com qed: suppress "don't support RoCE & iWARP" flooding on HW init
Liu Jian liujian56@huawei.com mlxsw: destroy workqueue when trap_register in mlxsw_emad_init
Taehee Yoo ap420073@gmail.com bonding: check error value of register_netdevice() immediately
Wang Hai wanghai38@huawei.com net: smc91x: Fix possible memory leak in smc_drv_probe()
Chen-Yu Tsai wens@csie.org drm: sun4i: hdmi: Fix inverted HPD result
Liu Jian liujian56@huawei.com ieee802154: fix one possible memleak in adf7242_probe
Sergey Organov sorganov@gmail.com net: dp83640: fix SIOCSHWTSTAMP to update the struct with actual configuration
George Kennedy george.kennedy@oracle.com ax88172a: fix ax88172a_unbind() failures
Christophe JAILLET christophe.jaillet@wanadoo.fr hippi: Fix a size used in a 'pci_free_consistent()' in an error handling path
Matthew Gerlach matthew.gerlach@linux.intel.com fpga: dfl: fix bug in port reset handshake
Vasundhara Volam vasundhara-v.volam@broadcom.com bnxt_en: Fix race when modifying pause settings.
Robbie Ko robbieko@synology.com btrfs: fix page leaks after failure to lock page for delalloc
Boris Burkov boris@bur.io btrfs: fix mount failure caused by race with umount
Filipe Manana fdmanana@suse.com btrfs: fix double free on ulist after backref resolution failure
Hans de Goede hdegoede@redhat.com ASoC: rt5670: Correct RT5670_LDO_SEL_MASK
Takashi Iwai tiwai@suse.de ALSA: info: Drop WARN_ON() from buffer NULL sanity check
Oleg Nesterov oleg@redhat.com uprobes: Change handle_swbp() to send SIGTRAP with si_code=SI_KERNEL, to fix GDB regression
Yang Yingliang yangyingliang@huawei.com IB/umem: fix reference count leak in ib_umem_odp_get()
Jon Maloy jon.maloy@ericsson.com tipc: clean up skb list lock handling on send path
Vladimir Oltean olteanv@gmail.com spi: spi-fsl-dspi: Exit the ISR with IRQ_NONE when it's not ours
Olga Kornievskaia kolga@netapp.com SUNRPC reverting d03727b248d0 ("NFSv4 fix CLOSE not waiting for direct IO compeletion")
Thomas Gleixner tglx@linutronix.de irqdomain/treewide: Keep firmware node unconditionally allocated
Miklos Szeredi mszeredi@redhat.com fuse: fix weird page warning
Gavin Shan gshan@redhat.com drivers/firmware/psci: Fix memory leakage in alloc_init_cpu_groups()
Ben Skeggs bskeggs@redhat.com drm/nouveau/i2c/g94-: increase NV_PMGR_DP_AUXCTL_TRANSACTREQ timeout
Tom Rix trix@redhat.com net: sky2: initialize return of gm_phy_read
Xie He xie.he.0141@gmail.com drivers/net/wan/lapbether: Fixed the value of hard_header_len
Max Filippov jcmvbkbc@gmail.com xtensa: update *pos in cpuinfo_op.next
Max Filippov jcmvbkbc@gmail.com xtensa: fix __sync_fetch_and_{and,or}_4 declarations
Tom Rix trix@redhat.com scsi: scsi_transport_spi: Fix function pointer check
Markus Theil markus.theil@tu-ilmenau.de mac80211: allow rx of mesh eapol frames with default rx key
Jacky Hu hengqing.hu@gmail.com pinctrl: amd: fix npins for uart0 in kerncz_groups
Navid Emamdoost navid.emamdoost@gmail.com gpio: arizona: put pm_runtime in case of failure
Navid Emamdoost navid.emamdoost@gmail.com gpio: arizona: handle pm_runtime_get_sync failure case
Douglas Anderson dianders@chromium.org soc: qcom: rpmh: Dirt can only make you dirtier, not cleaner
-------------
Diffstat:
Makefile | 6 +- arch/arm64/kernel/debug-monitors.c | 4 +- arch/parisc/include/asm/atomic.h | 2 + arch/riscv/include/asm/barrier.h | 10 ++- arch/x86/kernel/apic/io_apic.c | 10 +-- arch/x86/kernel/apic/msi.c | 18 ++++-- arch/x86/kernel/apic/vector.c | 1 - arch/x86/kernel/vmlinux.lds.S | 1 + arch/x86/math-emu/wm_sqrt.S | 2 +- arch/x86/platform/uv/uv_irq.c | 3 +- arch/xtensa/kernel/setup.c | 3 +- arch/xtensa/kernel/xtensa_ksyms.c | 4 +- drivers/android/binder_alloc.c | 2 +- drivers/base/regmap/regmap.c | 2 +- drivers/dma/ioat/dma.c | 12 ++++ drivers/dma/ioat/dma.h | 2 - drivers/dma/tegra210-adma.c | 5 +- drivers/firmware/psci_checker.c | 5 +- drivers/fpga/dfl-afu-main.c | 3 +- drivers/gpio/gpio-arizona.c | 7 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 9 +-- .../gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c | 10 +-- drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c | 4 +- drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgm200.c | 4 +- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 2 +- drivers/hid/hid-alps.c | 2 + drivers/hid/hid-apple.c | 18 ++++++ drivers/hid/hid-steam.c | 6 +- drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c | 8 +++ drivers/hwmon/aspeed-pwm-tacho.c | 2 + drivers/hwmon/pmbus/adm1275.c | 10 ++- drivers/hwmon/scmi-hwmon.c | 2 +- drivers/i2c/busses/i2c-rcar.c | 3 + drivers/infiniband/core/umem_odp.c | 3 +- drivers/input/mouse/elan_i2c_core.c | 7 ++- drivers/input/mouse/synaptics.c | 1 + drivers/iommu/amd_iommu.c | 5 +- drivers/iommu/intel_irq_remapping.c | 2 +- drivers/md/dm-integrity.c | 4 +- drivers/md/dm.c | 17 ++++++ drivers/net/bonding/bond_main.c | 10 ++- drivers/net/bonding/bond_netlink.c | 3 +- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 5 +- drivers/net/ethernet/marvell/sky2.c | 2 +- drivers/net/ethernet/mellanox/mlxsw/core.c | 3 +- drivers/net/ethernet/qlogic/qed/qed_cxt.c | 4 +- drivers/net/ethernet/smsc/smc91x.c | 4 +- drivers/net/ethernet/socionext/sni_ave.c | 2 +- drivers/net/hippi/rrunner.c | 2 +- drivers/net/ieee802154/adf7242.c | 4 +- drivers/net/phy/dp83640.c | 4 ++ drivers/net/usb/ax88172a.c | 1 + drivers/net/wan/lapbether.c | 9 ++- drivers/net/wireless/ath/ath9k/hif_usb.c | 52 ++++++++++++---- drivers/net/wireless/ath/ath9k/hif_usb.h | 5 ++ drivers/pci/controller/vmd.c | 5 +- drivers/pinctrl/pinctrl-amd.h | 2 +- drivers/scsi/scsi_transport_spi.c | 2 +- drivers/soc/qcom/rpmh.c | 8 +-- drivers/spi/spi-fsl-dspi.c | 4 +- drivers/spi/spi-mt65xx.c | 15 ++--- drivers/staging/comedi/drivers/addi_apci_1032.c | 20 ++++-- drivers/staging/comedi/drivers/addi_apci_1500.c | 24 ++++++-- drivers/staging/comedi/drivers/addi_apci_1564.c | 20 ++++-- drivers/staging/comedi/drivers/ni_6527.c | 2 +- drivers/staging/wlan-ng/prism2usb.c | 16 ++++- drivers/tty/serial/8250/8250_core.c | 2 +- drivers/tty/serial/8250/8250_exar.c | 12 +++- drivers/tty/serial/8250/8250_mtk.c | 18 ++++++ drivers/tty/vt/vt.c | 29 +++++---- drivers/usb/gadget/udc/gr_udc.c | 7 ++- drivers/usb/host/xhci-mtk-sch.c | 4 ++ drivers/usb/host/xhci-pci.c | 3 + drivers/video/fbdev/core/bitblit.c | 4 +- drivers/video/fbdev/core/fbcon_ccw.c | 4 +- drivers/video/fbdev/core/fbcon_cw.c | 4 +- drivers/video/fbdev/core/fbcon_ud.c | 4 +- fs/btrfs/backref.c | 1 + fs/btrfs/extent_io.c | 3 +- fs/btrfs/volumes.c | 8 +++ fs/cifs/inode.c | 10 +-- fs/fuse/dev.c | 3 +- fs/nfs/direct.c | 13 ++-- fs/nfs/file.c | 1 - include/asm-generic/vmlinux.lds.h | 5 +- include/linux/device-mapper.h | 1 + include/linux/io-mapping.h | 5 +- include/linux/mod_devicetable.h | 2 +- include/sound/rt5670.h | 1 + include/uapi/linux/input-event-codes.h | 3 +- kernel/events/uprobes.c | 2 +- mm/memcontrol.c | 4 +- mm/slab_common.c | 35 ++++++++--- net/mac80211/rx.c | 26 ++++++++ net/netfilter/ipvs/ip_vs_sync.c | 12 ++-- net/tipc/bcast.c | 8 +-- net/tipc/group.c | 4 +- net/tipc/link.c | 12 ++-- net/tipc/node.c | 7 ++- net/tipc/socket.c | 12 ++-- scripts/decode_stacktrace.sh | 4 +- scripts/gdb/linux/symbols.py | 2 +- sound/core/info.c | 4 +- sound/soc/codecs/rt5670.c | 71 +++++++++++++++++----- sound/soc/codecs/rt5670.h | 2 +- sound/soc/qcom/Kconfig | 2 +- 106 files changed, 578 insertions(+), 225 deletions(-)
On Mon, 27 Jul 2020 16:03:34 +0200, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 4.19.135 release. There are 86 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 29 Jul 2020 13:48:51 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.135-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
All tests passing for Tegra ...
Test results for stable-v4.19: 11 builds: 11 pass, 0 fail 22 boots: 22 pass, 0 fail 38 tests: 38 pass, 0 fail
Linux version: 4.19.135-rc1-ge61bf6def734 Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000, tegra194-p2972-0000, tegra20-ventana, tegra210-p2371-2180, tegra30-cardhu-a04
Thierry
On 7/27/20 8:03 AM, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 4.19.135 release. There are 86 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 29 Jul 2020 13:48:51 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.135-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan skhan@linuxfoundation.org
thanks, -- Shuah
On Mon, 27 Jul 2020 at 19:40, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.135 release. There are 86 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 29 Jul 2020 13:48:51 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.135-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Pseudo-Shortlog of commits:
<trim>
Results from Linaro’s test farm. Regressions detected on x86_64.
Boot failures on x86_64 devices running 4.19.135-rc1 kernel.
Summary ------------------------------------------------------------------------
kernel: 4.19.135-rc1 git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git git branch: linux-4.19.y git commit: e11702667f84474535b156dbb194deffa0a6cdb4 git describe: v4.19.134-87-ge11702667f84 Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.19-oe/build/v4.19.134-8...
Muchun Song songmuchun@bytedance.com mm: memcg/slab: fix memory leak at non-root kmem_cache destroy
[ 2.510884] ============================================ [ 2.510884] WARNING: possible recursive locking detected [ 2.510884] 4.19.135-rc1 #1 Not tainted [ 2.510884] -------------------------------------------- [ 2.510884] swapper/0/1 is trying to acquire lock: [ 2.510884] 0000000088703397 (slab_mutex){+.+.}, at: kmem_cache_destroy+0x9a/0x2b0 [ 2.510884] [ 2.510884] but task is already holding lock: [ 2.510884] 0000000088703397 (slab_mutex){+.+.}, at: kmem_cache_destroy+0x45/0x2b0 [ 2.510884] [ 2.510884] other info that might help us debug this: [ 2.510884] Possible unsafe locking scenario: [ 2.510884] [ 2.510884] CPU0 [ 2.510884] ---- [ 2.510884] lock(slab_mutex); [ 2.510884] lock(slab_mutex); [ 2.510884] [ 2.510884] *** DEADLOCK *** [ 2.510884] [ 2.510884] May be due to missing lock nesting notation [ 2.510884] [ 2.510884] 3 locks held by swapper/0/1: [ 2.510884] #0: 000000008702dddc (cpu_hotplug_lock.rw_sem){++++}, at: kmem_cache_destroy+0x32/0x2b0 [ 2.510884] #1: 0000000050103e4d (mem_hotplug_lock.rw_sem){++++}, at: kmem_cache_destroy+0x37/0x2b0 [ 2.510884] #2: 0000000088703397 (slab_mutex){+.+.}, at: kmem_cache_destroy+0x45/0x2b0 [ 2.510884] [ 2.510884] stack backtrace: [ 2.510884] CPU: 2 PID: 1 Comm: swapper/0 Not tainted 4.19.135-rc1 #1 [ 2.510884] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS 2.0b 07/27/2017 [ 2.510884] Call Trace: [ 2.510884] dump_stack+0x7a/0xa5 [ 2.510884] __lock_acquire+0x6f1/0x1380 [ 2.510884] ? ret_from_fork+0x3a/0x50 [ 2.510884] lock_acquire+0x95/0x190 [ 2.510884] ? lock_acquire+0x95/0x190 [ 2.510884] ? kmem_cache_destroy+0x9a/0x2b0 [ 2.510884] ? kmem_cache_destroy+0x9a/0x2b0 [ 2.510884] __mutex_lock+0x83/0x990 [ 2.510884] ? kmem_cache_destroy+0x9a/0x2b0 [ 2.510884] ? kmem_cache_destroy+0x60/0x2b0 [ 2.510884] ? set_debug_rodata+0x17/0x17 [ 2.510884] ? set_debug_rodata+0x17/0x17 [ 2.510884] mutex_lock_nested+0x1b/0x20 [ 2.510884] ? get_online_mems+0x5f/0x90 [ 2.510884] ? mutex_lock_nested+0x1b/0x20 [ 2.510884] kmem_cache_destroy+0x9a/0x2b0 [ 2.510884] ? set_debug_rodata+0x17/0x17 [ 2.510884] intel_iommu_init+0x11c6/0x1326 [ 2.510884] ? kfree+0xc4/0x240 [ 2.510884] ? lockdep_hardirqs_on+0xef/0x180 [ 2.510884] ? kfree+0xc4/0x240 [ 2.510884] ? trace_hardirqs_on+0x4c/0x100 [ 2.510884] ? unpack_to_rootfs+0x272/0x29a [ 2.510884] ? e820__memblock_setup+0x64/0x64 [ 2.510884] ? set_debug_rodata+0x17/0x17 [ 2.510884] pci_iommu_init+0x1a/0x44 [ 2.510884] ? e820__memblock_setup+0x64/0x64 [ 2.510884] ? pci_iommu_init+0x1a/0x44 [ 2.510884] do_one_initcall+0x61/0x2b4 [ 2.510884] ? set_debug_rodata+0xa/0x17 [ 2.510884] ? rcu_read_lock_sched_held+0x81/0x90 [ 2.510884] kernel_init_freeable+0x1d8/0x270 [ 2.510884] ? rest_init+0x190/0x190 [ 2.510884] kernel_init+0xe/0x110 [ 2.510884] ret_from_fork+0x3a/0x50
Full test log: https://pastebin.com/PWkk0YaF
Thanks for your test. I have reviewed the patch:
[PATCH 4.19 76/86] mm: memcg/slab: fix memory leak at non-root kmem_cache destroy
There is a backport problem and I have pointed out the problem in that email.
On Tue, Jul 28, 2020 at 4:34 PM Naresh Kamboju naresh.kamboju@linaro.org wrote:
On Mon, 27 Jul 2020 at 19:40, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.135 release. There are 86 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 29 Jul 2020 13:48:51 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.135-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Pseudo-Shortlog of commits:
<trim>
Results from Linaro’s test farm. Regressions detected on x86_64.
Boot failures on x86_64 devices running 4.19.135-rc1 kernel.
Summary
kernel: 4.19.135-rc1 git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git git branch: linux-4.19.y git commit: e11702667f84474535b156dbb194deffa0a6cdb4 git describe: v4.19.134-87-ge11702667f84 Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.19-oe/build/v4.19.134-8...
Muchun Song songmuchun@bytedance.com mm: memcg/slab: fix memory leak at non-root kmem_cache destroy
[ 2.510884] ============================================ [ 2.510884] WARNING: possible recursive locking detected [ 2.510884] 4.19.135-rc1 #1 Not tainted [ 2.510884] -------------------------------------------- [ 2.510884] swapper/0/1 is trying to acquire lock: [ 2.510884] 0000000088703397 (slab_mutex){+.+.}, at: kmem_cache_destroy+0x9a/0x2b0 [ 2.510884] [ 2.510884] but task is already holding lock: [ 2.510884] 0000000088703397 (slab_mutex){+.+.}, at: kmem_cache_destroy+0x45/0x2b0 [ 2.510884] [ 2.510884] other info that might help us debug this: [ 2.510884] Possible unsafe locking scenario: [ 2.510884] [ 2.510884] CPU0 [ 2.510884] ---- [ 2.510884] lock(slab_mutex); [ 2.510884] lock(slab_mutex); [ 2.510884] [ 2.510884] *** DEADLOCK *** [ 2.510884] [ 2.510884] May be due to missing lock nesting notation [ 2.510884] [ 2.510884] 3 locks held by swapper/0/1: [ 2.510884] #0: 000000008702dddc (cpu_hotplug_lock.rw_sem){++++}, at: kmem_cache_destroy+0x32/0x2b0 [ 2.510884] #1: 0000000050103e4d (mem_hotplug_lock.rw_sem){++++}, at: kmem_cache_destroy+0x37/0x2b0 [ 2.510884] #2: 0000000088703397 (slab_mutex){+.+.}, at: kmem_cache_destroy+0x45/0x2b0 [ 2.510884] [ 2.510884] stack backtrace: [ 2.510884] CPU: 2 PID: 1 Comm: swapper/0 Not tainted 4.19.135-rc1 #1 [ 2.510884] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS 2.0b 07/27/2017 [ 2.510884] Call Trace: [ 2.510884] dump_stack+0x7a/0xa5 [ 2.510884] __lock_acquire+0x6f1/0x1380 [ 2.510884] ? ret_from_fork+0x3a/0x50 [ 2.510884] lock_acquire+0x95/0x190 [ 2.510884] ? lock_acquire+0x95/0x190 [ 2.510884] ? kmem_cache_destroy+0x9a/0x2b0 [ 2.510884] ? kmem_cache_destroy+0x9a/0x2b0 [ 2.510884] __mutex_lock+0x83/0x990 [ 2.510884] ? kmem_cache_destroy+0x9a/0x2b0 [ 2.510884] ? kmem_cache_destroy+0x60/0x2b0 [ 2.510884] ? set_debug_rodata+0x17/0x17 [ 2.510884] ? set_debug_rodata+0x17/0x17 [ 2.510884] mutex_lock_nested+0x1b/0x20 [ 2.510884] ? get_online_mems+0x5f/0x90 [ 2.510884] ? mutex_lock_nested+0x1b/0x20 [ 2.510884] kmem_cache_destroy+0x9a/0x2b0 [ 2.510884] ? set_debug_rodata+0x17/0x17 [ 2.510884] intel_iommu_init+0x11c6/0x1326 [ 2.510884] ? kfree+0xc4/0x240 [ 2.510884] ? lockdep_hardirqs_on+0xef/0x180 [ 2.510884] ? kfree+0xc4/0x240 [ 2.510884] ? trace_hardirqs_on+0x4c/0x100 [ 2.510884] ? unpack_to_rootfs+0x272/0x29a [ 2.510884] ? e820__memblock_setup+0x64/0x64 [ 2.510884] ? set_debug_rodata+0x17/0x17 [ 2.510884] pci_iommu_init+0x1a/0x44 [ 2.510884] ? e820__memblock_setup+0x64/0x64 [ 2.510884] ? pci_iommu_init+0x1a/0x44 [ 2.510884] do_one_initcall+0x61/0x2b4 [ 2.510884] ? set_debug_rodata+0xa/0x17 [ 2.510884] ? rcu_read_lock_sched_held+0x81/0x90 [ 2.510884] kernel_init_freeable+0x1d8/0x270 [ 2.510884] ? rest_init+0x190/0x190 [ 2.510884] kernel_init+0xe/0x110 [ 2.510884] ret_from_fork+0x3a/0x50
Full test log: https://pastebin.com/PWkk0YaF
-- Linaro LKFT https://lkft.linaro.org
-- Yours, Muchun
On Tue, 28 Jul 2020 at 18:33, Muchun Song songmuchun@bytedance.com wrote:
Thanks for your test. I have reviewed the patch:
[PATCH 4.19 76/86] mm: memcg/slab: fix memory leak at non-root kmem_cache destroy
There is a backport problem and I have pointed out the problem in that email.
Thanks for your suggestions on the other email thread. I have made changes as you said and boot test pass on x86 now.
diff --git a/mm/slab_common.c b/mm/slab_common.c index 9c5eb4b08fc3..65bc49f19504 100644 --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -842,9 +842,7 @@ static int shutdown_memcg_caches(struct kmem_cache *s)
static void memcg_set_kmem_cache_dying(struct kmem_cache *s) { - mutex_lock(&slab_mutex); s->memcg_params.dying = true; - mutex_unlock(&slab_mutex); }
static void flush_memcg_workqueue(struct kmem_cache *s)
- Naresh
On Mon 2020-07-27 16:03:34, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 4.19.135 release. There are 86 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 29 Jul 2020 13:48:51 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.135-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
It passes tests on CIP test farm:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4...