This is the start of the stable review cycle for the 4.14.335 release. There are 21 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun, 07 Jan 2024 14:38:02 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.335-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below.
thanks,
greg k-h
------------- Pseudo-Shortlog of commits:
Greg Kroah-Hartman gregkh@linuxfoundation.org Linux 4.14.335-rc1
Sarthak Kukreti sarthakkukreti@chromium.org block: Don't invalidate pagecache for invalid falloc modes
Mikulas Patocka mpatocka@redhat.com dm-integrity: don't modify bio's immutable bio_vec in integrity_metadata()
Rouven Czerwinski r.czerwinski@pengutronix.de net: rfkill: gpio: set GPIO direction
Fedor Pchelkin pchelkin@ispras.ru net: 9p: avoid freeing uninit memory in p9pdu_vreadf
Luiz Augusto von Dentz luiz.von.dentz@intel.com Bluetooth: hci_event: Fix not checking if HCI_OP_INQUIRY has been sent
Reinhard Speyerer rspmn@arcor.de USB: serial: option: add Quectel RM500Q R13 firmware support
Slark Xiao slark_xiao@163.com USB: serial: option: add Foxconn T99W265 with new baseline
Alper Ak alperyasinak1@gmail.com USB: serial: option: add Quectel EG912Y module support
Mark Glover mark.glover@actisense.com USB: serial: ftdi_sio: update Actisense PIDs constant names
Johannes Berg johannes.berg@intel.com wifi: cfg80211: fix certs build to not depend on file order
Chen-Yu Tsai wens@kernel.org wifi: cfg80211: Add my certificate
Javier Carrasco javier.carrasco.cruz@gmail.com iio: common: ms_sensors: ms_sensors_i2c: fix humidity conversion time table
Haoran Liu liuhaoran14@163.com Input: ipaq-micro-keys - add error handling for devm_kmemdup
Su Hui suhui@nfschina.com iio: imu: inv_mpu6050: fix an error code problem in inv_mpu6050_read_raw
Alexis Lothoré alexis.lothore@bootlin.com pinctrl: at91-pio4: use dedicated lock class for IRQ
Liu Jian liujian56@huawei.com net: check vlan filter feature in vlan_vids_add_by_dev() and vlan_vids_del_by_dev()
Zhipeng Lu alexious@zju.edu.cn ethernet: atheros: fix a memleak in atl1e_setup_ring_resources
Eric Dumazet edumazet@google.com net: sched: ife: fix potential use-after-free
Johannes Berg johannes.berg@intel.com wifi: mac80211: mesh_plink: fix matches_local logic
Heiko Carstens hca@linux.ibm.com s390/vx: fix save/restore of fpu kernel context
Kunwu Chan chentao@kylinos.cn ARM: OMAP2+: Fix null pointer dereference and memory leak in omap_soc_device_init
-------------
Diffstat:
Makefile | 4 +- arch/arm/mach-omap2/id.c | 5 ++ arch/s390/include/asm/fpu/api.h | 2 +- drivers/iio/common/ms_sensors/ms_sensors_i2c.c | 4 +- drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 4 +- drivers/input/keyboard/ipaq-micro-keys.c | 3 + drivers/md/dm-integrity.c | 11 ++-- drivers/net/ethernet/atheros/atl1e/atl1e_main.c | 5 +- drivers/pinctrl/pinctrl-at91-pio4.c | 8 +++ drivers/usb/serial/ftdi_sio.c | 6 +- drivers/usb/serial/ftdi_sio_ids.h | 6 +- drivers/usb/serial/option.c | 5 ++ fs/block_dev.c | 9 ++- net/8021q/vlan_core.c | 9 ++- net/9p/protocol.c | 17 +++-- net/bluetooth/hci_event.c | 3 +- net/ife/ife.c | 1 + net/mac80211/mesh_plink.c | 10 +-- net/rfkill/rfkill-gpio.c | 8 +++ net/wireless/certs/wens.hex | 87 +++++++++++++++++++++++++ 20 files changed, 175 insertions(+), 32 deletions(-)
Hi Greg,
On 05/01/2024 14:38, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 4.14.335 release. There are 21 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun, 07 Jan 2024 14:38:02 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.335-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below.
thanks,
greg k-h
Pseudo-Shortlog of commits:
...
Alexis Lothoré alexis.lothore@bootlin.com pinctrl: at91-pio4: use dedicated lock class for IRQ
I am seeing the following build error for ARM ...
drivers/pinctrl/pinctrl-at91-pio4.c: In function ‘atmel_pinctrl_probe’: drivers/pinctrl/pinctrl-at91-pio4.c:1054:3: error: too many arguments to function ‘irq_set_lockdep_class’ irq_set_lockdep_class(irq, &atmel_lock_key, &atmel_request_key); ^~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/irq.h:517:0, from include/linux/gpio/driver.h:7, from drivers/pinctrl/pinctrl-at91-pio4.c:18: include/linux/irqdesc.h:250:1: note: declared here irq_set_lockdep_class(unsigned int irq, struct lock_class_key *class) ^~~~~~~~~~~~~~~~~~~~~
I am guessing it is the above commit.
Jon
On Fri, Jan 05, 2024 at 04:23:00PM +0000, Jon Hunter wrote:
Hi Greg,
On 05/01/2024 14:38, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 4.14.335 release. There are 21 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun, 07 Jan 2024 14:38:02 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.335-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below.
thanks,
greg k-h
Pseudo-Shortlog of commits:
...
Alexis Lothoré alexis.lothore@bootlin.com pinctrl: at91-pio4: use dedicated lock class for IRQ
I am seeing the following build error for ARM ...
drivers/pinctrl/pinctrl-at91-pio4.c: In function ‘atmel_pinctrl_probe’: drivers/pinctrl/pinctrl-at91-pio4.c:1054:3: error: too many arguments to function ‘irq_set_lockdep_class’ irq_set_lockdep_class(irq, &atmel_lock_key, &atmel_request_key); ^~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/irq.h:517:0, from include/linux/gpio/driver.h:7, from drivers/pinctrl/pinctrl-at91-pio4.c:18: include/linux/irqdesc.h:250:1: note: declared here irq_set_lockdep_class(unsigned int irq, struct lock_class_key *class) ^~~~~~~~~~~~~~~~~~~~~
I am guessing it is the above commit.
Thanks, now dropped.
greg k-h
Hello!
On 05/01/24 8:38 a. m., Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 4.14.335 release. There are 21 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun, 07 Jan 2024 14:38:02 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.335-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below.
thanks,
greg k-h
We are seeing build problems on Arm32 and Arm64. On Arm32, for the following configurations:
* clang-17-keystone_defconfig * clang-17-lkftconfig * clang-17-mini2440_defconfig * clang-17-sama5_defconfig * gcc-8-defconfig * gcc-8-sama5_defconfig * gcc-12-defconfig * gcc-12-lkftconfig * gcc-12-lkftconfig-debug * gcc-12-lkftconfig-debug-kmemleak * gcc-12-lkftconfig-kasan * gcc-12-lkftconfig-kselftest-kernel * gcc-12-lkftconfig-kunit * gcc-12-lkftconfig-libgpiod * gcc-12-lkftconfig-rcutorture * gcc-12-sama5_defconfig
Failure looks like this:
-----8<----- /builds/linux/drivers/pinctrl/pinctrl-at91-pio4.c: In function 'atmel_pinctrl_probe': /builds/linux/drivers/pinctrl/pinctrl-at91-pio4.c:1054:3: error: too many arguments to function 'irq_set_lockdep_class' irq_set_lockdep_class(irq, &atmel_lock_key, &atmel_request_key); ^~~~~~~~~~~~~~~~~~~~~ In file included from /builds/linux/include/linux/irq.h:517, from /builds/linux/include/linux/gpio/driver.h:7, from /builds/linux/drivers/pinctrl/pinctrl-at91-pio4.c:18: /builds/linux/include/linux/irqdesc.h:250:1: note: declared here irq_set_lockdep_class(unsigned int irq, struct lock_class_key *class) ^~~~~~~~~~~~~~~~~~~~~ make[3]: *** [/builds/linux/scripts/Makefile.build:330: drivers/pinctrl/pinctrl-at91-pio4.o] Error 1 ----->8-----
Bisection points to:
commit 6c47537ba008b3affe99360f65592ff5b797818f Author: Alexis Lothoré alexis.lothore@bootlin.com Date: Fri Dec 15 22:34:24 2023 +0100
pinctrl: at91-pio4: use dedicated lock class for IRQ
[ Upstream commit 14694179e561b5f2f7e56a0f590e2cb49a9cc7ab ]
Reproducer:
tuxmake --runtime podman --target-arch arm --toolchain clang-17 --kconfig defconfig LLVM_IAS=0
Then on Arm64 with Clang 17:
-----8<----- /builds/linux/net/8021q/vlan_core.c:332:39: error: incompatible integer to pointer conversion passing '__be16' (aka 'unsigned short') to parameter of type 'const struct vlan_vi d_info *' [-Wint-conversion] 332 | if (!vlan_hw_filter_capable(by_dev, vid_info->proto)) | ^~~~~~~~~~~~~~~ /builds/linux/net/8021q/vlan_core.c:169:38: note: passing argument to parameter 'vid_info' here 169 | const struct vlan_vid_info *vid_info) | ^ /builds/linux/net/8021q/vlan_core.c:344:39: error: incompatible integer to pointer conversion passing '__be16' (aka 'unsigned short') to parameter of type 'const struct vlan_vi d_info *' [-Wint-conversion] 344 | if (!vlan_hw_filter_capable(by_dev, vid_info->proto)) | ^~~~~~~~~~~~~~~ /builds/linux/net/8021q/vlan_core.c:169:38: note: passing argument to parameter 'vid_info' here 169 | const struct vlan_vid_info *vid_info) | ^ /builds/linux/net/8021q/vlan_core.c:366:39: error: incompatible integer to pointer conversion passing '__be16' (aka 'unsigned short') to parameter of type 'const struct vlan_vid_info *' [-Wint-conversion] 366 | if (!vlan_hw_filter_capable(by_dev, vid_info->proto)) | ^~~~~~~~~~~~~~~ /builds/linux/net/8021q/vlan_core.c:169:38: note: passing argument to parameter 'vid_info' here 169 | const struct vlan_vid_info *vid_info) | ^ 3 errors generated. make[3]: *** [/builds/linux/scripts/Makefile.build:329: net/8021q/vlan_core.o] Error 1 ----->8-----
Bisection in this case points to:
commit f33474044777425b3578d4e8b22a003f034ae214 Author: Liu Jian liujian56@huawei.com Date: Sat Dec 16 15:52:18 2023 +0800
net: check vlan filter feature in vlan_vids_add_by_dev() and vlan_vids_del_by_dev()
[ Upstream commit 01a564bab4876007ce35f312e16797dfe40e4823 ]
Reproducer:
tuxmake --runtime podman --target-arch arm64 --toolchain clang-17 --kconfig defconfig LD=ld.lld LLVM_IAS=0
Reported-by: Linux Kernel Functional Testing lkft@linaro.org
Greetings!
Daniel Díaz daniel.diaz@linaro.org
Hello,
On 1/5/24 18:13, Daniel Díaz wrote:
Hello!
On 05/01/24 8:38 a. m., Greg Kroah-Hartman wrote:
[...]
Failure looks like this:
-----8<----- /builds/linux/drivers/pinctrl/pinctrl-at91-pio4.c: In function 'atmel_pinctrl_probe': /builds/linux/drivers/pinctrl/pinctrl-at91-pio4.c:1054:3: error: too many arguments to function 'irq_set_lockdep_class' irq_set_lockdep_class(irq, &atmel_lock_key, &atmel_request_key); ^~~~~~~~~~~~~~~~~~~~~ In file included from /builds/linux/include/linux/irq.h:517, from /builds/linux/include/linux/gpio/driver.h:7, from /builds/linux/drivers/pinctrl/pinctrl-at91-pio4.c:18: /builds/linux/include/linux/irqdesc.h:250:1: note: declared here irq_set_lockdep_class(unsigned int irq, struct lock_class_key *class) ^~~~~~~~~~~~~~~~~~~~~ make[3]: *** [/builds/linux/scripts/Makefile.build:330: drivers/pinctrl/pinctrl-at91-pio4.o] Error 1 ----->8-----
Bisection points to:
commit 6c47537ba008b3affe99360f65592ff5b797818f Author: Alexis Lothoré alexis.lothore@bootlin.com Date: Fri Dec 15 22:34:24 2023 +0100
pinctrl: at91-pio4: use dedicated lock class for IRQ [ Upstream commit 14694179e561b5f2f7e56a0f590e2cb49a9cc7ab ]
This fails because linux-4.14.y is older than 39c3fd58952d: kernel/irq: Extend lockdep class for request mutex, which updates irq_set_lockdep_class API.
Looking at irq_set_lockdep_class update patch, what appears to be a simple fix is to simply remove the last parameter from irq_set_lockdep_class call in pinctrl-at91-pio4.c, but I am not even sure if the fix remains legitimate in this case (ie if the corresponding lockdep splat reappears), and I do not have access to corresponding hardware before the deadline, so if that's not already the plan, I suggest to drop this from 4.14 branch.
Alexis
On Fri, Jan 05, 2024 at 09:39:58PM +0100, Alexis Lothoré wrote:
Hello,
On 1/5/24 18:13, Daniel Díaz wrote:
Hello!
On 05/01/24 8:38 a. m., Greg Kroah-Hartman wrote:
[...]
Failure looks like this:
-----8<----- /builds/linux/drivers/pinctrl/pinctrl-at91-pio4.c: In function 'atmel_pinctrl_probe': /builds/linux/drivers/pinctrl/pinctrl-at91-pio4.c:1054:3: error: too many arguments to function 'irq_set_lockdep_class' irq_set_lockdep_class(irq, &atmel_lock_key, &atmel_request_key); ^~~~~~~~~~~~~~~~~~~~~ In file included from /builds/linux/include/linux/irq.h:517, from /builds/linux/include/linux/gpio/driver.h:7, from /builds/linux/drivers/pinctrl/pinctrl-at91-pio4.c:18: /builds/linux/include/linux/irqdesc.h:250:1: note: declared here irq_set_lockdep_class(unsigned int irq, struct lock_class_key *class) ^~~~~~~~~~~~~~~~~~~~~ make[3]: *** [/builds/linux/scripts/Makefile.build:330: drivers/pinctrl/pinctrl-at91-pio4.o] Error 1 ----->8-----
Bisection points to:
commit 6c47537ba008b3affe99360f65592ff5b797818f Author: Alexis Lothoré alexis.lothore@bootlin.com Date: Fri Dec 15 22:34:24 2023 +0100
pinctrl: at91-pio4: use dedicated lock class for IRQ [ Upstream commit 14694179e561b5f2f7e56a0f590e2cb49a9cc7ab ]
This fails because linux-4.14.y is older than 39c3fd58952d: kernel/irq: Extend lockdep class for request mutex, which updates irq_set_lockdep_class API.
Looking at irq_set_lockdep_class update patch, what appears to be a simple fix is to simply remove the last parameter from irq_set_lockdep_class call in pinctrl-at91-pio4.c, but I am not even sure if the fix remains legitimate in this case (ie if the corresponding lockdep splat reappears), and I do not have access to corresponding hardware before the deadline, so if that's not already the plan, I suggest to drop this from 4.14 branch.
Now dropped, thanks.
greg k-h
Hi!
This is the start of the stable review cycle for the 4.14.335 release. There are 21 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
CIP testing did not find any problems here:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4...
Tested-by: Pavel Machek (CIP) pavel@denx.de
Best regards, Pavel
Hi Greg,
On 05/01/24 8:08 pm, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 4.14.335 release. There are 21 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun, 07 Jan 2024 14:38:02 +0000. Anything received after that time might be too late.
No problems seen on x86_64 and aarch64 with our testing.
Tested-by: Harshit Mogalapalli harshit.m.mogalapalli@oracle.com
Thanks, Harshit
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.335-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y and the diffstat can be found below.
thanks,
greg k-h fix a memleak in atl1e_setup_ring_resources
Eric Dumazet edumazet@google.com net: sched: ife: fix potential use-after-free
Johannes Berg johannes.berg@intel.com wifi: mac80211: mesh_plink: fix matches_local logic
Heiko Carstens hca@linux.ibm.com s390/vx: fix save/restore of fpu kernel context
Kunwu Chan chentao@kylinos.cn ARM: OMAP2+: Fix null pointer dereference and memory leak in omap_soc_device_init
-
Alexis Lothoré -
Daniel Díaz -
Greg Kroah-Hartman -
Harshit Mogalapalli -
Jon Hunter -
Pavel Machek