This is the start of the stable review cycle for the 4.19.272 release. There are 80 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.272-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
------------- Pseudo-Shortlog of commits:
Greg Kroah-Hartman gregkh@linuxfoundation.org Linux 4.19.272-rc1
Peter Chen peter.chen@nxp.com usb: host: xhci-plat: add wakeup entry at sysfs
Eric Dumazet edumazet@google.com ipv6: ensure sane device mtu in tunnels
Kees Cook keescook@chromium.org exit: Use READ_ONCE() for all oops/warn limit reads
Kees Cook keescook@chromium.org docs: Fix path paste-o for /sys/kernel/warn_count
Kees Cook keescook@chromium.org panic: Expose "warn_count" to sysfs
Kees Cook keescook@chromium.org panic: Introduce warn_limit
Kees Cook keescook@chromium.org panic: Consolidate open-coded panic_on_warn checks
Kees Cook keescook@chromium.org exit: Allow oops_limit to be disabled
Kees Cook keescook@chromium.org exit: Expose "oops_count" to sysfs
Jann Horn jannh@google.com exit: Put an upper limit on how often we can oops
Randy Dunlap rdunlap@infradead.org ia64: make IA64_MCA_RECOVERY bool instead of tristate
Nathan Chancellor nathan@kernel.org h8300: Fix build errors from do_exit() to make_task_dead() transition
Nathan Chancellor nathan@kernel.org hexagon: Fix function name in die()
Eric W. Biederman ebiederm@xmission.com objtool: Add a missing comma to avoid string concatenation
Eric W. Biederman ebiederm@xmission.com exit: Add and use make_task_dead.
Tiezhu Yang yangtiezhu@loongson.cn panic: unset panic_on_warn inside panic()
Xiaoming Ni nixiaoming@huawei.com sysctl: add a new register_sysctl_init() interface
Hui Wang hui.wang@canonical.com dmaengine: imx-sdma: Fix a possible memory leak in sdma_transfer_init
Geert Uytterhoeven geert+renesas@glider.be ARM: dts: imx: Fix pca9547 i2c-mux node name
Jan Beulich jbeulich@suse.com x86/entry/64: Add instruction suffix to SYSRET
Mikulas Patocka mpatocka@redhat.com x86/asm: Fix an assembler warning with current binutils
Linus Torvalds torvalds@linux-foundation.org drm/i915/display: fix compiler warning about array overrun
Thomas Gleixner tglx@linutronix.de x86/i8259: Mark legacy PIC interrupts with IRQ_LEVEL
Dmitry Torokhov dmitry.torokhov@gmail.com Revert "Input: synaptics - switch touchpad on HP Laptop 15-da3001TU to RMI mode"
David Christensen drc@linux.vnet.ibm.com net/tg3: resolve deadlock in tg3_reset_task() during EEH
Yoshihiro Shimoda yoshihiro.shimoda.uh@renesas.com net: ravb: Fix possible hang if RIS2_QFF1 happen
Marcelo Ricardo Leitner marcelo.leitner@gmail.com sctp: fail if no bound addresses can be used for a given scope
Kuniyuki Iwashima kuniyu@amazon.com netrom: Fix use-after-free of a listening socket.
Sriram Yagnaraman sriram.yagnaraman@est.tech netfilter: conntrack: fix vtag checks for ABORT/SHUTDOWN_COMPLETE
Eric Dumazet edumazet@google.com ipv4: prevent potential spectre v1 gadget in ip_metrics_convert()
Eric Dumazet edumazet@google.com netlink: annotate data races around sk_state
Eric Dumazet edumazet@google.com netlink: annotate data races around dst_portid and dst_group
Eric Dumazet edumazet@google.com netlink: annotate data races around nlk->portid
Li RongQing lirongqing@baidu.com netlink: remove hash::nelems check in netlink_insert
Pablo Neira Ayuso pablo@netfilter.org netfilter: nft_set_rbtree: skip elements in transaction from garbage collection
Paolo Abeni pabeni@redhat.com net: fix UaF in netns ops registration error path
Manivannan Sadhasivam manivannan.sadhasivam@linaro.org EDAC/device: Respect any driver-supplied workqueue polling value
Giulio Benetti giulio.benetti@benettiengineering.com ARM: 9280/1: mm: fix warning on phys_addr_t to void pointer assignment
David Howells dhowells@redhat.com cifs: Fix oops due to uncleared server->smbd_conn in reconnect
Long Li longli@microsoft.com smbd: Make upper layer decide when to destroy the transport
Natalia Petrova n.petrova@fintech.ru trace_events_hist: add check for return value of 'create_hist_field'
Steven Rostedt (Google) rostedt@goodmis.org tracing: Make sure trace_printk() can output as soon as it can be used
Petr Pavlu petr.pavlu@suse.com module: Don't wait for GOING modules
Alexey V. Vissarionov gremlin@altlinux.org scsi: hpsa: Fix allocation size for scsi_host_alloc()
Archie Pusaka apusaka@chromium.org Bluetooth: hci_sync: cancel cmd_timer if hci_open failed
Dongliang Mu mudongliangabcd@gmail.com fs: reiserfs: remove useless new_opts in reiserfs_remount
Arnaldo Carvalho de Melo acme@redhat.com perf env: Do not return pointers to local variables
Christoph Hellwig hch@lst.de block: fix and cleanup bio_check_ro
Florian Westphal fw@strlen.de netfilter: conntrack: do not renew entry stuck in tcp SYN_SENT state
Yang Yingliang yangyingliang@huawei.com w1: fix WARNING after calling w1_process()
Yang Yingliang yangyingliang@huawei.com w1: fix deadloop in __w1_remove_master_device()
Jason Xing kernelxing@tencent.com tcp: avoid the lookup process failing to get sk in ehash table
Liu Shixin liushixin2@huawei.com dmaengine: xilinx_dma: call of_node_put() when breaking out of for_each_child_of_node()
Swati Agarwal swati.agarwal@xilinx.com dmaengine: xilinx_dma: Fix devm_platform_ioremap_resource error handling
Radhey Shyam Pandey radhey.shyam.pandey@xilinx.com dmaengine: xilinx_dma: program hardware supported buffer length
Andrea Merello andrea.merello@gmail.com dmaengine: xilinx_dma: commonize DMA copy size calculation
Pietro Borrello borrello@diag.uniroma1.it HID: betop: check shape of output reports
Robert Hancock robert.hancock@calian.com net: macb: fix PTP TX timestamp failure due to packet padding
Koba Ko koba.ko@canonical.com dmaengine: Fix double increment of client_count in dma_chan_get()
Randy Dunlap rdunlap@infradead.org net: mlx5: eliminate anonymous module_init & module_exit
Udipto Goswami quic_ugoswami@quicinc.com usb: gadget: f_fs: Ensure ep0req is dequeued before free_request
Udipto Goswami quic_ugoswami@quicinc.com usb: gadget: f_fs: Prevent race during ffs_ep0_queue_wait
Pietro Borrello borrello@diag.uniroma1.it HID: check empty report_list in hid_validate_values()
Heiner Kallweit hkallweit1@gmail.com net: mdio: validate parameter addr in mdiobus_get_phy()
Szymon Heidrich szymon.heidrich@gmail.com net: usb: sr9700: Handle negative len
Szymon Heidrich szymon.heidrich@gmail.com wifi: rndis_wlan: Prevent buffer overflow in rndis_query_oid
Jisoo Jang jisoo.jang@yonsei.ac.kr net: nfc: Fix use-after-free in local_cleanup()
Shang XiaoJing shangxiaojing@huawei.com phy: rockchip-inno-usb2: Fix missing clk_disable_unprepare() in rockchip_usb2phy_power_on()
Luis Gerhorst gerhorst@cs.fau.de bpf: Fix pointer-leak due to insufficient speculative store bypass mitigation
Raju Rangoju Raju.Rangoju@amd.com amd-xgbe: Delay AN timeout during KR training
Raju Rangoju Raju.Rangoju@amd.com amd-xgbe: TX Flow Ctrl Registers are h/w ver dependent
Alexander Potapenko glider@google.com affs: initialize fsdata in affs_truncate()
Dean Luick dean.luick@cornelisnetworks.com IB/hfi1: Fix expected receive setup error exit issues
Dean Luick dean.luick@cornelisnetworks.com IB/hfi1: Reserve user expected TIDs
Dean Luick dean.luick@cornelisnetworks.com IB/hfi1: Reject a zero-length user expected buffer
Masahiro Yamada masahiroy@kernel.org tomoyo: fix broken dependency on *.conf.default
Miaoqian Lin linmq006@gmail.com EDAC/highbank: Fix memory leak in highbank_mc_probe()
Jiasheng Jiang jiasheng@iscas.ac.cn HID: intel_ish-hid: Add check for ishtp_dma_tx_map
Fabio Estevam festevam@denx.de ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts'
Gaosheng Cui cuigaosheng1@huawei.com memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()
-------------
Diffstat:
Documentation/ABI/testing/sysfs-kernel-oops_count | 6 ++ Documentation/ABI/testing/sysfs-kernel-warn_count | 6 ++ Documentation/sysctl/kernel.txt | 20 ++++ Makefile | 4 +- arch/alpha/kernel/traps.c | 6 +- arch/alpha/mm/fault.c | 2 +- arch/arm/boot/dts/imx53-ppd.dts | 2 +- arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 1 - arch/arm/kernel/traps.c | 2 +- arch/arm/mm/fault.c | 2 +- arch/arm/mm/nommu.c | 2 +- arch/arm64/kernel/traps.c | 2 +- arch/arm64/mm/fault.c | 2 +- arch/h8300/kernel/traps.c | 3 +- arch/h8300/mm/fault.c | 2 +- arch/hexagon/kernel/traps.c | 2 +- arch/ia64/Kconfig | 2 +- arch/ia64/kernel/mca_drv.c | 2 +- arch/ia64/kernel/traps.c | 2 +- arch/ia64/mm/fault.c | 2 +- arch/m68k/kernel/traps.c | 2 +- arch/m68k/mm/fault.c | 2 +- arch/microblaze/kernel/exceptions.c | 4 +- arch/mips/kernel/traps.c | 2 +- arch/nds32/kernel/traps.c | 8 +- arch/nios2/kernel/traps.c | 4 +- arch/openrisc/kernel/traps.c | 2 +- arch/parisc/kernel/traps.c | 2 +- arch/powerpc/kernel/traps.c | 2 +- arch/riscv/kernel/traps.c | 2 +- arch/riscv/mm/fault.c | 2 +- arch/s390/kernel/dumpstack.c | 2 +- arch/s390/kernel/nmi.c | 2 +- arch/sh/kernel/traps.c | 2 +- arch/sparc/kernel/traps_32.c | 4 +- arch/sparc/kernel/traps_64.c | 4 +- arch/x86/entry/entry_32.S | 6 +- arch/x86/entry/entry_64.S | 8 +- arch/x86/kernel/dumpstack.c | 4 +- arch/x86/kernel/i8259.c | 1 + arch/x86/kernel/irqinit.c | 4 +- arch/x86/lib/iomap_copy_64.S | 2 +- arch/xtensa/kernel/traps.c | 2 +- block/blk-core.c | 5 +- drivers/dma/dmaengine.c | 7 +- drivers/dma/imx-sdma.c | 4 +- drivers/dma/xilinx/xilinx_dma.c | 78 +++++++++++---- drivers/edac/edac_device.c | 15 ++- drivers/edac/highbank_mc_edac.c | 7 +- drivers/gpu/drm/i915/intel_dp.c | 13 ++- drivers/hid/hid-betopff.c | 17 ++-- drivers/hid/hid-core.c | 4 +- drivers/hid/intel-ish-hid/ishtp/dma-if.c | 10 ++ drivers/infiniband/hw/hfi1/user_exp_rcv.c | 101 +++++++++++-------- drivers/input/mouse/synaptics.c | 1 - drivers/memory/mvebu-devbus.c | 3 +- drivers/net/ethernet/amd/xgbe/xgbe-dev.c | 23 +++-- drivers/net/ethernet/amd/xgbe/xgbe-mdio.c | 24 +++++ drivers/net/ethernet/amd/xgbe/xgbe.h | 2 + drivers/net/ethernet/broadcom/tg3.c | 8 +- drivers/net/ethernet/cadence/macb_main.c | 9 +- drivers/net/ethernet/mellanox/mlx5/core/main.c | 8 +- drivers/net/ethernet/renesas/ravb_main.c | 4 +- drivers/net/phy/mdio_bus.c | 7 +- drivers/net/usb/sr9700.c | 2 +- drivers/net/wireless/rndis_wlan.c | 19 ++-- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 4 +- drivers/scsi/hpsa.c | 2 +- drivers/usb/gadget/function/f_fs.c | 7 ++ drivers/usb/host/xhci-plat.c | 2 +- drivers/w1/w1.c | 6 +- drivers/w1/w1_int.c | 5 +- fs/affs/file.c | 2 +- fs/cifs/connect.c | 9 +- fs/cifs/smbdirect.c | 115 ++++++++++++++++++---- fs/cifs/smbdirect.h | 5 +- fs/proc/proc_sysctl.c | 33 +++++++ fs/reiserfs/super.c | 6 -- include/linux/kernel.h | 1 + include/linux/sched/task.h | 1 + include/linux/sysctl.h | 3 + kernel/bpf/verifier.c | 4 +- kernel/exit.c | 72 ++++++++++++++ kernel/module.c | 26 ++++- kernel/panic.c | 75 ++++++++++++-- kernel/sched/core.c | 3 +- kernel/trace/trace.c | 2 + kernel/trace/trace.h | 1 + kernel/trace/trace_events_hist.c | 2 + kernel/trace/trace_output.c | 3 +- mm/kasan/report.c | 3 +- net/bluetooth/hci_core.c | 1 + net/core/net_namespace.c | 2 +- net/ipv4/inet_hashtables.c | 17 +++- net/ipv4/inet_timewait_sock.c | 8 +- net/ipv4/metrics.c | 2 + net/ipv6/ip6_gre.c | 12 ++- net/ipv6/ip6_tunnel.c | 10 +- net/ipv6/sit.c | 8 +- net/netfilter/nf_conntrack_proto_sctp.c | 25 +++-- net/netfilter/nf_conntrack_proto_tcp.c | 10 ++ net/netfilter/nft_set_rbtree.c | 16 ++- net/netlink/af_netlink.c | 41 ++++---- net/netrom/nr_timer.c | 1 + net/nfc/llcp_core.c | 1 + net/sctp/bind_addr.c | 6 ++ security/tomoyo/Makefile | 2 +- tools/objtool/check.c | 3 +- tools/perf/util/env.c | 4 +- 109 files changed, 773 insertions(+), 304 deletions(-)
On Fri, 3 Feb 2023 at 15:48, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.272 release. There are 80 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.272-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Following patch caused build error on arm,
Gaosheng Cui cuigaosheng1@huawei.com memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()
drivers/memory/mvebu-devbus.c: In function 'mvebu_devbus_probe': drivers/memory/mvebu-devbus.c:297:8: error: implicit declaration of function 'devm_clk_get_enabled' [-Werror=implicit-function-declaration] 297 | clk = devm_clk_get_enabled(&pdev->dev, NULL); | ^~~~~~~~~~~~~~~~~~~~ drivers/memory/mvebu-devbus.c:297:6: warning: assignment to 'struct clk *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 297 | clk = devm_clk_get_enabled(&pdev->dev, NULL); | ^ cc1: some warnings being treated as errors
Reported-by: Linux Kernel Functional Testing lkft@linaro.org
Build link, https://storage.tuxsuite.com/public/linaro/lkft/builds/2LDxPVbsGpzKKtYLew33p...
-- Linaro LKFT https://lkft.linaro.org
On 03/02/2023 12:04, Naresh Kamboju wrote:
On Fri, 3 Feb 2023 at 15:48, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.272 release. There are 80 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.272-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Following patch caused build error on arm,
Gaosheng Cui cuigaosheng1@huawei.com memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()
drivers/memory/mvebu-devbus.c: In function 'mvebu_devbus_probe': drivers/memory/mvebu-devbus.c:297:8: error: implicit declaration of function 'devm_clk_get_enabled' [-Werror=implicit-function-declaration] 297 | clk = devm_clk_get_enabled(&pdev->dev, NULL); | ^~~~~~~~~~~~~~~~~~~~
Already reported: https://lore.kernel.org/all/202302020048.ZsmUJDHo-lkp@intel.com/
Best regards, Krzysztof
On 2/3/23 04:28, Krzysztof Kozlowski wrote:
On 03/02/2023 12:04, Naresh Kamboju wrote:
On Fri, 3 Feb 2023 at 15:48, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.272 release. There are 80 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.272-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Following patch caused build error on arm,
Gaosheng Cui cuigaosheng1@huawei.com memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()
drivers/memory/mvebu-devbus.c: In function 'mvebu_devbus_probe': drivers/memory/mvebu-devbus.c:297:8: error: implicit declaration of function 'devm_clk_get_enabled' [-Werror=implicit-function-declaration] 297 | clk = devm_clk_get_enabled(&pdev->dev, NULL); | ^~~~~~~~~~~~~~~~~~~~
Already reported: https://lore.kernel.org/all/202302020048.ZsmUJDHo-lkp@intel.com/
I don't usually check if release candidate reports have been reported already. If I know about it, I may add a reference to the report, but typically I still report it.
Personally I find it discouraging to get those "already reported" e-mails. To me it sounds like "hey, you didn't do your job properly". It should not matter if a problem was already reported or not, and I find it valuable if it is reported multiple times because it gives an indication of the level of test coverage. I would find it better if people would use something like "Also reported:" instead. But then maybe I am just oversensitive, who knows.
Anyway, yes, I noticed this problem as well (and probably overlooked it in my previous report to Greg - sorry for that).
Thanks, Guenter
On 03/02/2023 16:51, Guenter Roeck wrote:
On 2/3/23 04:28, Krzysztof Kozlowski wrote:
On 03/02/2023 12:04, Naresh Kamboju wrote:
On Fri, 3 Feb 2023 at 15:48, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.272 release. There are 80 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.272-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Following patch caused build error on arm,
Gaosheng Cui cuigaosheng1@huawei.com memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()
drivers/memory/mvebu-devbus.c: In function 'mvebu_devbus_probe': drivers/memory/mvebu-devbus.c:297:8: error: implicit declaration of function 'devm_clk_get_enabled' [-Werror=implicit-function-declaration] 297 | clk = devm_clk_get_enabled(&pdev->dev, NULL); | ^~~~~~~~~~~~~~~~~~~~
Already reported: https://lore.kernel.org/all/202302020048.ZsmUJDHo-lkp@intel.com/
I don't usually check if release candidate reports have been reported already. If I know about it, I may add a reference to the report, but typically I still report it.
Personally I find it discouraging to get those "already reported" e-mails. To me it sounds like "hey, you didn't do your job properly". It should not matter if a problem was already reported or not, and I find it valuable if it is reported multiple times because it gives an indication of the level of test coverage. I would find it better if people would use something like "Also reported:" instead. But then maybe I am just oversensitive, who knows.
Anyway, yes, I noticed this problem as well (and probably overlooked it in my previous report to Greg - sorry for that).
Let me rephrase it then:
This topic is already discussed here: https://lore.kernel.org/all/202302020048.ZsmUJDHo-lkp@intel.com/
I proposed to drop both broken backports - mvebu-devbus and atmel-sdramc, because they require new features in common clock framework API.
Best regards, Krzysztof
On Fri, Feb 03, 2023 at 05:56:17PM +0100, Krzysztof Kozlowski wrote:
On 03/02/2023 16:51, Guenter Roeck wrote:
On 2/3/23 04:28, Krzysztof Kozlowski wrote:
On 03/02/2023 12:04, Naresh Kamboju wrote:
On Fri, 3 Feb 2023 at 15:48, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.272 release. There are 80 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.272-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Following patch caused build error on arm,
Gaosheng Cui cuigaosheng1@huawei.com memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()
drivers/memory/mvebu-devbus.c: In function 'mvebu_devbus_probe': drivers/memory/mvebu-devbus.c:297:8: error: implicit declaration of function 'devm_clk_get_enabled' [-Werror=implicit-function-declaration] 297 | clk = devm_clk_get_enabled(&pdev->dev, NULL); | ^~~~~~~~~~~~~~~~~~~~
Already reported: https://lore.kernel.org/all/202302020048.ZsmUJDHo-lkp@intel.com/
I don't usually check if release candidate reports have been reported already. If I know about it, I may add a reference to the report, but typically I still report it.
Personally I find it discouraging to get those "already reported" e-mails. To me it sounds like "hey, you didn't do your job properly". It should not matter if a problem was already reported or not, and I find it valuable if it is reported multiple times because it gives an indication of the level of test coverage. I would find it better if people would use something like "Also reported:" instead. But then maybe I am just oversensitive, who knows.
Anyway, yes, I noticed this problem as well (and probably overlooked it in my previous report to Greg - sorry for that).
Let me rephrase it then:
This topic is already discussed here: https://lore.kernel.org/all/202302020048.ZsmUJDHo-lkp@intel.com/
I proposed to drop both broken backports - mvebu-devbus and atmel-sdramc, because they require new features in common clock framework API.
Ah, I totally missed that, again, seeing the good in the mess of the 0-day reports here is hard and not obvious at all. I ignored that and hence the problem was here. I've dropped the offending commit now.
thanks,
greg k-h
On Fri, Feb 03, 2023 at 01:28:59PM +0100, Krzysztof Kozlowski wrote:
On 03/02/2023 12:04, Naresh Kamboju wrote:
On Fri, 3 Feb 2023 at 15:48, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.272 release. There are 80 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.272-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Following patch caused build error on arm,
Gaosheng Cui cuigaosheng1@huawei.com memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()
drivers/memory/mvebu-devbus.c: In function 'mvebu_devbus_probe': drivers/memory/mvebu-devbus.c:297:8: error: implicit declaration of function 'devm_clk_get_enabled' [-Werror=implicit-function-declaration] 297 | clk = devm_clk_get_enabled(&pdev->dev, NULL); | ^~~~~~~~~~~~~~~~~~~~
Already reported: https://lore.kernel.org/all/202302020048.ZsmUJDHo-lkp@intel.com/
I barely look at 0-day reports about the stable stuff as there is just too much noise with it, and loads of false problems reported.
So this is a valid report, thanks!
greg k-h
On Fri, Feb 03, 2023 at 04:34:40PM +0530, Naresh Kamboju wrote:
On Fri, 3 Feb 2023 at 15:48, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.272 release. There are 80 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.272-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Following patch caused build error on arm,
Gaosheng Cui cuigaosheng1@huawei.com memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()
drivers/memory/mvebu-devbus.c: In function 'mvebu_devbus_probe': drivers/memory/mvebu-devbus.c:297:8: error: implicit declaration of function 'devm_clk_get_enabled' [-Werror=implicit-function-declaration] 297 | clk = devm_clk_get_enabled(&pdev->dev, NULL); | ^~~~~~~~~~~~~~~~~~~~ drivers/memory/mvebu-devbus.c:297:6: warning: assignment to 'struct clk *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 297 | clk = devm_clk_get_enabled(&pdev->dev, NULL); | ^ cc1: some warnings being treated as errors
Reported-by: Linux Kernel Functional Testing lkft@linaro.org
Build link, https://storage.tuxsuite.com/public/linaro/lkft/builds/2LDxPVbsGpzKKtYLew33p...
Ick, sorry about that, I'll go drop the offending patch now and push out a -rc2.
thanks,
greg k-h
On Fri, Feb 03, 2023 at 05:50:49PM +0100, Greg Kroah-Hartman wrote:
On Fri, Feb 03, 2023 at 04:34:40PM +0530, Naresh Kamboju wrote:
On Fri, 3 Feb 2023 at 15:48, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.272 release. There are 80 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.272-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Following patch caused build error on arm,
Gaosheng Cui cuigaosheng1@huawei.com memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()
drivers/memory/mvebu-devbus.c: In function 'mvebu_devbus_probe': drivers/memory/mvebu-devbus.c:297:8: error: implicit declaration of function 'devm_clk_get_enabled' [-Werror=implicit-function-declaration] 297 | clk = devm_clk_get_enabled(&pdev->dev, NULL); | ^~~~~~~~~~~~~~~~~~~~ drivers/memory/mvebu-devbus.c:297:6: warning: assignment to 'struct clk *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 297 | clk = devm_clk_get_enabled(&pdev->dev, NULL); | ^ cc1: some warnings being treated as errors
Reported-by: Linux Kernel Functional Testing lkft@linaro.org
Build link, https://storage.tuxsuite.com/public/linaro/lkft/builds/2LDxPVbsGpzKKtYLew33p...
Ick, sorry about that, I'll go drop the offending patch now and push out a -rc2.
Wait a minute, you have more issues to fix.
Guenter
On 2/3/23 03:11, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 4.19.272 release. There are 80 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sun, 05 Feb 2023 10:09:58 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.272-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan skhan@linuxfoundation.org
thanks, -- Shuah